profile
viewpoint
Johannes Würbach johanneswuerbach @contentful Berlin, Germany http://johanneswuerbach.net

jfirebaugh/konacha 1071

Test your Rails application's JavaScript with the mocha test framework and chai assertion library

bermi/sauce-connect-launcher 67

Downloads and launches an instance of Sauce Connect Selenium Proxy https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy

contentful-labs/terraform-contentful 12

Terraform provider for Contentful

johanneswuerbach/ci-cache 12

Cache files in an ephemeral continuous integration environment

johanneswuerbach/aws-secrets-manager-k8s 6

Sync AWS Secrets Manager secrets into a Kubernetes cluster.

johanneswuerbach/1password-mv-documents 0

Move documents between 1password vaults

johanneswuerbach/actionpack-action_caching 0

Action caching for Action Pack (removed from core in Rails 4.0)

johanneswuerbach/actions-on-google-nodejs 0

Client library for Actions on Google using Node.js

johanneswuerbach/activerecord-tableless 0

Bringing together the different tableless model implementations into a single gem/plugin

johanneswuerbach/active_model_serializers 0

ActiveModel::Serializer implementation and Rails hooks

issue commentDirectXMan12/k8s-prometheus-adapter

"http2: stream closed" and panic in k8s-prometheus-adapter

Maybe this is related to https://github.com/kubernetes/kubernetes/pull/82146, which has been released in 1.16?

oboguev

comment created time in 7 hours

push eventjohanneswuerbach/kube-prometheus

Lili Cosic

commit sha d9d3139dc8888516d2e543a200a802b535d6e57f

jsonnet: Drop exact metrics

view details

Lili Cosic

commit sha 6a3d667d3e306aaeeddf7a5461e344203cd3788f

manifests: Regenerate files

view details

Frederic Branczyk

commit sha 54c0fda307bde82b40f3d2de886d30df1196106b

Merge pull request #378 from LiliC/drop-less jsonnet,manifests: Do not drop not all metrics

view details

omerlh

commit sha f517b35a42ced4cdec19a5c9dfb24cf9f753c6e4

added patch to allow prom to watch all namespaces

view details

Krasi Georgiev

commit sha 44f3c610103b0c4cff51fc42018279d66c22dad2

remove some unused collectors Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com>

view details

Thibault Le Reste

commit sha 0608c96bf69e11fc7ccda256cddbe0cfedd497dd

bump kube-state-metrics to version 1.9.2

view details

Lili Cosic

commit sha 72ae778bfc122e013b09d391a40e7156a8d7ccde

Merge pull request #382 from tlereste/update_kube_state_metrics bump kube-state-metrics to version 1.9.2

view details

Frederic Branczyk

commit sha 9ebe632d5d18f32cfd5d8dc9bd2d32dd5131b2a5

Merge pull request #380 from omerlh/prom-all-namespaces added patch to allow prom to watch all namespaces

view details

Sergiusz Urbaniak

commit sha 7165938b39e437e2a32dacb8862d4465aea72ce8

prometheus-adapter: add nodes resource to aggregated-metrics-reader

view details

Sergiusz Urbaniak

commit sha 90e5982de49138ba501628f2fcd47a5c6d9069f3

manifests: regenerate

view details

Frederic Branczyk

commit sha 269aef6e378bf0c5b0570d5af76793e6020fa492

Merge pull request #384 from s-urbaniak/agg prometheus-adapter: add nodes resource to aggregated-metrics-reader

view details

paulfantom

commit sha d074ea1427bcf476829c2ffc40895e5cd8ada983

bump kubernetes-mixins dependency

view details

paulfantom

commit sha 894069f24da9704ec29667b83def68ae31c7fe31

manifests: regenerate

view details

Frederic Branczyk

commit sha e410043b6bd5cd0e319fe589d357c60938551d2d

Merge pull request #386 from paulfantom/bump_kube-mix Bump kubernetes-mixins

view details

Frederic Branczyk

commit sha 48d95f0b9fc9f0ed57dbd622b1a3c3173769f69c

*: Throw away unused high cardinality apiserver duration buckets

view details

Krasi Georgiev

commit sha 8984606f5de4708fc6fbde502b75190583e12620

re-added most collectors Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com>

view details

Frederic Branczyk

commit sha a7628e0223c501bf1ecb8466b8f9d0eba47c5dec

Merge pull request #381 from krasi-georgiev/remove-collectors remove some unused collectors

view details

Frederic Branczyk

commit sha f2b4528b637e60533f5b9467454f8a74254d15c7

Merge pull request #387 from brancz/reduce-histogram-buckets *: Throw away unused high cardinality apiserver duration buckets

view details

Frederic Branczyk

commit sha 23344a39eb3f7a598d395e9185ca597cd4a60b1d

*: Add some simple default inhibition rules

view details

Frederic Branczyk

commit sha 3277200fc528c0abc07e39c1f84f0ccee7ad1b9d

Merge pull request #391 from brancz/default-inhibit-rules *: Add some simple default inhibition rules

view details

push time in 2 days

startedcontentful/apps

started time in 2 days

Pull request review commentkubernetes/kops

Support S3 Virtual Hosted Style

 var ( 	// https://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region 	// TODO: perhaps make region regex more specific, i.e. (us|eu|ap|cn|ca|sa), to prevent matching bucket names that match region format? 	//       but that will mean updating this list when AWS introduces new regions-	s3UrlRegexp = regexp.MustCompile(`s3([-.](?P<region>\w{2}-\w+-\d{1})|[-.](?P<bucket>[\w.\-\_]+)|)?.amazonaws.com(.cn)?(?P<path>.*)?`)+	s3UrlRegexp = regexp.MustCompile(`(s3([-.](?P<region>\w{2}-\w+-\d{1})|[-.](?P<bucket>[\w.\-\_]+)|)?|(?P<bucket>[\w\-\_]+).s3.(?P<region>\w{2}-\w+-\d{1})).amazonaws.com(.cn)?(?P<path>.*)?`)

Having a dot in the bucket name causes https connection to fail:

https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html#bucketnamingrules

When you use virtual hosted–style buckets with Secure Sockets Layer (SSL), the SSL wildcard certificate only matches buckets that don't contain periods. To work around this, use HTTP or write your own certificate verification logic. We recommend that you do not use periods (".") in bucket names when using virtual hosted–style buckets.

While mirroring assets should work (as kops uses an aws sdk s3 client), the user data script is likely to fail as kops tries to fetch assets from https://bucket

johanneswuerbach

comment created time in 6 days

PR opened kubernetes/kops

Support S3 Virtual Hosted Style

Support S3 URLs written in Virtual Hosted Style, which seems to be only recommended notation nowadays, but isn't supported in kops.

https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingBucket.html#virtual-host-style-url-ex

All the other options are more or less deprecated https://docs.aws.amazon.com/AmazonS3/latest/dev/VirtualHosting.html#VirtualHostingBackwardsCompatibility

+9 -2

0 comment

2 changed files

pr created time in 8 days

create barnchjohanneswuerbach/kops

branch : s3-virtual-host

created branch time in 8 days

push eventjohanneswuerbach/kops

Xiaoyu Zhong

commit sha a727916f4a358331667303358ab4657978757f54

Alicloud: fix diff failures for SecurityGroupRule

view details

Xiaoyu Zhong

commit sha ded111c8b753818ab27a4833b473214c66c0a98f

Alicloud: fix comparison failures SSHKey

view details

Ciprian Hacman

commit sha 10b7d1e7b5498518c3bbd339769314eb8dd67811

Don't consider recommended packages as a dependency for installing

view details

John Gardiner Myers

commit sha eaa13e734dda0dd39bf6c166b4d691255d6edd36

Fix truncation of admission control plugins list

view details

Kubernetes Prow Robot

commit sha 32cf01f20ce3bbcb7c2e9364d4d4646b139ebb83

Merge pull request #8028 from bittopaz/ali-patch-10 Alicloud: fix comparison failures for SecurityGroupRule and SSHKey

view details

Kubernetes Prow Robot

commit sha d72d047c87bd45ccb69473cf8e52659d0dade055

Merge pull request #8026 from bittopaz/ali-patch-8 Alicloud: add Encrypted field in Disk Find func

view details

Kubernetes Prow Robot

commit sha 32682a57fb05ddd5932ae3518be780356ee2c3bb

Merge pull request #8010 from joshbranham/add-jb-reviewer Add joshbranham to OWNERs as reviewer

view details

Derek Heldt-Werle

commit sha 6b7a882b5953200a600f5ab9629bad53a37820d0

Adds support for additional leader-elect flags for use by either the kube-scheduler or kube-controller-manager Signed-off-by: Derek Heldt-Werle <derek.heldt-werle@viasat.com>

view details

Derek Heldt-Werle

commit sha 424ef85a2a7f230958bf8cc3438136dfd442c298

Generated files related to leader-elect flags Signed-off-by: Derek Heldt-Werle <derek.heldt-werle@viasat.com>

view details

tanjunchen

commit sha 977f987d655c4674548cc09fb7265ab37786cd78

fix-pkg-staticcheck and remove the repeat code

view details

Gabriel Tiossi

commit sha 9364da6d4f28c358c41501ae5d6160639353489e

feat(api): DeleteOnTermination fields for volumes Support RootVolumeDeleteOnTermination and DeleteOnTermination fields to enable a deeper customization

view details

Gabriel Tiossi

commit sha ad2b315c4eb86f1d56273c9cef406428033d9da3

feat(awstasks): Support EBS DeleteOnTermination Change BDM behavior when finding Launch Configuration and generating Cloudformation/Terraform

view details

Gabriel Tiossi

commit sha 3b902262f79bb1d41a93476e14b461f81c6f3fe5

feat(awsmodel): Logic for EBS DeleteOnTermination Implement separated logics for root volume and additional volumes

view details

Kubernetes Prow Robot

commit sha 8fead73173f9187d535d1c984524cd947ab35f31

Merge pull request #7406 from gjtempleton/Capacity-Optimized-Spot-Strategy Add CapacityOptimized to list of supported spot allocation strategies

view details

Ryan Bonham

commit sha 9a127347f2a2f51dabbd2f54182de1fb81aa0ce8

Fix Handling of LaunchTemplate Versions for MixedInstancePolicy

view details

Kubernetes Prow Robot

commit sha d551191c2ce0bfeee4eaf70aec52f434c86daf80

Merge pull request #8027 from bittopaz/ali-patch-9 Alicloud: fix comparison failures for VPC and NATGateway

view details

Kubernetes Prow Robot

commit sha c60a0e04109b4f26abfb8cb1a26606c350227d90

Merge pull request #8030 from bittopaz/ali-patch-11 Alicloud: use Balance as MultiAZPolicy

view details

Kubernetes Prow Robot

commit sha 33ed6315b6040710373ae8e2ce902f0d59cee21f

Merge pull request #7600 from uruddarraju/ng Allow users to set kube controller manager's concurrent sync flags.

view details

Kubernetes Prow Robot

commit sha 094fe2a645370890eaae3080cdb4dd6d6a112edd

Merge pull request #7925 from johngmyers/optimize-validation Pass the cloud object to validator from caller

view details

John Gardiner Myers

commit sha 0c36cff1415016fa1b8fe4a10b37f65f70b48b42

Vendor github.com/stretchr/testify/require

view details

push time in 8 days

delete branch johanneswuerbach/jaeger

delete branch : bump-gocql

delete time in 12 days

push eventjohanneswuerbach/jaeger

Johannes Würbach

commit sha 59c9f901dd9dbc1bc7980edfa856f5611a9c21cc

Update gocql to support AWS MCS Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 13 days

PR opened jaegertracing/jaeger

Update gocql to support AWS MCS

I'm looking into using Jaeger together with Amazon Managed Apache Cassandra Service (MCS) and the first issue I found is not recent enough gocql https://github.com/gocql/gocql/issues/1389#issuecomment-597200469

This bumps gocql to the latest master, which includes https://github.com/gocql/gocql/commit/cd4b606dd2fb8920e814a86b2901d062daf388a8

+3 -1

0 comment

2 changed files

pr created time in 13 days

create barnchjohanneswuerbach/jaeger

branch : bump-gocql

created branch time in 13 days

fork johanneswuerbach/jaeger

CNCF Jaeger, a Distributed Tracing Platform

https://jaegertracing.io/

fork in 13 days

push eventjohanneswuerbach/nfsexports

Tom

commit sha efaa08993f44c8ee519cde9b9c26b17afe60fb9a

Fix spelling of 'nfsd' in error

view details

Johannes Würbach

commit sha c48c3734757f0600c9bc292a02d64c5243d4389c

Merge pull request #7 from tommyp1ckles/fix-spelling Fix spelling of 'nfsd' in error

view details

push time in 14 days

Pull request review commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

 static int makeTracerFactory(const char* opentracingVersion,         return opentracing::incompatible_library_versions_error.value();     } -    *tracerFactory = new (std::nothrow) jaegertracing::TracerFactory{};+    const auto jaegerTracerFactory = new (std::nothrow) jaegertracing::TracerFactory(true);

It was originally implemented like that, but @mdouaihy recommended the ctor approach https://github.com/jaegertracing/jaeger-client-cpp/pull/192#issuecomment-570489433

I don’t have an opinion and happily change it to your preference

johanneswuerbach

comment created time in a month

pull request commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

@mdouaihy thanks for the pointers, all leaks addressed.

johanneswuerbach

comment created time in a month

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 43075a2c234c105130239842836ea90cfabe7ed6

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in a month

pull request commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

Sorry for the delay @mdouaihy, I rebased this PR, but are not sure about your suggestions.

Instead, we can define it in TracerFactory::MakeTracer when readFromEnv is defined.

I'm not sure what this means? In this PR I actually prefer the environment variable values now over the config values as fromEnv already defines some kind of a deep merge. What do you think about that?

johanneswuerbach

comment created time in a month

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha dc583ad358183ffcaa595822025c9358bb7295c5

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in a month

push eventjohanneswuerbach/jaeger-client-cpp

Patrick Vollebregt

commit sha 0e05450736a223a7ce91436c1f9b81ff5d535cfa

Fix typo in README.md (#194) Fixed typo in example configurations: repoter -> reporter Signed-off-by: Patrick Vollebregt <patrick@crosscode.nl>

view details

Yuri Shkuro

commit sha 49568d428b45de60a9820ea3a027a8c6da801e10

Fix sampling endpoint URL Resolves #201

view details

Emmanuel Courreges

commit sha 9e1b39ca9f4f57d7666783cfc7f9b6f97cbce3bf

Fix loading of sampling endpoint address from JAEGER_SAMPLING_ENDPOINT environment variable (#200) * fix configuration from environment variables fix conversion to double of JAEGER_SAMPLER_PARAM rename env var JAEGER_SAMPLER_MANAGER_HOST_PORT to JAEGER_SAMPLER_SERVER_URL properly load JAEGER_SAMPLER_SERVER_URL Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com> * proper unit testing of RemotelyControlledSampler Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com> * include /sampling in all samplingServerURL examples to avoid confusion / or /whatever does not work for this driver: the agent answers slightly differently with a numerical strategyType Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com> * rename JAEGER_SAMPLER_MANAGER_HOST_PORT into JAEGER_SAMPLING_ENDPOINT as per https://github.com/jaegertracing/jaeger/issues/1971#issuecomment-570075734 Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com>

view details

Mehrez DOUAIHY

commit sha 6f288238395ac002f6d671fe10b3ca2516159ebb

Update OpenTracing to 1.6.0 (#209) Use GTest @1.8.0 because the latest version seems to have a problem with rpath. Signed-off-by: Mehrez DOUAIHY <mehrez.douaihy@gmail.com>

view details

Alek86

commit sha 2bce8db5a85e73b32bded95316b7ba0bde9fa625

An extension of enum opentracing::SpanReferenceType, for a new Span. (#206) * An extension of enum opentracing::SpanReferenceType, for a new Span. Only to copy traceID and (for non-root spans) spanID, because spanID for root spans == traceID.low() Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * 1) Renamed useTheseIDs to SelfRef, for consistency between different lang implementations of Jaeger client 2) SpanId is always taken from the SelfRef context Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Seems like on some compilers jaegertracing::SpanContext::StrMap(initializer_list) is explicit Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Temporarily commented out the new unit test case body Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * SelfRef only used for creating root spans and can be passed as the only reference to enforce this rule Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Apparently std::exception ctor with a const char* is not standard Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Updates in README and code comments as per reviewer's request Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Added a testTracer subtest with no selfref to check the github CI result Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Removed test changes Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Added 2 unittests - a simple span child and a simple self ref Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Added child span to selfref unittest, small changes in new tests Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Show better log if sef ref is used with other references Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Change in error log if selfref is used with another ref Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com>

view details

Johannes Würbach

commit sha 363dc6e09e09785b90a32c442c76d60f730ce235

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in a month

push eventjohanneswuerbach/jaeger-client-cpp

Patrick Vollebregt

commit sha 0e05450736a223a7ce91436c1f9b81ff5d535cfa

Fix typo in README.md (#194) Fixed typo in example configurations: repoter -> reporter Signed-off-by: Patrick Vollebregt <patrick@crosscode.nl>

view details

Yuri Shkuro

commit sha 49568d428b45de60a9820ea3a027a8c6da801e10

Fix sampling endpoint URL Resolves #201

view details

Emmanuel Courreges

commit sha 9e1b39ca9f4f57d7666783cfc7f9b6f97cbce3bf

Fix loading of sampling endpoint address from JAEGER_SAMPLING_ENDPOINT environment variable (#200) * fix configuration from environment variables fix conversion to double of JAEGER_SAMPLER_PARAM rename env var JAEGER_SAMPLER_MANAGER_HOST_PORT to JAEGER_SAMPLER_SERVER_URL properly load JAEGER_SAMPLER_SERVER_URL Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com> * proper unit testing of RemotelyControlledSampler Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com> * include /sampling in all samplingServerURL examples to avoid confusion / or /whatever does not work for this driver: the agent answers slightly differently with a numerical strategyType Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com> * rename JAEGER_SAMPLER_MANAGER_HOST_PORT into JAEGER_SAMPLING_ENDPOINT as per https://github.com/jaegertracing/jaeger/issues/1971#issuecomment-570075734 Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com>

view details

Mehrez DOUAIHY

commit sha 6f288238395ac002f6d671fe10b3ca2516159ebb

Update OpenTracing to 1.6.0 (#209) Use GTest @1.8.0 because the latest version seems to have a problem with rpath. Signed-off-by: Mehrez DOUAIHY <mehrez.douaihy@gmail.com>

view details

Alek86

commit sha 2bce8db5a85e73b32bded95316b7ba0bde9fa625

An extension of enum opentracing::SpanReferenceType, for a new Span. (#206) * An extension of enum opentracing::SpanReferenceType, for a new Span. Only to copy traceID and (for non-root spans) spanID, because spanID for root spans == traceID.low() Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * 1) Renamed useTheseIDs to SelfRef, for consistency between different lang implementations of Jaeger client 2) SpanId is always taken from the SelfRef context Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Seems like on some compilers jaegertracing::SpanContext::StrMap(initializer_list) is explicit Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Temporarily commented out the new unit test case body Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * SelfRef only used for creating root spans and can be passed as the only reference to enforce this rule Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Apparently std::exception ctor with a const char* is not standard Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Updates in README and code comments as per reviewer's request Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Added a testTracer subtest with no selfref to check the github CI result Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Removed test changes Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Added 2 unittests - a simple span child and a simple self ref Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Added child span to selfref unittest, small changes in new tests Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Show better log if sef ref is used with other references Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com> * Change in error log if selfref is used with another ref Signed-off-by: Oleksandr Bukaiev <bukaevav@gmail.com>

view details

push time in a month

push eventjohanneswuerbach/dynamodb-stream-enumerator

dependabot[bot]

commit sha 3fd4d1e22e6d246689e67a576ce05aef2330eb29

Update rake requirement from ~> 10.0 to ~> 13.0 Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](https://github.com/ruby/rake/compare/v10.5.0...v13.0.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Johannes Würbach

commit sha 02bd2f5bfc5d6514d7a4ac1ed7541e9df43b8293

Merge pull request #1 from johanneswuerbach/dependabot/bundler/rake-tw-13.0 Update rake requirement from ~> 10.0 to ~> 13.0

view details

push time in a month

PR merged johanneswuerbach/dynamodb-stream-enumerator

Update rake requirement from ~> 10.0 to ~> 13.0 dependencies

Updates the requirements on rake to permit the latest version. <details> <summary>Changelog</summary>

Sourced from rake's changelog.

=== 13.0.1

==== Bug fixes

  • Fixed bug: Reenabled task raises previous exception on second invokation Pull Request #271 by thorsteneckel
  • Fix an incorrectly resolved arg pattern Pull Request #327 by mjbellantoni

=== 13.0.0

==== Enhancements

  • Follows recent changes on keyword arguments in ruby 2.7. Pull Request #326 by nobu
  • Make PackageTask be able to omit parent directory while packing files Pull Request #310 by tonytonyjan
  • Add order only dependency Pull Request #269 by take-cheeze

==== Compatibility changes

  • Drop old ruby versions(< 2.2)

=== 12.3.3

==== Bug fixes

  • Use the application's name in error message if a task is not found. Pull Request #303 by tmatilai

==== Enhancements:

  • Use File.open explicitly.

=== 12.3.2

==== Bug fixes

  • Fixed test fails caused by 2.6 warnings. Pull Request #297 by hsbt

==== Enhancements:

  • Rdoc improvements. Pull Request #293 by colby-swandale
  • Improve multitask performance. Pull Request #273 by jsm
  • Add alias prereqs. Pull Request #268 by take-cheeze </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • c8251e2 Bump version to 13.0.1
  • 8edd860 Fixed build failure of the latest GitHub Actions
  • b6e2a66 Merge pull request #271 from thorsteneckel/bugfix-reenable_invocation_exception
  • 985abff Merge pull request #327 from mjbellantoni/mjb-order-only-arg-fix
  • 4a90acb Merge pull request #329 from jeremyevans/skip-taint-test-on-2.7
  • 4dc6282 Skip a taint test on Ruby 2.7
  • a08b697 Merge pull request #328 from orien/gem-metadata
  • c3953d4 Add project metadata to the gemspec
  • 46a8f7c Update comments to reflect the current state
  • 00aacdc Fix an incorrectly resolved arg pattern
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

2 changed files

dependabot[bot]

pr closed time in a month

issue commentnodejs/node

Significant map/reduce performance regression in node 12

I’m not familiar with the v8 code base, but the issue you opened references https://chromium-review.googlesource.com/c/1529006 as the culprit and I guess we could go from the history after this or by reverting the change or is this thinking too simple?

kbjr

comment created time in a month

issue commentnodejs/node

Significant map/reduce performance regression in node 12

@targos sorry for the ping, but I couldn't find any meeting notes or other kind of documentation whether v8 7.9 is planned to be back-ported to v12? https://github.com/nodejs/node/pull/30020 has a backport-requested-v12.x label, but no comments whether this is still planned.

Could you provide some insights?

kbjr

comment created time in a month

issue commentnodejs/node

Significant map/reduce performance regression in node 12

Tested with v12.16.0 which ships with V8 7.8, but performance is still not fixed.

Using the script from https://github.com/nodejs/node/issues/27930#issuecomment-496353854

$ nvm use 10
Now using node v10.18.1 (npm v6.13.4)
$ node bench.js
Creating test data
Running test
Done. Duration: 4805ms
$ nvm use v12.15.0
Now using node v12.15.0 (npm v6.13.4)
$ node bench.js
Creating test data
Running test
Done. Duration: 73486ms
$ nvm use v12.16.0
Now using node v12.16.0 (npm v6.13.4)
$ node bench.js
Creating test data
Running test
Done. Duration: 73772ms
kbjr

comment created time in 2 months

pull request commentcoreos/kube-prometheus

WIP: Graduate custom-metrics

How would you feel about making this an opt-in patch instead so it easier for users to keep up-to-date and use it together with kube-prometheus jsonnet?

johanneswuerbach

comment created time in 2 months

pull request commentkubernetes-sigs/external-dns

Add --watchers flag to allow controller to respond automatically to Ingress or Service updates

Sorry for the nudge @SEJeff / @njuettner , but we are also really looking forward to see this merged.

jlamillan

comment created time in 3 months

pull request commentcoreos/kube-prometheus

WIP: Graduate custom-metrics

I share the same assertion that prometheus-adapter is not production ready yet regarding custom and external metrics.

Do you have further details on what is currently missing / a list of open items? Are they affecting both custom/external metrics or just one of them?

johanneswuerbach

comment created time in 3 months

PR opened coreos/kube-prometheus

WIP: Graduate custom-metrics

Instead of keeping the custom-metrics-api separate and experimental https://github.com/coreos/kube-prometheus/tree/master/experimental/custom-metrics-api, move it into jsonnet and use the same already deployed k8s-prometheus-adapter. The adapter supports custom-metrics (and also external-metrics) for awhile now and we are using it in production without issues.

What do you think?

I'm happy to re-generate the manifests if this looks reasonable.

+48 -253

0 comment

11 changed files

pr created time in 3 months

push eventjohanneswuerbach/kube-prometheus

Johannes Würbach

commit sha 624279336387152389f72e36ba262c364200dcaf

WIP: Graduate custom-metrics

view details

push time in 3 months

create barnchjohanneswuerbach/kube-prometheus

branch : custom-metrics

created branch time in 3 months

fork johanneswuerbach/kube-prometheus

Use Prometheus to monitor Kubernetes and applications running on Kubernetes

fork in 3 months

push eventjohanneswuerbach/1password-mv-documents

Johannes Würbach

commit sha bb1b3c3a91f7e53893307308fa6c4e71a851e5c5

Add license

view details

push time in 3 months

push eventjohanneswuerbach/1password-mv-documents

Johannes Würbach

commit sha 57cd43763fd4d12f93b7f42cf10ddd9eb1e12b5c

Initial implementation

view details

push time in 3 months

create barnchjohanneswuerbach/1password-mv-documents

branch : master

created branch time in 3 months

created repositoryjohanneswuerbach/1password-mv-documents

Move documents between 1password vaults

created time in 3 months

issue commentbrianc/node-postgres

Anything else to add?

I would really like to see something like https://github.com/brianc/node-pg-pool/pull/119 included as we historically had a lot of bugs with accidentally re-adding broken clients to the pool just to get random errors later. The client is already aware of the client state so that could be prevented by default with probably some warning logged.

brianc

comment created time in 3 months

pull request commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

@mdouaihy is something like https://github.com/jaegertracing/jaeger-client-cpp/pull/192/commits/e0fd88273d5b5b660944c3dadbb1fdc2821ffa7c what you had in mind?

It looks like environment variable now take always precedent over the file, is that desired or should I add checks to https://github.com/jaegertracing/jaeger-client-cpp/blob/master/src/jaegertracing/Config.cpp#L37 to validate they are only used when nothing is configured yet? The downside is obviously that this would change behaviour of the current, but unreleased Config::fromEnv().

johanneswuerbach

comment created time in 3 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha e0fd88273d5b5b660944c3dadbb1fdc2821ffa7c

fixup! Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 3 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 485352526790fe4aabfbd4bb567690a7dfc61feb

fixup! Support plugin configuration via environment variables

view details

push time in 3 months

pull request commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

@mdouaihy, the TracerFactory implements opentracing::TracerFactory so if I understand correctly adding an additional argument wouldn’t be easily possible. https://github.com/opentracing/opentracing-cpp/blob/4bb431f7728eaf383a07e86f9754a5b67575dab0/include/opentracing/tracer_factory.h#L50-L51

If I understand https://github.com/opentracing/opentracing-cpp/pull/45#issue-159318348 correctly the factory seems also be mainly used for dynamic loading, so I'm not sure modifying only dynamic load would be sufficient?

johanneswuerbach

comment created time in 3 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha e1c855537ea9d25189b1b739a4377b41c67bff09

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 3 months

startedkubernetes-sigs/kind

started time in 3 months

startedopen-telemetry/opentelemetry-js

started time in 4 months

push eventjohanneswuerbach/snooze-github-notifications

Johannes Würbach

commit sha 278e504de819a442907e986b2b79ea54294b0f76

Switch to go mod

view details

push time in 4 months

pull request commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

Hey @mdouaihy, thanks for the feedback.

How would you imaging this injected behaviour to look like? I can't really think of a way without breaking the public interface of TracerFactory::MakeTracer or would you create a dedicated tracer initialisation only used in DynamicLoad.cpp with the TracerFactory::MakeTracer logic in this PR and just leave the existing TracerFactory::MakeTracer logic untouched ?

johanneswuerbach

comment created time in 4 months

Pull request review commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

 TEST(TracerFactory, testValidConfig)         "refreshInterval": 60     }   })";+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "");     TracerFactory tracerFactory;     std::string errorMessage;     auto tracerMaybe = tracerFactory.MakeTracer(config, errorMessage);     ASSERT_EQ(errorMessage, "");     ASSERT_TRUE(tracerMaybe); }++TEST(TracerFactory, testEnvironmentConfig)+{+    const char* config = "";+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "AService");+    TracerFactory tracerFactory;+    std::string errorMessage;+    auto tracerMaybe = tracerFactory.MakeTracer(config, errorMessage);+    ASSERT_EQ(errorMessage, "");+    ASSERT_TRUE(tracerMaybe);+}++TEST(TracerFactory, testConfigAndEnvironment)+{+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "");+    const char* config = R"(+  {+    "service_name": "test"+  })";+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "AService");+    TracerFactory tracerFactory;+    std::string errorMessage;+    auto tracerMaybe = tracerFactory.MakeTracer(config, errorMessage);+    ASSERT_EQ(errorMessage, "");+    ASSERT_TRUE(tracerMaybe);++    auto tracer = tracerMaybe.value();+    const auto jaegerTracer = std::dynamic_pointer_cast<Tracer>(tracer);

@mdouaihy I tried:

TEST(TracerFactory, testConfigAndEnvironment)
{
    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "");
    const char* config = R"(
  {
    "service_name": "test"
  })";
    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "AService");
    TracerFactory tracerFactory;
    std::string errorMessage;
    auto tracerMaybe = tracerFactory.MakeTracer(config, errorMessage);
    ASSERT_EQ(errorMessage, "");
    ASSERT_TRUE(tracerMaybe);

    const auto tracer =
        std::static_pointer_cast<jaegertracing::Tracer>(tracerMaybe.value());

    ASSERT_EQ(std::string("test"), tracer->serviceName());
}

but this segfaults. Any pointers?

johanneswuerbach

comment created time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 2c631e2f40fc634112efd31279aca5de384e5f6d

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

pull request commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

Most other jaeger clients are already configurable using environment variables https://www.jaegertracing.io/docs/1.15/client-features/ and we use JAEGER_AGENT_HOST inside kubernetes to inject the agent IP into each pod https://www.jaegertracing.io/docs/1.15/operator/#installing-the-agent-as-daemonset

While the cpp client itself allows to be configured via environment variables, we only use the plugin via https://github.com/opentracing-contrib/nginx-opentracing/blob/master/README.md.

To inject now the IP we could generate the config, or change the plugin to also respect the common environment variables. I found the second option cleaner and opened this PR.

johanneswuerbach

comment created time in 4 months

Pull request review commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

 TEST(TracerFactory, testValidConfig)         "refreshInterval": 60     }   })";+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "");     TracerFactory tracerFactory;     std::string errorMessage;     auto tracerMaybe = tracerFactory.MakeTracer(config, errorMessage);     ASSERT_EQ(errorMessage, "");     ASSERT_TRUE(tracerMaybe); }++TEST(TracerFactory, testEnvironmentConfig)+{+    const char* config = "";+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "AService");+    TracerFactory tracerFactory;+    std::string errorMessage;+    auto tracerMaybe = tracerFactory.MakeTracer(config, errorMessage);+    ASSERT_EQ(errorMessage, "");+    ASSERT_TRUE(tracerMaybe);+}++TEST(TracerFactory, testConfigAndEnvironment)+{+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "");+    const char* config = R"(+  {+    "service_name": "test"+  })";+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "AService");+    TracerFactory tracerFactory;+    std::string errorMessage;+    auto tracerMaybe = tracerFactory.MakeTracer(config, errorMessage);+    ASSERT_EQ(errorMessage, "");+    ASSERT_TRUE(tracerMaybe);++    auto tracer = tracerMaybe.value();+    const auto jaegerTracer = std::dynamic_pointer_cast<Tracer>(tracer);

@yurishkuro any hints how I could the jaeger tracer instance here instead of the opentracing::tracer?

The dynamic pointer cast seems not to work, but I don't understand why :-(

johanneswuerbach

comment created time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 510aa96cc511e12e430a8631ed99852b6dc55fc5

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 4c6fd453da2f8e58a2e532e5e307dd9744247d0e

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 86f9fcae6f2d724cb7b0a00917fd5bdc0d483b05

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 7d78e8b56f852cb397296bfe1f4352e60050d0a6

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

pull request commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

@yurishkuro sorry my C++ knowledge is really rusty, any pointers how to properly access the returned tracer instance in the last test to get the service name?

johanneswuerbach

comment created time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha ca95345618f9032e9ab7181292fbb4627593e18c

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 566393715abb58356e24cc3e9f807bc614b94554

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

Pull request review commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

 TEST(TracerFactory, testValidConfig)         "refreshInterval": 60     }   })";+    testutils::EnvVariable::setEnv("JAEGER_SERVICE_NAME", "");+    TracerFactory tracerFactory;+    std::string errorMessage;+    auto tracerMaybe = tracerFactory.MakeTracer(config, errorMessage);+    ASSERT_EQ(errorMessage, "");+    ASSERT_TRUE(tracerMaybe);+}++TEST(TracerFactory, testEnvironmentConfig)

@objectiser done

johanneswuerbach

comment created time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 788f49cf4c7a2bf99f53706796e4674f2e2b2914

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

pull request commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

@yurishkuro thanks for the feedback, I addressed your comments.

johanneswuerbach

comment created time in 4 months

Pull request review commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

+/*
+ * Copyright (c) 2017 Uber Technologies, Inc.

Updated.

johanneswuerbach

comment created time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 5ec2883855df890fdb68d560b81170617a953c4e

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

Pull request review commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

 TracerFactory::MakeTracer(const char* configuration,             opentracing::configuration_parse_error);     } -    const auto serviceNameNode = yaml["service_name"];-    if (!serviceNameNode) {+    auto tracerConfig = jaegertracing::Config::parse(yaml);++    tracerConfig.fromEnv();++    if (tracerConfig.serviceName().empty()) {         errorMessage = "`service_name` not provided";         return opentracing::make_unexpected(             opentracing::invalid_configuration_error);     }-    if (!serviceNameNode.IsScalar()) {

This was manually verifying the integrity of the yaml, which should be done by the parsing itself

johanneswuerbach

comment created time in 4 months

Pull request review commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

 TracerFactory::MakeTracer(const char* configuration,             opentracing::configuration_parse_error);     } -    const auto serviceNameNode = yaml["service_name"];-    if (!serviceNameNode) {-        errorMessage = "`service_name` not provided";-        return opentracing::make_unexpected(-            opentracing::invalid_configuration_error);-    }-    if (!serviceNameNode.IsScalar()) {-        errorMessage = "`service_name` must be a string";+    auto tracerConfig = jaegertracing::Config::parse(yaml);+#endif  // JAEGERTRACING_WITH_YAML_CPP++    tracerConfig.fromEnv();++    if (tracerConfig.serviceName().empty()) {+        errorMessage = "`service_name` not provided123";

Fixed.

johanneswuerbach

comment created time in 4 months

Pull request review commentjaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

 opentracing::expected<std::shared_ptr<opentracing::Tracer>> TracerFactory::MakeTracer(const char* configuration,                           std::string& errorMessage) const noexcept try { #ifndef JAEGERTRACING_WITH_YAML_CPP-    errorMessage =-        "Failed to construct tracer: Jaeger was not build with yaml support.";-    return opentracing::make_unexpected(-        std::make_error_code(std::errc::not_supported));+    auto tracerConfig = jaegertracing::Config();

this feels unintuitive - the configuration is silently ignored in favor of default config?

I reverted now to the old behaviour of erroring out when no config is provided as it feels out of scope of this PR to change that.

does C++ have some standard way to document functions?

I haven't done C++ in a long time so I would need on your knowledge, but looking at the other files I don't see any documentation.

johanneswuerbach

comment created time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha d01d18282b8bdc695b5818bebb5d573c674e4e6d

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

PR opened jaegertracing/jaeger-client-cpp

Support plugin configuration via environment variables

<!-- We appreciate your contribution to the Jaeger project! 👋🎉

Before creating a pull request, please make sure:

  • Your PR is solving one problem
  • You have read the guide for contributing
    • See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
  • You signed all your commits (otherwise we won't be able to merge the PR)
    • See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#sign-your-work
  • You added unit tests for the new functionality
  • You mention in the PR description which issue it is addressing, e.g. "Resolves #123" -->

Which problem is this PR solving?

Support using the environment variables added in https://github.com/jaegertracing/jaeger-client-cpp/pull/181 when using the plugin. E.g. as part of https://github.com/opentracing-contrib/nginx-opentracing/

Short description of the changes

The plugin entry point now tries to parse the yaml file and loads environment variables if they are defined. Once all configuration methods performed, validate that the service name is not empty.

+96 -36

0 comment

6 changed files

pr created time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 42e2ee27c117fd116d99e50ff055cefe9fdf8dd3

Support plugin configuration via environment variables Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>

view details

push time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha af72ef9bcd99d316932e40d329fa267741beca3b

Support plugin configuration via environment variables

view details

push time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 497df2d2d4540b0e54ca849e3a5784305bbe8a4c

test

view details

push time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha 9a0fdee59b570c9efdfb2ac4ae84bab908d98e58

Support plugin configuration via environment variables

view details

push time in 4 months

push eventjohanneswuerbach/jaeger-client-cpp

Johannes Würbach

commit sha d58c4647ab556d726bb2c2da608548ea91b07597

Support plugin configuration via environment variables

view details

push time in 4 months

create barnchjohanneswuerbach/jaeger-client-cpp

branch : plugin-from-env

created branch time in 4 months

startedopentracing-contrib/nginx-opentracing

started time in 4 months

startedaws/aws-node-termination-handler

started time in 4 months

issue openedaws/aws-node-termination-handler

Handle instance retirement events

From time to time AWS is retiring EC2 instances due to underlying hardware or software failures https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/monitoring-instances-status-check_sched.html#types-of-scheduled-events

I would be awesome if the aws-node-termination-handler could watch the instance meta data service to react automatically to those events https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/monitoring-instances-status-check_sched.html#viewing_scheduled_events and drain the affected instance.

Would this be something in scope of this project?

created time in 4 months

issue commentnodejs/node

Significant map/reduce performance regression in node 12

Is there an update on this issue? We started adopting Node 12 now that it became LTS and one of our services was hit hard by this performance regression.

Would it make sense to start removing map from our code bases or is there a chance that this is going to be fixed in a future 12 minor/patch release?

As this issue is open for a while, I fear its more the first option.

I would love to offer my help, but my C++ knowledge is rusty at best.

kbjr

comment created time in 4 months

PublicEvent

push eventjohanneswuerbach/k8s-meetup-talk-autoscaling

Johannes Würbach

commit sha b5f055880dffeddeb75747d826e8851e5c5b3eec

Use public slides url

view details

push time in 4 months

pull request commentsquaremo/amqp.node

Fix stream becoming readable again

@squaremo thank you for the support. Could you also release a new version with this fix? That would be wonderful.

johanneswuerbach

comment created time in 4 months

issue commentkubernetes-sigs/kubebuilder

kubebuilder update command broken for v2

ember-cli provides a new project diff with each release, which I found fairly helpful when updating between versions.

Example https://github.com/ember-cli/ember-cli/releases/tag/v3.14.0 > Blueprint Changes https://github.com/ember-cli/ember-new-output/compare/v3.13.2...v3.14.0

luisdavim

comment created time in 5 months

delete branch johanneswuerbach/rabbitmq-peer-discovery-k8s

delete branch : use-not-ready

delete time in 5 months

PR closed rabbitmq/rabbitmq-peer-discovery-k8s

Respect not ready addresses

Proposed Changes

We are using tooling of top of Kubernetes which respects the pod disruption budget of a StatefulSets https://kubernetes.io/docs/tasks/run-application/configure-pdb/

The problem with PDBs and the current approach of rabbitmq peer discovery is that pods are required to be ready, before joining the cluster.

Ideally we would like to change pods to be only marked as ready, once they actually joined the cluster.

To achieve that we return also the IPs of not ready nodes and rely on rabbitmq to add them to the cluster once the pod is responding.

Instead of the current recommended command: ["rabbitmq-diagnostics", "status"], would the stage 4 check command: ["rabbitmq-diagnostics", "check_port_connectivity"] be sufficient to detect a pod not yet in a cluster?

Types of Changes

What types of changes does your code introduce to this project? Put an x in the boxes that apply

  • [x] Bug fix (non-breaking change which fixes issue #NNNN)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • [ ] Documentation improvements (corrections, new content, etc)
  • [ ] Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask on the mailing list. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING.md document
  • [x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • [x] All tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

+18 -17

3 comments

2 changed files

johanneswuerbach

pr closed time in 5 months

pull request commentrabbitmq/rabbitmq-peer-discovery-k8s

Respect not ready addresses

Scratch that, there was a misunderstanding.

johanneswuerbach

comment created time in 5 months

push eventjohanneswuerbach/rabbitmq-peer-discovery-k8s

Johannes Würbach

commit sha 464092393d32893051c9879afe73af5a7b82584b

Use not ready addresses

view details

push time in 5 months

push eventjohanneswuerbach/rabbitmq-peer-discovery-k8s

Johannes Würbach

commit sha 8ff915f73cd90ac9d58fa4dc5817a5d5e4696e57

Use not ready addresses

view details

push time in 5 months

push eventjohanneswuerbach/rabbitmq-peer-discovery-k8s

Johannes Würbach

commit sha 0d5dc81c6ab1982fba4b3c879bc69ae6ee602169

Use not ready addresses

view details

push time in 5 months

PR opened rabbitmq/rabbitmq-peer-discovery-k8s

Respect not ready addresses

Proposed Changes

We are using tooling of top of Kubernetes which respects the pod disruption budget of a StatefulSets https://kubernetes.io/docs/tasks/run-application/configure-pdb/

The problem with PDBs and the current approach of rabbitmq peer discovery is that pods are required to be ready, before joining the cluster.

Ideally we would like to change pods to be only marked as ready, once they actually joined the cluster.

To achieve that we return also the IPs of not ready nodes and rely on rabbitmq to add them to the cluster once the pod is responding.

Instead of the current recommended command: ["rabbitmq-diagnostics", "status"], would the stage 4 check command: ["rabbitmq-diagnostics", "check_port_connectivity"] be sufficient to detect a pod not yet in a cluster?

Types of Changes

What types of changes does your code introduce to this project? Put an x in the boxes that apply

  • [x] Bug fix (non-breaking change which fixes issue #NNNN)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • [ ] Documentation improvements (corrections, new content, etc)
  • [ ] Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask on the mailing list. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING.md document
  • [ ] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • [ ] All tests pass locally with my changes
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

+7 -15

0 comment

2 changed files

pr created time in 5 months

create barnchjohanneswuerbach/rabbitmq-peer-discovery-k8s

branch : use-not-ready

created branch time in 5 months

fork johanneswuerbach/rabbitmq-peer-discovery-k8s

Kubernetes-based peer discovery backend for RabbitMQ 3.7.0+

fork in 5 months

pull request commentnodesource/docker-nsolid

Update to alpine 3.10

I think that highly depends on what folks build on top of nsolid images as there have been various updates

https://www.alpinelinux.org/posts/Alpine-3.6.0-released.html https://www.alpinelinux.org/posts/Alpine-3.7.0-released.html https://www.alpinelinux.org/posts/Alpine-3.8.0-released.html https://www.alpinelinux.org/posts/Alpine-3.9.0-released.html https://www.alpinelinux.org/posts/Alpine-3.10.0-released.html

What is actually more important for us, is that 3.5 has reached end of support already a while ago https://wiki.alpinelinux.org/wiki/Alpine_Linux:Releases

johanneswuerbach

comment created time in 5 months

pull request commentsquaremo/amqp.node

Fix stream becoming readable again

@squaremo sorry for the ping, but is there anything else required here?

johanneswuerbach

comment created time in 5 months

pull request commentnodesource/docker-nsolid

Add erbium images

Any chance to also bump alpine for the erbium images at least https://github.com/nodesource/docker-nsolid/pull/41?

johanneswuerbach

comment created time in 5 months

PR opened nodesource/docker-nsolid

Update to alpine 3.10

Update alpine to latest.

Fixes https://github.com/nodesource/docker-nsolid/issues/32

+5 -5

0 comment

5 changed files

pr created time in 5 months

create barnchjohanneswuerbach/docker-nsolid

branch : bump-alpine

created branch time in 5 months

push eventjohanneswuerbach/docker-nsolid

Johannes Würbach

commit sha f8b2171bd50389886c3673c38ae1cc198e5fc80b

Add erbium images

view details

Adrian Estrada

commit sha 1b6e0c3a8fe696d0eaba56346a71cbd52c38ece8

Updating some docs for latest N|Solid and erbium

view details

push time in 5 months

delete branch johanneswuerbach/docker-nsolid

delete branch : erbium

delete time in 5 months

PR opened nodesource/docker-nsolid

Add erbium images

Add images for Node Erbium (v12), which should available now https://nodesource.com/blog/announcing-NSolid-V3.7.0

+24 -24

0 comment

17 changed files

pr created time in 5 months

more