pull request commentTheRealReal/ecto-ulid
@sztosz I managed to contact dcuddeback and long story short, TheRealReal has assigned people to look into this. They seem like an active company so I won’t consider forking yet.
comment created time in 2 months
pull request commentTheRealReal/ecto-ulid
@markusfeyh Hi there, appreciate you looking into this.
CI was failing because Travis couldn’t fetch certain Erlang versions. Fixed and expanded coverage up to Elixir 1.11. For your convenience, #7, #8 and half of #10 are duplicates.
comment created time in 2 months
pull request commentTheRealReal/ecto-ulid
@jayjun I don't think you can just "take over" a repo without the owner permission. But If you fork it, update, and fix it, I'll be glad to make the project I work on switch to it. We're doing daily a lot of builds in our pipelines, so it may give new library some stats in hex.pm that would make deprecation of this package easier.
I totally understand that @dcuddeback does not maintain it any more for whatever reasons, and I'm OK with that. I can only thank him, and thank the person that will carry on with making ULID's compatible with current and further versions of ecto.
comment created time in 2 months
pull request commentTheRealReal/ecto-ulid
@jayjun could you update the tests so CI passes?
comment created time in 2 months
pull request commentTheRealReal/ecto-ulid
Agree with @xward, I sent the same fix #5 over a year ago. 🙂
@dcuddeback If you are no longer interested in this project, may I take over?
I rely on this package heavily and evidently many do.
comment created time in 2 months
PR closed TheRealReal/ecto-ulid
I needed this to work, so I created my own fork and cherry-picked what I needed and made some changes to make it work on the CI.
- fixes compatibility issue with Ecto ~> 3.2 (cherry-picked from #7)
- adds ULID type (from #6)
- bumps Ecto requirement to
~> 3.2 - requires Elixir 1.7 (because of newer Ecto versions)
- updates CI configuration
- formats code with mix format
pr closed time in 2 months
pull request commentTheRealReal/ecto-ulid
Compatibility with Ecto ~> 3.2, ULID.t, formatter
See #10.
comment created time in 2 months
PR opened TheRealReal/ecto-ulid
Same as #9, I had to change the source branch.
pr created time in 2 months
pull request commentTheRealReal/ecto-ulid
Compatibility with Ecto ~> 3.2, ULID.t, formatter
I don't want to rush anybody, but do you intent to merge any of the pull requests addressing this issue? The first PR addressing it is more than a year old.
comment created time in 2 months
push eventTheRealReal/heroku-review-envs
commit sha 9c5dbf4bb05ef9dae6eeff998f0e899b4cb9476f
Merge pull request #35 from TheRealReal/zotter [#173948593] Auto bump timeout
commit sha 897d727b55c6e38fbeba952411a7a734246fe328
Do not attempt to attach to related app if env var is not present
push time in 2 months
PR opened TheRealReal/ecto-ulid
I needed this to work, so I created my own fork and cherry-picked what I needed.
- fixes compatibility issue with Ecto ~> 3.2 (cherry-picked from #7)
- adds ULID type (from #6)
- bumps Ecto requirement to
~> 3.2 - updates CI configuration
- formats code with mix format
pr created time in 3 months
pull request commentTheRealReal/ecto-ulid
I've got other things on my mind right now, so changed it to draft. I may find some time later in the week. Changing behaviour to just use may work, but it does not enforce that public API stays same in proper way.
comment created time in 3 months
pull request commentTheRealReal/ecto-ulid
What about doing like I did here ? Code will be managed in Ecto.Type here
comment created time in 3 months
pull request commentTheRealReal/ecto-ulid
Any news about this pr ? The fixed I did here also fix the problem on ecto 3.5.
comment created time in 3 months
pull request commentTheRealReal/ecto-ulid
Probably the best solution. But I also am not sure any more If it should be :dump or :self. I need to rethink it and rewrite it. But running those tests only on 3.5 makes a lot of sense.
comment created time in 3 months
pull request commentTheRealReal/ecto-ulid
Would it be possible to add a check if the ecto version is greater than 3.5 so those tests are only run in that case?
comment created time in 3 months
pull request commentTheRealReal/ecto-ulid
@markusfeyh I added unit tests, and they work with Ecto 3.5, but they are not backward compatible with earlier versions because embeded_dump and embeded_load were added only in Ecto 3.4.1.
Should I just drop the tests with embed_as, which de facto tests not the Ecto.ULID library but if Ecto does it job correctly, or rather try to rewrite those tests to be backward compatible?
comment created time in 3 months
pull request commentTheRealReal/ecto-ulid
Sure, will add them tomorrow.
comment created time in 3 months
pull request commentTheRealReal/ecto-ulid
Thanks @sztosz. Could you add unit tests that document this functionality?
comment created time in 3 months
PR opened TheRealReal/ecto-ulid
Adds required callbacks implementations embed_as/1 and equal?/2 for Ecto.Type behaviour
pr created time in 3 months