profile
viewpoint

jboss-openshift/cct_module 41

CEKit modules shared by OpenShift container images

jmtd/badiso 4

tool for investigating damaged ISO9660 filesystems

jmtd/chocolate-doom 2

Chocolate Doom is a Doom source port that is conservative and historically accurate.

jmtd/chocolate_duke3D 1

chocolate Duke Nukem,3D

jmtd/Cinnamon 1

A Linux Desktop featuring a traditional layout (Gnome 2), built from modern technology (Gnome Shell) and introducing brand new innovative features.

jmtd/crm114-spamd 1

clone of Johannes Berg's crm114-spamd

jmtd/cryptkeeper 1

A system tray (gnome, xfce, kde) applet that manages EncFS encrypted folders.

jmtd/alga 0

Algebraic graphs

jmtd/application-templates 0

OpenShift application templates supporting JBoss Middleware based applications.

push eventjmtd/striot

Jonathan Dowland

commit sha 3dce0fdcbed74f0e4dc731cd52bdd9345c1df7ce

VizGraph: Correct display of operator service rate The Operator parameter is service *time*: I.e., time taken to serve one Event. We wish to display the service *rate*: i.e., number of Events served per time unit (same as arrival rate). Calculate the service rate from the time and display that. If an operator has a serviceTime of 0, then the calculated rate is meaningless (divide by zero). Instead, display nothing.

view details

Jonathan Dowland

commit sha d0f9412b8275e0d264e90439a04a875add47ddb5

WearableExample: fix intSqrt Call `sqrt` in `intSqrt`

view details

Jonathan Dowland

commit sha 672ad2e1771896f312e10238910de2bf5df48c16

WearableExample: decompose euclidean distance Map Decompose the map that implements euclidean into two: one that performs the initial squaring and another that does the square root. Start adjusting service Time parameters to better model what happened in real life.

view details

Jonathan Dowland

commit sha 00477e9ec126a1d2483d6008e109dd4f201501f6

Orchestration: example of map hoisting reducing nodes

view details

Jonathan Dowland

commit sha 5966b7a697bfabcbdac5c448d0c43e4a2fbb9c0b

WIP: prep for UKSystems 21

view details

push time in 6 days

pull request commentjboss-container-images/openjdk

OPENJDK-533: test $HOME/passwd can be written to

I'd really like to have a regression test for this along the lines of:

I've got a behave test like this and a few other related WIP test changes in a branch (OPENJDK-533-passwd-perms-wip) which I'll be working on fixing up over the next couple of days whilst I'm at a conference.

jmtd

comment created time in 6 days

issue commentcekit/cekit

let's expand the joined CMD lines (e.g. stop doing CMD1 && CMD2…)

Hi! I guess we're used to it now. I haven't hit a problem with the chained commands for a while. I'll close.

jmtd

comment created time in 6 days

issue closedcekit/cekit

let's expand the joined CMD lines (e.g. stop doing CMD1 && CMD2…)

In the template, we do things like e.g.

{{ pkg_manager }} --setopt=tsflags=nodocs install -y {%- for package in packages %} {{ package }}{% endfor %} \
&& rpm -q{% for package in packages %} {{ package }}{% endfor %}

This was originally to reduce the amount of layers in our images, but we do not need to do that anymore since we can use more sophisticated build systems that don't result in excessive layers, and/or squashing.

But compressing things like this does make debugging issues harder because it's not always clear which part of the chain may have failed when something doesn't work. This has been a minor issue for a long time but I've just hit it fresh so I thought i'd finally raise an issue to discuss it.

closed time in 6 days

jmtd

pull request commentjboss-container-images/openjdk

Update imagestreams

Hey @jhuttana : whilst we were working on #248 , this PR has arrived. I think it covers much of what you were working on in #248 but there might be some things missing, there is also extra things we need (such as the apiVersion changes). Could you give it a review please? My hunch is this is likely good and if there are template changes we need to make not in this PR, it might make sense to leave those in #248 and rebase that PR on top of this one. WDYT?

yselkowitz

comment created time in 6 days

pull request commentjboss-container-images/openjdk

Update imagestreams

Thanks @yselkowitz! This will collide with #248 to some extent so we'll figure out how best to address that.

yselkowitz

comment created time in 6 days

pull request commentjboss-container-images/openjdk

Add OpenJDK 17 images to OpenShift ImageStream templates.

Syntax check I have done. I am not sure about item 2. and 3. As this is the first time I am trying testing part could you please help?

Sure no problem!

  1. importing them into an OpenShift cluster,

I've logged into an OpenShift cluster (I'll send you details of a shared one internally if you like). Then:

$ oc create -n dotnet-java-playground -f https://raw.githubusercontent.com/jhuttana/openjdk/release_branch_OpenJDK17_images_to_OpenShift_ImageStream_templates/templates/community-image-streams.json
imagestream.image.openshift.io/ubi8-openjdk-8 created
imagestream.image.openshift.io/ubi8-openjdk-11 created
imagestream.image.openshift.io/ubi8-openjdk-17 created
imagestream.image.openshift.io/java created

That completed successfully. Then I can inspect the objects it created:

;oc describe imagestream/ubi8-openjdk-17
Name:			ubi8-openjdk-17
Namespace:		dotnet-java-playground
Created:		About a minute ago
Labels:			<none>
Annotations:		openshift.io/display-name=Red Hat OpenJDK 17 (UBI8)
			openshift.io/image.dockerRepositoryCheck=2021-11-29T10:00:12Z
			openshift.io/provider-display-name=Red Hat, Inc.
Image Repository:	image-registry.openshift-image-registry.svc:5000/dotnet-java-playground/ubi8-openjdk-17
Image Lookup:		local=false
Unique Images:		1
Tags:			2

1.10
  tagged from registry.access.redhat.com/ubi8/openjdk-17:1.10
    prefer registry pullthrough when referencing this tag

  Build and run Java applications using Maven and OpenJDK 17 upon RHEL8.
  Tags: builder, java, openjdk, ubi8
  Example Repo: https://github.com/jboss-openshift/openshift-quickstarts

  * registry.access.redhat.com/ubi8/openjdk-17@sha256:9816c59fa8a2533c27960107a8bef181967d5af8903ac65a268c6a87407dd8fb
      About a minute ago

1.3
  tagged from registry.access.redhat.com/ubi8/openjdk-17:1.3
    prefer registry pullthrough when referencing this tag

  Build and run Java applications using Maven and OpenJDK 17 upon RHEL8.
  Tags: builder, java, openjdk, ubi8
  Example Repo: https://github.com/jboss-openshift/openshift-quickstarts

  ! error: Import failed (InternalError): Internal error occurred: registry.access.redhat.com/ubi8/openjdk-17:1.3: error parsing HTTP 404 response body: invalid character 'N' looking for beginning of value: "Not found\n"
      About a minute ago

That highlights that the metadata includes descriptions of non-existing image tags (1.3 for openjdk-17). but the :1.10 tag was successful.

jhuttana

comment created time in 7 days

Pull request review commentjboss-container-images/openjdk

Add OpenJDK 17 images to OpenShift ImageStream templates.

                 ]             }         },+        {+            "kind": "ImageStream",+            "apiVersion": "v1",+            "metadata": {+                "name": "openjdk-17-rhel7",+                "annotations": {+                    "openshift.io/display-name": "Red Hat OpenJDK 17",+                    "openshift.io/provider-display-name": "Red Hat, Inc.",+                    "version": "1.4.17"+                },+                "labels": {+                    "xpaas": "1.4.17"+                }+            },+            "spec": {+                "tags": [+                    {+                        "name": "1.0",

drop this section and the next (1.0 and 1.1)

jhuttana

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentjboss-container-images/openjdk

Add OpenJDK 17 images to OpenShift ImageStream templates.

                 ]             }         },+        {+            "kind": "ImageStream",+            "apiVersion": "v1",+            "metadata": {+                "name": "ubi8-openjdk-17",+                "annotations": {+                    "openshift.io/display-name": "Red Hat OpenJDK 17 (UBI8)",+                    "openshift.io/provider-display-name": "Red Hat, Inc."+                }+            },+            "spec": {+                "tags": [+                    {+                        "name": "1.3",

(and in the other files)

jhuttana

comment created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentjboss-container-images/openjdk

Add OpenJDK 17 images to OpenShift ImageStream templates.

                             "name": "registry.access.redhat.com/ubi8/openjdk-11:latest"                         }                     },+                    {+                        "name": "openjdk-17-ubi8",+                        "annotations": {+                            "openshift.io/display-name": "Red Hat OpenJDK 17 (UBI 8)",+                            "description": "Build and run Java applications using Maven and OpenJDK 17 upon UBI8.",+                            "iconClass": "icon-rh-openjdk",+                            "tags": "builder,java,openjdk",+                            "supports": "java:17,java",+                            "sampleRepo": "https://github.com/jboss-openshift/openshift-quickstarts",+                            "sampleContextDir": "undertow-servlet",+                            "version": "17"+                        },+                        "referencePolicy": {+                            "type": "Local"+                        },+                        "from": {+                            "kind": "DockerImage",+                            "name": "registry.access.redhat.com/ubi8/openjdk-17:latest"+                        }+                    },+                    {+                        "name": "11",

this should be "17"

jhuttana

comment created time in 7 days

Pull request review commentjboss-container-images/openjdk

Add OpenJDK 17 images to OpenShift ImageStream templates.

                 ]             }         },+        {+            "kind": "ImageStream",+            "apiVersion": "v1",+            "metadata": {+                "name": "ubi8-openjdk-17",+                "annotations": {+                    "openshift.io/display-name": "Red Hat OpenJDK 17 (UBI8)",+                    "openshift.io/provider-display-name": "Red Hat, Inc."+                }+            },+            "spec": {+                "tags": [+                    {+                        "name": "1.3",

This segment describes ubi8/openjdk-17:1.3 but that version does not exist; the first version we have published is :1.10.

jhuttana

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentjboss-container-images/openjdk

OPENJDK-533: test $HOME/passwd can be written to

 get_exec_args() { # Ensure that the running UID has the "jboss" passwd metadata # XXX: Maybe we should make this an entrypoint for the image? function configure_passwd() {-  sed "/^jboss/s/[^:]*/$(id -u)/3" /etc/passwd > "$HOME/passwd"+  if [ -w "$HOME/passwd" ]; then

Good idea.

jmtd

comment created time in 7 days

PullRequestReviewEvent

push eventjmtd/openjdk

Jonathan Dowland

commit sha e7df1607f26f88cb8cab512958d82e063a783d40

OPENJDK-533: test $HOME/passwd can be written to run-java.sh has a line which attempts to write to $HOME/passwd, which is part of the solution for backwards compatibility on OCP 3.11 (OPENJDK-312). This was made writeable by a common module but that was moved to a new nss-wrapper module in OPENJDK-493, which is not installed in OpenJDK 17 containers. Two problems result for the OpenJDK-17 image: • Starting a downstream (S2I) container with a random UID (OpenShift default) terminates when the attempt to write to /home/jboss/passwd fails • for some container runtimes (at least Docker), the container will refuse to start if the running uid can't chdir to /home/jboss That change also moved changing the /home/jboss permissions. Partially revert those changes and check to ensure the file can be written before attempting to. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>

view details

push time in 7 days

push eventjboss-container-images/openjdk

Jayashree Huttanagoudar

commit sha 0afe49cf8b1bc707f91003a4d4404cb682766036

Updated container metadata for documentation to point at new docs. -Deleted documentation metadata from runtime descriptors as it is in-appropriate. Signed-off-by: Jayashree Huttanagoudar <jhuttana@redhat.com>

view details

Jonathan Dowland

commit sha 6ea56052d8c300f157f031832dc8d2243119060a

Merge pull request #251 from jhuttana/update_container_metadata_to_point_new_doc Updated container metadata for documentation to point at new docs.

view details

push time in 7 days

PullRequestReviewEvent

push eventjboss-container-images/openjdk

Jayashree Huttanagoudar

commit sha c241dc0e12d6ae75c05d3dd8ebef6124ae54cfaa

Added LANG environment variable to ubi8-based images. -The value set is LANG="C.utf8" -Added behave test to openjdk.feature Signed-off-by: Jayashree Huttanagoudar <jhuttana@redhat.com>

view details

Jonathan Dowland

commit sha a88d4268c81fa438c3df7479b468c5e631833ad4

Merge pull request #252 from jhuttana/define_LANG_ENV_for_ubi8_images Added LANG environment variable to ubi8-based images.

view details

push time in 7 days

PullRequestReviewEvent

issue commentjboss-container-images/openjdk

Add GHA tests for ubi8/openjdk-17

This might be another good issue for @jhuttana

jerboaa

comment created time in 7 days

pull request commentjboss-container-images/openjdk

OPENJDK-533: test $HOME/passwd can be written to

@jerboaa it's tagged \@openjdk which should mean it's run for any image prefixed with openjdk/ including the 17 images. None of the tests it seems would catch bug 1) above, since they almost all override the CMD to do somehing like stat or grep, so run-java.sh was not getting exercised. I've been working on addressing that, but there are some complexities trying to do an s2i test and a non-default uid test at the same time.

For issue 2), I would have thought nearly all the tests should fail, so I cannot explain yet why they didn't.

jmtd

comment created time in 7 days

pull request commentjboss-container-images/openjdk

Updated container metadata for documentation to point at new docs.

Thanks - for the builder images that's perfect. For the runtime images, it's not appropriate (documents s2i features they don't have). However, the old value is also problematic! Can we delete the "usage" label from the runtime images for now?

jhuttana

comment created time in 10 days

PR opened jboss-container-images/openjdk

OPENJDK-533: test $HOME/passwd can be written to

run-java.sh has a line which attempts to write to $HOME/passwd, which is part of the solution for backwards compatibility on OCP 3.11 (OPENJDK-312). This was made writeable by a common module but that was moved to a new nss-wrapper module in OPENJDK-493, which is not installed in OpenJDK 17 containers.

Two problems result for the OpenJDK-17 image:

• Starting a downstream (S2I) container with a random UID (OpenShift default) terminates when the attempt to write to /home/jboss/passwd fails • for some container runtimes (at least Docker), the container will refuse to start if the running uid can't chdir to /home/jboss

That change also moved changing the /home/jboss permissions. Partially revert those changes and check to ensure the file can be written before attempting to.


Testing performed:

• local s2i builds, verified the /home/jboss +x change resolves the docker issue • oc new-app (OCP 4.x cluster) with a quarkus quickstart, pod runs

I'm surprised that the Behave tests didn't catch these issues, and I'm looking now to find out why.

+4 -1

0 comment

2 changed files

pr created time in 10 days

create barnchjmtd/openjdk

branch : OPENJDK-533-passwd-perms

created branch time in 10 days

pull request commentjboss-container-images/openjdk

Delete duplicate JAVA_ARGS value in the logs ubi8/openjdk image.

Thanks. Please have a go and feel free to ask any questions. I realise running the tests might be awkward as the cekit test … behave functionality only works with Docker not Podman, however, if you push a test to a branch in your GitHub fork, GitHub actions should run the test (if it's properly tagged)

jhuttana

comment created time in 12 days

more