profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jjtang1985/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Junjie Tang jjtang1985 SAP **Disclaimer:** Opinions expressed are solely my own and do not express the views or opinions of my employer.

jjtang1985/Tutorials 1

Tutorials on sap.com

jjtang1985/cloud-s4-sdk-examples 0

Runnable example applications that showcase the usage of the SAP Cloud SDK.

jjtang1985/cloud-s4-sdk-pipeline 0

The Cloud SDK pipeline uses the Cloud SDK continuous delivery server for building, checking, and deploying extension applications. Projects based on the SAP Cloud SDK archetype will automatically use this pipeline.

jjtang1985/cloud-sdk 0

Use the SAP Cloud SDK for JavaScript / TypeScript to reduce development effort when building applications on SAP Cloud Platform that communicate with SAP solutions and services such as SAP S/4HANA Cloud, SAP SuccessFactors, and many others.

jjtang1985/cloud-sdk-cli 0

The command line interface for the SAP Cloud SDK

jjtang1985/cloud-sdk-team-calendar 0

Learn how to build an extension to SAP S/4HANA and SAP SuccessFactors using the SAP Cloud SDK. Start using this sample and follow the given instructions.

jjtang1985/fosstars-rating-core 0

A framework for defining ratings for open source projects. In particular, the framework offers a security rating for open source projects that may be used to assess the security risk that comes with open source components.

PullRequestReviewEvent

Pull request review commentSAP/cloud-sdk-js

feat: Add OAuth2Password as auth type

 describe('OAuth flows', () => {     expect(result.length).toBe(1);   }, 60000); +  xit('OAuth2Password: Fetches destination and destiantion service has token', async () => {

All the tests in the file are local tests that need a JWT that is fetched manually, which is a convenient auth related local test instead of doing e2e test.

FrankEssenberger

comment created time in 7 hours

PullRequestReviewEvent

Pull request review commentSAP/cloud-sdk-js

feat: Add OAuth2Password as auth type

 class DestinationFromServiceRetriever {     return this.fetchDestinationByToken(token);   } -  private async addOAuth2ClientCredentials(): Promise<Destination> {+  /**+   * The fetch by name delegates the oAuth token handling to the destination service.+   * @private+   */+  private async fetchDestinationByClientCrendentialsGrant(): Promise<Destination> {     const clientGrant = await serviceToken('destination', {       userJwt: this.options.userJwt || this.providerClientCredentialsToken     }); -    return fetchDestination(-      this.destinationServiceCredentials.uri,-      clientGrant,-      this.name-    );+    return this.fetchDestinationByToken(clientGrant);   } -  private async addOAuthSamlAuth(-    destination: Destination,-    destinationOrigin: DestinationOrigin-  ): Promise<Destination> {-    /* This covers the two technical user propagation cases https://help.sap.com/viewer/cca91383641e40ffbe03bdc78f00f681/Cloud/en-US/3cb7b81115c44cf594e0e3631291af94.html-   If the destination comes from the provider account the client credentials token from the xsuaa.url is used (provider token).-   If the destination comes from the subscriber account the subscriber subdomain is used fetch the client credentials token (subscriber token).-   */-    if (destination.systemUser) {+  private async fetchDestinationBySystemUser(+    destinationResult: DestinationSearchResult+  ): Promise<Destination | undefined> {+    if (destinationResult.destination.systemUser) {       const token =-        destinationOrigin === 'provider'+        destinationResult.origin === 'provider'           ? this.providerClientCredentialsToken           : await DestinationFromServiceRetriever.getSubscriberClientCredentialsToken(               this.options             );       logger.debug(-        `System user found on destination. The ${destinationOrigin} token: ${token} is used for destination fetching.`+        `System user found on destination. The ${destinationResult.origin} token: ${token} is used for destination fetching.`

Yes, we only log token in this case, and we decided to remove it, as it's useless and the "system user" related functionalities are deprecated from the BTP.

FrankEssenberger

comment created time in 7 hours

PullRequestReviewEvent

Pull request review commentSAP/cloud-sdk-js

feature: Add OAuth2Password as auth type

 For return types the same extension could lead compile errors after client regen ## New Functionality  - [core] Support additional headers and query parameters, that are set on destinations.+- [core] Support authentication type `OAut2Pass`.
- [core] Support authentication type `OAuth2Password`.
FrankEssenberger

comment created time in 9 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventSAP/cloud-sdk-js

dependabot[bot]

commit sha f5e8999c67fb0f21cd9ab11475d30e200b93097b

chore(deps): bump yargs from 17.0.1 to 17.1.0 (#1486) Bumps [yargs](https://github.com/yargs/yargs) from 17.0.1 to 17.1.0. - [Release notes](https://github.com/yargs/yargs/releases) - [Changelog](https://github.com/yargs/yargs/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/yargs/compare/v17.0.1...v17.1.0) --- updated-dependencies: - dependency-name: yargs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 9 hours

delete branch SAP/cloud-sdk-js

delete branch : dependabot/npm_and_yarn/yargs-17.1.0

delete time in 9 hours

PR merged SAP/cloud-sdk-js

chore(deps): bump yargs from 17.0.1 to 17.1.0 dependencies

Bumps yargs from 17.0.1 to 17.1.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/yargs/yargs/blob/master/CHANGELOG.md">yargs's changelog</a>.</em></p> <blockquote> <h2><a href="https://www.github.com/yargs/yargs/compare/v17.0.1...v17.1.0">17.1.0</a> (2021-08-04)</h2> <h3>Features</h3> <ul> <li>update Levenshtein to Damerau-Levenshtein (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1973">#1973</a>) (<a href="https://www.github.com/yargs/yargs/commit/d2c121b00f2e1eb2ea8cc3a23a5039b3a4425bea">d2c121b</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li>coerce middleware should be applied once (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1978">#1978</a>) (<a href="https://www.github.com/yargs/yargs/commit/14bd6bebc3027ae929106b20dd198b9dccdeec31">14bd6be</a>)</li> <li>implies should not fail when implied key's value is 0, false or empty string (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1985">#1985</a>) (<a href="https://www.github.com/yargs/yargs/commit/80104727d5f2ec4c5b491c1bdec4c94b2db95d9c">8010472</a>)</li> <li>positionals should not overwrite options (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1992">#1992</a>) (<a href="https://www.github.com/yargs/yargs/commit/9d84309e53ce1d30b1c61035ed5c78827a89df86">9d84309</a>)</li> <li>strict should fail unknown arguments (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1977">#1977</a>) (<a href="https://www.github.com/yargs/yargs/commit/c804f0db78e56b44341cc7a91878c27b1b68b9f2">c804f0d</a>)</li> <li>wrap(null) no longer causes strange indentation behavior (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1988">#1988</a>) (<a href="https://www.github.com/yargs/yargs/commit/e1871aa792de219b221179417d410931af70d405">e1871aa</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/yargs/yargs/commit/5d531444077c91538d5c277ad5026996076d5811"><code>5d53144</code></a> chore: release 17.1.0 (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1984">#1984</a>)</li> <li><a href="https://github.com/yargs/yargs/commit/54837eb36c2fb1a73bda7495d34a3aa7f52b55d7"><code>54837eb</code></a> build: use denoland/setup-deno (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1991">#1991</a>)</li> <li><a href="https://github.com/yargs/yargs/commit/e1871aa792de219b221179417d410931af70d405"><code>e1871aa</code></a> fix: wrap(null) no longer causes strange indentation behavior (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1988">#1988</a>)</li> <li><a href="https://github.com/yargs/yargs/commit/b737d680aeaae1e396cec167ec94fa9c9895c88e"><code>b737d68</code></a> chore(deps): update dependency <code>@​types/mocha</code> to v9 (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1993">#1993</a>)</li> <li><a href="https://github.com/yargs/yargs/commit/9d84309e53ce1d30b1c61035ed5c78827a89df86"><code>9d84309</code></a> fix: positionals should not overwrite options (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1992">#1992</a>)</li> <li><a href="https://github.com/yargs/yargs/commit/80104727d5f2ec4c5b491c1bdec4c94b2db95d9c"><code>8010472</code></a> fix: implies should not fail when implied key's value is 0, false or empty st...</li> <li><a href="https://github.com/yargs/yargs/commit/14bd6bebc3027ae929106b20dd198b9dccdeec31"><code>14bd6be</code></a> fix: coerce middleware should be applied once (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1978">#1978</a>)</li> <li><a href="https://github.com/yargs/yargs/commit/d2c121b00f2e1eb2ea8cc3a23a5039b3a4425bea"><code>d2c121b</code></a> feat: update Levenshtein to Damerau-Levenshtein (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1973">#1973</a>)</li> <li><a href="https://github.com/yargs/yargs/commit/c804f0db78e56b44341cc7a91878c27b1b68b9f2"><code>c804f0d</code></a> fix: strict should fail unknown arguments (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1977">#1977</a>)</li> <li><a href="https://github.com/yargs/yargs/commit/54786119fc55ccc060ccdef8459bb2871083b9b6"><code>5478611</code></a> i18n: Update zh_TW.json (<a href="https://github-redirect.dependabot.com/yargs/yargs/issues/1976">#1976</a>)</li> <li>Additional commits viewable in <a href="https://github.com/yargs/yargs/compare/v17.0.1...v17.1.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 9 hours

pull request commentSAP/cloud-sdk-js

fix: encoding OData get by key

@FrankEssenberger , I rearranged the order of some sections and kept the long details into background.

jjtang1985

comment created time in a day

push eventSAP/cloud-sdk-js

Junjie Tang

commit sha 8d8b7a01a9803d69fe0d2ec7ef78d23693ea9013

comments

view details

push time in a day

push eventSAP/cloud-sdk-js

dependabot[bot]

commit sha 7fe2f4ae494d6ed6e7ca3c5be5ecde4e741e42c3

chore(deps-dev): bump @sap/cds from 5.4.0 to 5.4.1 (#1482) Bumps [@sap/cds](https://cap.cloud.sap/) from 5.4.0 to 5.4.1. --- updated-dependencies: - dependency-name: "@sap/cds" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in a day

delete branch SAP/cloud-sdk-js

delete branch : dependabot/npm_and_yarn/sap/cds-5.4.1

delete time in a day

PR merged SAP/cloud-sdk-js

chore(deps-dev): bump @sap/cds from 5.4.0 to 5.4.1 dependencies

Bumps @sap/cds from 5.4.0 to 5.4.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in a day

push eventSAP/cloud-sdk-js

dependabot[bot]

commit sha aca459fe34b7a32e7b6f84258d2d57412c57f92e

chore(deps-dev): bump @sap/cds-dk from 4.4.0 to 4.4.1 (#1483) Bumps [@sap/cds-dk](https://cap.cloud.sap/) from 4.4.0 to 4.4.1. --- updated-dependencies: - dependency-name: "@sap/cds-dk" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in a day

delete branch SAP/cloud-sdk-js

delete branch : dependabot/npm_and_yarn/sap/cds-dk-4.4.1

delete time in a day

PR merged SAP/cloud-sdk-js

chore(deps-dev): bump @sap/cds-dk from 4.4.0 to 4.4.1 dependencies

Bumps @sap/cds-dk from 4.4.0 to 4.4.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+5 -5

0 comment

1 changed file

dependabot[bot]

pr closed time in a day

push eventSAP/cloud-sdk-js

Junjie Tang

commit sha 130fd101bde0e375a9133c92ec7c5402a3b5cc06

chagelog

view details

push time in 2 days

PR opened SAP/cloud-sdk-js

Reviewers
Fix: encoding key

Please provide a description of what your change does and why it is needed.

Closes SAP/cloud-sdk-backlog#ISSUENUMBER.

<!-- Check List:

  • Tests created/adjusted for your changes.
  • Release notes updated.
  • PR title adheres to conventional commit guidelines.
  • If applicable:
    • Documented public API (TypeDoc).
    • Checked that yarn run doc still works. -->
+207 -1

0 comment

3 changed files

pr created time in 2 days

push eventSAP/cloud-sdk-js

Junjie Tang

commit sha 037bdf28b903c10ca85c041898142b23203e5daa

Update 0024-url-encoding.md

view details

push time in 2 days

create barnchSAP/cloud-sdk-js

branch : fix-encoding-key

created branch time in 2 days

issue closedSAP/cloud-sdk

[rl-reuse_tool-1] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-1 Explanation: Does README mention REUSE? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

closed time in 2 days

sap-ospo-bot

issue commentSAP/cloud-sdk

[rl-reuse_tool-1] Violation against OSS Rules of Play

The badge is added.

sap-ospo-bot

comment created time in 2 days

PR merged SAP/cloud-sdk

Reviewers
Add budge of reuse scan result.

What Has Changed?

Explain what you have changed.

Manual Checks?

  • [ ] Text adheres to the style guide (vale docs/)
    • Every sentence is on its own line
    • Headings use title capitalization (applies also to the sidebar and title of a document)
    • You followed naming center guidelines when referring to SAP products (e.g. SAP S/4HANA)
  • [ ] You checked your spelling and grammar (consider using Grammarly, see CONTRIBUTING.md)
  • [ ] You formatted all changed files with prettier (npm run prettier)
  • [ ] You tested if the documentation still builds (npm run build)
  • [ ] You verified all new and changed links still work (changing the id or name of a file can break links)
  • [ ] You have updated the feature matrix if you add documentation on a new feature or otherwise required.
+2 -0

0 comment

1 changed file

jjtang1985

pr closed time in 2 days

push eventSAP/cloud-sdk

Junjie Tang

commit sha cea7b28035bcd2a80691a1adc9898ce39b3f5b16

Add budge of reuse scan result. (#402)

view details

push time in 2 days

delete branch SAP/cloud-sdk

delete branch : jjtang1985-patch-1

delete time in 2 days

push eventSAP/cloud-sdk-js

dependabot[bot]

commit sha bcebca1de07ea052bc7fda451c291d8563a02fbe

chore(deps-dev): bump @typescript-eslint/parser from 4.28.5 to 4.29.0 (#1477) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.28.5 to 4.29.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.29.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 2 days

delete branch SAP/cloud-sdk-js

delete branch : dependabot/npm_and_yarn/typescript-eslint/parser-4.29.0

delete time in 2 days