profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jhendersonHDF/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

brtnfld/CLAMR-1 0

Cell-Based Adaptive Mesh Refinement

HDFGroup/vol-rest 0

HDF5 REST VOL Connector

jhendersonHDF/hdf5 0

Official HDF5® Library Repository

jhendersonHDF/ior 0

IOR and mdtest

jhendersonHDF/miniIO 0

I/O Mini-apps

jhendersonHDF/vol-daos 0

HDF5 VOL connector for DAOS

jhendersonHDF/vol-rest 0

HDF5 REST VOL Connector

PullRequestReviewEvent
PullRequestReviewEvent

delete branch jhendersonHDF/hdf5

delete branch : gcc_static_analysis

delete time in 2 days

push eventjhendersonHDF/hdf5

Dana Robinson

commit sha 8e2fc4a2e2325a006d42b1df5c339549cdd2cb94

Remove checks for winsock2.h (#813) This is only needed on Windows and always available, so there's no need to check for it.

view details

Dana Robinson

commit sha 86e8238ad32e70b56cdc61c56551ca71bd7d46b9

Removes develop header cruft (#828)

view details

H. Joe Lee

commit sha 6b94bf50a06a9e20c6893514bfa141b69dbca0d1

OESS-168:Remove implicit conversion warnings. (#829) * OESS-168:Remove implicit conversion increases floating-point precision warnings. * OESS-168:Remove clang warnings.

view details

jhendersonHDF

commit sha 31027a997c3cc5de9140930560d5155bef26289b

Add support for parallel filters to h5repack (#832)

view details

Jan-Willem Blokland

commit sha 21c6bb38e6cf0776dbdc37841280dffd6ca79990

CMake: (feature) libaec (#703) * CMake: (feature) libaec Implemented better support for the compression library libaec. Especially, for the new version 1.0.5: - The CMake config files of this version 1.0.5 now set certain SZIP variables which can be used in the existing CMake structure. - Both static and shared SZIP compatible libaec library contains all required objects such it can be easily used when building HDF5 from scratch. - Introduced the USE_LIBAEC_STATIC option to make use of the static version of SZIP compatible libaec library. * CMake: (fix) libaec Implemented the fallback option for the case if version 1.0.5 of libaec could not be found. * Docs: Added description about libaec implementation. Added short description about the libaec improvement to the Bug Fixes section in the Configuration sub-section.

view details

Allen Byrne

commit sha 9ec773bb18b8e7ddce5e347577329fcc8f7a73a9

Changes to docs for using plugins (#814) * Changes to docs for using plugins * VS2019 corrections * Fix typo

view details

Allen Byrne

commit sha 436727dceab2df46ef688f31fa199254e64ec34a

Perform option arg variables (#834) * Correct option name * Undo accidental commit * Note LLVM 10 to 11 format default changes * Update format plugin * Undo clang-format version 11 changes * One more correction * Update supported platforms * Revert whitespace changes * Correct whitespace * Changes from PR#3 * HDFFV-11213 added option to control gcc10 warnings diagnostics * HDFFV-11212 Use the new references correctly in JNI utility and tests * format source * Fix typo * Add new test file * HDFFV-11212 - update test and remove unused arg * Minor non-space formatting changes * Use H5I_INVALID_ID instead of "-1" * source formatting * add missing testfile, update jni function * Undo commit of debug code * remove mislocated file * Fix h5repack test for handling of fapls and id close * Update h5diff test files usage text * HDFFV-11212 add new ref tests for JNI export dataset * src format update * Remove blank line typo * src format typo * long double requires %Lg * Another long double foramt specifer S.B. %Lg * issue with t128bit test * Windows issue with h5dump and type. * Fix review issues * refactor function nesting and fix error checks * format fixes * Remove untested functions and javadoc quiet comments * Restore TRY block. * Change string append errors to memory exception * revert to H5_JNI_FATAL_ERROR - support functions need work * Add assertion error for h5util functions * remove duplicate function * format fix * Revert HD function error handling * Update copyright comments * GH #386 java folder copyright corrections * Whitespace * GH #359 implement and fix tools 1.6 API usage * remove excessive comments * Flip inits to correct ifdef section * rework ifdef to be simpler * format issue * Reformat ifdef inits * remove static attribute * format compliance * Update names * Revert because logic relies on float not being int * Changes noticed from creating merge of #412 * Double underscore change * Correct compiler version variable used * Remove header guard underscores * Whitespace cleanup * Split format source and commit changes on repo push * remove pre-split setting * Change windows TS to use older VS. * correct window os name * HDFFV-11212 JNI export util and Javadoc * Suggested review changes * Another change found * Committing clang-format changes * HDFFV-11113 long double in tools * HDFFV-11113 add note * Disable long double tests for now * HDFFV-11228 remove arbitrary CMake warning groups. * Make each flag a string * Some Javadoc warning fixes * Updated javadoc fixes * # WARNING: head commit changed in the meantime HDFFV-11229 Fix long double usage in tools and java Changed h5dump and h5ls to just print 128-bit for long double type. Added test and file for dataset and attributes with all three float types. * Committing clang-format changes * HDFFV-11229 Add release note * HDFFV-11229 windows testfile needed * fix typo * Remove non supported message text * HDFFV-11229 - change ldouble test to check both native and general * HDFFV-11229 add second file compare * HDFFV-11229 fix reference file * HDFFV-11229 autotools check two refs * HDFFV-11229 revert back to removal of NATIVE_LDOUBLE in tools output * Committing clang-format changes * Update release note * Update attribute type of ref file * Change source of ninja for macs * try port instead of brew * Recommended is to use brew. * Undo non long double changes * remove unneeded file * Fix perl and doxygen CMake code * Add "option" command for clang options * Rework CMake add_custom to use the BYPRODUCTS argument * Add stamp files to BYPRODUCTS * Only one copy of file exists * Fix custom cmmand depends targets * Fix fortran custom command DEPENDS * Add LD_LIBRARY_PATH to tests * Add custom target for DEPENDS * Add h5detect conditionaly to generated target DEPENDS * Correct DEPENDS targets * Parallel builds need the mpi compiler for pkgconfig scripts. * install only if MPI build * Fortran target depends * Remove incorrect source attribute * doxygen adjustments * doxygen build updates * Correct version * Correct function version - function has been merged to 1.12 * Correct version string for map functions * Cleanup warnings for tools debug builds * TRILAB-227 - fix indexing for h5diff selections * Correct location of pos to index function call * TRILAB-227 Enable test * Quote subset args * Use MATCHES because of AppleClang * if blocks needed for build modes * Update list of DT platforms * VS2019 correctly displays float values * revert VS2019 change * Issue #669 remove version from pkgcfg filename * remove version from h5cc script * Java reference functions updated enabled fortran in cmake gcc action yaml file java reference test changed to correctly test refs jni reference functions that create ids changed to use jni id logging * Correct BYPRODUCTS argument * Correct more genereated files BYPRODUCTS * BYPRODUCTS must have unique locations * Fix typo * Fix fortran configure checks * Rework H5_PAC_C_MAX_REAL_PRECISION setting logic * Add note about fortran configure change * Adds a quick for for some egregious chunk_info badness (#722) * Fixes issue with ccmake that prevents building Fortran (#723) ccmake runs iteratively, and the check_fortran_source_runs macros were clobbering a single output file that did not get updated on further configure iterations * Fix conflicts with merge * Move MAX_PRECISION back to HDF5UseFortran.cmake * Use STREQUAL to test macro argument * Move C language test to ConfigureChecks from HDF5UseFortran * MAX_PRECISION defines must be defined * Organize flags and align autotools and cmake * Fix comment in no-error-general warnings files. * Flag cleanup and fix typos * Add comment * Correct VAR used to find configure time file * Set the path correctly * Update missing release note info. * Update code owners * Correct JIRA note * add known problem. * Use only core library for testing dynamic plugins. * Fix static perform tools compile for arg options Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>

view details

jhendersonHDF

commit sha 50a37fde06457ee5e75ea65259c233cb6527bd91

Allow parallel filters feature for comm size of 1 (#840)

view details

Allen Byrne

commit sha 20dd1cedb35d95ecc21decb29352d7779d49a908

Issue #833 fix setting return result (#843)

view details

jhendersonHDF

commit sha 96b6872a1e7deac7673d31697dafa1f44763ede4

Avoid popping API context when one wasn't pushed (#848)

view details

Dana Robinson

commit sha 06de43332d80229dbe5f5a1ac4addf3fbc8325f5

Fixes a couple of warnings: (#849) - warn_unused_result warnings from h5jamgentest and j5stat_gentest that were triggered by write(2) calls where we didn't check the return value - A missing callback in the NULL VOL connector - A possibly uninitialized property list pointer

view details

Dana Robinson

commit sha 725da3768b6537d0cfae59f6b220396ea9fa042d

Removes unused commented-out code from h5jamgentest.c (#851)

view details

H. Joe Lee

commit sha f3441d54866d0736468b2697bbbee3ec81a83a5b

OESS-168:Remove clang warnings. (#835) * OESS-168:Remove implicit conversion increases floating-point precision warnings. * OESS-168:Remove clang warnings. * OESS-168:Remove clang warnings. * Committing clang-format changes * OESS-168:Remove clang warnings. * Committing clang-format changes * OESS-168:Remove clang warning. * OESS-168:Remove clang warnings. * OESS-168:Address @byrnHDF review. * Remove line added to generated hl/src/H5LTanalyze.c file. Issue #854 created for creating a fix. * Remove extra whitespace from H5LTanalyze.c. * Remove extra blank line. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Larry Knox <lrknox@hdfgroup.org>

view details

Allen Byrne

commit sha 74f1590d47acd41cd9aea8d9f6be52a5947ee5af

Only test h5diff_830 in serial (#858)

view details

Allen Byrne

commit sha cfcdf215187653703a21f1f99cc18e207138c39b

Remove version-check for relnum in H5check. (#812) * Remove version-check for relnum in H5check. * Add in release exception code check * Fix typos * Fix more typos * Rework comments * format change * format whitespace * Library version must be less than or equal to headers * Need the NOT version of the compare * Enable release+1 check for PASS * Add release note * Update note

view details

Dana Robinson

commit sha 9bb1d6d78e305e73b5c882e8f5b3ef66a1acdf8d

Updates a comment in H5mpi.c (#863) MPI_Type_struct() is an MPI-1 call we no longer use.

view details

Larry Knox

commit sha 9fd356e2408b6f91bfbe6820cdb979b6fade3fb3

Added int variable for comparison with H5_VERS_RELEASE in H5.c to avoid (#866) warning that unsigned comparison < 0 is always false, which is known, but for later versions the comparison can possibly be true.

view details

Larry Knox

commit sha 48a05aa887ae7d18512756bf1eeb177e08d0feaf

Unsigned comparison to 0 warning avoidance (#869) * Added int variable for comparison with H5_VERS_RELEASE in H5.c to avoid warning that unsigned comparison < 0 is always false, which is known, but for later versions the comparison can possibly be true. * Better solution for avoiding warning that unsigned comparison < 0.

view details

Dana Robinson

commit sha 04f1bff6757892df07cd72520af276f7691ff43b

Updates the RELEASE.txt file with a note about the variable-length fill (#871) value issue. A fix is in progress, but it might be a while before we have time to finish it up.

view details

Dana Robinson

commit sha 5dabec4cf6b97793e3af6df3b6a3953394bbf27d

Removes partial long options from the tools (#872) Some of the command-line tools would allow partial long options (e.g., --datas instead of --dataset). These were inconsistently implemented, difficult to maintain, and occasionally blocked useful long options. They have been removed from all the tools. NOTE: This change should NOT be merged to 1.12 or earlier.

view details

push time in 2 days

push eventjhendersonHDF/hdf5

Allen Byrne

commit sha 6968906418f9ecfc383ad960c975e65a504743b7

Fix clang/sanitizer for windows (#883) * Fix clang/sanitizer for windows * Restrict MSVC version for sanitize

view details

Allen Byrne

commit sha 451b472cdd63c8fef15c0866e0d3784e33a8b1c6

Fixed the CMake processing for C++ warnings and flags (#888)

view details

Allen Byrne

commit sha 04c504664b2cbb63b6a5cdf8c58a93dc65699f6d

Fix formatting (#923)

view details

Allen Byrne

commit sha af7989e858d383322ced07873c2e19b433e74988

Correct dataset close in java test (#919) * Correct dataset close * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Allen Byrne

commit sha c019db60eecc173e1d3b118c9aeb7885865fa50f

Remove non-published short arg names (#917) * Remove non-published short arg names * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Allen Byrne

commit sha c88c0f2008a0a431ee64ae7a36ed29f927ba3e13

Correct number of args to Windows HDunsetenv macro (#939) * Correct number of args to Windows HDunsetenv macro * Correct format

view details

Allen Byrne

commit sha 2524b57a6f69e1a24212cba12d504748e13e9743

Develop windows compiler fixes (#912) * Fix windows compiler issues Restore MS C++ Default exception handling behavior #885 Remove clang toolchain as it skips compiler checks * Add check and header gaurd for pwd.h * Revert change * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Larry Knox

commit sha 564380d176ae71d9f4ece9df51957e3f817be45d

Fix issue #924 in develop branch: the ${HDF5_CXXLINKER} does not work in h5c++ (#925) * Committing clang-format changes * Fix issue #924, ${HDF5_CXXLINKER} does not work in h5c++. 2 instances of CLINKER corrected to CXXLINKER comment border aligned Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Allen Byrne

commit sha 3600d33f10db1d520f360930c40bf99e282af101

CMake should use the output dir programs for shell scripts (#928)

view details

Jan-Willem Blokland

commit sha de60f08b0df0abdcac1c6959b393a6862dadd4ce

CMake: (fix) ph5example test (#935) Ensure that the used number of processes times an integer number is equal to SPACE1_DIM1 and SPACE_DIM2. These variables are equal to 24 and are defined in ph5example.c. If this is not the case the ph5example test will fail.

view details

Sean McBride

commit sha 09283ffbcb921efa89a7a1ca728f1d4b7064df8e

Get class name null str (#899) * Fixed MSVC compile error in C++23 mode Error message from MSVC with C++23 enabled: error C2440: 'return': cannot convert from 'int' to 'std::basic_string<char,std::char_traits,std::allocator>' * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Allen Byrne

commit sha b38bc071e956bec607b180a7d3f8217197393f02

Remove incorrect compiler check for windows clang sanitizer (#942)

view details

Ben Boeckel

commit sha b5f5c59f297be19096051282068cdcc14275eb34

cmake: simplify try_run result comparisons (#950) Instead of looking at `MATCHES 0` which runs a regex and returns a false positive for any result such as `10`, check if they are equal to `0`. Also quote `0` to avoid looking it up as a variable (which was left behind prior to the fix to use `${RETURN_VAR}` in the `c_run` macro).

view details

Sean McBride

commit sha f6c49fe8911a39810b236f7babf09a70fcc76c7b

More clang tidy (#908) * Pacify clang-analyzer-unix.cstring.NullArg * Apply some bugprone-suspicious-string-compare * Apply some readability-simplify-boolean-expr * Apply some readability-make-member-function-const * Apple some bugprone-macro-parentheses * Changed an f suffix to L for `long double` * Applied some readability-uppercase-literal-suffix automatically * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Dana Robinson

commit sha e9765e6c09de2e278e2821faef656b6d61854196

Move pwd header check to alphabetical order (#954)

view details

Sean McBride

commit sha 131402a92de9bbd5df60d5859c37c4820c60d6b9

More various warnings (#958) * Committing clang-format changes * Fixed various -Wdouble-promotion warnings * Fixed -Wshadow warning for `optopt` conflict On macOS at least, there is a global various named `optopt` in unistd.h. * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Scot Breitenfeld

commit sha 794acf489fa093a3a119723c7cea74cb2880624b

Fixed failure on BE with xlf (#968) * fixed missed closing of a dataset * fixed missed closing of a dataset * fixed typo in error return * Committing clang-format changes * minor edits * code format * Committing clang-format changes * code format * minor edit * switched from using MPI_count, to actual bytes written for H5FD_mpio_debug rw debugging * Committing clang-format changes * changed size_i in printf to reflect the I/O. * Committing clang-format changes * Fixed seg fault with xlf on BE with -qintsize=8 Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Scot Breitenfeld

commit sha 01fe2549a36d7635b2cbe6f6a57cbcce29c1335b

Rework of PR #826 (#972) * H5Fget_name_f fixed to handle correctly trailing whitespaces and newly allocated buffers. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Gerd Heber

commit sha cf25524474a4012a70cc2bdb6eaddc402b5ea136

A batch of life-cycle examples for different modules (#654) * Create a tag file for permalinks. * Added DOXYGEN_TAG_FILE. * Added Doxygen life-cycle examples for different modules. Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

view details

Allen Byrne

commit sha 6d15c45225e6b5202a4c1cfba2587ec0021de666

Synch CMake doxygen options with autotools configure (#983)

view details

push time in 2 days

PullRequestReviewEvent

push eventjhendersonHDF/vol-daos

Mohamad Chaarawi

commit sha 4d5fdacce8025642f043449d8abee2a2c89bf66b

Add env variable HDF5_DAOS_OBJ_CLASS for setting a runtime default object class. (#20) also rename env variables to have HDF5 prefix. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>

view details

jhendersonHDF

commit sha a14117665d322bab565c30878fe615ff8160a8ff

Init cleanup (#19) Rework connector initialization and termination Removes H5daos_init and H5daos_term, leaving H5Pset_fapl_daos() as the sole function for explicitly enabling access to the DAOS VOL connector. With the removal of H5daos_term(), connector termination is now always deferred to HDF5 library shutdown. The ability to dynamically load the connector via the HDF5_VOL_CONNECTOR environment variable remains unchanged. Remove remaining DAOS pool-related globals Remove DAOS SVCL parameter from public API For compatibility with DAOS 1.0, the SVCL can still be set via the DAOS_SVCL environment variable Remove MPI parameters from H5Pset_fapl_daos Update VOL test submodule

view details

Jerome Soumagne

commit sha 4cc642f3c895be45e7e80845d36efa5f1124df62

Testing: fixes for daos 1.1.4 (#21) * Testing: fixes for daos 1.1.4 * Testing: fix jelly hdf5 version

view details

Jerome Soumagne

commit sha 717dd516bea1f4e7e5d19707c7f64505bb1db457

doc: updates to user's guide

view details

Jerome Soumagne

commit sha d61e8284bdb01d7dd6118c1d9c41f2974f218cbb

v1.1.0rc3

view details

Mohamad Chaarawi

commit sha 34db47e61d48988458a251af7148f15b1ecec8b8

remove unneeded cart headers Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>

view details

Brian J. Murrell

commit sha bc2234f5de678fc1125683e271ffb8ea515115e9

DER_EVICTED has been renamed DER_EXCLUDED In https://github.com/daos-stack/daos/commit/fe6c2f2d33502f4410dc332207e0f23679e5d26d DER_EVICTED was renamed DER_EXCLUDED. This commit makes the corresponding change. But it allows either DER_EXCLUDED and DER_EVICTED so that users can continue to use current and previous versions of DAOS. Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>

view details

Mohamad Chaarawi

commit sha 5eed612db03458c1b21e18f13fa2d1cb51e96193

memset the duns struct to 0 to initialize unused flags. Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>

view details

Mohamad Chaarawi

commit sha 0c6df99cb3a700fc4d9b6d4f6becfa51f5bdd818

proper fix for DER_EVICTED -> DER_EXCLUDED rename Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>

view details

push time in 3 days

Pull request review commentHDFGroup/hdf5

VFD ctl feature

 H5FD_unlock(H5FD_t *file)     FUNC_LEAVE_NOAPI(ret_value) } /* end H5FD_unlock() */ +/*-------------------------------------------------------------------------+ * Function:    H5FDctl+ *+ * Purpose:     Perform a CTL operation.+ *+ *              The desired operation is specified by the op_code+ *              parameter.+ *+ *              The flags parameter controls management of op_codes that+ *              are unknown to the callback+ *+ *              The input and output parameters allow op_code specific+ *              input and output+ *+ * Return:      Non-negative on success/Negative on failure+ *+ * Programmer:  JRM -- 8/3/21+ *+ *-------------------------------------------------------------------------+ */+herr_t+H5FDctl(H5FD_t *file, uint64_t op_code, uint64_t flags, const void *input, void **output)+{+    herr_t ret_value = SUCCEED; /* Return value */++    FUNC_ENTER_API(FAIL)+    H5TRACE5("e", "*#ULUL*x**x", file, op_code, flags, input, output);++    /* Check arguments */+    if (!file)+        HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "file pointer cannot be NULL")++    if (!file->cls)+        HGOTO_ERROR(H5E_ARGS, H5E_BADVALUE, FAIL, "file class pointer cannot be NULL")++    /* Don't attempt to validate the op code.  If appropriate, that will+     * be done by the underlying VFD callback, along with the input and+     * output parameters.+     */

Maybe misread as "Don't forget (attempt) to validate the op code" here? It seems appropriate since it's explaining why we don't validate the op code at this point.

jhendersonHDF

comment created time in 7 days

PullRequestReviewEvent

push eventjhendersonHDF/hdf5

Jordan Henderson

commit sha a85e6fb557102dc47d48c69baed3baa2d908a09f

Remove handling of passthrough "ctl" flag from multi VFD

view details

push time in 9 days

push eventjhendersonHDF/hdf5

Jordan Henderson

commit sha 2969dc1e9b046227092681a348553549d52dd8d6

Remove handling of passthrough "ctl" flag from multi VFD

view details

push time in 9 days

Pull request review commentHDFGroup/hdf5

VFD ctl feature

 H5FD_multi_delete(const char *filename, hid_t fapl_id) } /* end H5FD_multi_delete() */ H5_MULTI_GCC_DIAG_ON("format-nonliteral") +/*-------------------------------------------------------------------------+ * Function:    H5FD_multi_ctl+ *+ * Purpose:     Multi VFD version of the ctl callback.+ *+ *              The desired operation is specified by the op_code+ *              parameter.+ *+ *              The flags parameter controls management of op_codes that+ *              are unknown to the callback+ *+ *              The input and output parameters allow op_code specific+ *              input and output+ *+ *              At present, this VFD supports no op codes of its own and+ *              simply passes ctl calls on to each member VFD.+ *+ * Return:      Non-negative on success/Negative on failure+ *+ *-------------------------------------------------------------------------+ */+static herr_t+H5FD_multi_ctl(H5FD_t *_file, uint64_t op_code, uint64_t flags, const void *input, void **output)

Hmm, based just on the definition from H5FDpublic.h, then yes I can see how we could consider the splitter VFD as being the only passthrough VFD. Intuitively though, it seems to me like VFDs which use the public versions of certain H5FD calls (H5FDopen/H5FDread/H5FDwrite, etc.) could be considered as passthrough VFDs. However, if our current definitions do not consider the multi VFD to be a passthrough VFD, then I should either modify its ctl callback to not handle the "route to terminal VFD" flag, or remove the callback altogether.

jhendersonHDF

comment created time in 16 days

PullRequestReviewEvent

Pull request review commentHDFGroup/hdf5

VFD ctl feature

 H5FD_multi_delete(const char *filename, hid_t fapl_id) } /* end H5FD_multi_delete() */ H5_MULTI_GCC_DIAG_ON("format-nonliteral") +/*-------------------------------------------------------------------------+ * Function:    H5FD_multi_ctl+ *+ * Purpose:     Multi VFD version of the ctl callback.+ *+ *              The desired operation is specified by the op_code+ *              parameter.+ *+ *              The flags parameter controls management of op_codes that+ *              are unknown to the callback+ *+ *              The input and output parameters allow op_code specific+ *              input and output+ *+ *              At present, this VFD supports no op codes of its own and+ *              simply passes ctl calls on to each member VFD.+ *+ * Return:      Non-negative on success/Negative on failure+ *+ *-------------------------------------------------------------------------+ */+static herr_t+H5FD_multi_ctl(H5FD_t *_file, uint64_t op_code, uint64_t flags, const void *input, void **output)

This is interesting; is there an example of what API calls the multi driver doesn't pass down? It seems as though it passes all VFD calls down to all of its underlying member VFDs.

jhendersonHDF

comment created time in 16 days

PullRequestReviewEvent

push eventjhendersonHDF/hdf5

Jordan Henderson

commit sha 532fd70dd747aa8597e4fd6a072323775a39d131

Use H5FDopen with H5F_ACC_RDWR flag instead of H5F_ACC_TRUNC in vfd test

view details

push time in 17 days

Pull request review commentHDFGroup/hdf5

VFD ctl feature

 H5FD__sec2_delete(const char *filename, hid_t H5_ATTR_UNUSED fapl_id) done:     FUNC_LEAVE_NOAPI(ret_value) } /* end H5FD__sec2_delete() */++/*-------------------------------------------------------------------------+ * Function:    H5FD__sec2_ctl+ *+ * Purpose:     Sec2 VFD version of the ctl callback.+ *+ *              The desired operation is specified by the op_code+ *              parameter.+ *+ *              The flags parameter controls management of op_codes that+ *              are unknown to the callback+ *+ *              The input and output parameters allow op_code specific+ *              input and output+ *+ *              At present, no op codes are supported by this VFD.+ *+ * Return:      Non-negative on success/Negative on failure+ *+ *-------------------------------------------------------------------------+ */+static herr_t+H5FD__sec2_ctl(H5FD_t *_file, uint64_t op_code, uint64_t flags, const void H5_ATTR_UNUSED *input,+               void H5_ATTR_UNUSED **output)

Though this callback only handles the H5FD_CTL__TEST_OPCODE op code, I figured it would be good to have a ctl callback implemented in the default VFD for testing purposes.

jhendersonHDF

comment created time in 17 days

PullRequestReviewEvent

Pull request review commentHDFGroup/hdf5

VFD ctl feature

  */ #define H5FD_FEAT_DEFAULT_VFD_COMPATIBLE 0x00008000 +/* ctl function definitions: */+#define H5FD_CTL_OPC_RESERVED 512 /* Opcodes below this value are reserved for library use */+#define H5FD_CTL_OPC_EXPER_MIN                                                                               \+    H5FD_CTL_OPC_RESERVED /* Minimum opcode value available for experimental use                             \+                           */+#define H5FD_CTL_OPC_EXPER_MAX                                                                               \+    (H5FD_CTL_OPC_RESERVED + 511) /* Maximum opcode value available for experimental use */++/* ctl function op codes: */+#define H5FD_CTL__INVALID_OPCODE              0+#define H5FD_CTL__TEST_OPCODE                 1

Here, I added a reserved op code for testing purposes so that we can have a valid op code to test using a serial test. Otherwise, the only valid op codes applied only to the MPI I/O VFD.

jhendersonHDF

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentHDFGroup/hdf5

VFD ctl feature

 H5FD_multi_delete(const char *filename, hid_t fapl_id) } /* end H5FD_multi_delete() */ H5_MULTI_GCC_DIAG_ON("format-nonliteral") +/*-------------------------------------------------------------------------+ * Function:    H5FD_multi_ctl+ *+ * Purpose:     Multi VFD version of the ctl callback.+ *+ *              The desired operation is specified by the op_code+ *              parameter.+ *+ *              The flags parameter controls management of op_codes that+ *              are unknown to the callback+ *+ *              The input and output parameters allow op_code specific+ *              input and output+ *+ *              At present, this VFD supports no op codes of its own and+ *              simply passes ctl calls on to each member VFD.+ *+ * Return:      Non-negative on success/Negative on failure+ *+ *-------------------------------------------------------------------------+ */+static herr_t+H5FD_multi_ctl(H5FD_t *_file, uint64_t op_code, uint64_t flags, const void *input, void **output)

@jrmainzer The terminology for what constitutes a terminal vs passthrough VFD seemed to get a little bit fuzzy for certain VFDs. At first, it seemed like the splitter VFD was really the only passthrough VFD that we currently have. However, the multi VFD also seems like it might fit the bill, so I went ahead and implemented the ctl function here as though the multi VFD were a passthrough VFD. If that's not the case, I'm happy to change it back/remove the ctl callback from the multi VFD.

jhendersonHDF

comment created time in 17 days

push eventjhendersonHDF/hdf5

Jordan Henderson

commit sha 709eb4d79c74580d99deafacb918a107732f0aec

Add RELEASE.txt entry for "ctl" callback

view details

push time in 17 days

PR opened HDFGroup/hdf5

Reviewers
VFD ctl feature
+961 -170

0 comment

21 changed files

pr created time in 17 days

push eventjhendersonHDF/hdf5

Jordan Henderson

commit sha 09f518318797e91577d2749610fb8f0ad4a1fb7d

Add "ctl" callbacks to passthrough VFDs

view details

Jordan Henderson

commit sha 43dcae7f5616b9ed439da4b4de7a4bcf88bd798f

Add RELEASE.txt entry for "ctl" callback

view details

push time in 17 days

create barnchjhendersonHDF/hdf5

branch : VFD_ctl_feature

created branch time in 17 days

PullRequestReviewEvent

create barnchjhendersonHDF/vol-tests

branch : vol_tests_error_fix

created branch time in 24 days

Pull request review commentHDFGroup/hdf5

Correct dataset close in java test

 #define MPICH_SKIP_MPICXX 1 #endif #ifndef OMPI_SKIP_MPICXX-#define OMPI_SKIP_MPICXX  1+#define OMPI_SKIP_MPICXX 1

Looks like this change is getting pulled into different PRs?

byrnHDF

comment created time in a month