profile
viewpoint
Jérôme Gamez jeromegamez Bonn https://www.gamez.name French name, German accent.

jeromegamez/firebase-php-examples 62

Example Firebase Symfony application using the Firebase PHP Admin SDK

jeromegamez/ansible-macos-playbook 38

macOs setup and configuration via Ansible.

jeromegamez/duration-php 35

Working with durations made easy

jeromegamez/cookiecutter-php 4

Cookiecutter template for new PHP projects.

jeromegamez/clock-poc 1

Proof of concept for the proposed clock PSR

jeromegamez/flysystem-google-storage 1

Flysystem Adapter for Google Cloud Storage

jeromegamez/android-mapbox-search-dependabot 0

Please ignore, only used to showcase a potential/unverified issue with Dependabot and private maven repositories.

jeromegamez/ansible-role-docker 0

Ansible Role - Docker

jeromegamez/ansible-role-java 0

Ansible Role - Java.

push eventbeste/jmikola-geojson

Jeremy Mikola

commit sha f5b122e15c804fabc5881da214c57d52ea0c5715

Revert "properties default array", which broke tests This reverts commit b8bcafa33a836a501205d9e64fa38fd479e23c94.

view details

Jérôme Gamez

commit sha 245f886610096a8fb842e04e69c13c9cac8125fb

Drop support for PHP <7.4 and update PHPUnit to ~9.5 The changes to the tests only make them run with the latest PHPUnit version and does not address failing tests.

view details

Jérôme Gamez

commit sha db9276d4b3aeca4cc6be81f2034adfcabab9d751

Re-enable `Feature`s to have `properties` with a null value. This reverts the change in the constructor introduced in https://github.com/jmikola/geojson/pull/24, since it broke the tests. According to https://www.rfc-editor.org/rfc/rfc7946#section-3.2, the `properties` member is an object (associative array), or null.

view details

Jérôme Gamez

commit sha 71a394121e36ae84bc8a21b04c4fa3f5f928446f

Remove `JsonSerializable` stub

view details

Jérôme Gamez

commit sha ea827f5d7832e3fc02b0892b6bbe852357210a00

Remove API Documentation apigen hasn't seen updates for newer PHP versions in a long time. Downloading the code and exloring it in one's favorite editor and/or directly on GitHub should™ be easy enough nowadays.

view details

Jérôme Gamez

commit sha 0053b4418c5b5205f1f6803f7ff9a1370c24717d

Update MkDocs config The spacelab theme isn't included by default anymore, and I couldn't find it elsewhere.

view details

Jérôme Gamez

commit sha 6549c13e97f07a9f5ee62ae228fd7f8d26b4f8ad

Transfer Travis CI configuration to GitHub Actions

view details

Jérôme Gamez

commit sha cc4c99083ba79bbbe8b49b484091278059ce03a4

Add return types to methods implementing interfaces This prevents errors like > Return type of {method} should either be compatible with {method}, > or the #[\ReturnTypeWillChange] attribute should be used to > temporarily suppress the notice

view details

Jérôme Gamez

commit sha bd119b2699047d981ed4af26864003d3eab7fc80

Upload code coverage only if in source repository

view details

Jeremy Mikola

commit sha 2d37409c59e70b3941aaba7e80a6391ad10ada7b

Change requirement syntax and bump master alias to 1.1-dev

view details

Jeremy Mikola

commit sha 8161748db30f971260d50c37f29b566bfccd5620

Label CI steps and only test lowest deps on PHP 7.4

view details

Jeremy Mikola

commit sha 4f37af3213996a619edc6b02518fb3311aed538a

Replace ocular.phar with dev dependency This should address failing CI builds on PHP 8 (see: scrutinizer-ci/ocular#51)

view details

Jeremy Mikola

commit sha 53f265c75dc9246cc9fdc8c90918b1a01ee43ff1

Bump license date

view details

Jeremy Mikola

commit sha 8b3eb745f8416c976ae27d26305ffa98b5b1d12a

Increase checkout depth to address ocular failure (#32)

view details

Jeremy Mikola

commit sha a85abb6bf7287b904a1fd908124f63c31efb5da2

Move docs to USAGE.md and update README This also removes the mkdocs configuration and obsolete Makefile. The gh-pages branch has also been deleted.

view details

Jeremy Mikola

commit sha cd480967abde94ec218f9bcc8e777cc1d9454028

Remove references to PHP 5.x in docs

view details

push time in 2 hours

push eventbeste/jmikola-geojson

Jeremy Mikola

commit sha f5b122e15c804fabc5881da214c57d52ea0c5715

Revert "properties default array", which broke tests This reverts commit b8bcafa33a836a501205d9e64fa38fd479e23c94.

view details

Jérôme Gamez

commit sha 245f886610096a8fb842e04e69c13c9cac8125fb

Drop support for PHP <7.4 and update PHPUnit to ~9.5 The changes to the tests only make them run with the latest PHPUnit version and does not address failing tests.

view details

Jérôme Gamez

commit sha db9276d4b3aeca4cc6be81f2034adfcabab9d751

Re-enable `Feature`s to have `properties` with a null value. This reverts the change in the constructor introduced in https://github.com/jmikola/geojson/pull/24, since it broke the tests. According to https://www.rfc-editor.org/rfc/rfc7946#section-3.2, the `properties` member is an object (associative array), or null.

view details

Jérôme Gamez

commit sha 71a394121e36ae84bc8a21b04c4fa3f5f928446f

Remove `JsonSerializable` stub

view details

Jérôme Gamez

commit sha ea827f5d7832e3fc02b0892b6bbe852357210a00

Remove API Documentation apigen hasn't seen updates for newer PHP versions in a long time. Downloading the code and exloring it in one's favorite editor and/or directly on GitHub should™ be easy enough nowadays.

view details

Jérôme Gamez

commit sha 0053b4418c5b5205f1f6803f7ff9a1370c24717d

Update MkDocs config The spacelab theme isn't included by default anymore, and I couldn't find it elsewhere.

view details

Jérôme Gamez

commit sha 6549c13e97f07a9f5ee62ae228fd7f8d26b4f8ad

Transfer Travis CI configuration to GitHub Actions

view details

Jérôme Gamez

commit sha cc4c99083ba79bbbe8b49b484091278059ce03a4

Add return types to methods implementing interfaces This prevents errors like > Return type of {method} should either be compatible with {method}, > or the #[\ReturnTypeWillChange] attribute should be used to > temporarily suppress the notice

view details

Jérôme Gamez

commit sha bd119b2699047d981ed4af26864003d3eab7fc80

Upload code coverage only if in source repository

view details

Jeremy Mikola

commit sha 2d37409c59e70b3941aaba7e80a6391ad10ada7b

Change requirement syntax and bump master alias to 1.1-dev

view details

Jeremy Mikola

commit sha 8161748db30f971260d50c37f29b566bfccd5620

Label CI steps and only test lowest deps on PHP 7.4

view details

Jeremy Mikola

commit sha 4f37af3213996a619edc6b02518fb3311aed538a

Replace ocular.phar with dev dependency This should address failing CI builds on PHP 8 (see: scrutinizer-ci/ocular#51)

view details

Jeremy Mikola

commit sha 53f265c75dc9246cc9fdc8c90918b1a01ee43ff1

Bump license date

view details

Jeremy Mikola

commit sha 8b3eb745f8416c976ae27d26305ffa98b5b1d12a

Increase checkout depth to address ocular failure (#32)

view details

Jeremy Mikola

commit sha a85abb6bf7287b904a1fd908124f63c31efb5da2

Move docs to USAGE.md and update README This also removes the mkdocs configuration and obsolete Makefile. The gh-pages branch has also been deleted.

view details

Jeremy Mikola

commit sha cd480967abde94ec218f9bcc8e777cc1d9454028

Remove references to PHP 5.x in docs

view details

push time in 2 hours

create barnchbeste/jmikola-geojson

branch : 1.1

created branch time in 2 hours

delete branch beste/jmikola-geojson

delete branch : pre-1.1

delete time in 2 hours

starteddaltonmenezes/aura-theme

started time in 2 hours

delete branch beste/jmikola-geojson

delete branch : 1.1

delete time in 3 hours

push eventbeste/jmikola-geojson

Jérôme Gamez

commit sha 6d5f4d72f9ef341659905f81542b45dd8dd0fe53

Add return types to methods implementing interfaces This prevents errors like > Return type of {method} should either be compatible with {method}, > or the #[\ReturnTypeWillChange] attribute should be used to > temporarily suppress the notice

view details

Jérôme Gamez

commit sha 85f5b146fed1a1e5b86d5e4f1f80be808863b9fb

Upload code coverage only if in source repository

view details

push time in 11 hours

issue openedtom-james-watson/wikitrivia

🤩 Love it!

Not exactly an issue, but an easy one to slap a "Won't fix" label onto.

Thank you! 🥰

created time in 13 hours

startedtom-james-watson/wikitrivia

started time in 13 hours

Pull request review commentjmikola/geojson

Drop support for PHP <7.4, update PHPUnit to ~9.5, migrate to GitHub Actions

 site_name: "GeoJSON PHP library" repo_url: https://github.com/jmikola/geojson-theme: spacelab-pages:-    - [index.md, Home]+theme: readthedocs+nav:+    - Home: index.md

If you'd like, I can do it in a subsequent PR (I would like to do some more cleanups and quality of life improvements in other PRs, if you have the time and headspace to review them 🤞)

jeromegamez

comment created time in a day

PullRequestReviewEvent

delete branch beste/jmikola-geojson

delete branch : gh-pages

delete time in a day

push eventbeste/jmikola-geojson

Jérôme Gamez

commit sha 2bcb3d9e8aba23e576c95df33a81905f40dccf56

Deployed e098f33 with MkDocs version: 1.2.3

view details

push time in a day

Pull request review commentjmikola/geojson

Drop support for PHP <7.4, update PHPUnit to ~9.5, migrate to GitHub Actions

 class Feature extends GeoJson     protected $geometry;      /**-     * Properties are a JSON object, which corresponds to an associative array.+     * Properties are a JSON object, which corresponds to an associative array, or null.      *-     * @var array+     * @see https://www.rfc-editor.org/rfc/rfc7946#section-3.2

I quickly created a branch with only those commits that update the dependencies and move to GH actions, so that you can see it in… action - apparently, the problem doesn't just occur in PHP 8.1 🙈

https://github.com/beste/jmikola-geojson/runs/4877118084

jeromegamez

comment created time in a day

PullRequestReviewEvent

pull request commentjmikola/geojson

Drop support for PHP <7.4, update PHPUnit to ~9.5, migrate to GitHub Actions

I just added a commit that prevents the upload of the code coverage report when not in this repository.

It's possible that you'd have to activate the actions on https://github.com/jmikola/geojson/settings/actions so that they can run on this PR - if you want to have a look beforehand, here is a (now) successful run on my fork: beste/jmikola-geojson/actions/runs/1721431686

jeromegamez

comment created time in a day

create barnchbeste/jmikola-geojson

branch : pre-1.1

created branch time in a day

push eventbeste/jmikola-geojson

Jérôme Gamez

commit sha e098f334046898c5046fce474fcc2f76d92d34d1

Upload code coverage only if in source repository

view details

push time in a day

push eventbeste/jmikola-geojson

Jérôme Gamez

commit sha 104d67358ae5c7369ac25daebf369aa079e9011c

Drop support for PHP <7.4 and update PHPUnit to ~9.5 The changes to the tests only make them run with the latest PHPUnit version and does not address failing tests.

view details

Jérôme Gamez

commit sha 69105034c383373d6144e932492f333f26b05477

Re-enable `Feature`s to have `properties` with a null value. This reverts the change in the constructor introduced in https://github.com/jmikola/geojson/pull/24, since it broke the tests. According to https://www.rfc-editor.org/rfc/rfc7946#section-3.2, the `properties` member is an object (associative array), or null.

view details

Jérôme Gamez

commit sha 84c123631eabc7d73557eb536f0187c8b7c2c33e

Remove `JsonSerializable` stub

view details

Jérôme Gamez

commit sha c06c1fa73e504810388081926f67500cc8918d54

Remove API Documentation apigen hasn't seen updates for newer PHP versions in a long time. Downloading the code and exloring it in one's favorite editor and/or directly on GitHub should™ be easy enough nowadays.

view details

Jérôme Gamez

commit sha 14ba123955aa9f77aa7d95f96d7d2014a1ff0072

Update MkDocs config The spacelab theme isn't included by default anymore, and I couldn't find it elsewhere.

view details

Jérôme Gamez

commit sha 02ff9c1fda355803559545a19c3f4d60dd7e9d35

Transfer Travis CI configuration to GitHub Actions

view details

Jérôme Gamez

commit sha 969044a2ac71cdfe45d2d75500a7c2f20664b6dd

Add return types to methods implementing interfaces This prevents errors like > Return type of {method} should either be compatible with {method}, > or the #[\ReturnTypeWillChange] attribute should be used to > temporarily suppress the notice

view details

push time in a day

Pull request review commentjmikola/geojson

Drop support for PHP <7.4, update PHPUnit to ~9.5, migrate to GitHub Actions

 public function getGeometries()     /**      * @see http://php.net/manual/en/iteratoraggregate.getiterator.php      */-    public function getIterator()+    public function getIterator(): \ArrayIterator

Good point! Fixed! ✅

jeromegamez

comment created time in a day

PullRequestReviewEvent

Pull request review commentjmikola/geojson

Drop support for PHP <7.4, update PHPUnit to ~9.5, migrate to GitHub Actions

 public function testSerializationWithCrsAndBoundingBox()          $box->expects($this->any())             ->method('jsonSerialize')-            ->will($this->returnValue('boundingBox'));+            ->will($this->returnValue(['boundingBox']));          $crs->expects($this->any())             ->method('jsonSerialize')-            ->will($this->returnValue('coordinateReferenceSystem'));+            ->will($this->returnValue(['coordinateReferenceSystem']));          $sut = $this->createSubjectWithExtraArguments(array($box, $crs));          $json = $sut->jsonSerialize();          $this->assertArrayHasKey('bbox', $json);         $this->assertArrayHasKey('crs', $json);-        $this->assertSame('boundingBox', $json['bbox']);-        $this->assertSame('coordinateReferenceSystem', $json['crs']);+        $this->assertSame(['boundingBox'], $json['bbox']);+        $this->assertSame(['coordinateReferenceSystem'], $json['crs']);

Yes, it's exactly as you describe it!

jeromegamez

comment created time in a day

PullRequestReviewEvent

Pull request review commentjmikola/geojson

Drop support for PHP <7.4, update PHPUnit to ~9.5, migrate to GitHub Actions

 public function testConstructorShouldAcceptEquivalentPointObjectsAndPositionArra             array(3, 3),             new Point(array(1, 1)),         ));++        $this->addToAssertionCount(1);

Yes, indeed! I've updated the test as you suggested ✅

jeromegamez

comment created time in a day

PullRequestReviewEvent

Pull request review commentjmikola/geojson

Drop support for PHP <7.4, update PHPUnit to ~9.5, migrate to GitHub Actions

 class Feature extends GeoJson     protected $geometry;      /**-     * Properties are a JSON object, which corresponds to an associative array.+     * Properties are a JSON object, which corresponds to an associative array, or null.      *-     * @var array+     * @see https://www.rfc-editor.org/rfc/rfc7946#section-3.2

Yes, that's the section! When I ran the tests after updating the dependencies (the first commit), these were the relevant errors:

<details> <summary>CLI Output</summary>

❯ php -v
PHP 8.1.1 (cli) (built: Dec 15 2021 09:54:28) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.1, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.1, Copyright (c), by Zend Technologies
    with Xdebug v3.1.2, Copyright (c) 2002-2021, by Derick Rethans

❯ phpunit
PHPUnit 9.5.11 by Sebastian Bergmann and contributors.

[...]

There were 4 errors:

1) GeoJson\Tests\Feature\FeatureCollectionTest::testUnserialization with data set "assoc=true" (true)
TypeError: GeoJson\Feature\Feature::__construct(): Argument #2 ($properties) must be of type array, null given

/Users/jg/Code/beste/geojson/src/GeoJson/Feature/Feature.php:43
/Users/jg/Code/beste/geojson/src/GeoJson/GeoJson.php:171
/Users/jg/Code/beste/geojson/src/GeoJson/GeoJson.php:141
/Users/jg/Code/beste/geojson/tests/GeoJson/Tests/Feature/FeatureCollectionTest.php:125
/Users/jg/Code/beste/geojson/vendor/phpunit/phpunit/phpunit:98

2) GeoJson\Tests\Feature\FeatureCollectionTest::testUnserialization with data set "assoc=false" (false)
TypeError: GeoJson\Feature\Feature::__construct(): Argument #2 ($properties) must be of type array, null given

/Users/jg/Code/beste/geojson/src/GeoJson/Feature/Feature.php:43
/Users/jg/Code/beste/geojson/src/GeoJson/GeoJson.php:171
/Users/jg/Code/beste/geojson/src/GeoJson/GeoJson.php:141
/Users/jg/Code/beste/geojson/tests/GeoJson/Tests/Feature/FeatureCollectionTest.php:125
/Users/jg/Code/beste/geojson/vendor/phpunit/phpunit/phpunit:98

3) GeoJson\Tests\Feature\FeatureTest::testConstructorShouldScanExtraArgumentsForCrsAndBoundingBox
TypeError: GeoJson\Feature\Feature::__construct(): Argument #2 ($properties) must be of type array, null given

/Users/jg/Code/beste/geojson/src/GeoJson/Feature/Feature.php:43
/Users/jg/Code/beste/geojson/tests/GeoJson/Tests/Feature/FeatureTest.php:15
/Users/jg/Code/beste/geojson/tests/GeoJson/Tests/BaseGeoJsonTest.php:16
/Users/jg/Code/beste/geojson/vendor/phpunit/phpunit/phpunit:98

4) GeoJson\Tests\Feature\FeatureTest::testSerializationWithCrsAndBoundingBox
TypeError: GeoJson\Feature\Feature::__construct(): Argument #2 ($properties) must be of type array, null given

/Users/jg/Code/beste/geojson/src/GeoJson/Feature/Feature.php:43
/Users/jg/Code/beste/geojson/tests/GeoJson/Tests/Feature/FeatureTest.php:15
/Users/jg/Code/beste/geojson/tests/GeoJson/Tests/BaseGeoJsonTest.php:55
/Users/jg/Code/beste/geojson/vendor/phpunit/phpunit/phpunit:98

--

There was 1 failure:

1) GeoJson\Tests\Feature\FeatureTest::testSerializationWithNullConstructorArguments
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
     'type' => 'Feature'
     'geometry' => null
-    'properties' => null
+    'properties' => stdClass Object &00000000000003a50000000000000000 ()
 )

/Users/jg/Code/beste/geojson/tests/GeoJson/Tests/Feature/FeatureTest.php:60
/Users/jg/Code/beste/geojson/vendor/phpunit/phpunit/phpunit:98

ERRORS!
Tests: 128, Assertions: 389, Errors: 4, Failures: 1.

</details>

I first changed the signature so that it would allow null:

- public function __construct(Geometry $geometry = null, array $properties = array(), $id = null)
+ public function __construct(Geometry $geometry = null, ?array $properties = array(), $id = null)

That fixed the 4 errors, but the failure remained - with the properties defaulting to an empty array, jsonSerialize() converts it to a stdClass

https://github.com/jmikola/geojson/blob/980408cc70cd7d5f043f917d827dcc40d7470202/src/GeoJson/Feature/Feature.php#L95-L97

We could, of course, replace the new \stdClass with null, but I thought the change in #24 shouldn't have broken the tests in the first place 😅.

jeromegamez

comment created time in a day

PullRequestReviewEvent

startedbeste/latlon-geohash-php

started time in 2 days

push eventbeste/latlon-geohash-php

Jérôme Gamez

commit sha d41c9a9795c85fee0ce60256cd3988f8edfd6c51

Remove unnecessary check

view details

push time in 2 days

push eventbeste/latlon-geohash-php

Jérôme Gamez

commit sha 6799c614e07396fd134abe083aa5832b895ed2fa

Add PHP 7.4 to the test matrix

view details

push time in 2 days

more