profile
viewpoint
Jérémy Romey jeremyFreeAgent @alximy Paris http://jeremy.free-agent.fr Tony Danza @ alximy

jeremyFreeAgent/Bitter 130

Bitter is a simple but powerful analytics library

gnugat-legacy/wizard-plugin 4

[DEPRECATED] use Symfony Flex instead - Automagically launches GnugatWizardBundle after a `composer require` command

jeremyFreeAgent/bitter.free-agent.fr 1

Bitter website source

jeremyFreeAgent/composer 1

Dependency Manager for PHP

jeremyFreeAgent/DoctrineExtensions 1

Extensions and diferent behaviors for Doctrine 2, Translatable, Sluggable, Tree - NestedSet, Timestampable, Loggable

jeremyFreeAgent/guard-ctags-composer 1

Guard gem for generating ctags for project files and gems from project's bundle.

jeremyFreeAgent/homebrew-alt 1

Alternate formulae repos for Homebrew

jeremyFreeAgent/homebrew-php 1

PHP formulae repo for Homebrew

startedRaathigesh/majestic

started time in 9 days

startedddd-crew/ddd-starter-modelling-process

started time in 10 days

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 45683cd887eb8b0bae8d7f79c4e0e48adaf11008

Update version to 5.2

view details

push time in 16 days

startedkyleneideck/BackgroundMusic

started time in 16 days

startedOrbitale/DoctrineTools

started time in 20 days

startedddd-crew/core-domain-charts

started time in 22 days

pull request commentsymfony/symfony

Add Notifier SentMessage

Does it still relevant for 5.1?

jeremyFreeAgent

comment created time in 24 days

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 40a5c811a55340c1239c129dfd49f1ad1ace70e6

Remove TransportResponseData

view details

Jérémy Romey

commit sha a7e8b9b6d57cf80b28038eb1a4b9163a69652546

Update transports

view details

push time in a month

Pull request review commentsymfony/symfony

Add Notifier SentMessage

 protected function doSend(MessageInterface $message): void                 throw new TransportException(sprintf('Unable to send the SMS: '.$msg['error-text'].' (%s).', $msg['status']), $response);             }         }++        $success = $response->toArray(false);++        $message = new SentMessage($message);+        $message->setMessageId($success['messages'][0]['message-id']);+        $message->setTransportResponseData($success);

Yes exactly. Most of the services have webhook or API to get the other information parts.

Thanks.

jeremyFreeAgent

comment created time in a month

Pull request review commentsymfony/symfony

Add Notifier SentMessage

 protected function doSend(MessageInterface $message): void                 throw new TransportException(sprintf('Unable to send the SMS: '.$msg['error-text'].' (%s).', $msg['status']), $response);             }         }++        $success = $response->toArray(false);++        $message = new SentMessage($message);+        $message->setMessageId($success['messages'][0]['message-id']);+        $message->setTransportResponseData($success);

Yes, you are right.

The only real common thing is the message-id. The other data parts depend on :

  • the kind of message (chat or SMS)
  • the service (some returns cost for SMS, number of SMS sent for the message)

I think we can start with:

  • original message (in the construct)
  • transport __toString() (in the construct)
  • message-id (with setter if returned)
jeremyFreeAgent

comment created time in a month

create barnchjeremyFreeAgent/symfony-docs

branch : notifier-sent-message

created branch time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 880e111c57cf32d5ad30977d53daf375c64567bb

Fix missing use

view details

push time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 3caa05f6ebd0b966b3a586add2e59d6e2ac63d00

Update Chatter and Texter send()

view details

push time in a month

PR opened symfony/symfony-docs

[Notifier] Add Infobip
+2 -1

0 comment

1 changed file

pr created time in a month

push eventjeremyFreeAgent/symfony-docs

Jérémy Romey

commit sha 16883e286e62765cbdaccaf2902e69e5d3f2653e

[Notifier] Add Infobip

view details

push time in a month

Pull request review commentsymfony/symfony

Add Notifier SentMessage

 protected function doSend(MessageInterface $message): void         if (200 !== $response->getStatusCode()) {             $errorMessage = $jsonContents ? $jsonContents['results']['error'] : $response->getContent(false); -            throw new TransportException(sprintf('Unable to post the Firebase message: %s.', $errorMessage), $response);+            throw new TransportException(sprintf('Unable to post the Firebase message: "%s".', $errorMessage), $response);

Done!

jeremyFreeAgent

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha f73c8a91bc96f9300a12acc8701183cbd6c83964

Revert ":pill: Fix CS" This reverts commit c4eaa9707915d97edef2323c25e91eba491c83c8.

view details

push time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha f35c849bfba735144b3389f752d1d779fd3d8bed

Revert "Fix CS" This reverts commit c586ddd7f77c0107e1d3f2a9684c151d333ac8f3.

view details

push time in a month

Pull request review commentsymfony/symfony

Add Notifier SentMessage

 protected function doSend(MessageInterface $message): void         if (200 !== $response->getStatusCode()) {             $errorMessage = $jsonContents ? $jsonContents['results']['error'] : $response->getContent(false); -            throw new TransportException(sprintf('Unable to post the Firebase message: %s.', $errorMessage), $response);+            throw new TransportException(sprintf('Unable to post the Firebase message: "%s".', $errorMessage), $response);

Ok! (That was asked by fabbot.io)

jeremyFreeAgent

comment created time in a month

Pull request review commentsymfony/symfony

Add Notifier SentMessage

 protected function doSend(MessageInterface $message): void              throw new TransportException(sprintf('Unable to send the SMS: error %d: ', $response->getStatusCode()).($errors[$response->getStatusCode()] ?? ''), $response);         }++        $message = new SentMessage($message, uniqid());

I removed it from __construct then.

jeremyFreeAgent

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 1caca82a172221e3b93c9c450eb422ffc4898461

Revert add messageId in __construct()

view details

push time in a month

pull request commentsymfony/symfony

Add Notifier SentMessage

I have set uniqid() for transports that do not give back an identifier.

jeremyFreeAgent

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha c586ddd7f77c0107e1d3f2a9684c151d333ac8f3

Fix CS

view details

push time in a month

push eventjeremyFreeAgent/symfony

Michel Roca

commit sha b5d406117defbbe44006cffae06b4263dd3b9dc0

Fix profiler nullable string type

view details

Thomas Calvet

commit sha 24150370c3cad7564bed19d112fb4c8dd281d32a

[DependencyInjection][ServiceSubscriber] Support late aliases

view details

Ryan Weaver

commit sha d34b437ce0e3f6a28f3bc5bcf8d8979c972ae5da

Fixing a bug where class_alias would cause incorrect items in debug:autowiring

view details

Fabien Potencier

commit sha 22f1076375db8b603a842ba6ce5848df7140cb38

bug #36162 [Profiler] Fix profiler nullable string type (mRoca) This PR was merged into the 5.0 branch. Discussion ---------- [Profiler] Fix profiler nullable string type | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | - This PR fixes nullable string types in setter for the Profile class. The detected issue comes from [the Profiler class](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Profiler/Profiler.php#L149) : ```php $profile->setIp($request->getClientIp()); // string or null ``` The corresponding return types for the Profile getters are allready good: ```php /** * Returns the IP. * * @return string|null The IP */ public function getIp() { return $this->ip; } ``` Commits ------- b5d406117d Fix profiler nullable string type

view details

Nicolas Grekas

commit sha 119ba3b742337e5df5a286c6c0af7aeb784f6483

bug #36454 [DependencyInjection][ServiceSubscriber] Support late aliases (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection][ServiceSubscriber] Support late aliases | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - A service subscriber that references a service that is aliased after optimization passes (after ResolveReferencesToAliasesPass technically) end up being dumped with the real service and not the alias. I would consider it a bug but @nicolas-grekas told me it's a feature for him, this is why I'm submitting this on master. @nicolas-grekas, feel free to close this one and open with your solution since you definitely know the subject better. Commits ------- 24150370c3 [DependencyInjection][ServiceSubscriber] Support late aliases

view details

Tobias Schultze

commit sha 5ef9390b2fb0a480527fb274443e1163c5f827e2

remove getContainer overwrites in tests Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see https://github.com/symfony/symfony/pull/31202

view details

Nicolas Grekas

commit sha a2f0bf89d76d4783a1071ffa71c5e7014a4dd11e

minor #36522 [FrameworkBundle] remove getContainer overwrites in tests (Tobion) This PR was merged into the 5.0 branch. Discussion ---------- [FrameworkBundle] remove getContainer overwrites in tests | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | Doc PR | Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see https://github.com/symfony/symfony/pull/31202 Commits ------- 5ef9390b2f remove getContainer overwrites in tests

view details

Dimitri Gritsajuk

commit sha 3c24cfecdd3ae40ffdc4450bc2f6a9df8f18ff88

[Form] apply automatically step=1 for datetime-local input

view details

Fabien Potencier

commit sha 444e616f6b264b1bcae3078896e8e4b326d7af44

[Mailer] Add a comment to avoid more wrong PRs on this piece of code

view details

Fabien Potencier

commit sha bbbf80f60b5ae8bc7d98be75098f162f6d97d7b1

minor #36546 [Mailer] Add a comment to avoid more wrong PRs on this piece of code (fabpot) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Add a comment to avoid more wrong PRs on this piece of code | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Numerous bogus PRs <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | n/a Commits ------- 444e616f6b [Mailer] Add a comment to avoid more wrong PRs on this piece of code

view details

Nicolas Grekas

commit sha 2d7b0b8dadce16ead113091ed798603c35b22de3

bug #36519 [FrameworkBundle] debug:autowiring: Fix wrong display when using class_alias (weaverryan) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] debug:autowiring: Fix wrong display when using class_alias | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | None | License | MIT | Doc PR | not needed Imagine that `FooInterface` is an alias, but it is deprecated and so has a `class_alias` to `BarInterface`. Currently, `debug:autowiring` will actually print that's the autowiring alias is `BarInterface`, despite there being no such id in the container. @nicolas-grekas originally (on purpose) made the 2nd argument to `Descriptor::getClassDescription()` be passed by reference *for* this exact feature - https://github.com/symfony/symfony/commit/56aab09b013029d68e8442b927077898340fe6cc - but I can't figure out why. This change (which effectively removes the by-reference modifying) made no existing tests fail. Discovered this because the whole deprecated`Doctrine\Common\Persistence\ManagerRegistry` vs newer `Doctrine\Persistence\ManagerRegistry` causes the issue. Thanks! Commits ------- d34b437ce0 Fixing a bug where class_alias would cause incorrect items in debug:autowiring

view details

Nicolas Grekas

commit sha ea69f77b709fc1a58ab23f25fb2b17b3bee6fc24

bug #36523 [Form] apply automatically step=1 for datetime-local input (ottaviano) This PR was merged into the 3.4 branch. Discussion ---------- [Form] apply automatically step=1 for datetime-local input | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | ~ | License | MIT | Doc PR | this PR just reapplies the same fix from `TimeType` (https://github.com/symfony/symfony/pull/10777 thanks @tucksaun) to `DateTimeType`. ### before: ```php 'widget' => 'single_text', 'with_seconds' => true, ``` ![image](https://user-images.githubusercontent.com/4582866/79972699-a5369500-8496-11ea-8272-d43b68ff49b5.png) ### after: ```php 'widget' => 'single_text', 'with_seconds' => true, ``` ![image](https://user-images.githubusercontent.com/4582866/79972801-cbf4cb80-8496-11ea-9af5-b193445b1f1d.png) Commits ------- 3c24cfecdd [Form] apply automatically step=1 for datetime-local input

view details

Nicolas Grekas

commit sha 5a7208481d777b78ad3038d54f3e10d9a8a21397

[Cache] skip APCu in chains when the backend is disabled

view details

Massimiliano Arione

commit sha e27ed28bae708102b011c7a8c4744e01b0173d14

fix compatibility with phpunit 9

view details

Fabien Potencier

commit sha 259f523010ca171952cd6aec1b091f69cdc4bbb6

bug #36555 [Cache] skip APCu in chains when the backend is disabled (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Cache] skip APCu in chains when the backend is disabled | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34962 | License | MIT | Doc PR | - I think this should do it. Commits ------- 5a7208481d [Cache] skip APCu in chains when the backend is disabled

view details

Fabien Potencier

commit sha 719bb15c38c738f03f1a3431af08535028502e2d

bug #36539 [PhpUnitBridge] fix compatibility with phpunit 9 (garak) This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] fix compatibility with phpunit 9 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36499 | License | MIT | Doc PR | none See related issue Commits ------- e27ed28bae fix compatibility with phpunit 9

view details

sdkawata

commit sha 734d97bdccca86bc5c669713b34dc84b9855229f

[YAML] escape DEL(\x7f)

view details

Fabien Potencier

commit sha fe5eacd3a2d560178dff7c066a7d75d2472ec969

bug #36560 [YAML] escape DEL(\x7f) (sdkawata) This PR was merged into the 3.4 branch. Discussion ---------- [YAML] escape DEL(\x7f) | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36559 | License | MIT | Doc PR | none Commits ------- 734d97bdcc [YAML] escape DEL(\x7f)

view details

Laurent VOULLEMIER

commit sha 28fdb3a8797e9a908ea8b0a71bb3477d1de2545e

Allow invalidateTags calls to be traced by data collector

view details

Thomas Calvet

commit sha 6dce90d47bc8ff944d670f6b6d418efb1506fa33

[PhpUnitBridge] Use COMPOSER_BINARY env var if available

view details

push time in a month

fork jeremyFreeAgent/phpinsights

🔰 Instant PHP quality checks from your console

https://phpinsights.com

fork in a month

startednunomaduro/phpinsights

started time in a month

startedsensiolabs-de/deptrac

started time in a month

startedgoogle/triage-party

started time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 93d50f0325ce58834faf4247f5ec3954f5143b2f

Add CHANGELOG entry

view details

push time in a month

Pull request review commentsymfony/symfony

Add Notifier SentMessage

 protected function doSend(MessageInterface $message): void         if (201 !== $response->getStatusCode()) {             $error = $response->toArray(false); -            throw new TransportException(sprintf('Unable to send the SMS: '.$error['message'].' (see %s).', $error['more_info']), $response);+            throw new TransportException(sprintf('Unable to send the SMS: '.$error['message'].' (see "%s").', $error['more_info']), $response);         }++        $success = $response->toArray(false);++        $message = new SentMessage($message);+        $message->setMessageId($success['sid']);

Changed! Thanks @Koc

jeremyFreeAgent

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 7715cc3187679b1f2e89ab64cd9b28bd24d4c118

Add messageId in __construct()

view details

push time in a month

Pull request review commentsymfony/symfony

Add Notifier SentMessage

 protected function doSend(MessageInterface $message): void         if (201 !== $response->getStatusCode()) {             $error = $response->toArray(false); -            throw new TransportException(sprintf('Unable to send the SMS: '.$error['message'].' (see %s).', $error['more_info']), $response);+            throw new TransportException(sprintf('Unable to send the SMS: '.$error['message'].' (see "%s").', $error['more_info']), $response);         }++        $success = $response->toArray(false);++        $message = new SentMessage($message);+        $message->setMessageId($success['sid']);

Good idea!

jeremyFreeAgent

comment created time in a month

Pull request review commentsymfony/symfony

Add Notifier SentMessage

 interface TransportInterface     /**      * @throws TransportExceptionInterface      */-    public function send(MessageInterface $message): void;+    public function send(MessageInterface $message): SentMessage;

Yes of course. Thank you @Koc! I wanted some feedback about the how before.

jeremyFreeAgent

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha c4c798f5fd2ab43d263ec6636d964f794a777c78

:pill: Fix attribute

view details

push time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 65b542705fee405a2d096eb51f2900998e89fff8

:pill: Fix CS

view details

push time in a month

PR opened symfony/symfony

Add Notifier SentMessage
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

Like Mailer, Notifier returns now a SentMessage that contains the messageId (returned by the provider in the response). It contains also the body of the response as array to have more info about price, number of sms sent, status and so on.

  • [ ] apply to bridges
+68 -5

0 comment

4 changed files

pr created time in a month

create barnchjeremyFreeAgent/symfony

branch : notifier-sent-message

created branch time in a month

PR opened symfony/symfony-docs

[Error pages] Add missing use
+1 -0

0 comment

1 changed file

pr created time in a month

push eventjeremyFreeAgent/symfony-docs

Jérémy Romey

commit sha 18c0533dbe8b1a3e30d8d46f98d77496f21622f1

[Error pages] Add missing use

view details

push time in a month

startedpyrech/composer-changelogs

started time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 40032e4cd3dd0479f41938a213248eebcd685544

:pill: Fix CS

view details

push time in a month

pull request commentsymfony/symfony

[Notifier] Add Infobip bridge

I've added tests based on Freemobile too.

jeremyFreeAgent

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 22a94cbbf2689343ee94a794f65c135f691a7223

:rocket: Add test

view details

push time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 73cfbbc3c70f62f0a90be6fcec2ea6331537d618

:pill: Fix CS

view details

push time in a month

pull request commentsymfony/symfony

[Notifier] Add Infobip bridge

I have changed the auth.

Thank you @Jontsa

jeremyFreeAgent

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha c343d2259c3e05d361f5c5eb90c81dd3d042ca0e

:pill: Fix CS

view details

push time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 102fa335f82a535202626946954111e4a935299e

:recycle: Change auth

view details

push time in a month

startedrectorphp/rector

started time in a month

Pull request review commentsymfony/symfony

[Notifier] Add Infobip bridge

+<?php++/*+ * This file is part of the Symfony package.+ *+ * (c) Fabien Potencier <fabien@symfony.com>+ *+ * For the full copyright and license information, please view the LICENSE+ * file that was distributed with this source code.+ */++namespace Symfony\Component\Notifier\Bridge\Infobip;++use Symfony\Component\Notifier\Exception\UnsupportedSchemeException;+use Symfony\Component\Notifier\Transport\AbstractTransportFactory;+use Symfony\Component\Notifier\Transport\Dsn;+use Symfony\Component\Notifier\Transport\TransportInterface;++/**+ * @author Fabien Potencier <fabien@symfony.com>+ * @author Jérémy Romey <jeremy@free-agent.fr>+ *+ * @experimental in 5.1+ */+final class InfobipTransportFactory extends AbstractTransportFactory+{+    /**+     * @return InfobipTransport+     */+    public function create(Dsn $dsn): TransportInterface+    {+        $scheme = $dsn->getScheme();+        $username = $this->getUser($dsn);+        $password = $this->getPassword($dsn);+        $from = $dsn->getOption('from');

I've added it but we do not have that exception thrown for Nexmo and Twilio. Do you want me to add it too for those?

jeremyFreeAgent

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha 8a46daa9928c547d886d63da46438ed11ec258ac

[Notifier] Add Infobip bridge

view details

Jérémy Romey

commit sha 028834baec7a8cadc307feaf73e53ce19826218c

:pill: Fix version

view details

Jérémy Romey

commit sha 11d22deea04202258faf78349816bfb685558951

:pill: Fix sprintf call

view details

Jérémy Romey

commit sha 2f0457b2b8f82a7009a3630efea159eb8445283f

:pill: Fix TransportException message

view details

Jérémy Romey

commit sha d669560a22f30f34a48d388381e0326159131a33

:pill: Remove default host

view details

Jérémy Romey

commit sha 2962528e57df01c9a9f25c72ff80d4b717eb0387

:pill: Fix StatusCode

view details

Jérémy Romey

commit sha f4a37fc608955ab263b547628b7d9b0864543a6b

Add IncompleteDsnException for DSN from

view details

push time in a month

push eventjeremyFreeAgent/symfony

Grégoire Pineau

commit sha 15a8610c0c4aa69a13c6a3d25a604e27ed69abb2

[Cache] Avoid memory leak in TraceableAdapter::reset()

view details

Sebastiaan

commit sha 5e3ccc28143eca0ae31897379ba54a6816049c0d

[Mime] Ensure proper line-ending for SMIME

view details

Fabien Potencier

commit sha 17bbaa502ac30a9ecf00c8b263ee6953a73f3e0d

bug #36460 [Cache] Avoid memory leak in TraceableAdapter::reset() (lyrixx) This PR was merged into the 3.4 branch. Discussion ---------- [Cache] Avoid memory leak in TraceableAdapter::reset() | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | When we call `ServicesResetter::reset()`, we want to reset the application to its initial states. We don't want a memory leak :p Commits ------- 15a8610c0c [Cache] Avoid memory leak in TraceableAdapter::reset()

view details

Fabien Potencier

commit sha 6f81e033312f5feb744507766d02f2e8cae01e9b

bug #36463 [Mime] Ensure proper line-ending for SMIME (sstok) This PR was merged into the 5.0 branch. Discussion ---------- [Mime] Ensure proper line-ending for SMIME | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36398 | License | MIT | Doc PR | Commits ------- 5e3ccc2814 [Mime] Ensure proper line-ending for SMIME

view details

Jules Pietri

commit sha dfb61c204c3d2149e36bcce7a9aefd020ff2f0c2

[Form] Fixed handling groups sequence validation

view details

Nicolas Grekas

commit sha 0f1a5c452e965be6191aeec4357f8b6556822ef5

bug #36343 [Form] Fixed handling groups sequence validation (HeahDude) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Fixed handling groups sequence validation | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | FIx https://github.com/symfony/symfony/issues/9939#issuecomment-607459505, Fix #35556 | License | MIT | Doc PR | ~ This is not the same as the original issue fixed by #36245, that was reported in https://github.com/symfony/symfony/issues/9939#issuecomment-607459505. The form also fails to cascade sequence validation properly because each nested field is validated against the sequence, and one can fail at a step independently from another which could failed in another step. I've added a lot of tests to ensure this is working properly and tested in a website skeleton too. This PR aims to close #35556 which tries to fix the same issue but afterwards in its implementation as said in https://github.com/symfony/symfony/pull/35556#discussion_r379289230. Commits ------- dfb61c204c [Form] Fixed handling groups sequence validation

view details

Talha Zekeriya Durmuş

commit sha 46c278316c7306de7e323866072e3c4422b14d7d

[SecurityBundle] fix accepting env vars in remember-me configurations

view details

Nicolas Grekas

commit sha a347a84453f66107e4b59266f4f2da43723f4a99

bug #36483 [SecurityBundle] fix accepting env vars in remember-me configurations (zek) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] fix accepting env vars in remember-me configurations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36271 | License | MIT | Doc PR | - As @wouterj explained we cannot use env variables after #35910 merged. > Hmm, so I'm guessing this is what happens: > > * `lifetime` is now an `integerNode()` > * For the Config component (which IIRC doesn't know anything about env variables), you're passing a string: `"%env(int:REMEMBER_ME_COOKIE_LIFETIME)%"` > * This throws an error, although if it wouldn't, the DI component would sucessfully process the string into a integer before it's used by any PHP class. > > So we either make Config aware of environment variables (that's probably a huge feature) or we revert the `integerNode()` changes (as you suggested). > > @HeahDude am I mislooking something, or would reverting these 2 lines not result in much harm? (only a little less strict config processor) Commits ------- 46c278316c [SecurityBundle] fix accepting env vars in remember-me configurations

view details

Nicolas Grekas

commit sha 80c5060401b0f3c0a0d24af3d56e258a512d1c5b

Merge branch '3.4' into 4.4 * 3.4: [SecurityBundle] fix accepting env vars in remember-me configurations [Form] Fixed handling groups sequence validation [Cache] Avoid memory leak in TraceableAdapter::reset()

view details

Wouter de Jong

commit sha 94f47630bab524331d5fcb5c2fb644b594e2190b

Fixed fetching sessionId from InputBag

view details

Nicolas Grekas

commit sha 23f5070696929f6f33c6b12072305a0b7dac629b

minor #36485 [Security] Fixed broken master build (wouterj) This PR was merged into the 5.1-dev branch. Discussion ---------- [Security] Fixed broken master build | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | n/a The build failures are caused by these lines (line 100 specically): https://github.com/symfony/symfony/blob/2460ca59af71e0ce610a3f807ab092436850b487/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L97-L108 Since #34363, `$request->cookies->get()` is typehinted as `string|null`. On Travis with PHP=7.4, this doc typehint is transformed into PHP return type: `get(): ?string`. On tests, the session cookie is set to `true`. See #36118 for some background on why this is necessary. There are a couple possible solutions: 1. Update the `InputBag::get()` PHPdoc to use `@return scalar|null` 2. Use `$request->cookie->all()[$session->getName()]` in `ContextListener` 3. Allow pre-configuring the session ID in `MockArraySessionStorage`. I've implemented solution (1). The method is actually using `is_scalar()` to check if a deprecation notice should be triggered, so it is expected to return a scalar in Symfony 6. _I've had to update the `DebugClassLoader` to not convert this to `get(): ?scalar`, as that doesn't exists in PHP. I'm not sure if my changes are correct (but they work)._ Commits ------- 94f47630ba Fixed fetching sessionId from InputBag

view details

Nicolas Grekas

commit sha 0cbca19edcd7d64ae18f7d1a02c0e1ba2aaa8132

[HttpFoundation] workaround PHP bug in the session module

view details

Nicolas Grekas

commit sha 62565a1b66a697a0b52109aabed7e157df7dc3f4

bug #36490 [HttpFoundation] workaround PHP bug in the session module (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] workaround PHP bug in the session module | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Current tests fail after https://github.com/php/php-src/pull/5305 Which itself is a patch for a bug in the session module. This PR works around the issue in older versions of PHP and fixes the tests. Commits ------- 0cbca19edc [HttpFoundation] workaround PHP bug in the session module

view details

Nicolas Grekas

commit sha e0e3cf634eaacfaa8bc2c163e98a19ac0e6123dc

Merge branch '3.4' into 4.4 * 3.4: [HttpFoundation] workaround PHP bug in the session module

view details

Nicolas Grekas

commit sha efbe75291869ab944c62b48de9a0c2257ccace8f

Merge branch '4.4' into 5.0 * 4.4: [HttpFoundation] workaround PHP bug in the session module [SecurityBundle] fix accepting env vars in remember-me configurations [Form] Fixed handling groups sequence validation [Cache] Avoid memory leak in TraceableAdapter::reset()

view details

Nicolas Grekas

commit sha 69b6c903300cf83cbca1fbcfe2f643c99dc2f62a

Merge branch '5.0' * 5.0: [HttpFoundation] workaround PHP bug in the session module [SecurityBundle] fix accepting env vars in remember-me configurations [Form] Fixed handling groups sequence validation [Mime] Ensure proper line-ending for SMIME [Cache] Avoid memory leak in TraceableAdapter::reset()

view details

Nicolas Grekas

commit sha 8f9ff4f7a0548e58077caa126ed31fb44cbbc810

[Routing] fix CS

view details

Olivier Dolbeau

commit sha 4751a732f272f5c4f9e9f48fdceb2352ccbdd9ac

[Routing] Deal with hosts per locale

view details

Fabien Potencier

commit sha e46495499841f805ab1915643f763d736d24822e

feature #36187 [Routing] Deal with hosts per locale (odolbeau) This PR was squashed before being merged into the 5.1-dev branch. Discussion ---------- [Routing] Deal with hosts per locale | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #30617 | License | MIT | Doc PR | TODO Allow to define a different host for each locale in routing. It's now possible to define this kind of configuration: ```yaml controllers: resource: ../../src/Controller/ type: annotation host: fr: www.example.fr en: www.example.com ``` It's still possible to define an unique host (`host: wwww.example.com`) and if a host is defined for a given route directly, it's not overridden. To be done: - [x] YamlLoader - [x] XmlLoader - [x] PhpLoader? - [x] Documentation - [x] Changelog Commits ------- 4751a732f2 [Routing] Deal with hosts per locale

view details

Wouter J

commit sha c321f4d73a33598792164788d8618c8de02e008b

Created GuardAuthenticationManager to make Guard first-class Security

view details

push time in a month

pull request commentjanephp/janephp

Update `null` values handling in normalizers

Thanks!

Korbeil

comment created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha f599c5af7ce80fb5cfbed638b206f21e4a4700a5

:pill: Remove default host

view details

Jérémy Romey

commit sha 0bb58c132fc3789eb67eaad248e502b65b8562a6

:pill: Fix StatusCode

view details

push time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha d016042010a1d6244ec9de0e43e03ac9b663ba0a

:pill: Fix TransportException message

view details

push time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha a3b025a3f155dc3fc48e30657f8a7ec76c6eac88

:pill: Fix sprintf call

view details

push time in a month

create barnchjeremyFreeAgent/symfony

branch : notifier-infobip-bridge

created branch time in a month

PR opened symfony/symfony

[Notifier] Add Infobip bridge
Q A
Branch? master
Bug fix? yes
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

Add Infobip SMS.

see https://www.infobip.com

+259 -0

0 comment

12 changed files

pr created time in a month

push eventjeremyFreeAgent/symfony

Jérémy Romey

commit sha d1c84a792b2adfddbdc7d2f7d4b94718f8d9935d

:pill: Fix version

view details

push time in a month

issue commentjanephp/janephp

Null values handling in normalizers

'normalizer-force-null-when-nullable' => false

on master (v6) works.

jeremyFreeAgent

comment created time in a month

issue commentjanephp/janephp

Null values handling in normalizers

By the way I'm using JsonSchema.

jeremyFreeAgent

comment created time in a month

issue openedjanephp/janephp

Null values handling in normalizers

Hello I found the following issue in the normalizers:

Before 5.3.0

{
    "phone": "+33600000000"
}

Since 5.3.0

{
    "phone": "+33600000000",
    "email": null
}

What about a skipNullValues like Symfony?

created time in a month

startedplotly/falcon

started time in a month

pull request commentsymfony/symfony

[DI] add syntax to stack decorators

Today I do that stack part by myself. Can’t wait to use it that way.

nicolas-grekas

comment created time in 2 months

startedhirak/prestissimo

started time in 3 months

startedasync-aws/aws

started time in 3 months

more