profile
viewpoint
Jeffrey Fisher jeffslofish Slofish California, USA

jeffslofish/algorithm-visualizer 0

:fireworks:Interactive Online Platform that Visualizes Algorithms from Code

jeffslofish/angular-quiz-app 0

Sample app demonstrating AngularJS features

jeffslofish/angularFire 0

AngularJS bindings for Firebase.

jeffslofish/angularjs-Quizzler 0

The AngularJS Challenge: Create an online Quiz builder & testing application.

jeffslofish/apple-watch-uikit 0

Run UIKit on the Watch!

jeffslofish/aragon 0

Aragon client to create and manage decentralized organizations on Ethereum.

jeffslofish/aragon-apps 0

Aragon apps developed by Aragon Core Devs (smart contracts + webapps)

jeffslofish/aragon-cli 0

CLI for creating and publishing Aragon apps

jeffslofish/aragon-desktop 0

Managing an decentralized organization on a desktop near you

jeffslofish/aragon-ui 0

Aragon-native toolkit of React UI components for decentralized apps, based on the Aragon Design System.

push eventjeffslofish/twitter-ad-blocker

Jeffrey Fisher

commit sha 5292c47d2b62bb2c6039f69766df2ad892647ab8

Update README.md

view details

push time in 9 hours

issue commentsignalapp/Signal-Desktop

Lbry.tv links aren't recognized as links

Does the link start with https:// or lbry:// ?

Can you share an example of a link that doesn't work?

kpuljek

comment created time in 6 days

fork jeffslofish/Signal-Desktop

Signal — Private Messenger for Windows, Mac, and Linux

https://signal.org/download

fork in 6 days

startedkodxana/Watch-on-LBRY

started time in 6 days

push eventjeffslofish/open-source-help-wanted

Jeffrey Fisher

commit sha d5290b6d4a10ecc869d2a6dcd2f3c5b3eba609dc

Fix npm package security issues

view details

push time in 6 days

push eventjeffslofish/open-source-help-wanted

Cesar Gomez

commit sha a197ec55bec8484db617dd7cc89aae6e14bf682b

fixed scroll issue (#20)

view details

push time in 7 days

pull request commentjeffslofish/open-source-help-wanted

fixed scroll issue

I tried using the graphql (verison 4 api) a while back, but ran into problems because sorting searched issues wasn't possible, so I couldn't paginate correctly. If you could see if they fixed that, and then implement this with graphql, that would be great! I have a branch (graphql) where I tried it before, but I got stuck because of the issue.

zootechdrum

comment created time in 7 days

pull request commentjeffslofish/open-source-help-wanted

fixed scroll issue

Thanks @zootechdrum! Works great =)

zootechdrum

comment created time in 7 days

push eventjeffslofish/open-source-help-wanted

Cesar Gomez

commit sha a197ec55bec8484db617dd7cc89aae6e14bf682b

fixed scroll issue (#20)

view details

push time in 7 days

PR merged jeffslofish/open-source-help-wanted

fixed scroll issue

I added a window.scroll method to both previous and next button. It will not scroll smoothly every time on button click.

+16 -2

0 comment

1 changed file

zootechdrum

pr closed time in 7 days

fork jeffslofish/lbrypress

LBRY WordPress plugin

fork in 7 days

startedDoichain/dapp

started time in 8 days

fork jeffslofish/dapp

Doichan dApp - a Meteor.js implementation of the "Doichain Atomic Double-Opt-In" Protocol

https://www.doichain.org

fork in 8 days

create barnchjeffslofish/us-senate-financial-disclosure-scraper

branch : issue-6

created branch time in 8 days

push eventjeffslofish/us-senate-financial-disclosure-data

Jeffrey Fisher

commit sha f88f0151182b68609698934de340bccb49c6d345

Update to 09F27BC5-02B8-42D8-BB79-9AEC73A91A61.json

view details

push time in 8 days

push eventjeffslofish/us-senate-financial-disclosure-data

Jeffrey Fisher

commit sha ee61fbfc18695929ce3945c29db1692628847198

Update to 09F27BC5-02B8-42D8-BB79-9AEC73A91A61.json

view details

push time in 8 days

push eventjeffslofish/us-senate-financial-disclosure-data

Jeffrey Fisher

commit sha 68bf31739c316fdf57b63d7bd60f84083143e3ce

Update to 09F27BC5-02B8-42D8-BB79-9AEC73A91A61.json

view details

push time in 8 days

push eventjeffslofish/us-senate-financial-disclosure-data

Jeffrey Fisher

commit sha 75cf68698f151bd1b1f56062a082f0bb0fbce9a6

Update to 09F27BC5-02B8-42D8-BB79-9AEC73A91A61.json

view details

push time in 8 days

push eventjeffslofish/us-senate-financial-disclosure-data

Jeffrey Fisher

commit sha 793a5c2b6079a211e7ba9850e91c73b83ad8b4f3

Update to 09F27BC5-02B8-42D8-BB79-9AEC73A91A61.json

view details

push time in 8 days

push eventjeffslofish/us-senate-financial-disclosure-data

Jeffrey Fisher

commit sha 342ac1e9c269e93186dbe775c926c01581a5c671

Create 09F27BC5-02B8-42D8-BB79-9AEC73A91A61.json

view details

push time in 8 days

issue openedjeremiak/us-senate-financial-disclosure-scraper

List of Senators should be in order by last name instead of by state

The current dropdown list of senators is in order by state, which is kind of annoying if you don't know what state a certain senator is from and since the PDFs don't list the state of the senator filing. I think it would make more sense to order them by last name (or make the ordering changeable) so you can more quickly choose the correct senator from the dropdown.

created time in 8 days

create barnchjeffslofish/us-senate-financial-disclosure-scraper

branch : issue-5

created branch time in 8 days

push eventjeffslofish/twitter-ad-blocker

Jeffrey Fisher

commit sha 63392198682c217d36a042a266940948dde706d7

Block promoted ads on explore page and code simplification.

view details

push time in 8 days

push eventjeffslofish/twitter-ad-blocker

Jeffrey Fisher

commit sha 40d5aa53a79c64ae8a18cab72f49ec5836a00b98

Hide Promotions when navigating via left sidebar.

view details

push time in 9 days

push eventjeffslofish/twitter-ad-blocker

Jeffrey Fisher

commit sha 2de2ed2586dbffa21d51857ac00b63bdfa715d42

Simplify code and make it block before first scroll.

view details

push time in 9 days

fork jeffslofish/facebook_adblock

An open-source Ad Blocker for Facebook™

fork in 9 days

push eventjeffslofish/twitter-ad-blocker

Jeffrey Fisher

commit sha cd0b1930376caeddca599655f04e4354fdad049e

Updated to work with new Twitter design

view details

push time in 10 days

fork jeffslofish/react

A declarative, efficient, and flexible JavaScript library for building user interfaces.

https://reactjs.org

fork in 10 days

fork jeffslofish/btc-rpc-explorer

Database-free, self-hosted Bitcoin explorer, via RPC. Built with Node.js, express, bootstrap-v4.

https://explorer.btc21.org

fork in 10 days

fork jeffslofish/lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol

https://lbry.com

fork in 10 days

issue commentlbryio/block-explorer

New User Setup - Naming Conventions for tables and columns

Here is an example of one of the errors I am getting:

Screen Shot 2020-05-22 at 1 10 28 AM

jeffslofish

comment created time in 11 days

issue openedlbryio/block-explorer

New User Setup - Naming Conventions for tables and columns

Hello, I would like to contribute to this project and I am having a little trouble getting set up.

I noticed that in the code the database table names are lowercase singular like 'block' and 'claim' while in the database SQL file https://github.com/lbryio/block-explorer/blob/master/sql/lbryexplorer.ddl.sql that is supposed to be used to populate the database schema, the table names are capital and plural, like 'Blocks' and 'Claims'.

Also, similar things are going on for the column names such as 'TransactionHashes' in the database and 'transaction_hashes' in the code.

Is there something I am missing to get CakePHP to convert from one to the other automatically? Also, it seems that this is exactly opposite of their recommended conventions.

Any help would be appreciated. =)

created time in 11 days

issue commentlbryio/lbry-desktop

Bring back Wallet History page (transaction list data)

Is this more along the lines you were thinking?

https://open.lbry.com/@jeffslofish:7/wallet-history-test-2:3

tzarebczan

comment created time in 11 days

push eventjeffslofish/lbry-desktop

Jeffrey Fisher

commit sha cdaf4fdb8304572a61d97d210502b5df2848d764

Update changelog

view details

push time in 12 days

PR opened lbryio/lbry-desktop

Make sure native controls appear on touch devices

Closes #4150

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #4150

What is the current behavior?

Videos on iPad are not playable. They do not autoplay and there are no controls to play.

What is the new behavior?

Native controls for video appear on iPad allowing user to play a video.

Other information

This should also be tested on Android, which I don't have.

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+1 -0

0 comment

1 changed file

pr created time in 12 days

create barnchjeffslofish/lbry-desktop

branch : issue-4150

created branch time in 12 days

issue commentlbryio/lbry-desktop

PDF viewer in app (not external link)

The PDF issue in Electron was fixed in 9.0.0, which was recently released. There are some deprecations and other changes that require more changes in the code than just setting the Electron dependency to 9.0.0.

Here is what I did to get PDFs to work in the app:

  1. Update core Electron dependency to 9.0.0
  2. Set the nodeIntegration option to true (because it now defaults to false) under webPreferences here: https://github.com/lbryio/lbry-desktop/blob/master/electron/createWindow.js#L36
  3. Remove PDF from the const UNSUPPORTED_IN_THIS_APP here: https://github.com/lbryio/lbry-desktop/blob/master/ui/constants/file_render_modes.js#L30
  4. In lbry-redux, add mode: 'no-cors', to the apiCall options, here: https://github.com/lbryio/lbry-redux/blob/master/src/lbry.js#L186

Setting the mode to no-cors seems like a bad thing to do, but I couldn't find any way around it. Perhaps there needs to be a change to the lbry-sdk to make cors work with the latest electron?

This is what happens if the mode isn't set to 'no-cors':

405 method not allowed

I could submit a pull request with these changes (actually two pull request because some changes are in this repo and one is in lbry-redux) if you like, but I figured you might want to discuss this further before pulling in the latest version of Electron and making these changes.

tzarebczan

comment created time in 12 days

pull request commentlbryio/lbry-desktop

Make embeds work without sesion or local storage

Done.

jeffslofish

comment created time in 14 days

push eventjeffslofish/lbry-desktop

Jeffrey Fisher

commit sha f2d6dede4f360ca451a4e8e8c466cf9625c60478

Update changelog

view details

push time in 14 days

startedkodxana/Watch-on-LBRY

started time in 15 days

issue commentlbryio/lbry-desktop

PDF viewer in app (not external link)

Looking into this...

tzarebczan

comment created time in 15 days

PR opened lbryio/lbry-desktop

Allow selecting of text by dragging the cursor over text

Closes #4209

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #4209

What is the current behavior?

Attempting to select text in the wunderbar in the app will move the whole app window instead of selecting text.

What is the new behavior?

Attempting to select text in the wunderbar in the app will actually let you select the text.

Other information

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+1 -0

0 comment

1 changed file

pr created time in 15 days

create barnchjeffslofish/lbry-desktop

branch : issue-4209

created branch time in 15 days

issue commentlbryio/lbry-desktop

Can't select text in wunderbar by dragging cursor over it in app

Looking into this now...

jeffslofish

comment created time in 15 days

issue openedlbryio/lbry-desktop

Can't select text in wunderbar by dragging cursor over it in app

<!-- Thanks for reporting an issue to LBRY and helping us improve!

To make it possible for us to help you, please fill out below information carefully.

Before reporting any issues, please make sure that you're using the latest version.

  • App releases: https://github.com/lbryio/lbry-desktop/releases
  • Standalone daemon: https://github.com/lbryio/lbry/releases

We are also available on live chat at https://chat.lbry.com -->

Bug Normally you can select text by dragging the cursor over the text and highlighting it. However, in the wunderbar if you try to do this, it acts like you are grabbing the app and the entire app moves across the screen.

To Reproduce Steps to reproduce the behavior:

  1. Open the app
  2. Enter some text in the wunderbar
  3. Attempt to select it by dragging over the text with the cursor
  4. Watch the entire app window move with your cursor!

Expected behavior The desired text should be able to be selected.

Screenshots May-17-2020 22-45-54

System Configuration

<!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out -->

<!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output -->

  • LBRY Daemon version: 0.72.0
  • LBRY App version: 0.45.1
  • LBRY Installation ID: 6FW8Z6nraRjKxu7DxhayqYgMtHgovjAAKswHTSfhQYarw42MM289CWoAUzfc1CLkRi
  • Operating system: Mac OS 19.4.0

Additional context Add any other context about the problem here.

created time in 15 days

pull request commentlbryio/lbry-desktop

Allow double-clicking in header to maximize the app.

I am only able to test this on a mac. Can someone else test this on linux/windows?

jeffslofish

comment created time in 15 days

PR opened lbryio/lbry-desktop

Allow double-clicking in header to maximize the app.

Closes #4207

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #4207

What is the current behavior?

Double clicking in the header of the app does nothing.

What is the new behavior?

Double clicking in the header of the app maximizes the app window.

Other information

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+63 -3

0 comment

3 changed files

pr created time in 15 days

create barnchjeffslofish/lbry-desktop

branch : issue-4207

created branch time in 15 days

issue commentlbryio/lbry-desktop

Should be able to double-click in header of app to maximize window

I'm looking into this now...

jeffslofish

comment created time in 15 days

issue openedlbryio/lbry-desktop

Should be able to double-click in header of app to maximize window

Is your feature request related to a problem? Please describe. There is no easy way to maximize the app window without going into "full screen" mode.

Describe the solution you'd like I would like to be able to maximize the app window (but not use "full screen" mode) without having to drag the app window to the upper-left of my screen and then drag the lower-right corner of the app to the lower right edge of the screen. You can do this on most applications these days by double-clicking in the header of the app.

I am using macOS, but I believe this should work the same in all operating systems.

created time in 15 days

issue commentlbryio/lbry-desktop

don't use localstorage in Embed if not available

Pull request submitted =)

tzarebczan

comment created time in 15 days

PR opened lbryio/lbry-desktop

Make embeds work without sesion or local storage

Closes #4017

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #4017

What is the current behavior?

Embeds don't work in Brave with shields up because session and local storage is trying to be accessed.

What is the new behavior?

Embeds work in Brave with shields because session and local storage access is avoided.

Other information

I tested this by creating a new local web site with an embedded iframe from a share link. I then modified the host from lbry.tv to localhost:9090. Without my changes I got errors and the video wouldn't load, but with my changes, the errors went away and the video played.

Note on changes: the 'startup' sesionStorage item is only used on the app, so I made that code that sets this item only appear in the app code.

The second change where I move IS_WEB to the front of the || will short circuit the || if it is web and hence the window.localStorage.getItem() code will not run on the web.

When testing, I did still get this error:

createPersistoid.js?d203:97 Error storing data Error: No available storage method found.
    at driverPromiseLoop (localforage.js?69ae:2714)

but the video played fine, so I am assuming we can ignore it?

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+3 -1

0 comment

2 changed files

pr created time in 15 days

create barnchjeffslofish/lbry-desktop

branch : issue-4017

created branch time in 15 days

issue commentlbryio/lbry-desktop

don't use localstorage in Embed if not available

Looking into this...

tzarebczan

comment created time in 15 days

issue openedlbryio/lbry-desktop

Cannot create a new channel in mobile view

<!-- Thanks for reporting an issue to LBRY and helping us improve!

To make it possible for us to help you, please fill out below information carefully.

Before reporting any issues, please make sure that you're using the latest version.

  • App releases: https://github.com/lbryio/lbry-desktop/releases
  • Standalone daemon: https://github.com/lbryio/lbry/releases

We are also available on live chat at https://chat.lbry.com -->

Bug When the screen width is below 900px, there is no way to create a channel, except from the publish page. The "New Channel" button disappears at 900px from the channels page. Also, there is no "New Channel" menu item in the mobile menu.

To Reproduce Steps to reproduce the behavior:

  1. On a device with less than 900px width, Go to https://lbry.tv/$/channels
  2. Notice that there is no "New Channel" button.
  3. Click on the menu with the three bars
  4. Notice there is no "New Channel" menu item.

Expected behavior I expect to be able to create a channel in a mobile view.

created time in 16 days

issue commentlbryio/lbry-desktop

Bring back Wallet History page (transaction list data)

What if we have a button on the wallet page called "Detailed History" that takes you to the old transactions page which has all the transaction list data. Or did you want to display the transaction list data right on the wallet page? I have the former working right now ... it would take some more work to display it on the wallet page.

Screen Shot 2020-05-16 at 12 40 59 AM

tzarebczan

comment created time in 17 days

issue commentlbryio/lbry-desktop

Bring back Wallet History page (transaction list data)

I'm working on this now.

tzarebczan

comment created time in 17 days

PR opened lbryio/lbry-desktop

Add grab cursor to pop out player header

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [x] Other - Please describe: Improvement: Makes it clearer that the pop out player can be moved around

Fixes

Issue Number: Partially fixes #2750, specifically the checkbox that says "make it clearer on how to drag around"

What is the current behavior?

When hovering over the header of the pop out player, a pointer cursor is shown.

What is the new behavior?

When hovering over the header of the pop out player, a hand cursor is shown, similar to the footer of the pop out player.

Other information

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+1 -0

0 comment

1 changed file

pr created time in 17 days

create barnchjeffslofish/lbry-desktop

branch : issue-2750

created branch time in 17 days

issue commentlbryio/lbry-desktop

Video player does not work on iPad

It appears that both the native and videojs controls are hidden. I think we should show one or the other. I believe the video is not playing when you try to autoplay a non-muted video in iOS, so if the controls were there, the user could manually start the video.

If we want to show native controls, we need to add

html5: { nativeControlsForTouch: true, }, here: https://github.com/lbryio/lbry-desktop/blob/master/ui/component/viewers/videoViewer/internal/videojs.jsx#L79.

If we want to show the videojs controls, we need to unhide them here: https://github.com/lbryio/lbry-desktop/blob/master/ui/scss/component/_file-render.scss#L292

@seanyesmunt What do you think?

tzarebczan

comment created time in 17 days

PR opened lbryio/lbry-desktop

Only show "start at" on share page for videos/audio

Closes #4177

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #4177

What is the current behavior?

"Start at" is shown for all sharing modals

What is the new behavior?

"Start at" is only shown for video and audio sharing modals

Other information

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+22 -16

0 comment

1 changed file

pr created time in 18 days

create barnchjeffslofish/lbry-desktop

branch : issue-4177

created branch time in 18 days

issue commentlbryio/lbry-desktop

Only show "start at" on share page for videos/audio

I'll take a look at this

tzarebczan

comment created time in 18 days

PR opened lbryio/lbry-desktop

Clear media position if video has played to the end.

Closes #4174

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #4174

What is the current behavior?

When a video plays to the end, the media position is set to the end of the video.

What is the new behavior?

When a video plays to the end, the media position is cleared.

Other information

I could have just set the media position to 0 (using a lot less code), but I thought that completely clearing the relevant entries from the redux store would be better to prevent an over accumulation of media positions.

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+62 -3

0 comment

6 changed files

pr created time in 18 days

create barnchjeffslofish/lbry-desktop

branch : issue-4174

created branch time in 18 days

issue commentlbryio/lbry-desktop

reset media position when at the end of video

I'm looking into it now

tzarebczan

comment created time in 18 days

PR opened lbryio/lbry-redux

Support lbry:// links with timestamp

Current behavior: If you paste a lbry:// link with a ?t=xyz parameter at the end into the wunderbar, it will start the video at the beginning.

New behavior: If you paste a lbry:// link with a ?t=xxx parameter at the end into the wunderbar, it will start the video at the xyz seconds timestamp.

This should fix https://github.com/lbryio/lbry-desktop/issues/3972

+9 -1

0 comment

2 changed files

pr created time in 25 days

create barnchjeffslofish/lbry-redux

branch : suport-lbry-link-with-timestamp

created branch time in 25 days

pull request commentlbryio/lbry-desktop

Allow video sharing with start timestamp

Thanks for you help!

All of the issues you mentioned should be resolved now, with much cleaner code =)

jeffslofish

comment created time in 25 days

push eventjeffslofish/lbry-desktop

Jeffrey Fisher

commit sha a1b6260426a1f54a1608790777ae8616b53af934

Fix code review issues

view details

push time in 25 days

Pull request review commentlbryio/lbry-desktop

Allow video sharing with start timestamp

 type Props = {   webShareable: boolean,   referralCode: string,   user: any,+  position: number, };  function SocialShare(props: Props) {-  const { claim, title, referralCode, user, webShareable } = props;+  const { claim, title, referralCode, user, webShareable, position } = props;   const [showEmbed, setShowEmbed] = React.useState(false);   const [showExtra, setShowExtra] = React.useState(false);+  const [includeStartTime, setincludeStartTime]: [boolean, any] = React.useState(false);+  const [startTime, setStartTime]: [string, any] = React.useState(secondsToHms(position));+  const [startTimeSeconds, setStartTimeSeconds]: [number, any] = React.useState(Math.floor(position));   const isMobile = useIsMobile(); -  if (!claim) {

I am using state for the URLs so that the user can change the time if they want and the URLs will update automatically. Do we want to lose that functionality?

jeffslofish

comment created time in a month

Pull request review commentlbryio/lbry-desktop

Allow video sharing with start timestamp

 type Props = {   webShareable: boolean,   referralCode: string,   user: any,+  position: number, };  function SocialShare(props: Props) {-  const { claim, title, referralCode, user, webShareable } = props;+  const { claim, title, referralCode, user, webShareable, position } = props;   const [showEmbed, setShowEmbed] = React.useState(false);   const [showExtra, setShowExtra] = React.useState(false);+  const [includeStartTime, setincludeStartTime]: [boolean, any] = React.useState(false);+  const [startTime, setStartTime]: [string, any] = React.useState(secondsToHms(position));+  const [startTimeSeconds, setStartTimeSeconds]: [number, any] = React.useState(Math.floor(position));   const isMobile = useIsMobile(); -  if (!claim) {

I didn't move it originally, but when I tried to commit, it gave me an error saying that you can't return conditionally before calling React.useState(). So I moved it after all the React.useState() calls, and tried to make the code work if claim did happen to be null. I am not really happy with it myself, but I couldn't figure another way around the problem. This is also why I got rid of the claim destructuring, so the code wouldn't give an error if claim happened to be null. It looks like I missed one line of code that you pointed out. Can you suggest any better ways to handle the problem?

jeffslofish

comment created time in a month

issue commentlbryio/lbry-desktop

Support opening timestamped videos on Desktop app

I'm going to look into this issue.

tzarebczan

comment created time in a month

push eventjeffslofish/lbry-desktop

Sean Yesmunt

commit sha 36c0694b8bab252cf1229bc243b627b5a83863a7

v0.45.1-rc.4

view details

Sean Yesmunt

commit sha db94e38911bba563cb6b8c6197643adba950940b

slightly improve pagination button placement

view details

Sean Yesmunt

commit sha 1b830f74a1b544cad20b681ba080e0e297065996

update button styles

view details

Sean Yesmunt

commit sha 85ac7c5aac12109e2f6a5cd3d13fc76b9c357fa1

move edit button on channel pages

view details

Sean Yesmunt

commit sha e066e46f589c5ee91710e5a826042b16f6dcbd28

v0.45.1-rc.5

view details

Sean Yesmunt

commit sha 20d4b5b7e1b426f9ff3847ea907541fdd9d1e353

bump lbry-redux and lbry-sdk

view details

Sean Yesmunt

commit sha 66ea800ca21de60390adade584f9642b1b04f2d7

update changelog

view details

Sean Yesmunt

commit sha 9e4de43819b0f867cee17a0ee28b4fc0c713168c

v0.45.1-rc.6

view details

Sean Yesmunt

commit sha d8c6300f5142346e9aba3b00f74b9849ad2d22b8

fix typo

view details

Sean Yesmunt

commit sha 0f87c8b207cb20cf9a2bd85ca28222a324c476ca

v0.45.1-rc.7

view details

Sean Yesmunt

commit sha db51789e071e3472f2900e9627303fc9235024a8

pass time in ms to analytics for view apis

view details

Sean Yesmunt

commit sha e7c41590ba7bd511741f83d6bbbae8a69d76020d

v0.45.1-rc.8

view details

Sean Yesmunt

commit sha 95233c2196153864a6ef11ad68cffa079bca6de6

remove hard coded reward amount

view details

Sean Yesmunt

commit sha 5d0e7af049bf51f03f90132656de925df064fad5

v0.45.1-rc.9

view details

Sean Yesmunt

commit sha 96d9e24a4b19e60faa300fe4f7ff070aef24df8e

fix time to start analytics for desktop and fix rewards link

view details

Sean Yesmunt

commit sha bedb0d63733eab7941530110f2bca7eca08b528f

v0.45.1-rc.10

view details

Jeremy Kauffman

commit sha ab70f1c758e11a6606d1b18cd30a1bd24b7f0905

remove #whothinks

view details

Sean Yesmunt

commit sha ff429117cdf888fa2a85ab323d181a06e6a9899c

make sure player callback has access to latest desktop start time

view details

Sean Yesmunt

commit sha b09283ce725b7417ba8f63cee4b245f9180a2a8e

v0.45.1-rc.11

view details

Jeffrey Fisher

commit sha f76c1c1df64e163de3d2d7cd3b4c803f22be3cd7

Merge branch 'master' into issue-3122

view details

push time in a month

PR opened lbryio/lbry-desktop

Allow video sharing with start timestamp

Closes #3122

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #3122

What is the current behavior?

Sharing videos always starts at the beginning of the video using the share modal.

What is the new behavior?

When the share model opens, the start time field is auto-populated with the current time of the video. The use may then check a checkbox to share the video starting at that point in time. Also, the time field is editable, so the user can adjust as they wish.

The "LBRY Link", the "Embedded" link, as well as all the social sharing links will include a "t" query param in the sharable url (if the checkbox is checked) which will start the shared video at the desired time.

Other information

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+191 -15

0 comment

8 changed files

pr created time in a month

create barnchjeffslofish/lbry-desktop

branch : issue-3122

created branch time in a month

issue commentlbryio/lbry-desktop

Sharing videos with a start timestamp

Also, should both the "LBRY Link" and "Embedded" tag have the t parameter, but not the "LBRY URL" or "Download Link"?

tzarebczan

comment created time in a month

issue commentlbryio/lbry-desktop

Sharing videos with a start timestamp

For the UI, how about something like this:

Screen Shot 2020-05-02 at 9 51 54 PM Screen Shot 2020-05-02 at 9 51 06 PM

tzarebczan

comment created time in a month

issue commentlbryio/lbry-desktop

Sharing videos with a start timestamp

I'm going to work on this now

tzarebczan

comment created time in a month

push eventjeffslofish/lbry-desktop

Jeffrey Fisher

commit sha 800f5cd6248ada782c3caf6d12e88f6f41bf0e34

Update changelog

view details

push time in a month

PR opened lbryio/lbry-desktop

Open hyperlinks in new tab

Closes #3467

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #3467

What is the current behavior?

Hyperlinks in markdown (markdown files, content description, about page) open in same tab

What is the new behavior?

Hyperlinks in markdown open in new tab

Other information

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchjeffslofish/lbry-desktop

branch : issue-3467

created branch time in a month

issue commentlbryio/lbry-desktop

hyperlinks should open in new tab

I'm looking into this issue now.

tzarebczan

comment created time in a month

push eventjeffslofish/lbry-desktop

Sean Yesmunt

commit sha 1a50e697ceaaf93e81965cb49d195a7735fa10ed

embed functionality inside markdown posts

view details

Sean Yesmunt

commit sha 9923df7b1954b836aeac74104abaf3eba3e4c750

let browser validate iframe markup

view details

Jeffrey Fisher

commit sha c56f135dcedfb9ecffbb90dd877085810f711d79

Update CHANGELOG.md

view details

Jeremy Kauffman

commit sha 6b02805645b3b33b0b08bbeeef8bda33e3c98fd9

fix play button on embed end

view details

Sean Yesmunt

commit sha 49275c298a7e8d0405672b4d4761c65992b8cb5e

embeds style fixes

view details

Sean Yesmunt

commit sha 554f50802ed61a3b96371fb02753d474d1a62eb3

set playing uri when navigating from the floating player

view details

Sean Yesmunt

commit sha 6eb9d665c8c191649fb578acff3034b0d4b92033

update changelog

view details

Sean Yesmunt

commit sha 45b7720118d750bd4a1ae7c7e5f84a7811e266ac

v0.45.1-rc.1

view details

Sean Yesmunt

commit sha 5152e78f09182fd9e09ce4b0b3c90f35bb46e85b

new og image

view details

Sean Yesmunt

commit sha 8d888d3e2349f78db7db286f29eca4026e6fc72b

improve floating behavior when coming from embeds

view details

Sean Yesmunt

commit sha f99ce16a67188132a2876cbf6a341b11700c424f

improve header markup for voiceover and add aria-expanded attribute for cards

view details

Sean Yesmunt

commit sha b4eabda314906561602d2a95ba551b8ab9c1c50a

v0.45.1-rc.2

view details

Sean Yesmunt

commit sha 2e7c0ac5d0dac3a4ffeb832508ba3895b7786828

Update README.md

view details

Jeffrey Fisher

commit sha dd58f57236529ff02afe9f9802886b384126d5dd

Merge branch 'master' into issue-2775-1

view details

push time in a month

pull request commentlbryio/lbry-desktop

Save media position in video viewer

I updated the code to only save the media position on pause or dispose (in case they leave the page without stopping the video first) instead of every timeupdate event. This should help out performance and save the position in the majority of cases.

jeffslofish

comment created time in a month

push eventjeffslofish/lbry-desktop

Jeffrey Fisher

commit sha 63a2d1a6f3b86a5a22189c42e5a786c49fd8f513

Only save media position on pause or dispose, not every timeupdate, for performance reasons.

view details

push time in a month

pull request commentlbryio/lbry-desktop

Save media position in video viewer

I didn't notice any issue, but perhaps there would be on some devices. Let me see what I can do to make it write less often (hopefully just once)...

jeffslofish

comment created time in a month

pull request commentlbryio/lbry-desktop

Save media position in video viewer

I abandoned my previous pull request (#4098) and created this clean one with the changes you wanted.

jeffslofish

comment created time in a month

push eventjeffslofish/lbry-desktop

Jeffrey Fisher

commit sha 23d70fc3a71773cbc9e027852694b4bc6027776f

Update changelog for #4104

view details

push time in a month

PR opened lbryio/lbry-desktop

Save media position in video viewer

#3886 PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #2775

What is the current behavior?

Videos start playing at beginning of the video.

What is the new behavior?

Video position is saved when being played. If a previously viewed video is played again, it starts at the saved location.

Other information

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+6 -2

0 comment

3 changed files

pr created time in a month

PR closed lbryio/lbry-desktop

Save media position to local storage.

Closes #2775

PR Checklist

<!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" -->

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Fixes

Issue Number: #2775

What is the current behavior?

The media player always starts at the beginning of the video

What is the new behavior?

The position of the media player is saved to local storage and the next time that video is played, the video will start at the position it was last played at.

Other information

The following is a screenshot of what the local storage will start to look like with this solution: Screen Shot 2020-04-29 at 12 10 12 AM

<!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. -->

+16 -4

2 comments

2 changed files

jeffslofish

pr closed time in a month

more