profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jcnars/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

google/bms-toolkit 40

Toolkit for installing and creating an initial database on Bare Metal Solution

jcnars/bms-toolkit 0

Toolkit for installing and creating an initial database on Bare Metal Solution

jcnars/github-slideshow 0

A robot powered training repository :robot:

jcnars/hello-world 0

OTYSPUIBMMA

jcnars/Spoon-Knife 0

This repo is for demonstration purposes only.

pull request commentGoogleCloudPlatform/oss-test-infra

Adding mfielding after he joined under GCP org

/lgtm

jcnars

comment created time in 4 days

push eventjcnars/oss-test-infra

jcnars

commit sha f9323fd6fb5b0de2bff8c0c035322587a027282f

Adding mfielding after he joined under GCP org

view details

push time in 4 days

push eventjcnars/oss-test-infra

Cole Wagner

commit sha 94f16a846e5eceb842a6c0b49bff7f038cd4d342

Bump pull-test-infra-go-test to go version 1.16.

view details

Google OSS Prow Robot

commit sha 8de02286fc474ca59659b0d945587018c147eb33

Merge pull request #1207 from cjwagner/go-version Bump pull-test-infra-go-test to go version 1.16.

view details

Google OSS Prow Robot

commit sha 918ec767c31c1d3937c5bd769225961161481f17

Merge pull request #1208 from jcnars/master Adding OWNERS so BMS Oracle team can change the tests run

view details

push time in 6 days

push eventjcnars/oss-test-infra

Cole Wagner

commit sha 8ecdeb99fcd3d6ec9c355b4788e66cedb9cf7e78

Remove bms-toolkit job targetting invalid cluster.

view details

Google OSS Prow Robot

commit sha 6f5660c94a911954bf705723b75fd7a08ddb21f3

Merge pull request #1206 from cjwagner/remove-invalid-job Remove bms-toolkit job targeting invalid cluster.

view details

jcnars

commit sha 5cd38daa1ea8a25c533614ee3b249fbf8c226b69

Merge branch 'GoogleCloudPlatform:master' into master

view details

push time in 6 days

push eventjcnars/oss-test-infra

JC Narasimhan

commit sha c5ce17e6cb302783e5a5b765a5a162e3467c7fe1

Adding OWNERS file to prow/prowjobs/google/bms-toolkit directory

view details

push time in 6 days

push eventgoogle/bms-toolkit

JC Narasimhan

commit sha 23649e81118f4b66e7150552aa764719b5556a3d

Adding OWNERS file

view details

JC Narasimhan

commit sha 0144728c8e2ae2f8ff378f211665994718a71bfe

Modifying structure of OWNERS adding field: approver

view details

JC Narasimhan

commit sha 76f83082fa331c954ef2cfe7d85da89ff5394fa3

Adding a comment to include https://go.k8s.io/owners

view details

jcnars

commit sha d5d6aecc77a88885387fd804555948c621724b7d

Merge pull request #91 from google/add_owners_file Adding OWNERS file

view details

push time in 6 days

PR merged google/bms-toolkit

Adding OWNERS file size/XS lgtm

As expected by OSS bot, adding OWNERS file: https://github.com/google/bms-toolkit/pull/90#issuecomment-943604974

+7 -0

2 comments

1 changed file

jcnars

pr closed time in 6 days

push eventjcnars/oss-test-infra

Google OSS Prow Robot

commit sha bc4c338c8280c2bf273977167147a08256a1e3e0

Merge pull request #1205 from jcnars/master reverting changes in #1189 and #1188

view details

push time in 6 days

PR opened GoogleCloudPlatform/oss-test-infra

reverting changes in #1189 and #1188

It looks like when I onboarded the build cluster, few steps may have been overlooked. That results in one-off fixes/troubleshooting that's not typical during onboarding.

Hence cleaning up PRs #1189 and #1188 with this PR, so I can start afresh.

+9 -85

0 comment

10 changed files

pr created time in 6 days

push eventjcnars/oss-test-infra

JC Narasimhan

commit sha 2b7c616df957df2fc65dd4ff0074dd072556a0f0

reverting changes in https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1189 and 1188

view details

push time in 6 days

push eventjcnars/oss-test-infra

Google OSS Prow Robot

commit sha ea814c0b60907b6d1b7357c3d6408720cf0a8e36

Merge pull request #1195 from jcnars/master Onboard google/bms-toolkit to prow

view details

Cole Wagner

commit sha ed50168a9c0d82092db5af1307c5f898a269d590

Update terraform rules to switch to using 'prow-metrics' scoping project. The 'prow-metrics' scoping project includes metrics from all the Prow instances we manage. By deploying dashboards and alerts there we can avoid duplication and additional infra for managing terraform in each project.

view details

Google OSS Prow Robot

commit sha afa5a0e9ea9131ca9154f625d4ef6b69875e6701

Bumping oss-prow Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- https://github.com/kubernetes/test-infra/compare/f0462bffd3...a7344144f0 | 2021‑10‑13 → 2021‑10‑13 | checkconfig, clonerefs, configurator, crier, deck, entrypoint, generic-autobumper, gerrit, ghproxy, grandmatriarch, hmac, hook, horologium, initupload, prow-controller-manager, sidecar, sinker, sub, tide

view details

Google OSS Prow Robot

commit sha 93143e7e552126a859163f035ba85b3aa3e385bf

Merge pull request #1197 from google-oss-robot/autobump-oss-prow Update oss-prow to v20211013-a7344144f0

view details

Chao Dai

commit sha 2ac5df9e98b8acafa07dab06cab2b91884865ec8

Opt in oss-test-infra for GitHub app authentication Note that there will be some minor impacts: 1. there will be a few seconds that webhooks are double handled, so prow might do something repeatedly 2. prow will not recognize the comments it left before, so on existing PRs there will be two prow comments instead of one

view details

Google OSS Prow Robot

commit sha 79016f2d43cb9360b707456288f5263c8981330e

Bumping knative-prow Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- https://github.com/kubernetes/test-infra/compare/f0462bffd3...a7344144f0 | 2021‑10‑13 → 2021‑10‑13 | cherrypicker, clonerefs, crier, deck, entrypoint, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide

view details

Google OSS Prow Robot

commit sha 6b1b5e51c6b5b433b3822e7822d74eae3770495d

Merge pull request #1196 from google-oss-robot/autobump-knative-prow Update knative-prow to v20211013-a7344144f0

view details

Google OSS Prow Robot

commit sha 3d225f37078c6daef59903b850d52ed1b713aa8e

Merge pull request #1199 from chaodaiG/migrate-oss-test-infra-ghapp Opt in oss-test-infra for GitHub app authentication

view details

Chao Dai

commit sha 4fe8cd992e27572bf12f4412ccaaf456e4351bb0

Fix config for oss-test-infra onboarding gh app

view details

Google OSS Prow Robot

commit sha 7731263a8d0258037ba3109cc26b33adfee4d5a6

Merge pull request #1200 from chaodaiG/fix-gh-oss-test-infra Fix config for oss-test-infra onboarding gh app

view details

Google OSS Prow Robot

commit sha 31440178f86856f505f435b04c73c30d03404dc0

Merge pull request #1198 from cjwagner/metric-hub Update terraform rules to switch to using 'prow-metrics' scoping project.

view details

Chao Dai

commit sha 6176dba71371e80a03340cd22c21706b21b0f227

Revert "Fix config for oss-test-infra onboarding gh app" This reverts commit 4fe8cd992e27572bf12f4412ccaaf456e4351bb0.

view details

Google OSS Prow Robot

commit sha c6771abc49cc43e51259d2641435a3cdd7e6372f

Merge pull request #1201 from chaodaiG/revert Revert "Fix config for oss-test-infra onboarding gh app"

view details

Google OSS Prow Robot

commit sha d6010dee9ddd6baf103a01ffff5734ef106daf36

Bumping oss-prow Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- https://github.com/kubernetes/test-infra/compare/a7344144f0...a3eefb553f | 2021‑10‑13 → 2021‑10‑15 | checkconfig, clonerefs, configurator, crier, deck, entrypoint, generic-autobumper, gerrit, ghproxy, grandmatriarch, hmac, hook, horologium, initupload, prow-controller-manager, sidecar, sinker, sub, tide

view details

Google OSS Prow Robot

commit sha 48bd51a7b624d5d24faaa69efbfd081d2e54d3a5

Merge pull request #1204 from google-oss-robot/autobump-oss-prow Update oss-prow to v20211015-a3eefb553f

view details

Google OSS Prow Robot

commit sha d24150d17c0557b8b764c1579f84e2a736d50150

Bumping knative-prow Multiple distinct gcr.io/k8s-prow/ changes: Commits | Dates | Images --- | --- | --- https://github.com/kubernetes/test-infra/compare/a7344144f0...a3eefb553f | 2021‑10‑13 → 2021‑10‑15 | cherrypicker, clonerefs, crier, deck, entrypoint, ghproxy, hook, horologium, initupload, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide

view details

Google OSS Prow Robot

commit sha 985fc4e70c9185c538bf34e370d8fdad6a3d11af

Merge pull request #1203 from google-oss-robot/autobump-knative-prow Update knative-prow to v20211015-a3eefb553f

view details

push time in 6 days

push eventgoogle/bms-toolkit

JC Narasimhan

commit sha 76f83082fa331c954ef2cfe7d85da89ff5394fa3

Adding a comment to include https://go.k8s.io/owners

view details

push time in 7 days

pull request commentgoogle/bms-toolkit

Adding OWNERS file

You may need to disable the OSS robot o get this submitted, as there are no current approvers.

IIUC, this is only true if we using the bot to merge the PR, which in our case is not. We will see shortly when we merge this !

This involves a fairly big (but fortunately mostly self-documenting) process for reviews; it might make sense to annotate docs/contributing.md appropriately, as it's different form the traditional GitHub process many may be familiar with. Agreed, adding the link you mentioned in the other comment.

jcnars

comment created time in 7 days

pull request commentgoogle/bms-toolkit

Testing prowjob after the webhook is configured per https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1195

/test testjob

https://screenshot.googleplex.com/BNv4AiCKgZsbv7f https://screenshot.googleplex.com/37W4NFYjJjEuc3z

jcnars

comment created time in 7 days

pull request commentgoogle/bms-toolkit

Testing prowjob after the webhook is configured per https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1195

/test testjob

Reason: Granted: https://screenshot.googleplex.com/HFdB43qEwULtx4X

Reason: (Thanks ChaodaiG for clarification) When creating, this roles/storage.objectAdmin grant was somehow missed: https://github.com/kubernetes/test-infra/blob/75b15aa2202a3285ec737586e211025c31466908/prow/create-build-cluster.sh#L166

function createBucket() {
  gsutil mb -p "${PROJECT}" -b on "${GCS_BUCKET}"
  for i in ${CONTROL_PLANE_SA//,/ }
  do
    gsutil iam ch "serviceAccount:${i}:roles/storage.objectAdmin" "${GCS_BUCKET}"
  done
}
jcnars

comment created time in 7 days

pull request commentgoogle/bms-toolkit

Testing prowjob after the webhook is configured per https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1195

/test all

Editing a comment doesn't seem to trigger a test

jcnars

comment created time in 7 days

pull request commentgoogle/bms-toolkit

Testing prowjob after the webhook is configured per https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1195

/retest

added this: https://screenshot.googleplex.com/C9vf3bDn9P69GY5 because got the same error:

error rendering spyglass page: error when resolving real path gs/bmaas-testing-prow-poc/pr-logs/pull/google_bms-toolkit/90/testjob/1448771039117971456: googleapi: got HTTP response code 403 with body: <?xml version='1.0' encoding='UTF-8'?><Error><Code>AccessDenied</Code><Message>Access denied.</Message><Details>oss-prow-public-deck@oss-prow.iam.gserviceaccount.com does not have storage.objects.get access to the Google Cloud Storage object.</Details></Error>

whenever we click on the "Details" link next to the test that passed and also on the prow jobs page (https://oss-prow.knative.dev/), clicking on testjob

jcnars

comment created time in 7 days

pull request commentgoogle/bms-toolkit

Testing prowjob after the webhook is configured per https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1195

/retest

Added as noted here: (Internal) https://screenshot.googleplex.com/3rUJ57oXXYZBpG6

jcnars

comment created time in 7 days

pull request commentgoogle/bms-toolkit

Testing prowjob after the webhook is configured per https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1195

@jcnars: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command testjob 84dca99 link true /test testjob

The error from prow status page: https://oss-prow.knative.dev/ is:

error rendering spyglass page: error when resolving real path gs/bmaas-testing-prow-poc/pr-logs/pull/google_bms-toolkit/90/testjob/1448767330606649344: googleapi: got HTTP response code 403 with body: 
<?xml version="1.0" encoding="UTF-8"?>
<Error>
   <Code>AccessDenied</Code>
   <Message>Access denied.</Message>
   <Details>oss-prow-public-deck@oss-prow.iam.gserviceaccount.com does not have storage.objects.get access to the Google Cloud Storage object.</Details>
</Error>

Looks like a permission issue. Exploring how to give access to oss-prow-public-deck@oss-prow.iam.gserviceaccount.com. Will first verify that prowjob-default-sa locally in the build cluster has access.

jcnars

comment created time in 7 days

pull request commentgoogle/bms-toolkit

Testing prowjob after the webhook is configured per https://github.com/GoogleCloudPlatform/oss-test-infra/pull/1195

/retest

Ran this manually:

jcnarasimhan@jon2:~/DriveFS/My Drive/bmaas/test_automation/oss_prow_onboarding$ kubectl apply -f - <<EOF
apiVersion: v1
kind: ServiceAccount
metadata:
  annotations:
    iam.gke.io/gcp-service-account: prowjob-default-sa@bmaas-testing.iam.gserviceaccount.com
  name: prowjob-default-sa
  namespace: test-pods
EOF
serviceaccount/prowjob-default-sa created
jcnars

comment created time in 7 days

Pull request review commentgoogle/bms-toolkit

Adding OWNERS file

+mfielding

This is fixed. Changed from:

mfielding
rachelhmyang
jcnars

to:

approvers:
- mfielding
- jcnars
- rachelhmyang
jcnars

comment created time in 8 days