profile
viewpoint
Jannick Fahlbusch jannickfahlbusch @SAP GMXX8514 Opinions expressed are solely my own and do not express the views or opinions of my employer.

mailcow/mailcow 1003

PLEASE USE https://github.com/mailcow/mailcow-dockerized ! This version is outdated until "mailcow: dockerized" code is merged to this repository.

jannickfahlbusch/hubot-whatsapp 5

WhatsApp adapter for Hubot

jannickfahlbusch/node-routerpwn 4

Just a small library with some exploits for Routers

jannickfahlbusch/magic-filetransfer 2

Transfer files like a magician!

jannickfahlbusch/node-wardriving 2

Wardriving with Node.JS

jannickfahlbusch/corona-exporter 0

Prometheus Exporter for COVID-19 cases

jannickfahlbusch/crtsh 0

API client for crt.sh

jannickfahlbusch/flathunter 0

TelegramBot that finds flats on immobilienscout24.de, wg-gesucht.de, ebay-kleinanzeigen.de and immowelt.de [tested this week - working!]

PR closed tschuehly/flathunter

[Immowelt] Fix Size detection
+1 -1

0 comment

1 changed file

jannickfahlbusch

pr closed time in 21 days

delete branch jannickfahlbusch/gardener-extension-networking-calico

delete branch : makeCalicoRunOnAllowedPools

delete time in a month

pull request commentgardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

@vpnachev @zanetworker I've worked in the changes.

Please take a look again

jannickfahlbusch

comment created time in a month

push eventjannickfahlbusch/gardener-extension-networking-calico

Jannick Fahlbusch

commit sha 42b773ee60c52895bf763eb5359da03bdcb55060

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools This makes the the following components run only on pools that are allowed to host system components and extensions: * calico-kube-controller * calico-node-vertical-autoscaler * calico-typha-deploy * calico-typha-horizontal-autoscaler * calico-typha-vertical-autoscaler See https://github.com/gardener/gardener/issues/2462 and https://github.com/gardener/gardener/pull/2480

view details

push time in a month

push eventjannickfahlbusch/gardener-extension-networking-calico

Jannick Fahlbusch

commit sha b4456d5efd8d4d951cfdc40841496b9e40379cb8

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools This makes the the following components run only on pools that are allowed to host system components and extensions: * calico-kube-controller * calico-node-vertical-autoscaler * calico-typha-deploy * calico-typha-horizontal-autoscaler * calico-typha-vertical-autoscaler See https://github.com/gardener/gardener/issues/2462 and https://github.com/gardener/gardener/pull/2480

view details

push time in a month

push eventjannickfahlbusch/gardener-extension-networking-calico

Plamen Kokanov

commit sha d2000fb97da1640733d9a2fb1029c6c69fe238c3

Restore now calls Reconcile instead of being an empty op

view details

Adel Zaalouk

commit sha 547981b09252746fa57ce5a981fbc64df2078234

Merge pull request #37 from plkokanov/cp-migration/restore Restore now calls Reconcile instead of being an empty op

view details

Jannick Fahlbusch

commit sha 7342e67118289b82c7f82f299d5b734b96e89ba1

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools This makes the the following components run only on pools that are allowed to host system components and extensions: * calico-kube-controller * calico-node-vertical-autoscaler * calico-typha-deploy * calico-typha-horizontal-autoscaler * calico-typha-vertical-autoscaler See https://github.com/gardener/gardener/issues/2462 and https://github.com/gardener/gardener/pull/2480

view details

push time in a month

Pull request review commentgardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

 spec:     spec:       nodeSelector:         beta.kubernetes.io/os: linux

Removed the selector

jannickfahlbusch

comment created time in a month

Pull request review commentgardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

 spec:         gardener.cloud/role: system-component     spec:       nodeSelector:-        beta.kubernetes.io/os: linux+{{ toYaml .Values.nodeSelector | indent 8 }}

Done

jannickfahlbusch

comment created time in a month

Pull request review commentgardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

 images:   calico-kube-controllers: "image-repository:image-tag"   calico-podtodaemon-flex: "image-repository:image-tag"   calico-cpva: "image-repository:image-tag"-  calico-cpa: "image-repository:image-tag"\ No newline at end of file+  calico-cpa: "image-repository:image-tag"++nodeSelector: {}

Done

jannickfahlbusch

comment created time in a month

push eventjannickfahlbusch/gardener-extension-networking-calico

Jannick Fahlbusch

commit sha 727185d85999177d65dd3d70b1875ec5a2093ddd

Incorporate feedback

view details

push time in a month

Pull request review commentgardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

 spec:     spec:       nodeSelector:         beta.kubernetes.io/os: linux

I've removed it by accident. I'll readd it

jannickfahlbusch

comment created time in 2 months

pull request commentgardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

We need to wait for the next release of gardener/gardener to vendor the changes here right?

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener-extension-networking-calico

Jannick Fahlbusch

commit sha 9f6b4e0472bcd051c2dff6f682866886c1bc89c1

Activate nodeSelector only if there is one workeer pool supporting it

view details

push time in 2 months

startedmicb25/dka

started time in 2 months

delete branch jannickfahlbusch/gardener

delete branch : shootWorkerAllowSystemComponents

delete time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 spec:         origin: gardener         k8s-app: kubernetes-dashboard     spec:+      nodeSelector:+        worker.gardener.cloud/system-components: true

Fixed

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 6f3a5c275d5a667ab62f262fb9635ed4c6f795dd

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

resource manager cannot apply the deployments

How can I debug this to submit a fix?

jannickfahlbusch

comment created time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

I had to push again as I forgot to format a test

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 82e28765f04fcb34cc83f070055e749b8e3b36e4

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

pull request commentgardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

This would need to be handled here right?

https://github.com/gardener/gardener-extension-networking-calico/blob/d7c117e2b59d31dcd5ac57684eab718e9d52d53b/pkg/charts/utils.go#L114-L139

jannickfahlbusch

comment created time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

I've added a sentence for the extension documentation and also opened a change for calico: https://github.com/gardener/gardener-extension-networking-calico/pull/39

jannickfahlbusch

comment created time in 2 months

pull request commentgardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

/hold

This can only be merged after https://github.com/gardener/gardener/pull/2480 got merged

jannickfahlbusch

comment created time in 2 months

PR opened gardener/gardener-extension-networking-calico

[gardener/gardener#2462] Add nodeSelector to run only on allowed worker pools

How to categorize this PR? /priority normal /area networking

What this PR does / why we need it: This makes the the following components run only on pools that are allowed to host system components and extensions:

  • calico-kube-controller
  • calico-node-vertical-autoscaler
  • calico-typha-deploy
  • calico-typha-horizontal-autoscaler
  • calico-typha-vertical-autoscaler

Which issue(s) this PR fixes: Relates to https://github.com/gardener/gardener/issues/2462 Needs https://github.com/gardener/gardener/pull/2480

Special notes for your reviewer:

Release note: <!-- Write your release note:

  1. Enter your release note in the below block.
  2. If no release note is required, just write "NONE" within the block.

Format of block header: <category> <target_group> Possible values:

  • category: improvement|noteworthy|action
  • target_group: user|operator|developer -->
All non-DaemonSet resources now respect the node label `worker.gardener.cloud/system-components=true` as introduced by https://github.com/gardener/gardener/pull/2480
+9 -1

0 comment

5 changed files

pr created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 720734323536e195f758fa68591ff06a274b67a2

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

I've adapted the release note.

Do you have a list of components that would need adoption to the feature? So far I'm only aware of gardener-extension-networking-calico

jannickfahlbusch

comment created time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

Resolved all requested changes and squashed the commits together.

Please take a look again :)

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 215c1865eafe99926be92dbd7bf9a57e5d45b621

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func SetDefaults_Worker(obj *Worker) { 	if obj.MaxUnavailable == nil { 		obj.MaxUnavailable = &DefaultWorkerMaxUnavailable 	}-	if obj.AllowSystemComponents == nil {-		obj.AllowSystemComponents = &DefaultWorkerAllowSystemComponents+	if obj.SystemComponents == nil {+		obj.SystemComponents = &WorkerSystemComponents{}+	}+	if obj.SystemComponents.Allow == nil {+		obj.SystemComponents.Allow = &DefaultWorkerSystemComponentsAllow

I've readded the defaulting with https://github.com/gardener/gardener/pull/2480/commits/c159d9da2f77cbaf1a321b71eeeb546a5f76730d but left the helper functions in as I made use of them in the botanist

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 type Worker struct { 	Zones []string } +// WorkerSystemComponents contains configuration for system components related to this worker pool+type WorkerSystemComponents struct {+	// Allow determines whether the pool should be allowed to host system components or not (defaults to true)+	Allow *bool

Removed

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha c159d9da2f77cbaf1a321b71eeeb546a5f76730d

Readd defaulting and make systemComponents.Allow required

view details

push time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func SetDefaults_Worker(obj *Worker) { 	if obj.MaxUnavailable == nil { 		obj.MaxUnavailable = &DefaultWorkerMaxUnavailable 	}-	if obj.AllowSystemComponents == nil {-		obj.AllowSystemComponents = &DefaultWorkerAllowSystemComponents+	if obj.SystemComponents == nil {+		obj.SystemComponents = &WorkerSystemComponents{}+	}+	if obj.SystemComponents.Allow == nil {+		obj.SystemComponents.Allow = &DefaultWorkerSystemComponentsAllow

I've changed the behavior in https://github.com/gardener/gardener/pull/2480/commits/8c17a3de043c1e988f916f4ef0e6b5e4993228af. Please take a look. If it looks good, I'll squash everything together and submit this for a final review

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 8c17a3de043c1e988f916f4ef0e6b5e4993228af

Default systemComopnents internally

view details

push time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

/unassign

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 var _ = Describe("Shoot Validation Tests", func() { 				Maximum:        0, 				MaxSurge:       &maxSurge, 				MaxUnavailable: &maxUnavailable,+				//SystemComponents: systemComponents,

Done

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha d8d9fd5ec90fbce4c0eac4ccc02484eef6fa2d21

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 2e160867744837cd72b53e419cf7c9df84257857

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func SetDefaults_Worker(obj *Worker) { 	if obj.MaxUnavailable == nil { 		obj.MaxUnavailable = &DefaultWorkerMaxUnavailable 	}-	if obj.AllowSystemComponents == nil {-		obj.AllowSystemComponents = &DefaultWorkerAllowSystemComponents+	if obj.SystemComponents == nil {+		obj.SystemComponents = &WorkerSystemComponents{}+	}+	if obj.SystemComponents.Allow == nil {+		obj.SystemComponents.Allow = &DefaultWorkerSystemComponentsAllow

I'm not sure.

I'd like to not have magic where defaulting is happening but not visible on the Shoot CR. If you prefer it the other way around I can change the behavior

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func ValidateWorkers(workers []core.Worker, fldPath *field.Path) field.ErrorList 				atLeastOnePoolWithCompatibleTaints = true 			} 		}++		if atLeastOneActivePool && atLeastOnePoolWithCompatibleTaints {+			if worker.SystemComponents != nil && worker.SystemComponents.Allow != nil && *worker.SystemComponents.Allow {+				atLeastOnePoolWithAllowedSystemComponents = true+			}+		}

Done

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 2836eef8ccdacbb61ec5caaa0d07ea4badb4218b

Ensure that current workerpool is able to host system components

view details

push time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 24c35f5ae7416da9e4acd90060f06bb21b60a2de

[#2462] Add flag AllowSystemComponents to worker options

view details

Jannick Fahlbusch

commit sha ed8c22f9623ffa319e8ac6a1302c909de6740f2d

Adapt struct comments

view details

push time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 8fbeed537088990e6d82965104522a4cff99657f

Add nodeSelector for nginx and K8s Dashboard

view details

push time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

Sounds good, I'll add the node selectors there as well :)

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 var _ = Describe("Defaults", func() { 			Expect(obj.TimeWindow.End).To(HaveSuffix("0000+0000")) 		}) 	})++	Describe("#SetDefaults_Worker", func() {+		var obj *Worker++		BeforeEach(func() {+			obj = &Worker{}+		})++		It("should set the allowSystemComponents field", func() {+			obj.AllowSystemComponents = nil++			SetDefaults_Worker(obj)++			Expect(obj.AllowSystemComponents).To(Equal(&DefaultWorkerAllowSystemComponents))

Changed

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 90e6748fbb4b37b433bdbf16e70facfecb525df7

Adapt Defaulting test

view details

push time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func (b *Botanist) DeployWorker(ctx context.Context) error { 			DataVolumes:           dataVolumes, 			KubeletDataVolumeName: workerPool.KubeletDataVolumeName, 			Zones:                 workerPool.Zones,+			AllowSystemComponents: workerPool.AllowSystemComponents,

Removed

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func ValidateWorkers(workers []core.Worker, fldPath *field.Path) field.ErrorList 	var ( 		allErrs = field.ErrorList{} -		workerNames                        = make(map[string]bool)-		atLeastOneActivePool               = false-		atLeastOnePoolWithCompatibleTaints = len(workers) == 0+		workerNames                               = make(map[string]bool)+		atLeastOneActivePool                      = false+		atLeastOnePoolWithCompatibleTaints        = len(workers) == 0+		atLeastOnePoolWithAllowedSystemComponents = false 	)  	for i, worker := range workers { 		if worker.Minimum != 0 && worker.Maximum != 0 { 			atLeastOneActivePool = true++			if *worker.AllowSystemComponents {+				atLeastOnePoolWithAllowedSystemComponents = true

Done

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 spec:                       values:                         - kube-dns       priorityClassName: system-cluster-critical+      nodeSelector:+        system-components.gardener.cloud/allowed: true

Done

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func (b *Botanist) DeployWorker(ctx context.Context) error { 			workerPool.Labels["node.kubernetes.io/role"] = "node" 		} +		workerPool.Labels[v1beta1constants.LabelWorkerPoolAllowSystemComponents] = strconv.FormatBool(*workerPool.AllowSystemComponents)

Done

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func ValidateWorkers(workers []core.Worker, fldPath *field.Path) field.ErrorList 	var ( 		allErrs = field.ErrorList{} -		workerNames                        = make(map[string]bool)-		atLeastOneActivePool               = false-		atLeastOnePoolWithCompatibleTaints = len(workers) == 0+		workerNames                               = make(map[string]bool)+		atLeastOneActivePool                      = false+		atLeastOnePoolWithCompatibleTaints        = len(workers) == 0+		atLeastOnePoolWithAllowedSystemComponents = false 	)  	for i, worker := range workers { 		if worker.Minimum != 0 && worker.Maximum != 0 { 			atLeastOneActivePool = true++			if *worker.AllowSystemComponents {

Done

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 spec:     # kubeletDataVolumeName: kubelet-dir     # providerConfig:     #   <some-provider-specific-worker-config>+    # allowSystemComponents: true

Done

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 644c7a409f1429ffb944988130beb0c93d763e98

Incorporate review comments

view details

Jannick Fahlbusch

commit sha 72e57d0b7465cb1279f8433133b235f9b026d074

Merge branch 'shootWorkerAllowSystemComponents' of github.com:jannickfahlbusch/gardener into shootWorkerAllowSystemComponents

view details

Jannick Fahlbusch

commit sha 58932c306f9d9e366543515f9c6285ec65a0dcbf

Autogeneration

view details

Jannick Fahlbusch

commit sha ea93f348b9fd851c885497f3e4650bb7ba58709e

Use correct label

view details

push time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

You can probably add it to:

  • nginx-ingress-controller
  • kubernetes-dashboard

I'd like to be able to do this. However I wouldn't consider the plugins as system components.

How do you see that?

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 type WorkerPool struct { 	// Zones contains information about availability zones for this worker pool. 	// +optional 	Zones []string `json:"zones,omitempty"`+	// AllowSystemComponents determines whether the pool should be allowed to host system components or not (defaults to true)+	AllowSystemComponents *bool

Removed due to the comment from @tim-ebert below: https://github.com/gardener/gardener/pull/2480#discussion_r443415041

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 type WorkerPool struct { 	// Zones contains information about availability zones for this worker pool. 	// +optional 	Zones []string `json:"zones,omitempty"`+	// AllowSystemComponents determines whether the pool should be allowed to host system components or not (defaults to true)

Removed due to the comment from @tim-ebert below: https://github.com/gardener/gardener/pull/2480#discussion_r443415041

jannickfahlbusch

comment created time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 spec:     # kubeletDataVolumeName: kubelet-dir     # providerConfig:     #   <some-provider-specific-worker-config>+    # allowSystemComponents: true

Sound reasonable to me, I'll change it

jannickfahlbusch

comment created time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

At the moment the following components would respect the setting:

  • CoreDNS
  • Metrics server
  • Blackbox exporter
  • VPN
jannickfahlbusch

comment created time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

Figured it out:

Since the repo is a Go module I assumed that I can place the repo outside of my GOPATH. When run outside of the GOPATH, make generate finishes without any error but does not generate additional sources.

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 8e1f740a970afb46afe2330158c0550df2948b1f

Add autogenerated sources

view details

push time in 2 months

Pull request review commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

 func ValidateWorkers(workers []core.Worker, fldPath *field.Path) field.ErrorList 	var ( 		allErrs = field.ErrorList{} -		workerNames                        = make(map[string]bool)-		atLeastOneActivePool               = false-		atLeastOnePoolWithCompatibleTaints = len(workers) == 0+		workerNames                               = make(map[string]bool)+		atLeastOneActivePool                      = false+		atLeastOnePoolWithCompatibleTaints        = len(workers) == 0+		atLeastOnePoolWithAllowedSystemComponents = false 	)  	for i, worker := range workers { 		if worker.Minimum != 0 && worker.Maximum != 0 { 			atLeastOneActivePool = true 		} +		// ToDo: Should this also validate that the pool allowing System components is not scaled to zero?

Done

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 36aab552cb44bd5a75f871225cdb39f3ebc19bf6

Adapt test

view details

push time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha e69cd4cd6de75fb73dc4187d0e3254a27f738b87

Incorporate review comments

view details

push time in 2 months

pull request commentgardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

Somehow make generate does not generate the DeepCopy functions. Did I forget something?

jannickfahlbusch

comment created time in 2 months

push eventjannickfahlbusch/flathunter

Jannick Fahlbusch

commit sha 855891695a2deb3131a1b5884aece773e81906a4

Add test

view details

push time in 2 months

create barnchjannickfahlbusch/flathunter

branch : ui-host-port

created branch time in 2 months

PR opened flathunters/flathunter

Add basic Dockerfile

This adds a basic Dockerfile that has to be docker build by the user.

So far it is only starting flathunter without the UI and without an option to persist the database to survive restarts (#23 will make this easier).

I'm planning to add the building of the image to Travis in a separate PR.

+10 -0

0 comment

1 changed file

pr created time in 2 months

create barnchjannickfahlbusch/flathunter

branch : dockerfile

created branch time in 2 months

push eventjannickfahlbusch/flathunter

Jannick Fahlbusch

commit sha 470c940ba4d53b4b02e8932b9ef43979ddeec0d1

Add test

view details

push time in 2 months

push eventjannickfahlbusch/flathunter

Jannick Fahlbusch

commit sha c251e08b2f99982f186c46a6fe0381fbda436cfe

Add test

view details

push time in 2 months

PR opened flathunters/flathunter

Make database location configurable

This adds the configuration option database_location which allows users to configure the location of the database.

The field defaults to the current directory.

+13 -3

0 comment

4 changed files

pr created time in 2 months

create barnchjannickfahlbusch/flathunter

branch : make-databaselocation_configurable

created branch time in 2 months

fork jannickfahlbusch/flathunter

TelegramBot that finds flats on immobilienscout24.de, wg-gesucht.de, ebay-kleinanzeigen.de and immowelt.de [tested this week - working!]

fork in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 4615f36c6a1cb6d6b5f6c5a5c7c2c53eba48dafa

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 0c5591a3c5ba7d443c23fe8cc33623f1f17fdcdd

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

issue commentgardener/gardener

Specify NodeSelector/Affinities for Shoot core components

Here is the PR: https://github.com/gardener/gardener/pull/2480

jannickfahlbusch

comment created time in 2 months

PR opened gardener/gardener

[#2462] Add flag AllowSystemComponents to worker options

How to categorize this PR? /area control-plane /kind enhancement /kind api-change /priority normal

What this PR does / why we need it: This allows to restrict the core components from being able to be scheduled to every worker pool.

I've added the option allowSystemComponents on worker pools which defaults to true. Each node will receive a label system-components.gardener.cloud/allowed with the specified value.

The core components received a nodeSelector for system-components.gardener.cloud/allowed=true

Which issue(s) this PR fixes: Fixes #2462

Special notes for your reviewer: Currently it would be possible to restrict the core-components solely to a worker-group which is scaled to zero. I think this makes no sense. What do you think?

Release note:

It is now possible to restrict core components from running on a worker pool by specifying `allowSystemComponents: false` in the pool definition
+134 -45

0 comment

14 changed files

pr created time in 2 months

push eventjannickfahlbusch/gardener

Jannick Fahlbusch

commit sha 95e8802bd6cd87b0738c9764e5caf03e67087f3e

[#2462] Add flag AllowSystemComponents to worker options

view details

push time in 2 months

create barnchjannickfahlbusch/gardener

branch : shootWorkerAllowSystemComponents

created branch time in 2 months

issue commentgardener/gardener

Specify NodeSelector/Affinities for Shoot core components

I spoke with @vpnachev over Slack. I'll try to contribute the feature.

/assign

jannickfahlbusch

comment created time in 2 months

fork jannickfahlbusch/gardener

Kubernetes-native system managing the full lifecycle of conformant Kubernetes clusters as a service on Alicloud, AWS, Azure, GCP, OpenStack, Packet, MetalStack, and vSphere with minimal TCO.

https://gardener.cloud

fork in 2 months

issue commentgardener/gardener

Specify NodeSelector/Affinities for Shoot core components

Thank you for the suggestions :)

I see that I can and should do this with Taints/Tolerations on the Shoot owner side for the deployed components.

However I think this increases complexity for components that are not directly related to the workload running on the Shoot (As the Core components are deployed by Gardener). If we'd now add a taint to all our "special" worker pools we would need to add tolerations to all components that should run on them. This would mean additional effort for a lot of teams which is not directly related to their work.

As we have many different types of clusters with different types of workload adding taints and tolerations would dramatically increase the work that we'd need to do to force the core-components onto different pools.

Therefore I think having the option to specify allowSystemComponents: false per worker pool would be the most sustainable solution for our use-case.

jannickfahlbusch

comment created time in 2 months

issue openedgardener/gardener

Specify NodeSelector/Affinities for Shoot core components

How to categorize this issue? /area control-plane /kind enhancement /priority normal

What would you like to be added: I'd like to be able to specify nodeSelectors or affinities for the core component that Gardener deploys into each seed so that I can control on which worker pools those components run.

Why is this needed: This is needed as some workerpools might have special hardware or might have very much resources which are reserved for workload.

By letting the core components run wherever they are scheduled they might end up on hardware which is very expensive and should only be used by the intended workload.

Allowing to specify nodeSelectors or affinities would also make it possible to create a dedicated workerpool for core components.

created time in 2 months

create barnchjannickfahlbusch/flathunter

branch : fix-immowelt-size

created branch time in 2 months

fork jannickfahlbusch/flathunter

TelegramBot that finds flats on immobilienscout24.de,ebay-kleinanzeigen.de, immowelt.de and wg-gesucht.de [Working as of 03.03.2020]

fork in 2 months

issue commentkubernetes-sigs/kubebuilder

Support custom ServiceAccount Name in rbac generating

It seems like the option to specify the name of the ServiceAccount from https://github.com/kubernetes-sigs/controller-tools/pull/147 disappeared with https://github.com/kubernetes-sigs/controller-tools/commit/80c3f33947eae2256dd464e544eabfff4884e21b.

Is there currently a way to specify the name of the ServiceAccount?

magicsong

comment created time in 2 months

startedcdr/code-server

started time in 3 months

fork jannickfahlbusch/gardener

Kubernetes-native system managing the full lifecycle of conformant Kubernetes clusters as a service on Alicloud, AWS, Azure, GCP, OpenStack, Packet, MetalStack, and vSphere with minimal TCO.

https://gardener.cloud

fork in 3 months

startedcorona-warn-app/cwa-documentation

started time in 3 months

more