profile
viewpoint

jamesmfriedman/rmwc 1321

A React wrapper for Material Design (Web) Components

jamesmfriedman/flagg 13

Declarative Feature Flagging for your Javascript App

jamesmfriedman/django-easytz 12

Timezone localization without any thinking or doing whatsoever.

jamesmfriedman/django-primer 8

The base coat for your web app.

jamesmfriedman/redux-state-branch 8

A library for simplified Redux development.

jamesmfriedman/3dwave 5

React 3JS Wave

jamesmfriedman/angularjs-starter-kit 2

A starter kit for angualr

jamesmfriedman/ngen 2

A non-opinionated scaffolding generator

jamesmfriedman/staterx 2

State Management with RxJS

pull request commentjamesmfriedman/rmwc

feat(List): selectedIndex && a11y enhancements

Did not forget about this, definitely still going to make it in with the next release.

mgr34

comment created time in 7 days

issue commentjamesmfriedman/rmwc

Feature: Multiline text fields

I agree, this would be very useful.

I've built a 101 of these in the past, there are some really easy ways to make it happen. I'll look into it.

nickmccurdy

comment created time in 7 days

push eventjamesmfriedman/rmwc

Ryan Bare

commit sha ed0f0091eaddb1e64f98b73e433f816a0a70a961

fix(Tab): activeTabIndex always updating automatically

view details

James Friedman

commit sha bcd1b728e505ce2caab62ecd4a33010ca24ee8da

Merge pull request #661 from rbare1/rbare1/606-tab-bar-always-updates fix(Tab): activeTabIndex always updating automatically

view details

push time in 8 days

PR merged jamesmfriedman/rmwc

fix(Tab): activeTabIndex always updating automatically

Before: 2020-06-29_15-32-31

After: 2020-06-29_15-14-17

https://github.com/jamesmfriedman/rmwc/issues/606

+29 -1

4 comments

2 changed files

rbare1

pr closed time in 8 days

pull request commentjamesmfriedman/rmwc

fix(Tab): activeTabIndex always updating automatically

Thanks for doing this, will go out in the next release.

rbare1

comment created time in 8 days

pull request commentjamesmfriedman/rmwc

fix(Tab): activeTabIndex always updating automatically

Seems reasonable. Thanks for the gif. I assume that the "Always 1" tab is the thing you were fixing?

rbare1

comment created time in 8 days

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 68804689bd86972e768b11a3d35cc31efa323a1d

Building docs

view details

push time in 12 days

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 1bf5eb77f176e844e41aa9b1f098892cb6507191

Building docs

view details

push time in 12 days

issue commentOpenAPITools/openapi-generator

[BUG] OpenAPI 4.0.2 not able to generate anyOf models.

I'm seeing this in the latest using the typescript-fetch generator.

It improperly returns invalid javascript that points to a class, a typescript single pipe, and a function that isn't actually defined.

'item': Item | numberToJSON(value.itemId),
charmygarg

comment created time in 12 days

issue commentjamesmfriedman/rmwc

Menu run time error when used within Dialog and hoistToBody is true

There something preventing you from upgrading to v6 @liamcmitchell-sc ?

majames

comment created time in 20 days

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 46d54c9cff74239f3f457a6491329e4b834ec38e

Adding repo

view details

me@jamesmfriedman.com

commit sha aee8311698db145e45e27131cd3964e884d45259

Work on devtools

view details

me@jamesmfriedman.com

commit sha 179c4a85653de19f0a57cbe0cd1aff4b0dfec2bc

More work on dev tools

view details

me@jamesmfriedman.com

commit sha e94c6a2456d843c8c13500e4d170ecb200c1116a

0.0.1

view details

me@jamesmfriedman.com

commit sha 9b887358a96e4b3fe5e038ed490ca2357b92d024

0.0.2

view details

push time in 22 days

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha 1be35e6b5dd2f6795b29244b6551baf3fc042181

Building docs

view details

push time in 23 days

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha b5b67e5ff3c68d5f28259dc74d796c3a72662aa1

Generating Props

view details

me@jamesmfriedman.com

commit sha d833c2c7c1931e80ba1cba4276b287ad851b1e7c

Updating Changelog

view details

me@jamesmfriedman.com

commit sha 0c517b3609c3f39d11b663fbe9871eec6d0033bf

v6.1.3

view details

push time in 23 days

created tagjamesmfriedman/rmwc

tagv6.1.3

A React wrapper for Material Design (Web) Components

created time in 23 days

issue commentjamesmfriedman/rmwc

<Select /> onChange handler does not trigger in jsdom

@astrofrans I'll be upgrading this library to the newest version of material-components-web in the near future. These maintenance upgrades are usually not that bad, except in the last 2 versions they have decided to continuously refactor the select. Not only is this maddening for me, it also causes more issues such as this. I can definitely look into the issue, but not before I have to re-rewrite the select again.

tstirrat

comment created time in 23 days

issue commentjamesmfriedman/rmwc

Export DialogQueueSpec

Releasing now, should be live in a few minutes.

aktary

comment created time in 23 days

push eventjamesmfriedman/rmwc

David Aktary

commit sha 31776cc348354173e677dd258ce886a543bc0a78

Export DialogQueueSpec Fixes #646

view details

James Friedman

commit sha 07dc2357a9ceef63cacd6ac56f98469fb8e78272

Merge pull request #657 from aktary/patch-1 Export DialogQueueSpec

view details

push time in 23 days

PR merged jamesmfriedman/rmwc

Export DialogQueueSpec

Fixes #646

+1 -1

2 comments

1 changed file

aktary

pr closed time in 23 days

issue closedjamesmfriedman/rmwc

Export DialogQueueSpec

  • What RMWC Version are you using [major.minor.patch]: 6.0.14

  • Name your build system [Webpack, Rollup...]: Parcel

  • Describe the bug with as much detail as possible: Simple TypeScript issue. Need to add the export keyword to DialogQueueSpec in dialog-queue.d.ts

  • What happened, and what was supposed to happen: Without the export, TS complains:

Exported variable 'dialogQueue' has or is using name 'DialogQueueSpec' from external module ".../node_modules/@rmwc/dialog/dist/dialog-queue" but cannot be named.

Adding the export keyword will fix it.

closed time in 23 days

aktary

pull request commentjamesmfriedman/rmwc

Export DialogQueueSpec

Thanks!

aktary

comment created time in 23 days

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha 09dc00c8a2456b455a8388d3465d011ccd3fcf67

Building Docs

view details

push time in a month

IssuesEvent

issue commentjamesmfriedman/rmwc

SimpleMenu breaks when adding "renderToPortal" prop

@anthonysapien thanks for reporting that. I think it has to do with event bubbling through React portals and the fact that MDC doesn't use react events, but standard DOM ones. I'll have to inspect more.

For now, here is a non-ideal, but working solution. https://codesandbox.io/s/rmwc-sandbox-omw4n

anthonysapien

comment created time in a month

issue commentjamesmfriedman/rmwc

SimpleMenu breaks when adding "renderToPortal" prop

That specific example the open prop is always set to true. Just add renderToPortal to any others, it works as expected

anthonysapien

comment created time in a month

issue closedjamesmfriedman/rmwc

Navigation Drawer List Item Icon color doesn't use theme color when in active state, differs from the text color.

This is an issue with a MDC styles that will require a patch in '@rmwc/theme/theme.css'.

  • What RMWC Version are you using [major.minor.patch]: 6.0.9

  • Name your build system [Webpack, Rollup...]: Ejected CRA

  • Describe the bug with as much detail as possible: When using a custom theme, the color of the icon in the active menu item inside the navigator drawer is incorrect. This occurs even with the theme.css stylesheet loaded.

  • What happened, and what was supposed to happen: The icon color was the default purple instead of the custom color as defined by the theme. I expected the theme.css stylesheet to fix it like it fixed the color of the text.

image

closed time in a month

kintz09

issue closedjamesmfriedman/rmwc

Typo in rmwc.io/provider page example

<!--- ** PLEASE READ THIS BEFORE FILING AN ISSUE **

RMWC or MDC?

RMWC is a React wrapper for Google's official MDC that provides a props based interface for their components. Is the bug being caused by RMWC, or MDC? Please do your best to track down where the bug is originating from and post your issue to the proper repository. MDC bugs should be filed here https://github.com/material-components/material-components-web/issues.

Do you really want it fixed? Make a repro in the sandbox!

  • Javascript Sandbox https://codesandbox.io/s/rmwc-sandbox-o0s0d
  • Typescript Sandbox https://codesandbox.io/s/rmwc-typescript-sandbox-y7516 -->
  • RMWC v6.1.0

  • Typo in rmwc.io/provider page example

  • tootlip={{ align: 'right' }} will be tooltip={{ align: 'right' }}

closed time in a month

meghoshpritam

issue commentjamesmfriedman/rmwc

Typo in rmwc.io/provider page example

Fixed

meghoshpritam

comment created time in a month

issue closedjamesmfriedman/rmwc

QUESTION (stuck..): what is the the most right & simple way to style a component

Hey, im trying to use RMWC in order to implement custom components (suppose to look totally different). I started with a classic Input component & I am really struggling with finding the way to do that. i read in the docs that the right approach is to override the RMWC classes, but im finding myself filling my css files with very large & repetitive selectors, which looks and feels really bad. What am i missing?? there has to be a better approach. in addition, is there anyway not to use some of the classes (for example, Ripple effect).

THANKS!!

closed time in a month

ziperfal123

issue closedjamesmfriedman/rmwc

SimpleMenu breaks when adding "renderToPortal" prop

<!--- ** PLEASE READ THIS BEFORE FILING AN ISSUE **

RMWC or MDC?

RMWC

RMWC is a React wrapper for Google's official MDC that provides a props based interface for their components. Is the bug being caused by RMWC, or MDC? Please do your best to track down where the bug is originating from and post your issue to the proper repository. MDC bugs should be filed here https://github.com/material-components/material-components-web/issues.

Do you really want it fixed? Make a repro in the sandbox!

  • Javascript Sandbox https://codesandbox.io/s/rmwc-sandbox-o0s0d
  • Typescript Sandbox https://codesandbox.io/s/rmwc-typescript-sandbox-y7516 --> Here's a sandbox: https://codesandbox.io/s/rmwc-sandbox-ybu69?file=/index.js
  • What RMWC Version are you using [major.minor.patch]: 6.1.0

  • Name your build system [Webpack, Rollup...]: create-react-app

  • Describe the bug with as much detail as possible: Adding the renderToPortal prop to SimpleMenu causes the menu to no longer handle menu item selection.

  • What happened, and what was supposed to happen: When I add the renderToPortal property, if I open the SimpleMenu and click a menu item, the menu stays open and the onSelect event handler does not fire.

I expect the menu to close and the onSelect event handle to fire.

Thanks!

closed time in a month

anthonysapien

issue commentjamesmfriedman/rmwc

SimpleMenu breaks when adding "renderToPortal" prop

Confirming this is fixed in 6.1.2. You can try adding it in the docs to see. https://rmwc.io/menus

anthonysapien

comment created time in a month

issue closedjamesmfriedman/rmwc

Can I make a Select clearable?

  • What RMWC Version are you using [major.minor.patch]: 6.1.0

  • Name your build system [Webpack, Rollup...]: Webpack

  • Describe the bug with as much detail as possible: I'm creating an outlined <Select> component which I need to be clearable. I'll try to explain myself: I create this select:

        <Select
            outlined
            label="My Field Name"
            options={["Element 1", "Element 2"]}
        />

Once I select an option, I cannot clear the field. There is an empty option which is created automatically by the component to include the placeholder, but it's disabled and I cannot select it again.

Here is an example: https://codesandbox.io/s/rmwc-select-not-clearable-uz6xl

  • What happened, and what was supposed to happen: The behavior described above (being able to clear a selection), is the default behavior for the original material library. See here: https://material-components.github.io/material-components-web-catalog/#/component/select

Is this a bug? Is this done intentionally? I have been digging in the documentation but I can't find a way to make it clearable.

Thanks!!

closed time in a month

jjimenezlopez

issue commentjamesmfriedman/rmwc

Can I make a Select clearable?

Closing due to inactivity. Please direction questions to Discord or Stack Overflow.

jjimenezlopez

comment created time in a month

issue commentjamesmfriedman/rmwc

Building for production RMWC styles not working

Closing due to inactivity.

TrySpace

comment created time in a month

issue closedjamesmfriedman/rmwc

Building for production RMWC styles not working

RMWC Version: 5.7.1 Build system: Webpack

It works for development, but not for production.

I'm not using modules, but I've tried every combination described here: https://rmwc.io/installation But it's not including or building any rmwc css at all, it is including all my own scss classes.

My webpack.common file:

const path = require("path");

module.exports = {
  entry: {
    popup: path.join(__dirname, "src/popup/index.tsx"),
    newtab: path.join(__dirname, "src/newtab/index.tsx"),
    background: path.join(__dirname, "src/background/background.ts"),
    tabs: path.join(__dirname, "src/background/tabs.ts"),
    options: path.join(__dirname, "src/options/index.tsx"),

    contextmenu: path.join(__dirname, "src/contextmenu/contextmenu.ts"),
    omnibox: path.join(__dirname, "src/libs/omnibox.ts"),
    init: path.join(__dirname, "src/content_scripts/init.ts")
  },
  output: {
    path: path.join(__dirname, "dist/js"),
    filename: "[name].js"
  },
  module: {
    rules: [
      {
        exclude: /node_modules/,
        test: /\.tsx?$/,
        use: "ts-loader"
      },
      {
        test: /\.css$/,
        use: [
            {
                loader: 'style-loader',
            },
            {
                loader: 'css-loader',
                options: {
                    sourceMap: true,
                    importLoaders: 2,
                },
            }
        ],
      },
      {
        exclude: /node_modules/,
        test: /\.scss$/,
        use: [
          {
            loader: "style-loader" // Creates style nodes from JS strings
          },
          {
            loader: "css-loader" // Translates CSS into CommonJS
          },
          {
            loader: "sass-loader" // Compiles Sass to CSS
          }
        ]
      }
    ]
  },
  resolve: {
    extensions: [".ts", ".tsx", ".js"]
  }
};

It is a chrome extension, but when running from webpack in development mode, it works...

webpack.prod.js:

const merge = require("webpack-merge");
const common = require("./webpack.common.js");

module.exports = merge(common, {
  mode: "production"
});

webpack.dev.js:

const merge = require("webpack-merge");
const common = require("./webpack.common.js");

module.exports = merge(common, {
  mode: "development",
  devtool: "inline-source-map",
});

I'm sure I'm missing some basic thing here.

Do I need to compile css files separately and use some plugin to inject the import? I'd prefer having the css compiled with the build, and perhaps embedded in the index.js?

package.json scripts:

"scripts": {
    "build": "webpack --config webpack.prod.js",
    "dev": "webpack --config webpack.dev.js",
    "start": "webpack -w --config webpack.dev.js",
}

An example of how I import the styles in a tsx file:


import '../../node_modules/material-components-web/dist/material-components-web.min.css';
import '@rmwc/circular-progress/circular-progress.css';
import '@rmwc/icon/icon.css';
import '@rmwc/tooltip/tooltip.css';
import '@rmwc/avatar/avatar.css';

Again development mode works fine, so I would say all the code itself should not have to change, only the webpack config.. but what exactly?

closed time in a month

TrySpace

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha ffb1ffaebf231acac3bd3d1f57ce9d381c331dae

Building docs

view details

push time in a month

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha 46ffd52dd0be094b66c6f97bed857d70ac4c1827

Commiting updates

view details

me@jamesmfriedman.com

commit sha bfc40d77ca75fc8b8557a5d90769ad4377cff82a

Generating Props

view details

me@jamesmfriedman.com

commit sha c06c9d42c5f81eeb5fa64acfee24d6434ec03704

Updating Changelog

view details

me@jamesmfriedman.com

commit sha 665241e2488e957c08efc631a3a8caf163015cb2

v6.1.2

view details

push time in a month

created tagjamesmfriedman/rmwc

tagv6.1.2

A React wrapper for Material Design (Web) Components

created time in a month

issue closedjamesmfriedman/rmwc

How to set selected drawer item background color to primary?

All the examples show a light grey background but none show the background using primary color

Example: Shot 2020-05-27 at 12 45 28

Requested example: Shot 2020-05-27 at 12 43 25

closed time in a month

jahirfiquitiva

issue commentjamesmfriedman/rmwc

How to set selected drawer item background color to primary?

Please post questions on either stack overflow or on the Discord channel.

jahirfiquitiva

comment created time in a month

issue commentjamesmfriedman/rmwc

Support overriding material-icons with @mdi/font

that does appear to be setup properly, but I'd need to see a repro in order to better assist. At any rate, it is indeed supported. Stackoverflow is a better place for questions since I don't believe there is a bug present here.

Is it possible that you forgot to include your icon font?

jahirfiquitiva

comment created time in a month

issue commentjamesmfriedman/rmwc

How to set selected drawer item background color to primary?

I believe you are just looking for the activated prop

jahirfiquitiva

comment created time in a month

issue commentjamesmfriedman/rmwc

Dialog Focus a different element on open?

Not out of the box, it just looks for the first focusable element. As a workaround I'm sure you can re-arrange the DOM, or or focus the element you want in the onOpen callback.

mike391

comment created time in a month

issue commentjamesmfriedman/rmwc

Clicking Tab submits form

That is very interesting and something we should likely report upstream as well. I'll take a look

aktary

comment created time in a month

created tagjamesmfriedman/rmwc

tagv6.1.1

A React wrapper for Material Design (Web) Components

created time in a month

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha 644d0071e6433180ffca90adba95c21454e1bab3

Generating Props

view details

me@jamesmfriedman.com

commit sha 32d46a408aa89613965d59253210623b8b591a94

Updating Changelog

view details

me@jamesmfriedman.com

commit sha d9befec0e3b258864b71686eecd16c16feb43cf1

v6.1.1

view details

push time in a month

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha c1b6631c757cabcdc8ce6fdefa58b0dd94974335

Fixing some docs examples

view details

push time in a month

IssuesEvent

issue commentjamesmfriedman/rmwc

RMWC tabs not working in IE11 browser, working fine in chrome

Great. Let me know what you find and I'll be proactive about getting the PRs in.

RojyKumari

comment created time in a month

issue commentjamesmfriedman/rmwc

RMWC tabs not working in IE11 browser, working fine in chrome

@liamcmitchell-sc I understand and want to be supportive of that initiative. I think the largest hurdle you'll run into will be material-components-web. I don't know about their support coverage, but I seem to recall them ditching IE11 a while ago.

If there are issues that are fixable in here and it's sensible I'm absolutely fine including it. Anything that can be polyfilled though should be done outside of this library.

RojyKumari

comment created time in a month

pull request commentjamesmfriedman/rmwc

feat(List): selectedIndex && a11y enhancements

@mgr34 if you can fix the conflicts I'll get this in

mgr34

comment created time in a month

push eventjamesmfriedman/rmwc

33577

commit sha c4ff766436245fefab248fa5460c264d045c153e

fix(top-app-bar): Fix wrong className for TopAppBarAdjust

view details

James Friedman

commit sha 8c87e801f56f47b484361a94d7ce998e10780115

Merge pull request #635 from 33577/master fix(top-app-bar): Fix wrong className for TopAppBarAdjust

view details

push time in a month

PR merged jamesmfriedman/rmwc

fix(top-app-bar): Fix wrong className for TopAppBarAdjust

Hi, I want to resolve this issue, #634. Since media query, className mdc-top-app-bar--fixed-adjust has higher priority than .mdc-top-app-bar--dense-fixed-adjust in <TopAppBarFixedAdjust dense />.

So, I want to add className mdc-top-app-bar--fixed-adjust when all props (dense, denseProminent, prominent, short) are undefined or false. Since the only css property that mdc-top-app-bar--fixed-adjust or .mdc-top-app-bar--dense-fixed-adjust manipulates is padding-top, I think this PR makes sense. But, I know this PR makes the className mdc-top-app-bar--fixed-adjust loose its role as default className for <TopAppBarFixedAdjust /> In addition, I'm worried since this line need update if another property of TopAppBarFixedAdjust is created newly.

If you have more appropriate idea, please let me know.

Thanks!!

image

(In <TopAppBarFixedAdjust dense />, I want 48px padding-top but 56px is activated)

resolve: #634

+1 -1

1 comment

1 changed file

33577

pr closed time in a month

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha ac05b49f73f206cf8c934b3ea469e8e13274ebf1

Fixing formatting for merge

view details

push time in a month

push eventjamesmfriedman/rmwc

me@jamesmfriedman.com

commit sha 780d3b551ccc9734bc4cc367bbbada6e6d6b2348

Fixing bad merge

view details

push time in a month

push eventjamesmfriedman/rmwc

dependabot[bot]

commit sha b5902f81351014f31f9450ca075594ca5b710910

Bump websocket-extensions from 0.1.3 to 0.1.4 Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

James Friedman

commit sha cc02a808eaf764b6161c299ed2adafac9df7cf65

Merge pull request #653 from jamesmfriedman/dependabot/npm_and_yarn/websocket-extensions-0.1.4 Bump websocket-extensions from 0.1.3 to 0.1.4

view details

push time in a month

PR merged jamesmfriedman/rmwc

Bump websocket-extensions from 0.1.3 to 0.1.4 dependencies

Bumps websocket-extensions from 0.1.3 to 0.1.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+25 -25

1 comment

1 changed file

dependabot[bot]

pr closed time in a month

push eventjamesmfriedman/rmwc

Grigory Bogush

commit sha 4a3e57d95ebc0312176eeea6f01850f3d22f62f2

fix(Select): fixed menu props not frowarding for enhanced select

view details

James Friedman

commit sha f11693ea20059c0e125ea1139a3939461a2583a1

Merge pull request #649 from grigory-bogush/enhanced_select_menu_props_fix fix(Select): fixed menu props not forwarding for enhanced select

view details

push time in a month

PR merged jamesmfriedman/rmwc

fix(Select): fixed menu props not forwarding for enhanced select

This bug did not allow MenuProps like "renderToPortal" to be forwarded to menu for enhanced select when passing in an object in "enhanced" prop.

+3 -0

4 comments

1 changed file

grigory-bogush

pr closed time in a month

pull request commentjamesmfriedman/rmwc

fix(Select): fixed menu props not forwarding for enhanced select

@nicholaschiang sorry for the delay on yours. I just checked it out, yours would cause a regression since we still need the {...rest} props as well. Going to merge this one in favor of that.

grigory-bogush

comment created time in a month

push eventjamesmfriedman/rmwc

Ixl123

commit sha a54056d4becf757558f056d906a66eff09577fd6

🐛 FIX: should fix

view details

James Friedman

commit sha fd06e51c6a4c86e34406499d7737c50b347abdeb

Merge pull request #630 from JCofman/jcofman/fix/data-table-controlled-sort fix(DataTable): datable controlled sorting #624

view details

push time in a month

PR merged jamesmfriedman/rmwc

fix(DataTable): datable controlled sorting #624

You can now provide a click handler on DataTableHeadCell without passing onSortedChange function to manage sort icon of the DataTable fixes #624 and adds some a storybook file as well as some basic examples for the DataTable

+394 -134

1 comment

5 changed files

JCofman

pr closed time in a month

issue closedjamesmfriedman/rmwc

Datable controll sort without providing onSortChange prop

Hi ✌️,

I found an interesting behavior in the Datatable when using sorting and trying to control sort with a prop without using the onSortChange callback.

repo -> https://codesandbox.io/s/rmwc-typescript-sandbox-md4ui?file=/src/index.tsx

  • What RMWC Version are you using: Using the latest version 6.1.0

  • Name your build system: Create React App with typescript support

  • Describe the bug with as much detail as possible: I want to sort the datable by jut providing a sort prop. This is currently only possible when you provide an onSortChange function.

  • What happened, and what was supposed to happen: You have to provide sort and onSortChange prop to sort the table but onSortChange is an optional prop. You should be able to sort the table by providing just the sort prop.

I can work on that and create a PR :)

closed time in a month

JCofman

pull request commentjamesmfriedman/rmwc

fix(DataTable): datable controlled sorting #624

Awesome, looks great!

JCofman

comment created time in a month

push eventjamesmfriedman/rmwc

Choi Geonu

commit sha fd6a73b6573413ccb0bbfe41171ef3e272ae30ea

fix(TopAppBar): Add classname tests for TopAppBarFixedAdjust component

view details

Choi Geonu

commit sha 905f9c8e21fa26007497eb9d8108dbd44c5d19df

fix(TopAppBar): Fix TopAppBarFixedAdjust to pass broken tests

view details

James Friedman

commit sha e950d60d1eb598890aec372856ebd27000c8e967

Merge pull request #640 from Hardtack/master fix(TopAppBar): Wrong className for TopAppBarFixedAdjust

view details

push time in a month

PR merged jamesmfriedman/rmwc

fix(TopAppBar): Wrong className for TopAppBarFixedAdjust

It fixes #634

This PR adds some tests for checking class names in TopAppBarFixedAdjust components and updates code to pass the tests

+38 -14

2 comments

2 changed files

Hardtack

pr closed time in a month

issue closedjamesmfriedman/rmwc

Wrong className for TopAppBarFixedAdjust

<!--- ** PLEASE READ THIS BEFORE FILING AN ISSUE **

RMWC or MDC?

RMWC is a React wrapper for Google's official MDC that provides a props based interface for their components. Is the bug being caused by RMWC, or MDC? Please do your best to track down where the bug is originating from and post your issue to the proper repository. MDC bugs should be filed here https://github.com/material-components/material-components-web/issues.

Do you really want it fixed? Make a repro in the sandbox!

  • Javascript Sandbox https://codesandbox.io/s/rmwc-sandbox-o0s0d
  • Typescript Sandbox https://codesandbox.io/s/rmwc-typescript-sandbox-y7516 -->
  • What RMWC Version are you using [major.minor.patch]:

6.0.14

  • Name your build system [Webpack, Rollup...]:

Webpack (Next.js)

  • Describe the bug with as much detail as possible:

When I try to use TopAppBarFixedAdjust with dense prop. RMWC adds both mdc-top-app-bar--fixed-adjust and mdc-top-app-bar--dense-fixed-adjust to className.

<TopAppBarFixedAdjust dense />
<div class="mdc-top-app-bar--fixed-adjust mdc-top-app-bar--dense-fixed-adjust"></div>

But, mdc-top-app-bar--dense-fixed-adjust is not an option of mdc-top-app-bar--fixed-adjust but an independent component. So it should render like following

<div class="mdc-top-app-bar--dense-fixed-adjust"></div>

See the Code Sandbox for demo.

  • What happened, and what was supposed to happen:

The problem of adding both classnames happens when I use it on the mobile web. The default top app bar shrinks its height when the window size is smaller than 600px. So mdc-top-app-bar--fixed-adjust also shrinks its top margin.

Since (media query + class name) has higher priority than (class name only) the top margin value of mdc-top-app-bar--fixed-adjust, which is greater than margin value for dense one, will be used for rendering. So it breaks UI.

So TopAppBarFixedAdjust should add classnames exclusively.

closed time in a month

Hardtack

pull request commentjamesmfriedman/rmwc

fix(TopAppBar): Wrong className for TopAppBarFixedAdjust

Looks good, thanks!

Hardtack

comment created time in a month

issue closedjamesmfriedman/rmwc

Responsive example

Hello

I just wanted to ask for a responsive example. I think the framework isn't mobile-first, so it's been hard for me to achieve a responsive result.

Would be great to have better support for that.

Thanks

closed time in a month

jahirfiquitiva

issue commentjamesmfriedman/rmwc

Responsive example

No problem

jahirfiquitiva

comment created time in a month

issue commentjamesmfriedman/rmwc

Responsive example

They're hacked together, but you can find some examples of mobile implementation on there. Honestly I think the only difference is the main navigation.

https://github.com/jamesmfriedman/rmwc/tree/master/src/rmwc/docs

jahirfiquitiva

comment created time in a month

issue commentjamesmfriedman/rmwc

Responsive example

@jahirfiquitiva the docs themselves are responsive. Material design itself is modeled to be mobile first and mobile friendly. Have you checked the material.io for design guidance?

jahirfiquitiva

comment created time in a month

pull request commentjamesmfriedman/rmwc

feat(List): selectedIndex && a11y enhancements

You know @mgr34 extremely busy, but the good news is that I'll be devoting quite a bit of time to RMWC coming up, so this is not forgotten.

mgr34

comment created time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha a5d9efa5f877847eb20519e5e27e902f8055b87a

Updating redux dev tools

view details

me@jamesmfriedman.com

commit sha 4eb074236c4289ff4420fd4057f397f90a766576

Updating docs

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 724646ce7e6e739fc993b28ec71a2bb12118c6e2

building docs

view details

me@jamesmfriedman.com

commit sha af0555883044389d7a71a97ad767b60cf16f1314

Merge branch 'master' of github.com:jamesmfriedman/staterx

view details

push time in a month

push eventjamesmfriedman/staterx

James Friedman

commit sha dd9a8d59c22d3f18d3ffeff7594dd80a142ed27a

Update README.md

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha dc8f3a6662484f44fa4cc09e7b1d7c88f0c1f3e3

Updating readme

view details

me@jamesmfriedman.com

commit sha d1c1076ab046525ea7675642cb7138bd9d098be8

Merge branch 'master' of github.com:jamesmfriedman/staterx

view details

push time in a month

push eventjamesmfriedman/staterx

James Friedman

commit sha 498eba7181cf8c695bb2f49bfc8c65375c4d78dd

Update main.yml

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 4b3cc3a1412951b4e138e994f0dbdeae3aa85c7a

Adding postinstall script

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha fecf79d6c7445f5e7d6a50a565365e2091663006

Adding test

view details

me@jamesmfriedman.com

commit sha 59ba0bcc7365f7b269a316baa67b1ee9b9adbf3e

Merge branch 'master' of github.com:jamesmfriedman/staterx

view details

push time in a month

push eventjamesmfriedman/staterx

James Friedman

commit sha d2ce1f46bfee716c3b7ce2cadc570b48cbbe436d

Create main.yml

view details

push time in a month

push eventjamesmfriedman/staterx

James Friedman

commit sha 226c3810489cbc5100669c97d80e237731b15ca1

Create LICENSE

view details

James Friedman

commit sha 98b8a94ca595b77af926bc0aecbbce6c4665b595

Merge pull request #1 from jamesmfriedman/add-license-1 Create LICENSE

view details

push time in a month

create barnchjamesmfriedman/staterx

branch : add-license-1

created branch time in a month

PR opened jamesmfriedman/staterx

Create LICENSE
+21 -0

0 comment

1 changed file

pr created time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 72caeb5a4627da77fac0e89de0d3929e2e9b6a9d

Building docs

view details

me@jamesmfriedman.com

commit sha 2bacb4d37388d170488630c336c502817bcf679c

Building docs

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 00ce5265bc81ada01c38ac6752e0b13532412992

Building docs

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 922d32c1cf7e89ae9489b5149dc22cde40793c30

Building docs

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha b84d258548146bf0a283fbc9b54dda7f0c5b0ccb

Building docs

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 929ced994a0dd6deb2b511a8c53ed0e8d49237da

Building docs

view details

me@jamesmfriedman.com

commit sha 4b8cecb2c7467d05067d62e1254a39166440189c

Building docs

view details

push time in a month

push eventjamesmfriedman/staterx

me@jamesmfriedman.com

commit sha 86757b170a688d8b4f1e580e279307db79b2c93f

Checkpoint

view details

me@jamesmfriedman.com

commit sha b8326e68d3d51d2e5e7384c2ade1be1a90bfc132

Checkpoint

view details

me@jamesmfriedman.com

commit sha 5004e0fa34025f63343ba6ab1e559b1be76ba473

Added canvas renderer

view details

me@jamesmfriedman.com

commit sha 9c6b5837c44e5f6cd68b3de844a38c51d5e4e7f7

Lots of docs

view details

me@jamesmfriedman.com

commit sha 8f521266b371298127ce3260f0175fc7f458aa2c

Building docs

view details

me@jamesmfriedman.com

commit sha f83eab0985e7ab2a9c34f20013e8a84e68c50f45

Building docs

view details

push time in a month

issue commentdoczjs/docz

External link in menu

For a little more information, it appears to render a link, it just only inserts '/'. image

xaviergonz

comment created time in a month

issue commentdoczjs/docz

External link in menu

Same issue for me

xaviergonz

comment created time in a month

issue commentjamesmfriedman/rmwc

Export DialogQueueSpec

Never had this issue. Is it possible that this is a tsconfig setting?

aktary

comment created time in a month

issue commentjamesmfriedman/rmwc

Clicking fab makes site reload

Just wrapping them in divs or a BR. They're inline-block by default.

jahirfiquitiva

comment created time in a month

issue commentjamesmfriedman/rmwc

Clicking fab makes site reload

I don't know what your code looks like, but I'm reasonably certain that fab doesn't have anything to do with it

jahirfiquitiva

comment created time in a month

issue commentjamesmfriedman/rmwc

Building for production RMWC styles not working

Whatever your build system is, it’s dropping side effects. You need to whitelist css files as non tree shakeable. Look into webpack tree shaking, this isn’t an RMWC thing.

TrySpace

comment created time in a month

issue commentjamesmfriedman/rmwc

Can't set value from Menu selection in TextField

Not sure about your specific issue, but this just sounds like a standard react thing and maybe a gap in knowledge.

Here is a super basic example of using a controlled textfield and setting the value. This isn't RMWC specific, the same would work with a standard input.

https://codesandbox.io/s/rmwc-typescript-sandbox-37131?file=/src/index.tsx

francos

comment created time in 2 months

more