profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jalandis/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
John Landis jalandis Philadelphia

brendanfmartin/weather_tracker 0

Track the accuracy of weather forecasts

jalandis/congress-ember 0

Ember ProPublica Congress API Explorer

jalandis/congress-go-api 0

Wrapper for ProPublica Congress API

jalandis/crongo 0

Simple GO cron system

jalandis/elm-analyse 0

A tool that allows you to analyse your Elm code, identify deficiencies and apply best practices.

jalandis/elm-datepicker 0

A reusable date picker component in Elm 0.19.

jalandis/elm-protobuf 0

protobuf plugin for elm

jalandis/ember-elm 0

Write Elm in your Ember app

push eventjalandis/marketing-poc-gatsby-netlify

dependabot-preview[bot]

commit sha ab1df464a4537adda0d3dc2c61090fea6cae8092

chore(deps): [security] bump color-string from 1.5.3 to 1.5.5 Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.3 to 1.5.5. **This update includes a security fix.** - [Release notes](https://github.com/Qix-/color-string/releases) - [Changelog](https://github.com/Qix-/color-string/blob/master/CHANGELOG.md) - [Commits](https://github.com/Qix-/color-string/commits/1.5.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 6d3909cf344d17eaf617c906e83f5fd3d98eb5bd

Merge pull request #22 from jalandis/dependabot/npm_and_yarn/color-string-1.5.5

view details

push time in 16 hours

delete branch jalandis/marketing-poc-gatsby-netlify

delete branch : dependabot/npm_and_yarn/color-string-1.5.5

delete time in 16 hours

PR merged jalandis/marketing-poc-gatsby-netlify

chore(deps): [security] bump color-string from 1.5.3 to 1.5.5 dependencies security

Bumps color-string from 1.5.3 to 1.5.5. This update includes a security fix. <details> <summary>Vulnerabilities fixed</summary> <p><em>Sourced from <a href="https://github.com/advisories/GHSA-257v-vj4p-3w2h">The GitHub Security Advisory Database</a>.</em></p> <blockquote> <p><strong>Regular Expression Denial of Service (ReDOS)</strong> A Regular Expression Denial of Service (ReDOS) vulnerability was discovered in Color-String version 1.5.5 and below which occurs when the application is provided and checks a crafted invalid HWB string.</p> <p>Affected versions: < 1.5.5</p> </blockquote> </details> <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Qix-/color-string/releases">color-string's releases</a>.</em></p> <blockquote> <h2>1.5.5 (Patch/Security Release) - hwb() ReDos patch (low-severity)</h2> <blockquote> <p>Release notes copied verbatim from the commit message, which can be found here: 0789e21284c33d89ebc4ab4ca6f759b9375ac9d3</p> </blockquote> <pre><code>Discovered by Yeting Li, c/o Colin Ife via Snyk.io. <p>A ReDos (Regular Expression Denial of Service) vulnerability was responsibly disclosed to me via email by Colin on Mar 5 2021 regarding an exponential time complexity for linearly increasing input lengths for <code>hwb()</code> color strings.</p> <p>Strings reaching more than 5000 characters would see several milliseconds of processing time; strings reaching more than 50,000 characters began seeing 1500ms (1.5s) of processing time.</p> <p>The cause was due to a the regular expression that parses hwb() strings - specifically, the hue value - where the integer portion of the hue value used a 0-or-more quantifier shortly thereafter followed by a 1-or-more quantifier.</p> <p>This caused excessive backtracking and a cartesian scan, resulting in exponential time complexity given a linear increase in input length.</p> <p>Thank you Yeting Li and Colin Ife for bringing this to my attention in a secure, responsible and professional manner.</p> <p>A CVE will not be assigned for this vulnerability. </code></pre></p> <h2>1.5.4 (Patch Release)</h2> <ul> <li>Removes rounding of alpha values in RGBA hex (<code>#rrggbbaa</code>) and condensed-hex (<code>#rgba</code>) parsers, which caused certain unique inputs to result in identical outputs (see <a href="https://github.com/qix-/color/issues/174">https://github.com/qix-/color/issues/174</a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/Qix-/color-string/commits/1.5.5">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -3

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 16 hours

PR opened jalandis/marketing-poc-gatsby-netlify

chore(deps): [security] bump color-string from 1.5.3 to 1.5.5

Bumps color-string from 1.5.3 to 1.5.5. This update includes a security fix. <details> <summary>Vulnerabilities fixed</summary> <p><em>Sourced from <a href="https://github.com/advisories/GHSA-257v-vj4p-3w2h">The GitHub Security Advisory Database</a>.</em></p> <blockquote> <p><strong>Regular Expression Denial of Service (ReDOS)</strong> A Regular Expression Denial of Service (ReDOS) vulnerability was discovered in Color-String version 1.5.5 and below which occurs when the application is provided and checks a crafted invalid HWB string.</p> <p>Affected versions: < 1.5.5</p> </blockquote> </details> <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Qix-/color-string/releases">color-string's releases</a>.</em></p> <blockquote> <h2>1.5.5 (Patch/Security Release) - hwb() ReDos patch (low-severity)</h2> <blockquote> <p>Release notes copied verbatim from the commit message, which can be found here: 0789e21284c33d89ebc4ab4ca6f759b9375ac9d3</p> </blockquote> <pre><code>Discovered by Yeting Li, c/o Colin Ife via Snyk.io. <p>A ReDos (Regular Expression Denial of Service) vulnerability was responsibly disclosed to me via email by Colin on Mar 5 2021 regarding an exponential time complexity for linearly increasing input lengths for <code>hwb()</code> color strings.</p> <p>Strings reaching more than 5000 characters would see several milliseconds of processing time; strings reaching more than 50,000 characters began seeing 1500ms (1.5s) of processing time.</p> <p>The cause was due to a the regular expression that parses hwb() strings - specifically, the hue value - where the integer portion of the hue value used a 0-or-more quantifier shortly thereafter followed by a 1-or-more quantifier.</p> <p>This caused excessive backtracking and a cartesian scan, resulting in exponential time complexity given a linear increase in input length.</p> <p>Thank you Yeting Li and Colin Ife for bringing this to my attention in a secure, responsible and professional manner.</p> <p>A CVE will not be assigned for this vulnerability. </code></pre></p> <h2>1.5.4 (Patch Release)</h2> <ul> <li>Removes rounding of alpha values in RGBA hex (<code>#rrggbbaa</code>) and condensed-hex (<code>#rgba</code>) parsers, which caused certain unique inputs to result in identical outputs (see <a href="https://github.com/qix-/color/issues/174">https://github.com/qix-/color/issues/174</a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/Qix-/color-string/commits/1.5.5">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -3

0 comment

1 changed file

pr created time in 16 hours

issue commentjasmine/jasmine

using suites to run test - but DO NOT stop run test files on fail test

Is there a different way to stop a describe on failure? (only with Jasmine and not 3rd party package?)

Not really. protractor-stop-describe-on-failure is probably about as close as you can come to a working solution.

You didn't say why you want to do this, but my guess is that there's some sort of dependency between your specs, so that one of them will only work if a previous one passes. If that's the case, my advice is to fix the specs so that each one can run independently of all the rest. We occasionally see Protractor users write test suites where each spec is a sequential step in a process, but that's not how Jasmine is meant to be used. If that's what you're doing, your best bet is to combine the steps into a single spec.

razielron

comment created time in a day

startedMaggieAppleton/digital-gardeners

started time in a day

pull request commentrwjblue/ember-cli-content-security-policy

Don't add nonce to script-src when it already contains 'unsafe-inline'

Just noticed this bug has been hitting me for a few months, is it safe to update to v2? or can we have a backport please? Thank you very much in advance!

joukevandermaas

comment created time in a day

push eventjasmine/jasmine

Steve Gravrock

commit sha 5862b22aefd3229d70639526a796b3cfd4e40fd8

Include rejection details in failure messages for toBeResolved and toBeResolvedWith [#178559119]

view details

push time in 2 days

push eventjasmine/jasmine

Steve Gravrock

commit sha 1893bf6c16cdefe85f0405e0e593eb53b5187f9f

Added jsdocs for asymmetric equality testers

view details

Steve Gravrock

commit sha 163f93d6ffe905a7d2f907f83cea934706b69e64

Removed constructors from jsdocs of classes that aren't user-constructable

view details

push time in 2 days

push eventjasmine/jasmine

Steve Gravrock

commit sha 095745ab12144ee27147d962d690cfd49104e7fa

Removed gulp-jasmine-browser mention from README

view details

push time in 2 days

issue openedepochjs/epoch

TypeError: $(...).epoch is not a function

ENV

  • OS: WINDOWS
  • nodejs 14.16.1
  • electron #error
Uncaught TypeError: Cannot read property 'format' of undefined
    at epoch.min.js:1
Uncaught TypeError: $(...).epoch is not a function
    at test_epoch.html:34

image

test file

<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">

    <script src="./node_modules/jquery/dist/jquery.min.js"></script>
    <script src="./node_modules/d3/dist/d3.min.js"></script>
    <link rel="stylesheet" type="text/css" href="./node_modules/epoch-charting/dist/css/epoch.min.css">
    <script src="./node_modules/epoch-charting/dist/js/epoch.min.js"></script>

    <script type="module">

        import * as d3 from "https://cdn.skypack.dev/d3@7";

        const div = d3.selectAll("div");

    </script>

    <title>show</title>
</head>

<body>

    <div id="area" class="epoch category10" style="height: 200px;"></div>
    <script>
        const $ = require("jquery")
        var data = [
            { label: 'Layer 1', values: [{ x: 0, y: 0 }, { x: 1, y: 1 }, { x: 2, y: 2 }] },
            { label: 'Layer 2', values: [{ x: 0, y: 0 }, { x: 1, y: 1 }, { x: 2, y: 4 }] }
        ];
        var areaChartInstance = $('#area').epoch({
            type: 'area',
            data: data,
            axes: ['left', 'right', 'bottom']
        });
    </script>


</body>


</html>

created time in 4 days

issue commentepochjs/epoch

Cannot read property 'format' of undefined

epoch chart is very old and it is not compatible with new version of d3.js. Try linking to older version of d3. I tried v3 and it worked.

<script src="https://d3js.org/d3.v3.min.js"></script>

when I changed into d3.v3.min.js, there is another error

Uncaught ReferenceError: d3 is not defined
    at epoch.min.js:1
JakobStaudt

comment created time in 4 days

issue commentjasmine/jasmine

Async timeout firing before custom set timeout

Would it be easy for you to disable the timeout entirely if 0 or -1 is passed as parameter?

The necessary code change is straightforward, but it sits right in the middle of the most bug-prone and difficult to debug part of Jasmine. The bar for adding even small amounts of complexity there is pretty high. And I suspect that you’re the only one who’s going to use the proposed feature.

I hate to tell anyone to maintain a local fork of Jasmine, but that might be the best path forward if you really need a spec to run for longer than 24 days. Here’s the most likely touch point: https://github.com/jasmine/jasmine/blob/68db3f6fcf17426148edffb165c12517bdb84f9b/src/core/QueueRunner.js#L138-L150

appy-one

comment created time in 4 days

issue commentjasmine/jasmine

Slow (large) Uint8Array comparison

I'm glad the workaround worked for you.

I understand the issue with devs maybe defining custom properties on their typed arrays, but they should be the ones requiring custom testing methods, not those using typed arrays the way they should be used 😉.

People sometimes say that we should break someone else's code to deliver an improvement they want. I've never yet heard anyone say that we should break their code to deliver an improvement that someone else wants.

Comparing typed arrays that have extra properties on them is an obscure but legitimate use case, much like comparing really huge typed arrays or wanting a spec to run for more than 28 days. If we broke that, anyone who depended on that capability would be rightly upset. All the more so because the change would turn a failing spec into an incorrectly passing spec, which is one of the worst kinds of breaking change a testing framework can make.

We could switching to a faster comparison algorithm for typed arrays in the next major release. But we'd need to weigh the amount of user interest in faster comparisons against the costs: It would cut typed arrays off from the various customizations that the matcher system supports, and we'd have to forever treat them as special cases for diff building.

appy-one

comment created time in 4 days

issue closedjasmine/jasmine

List filtered specs without executing them

I am using Jasmine in stand-alone mode in the browser. Every time, I am opening the page, all the tests are executed. I would prefer to have an option to set if tests should be executed or just listed (in gray). More or less an interactive mode (cf Git).

It could take the form of:

  • URL parameter (my_test.html?execution=false)
  • A check box option in the Options menu of Jasmine

Advantages:

  • You don't have to change your code to choose which specs to do
    • Avoid to disturb the git
    • You can share the spec param to provide the same filter
  • You can see and prepare which tests are going to be done (Also because each suites/specs give a link to select automatically the sub tests)
  • You can open a page with tests without launching them right now (I have mostly integration tests that use the browser API, they impact the UI directly and are resource consuming)

Temporary solution but limited

This code makes all and only all the tests to be listed (in grey) without being executed if spec param is empty or not defined. It is like if no spec names match the filter, then all the tests are listed. Am I right ?

Limitation: I didn't find an alternative to keep the list mode while filtering the specs by name.

var specFilter = new jasmine.HtmlSpecFilter({
  filterString: function() {
    switch(queryString.getParam("spec")) {
      case "all":
        return "";
      case undefined:
        return "@@@@@@@";
      case "":
        return "@@@@@@@";
      default:
        return queryString.getParam("spec")
    }
  }
});

var env = jasmine.getEnv();

env.specFilter = function(spec) {
  return specFilter.matches(spec.getFullName());
};

closed time in 5 days

Morikko

issue commentjasmine/jasmine

List filtered specs without executing them

Closing since we haven't heard anything new on this in a while.

Morikko

comment created time in 5 days

delete branch simplabs/ember-simple-auth

delete branch : simplify-ember-try-config

delete time in 6 days

push eventsimplabs/ember-simple-auth

Marco Otte-Witte

commit sha e93a120a187943cb2453976f81912f9b8ef83247

delete duplicate ember-try config file (#2298)

view details

push time in 6 days

PR merged simplabs/ember-simple-auth

Simplify ember try config

Currently the ember-try.js config file in the classic-test-app links to the one in the ember-simple-auth package so we don't have to duplicate everything. However, the test-app has its own duplicated ember-try.js config. This removes that duplicated file and links it to the one from the ember-simple-auth package as well.

+1 -176

0 comment

1 changed file

marcoow

pr closed time in 6 days

push eventsimplabs/ember-simple-auth

Marco Otte-Witte

commit sha af3ad9f8437dd3c3962947600bb2b82eaf5fb12b

remove ember-bootstrap from test app

view details

Marco Otte-Witte

commit sha b73365ec395ae2ca5b497a5fa9aa307c43fdea71

import bootstrap CSS into vendor.css

view details

Marco Otte-Witte

commit sha a0fd601dbee674e0ca17eb81742eb3fea076957c

upgrade bootstrap to latest in test app

view details

Marco Otte-Witte

commit sha 068270d8d042596c7f315b2631fb27d2b4ca7e2c

don't continue on error when ember-release build fails

view details

Ilya Radchenko

commit sha d11bc271a6ed2905c4191f54eb68e034f3863834

fix computed import deprecation (#2296) Resolving this deprecation: `DEPRECATION: Using `computed.oneWay` has been deprecated. Instead, import the value directly from @ember/object/computed`

view details

dependabot-preview[bot]

commit sha d532598c5cedd1ebd4ab2258fa5d41805c2b0f09

Upgrade to GitHub-native Dependabot (#2295) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Marco Otte-Witte

commit sha 8b09942dadda2668a47d1c90ffce01f0b9aac43e

remove unnecessary ESLint comments (#2290)

view details

Tony Miller

commit sha ff7b1ab735471ad9fd37a16ba7f2059bd3ae2382

Update README.md (#2284) It's not necessary to use `get` when accessing the session service in the example in the README.

view details

Bert De Block

commit sha f29cc8aa8ce031fd2d39c5af2b6d6691facdd626

Update super call in managing-current-user guide (#2274)

view details

bekzod

commit sha 55bc5df81a03009e4186d1e1e7ef4c3c4bdd7bf4

replace `tryInvoke` conditional invocation (#2266)

view details

Tony Miller

commit sha 6af8df8b00817b848956ae75beba1f627046b8e2

Update README.md (#2282) Seemed a bit awkward to say 'method' twice in the same sentence. Also the first 'method' was being rendered as part of the link.

view details

Samanta de Barros

commit sha 1fd6edca29826def650098cb69cf96c9d9396b88

Fix Github actions' configuration to allow ember canary tests to fail (#2261)

view details

Marco Otte-Witte

commit sha 19b1517acd18c59b6ffb81dfe67df1f19f94666a

remove extra resolver files

view details

Marco Otte-Witte

commit sha 2b387e5b43536c0542d182ee188b408d4296ab51

Drop `ember-cli-shims` dependency (#2301) * remove ember-cli-shims dependency * remove ember-cli-shims from ember-try configs

view details

Marco Otte-Witte

commit sha a98dd54f8ec4c1438622c77dc73dbec7dae9cf0f

dasherize engine name (#2299)

view details

Marco Otte-Witte

commit sha 8f4485250c9db9b7f7be20447f20a3135e44a2f6

Drop ember-bootstrap dependency from classic test app (#2292) * remove ember-bootstrap * import bootstrap into vendor.css * upgrade bootstrap to latest * don't continue on CI when ember-release build fails

view details

Marco Otte-Witte

commit sha 5e7e0e3f2919c6c89306be4f0455e7f4b18d400d

add missing dependent key in README (#2291)

view details

Samanta de Barros

commit sha 137efbb5b58f8aa9a94a2c873545fe8ad449e38e

Merge pull request #2300 from simplabs/fix-resolvers Remove extra resolver files

view details

Samanta de Barros

commit sha 28f2637b6eafaad5b4325be1e9f843d086a1d2a5

Merge pull request #2293 from simplabs/drop-ember-bootstrap-test-app Drop ember bootstrap from modern test app

view details

Marco Otte-Witte

commit sha 1cca7aaed927e06efac7fcc5153cea3bc90832eb

run CI on latest Ember LTS releases (#2297)

view details

push time in 6 days

PR opened simplabs/ember-simple-auth

WIP: show how to extend the session service in the README

Continuing from my comment here, there isn't any info about this in the docs so yet. https://github.com/simplabs/ember-simple-auth/pull/2285#issuecomment-807876500

+48 -0

0 comment

1 changed file

pr created time in 6 days

startedMartinSStewart/elm-serialize

started time in 6 days

issue commentjasmine/jasmine

Unhandled promise rejection: false positive

Does jasmine await the promise returned from the function passed to it()?

Yes. (Actually it calls then on it, but that shouldn't make a difference.)

You could try explicitly handling the rejection immediately after creating the promise:

        const rejectingPromise = Promise.reject(new Error("Operation failed."));
        rejectingPromise.catch(() => {});
        await new Promise<void>((resolve) => setTimeout(resolve, 100));
        // [...]

That should suppress the spec failure, at the cost of preventing both Jasmine and the JS runtime from letting you know if the rejection otherwise goes unhandled.

andreashuber69

comment created time in 8 days

issue commentjasmine/jasmine

Unhandled promise rejection: false positive

Hi

Thanks for your answer.

The usual solution is to avoid rejecting the promise until you're ready to await it. You might find the discussion and examples in #1648 helpful.

The repro I provided is a much dumbed down version of a real world situation I have. It is hard to explain, but what I'm doing is somewhat equivalent to using Promise.all to fire off a bunch of requests in parallel. If one of those requests fails, I get the mentioned false positive from jasmine.

I don't see how I can resolve this without changing the semantics of my test. Does jasmine await the promise returned from the function passed to it()?

andreashuber69

comment created time in 9 days

PR merged jasmine/jasmine

fix for #1906: add url pathName in toQueryString function

Description

ToQueryString function

Motivation and Context

See issue #1906

How Has This Been Tested?

Ran specs in local environment.

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ x ] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.
+19 -1

4 comments

2 changed files

jlpstolwijk

pr closed time in 9 days

push eventjasmine/jasmine

Joris Stolwijk

commit sha 1e4f0d1545c4e0a582391821d1ffa52f544bdfb5

add url pathName in toQueryString function - fixes (https://github.com/jasmine/jasmine/issues/1906 ) + comment + test

view details

Steve Gravrock

commit sha 68db3f6fcf17426148edffb165c12517bdb84f9b

Merge branch 'select-spec' of https://github.com/jlpstolwijk/jasmine into main * Merges #1907 from @jlpstolwijk * Fixes #1906 * Fixes spec filtering in karma-jasmine-html-reporter

view details

push time in 9 days

issue closedjasmine/jasmine

HTML Reporter for angular (karma) always runs all specs

Expected Behavior

When clicking a spec in the html report, only that spec should be run. (Using karma-jasmine-html-reporter, but issue should be fixed in jasmine itself, see below).

Current Behavior

When clicking a spec in the html report, the full page reloads, running all specs again. Both in regular report and in debug mode.

This seems to be caused by the combination of 2 things:

  1. the href of the specs have only a query string, without url path, e.g. <a title="should be created" href="?spec=ConfirmService%20should%20be%20created">should be created</a>
  2. both the context.html and the debug.html page have <base href="/"> in the header. The angular team apparently added this in response to this issue.

See also this issue, filed on karma repo (also not picked up there, because it belongs to jasmine).

Possible Solution

I'm working on a PR, which I will link to this issue. This involves adding the url pathname + query string to the href of the spec, instead of only adding the query string. This solution was inspired by this issue + PR on karma-jasmine-html-reporter, which was rejected because that repo basically copies its code from jasmine. I hope the current PR can be incorporated in jasmine and then copied to karma-jasmine-html-reporter.

Suite that reproduces the behavior (for bugs)

npm install -g @angular/cli
ng new test-app
cd test-app
ng test

Then click on a single spec => notice that page reloads, and all specs are run again. Same issue happens in debug mode.

Your Environment

  • Environment name and version: Chrome 90.0.4430.72 (Official Build) (64-bit), Node: 14.16.1
  • Operating System and version (desktop or mobile): Windows 10 desktop, x64
  • Packages:
   "@angular-devkit/build-angular": "^0.1102.9",
   "@angular/cli": "^11.2.9",
   "@angular/compiler-cli": "^11.2.10",
   "jasmine-core": "^3.7.1",
   "jasmine-spec-reporter": "^7.0.0",
   "karma": "^6.3.2",
   "karma-chrome-launcher": "^3.1.0",
   "karma-cli": "^2.0.0",
   "karma-jasmine": "^4.0.1",
   "karma-jasmine-html-reporter": "^1.5.4",

closed time in 9 days

jlpstolwijk

issue openedsimplabs/ember-simple-auth

[DEPRECATION] Usage of the Ember Global is deprecated (Ember.libraries.register...)

Description

This line here: https://github.com/simplabs/ember-simple-auth/blob/1cca7aaed927e06efac7fcc5153cea3bc90832eb/packages/ember-simple-auth/index.js#L24 Is causing the following deprecation:

DEPRECATION: Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead. [deprecation id: ember-global] See https://deprecations.emberjs.com/v3.x/#toc_ember-global for more details.

created time in 9 days

pull request commentjasmine/jasmine

fix for #1906: add url pathName in toQueryString function

Somehow, npm run cleanup did not work - prettier was using a different config locally or something. But right-clicking in VS code en "format with... prettier" did the job. Thanks in advance for merging!

jlpstolwijk

comment created time in 10 days