profile
viewpoint
Michael Stillwell ithinkihaveacat @google London https://beebo.org/ Google Developer Relations. JavaScript, TypeScript, and other things.

google/material-design-lite 31639

Material Design Components in HTML/CSS/JS

GoogleChromeLabs/gulliver 516

A PWA directory, focusing on collecting PWA best practices and examples.

ampproject/amp.dev 389

The AMP Project Website.

ampproject/amp-toolbox 316

A collection of AMP tools making it easier to publish and host AMP pages.

ampproject/ampbench 65

AMPBench: AMP URL validation and troubleshooting tools (DEPRECATED)

ithinkihaveacat/dotfiles 37

Shell-related config files and scripts

ithinkihaveacat/eleventy-jsx 3

Example of how to use JSX templates with Eleventy

ithinkihaveacat/byron 1

Small library of some kinda crappy code I use on beebo.org.

ithinkihaveacat/11ty.io 0

Documentation site for the Eleventy static site generator.

ithinkihaveacat/amp-by-example 0

A hands-on introduction to Accelerated Mobile Pages (AMP) focusing on code and live samples.

push eventithinkihaveacat/exposure-notifications-android

Google

commit sha 58f6dc872016e2a42d174178dcefcae5d7590952

Upstream changes through 2020-07-10. Features: - Updates to 1.5 SDK - Uses new ExposureWindows API rather than ExposureInformation - Notifications now handled by the app - Removes token debug screens Warning: - Contains destructive database migration - You must be using at minimum version 202902000 of en_module Requires minimum Nearby SDK version: 18.0.3 (updated)

view details

Google

commit sha eb045e17a02fc731684763863cb595dee67b532d

Fix broken links in README

view details

Google

commit sha 7dc2979051703443895123f83c370f64a81baa38

Upstream changes through 2020-07-30. Features: - Adds verification server integration - Adds low storage UIs - Adds BLE and Location off UIs - Adds licenses menu - Updates to zxing QR scanner library - Reject keyfiles older than (by default) 24hrs - Improved onboarding animations - Adds test coverage reports - Improved test coverage - Bug fixes, cleanup and improvements Known issues: - Error cases for verification flows still work in progress Requires minimum Nearby SDK version: 18.0.3 (no change)

view details

push time in 6 days

push eventithinkihaveacat/exposure-notifications-server

Mike Helmick

commit sha f5372ed732fa8aba3b585d5225196afb2c7fb0ca

Remove test date from verification claims. (#701) Confirmed that only report type and symptom onset date are needed. Test date was never used in the system.

view details

Mike Helmick

commit sha 1057fa3ad8d704274a1a637c4c609f1ad7e69e27

use approx time comparison instead of truncating for env differences (#702) * use approx time comparision instead of truncating for env differences * missed a spot

view details

Mike Helmick

commit sha 8294ee6a2f5a87855ebaa9efa33add23390f5c11

Early key release (#706) * Allow for v1.5+ early key release. Multiple keys can be provided that all have the same start interval * Add configuration params for this * Add tests for new pieces. 100% coverage on exposure model transform. * Add documentation. * add same day release as an optional feature to the generate server Fixes #705 Part of #663

view details

Mike Helmick

commit sha cc0b4125ace1c74c21bee411abb3d8ed8fbd5e56

code review comment followup (#707)

view details

Mike Helmick

commit sha 15716f2e14635f9c6c650c7bc07560c2a9e5a70e

additional logging on transform failures (#708)

view details

Mike Helmick

commit sha 8abb92d17b2ab16b28890ece416818ac15cc1e20

add tool for interval numbers and UTC time (#709)

view details

Mike Helmick

commit sha 75b4fdfb1cf321f6519d3c1c57a620b0ee54ce54

Work on v1.5 (#710) * Work on v1.5 * Add key revision columns to exposure table * This includes capturing the health authority ID (if provided) * Keys can only be revised by the same health authority ID * Implement setting of Exposure fields based on the claims from the verification certificate * If a ReportType is present, set it in the Exposure.ReportType * Optionally, backfill the transmission risk, based on the report type * Calculate the days +/- sypmtom onset * the symptom onset interval can be provided in the API or from the verification certificate * stub out key revision * existing keys are read from the DB if they match the input * TODO: merge existing and input keys * TODO: implement transactional key revision * IterateExposures * add ability to select revised keys More work on #663 * review comments * got/want fix * tabs

view details

Mike Helmick

commit sha 1aef0fbe22aef93ec86f5432dd9d0317418eba15

Allow for the min cleanup TTL to be overridden by flag. (#714) * Allow for the min cleanup TTL to be overridden by flag. Fixes #711 * someday I will learn to spell

view details

Christopher Wilcox

commit sha 27ca97668ee0f3d1ba7d92c944fac3e8e169c71d

docs: Clarify how publish payloads are validated (#719) * docs: Clarify how publish payloads are validated * docs: Clarify how publish payloads are validated - additional

view details

Mike Helmick

commit sha cfd26c26c7bda1b9df9ea63bb2b88dae4803bb4d

Implement ExposureKey revisions (#718) * Implement ExposureKey revisions * Publish API changes * Transform still validates the incoming request * If any of the uploaded keys have previously been seen, join and figure out changes * perform upsert over the new keys More work on #663 * review comments

view details

Adam Yi

commit sha 583290b63200f0d0821696efb4343ce0a156f6f8

docs: fix typo (#721)

view details

Mike Helmick

commit sha 821531b167d794ec4a57075cd2009adbcd137505

V1.5export (#722) * v1.5 export files * Add new TEK metadata fields to generated exports * Add revised keys to output Work on #663 * fix build errors * fix out of bounds w/ empty data * comments on new errors

view details

Mike Helmick

commit sha e49f54bdd77318d95fd9eb62d6a705f24d79adba

Have generation service generate report types and key revision. (#724)

view details

Mike Helmick

commit sha d7a1c0d1fc14f7bc90608d9fb54451c31ed13282

add logging to generate and fix index out of bounds (#725) * add additional logging on generate service * index out of bounds fix

view details

Mike Helmick

commit sha 9a562c1f1afe8152c89f28bb879c4a667cc923e0

fix incorrect if/else clause (#726)

view details

Justin Pflueger

commit sha aad171891fefd4bf0b123d0b21526470a66c2772

Add Managed Identity auth to Azure Blob Storage (#730) * adding msi auth to azure blobstorage * remove panic, use utc time, resolve staticcheck * running 'go mod tidy' for pull-en-server-release-unit

view details

Seth Vargo

commit sha 49ad6c8f9deba0fa7b7d244c56eda65226641902

Don't stale enhancements (#731) * Don't stale enhancements * Update stale.yml

view details

Seth Vargo

commit sha c3b76f3bc0cfbaf54a86f5c9412543bccc07cf19

Rewrite integration test to incorporate retries (#733) * Rename * Rewrite integration test to incorporate retries Hopefully this fixes the sometimes flakey tests * Rename * Simplify testing API * oops * Retest

view details

Chao Dai

commit sha 4c2ac1d274ebaa7c436d745794d56725ad56ca5d

Integration tests use real GCS (#736) * Integration tests use real GCS * Code review comment updates * Go style

view details

Mike Helmick

commit sha a43d97a420c022e3e4850b688dc80555c5d4e226

add a command line tool for calculating the expected HMAC from a publish JSON request (#737)

view details

push time in 6 days

pull request commentgoogle/exposure-notifications-internals

Improve formatting of headings

Before:

github com_google_exposure-notifications-internals_blob_main_en-risks-and-mitigations-faq md(Pixel 2)

After:

github com_ithinkihaveacat_exposure-notifications-internals_blob_b3d80c98cb83135e45986499a0aa3feda445fcc7_en-risks-and-mitigations-faq md(Pixel 2)

ithinkihaveacat

comment created time in 7 days

PR opened google/exposure-notifications-internals

Improve formatting of headings

Make (some) headings more prominent and linkable when rendered by GitHub.

+7 -7

0 comment

1 changed file

pr created time in 7 days

push eventithinkihaveacat/exposure-notifications-internals

Michael Stillwell

commit sha b3d80c98cb83135e45986499a0aa3feda445fcc7

Improve formatting of headings

view details

push time in 7 days

fork ithinkihaveacat/exposure-notifications-internals

This repository contains snippets of code that show how the Exposure Notifications API works inside the Google Play services layer.

fork in 7 days

issue commentampproject/amp-toolbox

AMP Optimizer: provide a Cloudflare Webworker implementation

Cloudflare just announced an "unbound" version of their workers that are less constrained re time (probably memory too):

https://blog.cloudflare.com/introducing-workers-unbound/

sebastianbenz

comment created time in 8 days

push eventithinkihaveacat/eleventy-plugin-amp

Michael Stillwell

commit sha 86e05aeaec9d3a5b9c569dbf46bb4d241b28ac73

Wait for runtime download to complete

view details

push time in 10 days

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha fca1909d21517f215b2e53d128413450155866d7

Add DIG_CMD

view details

push time in 15 days

issue commentampproject/amp-toolbox

Node example on README doesn't work

Can you provide the commands you ran to install and compile the dependencies?

Also, are you aware of the pre-built command-line tool?

# install "amp" tool globally
$ npm install @ampproject/toolbox-cli -g
# lint https://amp.dev
$ amp lint https://amp.dev
ibrahimcesar

comment created time in 20 days

push eventithinkihaveacat/amp-toolbox

Sebastian Benz

commit sha 6d8834f9f0122ac5256b3163809712472c0e2df3

Add experimental image preloading support (#730) * Add srcSet parser * Add hero image transformer * addressed comments

view details

Michael Stillwell

commit sha 138d15776d884718e589aa001147cb8866056383

WebP is okay for metadata (#744) * Add packages requires for linter tests * Support webp metadata images * lock versions Co-authored-by: Sebastian Benz <sebastian.benz@gmail.com>

view details

Sebastian Benz

commit sha bb242b62266a71c777437d199161ba850ddab53b

Extract runtime parameters (#736) * pass validator rules object via params * Extract RuntimeParameters This PR extracts fetching and configuration of runtime parameters into a separate function outside the transformers. This externalizes and centralizes runtime parameter handling enabling, removing the responsibility of handling runtime configuration inside transformers (with the potential for duplication) and enabling future optimizations of file system based caching of runtime artifacts (see #650). * update to amp.dev * use 15 digit version numbers * update jsdoc

view details

Sebastian Benz

commit sha e0561edeb678a43387a59a686beaeedf96a9376d

update dependencies

view details

WhiteSource Renovate

commit sha b3d822712e75545e5d9c6fccece23af31e349008

Update dependency jest to v26.0.1 (#746)

view details

Sebastian Benz

commit sha fa9a535da7ead4ad0cedba970ce1ec215547ff69

Update changelog

view details

Sebastian Benz

commit sha 2396773adfc982c044cf932dfef73b6955cb005b

v2.3.1

view details

WhiteSource Renovate

commit sha 5a6f8a8384a47fd7f07f84c0d0dfd0f3b89ed206

Update dependency @ampproject/toolbox-optimizer to v2.3.1 (#748)

view details

WhiteSource Renovate

commit sha 57bf22394853269db6f8e01dd2f86a058adc8e9d

Update dependency fetch-mock to v9.5.0 (#749)

view details

Matthias Rohmer

commit sha b658dc80b09baa3beafdd4c0ee2a83dfc6dc8d96

Add missing command name to CLI documentation (#752)

view details

WhiteSource Renovate

commit sha 2d56b137813bba6cb97b9e45f1db4d5a2df4140c

Update dependency amphtml-validator to v1.0.31 (#750)

view details

WhiteSource Renovate

commit sha 6a89b0578d97ff7ab662ef0b7725fc476fa21546

Update dependency rollup to v2.8.0 (#751)

view details

Alain Schlesser

commit sha fc4f17473ed5eef693d2a6b41f3afe2891ac5f33

Fix typos in parameter documentation (#753)

view details

Sebastian Benz

commit sha cd20087d0b0b3add6a556792ec78ea0fd4fa31af

Optimizer: cache runtime artifacts on filesystem (#747) * Cache downloaded parameters This will download all runtime parameters once and stores them in an in memory cache. * Cache downloaded runtime artifacts * Warm up cache on postinstall * add option to disable cache * addressed comments * only delete files in cache dir

view details

Sebastian Benz

commit sha ea6bbee6669dec0bb88408bf8404ca4bc2283a78

add publish script

view details

Sebastian Benz

commit sha 9dc1eb40a598d413e687148305d8410c2b06df44

v2.4.0-alpha.0

view details

Sebastian Benz

commit sha aeceb5cb83cc111c08297415ab469696f2f7994e

update githead

view details

Sebastian Benz

commit sha 324542bdb7b8117e4c25ac963748acc141f85881

enable esm experiment via param

view details

Sebastian Benz

commit sha 9d28f064c27d7b4466a49f0de003e4c466812caf

update githead

view details

Sebastian Benz

commit sha 64a25a757ff6d2acc9a7d59ec718a025c713b63e

v2.4.0-alpha.1

view details

push time in 20 days

create barnchithinkihaveacat/amp-toolbox

branch : main

created branch time in 20 days

Pull request review commentampproject/eleventy-plugin-amp

Fix image optimization and self-hosting setup

 Optionally pass in an options object as the second argument to `addPlugin` to fu const ampPlugin = require('@ampproject/eleventy-plugin-amp'); module.exports = function (eleventyConfig) {   eleventyConfig.addPlugin(ampPlugin, {-    // Disable AMP Cache (enabled by default)+    // Disable AMP Cache (enabled by default) and self-host the AMP runtime.

I think it's also possible you might want to disable the AMP cache from search results, but still want to load the runtime from cdn.ampproject.org. Maybe no-one actually wants this in practice, but it's reasonable in theory, and helps keep the concepts separate.

For my personal use case (don't know if this would be useful to anyone else!) I'd like separate controls for:

  • Whether search links to my host, or its own separate cache (I guess the third SXG option would need to be configured elsewhere)
  • Where the AMP runtime comes from, options:
    • cdn.ampproject.org
      • … LTS version or latest? (default = latest)
    • self-hosted[*]
      • directory on filesystem to put runtime
      • URL path on host (default = "/amp/" or "/rtv/"?)

[*] Does the server hosting the AMP runtime need to match the host of the AMP page itself (i.e. its canonical)? I seem to remember that was a constraint, or potentially so.

sebastianbenz

comment created time in a month

Pull request review commentampproject/eleventy-plugin-amp

Fix image optimization and self-hosting setup

 Optionally pass in an options object as the second argument to `addPlugin` to fu const ampPlugin = require('@ampproject/eleventy-plugin-amp'); module.exports = function (eleventyConfig) {   eleventyConfig.addPlugin(ampPlugin, {-    // Disable AMP Cache (enabled by default)+    // Disable AMP Cache (enabled by default) and self-host the AMP runtime.

In the future will be be possible to self-host and use the cache? I was thinking it's awkward if a single flag controls both features.

sebastianbenz

comment created time in a month

Pull request review commentampproject/eleventy-plugin-amp

Fix image optimization and self-hosting setup

 Optionally pass in an options object as the second argument to `addPlugin` to fu const ampPlugin = require('@ampproject/eleventy-plugin-amp'); module.exports = function (eleventyConfig) {   eleventyConfig.addPlugin(ampPlugin, {-    // Disable AMP Cache (enabled by default)+    // Disable AMP Cache (enabled by default) and self-host the AMP runtime.

Why is disabling the AMP Cache necessary for self-hosting? Even if this isn't possible now, won't it be possible in the future?

sebastianbenz

comment created time in a month

pull request commentampproject/eleventy-plugin-amp

Avoid modifying outputDir

I think I'd be happy with eleventy-plugin-amp staying out of the way and passing through as much as possible, even if this means users of the plugin need to configure the same thing twice. (e.g. if two different libraries used by the plugin both require an output directory.)

It's true that this ties the plugin to its implementation details, but maybe that's okay.

Also, in my short time with the plugin, this is the second time I've hit a case where the options not being passed through has been a bit confusing. (I've been trying to get the plugin to generate self-hosted AMP components but so far I haven't been able to figure out how to thread ampUrlPrefix through to the optimizer's config.)

ithinkihaveacat

comment created time in a month

pull request commentampproject/eleventy-plugin-amp

Avoid modifying outputDir

One reason I think this should be avoided is that the concatenation mixes together different "types": urlPath is in the URL space, outputDir is in the filesystem space, so joining them together is slightly weird. And it actually does the wrong thing if urlPath is something like https://cdn.example.com/images/. (Sure, "path" is in the name, but this does otherwise work.)

Another issue is, if more options will be simply passed through to eleventy-img in the future, eleventy-plugin-amp will forever need to document that outputDir is transformed before being passed to eleventy-img, it's not possible to simply link to the eleventy-img docs.

ithinkihaveacat

comment created time in a month

PR opened ampproject/eleventy-plugin-amp

Avoid modifying outputDir

I think this line should be removed. (It was added via #31.)

I think the cached images should be created directly in outputDir rather than ${outputDir}/${urlPath}, both for semantic reasons and also because this is how it's documented in the eleventy-img config.

+0 -1

0 comment

1 changed file

pr created time in a month

push eventithinkihaveacat/eleventy-plugin-amp

Michael Stillwell

commit sha 61cd824e8fbdbfb148c1aa6c7d7fc9f014bd5d09

Avoid modifying outputDir

view details

push time in a month

push eventithinkihaveacat/eleventy-plugin-amp

Sebastian Benz

commit sha ff070671d66dab600ac1a959f9fd8dcf989cc5fc

Improve image optimization Makes image optimization optional as it requires the output directory to be configured. The image optimizer now also supports URLs without a specific file extensions. In this case we will use jpg as a default. This also updates the sample project to demonstrate image optimization.

view details

Sebastian Benz

commit sha c01aa015da9c9a060e302e0bc20fc86070e19c55

support imageBasePath in ImageOptimizer

view details

Sebastian Benz

commit sha 5eff46edb0da9eb51333f35521d81322c54d7115

add missing return

view details

Sebastian Benz

commit sha c9d0b3835eda94b750b1e3dbe9d85f46193e3282

Merge pull request #31 from ampproject/image-optimization-improvements Improve image optimization

view details

Sebastian Benz

commit sha 3fbc16ce8cebc68dc2b21bb4d8899baf58c7693a

add support for self-hosting (#32) * add support for self-hosting If `ampCache=false` we will also automatically download an self-host the AMP runtime. * only run no cache transform for amp files * fix test * remove invalid default param

view details

Sebastian Benz

commit sha 7f80fab7ec5abdded945b5972a11b3993b1b4937

update dependencies

view details

Sebastian Benz

commit sha 4cf7fae8b4abf0da1fe62a4ff33e9e9b68b88620

v0.3.0

view details

Sebastian Benz

commit sha fa7b4e6d912f52c628e2d52ebb50e1ac988c4723

add missing dependency

view details

Sebastian Benz

commit sha d8bd47bb58a194810d902b37eb75c48dde786347

move runtime fetch to dependencies

view details

Sebastian Benz

commit sha af0bf57b2b0c7e0ae20d32a2099275a99dc26b5f

fix options not initialized in noCacheTransform

view details

Sebastian Benz

commit sha 6452f658406516e78bc311e080708fa3bee72d91

fix publish script

view details

Sebastian Benz

commit sha 8b24bab5894bce9390e4404ccb5295169423dff6

fix missing require

view details

Sebastian Benz

commit sha d84a72155a37e7304098b5d587985739e2638972

avoid downloading the runtime multiple times

view details

push time in a month

push eventithinkihaveacat/exposure-notifications-server

Zsombor Szabo

commit sha 1208580e92e3a9f23d85eb570fbdff8d1f6e7a00

Update README.md (#676) https://github.com/google/exposure-notifications-verification-server/commit/37dfad3ef09cfb68ba21cc56a815039b33e72bf1

view details

Mike Helmick

commit sha 559d98fd0ec6f80333d27bd5b05127b143164d15

rename head branch links to main (#678)

view details

Mike Helmick

commit sha 440b71dc3a01f160c4bedcc36680400d8fb050a1

Fixes to export index.txt file creation (#681) * Fixes to export index.txt file creation * When generating the files for the index.txt, restrict it to the exportconfig.ID of the batch being processed * When determining if an empty batch should refresh the index, do this per-configID instead of per /do-work * Change index file locking to per-config id and not per-batch, better represents the race condition we are guarding against. Fixes #672 * fix tabs * lint

view details

Christopher Wilcox

commit sha a820290c22f0c973da3af3c2d2d7c41218a80b04

Add github action to deploy from main branch docs folder to gh-pages (#682) * Add github action to deploy from main/docs to gh-pages * docs directory Co-authored-by: anmapie <anna@apiechowski.com>

view details

Faithfulness Alamu

commit sha 5eba1d34044ef495818aa73864a82e8a8283c5d6

Fix typo in internal server implementation (#686) Typo was 'randombly', changed to 'randomly'

view details

Mike Helmick

commit sha 73377517c966bd39067abe63982cb3bd885b2bb4

Update publish-gh-pages.yml move to correct branch and directory

view details

Christopher Wilcox

commit sha 1b5c59ac82aeb02f61d4f4f3984bb7dd0054f345

gh-pages (#691)

view details

Zsombor Szabo

commit sha 899592708a4195589f46b00817e994333954fc45

Fix Cache-Control header (#683) * Fix Cache-Control header * Fix linting error

view details

Seth Vargo

commit sha c35c97708dec0a8a3e2ac54f89f9033be5da22a6

Use external retry package (#687)

view details

Mike Helmick

commit sha c3ed1364eadbdc72f79300b25e25e4588de80956

align windows (#694)

view details

Mike Helmick

commit sha 26bc7430ec1aa2ff44dc17d06c96f31ddba60e5e

Fix broken links (#695)

view details

Seth Vargo

commit sha 6119adab49ea58e0e0ea190fb35f5f46663a767e

Set PROJECT_ID on services (#697)

view details

Andre Briggs

commit sha 6b3da1d80f29685501b3feb94ed95f8dd4b2c05e

Update handler.go (#688) * Update handler.go Logging typo fix * Update handler.go

view details

Seth Vargo

commit sha d61a3f3e91bef00ad5308bae26210fa0de5a21a8

Update observability permissions (#698) * Grant observability permissions * Allow specifying regions in generate * Use LA timezone since UTC conflicts with the UI * Add lifecycle rule to bucket (matches prod)

view details

Mike Helmick

commit sha 4a1c49ec581cbac88dbaed4658298f81515221d3

Verification claims adjustments (#700) * remove free form pha claims * introduce v1.5 fields to verification claims * clairfy naming * mark transmission risk overrides as deprecated, but still used Part of #680 Part of #663

view details

push time in a month

delete branch ithinkihaveacat/exposure-notifications-server

delete branch : master

delete time in a month

create barnchithinkihaveacat/exposure-notifications-server

branch : main

created branch time in a month

push eventithinkihaveacat/exposure-notifications-server

Christopher Wilcox

commit sha 032a0eb94aa1a3b8e963e469e449b29cdb7202bb

Update cmd names in deployment document (#277)

view details

Seth Vargo

commit sha a495e2b0eb30bbba662ed180d525a467f070c2d9

Add an index to exposure.create_at (#281) This uses a BRIN index which will be most optimal given the size of the data.

view details

Christopher Wilcox

commit sha 9e927d9dd80f2a0fab9f2caff93154d7ceb8ac31

Adjust transmission risk range in documentation (#285)

view details

Jason Collins

commit sha 36f3e4dddc12ba19eaa652a1d2581fb55b16bd7e

Adjust batch boundary conditions so that published keys hit an open batch (#275) * Added checks for batch time consistency. * Leave a bit of room before a worker picks up a batch.

view details

Seth Vargo

commit sha b19d9be6e58f19678f643dd0775d2cda9001f151

Propose me as an OWNER (#286) Also alphabetize reviewers for my OCDification

view details

gurayAlsac

commit sha beea88613e3f08bea47ea29aaeb9bcf8a15d8f3d

demonstrate verification key version (#283) * demonstrate verification key version * reorder config

view details

gurayAlsac

commit sha ec32f66d56e5061c17cef86bb093c7c2cd8a0d12

add sample export file (#282) * add sample export file * create dedicated sample folder and include pem * add readme * move to examples folder * minor updates

view details

Jason Collins

commit sha 9a207d6f5f67f834ae85fd5bdee12e5bfba0ac1e

Make insert export file idempotent by skipping overwrite of existing record. (#288)

view details

C H

commit sha ca067d12407516033b03668dba9a162b6d312543

fix misspelling (#292)

view details

Seth Vargo

commit sha e918d0ea9143de0147b3df5f7a3cf6caafc30a45

Enable vacuum on all tables (#293)

view details

Mike Helmick

commit sha 47fbc67af7155e88a2ff83dadf46da106dc459fd

make tranismission risk per-exposure key (#294)

view details

mh-

commit sha 5fcc6f97bee8e60b74d5a411104b1bc8b8647a10

Clarify the text on signing the 'incremental files' and distributing public keys for this (#278) * Fixed text on public/private keys in README The original text was unclear, it somewhat implied that the mobile devices use the private key that's required for signing the "incremental files". * Fixed text on public/private keys in Overview The original text was unclear, it somewhat implied that the mobile devices use the private key that's required for signing the "incremental files".

view details

Christopher Wilcox

commit sha 66c10fe17ce2e88e7996ce39698ba1185dac4817

Adjust transmissionRisk ranges to match after #294 (#298)

view details

Jason Collins

commit sha 26eeeaf4fed9f2fcec1e5fdc4eddd5a5cd4551d6

Make insert export file idempotent by skipping overwrite of existing record. (#296)

view details

Dana Hoffman

commit sha 7fc6408b4cf1263270eafde1cb13d1c2219682b3

add federation services to terraform config (#260) * add federation services to terraform config * fix secrets

view details

Dana Hoffman

commit sha 4fcd9f1142923b483d98372fc079b91fcc1b909b

fix typo in tf env vars (#302)

view details

Dana Hoffman

commit sha e04aca6b151a6e92068f02df8f61981ae1b1cb86

optional cloudbuild triggers and other terraform improvements (#300) * optional cloudbuild triggers and other terraform improvements * formatting * un-change build.yaml * remove unrelated comment

view details

Dana Hoffman

commit sha baa64f176dd6f57374684f2315c6d5c2b6957885

Add federation deployments to deploy.yaml (#303) * Add federation deployments to deploy.yaml * Update deploy.yaml

view details

Mike Helmick

commit sha 24a274ff28743488b750e69eb0e84c48ecc27c09

ensure a minimum export file length (#304) * ensure a minimum export file length * add jitter to padded batch size

view details

Jason Collins

commit sha 7fd1d2ef8e45e2f0307b37c2e9352d74b3a343a6

Allow at most one index file write for empty batch within worker. (#306)

view details

push time in a month

Pull request review commentampproject/eleventy-plugin-amp

Improve image optimization

 const createImageOptimizer = (globalOpts) => {   }; }; +function resolveImageOnFileSystem(globalOpts, src) {+  if (typeof globalOpts.imageBasePath == 'function') {+    return globalOpts.imageBasePath(src);+  }+  if (typeof globalOpts.imageBasePath == 'string') {+    return path.join(globalOpts.imageBasePath, src);+  }+  src = path.join(WORKING_DIR, src);

Should be return path.join(WORKING_DIR, src).

sebastianbenz

comment created time in a month

pull request commentampproject/eleventy-plugin-amp

Resolve images via imageBasePath if provided

Oh great, I didn't see that!

ithinkihaveacat

comment created time in a month

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 025fcf4b16648657feba2a20fae80a8b167f7845

Display compressed bytes

view details

push time in a month

create barnchithinkihaveacat/eleventy-plugin-amp

branch : image-optimization

created branch time in a month

fork ithinkihaveacat/eleventy-plugin-amp

Quickly build interactive websites with Eleventy & AMP.

fork in a month

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 09daf799787ed5a8051b63a62bf331e46fe70acc

Add roundrect

view details

push time in a month

push eventithinkihaveacat/exposure-notifications-android

Google

commit sha 1b215ca7fc99cac292b56a87751421bd1065df75

Upstream changes through 2020-06-26. Features: - Adds daily provideDiagnosisKeys job - Adds provideDiagnosisKeys job history debug screen - Adds created and updated date to tokens - Doesn’t delete tokens on resolution, just marks them resolved - Always launch app intent to exposures tab - Cache isEnabled state for faster app launch - Changes status bar colour - Update Maven libraries to latest versions - Migrates DeviceAttestor to DiagnosisAttestor - Updates documentation links Requires minimum Nearby SDK version 18.0.2 (no change).

view details

push time in a month

startedbillpugh/GAEN_Explorer

started time in a month

startedperkeep/gphotos-cdp

started time in a month

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha bc0814f145e3cdeca63911501948407cd2280f14

Add adb-battery-historian

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 2de18dc26a4dbf9b05a6f63a24ab8dd96d687915

Go extension has changed name

view details

push time in 2 months

PR closed ampproject/amppackager

Add support for "PublicDir", PORT env var cla: yes
  • if PublicDir specified, amppkg will look for flat files on filesystem in PublicDir directory
  • use PORT env var for fallback port if not specified in config (needed for some hosts)
+45 -10

6 comments

6 changed files

ithinkihaveacat

pr closed time in 2 months

pull request commentampproject/amppackager

Add support for "PublicDir", PORT env var

Sorry to leave this hanging. Had a few goes at trying to complete this, but am not really making much progress. Will close it for now!

ithinkihaveacat

comment created time in 2 months

push eventithinkihaveacat/amppackager

Allan Banaag

commit sha ec46ffd61435d435b29ac5a95bad63ef65b2a9cc

FIXIT: refactor http testing functions to builder pattern. Fixes #426 (#440)

view details

Michael Rybak

commit sha 24016e1bac564dbc3c2699a9cdd5f5bbf6ecaf4c

Document amppackager's handlers and how to monitor them (#439)

view details

Allan Banaag

commit sha 70ecc1282f40f70287e1ff1d576130a1227ccf9a

Update the docker images of consumer and renewer to have C2D_RELEASE tags. Add dockerfile for init container for AMP Packager. Modify base image of renewer and consumer to use alpine instead of scratch. (#441)

view details

push time in 2 months

push eventithinkihaveacat/amppackager

Allan Banaag

commit sha 8172a3afedc87bd85a52a40bb8417fdce71fdc29

Added more documentation to cover the case of domain scoped projects in (#408) GCP. Also used a better link for picking compute engine zones.

view details

Googler

commit sha ef15d4ec1c67e7075c57f5765c29642a04f6f988

Fix amp-viewer-integration script tag detection for link rel=preload tag insertion for FixedLayer experiment PiperOrigin-RevId: 306951883

view details

Devin Mullins

commit sha efc9fb40c54aee1fbcc767030b6216828fc1b019

Create CODE_OF_CONDUCT.md (#411) Co-authored-by: Naina Raisinghani <nainar@google.com>

view details

Michael Rybak

commit sha 0fcd181e13b5aa3b32707922d8ca5112d52b484a

Add mux tests.

view details

Michael Rybak

commit sha 1952ba3acca4c13aaf063e020a58ea5c1efb3699

Merge pull request #413 from MichaelRybak/muxt Add mux tests.

view details

Michael Rybak

commit sha 1015592e33aae2d951326ff9af8fe56f5cd1f7f5

Refactor mux - introduce the routing matrix. (#416) Refactor mux. Will simplify adding Prometheus metrics endpoint (#357).

view details

Michael Rybak

commit sha 015da4bbe1869ab61fc64f0b1542074662bff698

Update Travis Go version to latest minor release of Go 1.10. (#419)

view details

Michael Rybak

commit sha 106947cbf9c6674f1079808ec646fdb4538ce110

Update README. (#414) Update setup instructions in README.md.

view details

Greg Grothaus

commit sha f6bfb2d104fd11b92453e759420464704d9ba940

Absolutify URLs in form `verify-xhr` attributes in the AMP transformers. PiperOrigin-RevId: 310025020

view details

Michael Rybak

commit sha 00ed2409234695f61ffe98c509f0a98695890259

Add "metrics" Prometheus endpoint - total requests by type and code. (#417) Add "metrics" endpoint. Provide a Prometheus counter of # of request broken down by request type and HTTP response code. This partly implements request #357. More metrics to be added.

view details

Michael Rybak

commit sha f0eec2bdf6a56c709934096da7ab642d7daa44d7

Add end-to-end latency Prometheus metric. (#422) Another metric per request #357.

view details

Michael Rybak

commit sha 7162ed11193635186407551e4e4adbd28a8540e3

Update Travis to use Go versions 1.10 to 1.14 (#424)

view details

Michael Rybak

commit sha aeca3fe93e1b36e198279a32fd7d0df20d2b7681

Add total gateway requests Prometheus metric. (#425) Another metric per request #357.

view details

Googler

commit sha 25169c11225fdd0bbd9a710e7c803eba7aaec7d1

Go 1.15: Drop tests cases depending on changing URL behavior Go 1.15's net/url package changes the handling of escaped URL fragments to preserve the original escaping when possible. For example, fmt.Println(url.Parse("https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz")) // Go 1.14: https://example.com/amp.html#htmlURL=http://bar.com/baz <nil> // Go 1.15: https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz <nil> Upstream change: https://go.googlesource.com/go/+/8c00e07# Drop two test cases that depend on the exact behavior of Go 1.14, which will break when run with Go 1.15. These tests have comments indicating that the preferred result would be that of Go 1.15. Since these tests appear to exist specifically to exercise the undesired path (there are other test cases exercising escaping URL fragments), dropping the tests seems simplest. PiperOrigin-RevId: 312422252

view details

Michael Rybak

commit sha a9742274b3e4769053314622c9cffe7e9f141800

Add gateway request latency Prometheus metric. (#429) Another metric per request #357.

view details

Michael Rybak

commit sha fd8f3ec62755174c16eae26cf7202a5f3c63a862

De-flake TestOCSP by adding a fake clock to certCache (#432) Resolves #427.

view details

Allan Banaag

commit sha 72682de5c8e3cea619c07a2edad834ed1f97c30e

FIXIT: fixes #188. Adds explicit -staging command line flag to use for development-mode cert url host. (#437)

view details

Allan Banaag

commit sha ce10ebb8fede85f4bc8a8461d483c2c2b8bb3075

FIXIT: Generate a better error for incorrectly generated private keys. Fixes #354 (#438)

view details

Michael Stillwell

commit sha 5745bb24d7ae21f0f8f3fa161306cc1c885b4f32

Merge branch 'master' into public-dir

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha a67e61b30cd256d507d910c8f7c009ef9f5e100d

Fix font-inter

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 0bfc180b968e5e670067231a012603176ccd9bcb

Fix shellcheck errors

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 29bd1ef11e0bf7c5bfd1cd5055eae46bb3e9ebe9

Add bugreport-dump, keyfile-dump

view details

push time in 2 months

PR closed developit/vhtml

Add support for dangerouslySetInnerHTML

Using the dangerouslySetInnerHTML attribute disables automatic escaping of &<>"'; see https://reactjs.org/docs/dom-elements.html#dangerouslysetinnerhtml.

+37 -11

2 comments

3 changed files

ithinkihaveacat

pr closed time in 2 months

pull request commentdevelopit/vhtml

Add support for dangerouslySetInnerHTML

@AndrewLeedham Yep!

ithinkihaveacat

comment created time in 2 months

push eventithinkihaveacat/exposure-notifications-android

Google

commit sha 765dab0af327d92cc6f5b7f16f5ad80d29361370

Upstream changes through 2020-06-12. Features: - Debug tab is now displayed on debug builds only - Server configuration options added to Debug tab - Implements new notification logic where app doesn't send notification, instead relying on getExposureInformation notification - Default tab on opening home screen is now Exposures tab - Added loading spinners for blocking API calls - Improved API timeout handling - Removed old unused SignatureInfo fields - Makes "View Keys" debug menu trigger via a button rather than automatically Requires minimum Nearby SDK version 18.0.2 (no change).

view details

push time in 2 months

push eventithinkihaveacat/amppackager

Allan Banaag

commit sha 8172a3afedc87bd85a52a40bb8417fdce71fdc29

Added more documentation to cover the case of domain scoped projects in (#408) GCP. Also used a better link for picking compute engine zones.

view details

Googler

commit sha ef15d4ec1c67e7075c57f5765c29642a04f6f988

Fix amp-viewer-integration script tag detection for link rel=preload tag insertion for FixedLayer experiment PiperOrigin-RevId: 306951883

view details

Devin Mullins

commit sha efc9fb40c54aee1fbcc767030b6216828fc1b019

Create CODE_OF_CONDUCT.md (#411) Co-authored-by: Naina Raisinghani <nainar@google.com>

view details

Michael Rybak

commit sha 0fcd181e13b5aa3b32707922d8ca5112d52b484a

Add mux tests.

view details

Michael Rybak

commit sha 1952ba3acca4c13aaf063e020a58ea5c1efb3699

Merge pull request #413 from MichaelRybak/muxt Add mux tests.

view details

Michael Rybak

commit sha 1015592e33aae2d951326ff9af8fe56f5cd1f7f5

Refactor mux - introduce the routing matrix. (#416) Refactor mux. Will simplify adding Prometheus metrics endpoint (#357).

view details

Michael Rybak

commit sha 015da4bbe1869ab61fc64f0b1542074662bff698

Update Travis Go version to latest minor release of Go 1.10. (#419)

view details

Michael Rybak

commit sha 106947cbf9c6674f1079808ec646fdb4538ce110

Update README. (#414) Update setup instructions in README.md.

view details

Greg Grothaus

commit sha f6bfb2d104fd11b92453e759420464704d9ba940

Absolutify URLs in form `verify-xhr` attributes in the AMP transformers. PiperOrigin-RevId: 310025020

view details

Michael Rybak

commit sha 00ed2409234695f61ffe98c509f0a98695890259

Add "metrics" Prometheus endpoint - total requests by type and code. (#417) Add "metrics" endpoint. Provide a Prometheus counter of # of request broken down by request type and HTTP response code. This partly implements request #357. More metrics to be added.

view details

Michael Rybak

commit sha f0eec2bdf6a56c709934096da7ab642d7daa44d7

Add end-to-end latency Prometheus metric. (#422) Another metric per request #357.

view details

Michael Rybak

commit sha 7162ed11193635186407551e4e4adbd28a8540e3

Update Travis to use Go versions 1.10 to 1.14 (#424)

view details

Michael Rybak

commit sha aeca3fe93e1b36e198279a32fd7d0df20d2b7681

Add total gateway requests Prometheus metric. (#425) Another metric per request #357.

view details

Googler

commit sha 25169c11225fdd0bbd9a710e7c803eba7aaec7d1

Go 1.15: Drop tests cases depending on changing URL behavior Go 1.15's net/url package changes the handling of escaped URL fragments to preserve the original escaping when possible. For example, fmt.Println(url.Parse("https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz")) // Go 1.14: https://example.com/amp.html#htmlURL=http://bar.com/baz <nil> // Go 1.15: https://example.com/amp.html#htmlURL=http%3A%2F%2Fbar.com%2Fbaz <nil> Upstream change: https://go.googlesource.com/go/+/8c00e07# Drop two test cases that depend on the exact behavior of Go 1.14, which will break when run with Go 1.15. These tests have comments indicating that the preferred result would be that of Go 1.15. Since these tests appear to exist specifically to exercise the undesired path (there are other test cases exercising escaping URL fragments), dropping the tests seems simplest. PiperOrigin-RevId: 312422252

view details

Michael Rybak

commit sha a9742274b3e4769053314622c9cffe7e9f141800

Add gateway request latency Prometheus metric. (#429) Another metric per request #357.

view details

Michael Rybak

commit sha fd8f3ec62755174c16eae26cf7202a5f3c63a862

De-flake TestOCSP by adding a fake clock to certCache (#432) Resolves #427.

view details

Allan Banaag

commit sha 72682de5c8e3cea619c07a2edad834ed1f97c30e

FIXIT: fixes #188. Adds explicit -staging command line flag to use for development-mode cert url host. (#437)

view details

Allan Banaag

commit sha ce10ebb8fede85f4bc8a8461d483c2c2b8bb3075

FIXIT: Generate a better error for incorrectly generated private keys. Fixes #354 (#438)

view details

push time in 2 months

push eventithinkihaveacat/exposure-notifications-android

Google

commit sha d41a1ea09e07d4da0718da8c4ef72b62fa81fbec

Update open source branch to include changes through 2020-05-29. Features: - Scheduled job makes fake Diagnosis Key uploads to help with user privacy. - Simplifies manual matching debug UI - Minor UI optimizations and improvements - Minor bug fixes and cleanup Known Issues: - Debug UI includes parameters for Diagnosis Key file signature verification, usable with upcoming Exposure Notifications debug mode. Debug mode is not yet available from Google Play Services. SDK Version: 20200508_RC00 (API v1.3.1)

view details

Google

commit sha 5eb8e99dc8ef0db4ee4754495d032e27094bcfe9

Upstream changes through 2020-06-07. Features: - Updated QR JSON format - Improved logcat logging for debugging - Updates gradle deps - Minor bug fixes and cleanup Known Issues: - Debug UI includes parameters for Diagnosis Key file signature verification, usable with upcoming Exposure Notifications debug mode. Debug mode is not yet available from Google Play Services. Requires minimum Nearby SDK version 18.0.2 (no change).

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 2d9a88f743ab2daf6032c1cc9cd4b61bb4a608de

Filter out some tags from logcat

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha ef296292c0dca4cee75ac3ea28206379c5661760

Add android build tools, remove ruby

view details

push time in 2 months

startedProteGO-Safe/android

started time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha aa6138f1b252ea65adfc2d1af7dccc308328156c

bundletool is optional

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 2b28da1dc71da28d175a13e95b815c6d21614bda

Install optional fonts

view details

Michael Stillwell

commit sha ae05439f4559496858f7229a7a3d49cba12e5ef3

protobuf is optional

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 91f15c8817876381b25a6fe157121b608ef81e70

Update Android Studio readme

view details

push time in 2 months

push eventithinkihaveacat/dotfiles

Michael Stillwell

commit sha 5393b50cfd1a680069cb25dc69e55b5408f6b510

Fix font-inter

view details

push time in 2 months

PR opened google/exposure-notifications-android

Make debug output compatible with CLI tool

Make the debug output (more) compatible with the server's command-line tool for generating keyfile zips (example keys.json).

Before this change:

[
  {
    "keyData": "YIoRYST4D8vdzbwpcA/+tA==",
    "rollingStartNumber": 2648160,
    "rollingPeriod": 0,
    "transmissionRiskLevel": 0
  }
]

After the change:

[
  {
    "key": "YIoRYST4D8vdzbwpcA/+tA==",
    "rollingStartNumber": 2648160,
    "rollingPeriod": 144,
    "transmissionRiskLevel": 0
  }
]

/cc @mikehelmick @gurayAlsac

+6 -4

0 comment

1 changed file

pr created time in 3 months

PR opened google/exposure-notifications-server

temporaryTracingKeys is now temporaryExposureKeys

As per the narrative docs, just above the sample JSON.

+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventithinkihaveacat/exposure-notifications-server

Michael Stillwell

commit sha 1d68cdd0190729e42c5b19c2553b621e50b2e0b0

temporaryTracingKeys is now temporaryExposureKeys

view details

push time in 3 months

issue openedgoogle/exposure-notifications-server

export-generate: rollingPeriod does not default to 144

export-generate fails if rollingPeriod keys are not present in keys.json:

$ git diff examples/export/keys.json
diff --git i/examples/export/keys.json w/examples/export/keys.json
index 86db896..50619a3 100644
--- i/examples/export/keys.json
+++ w/examples/export/keys.json
@@ -3,13 +3,11 @@
     {
       "key": "Fy/EgOWYSQw0F3YEM5sVQw==",
       "rollingStartNumber": 2649980,
-      "rollingPeriod": 1,
       "transmissionRisk": 8
     },
     {
       "key": "K2MFOsSDI43hdhaehh89zQ==",
       "rollingStartNumber": 2649866,
-      "rollingPeriod": 114,
       "transmissionRisk": 1
     }
   ]
$ go run ./tools/export-generate --signing-key=./examples/export/private.pem --tek-file=./examples/export/keys.json
2020/05/21 12:53:33 Using TEKs provided in: ./examples/export/keys.json
2020/05/21 12:53:33 invalid exposure key: invalid interval count, 0, must be >= 1 && <= 144
exit status 1

The rollingPeriod should probably default to 144, as per the Server Functional Requirements.

created time in 3 months

Pull request review commentgoogle/exposure-notifications-server

Update tek-file documentation

 var ( 	startTimestamp = flag.String("start-timestamp", "2020-05-01T15:00:00Z", "The test export start timestamp (RFC3339).") 	endTimestamp   = flag.String("end-timestamp", "2020-05-02T15:00:00Z", "The test export end timestamp (RFC3339).") 	numKeys        = flag.Int("num-keys", 450, "Number of total random temporary exposure keys to generate in the export")-	tekFile        = flag.String("tek-file", "", "File containing one base64 encoded Temporary Exposure Key per line. If set, num-keys ignored.")+	tekFile        = flag.String("tek-file", "", "JSON file of TEKs in the format {\"temporaryExposureKeys\":[{\"key\":\"…\",\"rollingStartNumber\":1,\"rollingPeriod\":1,\"transmissionRisk\":1}]}")

Oh yeah that works, I'd expect/hope that most people come across the keys.json one way or another too, that's pretty self-explanatory.

ithinkihaveacat

comment created time in 3 months

push eventithinkihaveacat/exposure-notifications-server

Michael Stillwell

commit sha a23c22279a6b04dcc7d4f1567e3f221157526be9

Update tools/export-generate/main.go Co-authored-by: gurayAlsac <64565798+gurayAlsac@users.noreply.github.com>

view details

push time in 3 months

PR opened google/exposure-notifications-server

Update tek-file documentation

Previous docs seem to be inaccurate. This makes it a bit long, but not sure how else to do this. Point to URL explaining the format?

+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventithinkihaveacat/exposure-notifications-server

Michael Stillwell

commit sha 609639c16b15c795c61068b17f78bb203c940258

Update tek-file documentation

view details

push time in 3 months

PR opened google/exposure-notifications-server

Add full paths

The command fails for me without full paths:

$ go run ./tools/export-generate --signing-key=private.pem --tek-file=keys.json
2020/05/20 22:34:38 unable to generate signing key: Invalid Key: Key must be PEM encoded PKCS1 or PKCS8 private key
exit status 1

(I think the actual error message is bogus.)

+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventithinkihaveacat/exposure-notifications-server

Michael Stillwell

commit sha a79ad9cc28f8a2940dc9881f0a1a2aadb73c3a2b

Add full paths

view details

push time in 3 months

pull request commentgoogle/exposure-notifications-server

Update example POST payload

/assign @llatif

ithinkihaveacat

comment created time in 3 months

PR opened google/exposure-notifications-server

Update example POST payload
  • temporaryTracingKeys -> temporaryExposureKeys
  • diagnosisStatus is not described. Disappeared? Deprecated?
+1 -2

0 comment

1 changed file

pr created time in 3 months

push eventithinkihaveacat/exposure-notifications-server

Michael Stillwell

commit sha 5b9d930d3aa034f0faac68cd647581bfba58a65c

Update example POST payload - `temporaryTracingKeys` -> `temporaryExposureKeys` - `diagnosisStatus` is not described. Disappeared? Deprecated?

view details

push time in 3 months

more