profile
viewpoint

Ask questionsFailpoint tests will not run when make dev

When calling command make dev on master, only integration tests are run, but failpoints is ignored.

When I run it explicitly, it refuses to run and reports:

% cargo test --no-default-features --features " jemalloc portable sse failpoints protobuf-codec" -p tests --test failpoints  -- --nocapture  ""
error: target `failpoints` in package `tests` requires the features: `failpoints`
Consider enabling them by passing, e.g., `--features="failpoints"`
tikv/tikv

Answer questions nrc

I'm investigating. I can reproduce the error and it is certainly introduced by #5379, in particular by separating out the tests crate (which was done to work around another Cargo bug with features :-| ).

Minimal repro I'm using is cargo test --no-default-features --features="failpoints" -p tests --test failpoints. The issue seems to be that the feature is not passed to the failpoints test. Not sure why yet.

(Given that issue, the failpoints test being skipped when not mentioned explicitly is expected).

useful!

Related questions

Test failed with error `too many open files` hot 1
combine all binaries into one hot 1
PCP: test hot 1
Deploy tidb with docker swarm, fail to send snap between tikv of different hosts hot 1
Fix design of engine_traits for mutual associated types / type bound equality hot 1
Needs protoc dependency hot 1
Running cargo bench causes panic hot 1
Better memory observation for tidb_query executors hot 1
how to disable gRPC batch mechanism hot 1
Github User Rank List