profile
viewpoint

Ask questionsIntegration tests: don't use names where possible

Follow up to https://github.com/moby/moby/pull/36538#discussion_r174090407

There are many tests that create objects (containers, networks, volumes, services) with a name. We should avoid using names (where possible), to prevent tests possibly influencing other tests due to resources not (yet) being cleaned up, or possibly if tests are run in parallel

  • Remove names from tests, and use object ID's (where possible)
  • For those tests that do need a name, make sure that a unique name is used. (For example, use t.Name() to name an object after the name of the test, or use a randomly generated name)

This may be a lot of work to go through all the tests, but perhaps there are contributors that want to work on some of these

If you're interested to work in this, leave a comment below, and mention what tests you'll be working on (so that it doesn't conflict with other people working on the same tests 😅)

moby/moby

Answer questions yogisinha

Hi, I want to contribute to this project. Can somebody please point me in the right direction that which test files should I take ? how do I make sure that somebody else is not working on it.

Related questions

start container failed with "failed to umount /var/lib/docker/containers/.../shm: no such file or directory" hot 47
upgrade docker-18.09.2-ce , shim.sock: bind: address already in use: unknown hot 24
start container failed with "failed to umount /var/lib/docker/containers/.../shm: no such file or directory" hot 17
runc regression - EPERM running containers from selinux hot 11
Windows Server 2019 publish ports in swarm not working hot 11
"docker stack deploy">"rpc error: code = 3 desc = name must be valid as a DNS name component" hot 9
OCI runtime exec failed: exec failed: cannot exec a container that has stopped: unknown hot 8
Swarm restarts all containers hot 8
integration: "error reading the kernel parameter" errors during CI hot 8
hcsshim::PrepareLayer failed in Win32: The parameter is incorrect hot 8
Docker 18.09.1 doesn't work with iptables v1.8.2 hot 7
Error response from daemon: rpc error: code = DeadlineExceeded desc = context deadline exceeded hot 6
Containers on overlay network cannot reach other containers hot 6
write unix /var/run/docker.sock->@: write: broken pipe hot 6
feature request: docker cat command hot 6
Github User Rank List