profile
viewpoint

Ask questionscmd/compile: intrinsify math/bits.RotateLeft{32,64} on all architectures

https://github.com/golang/go/issues/21536#issuecomment-480003894 reminded me about this. Currently the intrinsic is only implemented on amd64, arm64, ppc64 and s390x. We should enable it everywhere. It will need tests in tests/codegen. Could be a good beginner compiler issue to tackle.

CLs so far:

  • amd64: https://go-review.googlesource.com/c/go/+/132435
  • arm64: https://go-review.googlesource.com/c/go/+/122542
  • ppc64: https://go-review.googlesource.com/c/go/+/163760
  • s390x: https://go-review.googlesource.com/c/go/+/133035
golang/go

Answer questions laboger

CL 163760 handles both ppc64le and ppc64. When ppc64x is specified, that means both.

On Thu, Oct 17, 2019 at 9:07 AM cherrymui notifications@github.com wrote:

CL 163760 should cover both ppc64 and ppc64le, right?

On MIPS, the rotate instruction is rather new. We still support older machines. I guess we could do something based on GOMIPS(64) value, but we need to introduce the values first. Two shifts + an OR doesn't sounds too bad.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/golang/go/issues/31265?email_source=notifications&email_token=ACH7BDATPMDS3OGUPJ25KW3QPBWS3A5CNFSM4HDWR4J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQGSYY#issuecomment-543189347, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACH7BDCQYEPWOO4KKTS3ZF3QPBWS3ANCNFSM4HDWR4JQ .

useful!

Related questions

cmd/link: segmentation fault during mach-o linking
cmd/go: cannot find module providing package error stops `go get` processing hot 3
vendor/golang.org/x/xerrors/adaptor_go1_13.go:16:14: undefined: errors.Frame ... hot 2
cmd/vet: potential false positive in the "suspect or" check hot 2
cmd/go: needs a better error than "missing dot in first path element" when GOROOT is set incorrectly hot 2
x/xerrors: fails to compile on tip hot 1
cmd/go: `go clean <package>` downloads modules hot 1
cmd/cgo error: runtime: unknown pc 0x7fff5c805b86 hot 1
runtime: crash with "invalid pc-encoded table" hot 1
cmd/link: showing many ld warnings of "building for macOS, but linking in object file" hot 1
runtime: go program crach, it seems fall into infinite loop hot 1
cmd/go: major version without preceding tag must be v0, not v1 - breaks build of github.com/go-check hot 1
gollvm: Using External Go Packages with gollvm hot 1
runtime: macOS Sierra builders spinning hot 1
cmd/go: Problem using go modules hot 1
Github User Rank List