profile
viewpoint

Ask questionsRasterizer shouldn't require cameras as positional parameters

🚀 Feature

Motivation

In most modules, you did a great job being flexible about the inputs during initialization, so that at forward time, these inputs can be provided additionally.

An example is https://github.com/facebookresearch/pytorch3d/blob/686c8666d31d932ed42d3cd7319f249fc75e89a9/pytorch3d/renderer/mesh/shader.py#L45 and https://github.com/facebookresearch/pytorch3d/blob/686c8666d31d932ed42d3cd7319f249fc75e89a9/pytorch3d/renderer/mesh/shader.py#L56

An exception is the rasterizer, both for points and mesh. Somehow cameras becomes a required input upon initialization. This is inconsistent with the remaining style and also not flexible.

Pitch

Basically use the same way to initialize rasterizers as the other classes, such as the shader.

facebookresearch/pytorch3d

Answer questions jcjohnson

This should now be fixed in https://github.com/facebookresearch/pytorch3d/commit/17ca6ecd81b49751fd4adcbd6effee9f3fbfc455. If that solves the problem, feel free to close the issue!

useful!

Related questions

No questions were found.
source:https://uonfu.com/
Github User Rank List