profile
viewpoint
Alex Ivasyuv industral Ukraine, Lviv Senior Software Engineer

industral/NikaFramework 8

NikaFramework - Architectural WebUI JavaScript SPA Framework {OUTDATED}

industral/nixie-clock 2

I2C Nixie Clock

industral/SilentMedia 1

C++ audio library supporting ALSA/OSS/libao and wav, wv, flac, ogg formats

industral/aac.js 0

AAC decoder in JavaScript.

industral/aurora.js 0

JavaScript audio decoding framework

industral/boxAudio 0

Stream audio directly from Dropbox! 🤘

industral/building-a-multibranch-pipeline-project 0

For an advanced tutorial on how to use Jenkins to build a multibranch Pipeline project with selectively executed stages.

industral/component-datauri 0

Component build data URI plugin

industral/content-hash 0

simple tool to encode/decode content hash for EIP 1577 compliant ENS Resolvers

issue commentvuejs/vue-cli

Babel v3 to v4 Migration Fails

not sure why issue was closed, it hasn't been fixed yet. If somebody has the same issue - just move your .babelrc to babel.config.js.

It should contain something like:

module.exports = {
  "presets": [
    "@vue/app"
  ]
};
ghost

comment created time in 2 months

startedplotly/plotly.js

started time in 2 months

issue commentampproject/amphtml

I2I: Trinity Audio Player extension

we have publisher with news via subscriptions, and our JS version of player works well there. In case of fetching URL we need to do that request on server with cookies, that even worse in that case. Even if we'll able to do that, some tokens could be bind to specific IP, and it will not work.

Suggestions:

  1. extension could accept CSS selector what should be read, and publisher has to specified it. We'll read only content using that selector.
  2. publisher gives his consent about reading text on a page by passing parameter to component explicitly e.g.data-allow-to-read-page-content="1"
industral

comment created time in 2 months

push eventMemeGlobal/amphtml

Micajuine Ho

commit sha 7ed054711f93c038f6cd0a932cd8144b043cc3b0

🏗 Apply `rtv_version` flag to dist and build tasks (#27196)

view details

Devin Mullins

commit sha 527898a11a3e812c19afccbeca9d3b37fa213007

Validator rollup (#27201) * cl/299411284 Allow links with `tel` scheme in email spec * cl/300054759 github commit msg missing or malformed * cl/300575599 Revision bump for #27098 * cl/300578001 Revision bump for #27132 * cl/300590811 Revision bump for #27027 * cl/300593269 Revision bump for #27170 * cl/300596115 Revision bump for #27134 * cl/300598356 Revision bump for #27076 * cl/300599497 Revision bump for #26912 Co-authored-by: honeybadgerdontcare <sedano@google.com>

view details

Devin Mullins

commit sha 0ec8d8b5b0c141ab1fe0f34692085d5dfcf4fa6b

parse-css library. (#27203) PiperOrigin-RevId: 300504323 Co-authored-by: Amaltas Bohra <amaltas@google.com>

view details

Alan Orozco

commit sha 9f96b129acedf332c302d0034d172596398dc542

🐛 [check-links] Don't reassign const (#27197) This breaks due to reassigning `const`, introduced in #26739

view details

Alex Ivasyuv

commit sha bc1efa5aaa23121693506ee8dce1dc3a9212afa7

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 2 months

Pull request review commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

+/**+ * Copyright 2020 The AMP HTML Authors. All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS-IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++import {Layout} from '../../../src/layout';+import {getData} from '../../../src/event-helper';+import {isExperimentOn} from '../../../src/experiments';+import {userAssert} from '../../../src/log';++const TAG = 'amp-trinity-tts-player';+const URL = 'https://trinitymedia.ai';+const CDN_URL = 'https://vd.trinitymedia.ai';++export class AmpTrinityTTSPlayer extends AMP.BaseElement {+  /** @param {!AmpElement} element */+  constructor(element) {+    super(element);++    /** @private {string} */+    this.campaignId_ = '';++    this.isExperimentOn_ = isExperimentOn(this.win, 'amp-trinity-tts-player');+  }++  /** @override */+  buildCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    this.campaignId_ = userAssert(+      this.element.getAttribute('data-campaign-id'),+      'data-campaign-id attribute must be specified for <%s>',+      TAG+    );+  }++  /** @override */+  layoutCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    return new Promise(resolve => {+      this.element.setAttribute('layout', 'fixed-height');++      const iframe = this.win.document.createElement('iframe');+      iframe.setAttribute('hidden', true);++      window.addEventListener('message', event => {+        if (getData(event)['type'] === 'trinity-player-rendered') {+          resolve();+          iframe.removeAttribute('hidden');+        }+      });++      iframe.addEventListener('load', () => {+        iframe.contentWindow./*OK*/ postMessage(+          /** @type {JsonObject} */ ({+            type: 'init',+            data: {+              text: this.win.document.body./*OK*/ innerHTML,+              campaignId: this.campaignId_,

OK, thanks @alanorozco ! Let's wait for their approval or suggesting how we should handle that in other way.

industral

comment created time in 2 months

push eventMemeGlobal/amphtml

Ryan Cebulko

commit sha c91a61a03432f4abba766b07f3b75aeb20eb2fa5

🏗️ enable 3-at-a-time batching for all sauce labs tests (#27051) * Run all sauce labs tests in 2-at-a-time batches * enable 3-at-a-time batching for Sauce Labs tests * Add clarifying comment about batch size * Revert changes to remote-tests commands * Limit browsers used in batches for --stable and--beta flags * Merge browser logic * Update comments * dont change case, just apply filtering * Flip conditionals

view details

Gabriel Majoulet

commit sha 286109abe0d2241c92407f3fac7b6d48e9ed2a2a

Story navigation education animations. (#27165) * Animations * Remove font-display: swap.

view details

Jake Fried

commit sha 6b439aec75c1d9b52ba19435f6730b27a457bf42

testing: enable chai-as-promised for integ tests (#27077) * testing: enable chai-as-promised for integ * lint hack * try different spot for the hack * concisify / remove todo * nits + fixes

view details

Alex Ivasyuv

commit sha e5105852661c2ffe26d82160b5634e81079524f6

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

Alex Ivasyuv

commit sha 691e08623c1b192017b8ee6117f729827a7db7f5

- revert fix for TypeError: Assignment to constant variable. - removed createPlaceholderCallback - added example of usage

view details

push time in 2 months

Pull request review commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

+/**+ * Copyright 2020 The AMP HTML Authors. All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS-IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++import {Layout} from '../../../src/layout';+import {getData} from '../../../src/event-helper';+import {isExperimentOn} from '../../../src/experiments';+import {userAssert} from '../../../src/log';++const TAG = 'amp-trinity-tts-player';+const URL = 'https://trinitymedia.ai';+const CDN_URL = 'https://vd.trinitymedia.ai';++export class AmpTrinityTTSPlayer extends AMP.BaseElement {+  /** @param {!AmpElement} element */+  constructor(element) {+    super(element);++    /** @private {string} */+    this.campaignId_ = '';++    this.isExperimentOn_ = isExperimentOn(this.win, 'amp-trinity-tts-player');+  }++  /** @override */+  buildCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    this.campaignId_ = userAssert(+      this.element.getAttribute('data-campaign-id'),+      'data-campaign-id attribute must be specified for <%s>',+      TAG+    );+  }++  /** @override */+  layoutCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    return new Promise(resolve => {+      this.element.setAttribute('layout', 'fixed-height');++      const iframe = this.win.document.createElement('iframe');+      iframe.setAttribute('hidden', true);++      window.addEventListener('message', event => {+        if (getData(event)['type'] === 'trinity-player-rendered') {+          resolve();+          iframe.removeAttribute('hidden');+        }+      });++      iframe.addEventListener('load', () => {+        iframe.contentWindow./*OK*/ postMessage(+          /** @type {JsonObject} */ ({+            type: 'init',+            data: {+              text: this.win.document.body./*OK*/ innerHTML,+              campaignId: this.campaignId_,

or you talking specifically to remove passing campaignId?

industral

comment created time in 3 months

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

Hi @alanorozco! Thanks for taking this review! I'm in GMT+2 TZ, but will try to fix it ASAP in order to pass it thought!

industral

comment created time in 3 months

Pull request review commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

+/**+ * Copyright 2020 The AMP HTML Authors. All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS-IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++import {Layout} from '../../../src/layout';+import {getData} from '../../../src/event-helper';+import {isExperimentOn} from '../../../src/experiments';+import {userAssert} from '../../../src/log';++const TAG = 'amp-trinity-tts-player';+const URL = 'https://trinitymedia.ai';+const CDN_URL = 'https://vd.trinitymedia.ai';++export class AmpTrinityTTSPlayer extends AMP.BaseElement {+  /** @param {!AmpElement} element */+  constructor(element) {+    super(element);++    /** @private {string} */+    this.campaignId_ = '';++    this.isExperimentOn_ = isExperimentOn(this.win, 'amp-trinity-tts-player');+  }++  /** @override */+  buildCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    this.campaignId_ = userAssert(+      this.element.getAttribute('data-campaign-id'),+      'data-campaign-id attribute must be specified for <%s>',+      TAG+    );+  }++  /** @override */+  layoutCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    return new Promise(resolve => {+      this.element.setAttribute('layout', 'fixed-height');++      const iframe = this.win.document.createElement('iframe');+      iframe.setAttribute('hidden', true);++      window.addEventListener('message', event => {+        if (getData(event)['type'] === 'trinity-player-rendered') {+          resolve();+          iframe.removeAttribute('hidden');+        }+      });++      iframe.addEventListener('load', () => {+        iframe.contentWindow./*OK*/ postMessage(+          /** @type {JsonObject} */ ({+            type: 'init',+            data: {+              text: this.win.document.body./*OK*/ innerHTML,+              campaignId: this.campaignId_,

The reason here is not to pass campaignId, but to pass page text that we should read. As I understand you can't access it from any component, if it's not wrapped into it.

industral

comment created time in 3 months

Pull request review commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

 function checkLinksInFile(file) {         return;       }       let containsDeadLinks = false;-      for (const {link, status, statusCode} of results) {+      // eslint-disable-next-line prefer-const+      for (let {link, status, statusCode} of results) {

there was issue with checking, it failed on that due to reassign const. Will do if it's already fixed

industral

comment created time in 3 months

Pull request review commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

+/**+ * Copyright 2020 The AMP HTML Authors. All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS-IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++import {Layout} from '../../../src/layout';+import {getData} from '../../../src/event-helper';+import {isExperimentOn} from '../../../src/experiments';+import {userAssert} from '../../../src/log';++const TAG = 'amp-trinity-tts-player';+const URL = 'https://trinitymedia.ai';+const CDN_URL = 'https://vd.trinitymedia.ai';++export class AmpTrinityTTSPlayer extends AMP.BaseElement {+  /** @param {!AmpElement} element */+  constructor(element) {+    super(element);++    /** @private {string} */+    this.campaignId_ = '';++    this.isExperimentOn_ = isExperimentOn(this.win, 'amp-trinity-tts-player');+  }++  /** @override */+  buildCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    this.campaignId_ = userAssert(+      this.element.getAttribute('data-campaign-id'),+      'data-campaign-id attribute must be specified for <%s>',+      TAG+    );+  }++  /** @override */+  layoutCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    return new Promise(resolve => {+      this.element.setAttribute('layout', 'fixed-height');++      const iframe = this.win.document.createElement('iframe');+      iframe.setAttribute('hidden', true);++      window.addEventListener('message', event => {+        if (getData(event)['type'] === 'trinity-player-rendered') {+          resolve();+          iframe.removeAttribute('hidden');+        }+      });++      iframe.addEventListener('load', () => {+        iframe.contentWindow./*OK*/ postMessage(+          /** @type {JsonObject} */ ({+            type: 'init',+            data: {+              text: this.win.document.body./*OK*/ innerHTML,+              campaignId: this.campaignId_,+              pageURL: this.win.location.href,+            },+          }),+          '*'+        );+      });++      const src = `${URL}/player/trinity-amp`;++      iframe.setAttribute('frameborder', '0');+      iframe.setAttribute('allowfullscreen', 'true');+      iframe.src = src;++      this.applyFillContent(iframe);+      this.element.appendChild(iframe);+    });+  }++  /** @override */+  createPlaceholderCallback() {+    const placeholder = this.win.document.createElement('amp-img');

OK, will do. I believe I did it as amp-jwplayer extension, that was provided as example PRs https://github.com/ampproject/amphtml/blob/master/contributing/building-an-amp-extension.md (see in the bottom)

industral

comment created time in 3 months

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

@jridgewell finally I see all tests passed 👍But I see ampproject/owners-check — Missing required OWNERS approvals!. Who should approve it? Is there any required actions from my side?

industral

comment created time in 3 months

push eventMemeGlobal/amphtml

Jake Fried

commit sha e44a2c10d579723a8413fd55ba7a0d865629710b

amp-script: decouple dev modes (#27076) * amp-script: data-ampdevmode enabled dev mode * update doc * update validator * lint * remove whitespace * must be false * invalidate data-ampdevmode * empty string needs to enable dev mode. also root node should work * get rid of root html node again unless people love the idea * Revert "get rid of root html node again unless people love the idea" This reverts commit 59c03cddeb6f0bb0c7e86f39e8e1cc9e3661bcfd. * nit * add link to pr. * Update validator-amp-script.protoascii

view details

Oliver Yu

commit sha 6935ec50a8fd2ef040f4402ea6dcdcf8ac8209df

Remove deprecated Cloudflare AMP Cache and A4A support. (#26912)

view details

Ryan Hughes

commit sha c2c74b2de2029b323c7a6a6d7d4c7876c4ace653

🐛Delete setting of incorrect field "iframe_" (#27163)

view details

Enrique Marroquin

commit sha 0636c412e85cbe78c6742b1ca3489b8aa572bc13

sandbox iframe (#27179)

view details

Hongfei Ding

commit sha 833ec75662a59f5512cc966559056a8cac47d037

Change OWNER wg-ads to wg-ads-reviewers (#27186) * Change OWNER wg-ads to wg-ads-reviewers * Remove jeffkaufman * one more * prettify

view details

Alex Ivasyuv

commit sha 824e742be51ddf54638d6bb2c976d1afd8cd314a

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 3 months

push eventMemeGlobal/amphtml

Jeff Kaufman

commit sha ff8d6c1071233b1f4567039f9a6c58409cee17b2

🏗 ads owners: don't send reviews to jeffkaufman (#27135) * ads owners: don't send reviews to jeffkaufman * lint

view details

Esther Kim

commit sha 85b7d9b1dbecbd3de6b4a3f857153b416cf5f796

🏗 Log dist error on Travis and fix outdated dependency (#27158)

view details

George Luo

commit sha a6f32a92ebef85f24f0ac33de67b4ea178db3b67

🐛 Bug fix (#27096) * align to validator js business logic in master * Executing 'mvn clean' should remove validator-all.protoascii and ValidatorProtos.java. Co-authored-by: nhant01 <nhan.thuan.nguyen@verizonmedia.com>

view details

honeybadgerdontcare

commit sha 4de9a9c1718cb32dda23cc24b051f5e21c2254a4

Sync from Google (#27156) * - Make values returned by JsonObject::Get immutable, by returning a pointer to the value. - Add a Getter method for JsonDict, which also returns a pointer to the value. PiperOrigin-RevId: 299378494 * Add constness to const methods. PiperOrigin-RevId: 299465169 Co-authored-by: Amaltas Bohra <amaltas@google.com>

view details

Gabriel Majoulet

commit sha bb34805d1605adfe7aced444c44b6ad401f011cf

Story navigation education. (#27140) * Squash commits. * s/this.getAmpDoc().win/this.win

view details

WhiteSource Renovate

commit sha 2527cc9d9640425ced6640720f21baae51aa050b

📦 Update dependency rollup to v2 (#27128)

view details

Caleb Cordry

commit sha eb3d5f37815f6e5efa5c9b63ca0128cfcc4404fa

♻️Introduce new detached dom writing logic. (#26945) * wip * renaming & return body complete * transform test * cleanup * streamer test * test errors * remove demo code * clean up comments * comments

view details

Jake Fried

commit sha 3488672872a98df3df29a150bffc7bfca7994586

bind-impl: introduce getStateAsync (#26992) * wait for url-based amp-state * remove when complete * fix tests * remove extra nl * loosen promise type * in-progress, to be amended after unit tests * amp-bind: rescan test * fix types * undo promise refactor * add more tests and fix types * lint * mr. clean * more mr clean * mr clean town * remove registration + map in favor of dom scan * fix tests for new interface * lint * remove only * lift addAmpState * lint * remove bugfix * remove init gate * update documentation * remove extra nl * forgot to remove a single wait:true * lint * fn rename. getStateWithWait --> getStateAsync * address feedback * clena up getFetchingPromise * s/throw/reject * querySelect --> querySelector * fix tests * explanatory comment * fix integ * solve race * Update extensions/amp-bind/0.1/bind-impl.js Co-Authored-By: Justin Ridgewell <justin@ridgewell.name> * add tests * copy * remove describe.only * .match does not work with strings * nit: stateKey --> stateId * add catch resolution clasue Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

view details

WhiteSource Renovate

commit sha 06fa0e8aab5f39930d7d6159ac4111c22048c661

📦 Update dependency jsdom to v16.2.1 (#27164)

view details

WhiteSource Renovate

commit sha 82c9e7790cb890d4bfc82c9555d014d21d02020e

📦 Update dependency **/**/debug to v4 (#27170)

view details

WhiteSource Renovate

commit sha 509cebc933bde2dc27ad6107d83aa46f5ea5126b

📦 Update dependency sinon to v9.0.1 (#27169)

view details

Jake Fried

commit sha 5137ce381ab6e36419f2604efb2de44e54ab772e

✨ amp-bind: allow facetime protocol for links (#27134) * amp-bind: allow facetime protocol for links * add factime * add in other missing protocols * add reminders

view details

Enrique Marroquin

commit sha b21972a15c6aa3ad8cd8fcbcf6856a9ec291c26d

install viewer integration script on build, not on layoutcallback (#27166)

view details

Alex Ivasyuv

commit sha aa3f008baf58c59d33946f9de27e02d672220352

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 3 months

push eventMemeGlobal/amphtml

Justin Ridgewell

commit sha f6246b652cc14178a71bcf33ac80759bcb5e4bcc

Add React Hooks linter (#27142)

view details

Justin Ridgewell

commit sha 474c9f9cad9d29bf6edae2c16d63e30ed3d6e64c

Disable ampCors for analytics vendors requests (#27144) This should improve cacheablity.

view details

Rich Hall

commit sha b2a5d71eb8dc4079fd682f4d7113829fd46345cf

Fix typo in amp-ad.md (#27102) Correcting availbel to available

view details

Sebastian Benz

commit sha 66281384888c271f26f26e7b1b138c7a90ba9a32

Revert "Fix filters in amp-bind reference (#27143)" (#27154) * Revert "Fix filters in amp-bind reference (#27143)" This reverts commit 7bddc1ae9b3321e45f96180445ef2a98dd7d340b. * cleanup filters

view details

Raghu Simha

commit sha 12d8861b56f7c6ec0079701722345f4bd349d843

🏗 Standardize on-demand package installation for `gulp` tasks (#27141)

view details

William Chou

commit sha 54c8873388a31a3df1c6e27cb922a28ab168d447

First pass at IntersectionObserver in Resources (#26236) * Rebase IO prototype with examples. * Support unload, fix build/measure/layout order. * Uncomment and gate discoverWork_(). * Uncomment and gate relayoutTop and remeasurePass. * Uncomment and guard remaining code. * Uncomment . * Use isIframed(), simplify mutate switch. * Update TODOs. * Only enable on Chrome 81+. * Move observation to upgrade, only force-build intersecting elements. * Fix unload timing, always wait for build. * Fix collapsing, delegate layout box calc to viewport binding. * Remove a couple TODOs. * Correctly defer ready-scan signal, fix unobserve due to reparenting. * Cleanup some TODOs. * Skip passes after resize (vsync) and expand. * Apply sizes/media queries on viewport size change. * Remeasure all resources on viewport size change, and support requestMeasure. * Reenable remeasuring children after size change. * Fix wrong early return. * Partial revert: don't request measure on every mutate. * Add experiment and guard. * Add measure and unload helpers for DRY. * Fix lint. * Fix types. * Various clean up. * Tweak Resource.measure_, fix presubmit. * Fix types again. * Fix bugs, don't run pass on scroll. * Add comment about fast scrolling issue. * Fix amp-accordion collapse detection. * Accordion fix is just an animation tradeoff; adjust comments. * Add comment about unlayout. * Revert idempotency of Resource.measure_. * Fix method signature. * Remove 'stress' example pages. * Fix test-viewport.js. * Tweak feature detection. * Invert measureResource_, better comments. * Fix JSDoc. * Add a couple TODOs. * Coerce type for root. * Fix typo. * Need downcast->upcast to avoid JSC error. * Justin's comments. * Fix test-layout-rect.js, minor comment. * s/isExperimentOn/isIntersectionExperimentOn

view details

WhiteSource Renovate

commit sha e705eeac671b91871cc4efec408a7adc5324ea8c

📦 Update dependency @percy/agent to v0.24.3 (#27112)

view details

Alex Ivasyuv

commit sha 4c03169dd5bf6cc228710bc5721556593c09b6d0

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 3 months

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

now it failing on cicd on some other component

industral

comment created time in 3 months

push eventMemeGlobal/amphtml

Dima Voytenko

commit sha dc473eed4a95b56c0aa9245d35d700ae56b2120c

Aspect ratio format for amp-story-grid-layer (#27027) * Aspect ratio format for amp-story-grid-layer * renamed format to aspect-ratio * switch to service * fix setStyle * tests for setStyle * review fixes * tests * cleanup * validator fixes

view details

Filip Stanis

commit sha 7bddc1ae9b3321e45f96180445ef2a98dd7d340b

Fix filters in amp-bind reference (#27143)

view details

Alex Ivasyuv

commit sha 1d2ab45942aa8e0885a497f89d55e5b330a2179f

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 3 months

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

visual still failing https://percy.io/ampproject/amphtml/builds/4430937?utm_campaign=ampproject&utm_content=amphtml&utm_source=github_status_public. @jridgewell can you please take a look or accept it manually?

industral

comment created time in 3 months

push eventMemeGlobal/amphtml

Robin

commit sha de215bf5ef05bb73155cfc760ed5e8accb10c71a

🐛 Update format for story-components (#27129)

view details

Max Lever

commit sha fc0aa1b9018ceaada26a6a76438f483f15421c07

🐛 propagate title attribute in amp-iframe (#27037) * add title attribute to amp-iframe validator * add amp-iframe title to bind-validator * propagate title as amp-iframe attribute * only propagate mutated attributes * add test for title propagation * only propagate title * check if title was mutated before propagating * alphabetize propagated attrs in amp-iframe * document why we're only propagating title * add test for mutating 'title' attribute in amp-iframe

view details

greg-silvermine

commit sha 4a21c7d3cc7eefc2a75cfc015b11cdf77fc918a9

✨The Ozone Project: Update RTC endpoint macro in callout-vendors.js (#27103)

view details

Ryan Hughes

commit sha 2a90c87ee6ff10fb91c5d21ac65870f4d7f325e0

🐛Remove Google Safeframe origin check (#27074) * Update safeframe check * Update safeframe check * Change quotes * Adding source check * Working on updating tests * Use verbose flag instead * use devAssert * Clean up code * Clean up code * Clean up code * Lint fixes * Update type check * Lint fixes * Lint fixes

view details

Gabriel Majoulet

commit sha 114d2c11b87c9e738014c9544db0b3fce7bea823

amp-story-education extension boilerplate. (#27098) * amp-story-education extension boilerplate. * Lint.

view details

John Burnette

commit sha a9a67e26382a047b0dc54239ebc7fe9e1bf451c1

✨ Add support for tracking sub ids for revcontent amp ads (#27013)

view details

Enrique Marroquin

commit sha 9491ea82da3dfae0ed94d33d71654eea2874566f

allow nonce in inline bookend (#27132)

view details

Robert Linder

commit sha e8099e8fd4d4652d3f2da426545f07b5908a9157

Allow `text/javascript` for amp-script (#27136)

view details

Max Lever

commit sha 95957adab23535fe0a42ed5550762875d3017ba4

alphabetize propagated attrs in amp-img (#27115)

view details

colmsnowplow

commit sha 2a995e1481f0dda8dec6e1b2f213dce3756f07e3

🐛 Snowplow Extension: Patch Page Pings (#27106) * Add new page ping method * Update amp ID cookie storage * Update tests * Add warning message to v1 json config

view details

Alex Ivasyuv

commit sha 288125ea9e6914f37670038243b9b9fb007a4eb5

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 3 months

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

@jridgewell now it fails on other components https://percy.io/ampproject/amphtml/builds/4425094?utm_campaign=ampproject&utm_content=amphtml&utm_source=github_status_public (facepalm)

industral

comment created time in 3 months

push eventMemeGlobal/amphtml

Caroline Liu

commit sha 2a7b408d33ecae6e56ef5fe78a6f0379acf0c1cc

✨ Initial amp-timeago Bento component (#26507) * amp-timeago v2 * Remove parseInt * Refactor logic into getFuzzyTimestampValue * Lint * Add IntersectionObserver to rerender * Modify useIntersect * Refresh timestamp when entering view * Move useIntersect * Pass props to getFuzzyTimestampValue * Use useRerenderer * Add callback comments * Pass empty array to `useLayoutEffect` * Add timeago.js to build check allowlist * Remove useRerenderer and implement useInView * Update bind example on test page * Correct amp-bind example text * Refactor useIntersect as useInViewEffect * Rename use-intersect.js * Allowlist 3p timeago dependency * Restructure shape of useInViewEffect * Pass ref.current to useInViewEffect * Clean up typing * useInView -> useIntersect, useOnEnterViewport * Reset isIntersecting in cleanup function * Restore useInView implementation * Refactor new logic * Share IntersectionOb across timeago instances * Replace useFnInView with useIsIntersecting * Update DOM on enter viewport only * Move file + lint * Delete file * Rename timestamp to timestampRef * Initialize timestamp with null * Add type annotation to timestampRef * Map elements to setters * Place IntersectionObserver in component * Delete useIsIntersecting * unobserve -> disconnect * Array destructure * Specify props more granularly * Types

view details

Daniel Rozenberg

commit sha 6ab5e7433c79d418643a4c7be39e3d5dc29dcd6b

📦 Update dependency @percy/agent to v0.24.1 (#27099)

view details

Raghu Simha

commit sha 2a1187cfd2c4db5ea459422a2a0d6e67624edb0f

📦 Update dependency tsickle to v0.38.1 (#27104)

view details

Caroline Liu

commit sha dc682d5694f51b083d718f611cdbf54c142ab151

amp-carousel expose `ampTrust` in `slideChange` event (#26991) * Proof of concept * Use signals instead of boolean param * Make autoplayTimeoutId_ private * Add tests * Import actionTrustToString * Remove `userInteracted` and related * Remove irrelevant test lines * Remove signal enum * No intermediary variable

view details

Justin Ridgewell

commit sha c9c99f882d044e421177fea573bd103b8e7b3656

🏗 Allow JSX syntax (#26903) * Allow JSX syntax * Add react transform * Switch to Preact namespace * Copy sourcemaps for pre-closure babel transforms * Fix packages * Add preact eslint rule * Fixup plugins and sourcemaps * lint * Update Preact Types Defs * Undo sourcemap changes * Fix leading comments React constant elements was hoisting a cached value between the JSDoc comment and value it annotated. This is beacuse the comment was actually attached to the previous node as a trailing comment. * Fix Fragment reference * Perform single-pass browserify crawl in TMP directory

view details

Raghu Simha

commit sha f2000d0d79c513e099f9cfc15b701d29d0fcd1fa

Fix Timeago Preact Type (#27113)

view details

William Chou

commit sha 4f6325df548dfde52eb43658e70c029f77913eaf

Use { passive: true } on gesture.js (#26876)

view details

Ryan Cebulko

commit sha 58a99467b92a6af72a6c47a2bf57fd5fdd2ad060

📦 Update dependency selenium-webdriver to v4.0.0-alpha.7 (#27105)

view details

Jake Fried

commit sha 4e275bad433d4687a5adbcb0fb6d1c7a8d784f0c

🐛 activation-tracker: 'change' is an activation event (#27108) * activation-tracker: 'change' is an activation event * sort

view details

Justin Ridgewell

commit sha 5f9bce32d2f09a37209dad95698654c559a76d0e

Fixes various review comments on JSX PR (#27116) * Fixes * Nits

view details

Shihua Zheng

commit sha e1541036396967ef12031009242e8851a2e48390

📖Update amp-ad-exit docs (#26972) * Update amp-ad-exit docs * lint

view details

Alex Ivasyuv

commit sha c3cbd6ef378232f8cc5aadac9eddc1357ac2a1d2

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 3 months

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

so far visual fails each time on that one https://percy.io/ampproject/amphtml/builds/4388616?utm_campaign=ampproject&utm_content=amphtml&utm_source=github_status_public

industral

comment created time in 3 months

push eventMemeGlobal/amphtml

honeybadgerdontcare

commit sha acd5cd1c3a29ad2ca92c66643357aabb419f1190

Sync from Google (#27084) * Add url parsing functions. PiperOrigin-RevId: 296030023 * Add bazel file for grammar/ PiperOrigin-RevId: 296036004 * Fix a segfault which gets exposed only in gcc compiler. PiperOrigin-RevId: 296054553 * Remove undefined macro. PiperOrigin-RevId: 296054595 * Fix missing license text. PiperOrigin-RevId: 296063482 * Add json bazel file and prettify json testdata. PiperOrigin-RevId: 296064005 * Add bazel files for bin/ and data/. PiperOrigin-RevId: 296071309 * Remove unnecessary FLAG. PiperOrigin-RevId: 296075789 * Fix Node::DebugString() PiperOrigin-RevId: 296243621 * Whitelist a test case file. Corrected the test case output. PiperOrigin-RevId: 296243638 * Fixes and whitelist a test case, by allowing deprecated tags in test cases. PiperOrigin-RevId: 296268565 * Fixes and whitelist svg testcases. PiperOrigin-RevId: 296272502 * Fix a few more html5 test cases. PiperOrigin-RevId: 296291189 * Fix and whitelist <isindex> test cases. PiperOrigin-RevId: 296292146 * Whitelist main element test cases fixed in previous change. PiperOrigin-RevId: 296294494 * Fix C++ JSON Parsing by allowing \r anywhere we allow \n. PiperOrigin-RevId: 296492305 * Remove \f which is not a whitespace char in json syntax. PiperOrigin-RevId: 297128163 * Update line/col stats in tokenizer if new line is '\r' only. PiperOrigin-RevId: 297284764 * Defines Json types, to use in parsing json and writing c++ objects to json. PiperOrigin-RevId: 297662326 * Add support for json serialization of user defined data types. PiperOrigin-RevId: 297928702 * Replace raw pointers with unique. PiperOrigin-RevId: 297979276 * Prettyprinted json output. PiperOrigin-RevId: 298446324 Co-authored-by: Amaltas <amaltas@amaltas.org> Co-authored-by: Greg Grothaus <ggrothau@gmail.com>

view details

honeybadgerdontcare

commit sha 8a956d1b9cbbf82268681ff7cba11266ffe7c517

Add licenses that were missing (#27085) PiperOrigin-RevId: 298871126

view details

Dima Voytenko

commit sha 76bdef599383f94286b18ef8db9e60b9b2a9c19c

📖 Fix validation errors in amp-web-push example (#27022) * Fix validation errors in amp-web-push example * Remove unnecessary id of amp-web-push

view details

Dima Voytenko

commit sha ba6148911af87e0c0450e7fd788a5b0018f3c637

✨amp-access-scroll: Update the activate bar to properly set up relay for resizing (#27047) * Update the activate bar to properly set up relay for resizing * Add scrollx param to scroll bar url

view details

Micajuine Ho

commit sha 9eebb49390bfb85f65de0d54cb425b58eaae2d22

Avoid encoding data-amp-addparams (#26172) * Expanding params, with checks * Update url-replacements-impl.js * Suggested changes * Undo resolve early

view details

William Chou

commit sha 433f5f930e51c6dde08380991882ef189f4e8563

Fix one more referecnes to Mustache.js (#27087) See #26950 for background.

view details

Dima Voytenko

commit sha 9121d2fc91a4e8b2f70f886667ca3052dc89a9f8

Bump protocol version (#27088)

view details

Yuxuan Zhou

commit sha b4e7c02011d1e0287bb3ceb4427cb335a58c22e8

Add linker to ADOBEANALYTICS_CONFIG (#26289) (#27078) * Added linker to Adobe Analytics * Changed the internal Adobe Analytics type from 0 => 2 * removed the request type priority from AdobeAnalytics * updated tests for AdobeAnalytics to reflect changes * added linker to example

view details

Enrique Marroquin

commit sha c0e78fdf702117af3595bdacbb52ff1c1aa14f8f

New onDocumentState viewer messaging. (#27089)

view details

Alex Ivasyuv

commit sha cd5043af8867be77d18e98878760a0c656d1e749

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 3 months

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

@amaltas @jridgewell @ampproject/wg-ui-and-a11y can you guys help me, can't pass PR for 2 weeks now, as it fails every time with different issues not related to my code, e.g. checking, e2e tests, visual checking, etc.. each time new failing. I can't rerun them, so have to wait when a new code arrives into master and make remove merge/push in order to run checking again... Maybe I'm doing something wrong, and I shouldn't use master branch? So far it's broken. Please let me know how I can pass it through. Thanks!

industral

comment created time in 3 months

push eventMemeGlobal/amphtml

Jake Fried

commit sha d92844df966adac61b6712028ec01636060388b9

gulp performance: emit status updates (#27030)

view details

Justin Ridgewell

commit sha d32bf3b3751b1184b1d46b20e67a3f569cd93313

Remove TransferLayerShadow (#27057) I missed this when 🔪 iOS Shadow DOM Wrapper in #24273.

view details

Caroline Liu

commit sha 0fabf501cc126df7c5402fecd9dca9a041102dee

Fire low trust events when relevant in amp-carousel v1 (#27063) * Propagate trust from source of action * Scrolling is low trust * Default to LOW trust for updateOnScroll * Move opt_trust param to showSlideAndTriggerAction

view details

Naina Raisinghani

commit sha 59c433fdb4e0598b1f104a2b74204fb991ab8ef9

Update link to Mustache spec and not JS implementation (#26950) For context see here: https://docs.google.com/document/d/1lsG9svgClzfknEwWD8mMc7kf91N8RJhGrssNPc0lO9E/edit#bookmark=id.1xum78ltl3cu

view details

Derek Springer

commit sha bd4ac9916670cb22f51634e024775c2262e92db7

Updating Pubmine amp-ad to utilize amp-consent states. (#26794) Support for CONSENT_POLICY_STATE Prettier fix Update unit test to include `consent` Clarified npaOnUnknownConsent use Making 'false' check on data['npaOnUnknownConsent'] explicit Adding note about data-npa-on-unknown-consent to optinal parameters.

view details

Alex Ivasyuv

commit sha 606e96ae19e5e20fb8b37623fc1566b3955d8569

Merge branch 'remote-master' into amp-trinity-tts-player

view details

push time in 3 months

push eventMemeGlobal/amphtml

Alex Ivasyuv

commit sha c7e3602d03f15a430720b1ddb80b4b82d959235b

fixed issue with TypeError: Assignment to constant variable.

view details

push time in 3 months

push eventMemeGlobal/amphtml

Enrique Marroquin

commit sha 9566fe67b1ea215853824eb9126294144705c657

update owners file with correct syntax (#26899)

view details

Enrique Marroquin

commit sha ccceb7bbc12e1b6501229fcbd6e6b72840d07400

✨[amp-story-player] Adds tap-to-next/previous story (#26865) * tap to next/prev * add unit tests, encapsulate position updates into helpers, get rid of messagingFor * clean tests

view details

Yuxuan Zhou

commit sha 1f9e6bfcce4125436777a60ecb8348491e525d29

Update consent string maximum size to 200 bytes (#26741) * update maximum byte to 200 * nit

view details

Micajuine Ho

commit sha 50717b036dcbc0599e0488274862400e4276af44

🚀 Move scroll left and top macros out of url-replacement-impl (#25594) * moving variables and tests * fixing tests

view details

Micajuine Ho

commit sha ddfd41b2ca54a241c5041f381700deca2d9957da

Improve test vendor requests macros (#26828)

view details

Devin Mullins

commit sha 943e91e0b47205fece56e7cfc55abad3f5176739

📖 Clarify SXG duration minimum (#26890)

view details

Micajuine Ho

commit sha 43692d451973701753624a5839a1a37924f5e252

Amp consent restrict fullscreen prod flag (#26909)

view details

Enrique Marroquin

commit sha f67410266043c420be7431b4dfe98ab4a688faff

📖 [amp-story-player] Initial docs (#26606) * initial docs * separate api into different headings * comments * remove duplicate img * add in line executable code * reviews * reviews * update story title

view details

Kristofer Baxter

commit sha 99c5984e87b8ea34d29ce53c605c44e8e2bbbf27

🚀 Remove doc css and base css from ESM build (#26889) * Remove imported base css for valid transformed documents * Ensure defaultPlugins is always called with a boolean

view details

juno suárez

commit sha ecfb6c1ef4c62b3603df9eca4a2e6cd791fea20a

✨ Update amp-access-scroll (#26810) * ✨ Update amp-access-scroll This PR - adds a protocol version query param to requests made from amp-access-scroll for compatibility - adds a "holdback" flag and styles to prevent mismatched rendeirng with new layout - renames ScrollAudio to ScrollSheet - adds ability to dynamically size horizontal layout for ScrollComponents. Special care was taken to ensure these properties cannot interrupt vertical browser layout; only width, left, and right are allowed. Dynamic sizing is necessary to pervent invisible iframes being drawn over usable parts of the underlying page, which would cause UX and accessibility problems in certain layout scenarios. Dynamic sizing solves this by shrinking the iframe to fit the size neccessary to fit the rendered controls. * Refactor holdback and iframe title * Resolve circular dependency * Simplify scrolltab classes * Cleanup css * Use setAttribute * Update scrollbar dimensions

view details

Matt Mower

commit sha 4c71f6c6ba251e393fc169c38ec4385e1061fce2

amp-action: Support whitelist lookup in AmpDocShadow (#26684) * amp-action: Support whitelist lookup in ShadowRoot New getMetaByName method supports retrieving meta content values in shadow docs as well. * amp-action: Remove unnecessary doc check It is safe to assume that either document.head is available if AmpDocSingle/AmpDocFie, or that AmpDoc.meta_ is non-null if AmpDocShadow.

view details

Matt Mower

commit sha 5721bc4aefb62c54629bef07da241b6453e3e5da

dom: Minor test improvements (#26913) * dom: Add layout attr where needed in unit tests * dom: Resolve another sinon warning Expect another console error.

view details

Matt Mower

commit sha 337898b05c3d515ed9d0b719c0c7106a03034d93

viewer: Minor test improvements (#26906) Make test aware of some console errors when expected.

view details

Matt Mower

commit sha c1d233f976ccbe98340d2fdc92fbe970fd6f2163

amp-pixel: Minor test improvements (#26918) * amp-pixel: Minor test improvements Expect console errors. * amp-pixel: Revisions from review Create reusable regex for tests.

view details

Matt Mower

commit sha 82cce8211345c5012ac76e81d6a80c712753f13f

custom-element: Minor test improvements (#26923) Expect console errors. Specify layout params where necessary.

view details

WhiteSource Renovate

commit sha 3dc54cfad57ad6a0adb912faaeb8720b29087218

📦 Update dependency @percy/agent to v0.22.0 (#26910)

view details

WhiteSource Renovate

commit sha d2d000cac9abcb1a1991749443a3d2d1ee7afcfb

📦 Update dependency sinon-chai to v3.5.0 (#26884)

view details

Ryan Cebulko

commit sha ae7b203c45199d7a80dda63f2b326231c8ccc6d7

Increate karma browser activity timeout to 5min (#26887)

view details

WhiteSource Renovate

commit sha 1b2413852b83d7b4ce7fd403df9fcf54321fea94

📦 Update dependency typescript to v3.8.2 (#26898)

view details

Jake Fried

commit sha 3a7b315300650702be8c42f2aa623db2751fd37b

performance-impl: use performance.now() over Date.now() (#26512) * performance-impl: use performance apis instead of Date.now() * small self-nit * missed a Date.now() * fix strange test * lint and delete incorrect comment * prerenderComplete test should check for subtraction of docVisible time * make it harder to think that perf.now can be stubbed with Date.now * fix failing test. * should not check ordering

view details

push time in 3 months

more