profile
viewpoint
Alex Ivasyuv industral Ukraine, Lviv Senior Software Engineer

industral/NikaFramework 8

NikaFramework - Architectural WebUI JavaScript SPA Framework {OUTDATED}

industral/nixie-clock 2

I2C Nixie Clock

industral/SilentMedia 1

C++ audio library supporting ALSA/OSS/libao and wav, wv, flac, ogg formats

industral/aac.js 0

AAC decoder in JavaScript.

industral/aurora.js 0

JavaScript audio decoding framework

industral/boxAudio 0

Stream audio directly from Dropbox! 🤘

industral/building-a-multibranch-pipeline-project 0

For an advanced tutorial on how to use Jenkins to build a multibranch Pipeline project with selectively executed stages.

industral/component-datauri 0

Component build data URI plugin

industral/content-hash 0

simple tool to encode/decode content hash for EIP 1577 compliant ENS Resolvers

push eventMemeGlobal/amphtml

Raghu Simha

commit sha e11dc17004e3c7eda769e8a9fe874de9e488a945

✅ Skip another flaky shadow integration test on Safari (#26875)

view details

WhiteSource Renovate

commit sha 6d3d7daaeb14828cd2e0de5c1ead02f116aa0083

📦 Update dependency sinon to v9 (#26858)

view details

WhiteSource Renovate

commit sha ebcc4c655cd6fd066a9f01d30e0182e11f47af45

📦 Update dependency tempy to v0.4.0 (#26759)

view details

WhiteSource Renovate

commit sha 6de1cf4a5d2f94cb82d097c228a446b53c08dc8a

📦 Update dependency postcss to v7.0.27 (#26839)

view details

WhiteSource Renovate

commit sha 421e30c32960b135a8378380f6588d9d90d19de5

📦 Update dependency jsdom to v16.2.0 (#26591)

view details

Denys

commit sha 911661bd0d2f07bcf9cca9312fea34175ace32af

✨Idealmedia uniq ad (#25838) * Support for MGID | Idealmedia | Lentainform ads network * update * test trigger * Support for MGID | Idealmedia | Lentainform ads network * test trigger * Lentainform new improvements * Idealmedia fix * Revert "Idealmedia fix" This reverts commit cbe9046b76908d906f6950b90caec2b9cd4aca8b. * idealmedia fix * Revert "idealmedia fix" This reverts commit 7ea09a7edc8e23cc2f9b4e16789200b98a2323a0. * Idealmedia fix * idealmedia. adding uniques widget id * idealmedia. adding uniques widget id * idelmedia. adding uniques widget id * idelmedia. adding uniques widget id * idealmedia. adding uniques widget id

view details

ajwhatson

commit sha f56cdd41b4ff3a6d549d6dd07ae6c317f8ac9b5b

🐛 Bug fix: check links test (#26739)

view details

Esther Kim

commit sha caf985d35fb10317b101d86af3a08ff4efea575d

Add performance metrics to README (#26891)

view details

Matt Mower

commit sha 7627a16bff834f8c2e89a04c2c2560945f8a9ee7

amp-sticky-ad: Fix unit test (#26855) Resolve the following unit test failure: should not build when child is not ad Error: Uncaught Error: The element did not specify a layout attribute...

view details

Alex Ivasyuv

commit sha 67bdda1e07d83019687fa81d0c758b51d755799a

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 5 days

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

I can see flickering tests, each time fails different one, not related to that extension.

industral

comment created time in 6 days

push eventMemeGlobal/amphtml

Vidyome

commit sha 9d612177558105761036ee5b6592cb2d126a3107

TE Medya Widget Update (#26850) * Add files via upload * Add files via upload * Update temedya.js * Update integration.js * Update _config.js * Update temedya.js * Update ads.amp.html * Update _config.js * Update amp-ad.md * Update temedya.md * Update _config.js * Update temedya.js * Update temedya.js * Update temedya.js * Update _config.js * Update _config.js * Update temedya.js * Update temedya.js * Update temedya.md * Update temedya.md * Update temedya.js * Update temedya.js * Update temedya.js * Update temedya.md * Update temedya.md * Update temedya.md * Update temedya.js * Update temedya.md * Update temedya.md * Update temedya.md * Update temedya.js

view details

Enrique Marroquin

commit sha 5bcb4deece68e3a4871c606144d79c37b7eafe4b

✨[amp-story-player] Adds navigation logic (#26751) * navigation logic * renaming and jsdocs * factorize visibilitystate methods, API renaming, remove unneeded resolvers * add tests, rename methods * linter * move iframepool to another file, add todos, replace for constants. * jsdocs * replace rotateleft and right

view details

Malte Ubl

commit sha aed340c1874cd5e59ec8b20b36417a0ca7334840

✨Render captions in the vertical render mode of stories (#26849) - Introduces a new file for "semantic rendering" to factor out the related code into its own place. - Render WebVTT and TTML based captions as paragraphs into the vertical document. - Fixes a bug where text could still be white on white due to CSS inheritance.

view details

WhiteSource Renovate

commit sha 60adecfb183c416f34fc32f693f9520e9a500835

📦 Update dependency codecov to v3.6.5 (#26450)

view details

WhiteSource Renovate

commit sha d442485853a519a4c6519a55f66990072181df26

📦 Update dependency amphtml-validator to v1.0.30 (#26772)

view details

Matt Mower

commit sha 230fc304553708f4627b6ce31dd24c3f83b6c39a

amp-bind: getStateValue: Return nullable string (#26857) - Allow returning null from Bind.getStateValue() so that values 'null' and 'undefined' are not cast to strings "null" and "undefined" - Set AMP_STATE URL replacement to substitute an empty string if Bind.getStateValue() returns null

view details

Raghu Simha

commit sha ad6c09a71ccf7aa7092a0cdc43862de3f2551b12

✅ Skip flaky shadow integration test on Safari (#26864)

view details

Matt Mower

commit sha 8f0aa2d54ee3bfea22ed15292b4b1a24ce88e3f2

ampdoc: Fix params unit test (#26831) - Arguments to describe() were incorrect. - Expected result to explicit params tests was incorrect.

view details

honeybadgerdontcare

commit sha a2a9c267718ed6604e617fc662834201332670bb

Sync from Google (#26856) * Add JSON parser to validate json content in HTML. PiperOrigin-RevId: 292678263 * 1) Introduce exclude char '^' 2) Implement range syntax. 3) Introduce '\u' identifier for non-ascii character match. PiperOrigin-RevId: 293155674 * Add IsWhitespaceChar function that determines if a character at a given position is a whitespace char including any unicode whitespace. PiperOrigin-RevId: 293718940 * Adds Strings::SplitStrAtUtf8Whitespace string util method. PiperOrigin-RevId: 293834550 * Fix build errors. PiperOrigin-RevId: 293885884 * Fix strings::Escape PiperOrigin-RevId: 293897944 * JSON grammer do not allow trailing commas [1,] {"a":"b",}. Fixes this. Previously trailing commas were considered OK. START_PUBLIC Fix trailing comma in json parser. PiperOrigin-RevId: 294938254 * Internal refactoring. PiperOrigin-RevId: 294983985 * Prettify entities.json PiperOrigin-RevId: 295032659 * Add missing licenses and other clean up. PiperOrigin-RevId: 295033719 * Remove license comment from JSON file PiperOrigin-RevId: 295072895 * Replace base/logging.h with htmlparser/logging.h PiperOrigin-RevId: 295794452 * Added bazel build files for htmlparser. Updated README.md with details on building and testing. PiperOrigin-RevId: 295803731 * Minor bug fixes PiperOrigin-RevId: 295828454 * Fix error: 'cerr' is not a member of 'std' PiperOrigin-RevId: 295828491 * Update json testdata. PiperOrigin-RevId: 295828770 * Update json testfiles. PiperOrigin-RevId: 295829872 * Update json testdata. PiperOrigin-RevId: 295831774 * throw runtime error for unknown namespace. PiperOrigin-RevId: 295835358 * Fix fileutil issue. PiperOrigin-RevId: 295835589 * Fix std::find errors. PiperOrigin-RevId: 295851119 * Fixes compiler warnings of wrong types. PiperOrigin-RevId: 295852676 * Prettify README.md PiperOrigin-RevId: 295889757 * gulp prettify PiperOrigin-RevId: 295890877 * prettify 1.json * prettify 10.json * prettify 2.json * prettify 3.json * prettify 5.json * prettify 6.json * prettify 7.json * prettify 9.json * replace tabs * prettify 8.json * fix json * json formating * json formating * update 7.json * update 8.json * Update README.md Co-authored-by: Amaltas <amaltas@amaltas.org>

view details

CrystalOnScript

commit sha 698c9520be32754ce9b1e047d2a16c33e69a2275

Removed examples from table (#26867) * Removed examples from table Examples are now added automatically during the amp.dev import process. * Removed entire table!!! (#26869)

view details

Gabriel Majoulet

commit sha d56dbf86cd037dd4ffe5ba292791e7686348c631

Replacing onMeasureChange with onLayoutCallback. (#26871)

view details

Alex Ivasyuv

commit sha cbf4ebf1e63ed2d9758dc1a032e5df73ec141a88

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 7 days

push eventMemeGlobal/amphtml

Denys

commit sha e5c32f96d07575c5171fdbf8839e9960a1119959

✨Lentainform uniq ad (#25836) * Support for MGID | Idealmedia | Lentainform ads network * update * test trigger * Support for MGID | Idealmedia | Lentainform ads network * test trigger * Lentainform new improvements * Idealmedia fix * Revert "Idealmedia fix" This reverts commit cbe9046b76908d906f6950b90caec2b9cd4aca8b. * idealmedia fix * Revert "idealmedia fix" This reverts commit 7ea09a7edc8e23cc2f9b4e16789200b98a2323a0. * Idealmedia fix * alentainform. adding uniques widget id * lentainform. adding uniques widget id * lentainform. adding uniques widget id * lentainform. adding uniques widget id

view details

honeybadgerdontcare

commit sha c0454f7095a2a07d99e626b9c320f7b302d8541a

Validator rollup (#26845) * cl/294727468 Revision bump for #26399 * cl/294760377 Revision bump for #26403 * cl/294785564 Revision bump for #26362 * cl/294931948 Allow input type=button. * revert extra pubdate Co-authored-by: Greg Grothaus <ggrothau@gmail.com>

view details

erwin mombay

commit sha 28cc6c6bf6f01bcefd2f36daaa24e3c25fc814f9

Do not append `sourceMappingURL` to map files (#26851) * Do not append `sourceMappingURL` to map files * apply recs

view details

Gabriel Majoulet

commit sha f3b5d77363b8ba04f35f5017214ba0394068d5dc

Fix story page sizing variables. (#26793) * Fix story page sizing variables. * Changing the CSS selector for :root. * Fix tests.

view details

honeybadgerdontcare

commit sha abb47cd24d1b353b9e3a32cf1d424df75f8cfdb0

Sync from Google (#26854) * Internal refactor PiperOrigin-RevId: 289008926 * Internal refactor PiperOrigin-RevId: 289950482 * Revert entities.json * prettify readme * prettify again

view details

Alex Ivasyuv

commit sha fc5228fe2d73c2ca4dbd6d443b67a7c12e6fbd3f

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 8 days

push eventMemeGlobal/amphtml

Esther Kim

commit sha a79838fd03d1f2d653d3216f81ec4490fce4809f

🐛 Add gulp dist flags (#26842)

view details

Alex Ivasyuv

commit sha 2045db0fef5b6a92d39c76b56173dcbfe8da88f9

Merge remote-tracking branch 'remote-origin/master' into amp-trinity-tts-player

view details

push time in 8 days

push eventMemeGlobal/amphtml

Alex Ivasyuv

commit sha c36d2d09561213d0a81197161d9f6f4e0f28ee37

fixed OWNERS lint

view details

push time in 8 days

push eventMemeGlobal/amphtml

Alex Ivasyuv

commit sha 8d0c36231997be4b04b25072647f63c52afd45d1

fixed OWNERS

view details

push time in 8 days

push eventMemeGlobal/amphtml

Alex Ivasyuv

commit sha f1af5cda4ba53fa84b1bb654922651b51ac89d24

fixed parameter name changed spec

view details

push time in 9 days

push eventMemeGlobal/amphtml

Alex Ivasyuv

commit sha 08bd9210f492d0cc36c37a05690e824278073019

added cleanup issue added OWNERS fixed formatting

view details

push time in 9 days

push eventMemeGlobal/amphtml

jyn15

commit sha 307c885707ffd55b9ebb52059b5f6d68e68d022b

🐛Convert arg 'index' to number. (#26533) * Convert arg 'index' to number. * switch to userAssert and add unit tests

view details

Jake Fried

commit sha 49ce3f31671f4aded16d3321190085723f01ca25

♻️ test-performance.js: differentiate between relative and absolute time. (#26568) * test-performance.js: differentiate between relative and absolute time. * lint * slightly clean up two magic numbers

view details

ofirpaBrowsi

commit sha f898521093c21d8c0793f4b76b502bcdbe3ea1b5

✨RTC & Analytics - Adding RTC and Analytics vars (#26266) * Added RTC TOP and pageviewid64 macros * Added elementId to visibility trigger * Added SCROLL_TOP, PAGE_HEIGHT and BKG_STATE vars * Fixed lint issue * Fixed forbidden variable issue * Merged with master * changed EL_TOP to ELEMENT_TOP added RTC tests * changed ELEMENT_TOP to ELEMENT_POS * Updated rtc md file * Simple md change for retry * Simple md change for retry

view details

Vidyome

commit sha 6fbe88595b3833ee10a7556428602a79e84db4d8

temedya.md file (#26520) TE Medya native widget readme file.

view details

Rikard Lundmark

commit sha 4512c3770ea03e54cd102dccb5144e1a0296333f

Removing unused experiment config. (#25908)

view details

Malte Ubl

commit sha be3317aa870a67d4754118105ec3c0f3df327e1c

Use auto instead of 100% as width of story description. (#26571) Otherwise the padding leads to the text going over the edge of the right side of the screen. Fixes #26528

view details

Wassim Gharbi

commit sha e7a8e7f687e5e63a2ecb63566828ec25296a7f96

✨ <amp-next-page> v2 default and templated separator elements (#26413) * Added visual diff tests and better manual tests * Prototyping sticky element handling in amp-next-page * Deprecate amp-next-page-keep in favor of amp-next-page-hidden * Visibility bug fix * Remove animation added for testing * Exported host-page-specific parameters into HostPage * Preventing next-page form building again * Remove visual diff tests * Implement infinite loading for amp-next-page v2 * Implements un-loading and re-loading pages to reduce memory footprint * Added unit tests * Fixes types * Implemented a default separator pill and templating for the separator * Types fix * Fix tests for renaming * Added unit tests for separators * Fix types * Revert renaming and fixes (separate PR) * Suggested changes (1/2) * Suggested changes (2/2)

view details

Alan Orozco

commit sha 0167a143724bea511b98f80af045aef5f27de7fb

🐛 amp-auto-lightbox: Ignore unlaid out elements (#26573) Fixes #25764

view details

Raghu Simha

commit sha 53cb6302d0babf47090f86c355ebdc6646670a9f

🏗 Apply `AMP_CONFIG` to runtime files during `gulp dist` (#26554)

view details

Wassim Gharbi

commit sha 4fe68c28b95efdf7b94da4e757081d4300640b18

✨ Remote loading of pages for <amp-next-page> v2 (#26470) * Implements loading pages from remote urls * Adds unit tests and fixes issues * Fixes types * Requested changes * Add back tests * Fixed linter warning

view details

Dejan Grbavcic

commit sha 5eaa0918726dc883b4e3bb1d334c351ee1aaa970

amp-brid-player: Adding support for time/duration (#24424)

view details

Shihua Zheng

commit sha 72c99b1a21ddb35083d19fed05099e33228c04d5

Set owners for js in src/ for wg-ads and wg-analytics (#26527)

view details

Shihua Zheng

commit sha c680e53db1190f01a06dcfe1df3ad43438ac9037

Resource=>Mutator refactor for access-poool (#26547)

view details

Enrique Marroquin

commit sha b42e5096ddb25fc19a9f282a0542bc14baf8678e

🖍 [amp-story-player] Adds css for pre-fetch experience (#26557) * pre-fetch experience * change default dimensions, friendlier css name * rename css out, move css variable to anchor, use box sizing * add license

view details

Renovate Bot

commit sha 05046f64eb998df627816a2d135cae324fa2be3c

📦 Update dependency chromedriver to v79.0.3

view details

WhiteSource Renovate

commit sha e0500b7511695102c93ac2f6ada96efd33ab73cf

📦 Update dependency commander to v4.1.1 (#26597)

view details

Jonathan Rico

commit sha d6c7bae679ccec497c965f46ee29a1509203df9d

prevent extend String object by colors library (#25879) https://github.com/Marak/colors.js#usage is terrible to extend String because this generate issues in other libraries.

view details

Micajuine Ho

commit sha 83de808e18d71fecf5398019623d806693de8b48

Remove expected error (#26565)

view details

WhiteSource Renovate

commit sha a110d9a6c2bed0e30f04bebe93797d33c5c5296f

📦 Update dependency @percy/agent to v0.21.0 (#26577)

view details

Kevin Kimball

commit sha 653dda32baa494968308691e98f41d2dd16df746

🐛Force scrollTop to be remeasured on shadow doc visibility change (#26588) * Force scrolltop to be remeasured on shadow doc visibility change * Add comment to fix

view details

push time in 9 days

pull request commentampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player extension

@googlebot I signed it!

industral

comment created time in 9 days

PR opened ampproject/amphtml

✨Trinity TTS player amp-trinity-tts-player component

Implemented https://github.com/ampproject/amphtml/issues/26836

+312 -0

0 comment

7 changed files

pr created time in 9 days

issue openedampproject/amphtml

I2I: Trinity Audio Player extension

Summary

Trinity Audio proposes an <amp-trinity-player> component to enable publishers to audiofy their content using our cloud-hosted audio player. To use the component, it is required to have an account with Trinity Audio (there is a free option). Registration is through our site (trinityaudio.ai).

Motivation

Trinity Audio allow textual content creators the option to distribute and interact with their readers using audio. By doing so, it allows users to enjoy the high quality content they are already consuming in times when they couldn't before. As of so, most consumption is done from mobile, and a significant amount of publishers integrated AMP. By adding the Trinity component, it will allow all of those AMP-publishers the ability to (freely) explore how users interact with their content in audio. More so, it improve the accessibility of the content as people who are visually impaired or don't read well can enjoy content they couldn't before.

Since Trinity Player reads content from a page by provided selector (configures it on backoffice dashboard, later will be added ability to rewrite it by parameter, as we already have it in our Javascript version of player), we need somehow pass it to our player. We've tried to achieve that by using amp-iframe, but it's impossible to pass a text as it doesn't support postMessages yet. Also it required complicated setup. Neither approach with amp-state works, due to it will not reflect state update if there were no user interaction upon component.

PR did similar to https://amp.dev/documentation/components/amp-jwplayer/ and https://amp.dev/documentation/components/amp-minute-media-player/ extensions.

/cc @ampproject/wg-approvers

created time in 9 days

PR closed MemeGlobal/amphtml

DON'T MERGE!: Amp trinity tts player

<!--

Instructions:

  • Pick a meaningful title for your pull request. (Use sentence case.)
    • Prefix the title with an emoji to identify what is being done. (Copy-paste the emoji from the list below.)
    • Do not overuse punctuation in the title (like (chore):).
    • If it is helpful, use a simple prefix (like ProjectX: Implement some feature).
  • Enter a succinct description that says why the PR is necessary, and what it does.
    • Mention the GitHub issue that is being addressed by the pull request.
    • The keywords Fixes, Closes, or Resolves followed the issue number will automatically close the issue.

NOTE: All non-trivial changes (like introducing new features or components) should have an associated issue or reference an I2I (intent-to-implement: go.amp.dev/i2i). Please read through the contribution process (go.amp.dev/contributing/code) for more information.

Example of a good description:

  • Implement aspect X
  • Leave out feature Y because of A
  • Improve performance by B
  • Improve accessibility by C

Emojis for categorizing pull requests (copy-paste emoji into description):

✨ New feature 🐛 Bug fix 🔥 P0 fix ✅ Tests 🚀 Performance improvements 🖍 CSS / Styling ♿ Accessibility 🌐 Internationalization 📖 Documentation 🏗 Infrastructure / Tooling / Builds / CI ⏪ Reverting a previous change ♻️ Refactoring 🚮 Deleting code -->

+312 -0

0 comment

7 changed files

industral

pr closed time in 10 days

push eventMemeGlobal/amphtml

Alex Ivasyuv

commit sha d805bac80da2dc4f77d788cc6897f01a92ee9fac

updated campaignId use CDN fixed types

view details

push time in 10 days

Pull request review commentMemeGlobal/amphtml

DON'T MERGE!: Amp trinity tts player

+---+$category@: presentation+formats:+  - websites+  - email+teaser:+  text: Displays a cloud-hosted TTS Trinity Audio Player+---++<!--+Copyright 2020 The AMP HTML Authors. All Rights Reserved.++Licensed under the Apache License, Version 2.0 (the "License");+you may not use this file except in compliance with the License.+You may obtain a copy of the License at++      http://www.apache.org/licenses/LICENSE-2.0++Unless required by applicable law or agreed to in writing, software+distributed under the License is distributed on an "AS-IS" BASIS,+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+See the License for the specific language governing permissions and+limitations under the License.+-->++# amp-trinity-tts-player++<table>+  <tr>+    <td width="40%"><strong>Description</strong></td>+    <td>Displays a cloud-hosted TTS <a href="https://trinityaudio.ai/" target="_blank">Trinity Audio Player</a></td>+  </tr>+  <tr>+    <td width="40%"><strong>Required Script</strong></td>+    <td><code>&lt;script async custom-element="amp-trinity-tts-player" src="https://cdn.ampproject.org/v0/amp-trinity-tts-player-0.1.js">&lt;/script></code></td>+  </tr>+  <tr>+    <td class="col-fourty"><strong><a href="https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/control_layout">Supported Layouts</a></strong></td>+    <td>fixed-height</td>+  </tr>+  <tr>+    <td width="40%"><strong>Examples</strong></td>+    <td><a href="https://amp.dev/documentation/examples/components/amp-trinity-tts-player/">Annotated code example for amp-trinity-tts-player</a></td>+  </tr>+</table>+++## Usage++Player height should be set to `75`, for desktop or mobile.+`campaignId` is required.++```html+<amp-trinity-tts-player+    height="75"

that's required attribute, you can't avoid it

industral

comment created time in 14 days

Pull request review commentMemeGlobal/amphtml

DON'T MERGE!: Amp trinity tts player

+/**+ * Copyright 2020 The AMP HTML Authors. All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS-IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++import {Layout} from '../../../src/layout';+import {isExperimentOn} from '../../../src/experiments';+import {userAssert} from '../../../src/log';++const TAG = 'amp-trinity-tts-player';+const URL = 'https://trinitymedia.ai';++export class AmpTrinityTTSPlayer extends AMP.BaseElement {+  /** @param {!AmpElement} element */+  constructor(element) {+    super(element);++    /** @private {string} */+    this.campaignId_ = '';++    this.isExperimentOn_ = isExperimentOn(this.win, 'amp-trinity-tts-player');+  }++  /** @override */+  buildCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    this.campaignId_ = userAssert(+      this.element.getAttribute('campaignId'),+      'campaignId attribute must be specified for <%s>',+      TAG+    );+  }++  /** @override */+  layoutCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    return new Promise(resolve => {+      this.element.setAttribute('layout', 'fixed-height');++      const iframe = this.getWin().document.createElement('iframe');+      iframe.setAttribute('hidden', true);++      window.addEventListener('message', event => {+        if (event.data.type === 'trinity-player-rendered') {+          resolve();+          iframe.removeAttribute('hidden');+        }+      });++      iframe.addEventListener('load', () => {+        iframe.contentWindow.postMessage(+          {+            type: 'init',+            data: {+              text: this.getWin().document.body.innerHTML,+              campaignId: this.campaignId_,+              pageURL: this.getWin().location.href,+            },+          },+          '*'+        );+      });++      const src = `${URL}/player/trinity-amp`;++      iframe.setAttribute('frameborder', '0');+      iframe.setAttribute('allowfullscreen', 'true');+      iframe.src = src;++      this.applyFillContent(iframe);+      this.element.appendChild(iframe);+    });+  }++  /** @override */+  createPlaceholderCallback() {+    const placeholder = this.getWin().document.createElement('amp-img');+    placeholder.setAttribute('src', `${URL}/player/img/loader.svg`);+    placeholder.setAttribute('height', '75');

I want to add PoC for now, and later on add some params what we're going to support. But for now, at least create PR so they can review

industral

comment created time in 14 days

Pull request review commentMemeGlobal/amphtml

DON'T MERGE!: Amp trinity tts player

+/**+ * Copyright 2020 The AMP HTML Authors. All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS-IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++import {Layout} from '../../../src/layout';+import {isExperimentOn} from '../../../src/experiments';+import {userAssert} from '../../../src/log';++const TAG = 'amp-trinity-tts-player';+const URL = 'https://trinitymedia.ai';++export class AmpTrinityTTSPlayer extends AMP.BaseElement {+  /** @param {!AmpElement} element */+  constructor(element) {+    super(element);++    /** @private {string} */+    this.campaignId_ = '';++    this.isExperimentOn_ = isExperimentOn(this.win, 'amp-trinity-tts-player');+  }++  /** @override */+  buildCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    this.campaignId_ = userAssert(+      this.element.getAttribute('campaignId'),+      'campaignId attribute must be specified for <%s>',+      TAG+    );+  }++  /** @override */+  layoutCallback() {+    userAssert(this.isExperimentOn_, `Experiment ${TAG} is not turned on.`);++    return new Promise(resolve => {+      this.element.setAttribute('layout', 'fixed-height');++      const iframe = this.getWin().document.createElement('iframe');+      iframe.setAttribute('hidden', true);++      window.addEventListener('message', event => {+        if (event.data.type === 'trinity-player-rendered') {+          resolve();+          iframe.removeAttribute('hidden');+        }+      });++      iframe.addEventListener('load', () => {+        iframe.contentWindow.postMessage(+          {+            type: 'init',+            data: {+              text: this.getWin().document.body.innerHTML,+              campaignId: this.campaignId_,+              pageURL: this.getWin().location.href,+            },+          },+          '*'+        );+      });++      const src = `${URL}/player/trinity-amp`;++      iframe.setAttribute('frameborder', '0');+      iframe.setAttribute('allowfullscreen', 'true');+      iframe.src = src;++      this.applyFillContent(iframe);+      this.element.appendChild(iframe);+    });+  }++  /** @override */+  createPlaceholderCallback() {+    const placeholder = this.getWin().document.createElement('amp-img');+    placeholder.setAttribute('src', `${URL}/player/img/loader.svg`);

use bstatic or vd?

industral

comment created time in 14 days

PR opened MemeGlobal/amphtml

Reviewers
DON'T MERGE!: Amp trinity tts player

<!--

Instructions:

  • Pick a meaningful title for your pull request. (Use sentence case.)
    • Prefix the title with an emoji to identify what is being done. (Copy-paste the emoji from the list below.)
    • Do not overuse punctuation in the title (like (chore):).
    • If it is helpful, use a simple prefix (like ProjectX: Implement some feature).
  • Enter a succinct description that says why the PR is necessary, and what it does.
    • Mention the GitHub issue that is being addressed by the pull request.
    • The keywords Fixes, Closes, or Resolves followed the issue number will automatically close the issue.

NOTE: All non-trivial changes (like introducing new features or components) should have an associated issue or reference an I2I (intent-to-implement: go.amp.dev/i2i). Please read through the contribution process (go.amp.dev/contributing/code) for more information.

Example of a good description:

  • Implement aspect X
  • Leave out feature Y because of A
  • Improve performance by B
  • Improve accessibility by C

Emojis for categorizing pull requests (copy-paste emoji into description):

✨ New feature 🐛 Bug fix 🔥 P0 fix ✅ Tests 🚀 Performance improvements 🖍 CSS / Styling ♿ Accessibility 🌐 Internationalization 📖 Documentation 🏗 Infrastructure / Tooling / Builds / CI ⏪ Reverting a previous change ♻️ Refactoring 🚮 Deleting code -->

+331 -0

0 comment

8 changed files

pr created time in 16 days

push eventMemeGlobal/amphtml

Alex Ivasyuv

commit sha d723ef93df84878b1e1d59d2a6cb33530667750c

- added experimental flag - added unit test - added doc

view details

push time in 19 days

create barnchMemeGlobal/amphtml

branch : amp-trinity-tts-player

created branch time in a month

startedtypicode/json-server

started time in 2 months

issue closedvuejs/vue-cli

npm local package dependency not found

Version

4.1.1

Environment info

  System:
    OS: macOS 10.15.1
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.13.2 - /usr/local/bin/npm
  Browsers:
    Chrome: 78.0.3904.108
    Firefox: 70.0.1
    Safari: 13.0.3
  npmPackages:
    @vue/cli-overlay:  3.12.1
    @vue/cli-plugin-typescript: ^3.12.0 => 3.12.1
    @vue/cli-service: ^3.12.0 => 3.12.1
    @vue/cli-shared-utils:  3.12.1
    @vue/component-compiler-utils:  3.0.2
    @vue/preload-webpack-plugin:  1.1.1
    @vue/web-component-wrapper:  1.2.0
    typescript: ^3.6.4 => 3.7.3
    vue: ^2.6.10 => 2.6.10
    vue-class-component: ^7.1.0 => 7.1.0
    vue-hot-reload-api:  2.3.4
    vue-loader:  15.7.2
    vue-property-decorator: ^8.2.2 => 8.3.0
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.10 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
    vuex: ^3.1.1 => 3.1.2
  npmGlobalPackages:
    @vue/cli: 4.1.1

Steps to reproduce

install any local npm package, e.g.

npm i /path/to/your/package

In package.json new package dependency should be created, e.g. "your_package": "../../your_package". In fact in node_modules symlink will be created that will refer to your original local npm package. It creates, and link is OK.

What is expected?

npm run build works

What is actually happening?

Build fail.

...

To install it, you can run: npm install --save ....
ERROR  Build failed with errors.```

<!-- generated by vue-issues. DO NOT REMOVE -->

closed time in 3 months

industral

issue commentvuejs/vue-cli

npm local package dependency not found

OK, finally found issue in package.json itself. main entry was pointed to wrong file.

industral

comment created time in 3 months

issue openedvuejs/vue-cli

npm local package dependency not found

Version

4.1.1

Environment info

  System:
    OS: macOS 10.15.1
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.13.2 - /usr/local/bin/npm
  Browsers:
    Chrome: 78.0.3904.108
    Firefox: 70.0.1
    Safari: 13.0.3
  npmPackages:
    @vue/cli-overlay:  3.12.1
    @vue/cli-plugin-typescript: ^3.12.0 => 3.12.1
    @vue/cli-service: ^3.12.0 => 3.12.1
    @vue/cli-shared-utils:  3.12.1
    @vue/component-compiler-utils:  3.0.2
    @vue/preload-webpack-plugin:  1.1.1
    @vue/web-component-wrapper:  1.2.0
    typescript: ^3.6.4 => 3.7.3
    vue: ^2.6.10 => 2.6.10
    vue-class-component: ^7.1.0 => 7.1.0
    vue-hot-reload-api:  2.3.4
    vue-loader:  15.7.2
    vue-property-decorator: ^8.2.2 => 8.3.0
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.10 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
    vuex: ^3.1.1 => 3.1.2
  npmGlobalPackages:
    @vue/cli: 4.1.1

Steps to reproduce

install any local npm package, e.g.

npm i /path/to/your/package

In package.json new package dependency should be created, e.g. "your_package": "../../your_package". In fact in node_modules symlink will be created that will refer to your original local npm package. It creates, and link is OK.

What is expected?

npm run build works

What is actually happening?

Build fail.

...

To install it, you can run: npm install --save ....
ERROR  Build failed with errors.```

<!-- generated by vue-issues. DO NOT REMOVE -->

created time in 3 months

startedmasumsoft/express-cassandra

started time in 4 months

issue commentwebdriverio/webdriverio

Examples for performActions command

Same here, with Chrome 76 on Browserstack. locally works fine.

sgauruseu

comment created time in 5 months

more