profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ilovezfs/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

haskell/cabal 1287

Official upstream development repository for Cabal and cabal-install

ilovezfs/arq_restore 2

command-line utility for restoring from Arq backups

ilovezfs/formula-patches 1

:hospital: Patches for Homebrew formulae

ilovezfs/android-simg2img 0

Tool to convert Android sparse images to raw images

ilovezfs/aria2 0

aria2 is a lightweight multi-protocol & multi-source, cross platform download utility operated in command-line. It supports HTTP/HTTPS, FTP, SFTP, BitTorrent and Metalink.

ilovezfs/assimp 0

Official Open Asset Import Library Repository. Loads 40+ 3D file formats into one unified and clean data structure.

ilovezfs/audacious-plugins 0

Plugins for Audacious music player

ilovezfs/bazel 0

a fast, scalable, multi-language and extensible build system

ilovezfs/botan 0

Crypto and TLS for C++11

ilovezfs/brew 0

:beer: The missing package manager for OS X

push eventopenzfsonosx/openzfs

ilovezfs

commit sha 8a10b69f2c2f8bf5f8ff7e413d089bd327ce8e09

macOS: fix autoimport script Use absolute path to zsysctl. Ensure that the org.openzfsonosx.zpool-import service is loaded before kickstarting it.

view details

push time in 2 months

PR merged openzfsonosx/openzfs

macOS: fix autoimport script

Use absolute path to zsysctl.

Ensure that the org.openzfsonosx.zpool-import service is loaded before kickstarting it.

+2 -1

0 comment

1 changed file

ilovezfs

pr closed time in 2 months

PR opened openzfsonosx/openzfs

macOS: fix autoimport script

Use absolute path to zsysctl.

Ensure that the org.openzfsonosx.zpool-import service is loaded before kickstarting it.

+2 -1

0 comment

1 changed file

pr created time in 2 months

push eventilovezfs/openzfs

ilovezfs

commit sha 3701f15a496dc6f9f10999210414c5860dbbaa52

macOS: fix autoimport script Use absolute path to zsysctl. Ensure that the org.openzfsonosx.zpool-import service is loaded before kickstarting it.

view details

push time in 2 months

create barnchilovezfs/openzfs

branch : autoimport

created branch time in 2 months

issue commentopenzfsonosx/openzfs

Regression: man pages not in folder recognised by terminal

Odd, since manpath knows about them.

JMoVS

comment created time in 3 months

push eventilovezfs/openzfs

ilovezfs

commit sha ab3de5859f340e5f93606bbac0fff72f8fa41ea8

Upstream: unmount snapshots before destroying them on macOS

view details

Jorgen Lundman

commit sha a0ae744ccf2b344c054d1ec25a884095b0a2bf36

macOS: move sa_setup() to fater zap_lookup() This is the order Linux calls them, so we should minimise differences.

view details

Jorgen Lundman

commit sha 852da0a92fa0047ec5f4814d36851a6d2765f165

macOS: clean up handling of readonly with vfs_mount to follow what upstream does.

view details

Jorgen Lundman

commit sha 9a125c5b27fcd050465cc9b67c82514ae5805101

Upstream: Makefile.am to add zsysctl

view details

Jorgen Lundman

commit sha 78b1e8f00b2cb9efef97b1f1bdf928ce38e94dc6

Upstream: configure.ac add cmd/os/macos/zsysctl

view details

Jorgen Lundman

commit sha fc85db7d2b916a8dda7a1ce74a94a6a0936b4c5b

macOS: add cmd/os/macos/zsysctl

view details

Jorgen Lundman

commit sha b35ccf365255f90c3723e9e7736f1463c52b67d3

macOS: parentID also needs to be mapped to XNU id

view details

Jorgen Lundman

commit sha 19e7244700e95f98cca252f86969b015e78094cc

Upstream: configure.ac changes

view details

Jorgen Lundman

commit sha 2fee08a8eb83fa66a2a36e5f96538dfac6185111

macOS: bring in cmd/os/macos/zsysctl and mount_zfs

view details

Jorgen Lundman

commit sha c090299799c245ff011c836c25c5e8c5e807b57b

Upstream: libzfs.h changes

view details

Jorgen Lundman

commit sha ce1f311bb219a3bf92067fb00f53a3f7493e7805

macOS: Makefile.am for mount_zfs [squash]

view details

Jorgen Lundman

commit sha d5243ae19e1a682da3dac59f52568ad16e6e4324

macOS: squash

view details

Jorgen Lundman

commit sha 9b7fc17f802f3c939b5ffd4b1af945b34aae8203

macOS: strip selinux functions [squash]

view details

Jorgen Lundman

commit sha 28f63cb86be83c9345cf69137571bb88f532e1a3

macOS: userland unmount to disable auto_snapshot to avoid triggering a mount. Also make kernel remember 5 pid+tid to ignore.

view details

Jorgen Lundman

commit sha 7e9edb140ab5a214c40b82d022b603b103a914ff

macOS: Do not truncate returned name in case correcting lookups macOS: also don't truncate further down

view details

ilovezfs

commit sha ddc4024ff35cd5ec6b88f3e2a121b866e90de010

macOS: fix leak in ldi handle_set_wce_iokit The parent device needs to be released if it was retained.

view details

Jorgen Lundman

commit sha 4696d5527d0a9a18dad4a9c3cd23300903fdfdaf

macOS: add zvol_os_is_zvol() Or we are unable to create zpools inside zvols. Also cleanup zvolIO.cpp to be cstyle compliant and correcting obvious leaks.

view details

Jorgen Lundman

commit sha 8963fad0ddb88ee201760117525ce4fef5d564b4

macOS: run zsysctl if /etc/zfs/zsysctl.conf exists

view details

Jorgen Lundman

commit sha a86f2e3cc82fb77acd2320895750a3b95a02ff3e

Upstream: Do not define the enum if props are platform only

view details

Jorgen Lundman

commit sha a1c2e6c7d90a0ec499c5c9a30d9f1aa576ea45b4

macOS: re-implement most of xattrs We had some difference betweem how ZOL and macOS behaved when going between xattr=sa and xattr=on datasets (send/recv) and fairly large duplicate code. Take ZOL zpl_xattr for the sa/on logic, change it to take "uio" for the data buffer. Also pass in "cr" as we can. The finderinfo logic stays in the vnop handlers, leaving the imported source very close to ZOL. Everything with xattrs, and decmpfs needs to be tested :)

view details

push time in 3 months

issue closedopenzfsonosx/openzfs

Trying to create a pool on a zvol gets stuck

On 1.9.4 creating a pool on a zvol works fine.

But in 2.0-rc6 zfs gets stuck

Last login: Mon May  3 16:24:42 on ttys004
joe@joes-Mac ~ % sudo zfs create -V 500M goodbye/myzvol           
Password:
joe@joes-Mac ~ % ls -l /var/run/zfs/zvol/dsk/goodbye/myzvol 
lrwxr-xr-x  1 root  daemon  10 May  3 16:25 /var/run/zfs/zvol/dsk/goodbye/myzvol -> /dev/disk8
joe@joes-Mac ~ % sudo zpool create poolonmyzvol disk8
<command hangs here>

All other zfs commands are impossible at this point, and the system must be rebooted. Spindump attached.

spindump.txt

closed time in 3 months

ilovezfs

issue commentopenzfsonosx/openzfs

Trying to create a pool on a zvol gets stuck

Fixed by https://github.com/openzfsonosx/openzfs/commit/4696d5527d0a9a18dad4a9c3cd23300903fdfdaf

ilovezfs

comment created time in 3 months

issue closedopenzfsonosx/openzfs

zfs send output sometimes incorrect

10:42 PM <ilovezfs_> lundman: it looks like zfs send -p is acting up 10:42 PM <ilovezfs_> joes-Mac:~ root# echo moo > /Volumes/foo/hello 10:42 PM <ilovezfs_> joes-Mac:~ root# zfs snapshot foo@s0 10:42 PM <ilovezfs_> joes-Mac:~ root# zfs send -p foo@s0 > A 10:42 PM <ilovezfs_> joes-Mac:~ root# zfs send -p foo@s0 | tee B > /dev/null 10:42 PM <ilovezfs_> joes-Mac:~ root# ls -l A B 10:42 PM <ilovezfs_> -rw-r--r-- 1 root wheel 1408 May 28 22:40 A 10:42 PM <ilovezfs_> -rw-r--r-- 1 root wheel 2736032 May 28 22:41 B 10:44 PM <ilovezfs_> and tests/functional/cli_root/zfs_send/zfs_send-b.ksh is also struggling 10:48 PM <ilovezfs_> e.g. it can fail with 10:48 PM <ilovezfs_> ERROR: eval zfs send -bcew testpool/backup@s1 | zfs recv testpool/restore exited 1 10:48 PM <ilovezfs_> cannot receive new filesystem stream: incomplete stream 10:50 PM <ilovezfs_> and 10:50 PM <ilovezfs_> ERROR: eval zfs send -p testpool/sendfs@s1 | zfs recv testpool/backup exited 1 10:50 PM <ilovezfs_> cannot receive new filesystem stream: incomplete stream 11:10 PM <ilovezfs_> lundman: also problems with send in the test large_dnode_005_pos 11:10 PM <ilovezfs_> ERROR: eval zfs recv testpool/recv_large_dnode < /private/var/tmp/testdir/ldnsnap exited 1 11:10 PM <ilovezfs_> cannot receive: invalid stream (bad magic number)

closed time in 3 months

ilovezfs

issue commentopenzfsonosx/openzfs

zfs send output sometimes incorrect

This was fixed by recent send commits.

ilovezfs

comment created time in 3 months

issue closedopenzfsonosx/openzfs

Non-root snapshot amnesia

joe@joes-Mac ~ % cd /Volumes/testpool/testfs/.zfs/snapshot
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % stat .
838860822 281474976710653 dr-xr-xr-x 0 root wheel 838860822 0 "Jun  5 04:34:54 2021" "Jun  5 04:34:54 2021" "Jun  5 04:34:54 2021" "Jun  5 04:34:54 2021" 512 1 0 .
joe@joes-Mac snapshot % ls    
.
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % stat .
838860822 281474976710653 dr-xr-xr-x 0 root wheel 838860822 0 "Jun  5 04:34:54 2021" "Jun  5 04:34:54 2021" "Jun  5 04:34:54 2021" "Jun  5 04:34:54 2021" 512 1 0 .
joe@joes-Mac snapshot % ls    
.
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % touch foo
touch: foo: Permission denied
joe@joes-Mac snapshot % ls       
snap
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % sudo touch foo
touch: foo: Operation not supported
joe@joes-Mac snapshot % ls
.
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % touch foo
touch: foo: Permission denied
joe@joes-Mac snapshot % ls       
snap
joe@joes-Mac snapshot % sudo touch foo
touch: foo: Operation not supported
joe@joes-Mac snapshot % sudo ls       
snap
joe@joes-Mac snapshot % sudo touch foo
touch: foo: Operation not supported
joe@joes-Mac snapshot % ls
.
joe@joes-Mac snapshot % touch foo
touch: foo: Permission denied
joe@joes-Mac snapshot % sudo ls       
snap
joe@joes-Mac snapshot % file .
.: directory
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % sudo file .
.: directory
joe@joes-Mac snapshot % ls         
.
joe@joes-Mac snapshot % ls
snap
joe@joes-Mac snapshot % 

closed time in 3 months

ilovezfs

issue commentopenzfsonosx/openzfs

Non-root snapshot amnesia

This was fixed by recent changes to the snapshot code.

ilovezfs

comment created time in 3 months

issue closedopenzfsonosx/openzfs

realpath returns incorrect results for hardlinked files

It works okay on APFS and HFS, so I guess it's an ZFS specific issue. Steps to reproduce:

#/usr/bin/env zsh

clang realpath.c -o realpath

mkdir -p broken

touch file
ln file broken/copy

# for some reason without the mv everything works ok
mv broken/copy broken/link

./realpath broken/link
# /Volumes/media/build/broken/link

# might need to adjust this:
sleep 2s

./realpath broken/link
# /Volumes/media/build/broken/file

/usr/bin/stat -f "%N: %HT%SY" broken/link $(./realpath broken/link)
# broken/link: Regular File
# stat: /Volumes/media/build/broken/file: stat: No such file or directory
// realpath.c
#include <stdio.h>
#include <stdlib.h>
#include <sys/attr.h>

int main(int argc, char **argv) {
    char path[PATH_MAX];

    for (int i = 1; i < argc; i++) {
        if (realpath(argv[i], path)) {
            printf("%s\n", path);
        } else {
            printf("bad path: %s\n", argv[i]);
        }
    }

    return 0;
}

Now, I don't care about this realpath.c as I can use the one from coreutils which works correctly, but rust / cargo uses libc with the broken realpath and as the result can't build some crates due to incorrect paths to existing files.

Looking at the implementation of realpath, I see it saves the path to directory of the file and then uses getattrlist to replace filename, except getattrlist returns the filename of the original hardlinked file, i.e. /Volumes/media/build/file:

...
		/*
		 * Save resolved_len, so that we can later null out
		 * the the appended next_token, and replace with the
		 * real name (matters on case-insensitive filesystems).
		 */
		save_resolved_len = resolved_len;
...
		if (getattrlist(resolved, (void *)&_rp_alist, &attrs, sizeof(attrs), FSOPT_NOFOLLOW) == 0) {
...
			/*
			 * attrs already has the real name.
			 */
			// resolved: ./broken/link
			resolved[save_resolved_len] = '\0';
                         // resolved: ./broken/
			resolved_len = strlcat(resolved, (const char *)&attrs.name + attrs.name.attr_dataoffset, PATH_MAX);
                        // resolved: ./broken/file

Other info that might be relevant:

zfs-macOS-2.0.1-1
zfs-kmod-2.0.1-1

macOS 10.15.7 (19H1030)
Darwin mars.local 19.6.0 Darwin Kernel Version 19.6.0: Mon Apr 12 20:57:45 PDT 2021; root:xnu-6153.141.28.1~1/RELEASE_X86_64 x86_64 i386 Macmini6,2 Darwin

Apple clang version 12.0.0 (clang-1200.0.32.29)

closed time in 3 months

anongit

issue commentopenzfsonosx/openzfs

realpath returns incorrect results for hardlinked files

The fix itself triggered a different bug, which is now fixed https://github.com/openzfsonosx/openzfs/commit/7e9edb140ab5a214c40b82d022b603b103a914ff

anongit

comment created time in 3 months

PR opened openzfsonosx/openzfs

macOS: fix leak in ldi handle_set_wce_iokit

The parent device needs to be released if it was retained.

+3 -0

0 comment

1 changed file

pr created time in 3 months

push eventilovezfs/openzfs

ilovezfs

commit sha a72f85783516a0ebda5e693e992703f3b247e5e1

macOS: fix leak in ldi handle_set_wce_iokit The parent device needs to be released if it was retained.

view details

push time in 3 months

create barnchilovezfs/openzfs

branch : fix-ldi-leak

created branch time in 3 months

CommitCommentEvent