profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ifreund/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

ifreund/river 934

A dynamic tiling Wayland compositor

coilhq/tigerbeetle 303

A distributed financial accounting database designed for mission critical safety and performance to power the future of financial services.

giann/buzz 18

👨‍🚀 buzz, A small/lightweight typed scripting language

ifreund/dotfiles 15

My configuration for void linux and river

coilhq/tigerbeetle-node 6

TigerBeetle Node.js client

ifreund/ltoplevels 1

use wlr-foreign-toplevel-management to list toplevel info

clarksdalehabitat/clarksdalehabitat.github.io 0

Website for Clarksdale Area Habitat for Humanity

coilhq/tigerbeetle.dev 0

Code behind the TigerBeetle website

ifreund/aoc2018 0

Advent of Code 2018 in Janet

IssuesEvent

issue commentifreund/river

No mouse input on Steam when display is not at 0,0

Indeed, it seems that a3fdb294b311216bec388f97a52148ff8e1155cd has not affected this issue and my testing was insufficient.

What I've found is that if steam is started on an output at 0,0 mouse input will work properly, even if steam is moved to an output not at 0,0.

However, if started on an output not at 0,0, mouse input will never work properly even if moved to an output at 0,0.

This is pretty weird.

dgbuckley

comment created time in 20 minutes

push eventifreund/river

Isaac Freund

commit sha 6616d323530167737ba8a0807cbaa49d832c135e

ci: fix xbps invocation This avoids errors like: util-linux-common-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' util-linux-common-2.37.2_1 in transaction breaks installed pkg `libsmartcols-2.37.1_1' libuuid-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' libuuid-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' libblkid-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' libblkid-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' libmount-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' Transaction aborted due to unresolved dependencies.

view details

push time in 6 hours

delete branch ifreund/river

delete branch : ci-fix

delete time in 6 hours

PR merged ifreund/river

ci: try to fix
+6 -6

0 comment

1 changed file

ifreund

pr closed time in 6 hours

push eventifreund/river

Isaac Freund

commit sha fcaaa8be4613139498ecdeb71cf452f40db579d2

ci: fix xbps invocation This avoids errors like: util-linux-common-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' util-linux-common-2.37.2_1 in transaction breaks installed pkg `libsmartcols-2.37.1_1' libuuid-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' libuuid-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' libblkid-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' libblkid-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' libmount-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' Transaction aborted due to unresolved dependencies.

view details

push time in 6 hours

PR opened ifreund/river

ci: try to fix
+3 -3

0 comment

1 changed file

pr created time in 6 hours

create barnchifreund/river

branch : ci-fix

created branch time in 6 hours

issue commentifreund/river

Unable to launch river via the tty

To be clear, wlroots 0.14.1 and zig 0.8.1 would work fine as well. Are you certain that you initialized the git submodules with git submodule update --init? Do you have pkg-config and wayland-protocols installed?

Since you are on arch, does the AUR package compile successfully? That would rule out any missing dependencies...

idontknowwhatimdoing

comment created time in 6 hours

issue closedifreund/river

No mouse input on Steam when display is not at 0,0

To reproduce:

  • Have any connected displays not at 0,0 (My 3 are at 1530,0 / 0,700 / 1080,1080)
  • Open steam and try to click anywhere

If I move a monitor to 0,0 then input works on that monitor. This was also tested on a single output laptop with the same results.

closed time in 6 hours

dgbuckley

issue commentifreund/river

No mouse input on Steam when display is not at 0,0

This seems to be fixed by a3fdb294b311216bec388f97a52148ff8e1155cd, don't ask me why :D

dgbuckley

comment created time in 6 hours

push eventifreund/river

Isaac Freund

commit sha a3fdb294b311216bec388f97a52148ff8e1155cd

Cursor: implement surfaceAt() for XwaylandUnmanaged

view details

push time in 6 hours

PR closed swaywm/wlroots

Rename wlr_surface_get_extends() to wlr_surface_get_extents() surface breaking

Extend (verb): cause to cover a wider area; make larger.

+3 -3

4 comments

3 changed files

vyivel

pr closed time in 9 hours

pull request commentswaywm/wlroots

Rename wlr_surface_get_extends() to wlr_surface_get_extents()

Good find, I've cherry picked this commit over to #2434, if we decide these kinds of breaking changes are worth it, it's better to do them all at once.

vyivel

comment created time in 9 hours

push eventifreund/wlroots

Kirill Primak

commit sha b72a217fcc9f8bb47788c2068093579ac893301c

xdg-toplevel: refactor configure/state flow Previously, `wlr_xdg_toplevel` didn't follow the usual "current state + pending state" pattern and instead had confusingly named `client_pending` and `server_pending`. This commit removes them, and instead introduces `wlr_xdg_toplevel.scheduled` to store the properties that are yet to be sent to a client, and `wlr_xdg_toplevel.requested` to store the properties that a client has requested. They have different types to emphasize that they aren't actual states.

view details

Kirill Primak

commit sha 0e2d36910612b849ca9c4868910b308c4bf49213

xdg-surface: simplify configure mechanism This commit removes any checks whether a configure will change anything and makes configures be sent unconditionally. Additionally, configures are scheduled on xdg_toplevel.{un,}set_{maximized,fullscreen} events.

view details

Kirill Primak

commit sha ccc84f11a4a039c89ad20111805c051c000ff7f7

xdg surface: check adding configure_idle for NULL

view details

Simon Ser

commit sha 211b3b760ebc518badc1dfed28aaca0b5f0b0175

scene: add wlr_scene_tree

view details

Simon Ser

commit sha 597ba2b932e8d35fc746cc0e5e6c31742d12d71f

surface: add addon set

view details

Simon Ser

commit sha 2e590026e9ea0d556bb9f6b06ca21dfb9244aec8

scene: add wlr_scene_subsurface_tree_create

view details

Simon Ser

commit sha 0c5ff5efabac281065962538ec61431b6ce5c51d

build: simplify get_variable calls With recent-ish Meson we can stop repeating the variable name for each provider.

view details

Simon Ser

commit sha 2e12de96ca988f9b8ee51789e70542c24bab8844

backend/drm: add support for panel orientation Expose the panel orientation with wlr_drm_connector_get_panel_orientation. Leave it to the compositor to consume this information and configure the output accordingly. Closes: https://github.com/swaywm/wlroots/issues/1581

view details

Tadeo Kondrak

commit sha e0daa65aa6824607cad717d8d04b4508faaf6397

input-method-unstable-v2: Add error for surface with existing role

view details

Tadeo Kondrak

commit sha 30d3c768174c40fc914d1057403c50072cbef3e4

Implement input_method_v2 popups

view details

Simon Ser

commit sha b25759cd20262f59e6144b00e9bc9d132549cc94

scene: drop default case in wlr_scene_node_at This allows the compiler to error out if we haven't enumerated all of the cases. This is useful to avoid a missing implementation when adding a new node type.

view details

Simon Ser

commit sha f6f0e010d182e5a24b7e540fcc0567ebcafcca24

scene: unify intersection logic in wlr_scene_node_at Let's extract the common bits.

view details

Simon Ser

commit sha 7939bf8cc6b81d5bbd11da08b905eea1bba81ce3

scene: add wlr_scene_buffer This new scene-graph node displays a wlr_buffer. Closes: https://github.com/swaywm/wlroots/issues/3161

view details

Simon Ser

commit sha fdc22449d6f7ac38388812d7f0da7c93e110d28a

util/box: introduce wlr_fbox_empty Same as wlr_box_empty, but for wlr_fbox.

view details

Simon Ser

commit sha 63040d67448ad710fb3536b86d0e417b06783079

scene: add wlr_scene_buffer_set_source_box

view details

Simon Ser

commit sha 27b529f8a0a594a9933dbbaa81bd1167f791e4f9

scene: add scene_node_get_size helper

view details

Simon Ser

commit sha 3d4afbe9455a049b01a981ca10868cc6411827cc

scene: use scene_node_get_size in wlr_scene_node_at This allows to unify the RECT and BUFFER code-paths. The BUFFER one will become more complicated with destination size and transforms.

view details

Simon Ser

commit sha 43833fba642bd7c63c6010965f1009a72dbe3e74

scene: add wlr_scene_buffer_set_dest_size

view details

Simon Ser

commit sha 3c26244340fe09fb99368a1c2326335db86fbf5f

scene: add wlr_scene_buffer_set_transform

view details

Kirill Primak

commit sha 59fa3637c348270cd1adb239296be1219538394b

layer-shell: refactor configure/state flow Same logic as xdg-toplevel.

view details

push time in 9 hours

Pull request review commentziglang/zig

deflate.zig: fix bits_left overflow at EndOfStream and @intCast truncation with empty Huffman table

 test "lengths overflow" {     // f dy  hlit hdist hclen 16  17  18   0 (18)    x138 (18)    x138 (18)     x39 (16) x6     // 1 10 11101 11101 0000 010 010 010 010 (11) 1111111 (11) 1111111 (11) 0011100 (01) 11     const stream = [_]u8{ 0b11101101, 0b00011101, 0b00100100, 0b11101001, 0b11111111, 0b11111111, 0b00111001, 0b00001110 };+    try std.testing.expectError(error.InvalidLength, testInflate(stream[0..]));+} -    const reader = std.io.fixedBufferStream(&stream).reader();-    var window: [0x8000]u8 = undefined;-    var inflate = inflateStream(reader, &window);+test "empty distance alphabet" {+    // dynamic block with empty distance alphabet is valid if end of data symbol is used immediately+    // f dy  hlit hdist hclen 16  17  18   0   8   7   9   6  10   5  11   4  12   3  13   2  14   1  15 (18)    x128 (18)    x128 (1)  ( 0) (256)+    // 1 10 00000 00000 1111 000 000 010 010 000 000 000 000 000 000 000 000 000 000 000 000 000 001 000 (11) 1110101 (11) 1110101 (0)  (10)  (0)+    const stream = [_]u8 { 0b00000101, 0b11100000, 0b00000001, 0b00001001, 0b00000000, 0b00000000, 0b00000000, 0b00000000, 0b00010000, 0b01011100, 0b10111111, 0b00101110 };

No worries! this is why we have the CI check :)

mattbork

comment created time in 9 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentziglang/zig

deflate.zig: fix bits_left overflow at EndOfStream and @intCast truncation with empty Huffman table

 test "lengths overflow" {     // f dy  hlit hdist hclen 16  17  18   0 (18)    x138 (18)    x138 (18)     x39 (16) x6     // 1 10 11101 11101 0000 010 010 010 010 (11) 1111111 (11) 1111111 (11) 0011100 (01) 11     const stream = [_]u8{ 0b11101101, 0b00011101, 0b00100100, 0b11101001, 0b11111111, 0b11111111, 0b00111001, 0b00001110 };+    try std.testing.expectError(error.InvalidLength, testInflate(stream[0..]));+} -    const reader = std.io.fixedBufferStream(&stream).reader();-    var window: [0x8000]u8 = undefined;-    var inflate = inflateStream(reader, &window);+test "empty distance alphabet" {+    // dynamic block with empty distance alphabet is valid if end of data symbol is used immediately+    // f dy  hlit hdist hclen 16  17  18   0   8   7   9   6  10   5  11   4  12   3  13   2  14   1  15 (18)    x128 (18)    x128 (1)  ( 0) (256)+    // 1 10 00000 00000 1111 000 000 010 010 000 000 000 000 000 000 000 000 000 000 000 000 000 001 000 (11) 1110101 (11) 1110101 (0)  (10)  (0)+    const stream = [_]u8 { 0b00000101, 0b11100000, 0b00000001, 0b00001001, 0b00000000, 0b00000000, 0b00000000, 0b00000000, 0b00010000, 0b01011100, 0b10111111, 0b00101110 };

I believe the zig fmt CI check is failing due to the extra space here, could you run zig fmt locally and push the changes?

    const stream = [_]u8{ 0b00000101, 0b11100000, 0b00000001, 0b00001001, 0b00000000, 0b00000000, 0b00000000, 0b00000000, 0b00010000, 0b01011100, 0b10111111, 0b00101110 };
mattbork

comment created time in 13 hours

issue commentifreund/river

Views doesn't respect screen limit and paddings

We do have the option of cropping views that extend past the bounds river wants to those bounds. This may make some programs unusable though.

mfxarc

comment created time in 13 hours

Pull request review commentgithub/gitignore

Add gitignore support for the Zig programming language

+# Language: Zig (https://ziglang.org/)+# Source: https://github.com/ziglang/zig/blob/master/.gitignore (modified)++**/zig-cache/+**/build/+**/build-*/+**/docgen_tmp/

None of these belong in a generic zig gitignore template, they are cmake/c++ related. Only zig-cache and zig-out should be included.

timmyjose

comment created time in 13 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue commentifreund/river

Unable to launch river via the tty

I'd recommend you try building from source or using the AUR package instead of nix, I suspect that's what's causing you problems.

idontknowwhatimdoing

comment created time in a day

startedgiann/buzz

started time in 3 days

issue closedziglang/zig

std.debug.leb128: Implement functions capable of writing LEB128 to some form of output

While the leb128.zig file implements and provides functionality to read/parse/decode LEB128s, the file should also implement/provide functionality to write/encode LEB128s (into a buffer or stream).

Use Case

A simple but well known use case would be when dealing with Minecraft's protocol due to the fact it generally utilizing VarInts/VarLongs (LEB128) for numeric values.

closed time in 3 days

eltraywastaken

issue commentifreund/river

Dialog box does not reappear in QT XWayland application

I wonder if this has the same root cause as #436

ecocode

comment created time in 3 days

issue commentswaywm/wlroots

Swaybg spinning up CPU

I would call this a sway bug. Sway currently sends a configure to all layer surfaces on every layer surface commit even if nothing has changed: https://github.com/swaywm/sway/blob/b7b3ef6dcf904fce8ff072a88e505765a44a4ec6/sway/desktop/layer_shell.c#L303

59fa3637c348270cd1adb239296be1219538394b removed the wlroots logic that caused wlr_layer_surface_v1_configure() to not actually send a configure if wlroots could detect that the provided width/height match the last configure sent. The reason this logic was removed is because compositors using the configure serial to returned by wlr_layer_surface_v1_configure() for any purpose would have no way to know if the serial had already been ack'ed be the client at the time of the wlr_layer_surface_v1_configure() call or not.

The fix for sway would be to skip the arrange_layers() call linked if nothing about the layer surface's state has changed.

River does this here: https://github.com/ifreund/river/blob/b8ebbc29cf42a36e97666bf9757a9bc354e31925/river/LayerSurface.zig#L157

Wayfire does this here: https://github.com/WayfireWM/wayfire/blob/5754aeb9765617e0eb296cac5303aaa82f69257e/src/view/layer-shell.cpp#L479

J0nnyMak0

comment created time in 4 days