profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ifesdjeen/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

ifesdjeen/cascading-cassandra 45

Modern Cassandra tap for Cascading. Actually works with Cascading 2.0, Cascalog 1.10 and supports CQL collections.

ifesdjeen/continuum 18

Blazing Fast Time Series Database for ad-hoc queries

ifesdjeen/blomstre 14

Concurrent Bloom Filter

ifesdjeen/cascading-mongodb 8

Modern Mongodb tap for Cascading. Actually works with Cascading 2.0 and Cascalog 1.10.

ifesdjeen/awesome-consensus 6

Awesome list for Paxos and friends

ifesdjeen/binaer 4

Utility for composing flexible binary protocol parsers

ifesdjeen/cassandra-harry 3

Apache Cassandra - Harry

ifesdjeen/collectd-haskell 3

Haskell Bindings for Collectd. When you don't feel Python is hip enough for you.

ifesdjeen/awesome-machine-learning 2

A curated list of awesome Machine Learning frameworks, libraries and software.

ifesdjeen/bbaum 2

Adaptable On-Disk B+Tree implementation

PullRequestReviewEvent

Pull request review commentapache/cassandra-dtest

Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…

 def create_c1c2_table(tester, session, read_repair=None):     create_cf(session, 'cf', columns={'c1': 'text', 'c2': 'text'}, read_repair=read_repair)  -def insert_c1c2(session, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):+def insert_c1c2(session, ks=None, keys=None, n=None, consistency=ConsistencyLevel.QUORUM):     if (keys is None and n is None) or (keys is not None and n is not None):         raise ValueError("Expected exactly one of 'keys' or 'n' arguments to not be None; "                          "got keys={keys}, n={n}".format(keys=keys, n=n))     if n:         keys = list(range(n)) -    statement = session.prepare("INSERT INTO cf (key, c1, c2) VALUES (?, 'value1', 'value2')")+    fully_qualified_cf = "cf"+    if ((ks is not None) and (not ks)):

You're right, it should've been a double negation!

ifesdjeen

comment created time in 4 days

push eventifesdjeen/cassandra-dtest

Alex Petrov

commit sha eec44e6a185cb1d0f9e6a4ebd811ee7ff9c91f36

Fix syntax

view details

push time in 4 days

push eventifesdjeen/cassandra-dtest

Alex Petrov

commit sha 06812b602d227bc90dba59ce914663e995f0a35c

Fix syntax

view details

push time in 4 days

PR opened apache/cassandra-dtest

Fix flaky test: repair_tests/repair_test.py::TestRepair::test_local_d…

…c_repair

Patch by Alex Petrov; reviewed by TBD for CASSANDRA-16963

+11 -8

0 comment

2 changed files

pr created time in 4 days

create barnchifesdjeen/cassandra-dtest

branch : CASSANDRA-16963

created branch time in 4 days

push eventifesdjeen/cassandra

Andrés de la Peña

commit sha a9abccb28b220f02e6d7628dffdb4678a399820c

Fix flaky SSTableExportTest to run first the tests calling assertSchemaNotLoaded patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova and Berenguer Blasi for CASSANDRA-16818

view details

Ekaterina Dimitrova

commit sha ca6bb2af02dc21a2625840985551003c9d2e2a5c

Resolve ant-junit dependency issue CASSANDRA-16827 patch by Ekaterina Dimitrova; reviewed by Michael Semb Wever for CASSANDRA-16827

view details

Ekaterina Dimitrova

commit sha 112513c72d9af89b27bb97384aa85eaa9dbe49fc

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

David Capwell

commit sha 979ab72f4f2afe4a23654572cd804184fc0e2089

ArrayClustering.unsharedHeapSize does not include the data so undercounts the heap size patch by David Capwell; reviewed by Blake Eggleston for CASSANDRA-16845

view details

Bereng

commit sha 99e1fcc251bd498abab17a59a9fc9593d242671b

Materialized views incorrect quoting of UDF patch by Andres de la Peña, Jakub Zytka, Berenguer Blasi; reviewed by Andres de la Peña, Jakub Zytka for CASSANDRA-16836 Co-authored-by: Andres de la Peña <a.penya.garcia@gmail.com> Co-authored-by: Jakub Zytka <jakub.zytka@datastax.com> Co-authored-by: Berenguer Blasi <berenguerblasi@gmail.com>

view details

Bereng

commit sha f242ccbedd1e236b2288ea8158582eb05f623b03

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

Stefan Miklosovic

commit sha ad139da84c600c294e00263bd2c48b40aea2c2cc

fix incorrect error message in LegacyLayout

view details

Stefan Miklosovic

commit sha 0f836cc4b4c9c9281e365f271d5a689b94f9ef04

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

Stefan Miklosovic

commit sha f194d1a2ade093ed61b212bb85a234aa9f20f8be

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

Andrés de la Peña

commit sha 07706662104fd7d471379a5ba1155c7e4fb71618

Build tests in CircleCI build job patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16852

view details

Andrés de la Peña

commit sha 1482ead465a651f6ed7d694f081a128613d2dfd0

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

Andrés de la Peña

commit sha 5f755e608a6c987042b6d92f148c9b18fc91caa5

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

Andrés de la Peña

commit sha ce21eb5fac385098b7ed19c77167a38b5dee230a

Add tests for the Hint service metrics patch by Andrés de la Peña; reviewed by Benjamin Lerer for CASSANDRA-16189

view details

Andrés de la Peña

commit sha 770dee5a57da96696b3df64384326786c0506762

Regenerate CircleCI's MIDRES config file patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16858

view details

Andrés de la Peña

commit sha af6654cb062331ac4fd344c559afd36f524a9baf

Merge branch 'cassandra-3.11' into cassandra-4.0 # Conflicts: # .circleci/config.yml.MIDRES

view details

Sylvain Lebresne

commit sha e581a85b93acff0fecef7d41d9a94a2f89f810ba

Fixup scrub output when no data post-scrub and clear up old use of row, which really means partition patch by Ekaterina Dimitrova; reviewed by Brandon Williams for CASSANDRA-16835 Co-authored-by: Sylvain Lebresne <lebresne@gmail.com> Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>

view details

Ekaterina Dimitrova

commit sha cb19b39827f1175f8b284a4aab01f47ec160ed7e

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

arunkumar-m

commit sha 632790fd51ae9017fb0de16dbc25b739548ba54c

Remove possible infinite loop in NIODataInputStreamTest patch by arunkumar-m; reviewed by Joel Knighton and Benjamin Lerer for CASSANDRA-12660

view details

Benjamin Lerer

commit sha 6eb02a291dbb1d2415244f675167d3ac8c7ed60d

Merge branch cassandra-3.0 into cassandra-3.11

view details

Benjamin Lerer

commit sha 433274baea3642466176b64216dfad17dd6b54e2

Merge branch cassandra-3.11 into cassandra-4.0

view details

push time in 4 days

push eventifesdjeen/cassandra

Andrés de la Peña

commit sha a9abccb28b220f02e6d7628dffdb4678a399820c

Fix flaky SSTableExportTest to run first the tests calling assertSchemaNotLoaded patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova and Berenguer Blasi for CASSANDRA-16818

view details

Andrés de la Peña

commit sha b26a4daf8624f77279b8a98df6fdc7094b6b6da2

Merge branch 'cassandra-4.0' into trunk

view details

Ekaterina Dimitrova

commit sha ca6bb2af02dc21a2625840985551003c9d2e2a5c

Resolve ant-junit dependency issue CASSANDRA-16827 patch by Ekaterina Dimitrova; reviewed by Michael Semb Wever for CASSANDRA-16827

view details

Ekaterina Dimitrova

commit sha 112513c72d9af89b27bb97384aa85eaa9dbe49fc

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

Ekaterina Dimitrova

commit sha cd36926577729a0ba7e9d710b1dc92a117e5feab

Merge branch 'cassandra-4.0' into trunk

view details

Caleb Rackliffe

commit sha 6a1b20e58d493925439cc9a67bc6b51bb0be631a

Modify SecondaryIndexManager#indexPartition() to retrieve only columns for which indexes are actually being built patch by Caleb Rackliffe and Sam Tunnicliffe; reviewed by Benedict Elliott Smith and Aleksei Zotov for CASSANDRA-16776

view details

Yifan Cai

commit sha 8acbbe042b236c6948845ecd7af093c6f0fa3e4b

Background schedule to clean up orphaned hints files patch by Yifan Cai; reviewed by Brandon Williams, Chris Lohfink for CASSANDRA-16815

view details

David Capwell

commit sha 979ab72f4f2afe4a23654572cd804184fc0e2089

ArrayClustering.unsharedHeapSize does not include the data so undercounts the heap size patch by David Capwell; reviewed by Blake Eggleston for CASSANDRA-16845

view details

David Capwell

commit sha 39af4a54903267656aa3bbefaf30adfc67974919

Merge branch 'cassandra-4.0' into trunk

view details

Bereng

commit sha 99e1fcc251bd498abab17a59a9fc9593d242671b

Materialized views incorrect quoting of UDF patch by Andres de la Peña, Jakub Zytka, Berenguer Blasi; reviewed by Andres de la Peña, Jakub Zytka for CASSANDRA-16836 Co-authored-by: Andres de la Peña <a.penya.garcia@gmail.com> Co-authored-by: Jakub Zytka <jakub.zytka@datastax.com> Co-authored-by: Berenguer Blasi <berenguerblasi@gmail.com>

view details

Bereng

commit sha f242ccbedd1e236b2288ea8158582eb05f623b03

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

Bereng

commit sha 913d541ee9b9a636c02397f9fd3123e023d5c941

Merge branch 'cassandra-4.0' into trunk

view details

Stefan Miklosovic

commit sha ad139da84c600c294e00263bd2c48b40aea2c2cc

fix incorrect error message in LegacyLayout

view details

Stefan Miklosovic

commit sha 0f836cc4b4c9c9281e365f271d5a689b94f9ef04

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

Stefan Miklosovic

commit sha f194d1a2ade093ed61b212bb85a234aa9f20f8be

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

Stefan Miklosovic

commit sha 42f6f7ada600181fcb83aee6b3ccf470a823b07a

Merge branch 'cassandra-4.0' into trunk

view details

Andrés de la Peña

commit sha 07706662104fd7d471379a5ba1155c7e4fb71618

Build tests in CircleCI build job patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16852

view details

Andrés de la Peña

commit sha 1482ead465a651f6ed7d694f081a128613d2dfd0

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

Andrés de la Peña

commit sha 5f755e608a6c987042b6d92f148c9b18fc91caa5

Merge branch 'cassandra-3.11' into cassandra-4.0

view details

Andrés de la Peña

commit sha 76f1a64658f32dc933449a959f1c48d1d2919683

Merge branch 'cassandra-4.0' into trunk

view details

push time in 4 days

push eventifesdjeen/cassandra

Ekaterina Dimitrova

commit sha ca6bb2af02dc21a2625840985551003c9d2e2a5c

Resolve ant-junit dependency issue CASSANDRA-16827 patch by Ekaterina Dimitrova; reviewed by Michael Semb Wever for CASSANDRA-16827

view details

Bereng

commit sha 99e1fcc251bd498abab17a59a9fc9593d242671b

Materialized views incorrect quoting of UDF patch by Andres de la Peña, Jakub Zytka, Berenguer Blasi; reviewed by Andres de la Peña, Jakub Zytka for CASSANDRA-16836 Co-authored-by: Andres de la Peña <a.penya.garcia@gmail.com> Co-authored-by: Jakub Zytka <jakub.zytka@datastax.com> Co-authored-by: Berenguer Blasi <berenguerblasi@gmail.com>

view details

Stefan Miklosovic

commit sha ad139da84c600c294e00263bd2c48b40aea2c2cc

fix incorrect error message in LegacyLayout

view details

Stefan Miklosovic

commit sha 0f836cc4b4c9c9281e365f271d5a689b94f9ef04

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

Andrés de la Peña

commit sha 07706662104fd7d471379a5ba1155c7e4fb71618

Build tests in CircleCI build job patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16852

view details

Andrés de la Peña

commit sha 1482ead465a651f6ed7d694f081a128613d2dfd0

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

Andrés de la Peña

commit sha 770dee5a57da96696b3df64384326786c0506762

Regenerate CircleCI's MIDRES config file patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16858

view details

Sylvain Lebresne

commit sha e581a85b93acff0fecef7d41d9a94a2f89f810ba

Fixup scrub output when no data post-scrub and clear up old use of row, which really means partition patch by Ekaterina Dimitrova; reviewed by Brandon Williams for CASSANDRA-16835 Co-authored-by: Sylvain Lebresne <lebresne@gmail.com> Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>

view details

arunkumar-m

commit sha 632790fd51ae9017fb0de16dbc25b739548ba54c

Remove possible infinite loop in NIODataInputStreamTest patch by arunkumar-m; reviewed by Joel Knighton and Benjamin Lerer for CASSANDRA-12660

view details

Benjamin Lerer

commit sha 6eb02a291dbb1d2415244f675167d3ac8c7ed60d

Merge branch cassandra-3.0 into cassandra-3.11

view details

Bereng

commit sha 23b61a5fa1de17cc6b8a1d7c300053160bfc728a

Prevent broken concurrent schema pulls patch by Dimitar Dimitrov and Berenguer Blasi; reviewed by Brandon Williams, Berenguer Blasi for CASSANDRA-16856 Co-authored-by: Dimitar Dimitrov <dmtrndmtrv@gmail.com> Co-authored-by: Berenguer Blasi <berenguerblasi@gmail.com>

view details

Stefan Miklosovic

commit sha c562f1e78d86cfae6326549d3950f91d054de8ce

validate SASI tokenizer options before adding index to schema patch by Stefan Miklosovic; reviewed by Andrés de la Peña for CASSANDRA-15135

view details

Andrés de la Peña

commit sha c76ff1ba14487d521c49d4b830b2d718d170b2e1

Fix secondary indexes on primary key columns skipping some writes patch by Andrés de la Peña; reviewed by Benjamin Lerer for CASSANDRA-16868

view details

Andrés de la Peña

commit sha 0c38f9dfb8d66d2de2cbde2aadbd03105f411a0d

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

Mick Semb Wever

commit sha b0cdaec5ae31a80808f9892ef353cc3df6a47dbf

Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies patch by Tatu Saloranta; reviewed by Mick Semb Wever for CASSANDRA-16854

view details

Mick Semb Wever

commit sha 1038f4489a141d0660f114fdfa632b627ae73678

Remove duplicate 'lib.download.sha' entries in build-resolver.xml patch by Mick Semb Wever; reviewed by Zhao Yang for CASSANDRA-16897

view details

Caleb Rackliffe

commit sha f9d41ff83655ead37ac6083d7ee43f2c35a346da

Avoid signaling DigestResolver until the minimum number of responses are guaranteed to be visible patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-16883

view details

Caleb Rackliffe

commit sha e5621184d86ac0c8d0c9870786c44baaadfb446a

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

Andrés de la Peña

commit sha e4b37c3271c0e91407816d3c5370ebc8b95a615a

Add resource flags to CircleCI config generation script patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16871

view details

Andrés de la Peña

commit sha 595596e5eec74709c00a5876361262e680a7ab09

Merge branch 'cassandra-3.0' into cassandra-3.11

view details

push time in 4 days

push eventifesdjeen/cassandra

Stefan Miklosovic

commit sha ad139da84c600c294e00263bd2c48b40aea2c2cc

fix incorrect error message in LegacyLayout

view details

Andrés de la Peña

commit sha 07706662104fd7d471379a5ba1155c7e4fb71618

Build tests in CircleCI build job patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16852

view details

arunkumar-m

commit sha 632790fd51ae9017fb0de16dbc25b739548ba54c

Remove possible infinite loop in NIODataInputStreamTest patch by arunkumar-m; reviewed by Joel Knighton and Benjamin Lerer for CASSANDRA-12660

view details

Andrés de la Peña

commit sha c76ff1ba14487d521c49d4b830b2d718d170b2e1

Fix secondary indexes on primary key columns skipping some writes patch by Andrés de la Peña; reviewed by Benjamin Lerer for CASSANDRA-16868

view details

Caleb Rackliffe

commit sha f9d41ff83655ead37ac6083d7ee43f2c35a346da

Avoid signaling DigestResolver until the minimum number of responses are guaranteed to be visible patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-16883

view details

Andrés de la Peña

commit sha e4b37c3271c0e91407816d3c5370ebc8b95a615a

Add resource flags to CircleCI config generation script patch by Andrés de la Peña; reviewed by Ekaterina Dimitrova for CASSANDRA-16871

view details

Ekaterina Dimitrova

commit sha 67eb22ec9d588c9f984d13c0ffd703a14181f775

Fix materialized view schema backup as table patch by Zhao Yang, Ekaterina Dimitrova; reviewed by Benjamin Lerer, Ekaterina Dimitrova for CASSANDRA-12734 Co-authored-by: Zhao Yang <zhao.yang@datastax.com> Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>

view details

Mick Semb Wever

commit sha 2e547dfbc40e6b500db506353bced161c66f3113

Add python2 location to RPMs Patch by Mck Semb Wever; reviewed by brandonwilliams for CASSANDRA-16822

view details

Brandon Williams

commit sha 615372f9087a622e20dfa25159d366e4fc8451f6

Merge branch 'cassandra-2.2' into cassandra-3.0

view details

Stefan Miklosovic

commit sha 267d3ce04efb3bef228c9c1226cd5f938c5d60a3

make the addition of regular column to COMPACT tables throw an InvalidRequestException patch by Stefan Miklosovic; reviewed by Benjamin Lerer for CASSANDRA-14564

view details

Ekaterina Dimitrova

commit sha 57f53f53ae811f00cf9c1f84bd0414d99391f1ce

Avoid removing batch when it's not created during view replication patch by Zhao Yang, Ekaterina Dimitrova; reviewed by Zhao Yang, Ekaterina Dimitrova, Brandon Williams for CASSANDRA-16175 Co-authored-by: Zhao Yang <zhao.yang@datastax.com> Co-authored-by: Ekaterina Dimitrova <ekaterina.dimitrova@datastax.com>

view details

Mick Semb Wever

commit sha b6f0864982f335605e50e68aaf64374d34ec9024

Add semver4j to the default shared packages in the jvm dtests (Upgrade to dtest-api-0.0.9) patch by Mick Semb Wever; reviewed by Alex Petrov for CASSANDRA-16803

view details

Stephen L. De Rudder

commit sha be649d5d5437a99be225049f94fda058e4b9e896

catch UnsatisfiedLinkError in WindowsTimer Patch by Stephen L. De Rudder; reviewed by brandonwilliams and jmckenzie for CASSANDRA-16085

view details

Alex Petrov

commit sha a6e7e6eb19c57708363c7d4af1c8b0d60a302a76

Avoid re-prepare storm on qualified statements after `use` Patch by Alex Petrov; reviewed by Marcus Eriksson for CASSANDRA-15252

view details

Alex Petrov

commit sha 59c35e70bcc50c442e334e072090fc73a85eb126

Split into two files

view details

Alex Petrov

commit sha bd4c8b16cba82384dadd9413bb10d63251a45209

Avoid throwing unnecessarily

view details

Alex Petrov

commit sha fb3708a0bffd0de23f0d81242533a8b1be852c46

Address comments

view details

push time in 4 days

Pull request review commentapache/cassandra

Marcuse/16673

 public TokenMetadata cloneOnlyTokenMap()         }     } +    private TokenMetadata cloneOnlyTokenMapWithRingVersion()

Is there a reason why we wouldn't always want to preserve a ring version? We could then just add ringVersion to the map above.

ifesdjeen

comment created time in 10 days

PullRequestReviewEvent

Pull request review commentapache/cassandra

Marcuse/16673

 protected void validateExpectedOptions() throws ConfigurationException                 throw new ConfigurationException(String.format("Unrecognized strategy option {%s} passed to %s for keyspace %s", key, getClass().getSimpleName(), keyspaceName));         }     }++    static class ReplicaCache<K, V>

It looks like we can slightly improve this by introducing a versioned replicas map (i.e. a class that would hold a final cached version, and final map of replicas), that would be held in an atomic reference. Then, we don't need so synchronise on this, and can just create and return a new version of cached replicas.

ifesdjeen

comment created time in 10 days

PullRequestReviewEvent

PR opened apache/cassandra

Marcuse/16673
+256 -88

0 comment

5 changed files

pr created time in 10 days

pull request commentapache/cassandra-harry

Fix MetricReporter serialization + Update example yaml configs for required props

Thank you for the patch @grighetto, sorry for taking that long to review: was on vacation.

grighetto

comment created time in 14 days

push eventapache/cassandra-harry

Gianluca Righetto

commit sha ddd643ecc904258abe5e2f73d9b612793b0ac0e6

Fix MetricReporter serialization; Update example yaml configs for required props.

view details

push time in 14 days

PR merged apache/cassandra-harry

Fix MetricReporter serialization + Update example yaml configs for required props
  • Fixed Jackson serialization issue for the subtypes of MetricReporter (missing registerSubtypes call);
  • Updated YAML configs to include new required props (and removed old ones).
+15 -23

0 comment

3 changed files

grighetto

pr closed time in 14 days

push eventapache/cassandra

Alex Petrov

commit sha cfc402d26a628bbc9e005c370f5707f4985207aa

Add a flag to upgradesstables to allow only upgrading sstables older than a certain timestamp and recompress command Patch by Alex Petrov, reviewed by Marcus Eriksson for CASSANDRA-16837.

view details

push time in 14 days

PullRequestReviewEvent

Pull request review commentapache/cassandra

CASSANDRA-16721 Move RepairedDataInfo to the execution controller rather than the ReadCommand to avoid unintended sharing

 public void close()             addSample();     } +    public boolean isTrackingRepairedStatus()+    {+        return repairedDataInfo != RepairedDataInfo.NO_OP_REPAIRED_DATA_INFO;+    }++    /**+     * Returns a digest of the repaired data read in the execution of this command.+     *+     * If either repaired status tracking is not active or the command has not yet been+     * executed, then this digest will be an empty buffer.+     * Otherwise, it will contain a digest* of the repaired data read, or empty buffer

is * after "digest" intended?

maedhroz

comment created time in a month

Pull request review commentapache/cassandra

CASSANDRA-16721 Move RepairedDataInfo to the execution controller rather than the ReadCommand to avoid unintended sharing

 public void close()             addSample();     } +    public boolean isTrackingRepairedStatus()+    {+        return repairedDataInfo != RepairedDataInfo.NO_OP_REPAIRED_DATA_INFO;+    }++    /**+     * Returns a digest of the repaired data read in the execution of this command.+     *+     * If either repaired status tracking is not active or the command has not yet been+     * executed, then this digest will be an empty buffer.+     * Otherwise, it will contain a digest* of the repaired data read, or empty buffer+     * if no repaired data was read.+     * @return digest of the repaired data read in the execution of the command+     */+    public ByteBuffer getRepairedDataDigest()+    {+        return repairedDataInfo.getDigest();+    }++    /**+     * Returns a boolean indicating whether any relevant sstables were skipped during the read+     * that produced the repaired data digest.+     *+     * If true, then no pending repair sessions or partition deletes have influenced the extent+     * of the repaired sstables that went into generating the digest.+     * This indicates whether or not the digest can reliably be used to infer consistency+     * issues between the repaired sets across replicas.+     *+     * If either repaired status tracking is not active or the command has not yet been+     * executed, then this will always return true.+     *+     * @return boolean to indicate confidence in the dwhether or not the digest of the repaired data can be

dwether -> wether

maedhroz

comment created time in a month

Pull request review commentapache/cassandra

CASSANDRA-16721 Move RepairedDataInfo to the execution controller rather than the ReadCommand to avoid unintended sharing

 private void makeRequests(ReadCommand readCommand, Iterable<Replica> replicas)         if (hasLocalEndpoint)         {             logger.trace("reading {} locally", readCommand.isDigestQuery() ? "digest" : "data");-            Stage.READ.maybeExecuteImmediately(new LocalReadRunnable(command, handler));++            if (TEST_FORCE_ASYNC_LOCAL_READS)+                new Thread(new LocalReadRunnable(readCommand, handler)).start();

wondering if it could be best to just create a separate method for executing read runnable, and using ByteBuddy during test

maedhroz

comment created time in a month

PullRequestReviewEvent

pull request commentapache/cassandra

CASSANDRA-16859 - allow blocking IPs from updating metrics about traffic

+1 for Couter metrics change, it's a good addition

dcapwell

comment created time in a month

push eventifesdjeen/cassandra

Alex Petrov

commit sha 23e05afe12fbb00255f80a5b3c4b7629f8d309b7

Avoid throwing unnecessarily

view details

push time in a month

push eventifesdjeen/cassandra

Alex Petrov

commit sha 95cce893f96058ed34ad908b02b21ec63e9aaf9d

Avoid throwing unnecessarily

view details

push time in a month

push eventifesdjeen/cassandra

Alex Petrov

commit sha afa9d3453e8cb0f454f1ff19aa4ab04ddab29794

Avoid throwing unnecessarily

view details

push time in a month

push eventifesdjeen/cassandra

Alex Petrov

commit sha 0c2f8b1d74cbee2ae8933a344f8864953fa63ec5

Avoid throwing unnecessarily

view details

push time in a month

create barnchifesdjeen/cassandra

branch : run-tests-3.0

created branch time in a month