extremely +1 to this

Oh...now I know what you meant with the question. Yes, the oldPath will resolve to the same value.

@yanniszark @gaocegege @johnugeorge @tenzen-y I changed manifest and script to run from the Job instead of initContainer. I have one question to us.

1. We add template for the katib-webhook-cert YAML in the manifest, like we are doing right now. And we don't add ownerReference for this secret in the cert-generator script. Pros:

   • We can add ttlSecondsAfterFinished to the cert-generator Job and user doesn't waste cluster resources for the katib-cert-generator pod.
   • User can manually specify tls.key and tls.crt in the secret YAML and not use our Job.

   Cons:

   • Katib controller is restarted few times before the katib-cert-generator Job is finished.

2. We doesn't add template for the katib-webhook-cert YAML in the manifest and we add ownerReference for this secret in the cert-generator script. Like mentioned before: https://github.com/kubeflow/katib/pull/1450#issuecomment-789041529

   Pros:

   • Katib controller doesn't start before the katib-cert-generator Job is finished, which means controller should not be restarted.

   Cons:

   • We can't add ttlSecondsAfterFinished to the cert-generator Job.

   • User should manually create YAML for the secret to use custom certificates.

In the both cases, once we uninstall Katib all resources are deleted.

Hi @krmayankk ,

Enhancements team is currently tracking the following PRs

• kubernetes/kubernetes#94641
• kubernetes/kubernetes#98645

With the PRs merged, can we mark this enhancement complete for code freeze or do you have other PR(s) that are being worked on as part of the release?

Thanks

Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 36 of 160 Specs in 9794.298 seconds
FAIL! -- 21 Passed | 15 Failed | 0 Pending | 124 Skipped
--- FAIL: TestE2E (9794.33s)
FAIL

Ginkgo ran 1 suite in 2h43m42.966792045s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-block-vanilla/Results/335/vsphere-csi-driver`

The result is definitelly not the same :-). Archived directory has the same name as the provisioned directory, just with 'archived-' prefix. And that is the same behavior that the old nfs provisioner had. It is much more user friendly, than just plain guid PV name used now.

Editing with new name for clarity

This is the formal proposal for etcd graduation. The etcd project was open sourced in July 2014 and joined the CNCF in December 2018 as an incubator project. The project has grown significantly over time. With the latest major release of etcd, v3.4.0, the project maintainers believe that etcd is ready for the graduation.

This is the formal proposal for OPA to graduate from the incubating stage. All of the graduation criteria have been met. You can find the details in this proposal as well as the due diligence document that we have prepared.

SIG-Security performed a detailed assessment on OPA. Their TOC recommendation can be found at the end of the DD document.

cc @dshaw (SIG-Security) @brendandburns (TOC sponsor)

@DavidSpek: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

sure

What this PR does / why we need it: This PR adds TriggerCsiFullSync API to which lets admins to trigger full sync on demand.

This PR does the following

1. adds the API definition and create/update the API on syncer init.
2. guard the feature by a feature gate.
3. Moved pkg/internal to pkg/internalapis as internal folder can't be referenced outside the parent package.

Add TriggerCsiFullSync API

Testing Done: On Syncer init startup

{"level":"info","time":"2021-02-22T20:16:14.823823023Z","caller":"kubernetes/kubernetes.go:381","msg":"\"triggercsifullsyncs.cns.vmware.com\" CRD created successfully"}

All unit-tests passed.

cc @SandeepPissay @chethanv28

Sure

Will clean it up

/remove-lifecycle stale -- still actively working on this via different angles

copyright year.

copyright year.

Can you move this line back to previous location?

Is the comment needed? Can TypeMeta be different?

Please change the copyright year.

As you may notice, we have switched to the new differ framework to replace the old patroller logic. sigs.k8s.io/multi-tenancy/incubator/virtualcluster/pkg/syncer/patrol/differ/differ.go

Can you please adopt the same framework?

copyright year.

hi @pacoxu , looks like this feature is code complete based on kubernetes/kubernetes#99158 merged into master. Could you please confirm?

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/662#" title="Author self-approved">BaluDontu</a>, <a href="https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/662#pullrequestreview-602196215" title="LGTM">chethanv28</a>, <a href="https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/662#issuecomment-788355769" title="Approved">SandeepPissay</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

• OWNERS [BaluDontu,SandeepPissay,chethanv28]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

should this be closed as there is https://elekto.io/ now?

Hi @irozzo-1A,

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@JamesLaverack the core of this change is not in k/k as @youssefazrak pointed out. The only thing that we may need to do in k/k is adding/modifying some manifests and scripts, or adding an e2e test, but I'm not sure at this stage. Tomorrow I will check with the sig-cloud-provider and come back to you.

File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 25 of 165 Specs in 6522.986 seconds
FAIL! -- 21 Passed | 4 Failed | 0 Pending | 140 Skipped
--- FAIL: TestE2E (6523.01s)
FAIL

Ginkgo ran 1 suite in 1h49m8.480999499s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-file-vanilla/Results/193/vsphere-csi-driver`

4 tests failed not related to my change.