profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/idvoretskyi/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ihor Dvoretskyi idvoretskyi @cncf @kubernetes Ukraine twitter.com/idvoretskyi

cncf/mentoring 367

👩🏿‍🎓👨🏽‍🎓👩🏻‍🎓CNCF Mentoring + CommunityBridge + Summer of Code

cncf/cluster 112

🖥🖥🖥🖥CNCF Community Cluster

cncf/sig-contributor-strategy 42

CNCF Special Interest Group on Contributor Strategy -- maintainer relations, building up contributors, governance, graduation, and more.

cncf/project-template 4

CNCF Project Template

idvoretskyi/awesome-knative 2

Curated list of the knative-related resources

idvoretskyi/awesome-serverless 1

:cloud: A curated list of awesome services, solutions and resources for serverless / nobackend applications.

idvoretskyi/advocate 0

ihor.dev/advocate

idvoretskyi/ambassadors 0

CNCF Ambassadors

idvoretskyi/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.

issue commentkubernetes/community

Should LWKD be a Contribex Comms subproject?

extremely +1 to this

jberkus

comment created time in 2 minutes

Pull request review commentkubernetes-sigs/nfs-subdir-external-provisioner

Preserve name of the PV directory name during archiving

 func (p *nfsProvisioner) Provision(ctx context.Context, options controller.Provi  func (p *nfsProvisioner) Delete(ctx context.Context, volume *v1.PersistentVolume) error { 	path := volume.Spec.PersistentVolumeSource.NFS.Path-	relativePath := strings.Replace(path, p.path, "", 1)-	oldPath := filepath.Join(mountPath, relativePath)+	basePath := filepath.Base(path)+	oldPath := filepath.Join(mountPath, basePath)

Oh...now I know what you meant with the question. Yes, the oldPath will resolve to the same value.

petermicuch

comment created time in 6 minutes

pull request commentkubeflow/katib

Disable dynamic creation for admission hooks and update dependencies

@yanniszark @gaocegege @johnugeorge @tenzen-y I changed manifest and script to run from the Job instead of initContainer. I have one question to us.

  1. We add template for the katib-webhook-cert YAML in the manifest, like we are doing right now. And we don't add ownerReference for this secret in the cert-generator script. Pros:

    • We can add ttlSecondsAfterFinished to the cert-generator Job and user doesn't waste cluster resources for the katib-cert-generator pod.
    • User can manually specify tls.key and tls.crt in the secret YAML and not use our Job.

    Cons:

    • Katib controller is restarted few times before the katib-cert-generator Job is finished.
  2. We doesn't add template for the katib-webhook-cert YAML in the manifest and we add ownerReference for this secret in the cert-generator script. Like mentioned before: https://github.com/kubeflow/katib/pull/1450#issuecomment-789041529

    Pros:

    • Katib controller doesn't start before the katib-cert-generator Job is finished, which means controller should not be restarted.

    Cons:

    • We can't add ttlSecondsAfterFinished to the cert-generator Job.

    • User should manually create YAML for the secret to use custom certificates.

In the both cases, once we uninstall Katib all resources are deleted.

andreyvelich

comment created time in 9 minutes

issue commentkubernetes/enhancements

Provide RunAsGroup feature for Containers in a Pod

Hi @krmayankk ,

Enhancements team is currently tracking the following PRs

  • kubernetes/kubernetes#94641
  • kubernetes/kubernetes#98645

With the PRs merged, can we mark this enhancement complete for code freeze or do you have other PR(s) that are being worked on as part of the release?

Thanks

krmayankk

comment created time in 9 minutes

pull request commentkubernetes-sigs/vsphere-csi-driver

Add PVC name and namespace in the logs of csiGetVolumeHealthStatus method

Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 36 of 160 Specs in 9794.298 seconds
FAIL! -- 21 Passed | 15 Failed | 0 Pending | 124 Skipped
--- FAIL: TestE2E (9794.33s)
FAIL

Ginkgo ran 1 suite in 2h43m42.966792045s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-block-vanilla/Results/335/vsphere-csi-driver`

chethanv28

comment created time in 9 minutes

Pull request review commentkubernetes-sigs/nfs-subdir-external-provisioner

Preserve name of the PV directory name during archiving

 func (p *nfsProvisioner) Provision(ctx context.Context, options controller.Provi  func (p *nfsProvisioner) Delete(ctx context.Context, volume *v1.PersistentVolume) error { 	path := volume.Spec.PersistentVolumeSource.NFS.Path-	relativePath := strings.Replace(path, p.path, "", 1)-	oldPath := filepath.Join(mountPath, relativePath)+	basePath := filepath.Base(path)+	oldPath := filepath.Join(mountPath, basePath)

The result is definitelly not the same :-). Archived directory has the same name as the provisioned directory, just with 'archived-' prefix. And that is the same behavior that the old nfs provisioner had. It is much more user friendly, than just plain guid PV name used now.

petermicuch

comment created time in 9 minutes

pull request commentcncf/toc

Emissary-ingress proposal for CNCF Incubation

Editing with new name for clarity

danielbryantuk

comment created time in 13 minutes

push eventcncf/toc

Sahdev P. Zala

commit sha e889b78667e5e57ae55a8299e76e1eec262a7d97

Proposal for etcd graduation   This is a formal proposal for etcd graduation. The etcd project was open sourced in July 2014 and joined the CNCF in December 2018 as an incubator project. The project has grown significantly over time. With the latest major release of etcd, v3.4.0, the project maintainers believe that etcd is ready for the graduation. 

view details

Amye Scavarda Perrin

commit sha 3c14a098b9a69350bf0272446264c9e17e958e4b

Merge pull request #541 from spzala/etcdgradproposal Proposal for etcd graduation

view details

push time in 15 minutes

PR merged cncf/toc

Reviewers
Proposal for etcd graduation graduation

This is the formal proposal for etcd graduation. The etcd project was open sourced in July 2014 and joined the CNCF in December 2018 as an incubator project. The project has grown significantly over time. With the latest major release of etcd, v3.4.0, the project maintainers believe that etcd is ready for the graduation.

+41 -0

6 comments

1 changed file

spzala

pr closed time in 15 minutes

push eventcncf/toc

Torin Sandall

commit sha 7807aae79059005b9ee9b169736165f693472ac7

Add OPA graduation proposal Signed-off-by: Torin Sandall <torinsandall@gmail.com>

view details

Amye Scavarda Perrin

commit sha 143e3daa4dad2497a62e591703c15a757ac9e63b

Merge pull request #520 from tsandall/master Add OPA graduation proposal

view details

push time in 16 minutes

PR merged cncf/toc

Add OPA graduation proposal graduation

This is the formal proposal for OPA to graduate from the incubating stage. All of the graduation criteria have been met. You can find the details in this proposal as well as the due diligence document that we have prepared.

SIG-Security performed a detailed assessment on OPA. Their TOC recommendation can be found at the end of the DD document.

cc @dshaw (SIG-Security) @brendandburns (TOC sponsor)

+57 -0

1 comment

1 changed file

tsandall

pr closed time in 16 minutes

create barnchcncf/cnf-conformance

branch : feature/#601-kubectl-apply

created branch time in 16 minutes

pull request commentkubeflow/kubeflow

(JWA and notebook controller): Set header needed for R-Studio

@DavidSpek: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-kubeflow-presubmit 97306b418cb318b42f7c7bfee95d1e852a15391a link /test kubeflow-kubeflow-presubmit

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

DavidSpek

comment created time in 18 minutes

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

 package priorityclass  import ( 	"fmt"+	"sigs.k8s.io/multi-tenancy/incubator/virtualcluster/pkg/syncer/constants"

sure

weiling61

comment created time in 24 minutes

push eventkubernetes-sigs/vsphere-csi-driver

BaluDontu

commit sha 8f592e037ce32abcb5c5147207c5f1179514168a

Add TriggerCsiFullSync API

view details

BaluDontu

commit sha 5e3571c6a0e3101b4370d3671721e78906860110

Add TriggerCsiFullSync feature state switch to manifest files for all flavors

view details

Kubernetes Prow Robot

commit sha f38d255b60fa4ad8aa6fe8409cfa1ecad09ea825

Merge pull request #662 from BaluDontu/TriggerFullSyncOnDemand [Part 1] Add TriggerCsiFullSync API

view details

push time in 24 minutes

PR merged kubernetes-sigs/vsphere-csi-driver

Reviewers
[Part 1] Add TriggerCsiFullSync API approved cncf-cla: yes lgtm size/XL

What this PR does / why we need it: This PR adds TriggerCsiFullSync API to which lets admins to trigger full sync on demand.

This PR does the following

  1. adds the API definition and create/update the API on syncer init.
  2. guard the feature by a feature gate.
  3. Moved pkg/internal to pkg/internalapis as internal folder can't be referenced outside the parent package.
Add TriggerCsiFullSync API

Testing Done: On Syncer init startup

{"level":"info","time":"2021-02-22T20:16:14.823823023Z","caller":"kubernetes/kubernetes.go:381","msg":"\"triggercsifullsyncs.cns.vmware.com\" CRD created successfully"}

All unit-tests passed.

cc @SandeepPissay @chethanv28

+454 -54

70 comments

23 changed files

BaluDontu

pr closed time in 24 minutes

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

+/*+Copyright 2019 The Kubernetes Authors.

Sure

weiling61

comment created time in 24 minutes

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

 func (e vcEquality) CheckPriorityClassEquality(pObj, vObj *v1scheduling.Priority 	} } +func (e vcEquality) CheckCRDEquality(pObj, vObj *v1beta1.CustomResourceDefinition) *v1beta1.CustomResourceDefinition {+	pObjCopy := pObj.DeepCopy()+	pObjCopy.ObjectMeta = vObj.ObjectMeta+	// pObj.TypeMeta is empty

Will clean it up

weiling61

comment created time in 25 minutes

issue commentkubernetes/community

PR Lifecycle stats, automation, and leadership notification

/remove-lifecycle stale -- still actively working on this via different angles

timothysc

comment created time in 25 minutes

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

+/*+Copyright 2019 The Kubernetes Authors.

copyright year.

weiling61

comment created time in 42 minutes

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

+/*+Copyright 2020 The Kubernetes Authors.

copyright year.

weiling61

comment created time in 43 minutes

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

 package priorityclass  import ( 	"fmt"+	"sigs.k8s.io/multi-tenancy/incubator/virtualcluster/pkg/syncer/constants"

Can you move this line back to previous location?

weiling61

comment created time in 38 minutes

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

 func (e vcEquality) CheckPriorityClassEquality(pObj, vObj *v1scheduling.Priority 	} } +func (e vcEquality) CheckCRDEquality(pObj, vObj *v1beta1.CustomResourceDefinition) *v1beta1.CustomResourceDefinition {+	pObjCopy := pObj.DeepCopy()+	pObjCopy.ObjectMeta = vObj.ObjectMeta+	// pObj.TypeMeta is empty

Is the comment needed? Can TypeMeta be different?

weiling61

comment created time in an hour

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

+/*+Copyright 2019 The Kubernetes Authors.

Please change the copyright year.

As you may notice, we have switched to the new differ framework to replace the old patroller logic. sigs.k8s.io/multi-tenancy/incubator/virtualcluster/pkg/syncer/patrol/differ/differ.go

Can you please adopt the same framework?

weiling61

comment created time in an hour

Pull request review commentkubernetes-sigs/multi-tenancy

Adding CRD UW synchronization

+/*+Copyright 2019 The Kubernetes Authors.

copyright year.

weiling61

comment created time in an hour

issue commentkubernetes/enhancements

Add sysctl support

hi @pacoxu , looks like this feature is code complete based on kubernetes/kubernetes#99158 merged into master. Could you please confirm?

sttts

comment created time in 29 minutes

pull request commentkubernetes-sigs/vsphere-csi-driver

[Part 1] Add TriggerCsiFullSync API

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/662#" title="Author self-approved">BaluDontu</a>, <a href="https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/662#pullrequestreview-602196215" title="LGTM">chethanv28</a>, <a href="https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/662#issuecomment-788355769" title="Approved">SandeepPissay</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

  • OWNERS [BaluDontu,SandeepPissay,chethanv28]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

BaluDontu

comment created time in 30 minutes

issue commentkubernetes/community

Create app for holding Steering elections using only github auth

should this be closed as there is https://elekto.io/ now?

jberkus

comment created time in 33 minutes

issue commentkubernetes/enhancements

Extending Apiserver Network Proxy to handle traffic originated from Node network

Hi @irozzo-1A,

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@JamesLaverack the core of this change is not in k/k as @youssefazrak pointed out. The only thing that we may need to do in k/k is adding/modifying some manifests and scripts, or adding an e2e test, but I'm not sure at this stage. Tomorrow I will check with the sig-cloud-provider and come back to you.

irozzo-1A

comment created time in 33 minutes

pull request commentkubernetes-sigs/vsphere-csi-driver

[Part 1] Add TriggerCsiFullSync API

File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 25 of 165 Specs in 6522.986 seconds
FAIL! -- 21 Passed | 4 Failed | 0 Pending | 140 Skipped
--- FAIL: TestE2E (6523.01s)
FAIL

Ginkgo ran 1 suite in 1h49m8.480999499s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-file-vanilla/Results/193/vsphere-csi-driver`

4 tests failed not related to my change.

BaluDontu

comment created time in 34 minutes