profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/holyfight6/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

holyfight6/desktop-settings 0

⚙ settings packages for the manjaro flavors

holyfight6/doom-emacs 0

An Emacs framework for the stubborn martian hacker

holyfight6/github-slideshow 0

A robot powered training repository :robot:

holyfight6/learn_wgpu 0

Start learning wgpu.

holyfight6/MHW-Costume-Armor 0

GUI Program to customize layered Armor in the game Monster Hunter World.

holyfight6/SpaceVim 0

A community-driven modular vim distribution - The ultimate vim configuration

holyfight6/Urho3D 0

Cross-platform 2D and 3D game engine.

delete branch holyfight6/doom-emacs

delete branch : format-all-lsp

delete time in 2 months

PR opened hlissner/doom-emacs

Reviewers
Changed editor/format lsp feature requirement from textDocument/rangeFormatting to textDocument/formatting

<!--

YOUR PR WILL NOT BE ACCEPTED IF IT DOES NOT MEET THE FOLLOWING CRITERIA:

  • [x] It targets the develop branch
  • [x] I've searched for similar pull requests and found nothing
  • [x] This change is NOT in Doom's do-not-PR list: https://doomemacs.org/d/do-not-pr
  • [x] If I've bumped any packages, I've done so according to https://doomemacs.org/d/how2bump
  • [x] I've linked any relevant issues and PRs below
  • [x] All my commit messages are descriptive and distinct

-->

A lot of lsp servers don't support textDocument/rangeFormatting but support textDocument/formatting(eg: rust-analyzer). The fallback formatter has some issues (like in rust-mode it won't respect the project's cargo files). I think it's better to use lsp as the default formatter as long as the lsp server support file formating.

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchholyfight6/doom-emacs

branch : format-all-lsp

created branch time in 2 months

push eventholyfight6/doom-emacs

Fulvio di Girolamo

commit sha 01bb9357c905ab641f944c2856b256fe082424a3

Tolerate colon characters inside code

view details

Dave Lucia

commit sha 211ef8c93c6e02aa6d39e19d32e883c7f024a331

Syntax highlight .sface files as html [Phoenix.LiveView](https://hexdocs.pm/phoenix_live_view) has a project called [Surface](https://surface-ui.org/) that adds a `.sface` extension to files. These should be syntax highlighted as html. First PR!

view details

Kalle Lindqvist

commit sha 8e33ecf29a6882776bbf41096b2c8a9cc5d8be0d

config/default: Fix C-return binding in GUI Emacs The "C-RET" binding does only seem to work when running Emacs in a terminal. "C-<return>" makes it work in the GUI.

view details

Gerry Agbobada

commit sha fda382cc866feadc7212d1d5e7a7497c57b3b552

Feature-gate :tools lsp company-specific hooks As I’m trying to use [corfu](https://github.com/minad/corfu) for a bit, I found out that this hook prevents lsp-mode from starting if company-mode isn’t used.

view details

mjkalyan

commit sha cdf7846e3cbb256fddd67f786c6d9c6a4ad2920d

getting_started.org: Gentoo Linux install guide

view details

mjkalyan

commit sha 2d53f12f1c852d81e13bd2f328c84d0080da792d

getting_started.org: Gentoo xft and gui flags As suggested by @TheGreatMcPain here: https://github.com/hlissner/doom-emacs/pull/5165#issuecomment-863747913

view details

Leo Okawa Ericson

commit sha 7b3b74c2ad625a7c9f03a0723ddc5e09c51d7675

Remove workaround for upstream lispyville PR https://github.com/noctuid/lispyville/pull/297 was merged which makes the changes from https://github.com/hlissner/doom-emacs/pull/5101 obsolete.

view details

Henrik Lissner

commit sha 95f40c62ab062515b3f947e022271319172f82fb

Add doom/bumpify-diff & doom/commit-bumps commands To make bumping things easier. Use M-x doom/commit-bumps to create a pre-filled bump commit in magit. Use M-x doom/bumpify-diff to scrape the current buffer (assuming it's a diff buffer) and copy a bump commit message to your clipboard.

view details

Henrik Lissner

commit sha d79cea2e4c2f6ca99926bd8086bb03e71708970f

Minor refactors, reformatting, & comment revision

view details

Henrik Lissner

commit sha f523830a0ea5510e0646b93a5b737ec21c1a2dba

Don't load core-cli on doom/reload Hopefully addresses "Device 1 is not a termcap terminal device" errors, due to core-cli changing `debugger`. core-cli should never be loaded in an interactive session anyway. Possibly fixes #4849

view details

Henrik Lissner

commit sha cbb0ce9f85636d49832a98a019f3b7163b84d31f

Don't log hooks Produces a lot of logging noise, and Doom already injects context into errors that occur in hooks.

view details

Henrik Lissner

commit sha ec95669710dead9e7e21dc429553a7026dbdefb5

lang/javascript: remove coffee-mode The coffee-mode config was too trivial (a one-liner), and is becoming too niche for inclusion-by-default in the javascript module. I'm technically removing js2-mode too, but rjsx-mode installs it as a dependency anyway.

view details

Henrik Lissner

commit sha 6be2262423c87dadb9ada6deaa15db7959075f95

Bump :lang 200ok-ch/counsel-jq@153d70b -> 200ok-ch/counsel-jq@8cadd2e Andersbakken/rtags@63f18ac -> Andersbakken/rtags@65113e2 Groovy-Emacs-Modes/groovy-emacs-modes@26da902 -> Groovy-Emacs-Modes/groovy-emacs-modes@99eaf70 NixOS/nix-mode@0023fc5 -> NixOS/nix-mode@3cca5b6 ProofGeneral/PG@f0f0476 -> ProofGeneral/PG@bc86736 Raku/raku-mode@8a6e17f -> Raku/raku-mode@7496ad3 StanfordLegion/terra-mode@1e5e824 -> StanfordLegion/terra-mode@eab9e59 TheBB/company-reftex@291c283 -> TheBB/company-reftex@42eb98c agda/agda@ecb9323 -> agda/agda@af9c4b9 ananthakumaran/tide@ad6fa78 -> ananthakumaran/tide@ccff099 asok/projectile-rails@f1fe6e8 -> asok/projectile-rails@6a18ada beancount/beancount-mode@3c04745 -> beancount/beancount-mode@02fe03e brotzeit/rustic@ed68fd3 -> brotzeit/rustic@6ca73bb cdominik/cdlatex@adf96ba -> cdominik/cdlatex@614a8d9 clojure-emacs/clojure-mode@a14671e -> clojure-emacs/clojure-mode@3e426b3 cython/cython@9decfca -> cython/cython@fae33cf dgutov/robe@126650a -> dgutov/robe@e1304d1 diml/utop@711c246 -> diml/utop@c87b8b2 dominikh/go-mode.el@49a5380 -> dominikh/go-mode.el@3497434 elixir-editors/emacs-elixir@0212b06 -> elixir-editors/emacs-elixir@6bbc1e5 emacs-csharp/csharp-mode@f977800 -> emacs-csharp/csharp-mode@093f0f2 emacs-ess/ESS@126d344 -> emacs-ess/ESS@4fefd0f emacs-lsp/lsp-dart@f3b70ec -> emacs-lsp/lsp-dart@01d89d4 emacs-lsp/lsp-haskell@7efbef3 -> emacs-lsp/lsp-haskell@eb37ac4 emacs-lsp/lsp-java@9685334 -> emacs-lsp/lsp-java@b66a075 emacs-lsp/lsp-metals@51a89c1 -> emacs-lsp/lsp-metals@9f82ebe emacs-lsp/lsp-pyright@65fb141 -> emacs-lsp/lsp-pyright@71a7976 emacs-lsp/lsp-sourcekit@aafa987 -> emacs-lsp/lsp-sourcekit@ae4aa87 emacs-php/php-mode@a2bca9b -> emacs-php/php-mode@cbf2723 emacs-php/phpactor.el@80788a8 -> emacs-php/phpactor.el@272217f emacs-straight/auctex@1472d1d -> emacs-straight/auctex@ea410dc erlang/otp@94c9738 -> erlang/otp@645ea81 ethereum/emacs-solidity@b4fd719 -> ethereum/emacs-solidity@5f6ef31 factor/factor@5bfeab6 -> factor/factor@b989a86 fsharp/emacs-fsharp-mode@78898a1 -> fsharp/emacs-fsharp-mode@93b1fbc godotengine/emacs-gdscript-mode@16c631c -> godotengine/emacs-gdscript-mode@b7bfa6a greghendershott/racket-mode@5115c47 -> greghendershott/racket-mode@7f12cb1 haskell/haskell-mode@1baa12a -> haskell/haskell-mode@98ba392 hhvm/hack-mode@847fd91 -> hhvm/hack-mode@f9315be hlissner/emacs-pug-mode@685fd34 -> hlissner/emacs-pug-mode@d080904 hvesalai/emacs-sbt-mode@0bdc36b -> hvesalai/emacs-sbt-mode@e29464a idris-hackers/idris-mode@80aabd2 -> idris-hackers/idris-mode@f52ad0b immerrr/lua-mode@2d9a468 -> immerrr/lua-mode@2bd9077 iyefrat/evil-tex@5f0d6fb -> iyefrat/evil-tex@87445d4 jcollard/elm-mode@e9fcf9c -> jcollard/elm-mode@f2e2d00 joaotavora/sly@5966d68 -> joaotavora/sly@41f4d65 jorgenschaefer/pyvenv@9b3678b -> jorgenschaefer/pyvenv@045ff94 jrblevin/markdown-mode@ac9ea26 -> jrblevin/markdown-mode@359347b jwiegley/emacs-async@d7e7f79 -> jwiegley/emacs-async@9a8cd0c jyp/attrap@778382e -> jyp/attrap@a5bc695 leanprover/lean-mode@5c50338 -> leanprover/lean-mode@bf32bb9 ledger/ledger-mode@32fef09 -> ledger/ledger-mode@19b84dc nathankot/company-sourcekit@abf9bc5 -> nathankot/company-sourcekit@a1860ad necaris/conda.el@dce431b -> necaris/conda.el@6db0720 non-Jedi/eglot-jl@84cff9d -> non-Jedi/eglot-jl@49f170e nonsequitur/inf-ruby@c6990a6 -> nonsequitur/inf-ruby@03dd9c9 ocaml-ppx/ocamlformat@0ad8d0a -> ocaml-ppx/ocamlformat@5dd6574 ocaml/dune@65e04ba -> ocaml/dune@75ecfe3 ocaml/merlin@635923d -> ocaml/merlin@5731826 ocaml/tuareg@37a6730 -> ocaml/tuareg@b59c422 pashky/restclient.el@abc307b -> pashky/restclient.el@2cc1fd3 polymode/polymode@b3871e9 -> polymode/polymode@7d1f822 pythonic-emacs/anaconda-mode@344727c -> pythonic-emacs/anaconda-mode@4f367c7 seagle0128/grip-mode@2855205 -> seagle0128/grip-mode@c0ca789 sebasmonia/sharper@d610b83 -> sebasmonia/sharper@08277b6 swift-emacs/swift-mode@ad12a30 -> swift-emacs/swift-mode@1b47a09 technomancy/fennel-mode@ba14a7d -> technomancy/fennel-mode@a908db8 tpapp/julia-repl@7ce38a9 -> tpapp/julia-repl@79e686e ziglang/zig-mode@2d0eb23 -> ziglang/zig-mode@0babe7e Closes #5221

view details

Henrik Lissner

commit sha 55c9cde6eefff3a2468fe2763a99243f238221a7

Bump :ui doom hlissner/emacs-solaire-mode@731552b -> hlissner/emacs-solaire-mode@030964f Fixes solaire-mode not activating correctly due to missing autoload.

view details

Henrik Lissner

commit sha 69cfc602435252207c9a7af5fe35e248ae1dc65b

Bump :editor abo-abo/lispy@38a7df4 -> abo-abo/lispy@e9731aa emacs-evil/evil-collection@b6025cf -> emacs-evil/evil-collection@9be3805 emacs-evil/evil@1b3db63 -> emacs-evil/evil@b237462 emacs-straight/adaptive-wrap@91e939b -> emacs-straight/adaptive-wrap@0d5b4a0 emacsorphanage/god-mode@02a402b -> emacsorphanage/god-mode@1d7d647 hlissner/doom-snippets@f7747da -> hlissner/doom-snippets@5c0eb5b justinbarclay/parinfer-rust-mode@f130fa0 -> justinbarclay/parinfer-rust-mode@c2c1bbe magnars/multiple-cursors.el@7b13b03 -> magnars/multiple-cursors.el@616fbdd noctuid/lispyville@89316f0 -> noctuid/lispyville@9c14bed redguardtoo/evil-nerd-commenter@b8ac35f -> redguardtoo/evil-nerd-commenter@118bebd willghatch/evil-textobj-anyblock@29280cd -> willghatch/evil-textobj-anyblock@29280cd

view details

Henrik Lissner

commit sha 084918f4ea70c9b22e44942448040bf47ce37167

editor/evil: correct evil-collection module name

view details

Henrik Lissner

commit sha e2ca32bd6bf55c25c9dd22ed8e94e4ab9ba59372

Fix fill column indicator toggle on 'SPC t c' The :ui fill-column module was dropped in 044a1a5f2.

view details

Henrik Lissner

commit sha 9ffa5d6c2f561d18291bb09ccb90fad11814de0e

org-roam-link-use-custom-faces = everywhere

view details

lguenth

commit sha 4af3f4c4350248b515be3f19d5cfbe57b92abe9f

Update ui/deft README to new format

view details

Henrik Lissner

commit sha 5c741cb65f760e0dc3b2af6c1717495852d30199

Fix #5255: reload session after dashboard init Otherwise, the dashboard replaces one of the buffers when reloading the last session at startup.

view details

push time in 2 months

push eventholyfight6/doom-emacs

Yoav Marco

commit sha 9478a6a9012d8dff197dcd735364566d791233cd

lang/latex +fold: fix error when yas-snippet-{beg,end} are nil

view details

Leo Okawa Ericson

commit sha db83e94bad240d0548398232fe00e879139e4e9f

Remove dependence on company for fish and bash completion Bash and fish completion work without company, e.g. when the user uses the minibuffer for completion.

view details

Itai Y. Efrat

commit sha 5c54ae1329f05eefb15e52d13e72a327885a58dc

lang/json/doctor: only check for jq if ivy is on since `counsel-jq` is only relevant for ivy

view details

Gerry Agbobada

commit sha cbfd2fadc04c0934ee5d1b376d158532187cea73

[:input layout bepo] Remove "W" convenience remap `W` was used to emulate `C-w C-w`, which is useful to quickly change windows most of the time. But this currently conflicts with edebug evil-collection bindings. (gives `Key sequence W W starts with non-prefix key W`). Better to leave the key alone, avoid error messages altogether, and let users redefine the binding if they want to.

view details

Ralf Beckmann

commit sha 012b759e987f3221ac21a74758c406a67a2fca65

Fix #5128: No format-on-save by lsp-formatters A call to `format-all--formatter-executable` with the formatter being equal to `'lsp` or `'eglot` will return `nil`. Therefore, `funcall` was never called in those cases.

view details

Itai Y. Efrat

commit sha 033851556a18341acdde10f74577e204f9c7d270

lang/lua: document fennel support in readme

view details

meltinglava

commit sha 3eac1f4e8a0105bc99a01989d0eb2cd11b3e9e3e

removed unused use in "file-template rust main"

view details

pqitr

commit sha 8f89e58c3a2306baab3ee4282a8c3882a2099192

remove duplicate '+' from kotlin +lsp

view details

Connor Braa

commit sha 7f87870099d32b026af55cdeb99a3c7127d7bea8

Bump flycheck-kotlin whirm/flycheck-kotlin@5104ee9a -> whirm/flycheck-kotlin@bf1b398b flycheck-kotlin: support newer versions of ktlint

view details

Itai Y. Efrat

commit sha b3dfd4758d714b184c2e40b5a2a82bf277ce8af9

don't explicitly set `projectile-completion-system` The default value is `'auto`, which handles the detection of the active completion system, see the definition of `projectile-completing-read`.

view details

Patrick Wulfe

commit sha 2546883543919badaf08e5a8209790ad8df57c52

The dart config was setting the 'flutter-run-or-hot-reload' keybind with init, so if you changed the localleader in your settings, it would stay as SPC m rather than what localleader was mapped to

view details

Samuel Jackson

commit sha bb677cf7a5857e45519b7f2d5a67e43639ad19d2

Prevent extra variable from being passed in macro. In the PDF module, there is a macro that is used to prevent the file-too-big prompt for PDFs since they're always too big. However, this macro has an extra variable listed that then gets passed on to the wrapped function and causes an error if the function doesn't support the extra variable. This fix simply checks if the extra value is present or not and only calls the wrapped function with it if is actually present. After all, the variable will still be nil even if nil isn't passed.

view details

Henrik Lissner

commit sha 7afb09da73aa31267a96bdbd87823fb4d98f2860

Merge pull request #5232 from samrjack/fix-pdf-blocking-issue Prevent extra variable from being passed in macro.

view details

Patrick Wulfe

commit sha c091b27e4a6485ce630fb6bfc257080271cb752e

Made changes specified in pull request

view details

ErnestDong

commit sha 8c3a83526b6d09b438eb38eedb3d1e5dff240d17

Filter directories when purging straight repos in macOS there is always an annoying ".DS_Store" in straight/repos, which breaks `doom purge`

view details

Henrik Lissner

commit sha ff2d56794e6c0c3228c7c9ab6c71b6abcd33cfa2

Don't activate sly-mode in lisp-mode derived modes Fixes some issues (like indentation or unrelated sly-mode warnings) in lisp-like major modes (like fennel-mode).

view details

Henrik Lissner

commit sha 044a1a5f2b30476357548d025f7d13b42876467e

Drop Emacs 26.x support Emacs 27.x has been the stable version of Emacs for nearly a year, and introduces a litany of bugfixes, performance, and quality-of-life improvements that significantly reduce Doom's maintenance burden (like XDG support, early-init.el, image manipulation without imagemagick, a native JSON library, harfbuzz support, pdumper, and others). With so many big changes on Doom's horizon, I like having one less (big) thing to worry about. Also reverts bb677cf7a (#5232) as it is no longer needed.

view details

Henrik Lissner

commit sha 38bc1ab81af6cdc4c4fb9aa163bb44711969af36

Bump :tools pdf vedang/pdf-tools@d262cf9 -> vedang/pdf-tools@5f77dae Fixes #4989: remove local hacks for retina support in favor of upstream fixes.

view details

Henrik Lissner

commit sha 9198b03807b53ee255d52a3a2328f40f84d6cb5a

Bump :core bbatsov/projectile@5e6fdab -> bbatsov/projectile@da08a91 domtronn/all-the-icons.el@facbde4 -> domtronn/all-the-icons.el@9d97c07 justbur/emacs-which-key@fc29864 -> justbur/emacs-which-key@27d9fec raxod502/straight.el@915707f -> raxod502/straight.el@b45dd00

view details

Henrik Lissner

commit sha 19edcb931458e27255301f97279686fecab54abe

Change doom-version to 3.0.0-alpha The future is now.

view details

push time in 3 months

push eventholyfight6/doom-emacs

push time in 3 months