profile
viewpoint
Yuta Hiroto hiroppy recruiters: don't email me Tokyo / Japan https://hiroppy.me Working on @nodejs, @webpack, @babel and @whatwg.😼

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 6a26cc6472f33bb2d6b982b836af6f7ab90d9918

chore: feedback

view details

push time in an hour

pull request commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

Need to wait for resolving this issue. https://github.com/actions/setup-node/issues/132

hiroppy

comment created time in 11 hours

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 7b0a25a9b47e8923919b53ddd76c50265b994709

chore: feedback

view details

push time in 11 hours

push eventwebpack/webpack-dev-middleware

renovate[bot]

commit sha 43a928f6b3f37e239d1f1056578cea1ce4b07d99

chore(deps): update all patch dependencies (#608) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yuta Hiroto

commit sha 9a665ec8d5b19dc49118d08d60505e9419190c8c

chore(deps): update jest

view details

Yuta Hiroto

commit sha aa950a532e450f9c1d92632fa595ff561b8490b1

chore: migrate to github-actions

view details

Yuta Hiroto

commit sha c331bfb26a4aa2726f33c2e10128d4e1056c7c7d

test: don't use fixed values

view details

Yuta Hiroto

commit sha 5c71feee89736143b31316b41a7c4f59332c2b45

chore: feedback

view details

push time in 11 hours

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 36e4c57547525d077395756470abfc4ee5cff93e

chore: feedback

view details

push time in 11 hours

Pull request review commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

+name: test++on: [push]++jobs:+  test:+    runs-on: ${{ matrix.os }}+    strategy:+      matrix:+        os: [macos-latest, windows-latest, ubuntu-latest]+        node-version: [13.x, 12.x, 10.x]+        webpack-version: [next, 4]+        exclude:+          - node-version: 13.x+            webpack-version: 4+          - node-version: 12.x+            webpack-version: 4

Screen Shot 2020-04-06 at 21 50 17

So you want to change these tests cases?

hiroppy

comment created time in 12 hours

Pull request review commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

+name: linter++on: [push]++env:+  NODE_VERSION: 10.x++jobs:+  linter:+    runs-on: ubuntu-latest

sorry I can't understand. you can use the suggestion feature.

hiroppy

comment created time in 12 hours

Pull request review commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

+name: test++on: [push]

why do you want to specify the two branches?

hiroppy

comment created time in 12 hours

Pull request review commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

+name: linter++on: [push]++env:+  NODE_VERSION: 10.x++jobs:+  linter:+    runs-on: ubuntu-latest

run-on is specified os version.

hiroppy

comment created time in 12 hours

Pull request review commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

+name: test++on: [push]++jobs:+  test:+    runs-on: ${{ matrix.os }}+    strategy:+      matrix:+        os: [macos-latest, windows-latest, ubuntu-latest]+        node-version: [13.x, 12.x, 10.x]+        webpack-version: [next, 4]+        exclude:+          - node-version: 13.x+            webpack-version: 4+          - node-version: 12.x+            webpack-version: 4

Do you know the exclude meaning? It is necessary.

hiroppy

comment created time in 12 hours

pull request commentwebpack/webpack-dev-middleware

refactor: refactor some code

@evilebottnawi This pr has already been done. Please review. https://github.com/webpack/webpack-dev-middleware/pull/611

hiroppy

comment created time in 12 hours

push eventwebpack/webpack-dev-server

renovate[bot]

commit sha c4360589b5b06471f8f649fcfa43d243e48a2f7b

chore(deps): update all patch dependencies (master) (patch) (#2503) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 12 hours

delete branch webpack/webpack-dev-server

delete branch : renovate/master-patch-all-patch-dependencies

delete time in 12 hours

PR merged webpack/webpack-dev-server

Reviewers
chore(deps): update all patch dependencies (master) (patch) renovate

This PR contains the following updates:

Package Type Update Change
lint-staged devDependencies patch ^10.1.1 -> ^10.1.2
spdy dependencies patch ^4.0.1 -> ^4.0.2

Release Notes

<details> <summary>okonet/lint-staged</summary>

v10.1.2

Compare Source

Bug Fixes
  • no longer include untracked files in backup stash (#​827) (2f15336)

</details>

<details> <summary>indutny/node-spdy</summary>

v4.0.2

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+17 -17

1 comment

2 changed files

renovate[bot]

pr closed time in 12 hours

pull request commentwebpack/webpack-dev-middleware

refactor: refactor some code

azure-pipeline seems not good. It can't download Node.js image.

https://dev.azure.com/webpack/webpack-dev-middleware/_build/results?buildId=9126&view=logs&j=1d505e51-909d-5717-0d5b-43f6a0bd49f6&t=d7ba6858-798d-59e4-3be2-6e44963833ea

hiroppy

comment created time in 12 hours

Pull request review commentwebpack/webpack-dev-middleware

refactor: refactor some code

 export default function wrapper(context) {       });     } -    const acceptedMethods = context.options.methods || ['GET', 'HEAD'];--    if (acceptedMethods.indexOf(req.method) === -1) {-      return goNext();-    }--    return new Promise((resolve) => {-      // eslint-disable-next-line consistent-return-      function processRequest() {-        const filename = getFilenameFromUrl(context, req.url);--        if (!filename) {-          return resolve(goNext());-        }+    async function processRequest() {+      const filename = getFilenameFromUrl(context, req.url);+      const { headers } = context.options;+      let content; -        let content;+      if (!filename) {+        await goNext();+        return;+      } -        try {-          content = context.outputFileSystem.readFileSync(filename);-        } catch (_ignoreError) {-          return resolve(goNext());-        }+      try {+        content = context.outputFileSystem.readFileSync(filename);+      } catch (_ignoreError) {+        await goNext();+        return;+      } -        content = handleRangeHeaders(content, req, res);+      content = handleRangeHeaders(content, req, res); -        if (!res.get('Content-Type')) {-          const contentType = mime.contentType(path.extname(filename));+      if (!res.get('Content-Type')) {+        const contentType = mime.contentType(path.extname(filename)); -          if (contentType) {-            res.set('Content-Type', contentType);-          }+        if (contentType) {+          res.set('Content-Type', contentType);         }+      } -        const { headers } = context.options;--        if (headers) {-          for (const name in headers) {-            if ({}.hasOwnProperty.call(headers, name)) {-              res.set(name, context.options.headers[name]);-            }+      if (headers) {+        for (const name in headers) {+          if (Reflect.has(headers, name)) {+            res.set(name, headers[name]);           }         }--        res.send(content);--        resolve();       } -      ready(context, processRequest, req);-    });+      res.send(content);+    }

If you have points which are hard to read for you, please tell me.

hiroppy

comment created time in 12 hours

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha b00706082489bb494561a897a0296db60a8d1c46

refactor: feedback

view details

push time in 12 hours

Pull request review commentwebpack/webpack-dev-middleware

refactor: refactor some code

 export default function wrapper(context) {       });     } -    const acceptedMethods = context.options.methods || ['GET', 'HEAD'];--    if (acceptedMethods.indexOf(req.method) === -1) {-      return goNext();-    }--    return new Promise((resolve) => {-      // eslint-disable-next-line consistent-return-      function processRequest() {-        const filename = getFilenameFromUrl(context, req.url);--        if (!filename) {-          return resolve(goNext());-        }+    async function processRequest() {+      const filename = getFilenameFromUrl(context, req.url);+      const { headers } = context.options;+      let content; -        let content;+      if (!filename) {+        await goNext();+        return;+      } -        try {-          content = context.outputFileSystem.readFileSync(filename);-        } catch (_ignoreError) {-          return resolve(goNext());-        }+      try {+        content = context.outputFileSystem.readFileSync(filename);+      } catch (_ignoreError) {+        await goNext();+        return;+      } -        content = handleRangeHeaders(content, req, res);+      content = handleRangeHeaders(content, req, res); -        if (!res.get('Content-Type')) {-          const contentType = mime.contentType(path.extname(filename));+      if (!res.get('Content-Type')) {+        const contentType = mime.contentType(path.extname(filename)); -          if (contentType) {-            res.set('Content-Type', contentType);-          }+        if (contentType) {+          res.set('Content-Type', contentType);         }+      } -        const { headers } = context.options;--        if (headers) {-          for (const name in headers) {-            if ({}.hasOwnProperty.call(headers, name)) {-              res.set(name, context.options.headers[name]);-            }+      if (headers) {+        for (const name in headers) {+          if (Reflect.has(headers, name)) {

Actually, this code is unnecessary. I updated.

hiroppy

comment created time in 12 hours

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 44a5ebfb95fa5e78864a2edcccc7f273c43cd1be

refactor: feedback

view details

push time in 12 hours

Pull request review commentwebpack/webpack-dev-middleware

refactor: refactor some code

 export default function wrapper(context) {       });     } -    const acceptedMethods = context.options.methods || ['GET', 'HEAD'];--    if (acceptedMethods.indexOf(req.method) === -1) {-      return goNext();-    }--    return new Promise((resolve) => {-      // eslint-disable-next-line consistent-return-      function processRequest() {-        const filename = getFilenameFromUrl(context, req.url);--        if (!filename) {-          return resolve(goNext());-        }+    async function processRequest() {+      const filename = getFilenameFromUrl(context, req.url);+      const { headers } = context.options;+      let content; -        let content;+      if (!filename) {+        await goNext();+        return;+      } -        try {-          content = context.outputFileSystem.readFileSync(filename);-        } catch (_ignoreError) {-          return resolve(goNext());-        }+      try {+        content = context.outputFileSystem.readFileSync(filename);+      } catch (_ignoreError) {+        await goNext();+        return;+      } -        content = handleRangeHeaders(content, req, res);+      content = handleRangeHeaders(content, req, res); -        if (!res.get('Content-Type')) {-          const contentType = mime.contentType(path.extname(filename));+      if (!res.get('Content-Type')) {+        const contentType = mime.contentType(path.extname(filename)); -          if (contentType) {-            res.set('Content-Type', contentType);-          }+        if (contentType) {+          res.set('Content-Type', contentType);         }+      } -        const { headers } = context.options;--        if (headers) {-          for (const name in headers) {-            if ({}.hasOwnProperty.call(headers, name)) {-              res.set(name, context.options.headers[name]);-            }+      if (headers) {+        for (const name in headers) {+          if (Reflect.has(headers, name)) {

{}.hasOwnProperty.call(headers, name) is very poorly readable.

hiroppy

comment created time in 14 hours

Pull request review commentwebpack/webpack-dev-middleware

refactor: refactor some code

 export default function wrapper(context) {       });     } -    const acceptedMethods = context.options.methods || ['GET', 'HEAD'];--    if (acceptedMethods.indexOf(req.method) === -1) {-      return goNext();-    }--    return new Promise((resolve) => {-      // eslint-disable-next-line consistent-return-      function processRequest() {-        const filename = getFilenameFromUrl(context, req.url);--        if (!filename) {-          return resolve(goNext());-        }+    async function processRequest() {+      const filename = getFilenameFromUrl(context, req.url);+      const { headers } = context.options;+      let content; -        let content;+      if (!filename) {+        await goNext();+        return;+      } -        try {-          content = context.outputFileSystem.readFileSync(filename);-        } catch (_ignoreError) {-          return resolve(goNext());-        }+      try {+        content = context.outputFileSystem.readFileSync(filename);+      } catch (_ignoreError) {+        await goNext();+        return;+      } -        content = handleRangeHeaders(content, req, res);+      content = handleRangeHeaders(content, req, res); -        if (!res.get('Content-Type')) {-          const contentType = mime.contentType(path.extname(filename));+      if (!res.get('Content-Type')) {+        const contentType = mime.contentType(path.extname(filename)); -          if (contentType) {-            res.set('Content-Type', contentType);-          }+        if (contentType) {+          res.set('Content-Type', contentType);         }+      } -        const { headers } = context.options;--        if (headers) {-          for (const name in headers) {-            if ({}.hasOwnProperty.call(headers, name)) {-              res.set(name, context.options.headers[name]);-            }+      if (headers) {+        for (const name in headers) {+          if (Reflect.has(headers, name)) {+            res.set(name, headers[name]);           }         }--        res.send(content);--        resolve();       } -      ready(context, processRequest, req);-    });+      res.send(content);+    }

Could you give me a comment? So you mean move res.send(content); to prev position?

hiroppy

comment created time in 14 hours

Pull request review commentwebpack/webpack-dev-middleware

refactor: refactor some code

 export default function wrapper(context) {       });     } -    const acceptedMethods = context.options.methods || ['GET', 'HEAD'];--    if (acceptedMethods.indexOf(req.method) === -1) {-      return goNext();-    }--    return new Promise((resolve) => {-      // eslint-disable-next-line consistent-return-      function processRequest() {-        const filename = getFilenameFromUrl(context, req.url);--        if (!filename) {-          return resolve(goNext());-        }+    async function processRequest() {+      const filename = getFilenameFromUrl(context, req.url);+      const { headers } = context.options;+      let content; -        let content;+      if (!filename) {+        await goNext();+        return;+      } -        try {-          content = context.outputFileSystem.readFileSync(filename);-        } catch (_ignoreError) {-          return resolve(goNext());-        }+      try {+        content = context.outputFileSystem.readFileSync(filename);+      } catch (_ignoreError) {+        await goNext();+        return;+      } -        content = handleRangeHeaders(content, req, res);+      content = handleRangeHeaders(content, req, res); -        if (!res.get('Content-Type')) {-          const contentType = mime.contentType(path.extname(filename));+      if (!res.get('Content-Type')) {+        const contentType = mime.contentType(path.extname(filename)); -          if (contentType) {-            res.set('Content-Type', contentType);-          }+        if (contentType) {+          res.set('Content-Type', contentType);         }+      } -        const { headers } = context.options;--        if (headers) {-          for (const name in headers) {-            if ({}.hasOwnProperty.call(headers, name)) {-              res.set(name, context.options.headers[name]);-            }+      if (headers) {+        for (const name in headers) {+          if (Reflect.has(headers, name)) {

Why?

hiroppy

comment created time in 15 hours

push eventwebpack/webpack-dev-middleware

renovate[bot]

commit sha 43a928f6b3f37e239d1f1056578cea1ce4b07d99

chore(deps): update all patch dependencies (#608) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yuta Hiroto

commit sha 7a68e7345fdadf7505963db1537c240c09e4c4ba

Merge branch 'master' into feature/refactor-code

view details

push time in 15 hours

PR opened webpack/webpack-dev-middleware

Reviewers
refactor: refactor some code

<!-- HOLY CRAP a Pull Request. We ❤️ those!

If you remove or skip this template, you'll make the 🐼 sad and the mighty god of Github will appear and pile-drive the close button from a great height while making animal noises.

Please place an x (no spaces!) in all [ ] that apply -->

This PR contains a:

  • [ ] bugfix
  • [ ] new feature
  • [x] code refactor
  • [ ] test update <!-- if bug or feature is checked, this should be too -->
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

Improve readability.

<!-- Please explain the motivation or use-case for your change. What existing problem does the PR solve? If this PR addresses an issue, please link to the issue. -->

Breaking Changes

no

<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Additional Info

+52 -54

0 comment

6 changed files

pr created time in 15 hours

create barnchwebpack/webpack-dev-middleware

branch : feature/refactor-code

created branch time in 15 hours

issue closedexpressjs/express

[Performance Investigation] Compare es5 and es2015

First of all, thank you for maintaining Express.

This issue is just investigation, so please close it freely. Currently, Express is written in es5, but I thought to want to know the performance if Express is rewritten in es2015. I thought that it would be good if it would be helpful for your future plans, so I submitted this issue.

Condition

  • just used const, let, arrow functions, template literals, and class, and didn't use Promise
  • Node.js v6 or lower is out of scope because it is End-of-Life
    • https://github.com/nodejs/Release#release-schedule
  • ran benchmark three times and calculated the average value

code: ad1f46dbc103fa1ec39d748de9f7ff6d2a317623

Result

Node version branch 1(middleware) 5 10 15 20 30 50 100
12.2.0 master 9146.71 9214.94 9272.59 8011.20 8433.19 8617.55 7795.66 7037.85
12.2.0 es2015 8627.45 8714.08 8679.19 8981.91 8666.40 8123.18 8055.69 7547.16
10.15.3 master 9507.00 7561.25 7933.38 8440.16 8390.18 7037.11 7939.60 6915.03
10.15.3 es2015 9052.08 7785.81 7438.94 8600.42 8637.91 8459.80 8188.28 6515.97
8.16.0 master 7465.29 7534.43 8374.32 6821.92 7851.89 7049.46 6393.43 5233.66
8.16.0 es2015 8386.78 8291.34 7935.76 8146.73 7290.05 7605.94 7106.32 5665.79

See gist for more detail.

I thought the syntax of es2015 may be better for future versions of Node.js. In addition, Node.js core has already used es2015 or more, and also uses async / await. If you want to support Node.js v6 or less even in the next version for backward compatibility, I recommend using babel or typescript.


I hope that this result is useful for something. If you want to use core code written in es2015, please tell me. Of course, I would like to cooperate:)

Thanks.

closed time in 21 hours

hiroppy

issue commentexpressjs/express

[Performance Investigation] Compare es5 and es2015

OK, I thought refactoring to es2015(currently, es2019) does not seem to be a high priority for Express team. I closed.

hiroppy

comment created time in 21 hours

pull request commentwebpack/webpack-dev-middleware

feat: add webpack bot for trigger documentation issue

Please submit as an issue at first, because our team doesn't know this thing.

jeffin143

comment created time in a day

PR closed webpack/webpack-dev-server

Reviewers
fix: check if serverData object exist

<!-- Thank you for submitting a pull request!

Please note that this template is not optional and all ALL fields must be filled out, or your pull request may be rejected.

Please do not delete this template. Please do remove this header to acknowledge this message.

Please place an x, no spaces, in all [ ] that apply -->

  • [x] This is a bugfix
  • [ ] This is a feature
  • [ ] This is a code refactor
  • [ ] This is a test update
  • [ ] This is a docs update
  • [ ] This is a metadata update

For Bugs and Features; did you add new tests?

<!-- Please note that we won't approve your changes if you don't add tests. -->

Motivation / Use-Case

https://github.com/webpack/webpack-dev-server/issues/1479#issuecomment-549831416

This is just a minor patch

<!-- What existing problem does the pull request solve?

Please explain the motivation or use-case for making this change. If this Pull Request addresses an issue, please link to the issue. -->

Breaking Changes

None <!-- If this PR introduces a breaking change, please describe the impact and a potential migration path for existing applications. -->

Additional Info

Nothing

+1 -1

2 comments

1 changed file

jeffin143

pr closed time in a day

pull request commentwebpack/webpack-dev-server

fix: check if serverData object exist

This is an internal function and this argument always exists.

jeffin143

comment created time in a day

pull request commentwebpack/webpack-dev-middleware

feat: add webpack bot for trigger documentation issue

@jeffin143 How did you debug this? I'm wondering how you debugged this because we need to set up the infrastructure.

jeffin143

comment created time in a day

pull request commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

I'll modify github's setting of branch settings.

hiroppy

comment created time in a day

pull request commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

CI is green.

hiroppy

comment created time in a day

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 5fa0e87f885292d6fd18ed84ab9a8c29b61f82ad

chore: migrate to github-actions

view details

Yuta Hiroto

commit sha 1cd0835bcdde40adf9fd9728d24f05e68dc744a1

test: don't use fixed values

view details

push time in a day

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 4e6c9daf94c15b9e5b226fffbd14e20745301bec

chore: migrate to github-actions

view details

Yuta Hiroto

commit sha fc8136a4572753a8820020e021457393a6a9d362

test: don't use fixed values

view details

push time in a day

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha f5f8c09165fd14bb78f666f5d2f6104c8e018159

test: don't use fixed values

view details

push time in a day

pull request commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

I'll refactor tests after merging this pr.

hiroppy

comment created time in 2 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha aab42295f986feda5d4f3ee44bffb7ecf723cb6e

wip

view details

push time in 2 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 5b63a682dbca5f15a2382e82d62213a74c354cdd

wip

view details

push time in 2 days

PR opened webpack/webpack.js.org

fix(configuration): fix filename from webpack.config.js to someLibName.js

describe your changes...

  • [ ] Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • [ ] Make sure your PR complies with the writer's guide.
  • [ ] Review the diff carefully as sometimes this can reveal issues.
  • [ ] Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.
+2 -1

0 comment

1 changed file

pr created time in 2 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha f96fd16b87d5d88e1964bd969a40b0589257e1ff

wip

view details

push time in 2 days

pull request commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

windows CIs seem flaky, need to investigate.

hiroppy

comment created time in 2 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha a38fa857e641bfca22621b2e526dac388e7fb321

chore(deps): update jest

view details

Yuta Hiroto

commit sha 5a16ee958e16b00ebdde32f33e4297878665e66b

chore(deps): update some deps

view details

Yuta Hiroto

commit sha 65bac2ecbe9cc2e0691c8e749d96c6a5fbc1fb7f

chore: migrate to github-actions

view details

push time in 2 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 44dc5d26f4f0428dc4ff07bd13945352e0cadd5d

po

view details

push time in 2 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha f8be25a6cc26e69092bf037ad928c97517f1ae20

wip

view details

push time in 2 days

pull request commentwebpack/webpack-dev-middleware

chore: migrate to github-actions

Added CODECOV_TOKEN to settings/secret.

hiroppy

comment created time in 2 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha eea9568844954a70cf5f48d900d7d61721a5deba

wip

view details

push time in 2 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 99fdaba71b9e93d2bd6380e46125542d31ac6fb1

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha eb68cd4bb3dab0798986057886cc977a1027b203

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 2be4a483e615093277e494442f9385fd20f52db8

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 67bf8c97fc19500968cfaf248936c9c590f08671

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 34046d2d48ca6c2685f0149afe7119ec3de4ae79

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 310b846a02d22c0d2095a3640f84d6352f4ed19e

wip

view details

push time in 3 days

pull request commentwebpack/webpack-dev-middleware

test(middleware): use setImmediate for MacOS CI

When we use only MacOSnode-10-v4, CI will be succeed but when all CIs runs, MacOSnode-10-v4 will be failed 🤔

hiroppy

comment created time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha cbb48a027d1831a0e3aafbd8a503adef0417777c

test(middleware): use setImmediate for MacOS CI

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha c3623029e21a14966a82aab39559e1a914cb41df

test(middleware): use setImmediate for MacOS CI

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 7653c9f2679b4945935bdbb265f676a75283df64

wiup

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha b5d37c4cedbc73efcd0777c4613915cb9cdb3562

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha a62c949c587bc7cd2e51b4ead07b1ced0eca075b

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha cf6f4f0e26a772ec6fd3d7bbc5839f8ea2df6601

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha b1492ae614f37676c18ab418bfe5ecc6f10e4592

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 0a8cdf82e47f3e8d2aba1cd1f058383e269c2643

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 17bdbf3843e2f2b8c0b49c29b1443ba69ee1e5ef

wip

view details

push time in 3 days

Pull request review commentwebpack/webpack-dev-middleware

Investigate tests

 describe('middleware', () => {       });     }); -    describe('should work with difference requests', () => {+    describe.skip('should work with difference requests', () => {

This test causes.

hiroppy

comment created time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 40ff79e5ba7bdd7d2bfaba118ef833f3121d1bea

po

view details

push time in 3 days

pull request commentwebpack/webpack-dev-middleware

Investigate tests

Anyway, I'll resolve this problem and then I'll refactor many things.

hiroppy

comment created time in 3 days

pull request commentwebpack/webpack-dev-middleware

Investigate tests

Actually I want to move to github CI:)

hiroppy

comment created time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 2ff28d8213431cc16f7e489d4e7b329ca3d44fdc

wip

view details

Yuta Hiroto

commit sha 99b2c838227a63b74c58bb3875f81a1e173a4bc1

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 56bdc6b3ba4b0357299a68cb8b21db00e69cfafc

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 69ebe097396f39f042127038b06b3a447ad82c21

wip wip wip wip wip wip wip wip wip a a

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha c3816e62f00f46ddd2407bc90e4fa38f120dddbd

a

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 3f21a3d0864897ed9f109ddb58d258e0913f148c

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 742118ebadd72ccd3b78643db8155c4acdb25207

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 1b1c8b90801d6ac8510c9fc061a579c5d9718f3c

wip

view details

push time in 3 days

pull request commentwebpack/webpack-dev-middleware

Investigate tests

CI is green when I specify to comment out some places.

hiroppy

comment created time in 3 days

pull request commentwebpack/webpack-dev-middleware

Investigate tests

Yes, I know but when you skip https://github.com/webpack/webpack-dev-middleware/blob/master/test/middleware.test.js#L29, you will be able to see this error(https://github.com/webpack/webpack-dev-middleware/pull/611#issuecomment-608465254).

hiroppy

comment created time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha b66391207396662a024c300bbabf3c9cc9ad9674

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 34497042396172b556e70c73931612f246cd527c

wip

view details

push time in 3 days

pull request commentwebpack/webpack-dev-middleware

Investigate tests

Maybe this one. https://github.com/webpack/watchpack/issues/118

hiroppy

comment created time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 95740d7a882c6cded9ad47277a207389a2a764dd

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha ec29cbb92261fd6cf541c43105ec5b4cc993f145

wip

view details

push time in 3 days

pull request commentwebpack/webpack-dev-middleware

Investigate tests

I can't resolve this issue but a turning point is here. https://github.com/webpack/webpack-dev-middleware/commit/23a700ab01be3ff27c93419705ccc4b9c4f90565

hiroppy

comment created time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha 01a2022cf0b0f19b4560a6780e772ebc37e60ba5

wip

view details

push time in 3 days

push eventwebpack/webpack-dev-middleware

Yuta Hiroto

commit sha a99643d536f33ec3503cc4b9531fab12adcee356

wip

view details

push time in 3 days

PR opened webpack/webpack-dev-middleware

Investigate tests

<!-- HOLY CRAP a Pull Request. We ❤️ those!

If you remove or skip this template, you'll make the 🐼 sad and the mighty god of Github will appear and pile-drive the close button from a great height while making animal noises.

Please place an x (no spaces!) in all [ ] that apply -->

This PR contains a:

  • [ ] bugfix
  • [ ] new feature
  • [ ] code refactor
  • [ ] test update <!-- if bug or feature is checked, this should be too -->
  • [ ] typo fix
  • [ ] metadata update

Motivation / Use-Case

<!-- Please explain the motivation or use-case for your change. What existing problem does the PR solve? If this PR addresses an issue, please link to the issue. -->

Breaking Changes

<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->

Additional Info

+2571 -643

0 comment

2 changed files

pr created time in 3 days

create barnchwebpack/webpack-dev-middleware

branch : feature/modify-tests

created branch time in 3 days

pull request commentwebpack/webpack-dev-middleware

chore(deps): update all patch dependencies (patch)

My local is MacOS but I can't reproduce every time.

renovate[bot]

comment created time in 4 days

pull request commentwebpack/webpack-dev-middleware

chore(deps): update all patch dependencies (patch)

I can reproduce this issue and I investigated this.

The tests like below are sometimes broken. (they can't finish and I don't know how to fix... maybe we need to investigate more time)

https://github.com/webpack/webpack-dev-middleware/blob/master/test/middleware.test.js#L120

renovate[bot]

comment created time in 4 days

pull request commentwebpack/webpack-dev-server

feat: add invalidate endpoint

@evilebottnawi Totally agree with you. I'll improve these codes on the next branch.

EslamHiko

comment created time in 4 days

pull request commentwebpack/webpack-dev-server

feat: add invalidate endpoint

I got it but it's hard to read for me like a black box.

EslamHiko

comment created time in 4 days

push eventwebpack/webpack-dev-server

Yuta Hiroto

commit sha 4808abd434bac0511da688aee861f7e2d8b0c81c

feat(progess): emit progress-update (#2498) closes: #1666

view details

push time in 4 days

delete branch webpack/webpack-dev-server

delete branch : feature/emit-progress-update

delete time in 4 days

PR merged webpack/webpack-dev-server

Reviewers
feat(progess): emit progress-update

closes: #1666

<!-- Thank you for submitting a pull request!

Please note that this template is not optional and all ALL fields must be filled out, or your pull request may be rejected.

Please do not delete this template. Please do remove this header to acknowledge this message.

Please place an x, no spaces, in all [ ] that apply -->

  • [ ] This is a bugfix
  • [x] This is a feature
  • [ ] This is a code refactor
  • [ ] This is a test update
  • [ ] This is a docs update
  • [ ] This is a metadata update

For Bugs and Features; did you add new tests?

yes

<!-- Please note that we won't approve your changes if you don't add tests. -->

Motivation / Use-Case

Emit progress-update event.

<!-- What existing problem does the pull request solve?

Please explain the motivation or use-case for making this change. If this Pull Request addresses an issue, please link to the issue. -->

Breaking Changes

no

<!-- If this PR introduces a breaking change, please describe the impact and a potential migration path for existing applications. -->

Additional Info

+17 -5

1 comment

3 changed files

hiroppy

pr closed time in 4 days

PR closed webpack/webpack-dev-server

Reviewers
Emit progress-update event on the listeningApp, allowing update progress to be obtained in the node API. need tests
  • [ ] This is a bugfix
  • [x] This is a feature
  • [ ] This is a code refactor
  • [ ] This is a test update
  • [ ] This is a docs update
  • [ ] This is a metadata update

For Bugs and Features; did you add new tests?

<!-- Please note that we won't approve your changes if you don't add tests. -->

Motivation / Use-Case

<!-- What existing problem does the pull request solve?

Please explain the motivation or use-case for making this change. If this Pull Request addresses an issue, please link to the issue. -->

Breaking Changes

<!-- If this PR introduces a breaking change, please describe the impact and a potential migration path for existing applications. -->

Additional Info

Just like in the browser, we can now get the compilation progress of the current project in the node API.

new webpackDevServer(webpack, config).listen(port, hostname, function (err) {
  this.on('progress-update', ({ percent, msg }) => {
    console.log(`${percent}% - ${msg}.`);
  });
});
+4 -0

4 comments

1 changed file

pfdgithub

pr closed time in 4 days

pull request commentwebpack/webpack-dev-server

chore(deps): update dependency file-loader to v6 (master)

file-loader is used only samples. I think it's ok.

renovate[bot]

comment created time in 4 days

Pull request review commentwebpack/webpack-dev-server

feat(progess): emit progress-update

 class Server {       }        this.sockWrite(this.sockets, 'progress-update', { percent, msg });++      if (this.listeningApp) {+        this.listeningApp.emit('progress-update', { percent, msg });+      }

We need this condition because this.setupProgressPlugin is called before this.createServer.

hiroppy

comment created time in 4 days

issue openedwebpack/webpack-dev-server

some tests are flaky on CI

<!-- Please note that this template is not optional. Please fill out ALL fields, or your issue may be closed as "invalid." Please do not delete this template. Please ask questions on StackOverflow or Gitter (https://gitter.im/webpack/webpack). General questions, how-to questions, and support requests will be closed. -->

  • Operating System:
  • Node Version:
  • NPM Version:
  • webpack Version:
  • webpack-dev-server Version:
  • Browser:

<!-- Please place an x, no spaces, in all [ ] that apply Please note that we are NOT accepting FEATURE requests at this time. -->

  • [x] This is a bug
  • [ ] This is a modification request

Code

N/A

<!-- If you have a large amount of code to share which demonstrates the problem you're experiencing, or your webpack config is very large, please provide a link to your repository rather than pasting code. We'd also encourage you to use a Github Gist link instead of pasting code. Otherwise, please paste relevant short snippets below.

For bugs, please do consider providing a link to a stripped-down, bare-bones repo that can reproduce the problem you're experiencing. Many times, bugs aren't actual bugs, but rather specific issues with loaders, plugins, or an environment/OS. Problems with complicated or large applications will almost always require this to be triaged. -->

Expected Behavior

Green

Actual Behavior

Especially e2e tests aren't stable.

For Bugs; How can we reproduce the behavior?

See CI.

For Features; What is the motivation and/or use-case for the feature?

Maybe the next version will be stable because I modified many tests to improve but I monitor this issue.

created time in 4 days

Pull request review commentwebpack/webpack-dev-server

feat(progess): emit progress-update

 module.exports = class WebsocketServer extends BaseServer {     const noop = () => {};      setInterval(() => {-      this.wsServer.clients.forEach((ws) => {-        if (ws.isAlive === false) return ws.terminate();+      this.wsServer.clients.forEach((socket) => {

fixed by eslint

hiroppy

comment created time in 4 days

PR opened webpack/webpack-dev-server

Reviewers
feat(progess): emit progress-update

closes: #1666

<!-- Thank you for submitting a pull request!

Please note that this template is not optional and all ALL fields must be filled out, or your pull request may be rejected.

Please do not delete this template. Please do remove this header to acknowledge this message.

Please place an x, no spaces, in all [ ] that apply -->

  • [ ] This is a bugfix
  • [x] This is a feature
  • [ ] This is a code refactor
  • [ ] This is a test update
  • [ ] This is a docs update
  • [ ] This is a metadata update

For Bugs and Features; did you add new tests?

yes

<!-- Please note that we won't approve your changes if you don't add tests. -->

Motivation / Use-Case

Emit progress-update event.

<!-- What existing problem does the pull request solve?

Please explain the motivation or use-case for making this change. If this Pull Request addresses an issue, please link to the issue. -->

Breaking Changes

no

<!-- If this PR introduces a breaking change, please describe the impact and a potential migration path for existing applications. -->

Additional Info

+17 -5

0 comment

3 changed files

pr created time in 4 days

more