profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/hicom150/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

hicom150/airplayer 0

Query your local network for Apple TV's and have them play videos

hicom150/allure-karma 0

Allure adapter to karma test runner

hicom150/atoms 0

Atomic development

hicom150/botui 0

Robot User Interface for Kovan

hicom150/bower-nexus3-resolver 0

A custom Bower resolver to communicate with Nexus 3.

hicom150/bunyan-mqtt 0

A bunyan raw stream to publish to mqtt

hicom150/capture-website 0

Capture screenshots of websites

hicom150/capture-website-cli 0

Capture screenshots of websites from the command-line

push eventwebtorrent/webtorrent

Julen Garcia Leunda

commit sha 611ab1d2a1ec70eec9fea946676a02cfaccf581e

fix: handle done event when new files selected

view details

push time in a month

push eventwebtorrent/webtorrent

Julen Garcia Leunda

commit sha 21297db5517a1eccfbed2cdf59e620047c20a199

fix: handle done event when new files selected

view details

push time in a month

PR opened webtorrent/webtorrent

Fix done event when new files selected

<!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) Add a test to reproduce the issue and just a small change to mark the torrent.done as false when needed.

Which issue (if any) does this pull request address? This should fix https://github.com/webtorrent/webtorrent/issues/2170

Is there anything you'd like reviewers to focus on?

+68 -0

0 comment

2 changed files

pr created time in a month

push eventwebtorrent/webtorrent

Julen Garcia Leunda

commit sha 333b312948617e324c08e2075d0e496331e130f5

Fix done event when new files selected

view details

push time in a month

create barnchwebtorrent/webtorrent

branch : fix_done_event_when_new_files_selected

created branch time in a month

pull request commentwebtorrent/webtorrent

fix: ensure uTP peer address is IPv4

You are right about reusing https://github.com/mafintosh/utp-native code, but given that https://github.com/mafintosh/utp-native/blob/master/index.js#L9 nor https://github.com/mafintosh/utp-native/blob/master/index.js#L274 are exposed, I've fixed that by just copying the regex 😅

If in the future https://github.com/mafintosh/utp-native exposes this methods, we can easily refactor to use them 😉

hicom150

comment created time in 3 months

push eventwebtorrent/webtorrent

Julen Garcia Leunda

commit sha d521ca4704f66fa4f72402e8fd68bccce0560a07

fix: ensure uTP peer address is IPv4

view details

push time in 3 months

push eventwebtorrent/webtorrent

Julen Garcia Leunda

commit sha c8ba9b4f5be2e2448a4cf4d2e86797d3375f7b5c

fix: ensure uTP peer address is IPv4

view details

push time in 3 months

PR opened webtorrent/webtorrent

Ensure uTP peer address is IPv4

<!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) Check peer address to ensure it is a valid IPv4 when using uTP protocol.

Which issue (if any) does this pull request address? It should fix https://github.com/webtorrent/webtorrent/issues/2114

Is there anything you'd like reviewers to focus on? I've added an internal _isIPv4 method, just in case we want to replace its implementation with something different than https://github.com/sindresorhus/is-ip

+68 -3

0 comment

3 changed files

pr created time in 3 months

create barnchwebtorrent/webtorrent

branch : ensure_utp_peer_address_is_ipv4

created branch time in 3 months