profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/hi-se/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

hi-se/node-slack-sdk 0

Slack Developer Kit for Node.js

push eventsiiibo/shujinosuke

hi-se

commit sha d5efca8c753b186261b6fe6a538938403365f42a

feat: add meet url to terminate message (#28)

view details

push time in 3 days

delete branch siiibo/shujinosuke

delete branch : add_meet_url_to_terminate_message

delete time in 3 days

PR merged siiibo/shujinosuke

[feat] Add meet url to terminate message

https://siiibo.slack.com/archives/C0107S3RK24/p1624426225109300 であった要望への対応。

Google MeetのURLをterminateメッセージに追加。

+2 -1

0 comment

1 changed file

hi-se

pr closed time in 3 days

PR opened siiibo/shujinosuke

feat: add meet url to terminate message

https://siiibo.slack.com/archives/C0107S3RK24/p1624426225109300 であった要望への対応。

Google MeetのURLをterminateメッセージに追加。

+2 -1

0 comment

1 changed file

pr created time in 3 days

create barnchsiiibo/shujinosuke

branch : add_meet_url_to_terminate_message

created branch time in 3 days

push eventsiiibo/shujinosuke

hi-se

commit sha e390a121e638ab1ec6e3ef4076a318b6cf8a88d9

[fix] Change reminder condition (#25)

view details

push time in 3 days

delete branch siiibo/shujinosuke

delete branch : fix_reminder_condition

delete time in 3 days

PR merged siiibo/shujinosuke

[fix] Change reminder condition

リマインダーの条件に漏れがあり、終了処理が意図せぬタイミングで走ってしまうバグの修正。

+7 -6

1 comment

1 changed file

hi-se

pr closed time in 3 days

push eventsiiibo/shujinosuke

hi-se

commit sha ed16d8b475a373aab451821860f8f8990508826f

[chore] Upgrade dependencies (#26)

view details

hi-se

commit sha 38409a7cd02594f904f01a84253ddf3f5a806279

[fix] Change gha for clasp push (#27)

view details

hi-se

commit sha e00a5099038db8fee34f647e9b37dc931c8c58d8

Merge branch 'master' into fix_reminder_condition

view details

push time in 3 days

push eventsiiibo/shujinosuke

hi-se

commit sha 38409a7cd02594f904f01a84253ddf3f5a806279

[fix] Change gha for clasp push (#27)

view details

push time in 3 days

delete branch siiibo/shujinosuke

delete branch : fix_gha_for_clasp_push

delete time in 3 days

PR merged siiibo/shujinosuke

[fix] Change gha for clasp push

ed16d8b475a373aab451821860f8f8990508826f でclaspのアップデートをしたところ、GHA実行時に以下のエラーが発生。

$ /home/runner/work/shujinosuke/shujinosuke/node_modules/.bin/clasp push --force No valid .clasp.json project file. You may need to create or clone a project first. error Command failed with exit code 1.

上記エラーを解消するためのPR。

+2 -2

0 comment

1 changed file

hi-se

pr closed time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsiiibo/shujinosuke

[fix] Change gha for clasp push

 jobs:             "isLocalCreds": false           }           EOS-      - name: Create ~/.clasp.json+      - name: Create .clasp.json         run: |-          cat <<-EOS > ~/.clasp.json+          cat <<-EOS > $GITHUB_WORKSPACE/.clasp.json

.clasp.jsonをGitHubワークスペースディレクトリに置くことでエラー解消。

https://github.com/siiibo/shujinosuke/actions/runs/1081192857

hi-se

comment created time in 3 days

PR opened siiibo/shujinosuke

[fix] Change gha for clasp push

ed16d8b475a373aab451821860f8f8990508826f でclaspのアップデートをしたところ、GHA実行時に以下のエラーが発生。

$ /home/runner/work/shujinosuke/shujinosuke/node_modules/.bin/clasp push --force No valid .clasp.json project file. You may need to create or clone a project first. error Command failed with exit code 1.

上記エラーを解消するためのPR。

+2 -2

0 comment

1 changed file

pr created time in 3 days

push eventsiiibo/shujinosuke

hi-se

commit sha eaca51129963af5d147bbee9d1349179f0bdb839

fix: change how to write gha env

view details

push time in 3 days

push eventsiiibo/shujinosuke

hi-se

commit sha 52731ed47c3d5528edd1f7e5a24f14f4bdaded46

fix: change dir of .clasp.json

view details

push time in 3 days

create barnchsiiibo/shujinosuke

branch : fix_gha_for_clasp_push

created branch time in 3 days

delete branch siiibo/shujinosuke

delete branch : upgrade_dependencies

delete time in 3 days

create barnchsiiibo/shujinosuke

branch : upgrade_dependencies

created branch time in 3 days

push eventsiiibo/shujinosuke

hi-se

commit sha ed16d8b475a373aab451821860f8f8990508826f

[chore] Upgrade dependencies (#26)

view details

push time in 3 days

delete branch siiibo/shujinosuke

delete branch : upgrade_dependencies

delete time in 3 days

PR merged siiibo/shujinosuke

[chore] Upgrade dependencies

@slack/boltと@hi-se/web-apiのアップデートが主目的。 ライブラリのアップデートに伴ってコードを少し修正。

ついでに他のライブラリも最新のバージョンにアップデートした。

+1214 -945

0 comment

3 changed files

hi-se

pr closed time in 3 days

push eventsiiibo/shujinosuke

hi-se

commit sha 5e948140235d1565580aec396ae5276fc05626c8

chore: run yarn upgrade --latest

view details

push time in 3 days

PullRequestReviewEvent

Pull request review commentsiiibo/shujinosuke

[chore] Upgrade dependencies

 const sendReminderForJoin = async () => {   const client = getSlackClient();   const sessionChannelId = getSessionChannelId();   const channelState = getChannelState(sessionChannelId);-  const channelMembers = (await client.conversations.members({+  const channelMembers = client.conversations.members({     channel: sessionChannelId-  })).members.filter(userId => !exceptions.includes(userId));+  }).members.filter(userId => !exceptions.includes(userId));   const remindTargets = channelMembers.filter(userId => {     return (       !channelState.done.includes(userId) &&       !channelState.waiting.includes(userId)     )   });   remindTargets.forEach(async (remindTarget) => {-    if ((await client.users.getPresence({ user: remindTarget })).presence === 'active') {+    if (client.users.getPresence({ user: remindTarget }).presence === 'active') {

slack clientをGAS用に置き換えた際、不要なPromiseが残ってしまっていたためここでaync/awaitを利用していました。

https://github.com/hi-se/node-slack-sdk/commit/e5964bfe96bd27115a25d8b51a9fcacb45884d20 で対応したので、こちらも合わせて修正。

hi-se

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentsiiibo/shujinosuke

[chore] Upgrade dependencies

 const getChannelStateMessage = (channelId: string) => { const getListen = (client: SlackClient, event: SlackEvent) => {   switch (event.type) {     case 'app_mention':-      return (regExp: RegExp, callback: (client: SlackClient, event: GenericMessageEvent) => void) => {+      return (regExp: RegExp, callback: (client: SlackClient, event: AppMentionEvent) => void) => {         const messageContent = event.text.replace(/^<@\w+>\s*/, '');         if (messageContent.match(regExp)) {-          callback(client, event as unknown as GenericMessageEvent);+          callback(client, event as AppMentionEvent);         }       }   } }-const getThreadTs = (event: GenericMessageEvent | AppMentionEvent) => {+const getThreadTs = (event: AppMentionEvent) => {   return event.thread_ts ? event.thread_ts : event.ts; }   const handleSlackEvent = (client: SlackClient, event: SlackEvent) => {   switch (event.type) {     case 'app_mention':-      // 公式が提供しているAppMentionEvent型では足りないプロパティがあるためGenericMessageEvent型を利用している-      // see https://github.com/siiibo/shujinosuke/pull/16#discussion_r642349045-      handleAppMention(client, event as unknown as GenericMessageEvent);+      handleAppMention(client, event as AppMentionEvent);

以前AppMentionEventにeditedがない状況について、 @slack/bolt の issueにて拙い英語で質問したところ、バグだということで修正していただけました。(どうせなら自分で修正してプルリク投げれば良かった...)

GenericMessageEventを使う必要がなくなったので代用してた部分を全て修正。

hi-se

comment created time in 3 days

PR opened siiibo/shujinosuke

[chore] Upgrade dependencies

@slack/boltと@hi-se/web-apiのアップデートが主目的。 ライブラリのアップデートに伴ってコードを少し修正。

ついでに他のライブラリも最新のバージョンにアップデートした。

+1204 -927

0 comment

3 changed files

pr created time in 3 days