profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/hanami/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

hanami/hanami 5555

The web, with simplicity.

hanami/model 423

Ruby persistence framework with entities and repositories

hanami/router 331

Ruby/Rack HTTP router

hanami/api 284

Minimal, lightweight, fastest Ruby framework for HTTP APIs.

hanami/controller 226

Complete, fast and testable actions for Rack and Hanami

hanami/validations 206

Validation mixin for Ruby objects

hanami/utils 160

Ruby core extentions and class utilities for Hanami

hanami/view 145

Views, templates and presenters for Ruby web applications

hanami/hanami.github.io 89

Hanami website

hanami/hanami-2-application-template 81

Hanami 2 application starter template

startedhanami/hanami

started time in 6 hours

startedhanami/model

started time in 15 hours

startedhanami/hanami

started time in 15 hours

startedhanami/cli

started time in 16 hours

startedhanami/model

started time in 16 hours

push eventhanami/hanami

Tim Riley

commit sha 5750dd088b1a5d3ac28da0decbf15a50ae0af5bf

Port configuration to dry-configurable (#1107) Port `Hanami::Configuration` to dry-configurable. With this in place, dry-configurable-backed objects are used across all three of hanami, hanami-controller, and hanami-view. This makes `Hanami::Configuration` more manageable, with settings and their defaults now kept together instead of dotted across multiple places in the class. Along with this, make several other improvements to the configuration structure and behaviour: - The "missing configuration" objects for `actions` and `views` are now replaced with a proper `NullConfiguration` instance, which responds to `finalize!` even in the case of the action and view gems not being loaded (allowing us to remove a `respond_to?` hack in `Configuration#finalize!` - The handling of per-environment configuration is tightened up, with configuration for the current environment applied immediately (if applicable) instead of waiting for the configuration to be finalized - The logger configuration is pulled into a dedicated object, giving us a namespace for any router-related settings of behaviour in future. Right now it supports configuring the logger class and options separately (as before), as well as providing a pre-initialized router object. The `rack_logger_filter_params` setting has also moved into this namespace (for a future improvement, it would be nice to have this respected outside of the web apps, too) - Allows a preinitialized inflector to be provided via `config.inflector = my_inflector`, while still preserving the previous behaviour passing custom inflection rules only via `config.inflections(&block)` This change adds dry-configurable as an additional runtime dependency of hanami, but we're already requiring it transitively through dry-system anyway.

view details

Tim Riley

commit sha a7da1bdf32514f5cce1e29ec69fe61f0118e5881

Elide slice name from lib/ when autoloading

view details

Tim Riley

commit sha 03bed04f049c2f50cf9c15fba10f05cf510e135a

Detect component dirs inside slice

view details

push time in 19 hours

delete branch hanami/hanami

delete branch : enhancement/unstable/port-configuration-to-dry-configurable

delete time in 20 hours

push eventhanami/hanami

Tim Riley

commit sha 5750dd088b1a5d3ac28da0decbf15a50ae0af5bf

Port configuration to dry-configurable (#1107) Port `Hanami::Configuration` to dry-configurable. With this in place, dry-configurable-backed objects are used across all three of hanami, hanami-controller, and hanami-view. This makes `Hanami::Configuration` more manageable, with settings and their defaults now kept together instead of dotted across multiple places in the class. Along with this, make several other improvements to the configuration structure and behaviour: - The "missing configuration" objects for `actions` and `views` are now replaced with a proper `NullConfiguration` instance, which responds to `finalize!` even in the case of the action and view gems not being loaded (allowing us to remove a `respond_to?` hack in `Configuration#finalize!` - The handling of per-environment configuration is tightened up, with configuration for the current environment applied immediately (if applicable) instead of waiting for the configuration to be finalized - The logger configuration is pulled into a dedicated object, giving us a namespace for any router-related settings of behaviour in future. Right now it supports configuring the logger class and options separately (as before), as well as providing a pre-initialized router object. The `rack_logger_filter_params` setting has also moved into this namespace (for a future improvement, it would be nice to have this respected outside of the web apps, too) - Allows a preinitialized inflector to be provided via `config.inflector = my_inflector`, while still preserving the previous behaviour passing custom inflection rules only via `config.inflections(&block)` This change adds dry-configurable as an additional runtime dependency of hanami, but we're already requiring it transitively through dry-system anyway.

view details

push time in 20 hours

PR merged hanami/hanami

Reviewers
Port configuration to dry-configurable enhancement

In an effort to have consistent configuration objects across all the core hanami gems, this PR ports Hanami::Configuration to dry-configurable. With this in place, dry-configurable-backed objects are used across all three of hanami, hanami-controller, and hanami-view.

The resulting Hanami::Configuration object certainly feels much more manageable, with settings and their defaults now kept together instead sprawling across multiple places in the class.

Along with this, it makes several improvements:

  • The "missing configuration" objects for actions and views are now replaced with a proper NullConfiguration instance, which responds to finalize! even in the case of the action and view gems not being loaded (allowing us to remove a respond_to? hack in Configuration#finalize!
  • The handling of per-environment configuration is tightened up, with configuration for the current environment applied immediately (if applicable) instead of waiting for the configuration to be finalized
  • The logger configuration is pulled into a dedicated object, giving us a namespace for any router-related settings of behaviour in future. Right now it supports configuring the logger class and options separately (as before), as well as providing a pre-initialized router object. The rack_logger_filter_params setting has also moved into this namespace (for a future improvement, it would be nice to have this respected outside of the web apps, too)
  • Allows a preinitialized inflector to be provided via config.inflector = my_inflector, while still preserving the previous behaviour passing custom inflection rules only via config.inflections(&block)

This change does add dry-configurable as a runtime dependency of hanami, but given we're requiring it transitively already via dry-system, this feels fine to me.

This change relies upon the following PRs in dry-configurable, which I'd like to merge and release before merging this one:

  • Forward keyword args to initialize (https://github.com/dry-rb/dry-configurable/pull/113)
  • Remove implicit to_hash conversion from Config (https://github.com/dry-rb/dry-configurable/pull/114) - this will fix the tests that are breaking on 2.7
+468 -339

9 comments

25 changed files

timriley

pr closed time in 20 hours

pull request commenthanami/hanami

Port configuration to dry-configurable

Merging this one in a moment, but happy to continue the conversation, @jodosha, and tweak things in future :)

timriley

comment created time in 20 hours

Pull request review commenthanami/hanami

Port configuration to dry-configurable

 # frozen_string_literal: true +require "dry/configurable"+require_relative "../application/routing/resolver"+ module Hanami   class Configuration     # Hanami router configuration     #     # @since 2.0.0     # @api private     class Router-      # @api private-      # @since 2.0.0-      attr_writer :resolver+      include Dry::Configurable -      # @api private-      # @since 2.0.0-      def initialize(base_url)-        @base_url = base_url-      end+      # Base configuration is provided so router config can include the `base_url`+      attr_reader :base_configuration+      private :base_configuration        # @api private       # @since 2.0.0-      def resolver-        @resolver ||= begin-                        require_relative "../application/routing/resolver"-                        Application::Routing::Resolver-                      end+      def initialize(base_configuration)+        @base_configuration = base_configuration       end +      setting :routes_path, default: File.join("config", "routes")++      setting :routes_class_name, default: "Routes"++      setting :resolver, default: Application::Routing::Resolver+       # @api private       # @since 2.0.0       def options-        { base_url: @base_url }+        {base_url: base_configuration.base_url}

@jodosha Ah, now I remember another reason for this change.

If we pass only base_url into the Configuration::Router#initialize, then the router config will only ever see the value of base_url at that moment in time (i.e. when Hanami::Configuration itself is being initialized).

If, then, at any later point in time the user assigns their own new base_url (which is basically any time they assign it, given how early Configuration::Router is initialized), then the router config will not see it.

This is why we need to pass the whole base configuration object (since that object will never be replaced) rather than the base_url directly (which is an object that can and will be replaced).

timriley

comment created time in 20 hours

PullRequestReviewEvent

startedhanami/model

started time in 2 days

startedhanami/hanami-2-application-template

started time in 3 days

Pull request review commenthanami/hanami

Port configuration to dry-configurable

 # frozen_string_literal: true +require "dry/configurable"+require_relative "../application/routing/resolver"+ module Hanami   class Configuration     # Hanami router configuration     #     # @since 2.0.0     # @api private     class Router-      # @api private-      # @since 2.0.0-      attr_writer :resolver+      include Dry::Configurable -      # @api private-      # @since 2.0.0-      def initialize(base_url)-        @base_url = base_url-      end+      # Base configuration is provided so router config can include the `base_url`+      attr_reader :base_configuration+      private :base_configuration        # @api private       # @since 2.0.0-      def resolver-        @resolver ||= begin-                        require_relative "../application/routing/resolver"-                        Application::Routing::Resolver-                      end+      def initialize(base_configuration)+        @base_configuration = base_configuration       end +      setting :routes_path, default: File.join("config", "routes")++      setting :routes_class_name, default: "Routes"++      setting :resolver, default: Application::Routing::Resolver+       # @api private       # @since 2.0.0       def options-        { base_url: @base_url }+        {base_url: base_configuration.base_url}

Good question, Luca. Unfortunately enough time has passed that I don't know what exactly was on my mind when I made this change, haha, but I'm pretty sure the idea would have been about getting the boundaries right for when this routing config object might eventually be lifted out of the core hanami gem itself.

The idea here is that if the router config moved out (making routing a purely optional concern, something that the user could opt out of, or even replace with an alternative router providing Hanami integration), then the Hanami framework shouldn't be able to know specific details about the configuration needs of the router. To that end, the best we could do from the framework's side is to pass the whole base configuration object and let the external config (in this case, the router) use it for what it needs.

Does that make sense to you?

Of course, given the router config is entirely internal right now and will remain so for 2.0, this is a premature change, and one we could easily do later on, so I might switch this back to providing the base_url only before I merge.

Let me know what you think about the general idea, anyway :)

timriley

comment created time in 3 days

PullRequestReviewEvent

delete branch hanami/model

delete branch : depfu/update/rubocop-1.22.1

delete time in 3 days

PR closed hanami/model

Upgrade rubocop to version 1.22.1 depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.81 → 1.22.1) · Repo · Changelog

<details> <summary>Release Notes</summary> <p><em>Too many releases to show here. View the <a href="https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md">full release notes</a>.</em></p> </details>

<details> <summary>Commits</summary> <p><a href="https://github.com/rubocop/rubocop/compare/1bdcf65d88dcca526571bfc005af02a4f2695045...b5c9369aea2741877a93d8eaa4d57e16fc4c3be9">See the full diff on Github</a>. The new version differs by 14 commits:</p> <ul> <li><a href="https://github.com/rubocop/rubocop/commit/b5c9369aea2741877a93d8eaa4d57e16fc4c3be9"><code>Cut 1.22.1</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/ba81023c7589f97ff42a06dec3dbaab75a2b7da9"><code>Update Changelog</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/31ea6847cdd12e1269b57350104791d237e8ab3b"><code>[Fix #10145] Update Style/SelectByRegexp to ignore cases where the receiver appears to be a hash.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/a7ef72aa8c35336b169c5d78e2925fc27d739fcb"><code>[Fix #10148] Fix Style/QuotedSymbols handling escaped characters incorrectly.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/eba1d4d018d929a23ee73b005acb3687a1c4c33b"><code>Fix inconsistent capitalization of RuboCop.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/275a70b4286654b06154dbba259c10c1529d89e8"><code>Clarify documentation for Style/QuotedSymbols.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/1bed3ec0bbdfcd166b6246577d178b4b99f01b55"><code>Refine offense highlight range for Style/RedundantArgument</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/efcf741d688a12016fad4823fec7295903c11696"><code>Merge pull request #10146 from koic/fix_an_error_for_lint_require_relative_self_path</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/d26ec0cd6e665f3c38c3cbdac7c128e18705e7a1"><code>Merge pull request #10141 from dvandersluis/issue/10140</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/afa9bb5b7b8fc310a430018b33aa9e5cb166a348"><code>[Fix #10143] Fix an error for Lint/RequireRelativeSelfPath</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/ff42cfe24d9664fdb0b61937625654286932c076"><code>Minor update to changelog and release notes.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/b7a2f1d259a363bb3a7d89b6f99303edd41ac0dc"><code>[Fix #10140] Fix false positive for Layout/DotPosition when a heredoc receives a method on the same line as the start sigil in trailing style.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/502c606c6ddd7c1bbf6b2d07a9cd716071411de9"><code>Tweak a changelog entry</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/be8cc4c5823447918802c4670734b6a6fce7a456"><code>Switch back the docs version</code></a></li> </ul> </details>


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@​depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details>

+1 -1

1 comment

1 changed file

depfu[bot]

pr closed time in 3 days

pull request commenthanami/model

Upgrade rubocop to version 1.22.1

Closed in favor of #652.

depfu[bot]

comment created time in 3 days

PR opened hanami/model

Upgrade rubocop to version 1.22.2

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.81 → 1.22.2) · Repo · Changelog

<details> <summary>Release Notes</summary> <p><em>Too many releases to show here. View the <a href="https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md">full release notes</a>.</em></p> </details>

<details> <summary>Commits</summary> <p><a href="https://github.com/rubocop/rubocop/compare/b5c9369aea2741877a93d8eaa4d57e16fc4c3be9...60484a7bcf8fb240dada8db90e642a1b9baa8ca0">See the full diff on Github</a>. The new version differs by 33 commits:</p> <ul> <li><a href="https://github.com/rubocop/rubocop/commit/60484a7bcf8fb240dada8db90e642a1b9baa8ca0"><code>Cut 1.22.2</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/cc7ac48dfe4351cc2665ac46c4b62d307114023f"><code>Update Changelog</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/1d5621d031b1047fecddd3b9d2b74f02852e10c9"><code>Suppress warning: constant Net::HTTPServerException is deprecated</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/a319d09b0cadcc6f5fbb47fd53260b016868fd4d"><code>Updated Gemspec/RequiredRubyVersion register an offense when set to blank values.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/34ce2ed489e0228bbe57e911a9c6ed7aeb233b35"><code>[Fix #10200] Fix an error when inspecting a directory named *</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/5b27789b6c68ddb7292d247981ae2a71c7484f30"><code>[Fix #10186] Explicit block arg is not counted for Metrics/ParameterLists</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/189471786f93081be2432fb5abe62cf9c5c1aa28"><code>Merge pull request #10193 from koic/fix_an_error_for_empty_lines_around_exception_handling_keywords</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/95262d0628fde72c622a9591fcc242956862ea97"><code>Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/41f2632d22fb317f809f956c99f71e6cb9ffff0f"><code>Merge pull request #10187 from koic/fix_false_positive_for_lint_ambiguous_range</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/96457eee0db1212575025a2aac4c1fba90494f08"><code>[Fix #10185] Fix a false positive for Lint/AmbiguousRange</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/e9c339b7c27e49bf356f40caef2f05b13a31e5fe"><code>Merge pull request #10183 from koic/ci_against_jruby_9_3</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/2d6507f3b3d48ce3de1e1e3521a69289f37a93c9"><code>CI against JRuby 9.3</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/4ca072119f819f7425a162d08ef5025f554b839f"><code>Merge pull request #10181 from koic/fix_an_error_for_style_select_by_regexp</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/abcf9d390e99257d4a7282e1120006f19a8b5c3a"><code>[Fix #10180] Fix an error for Style/SelectByRegexp</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/512b771f88537996e65fdb571724bb67cdb7c6ab"><code>Merge pull request #10176 from koic/unmark_autocorrect_false_from_security_json_load</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/47be464d83b1eed39fbb9fa5eb62e5ef70ee112d"><code>Merge pull request #10177 from dvandersluis/issue/10172</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/42e8adf734b039fb9af6b9d2e1012005edd715b4"><code>Add documentation about rubocop-daemon.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/8c9692b500cc060070963d0990a93198d21704b3"><code>Unmark AutoCorrect: false from Security/JSONLoad</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/8c9860355a128f99ca60852573b77e87e3d53a6a"><code>Merge pull request #10169 from dvandersluis/same-line</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/a255b800dfbd057688ef2ed7e2a26b3796b4ce3e"><code>Tweak spell checking GitHub Actions workflow name</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/e6fa3b95760a5078828da37230c16e7f15c76b55"><code>Merge pull request #10171 from franzliedke/hash-transform-values-leftover-to_h</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/4c5f485bec514e10b29277f6b1b61dd45cecdd39"><code>Style/HashTransform*: Fix incorrect auto-correction when inside block body</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/29d104e6b6b26b713571c2db4bb740f01dce3b2f"><code>[Fix #8101] Reformat rake spec output to amplify signal and reduce noise.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/589c6e8ca02de98a1b5f624274dcdb10140a4e73"><code>Merge pull request #10149 from Drowze/bundler-gemcomment-frozen</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/976f71dfcd7b1fe603c44cb9aa4f6e6d4e56f8ab"><code>Refactor code that can use same_line?.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/7e21d7feb1701c9da0ea91115ca038898e1a46af"><code>Update InternalAffairs/LocationLineEqualityComparison to handle node.loc.first_line, node.first_line and node.source_range.line.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/f7a30886682275c62405d4e059d1fc3be2f808b6"><code>Merge pull request #10168 from dvandersluis/issue/10165</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/8f634b8b8687f4c334a2bd9f5e14e03da7d3fdde"><code>[Fix #10165] Fix Layout/DotPosition false positives when the selector and receiver are on the same line.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/f9d5e3263d15d738f9ca2a59941d2287ae0bc10d"><code>Update Util#same_line? to be able to compare ranges.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/b7f5d53756d39db72570bcca8e2c16c0185a17b3"><code>Merge pull request #10164 from dvandersluis/fix/changelog-spec</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/72a0f532326ec9b2284f4230db6d02b05391f2de"><code>Removed stray puts from changelog.rb.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/d5a2f3d342a09fcb145b11b3f1a1e6500fcfcaf9"><code>Merge pull request #10159 from koic/add_internal_affairs_location_line_equality_comparison_cop</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/3eb9d5008a75dde1cb72fbd4232c5d021f1dd34c"><code>Switch back the docs version</code></a></li> </ul> </details>


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@​depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details>

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchhanami/model

branch : depfu/update/rubocop-1.22.2

created branch time in 3 days

delete branch hanami/mailer

delete branch : depfu/update/rubocop-1.22.1

delete time in 3 days

PR closed hanami/mailer

Upgrade rubocop to version 1.22.1 depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.91 → 1.22.1) · Repo · Changelog

<details> <summary>Release Notes</summary> <p><em>Too many releases to show here. View the <a href="https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md">full release notes</a>.</em></p> </details>

<details> <summary>Commits</summary> <p><a href="https://github.com/rubocop/rubocop/compare/1bdcf65d88dcca526571bfc005af02a4f2695045...b5c9369aea2741877a93d8eaa4d57e16fc4c3be9">See the full diff on Github</a>. The new version differs by 14 commits:</p> <ul> <li><a href="https://github.com/rubocop/rubocop/commit/b5c9369aea2741877a93d8eaa4d57e16fc4c3be9"><code>Cut 1.22.1</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/ba81023c7589f97ff42a06dec3dbaab75a2b7da9"><code>Update Changelog</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/31ea6847cdd12e1269b57350104791d237e8ab3b"><code>[Fix #10145] Update Style/SelectByRegexp to ignore cases where the receiver appears to be a hash.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/a7ef72aa8c35336b169c5d78e2925fc27d739fcb"><code>[Fix #10148] Fix Style/QuotedSymbols handling escaped characters incorrectly.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/eba1d4d018d929a23ee73b005acb3687a1c4c33b"><code>Fix inconsistent capitalization of RuboCop.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/275a70b4286654b06154dbba259c10c1529d89e8"><code>Clarify documentation for Style/QuotedSymbols.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/1bed3ec0bbdfcd166b6246577d178b4b99f01b55"><code>Refine offense highlight range for Style/RedundantArgument</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/efcf741d688a12016fad4823fec7295903c11696"><code>Merge pull request #10146 from koic/fix_an_error_for_lint_require_relative_self_path</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/d26ec0cd6e665f3c38c3cbdac7c128e18705e7a1"><code>Merge pull request #10141 from dvandersluis/issue/10140</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/afa9bb5b7b8fc310a430018b33aa9e5cb166a348"><code>[Fix #10143] Fix an error for Lint/RequireRelativeSelfPath</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/ff42cfe24d9664fdb0b61937625654286932c076"><code>Minor update to changelog and release notes.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/b7a2f1d259a363bb3a7d89b6f99303edd41ac0dc"><code>[Fix #10140] Fix false positive for Layout/DotPosition when a heredoc receives a method on the same line as the start sigil in trailing style.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/502c606c6ddd7c1bbf6b2d07a9cd716071411de9"><code>Tweak a changelog entry</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/be8cc4c5823447918802c4670734b6a6fce7a456"><code>Switch back the docs version</code></a></li> </ul> </details>


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@​depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details>

+1 -1

2 comments

1 changed file

depfu[bot]

pr closed time in 3 days

pull request commenthanami/mailer

Upgrade rubocop to version 1.22.1

Closed in favor of #122.

depfu[bot]

comment created time in 3 days

pull request commenthanami/mailer

Upgrade rubocop to version 1.22.1

Closed in favor of #122.

depfu[bot]

comment created time in 3 days

PR opened hanami/mailer

Upgrade rubocop to version 1.22.2

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.91 → 1.22.2) · Repo · Changelog

<details> <summary>Release Notes</summary> <p><em>Too many releases to show here. View the <a href="https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md">full release notes</a>.</em></p> </details>

<details> <summary>Commits</summary> <p><a href="https://github.com/rubocop/rubocop/compare/b5c9369aea2741877a93d8eaa4d57e16fc4c3be9...60484a7bcf8fb240dada8db90e642a1b9baa8ca0">See the full diff on Github</a>. The new version differs by 33 commits:</p> <ul> <li><a href="https://github.com/rubocop/rubocop/commit/60484a7bcf8fb240dada8db90e642a1b9baa8ca0"><code>Cut 1.22.2</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/cc7ac48dfe4351cc2665ac46c4b62d307114023f"><code>Update Changelog</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/1d5621d031b1047fecddd3b9d2b74f02852e10c9"><code>Suppress warning: constant Net::HTTPServerException is deprecated</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/a319d09b0cadcc6f5fbb47fd53260b016868fd4d"><code>Updated Gemspec/RequiredRubyVersion register an offense when set to blank values.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/34ce2ed489e0228bbe57e911a9c6ed7aeb233b35"><code>[Fix #10200] Fix an error when inspecting a directory named *</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/5b27789b6c68ddb7292d247981ae2a71c7484f30"><code>[Fix #10186] Explicit block arg is not counted for Metrics/ParameterLists</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/189471786f93081be2432fb5abe62cf9c5c1aa28"><code>Merge pull request #10193 from koic/fix_an_error_for_empty_lines_around_exception_handling_keywords</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/95262d0628fde72c622a9591fcc242956862ea97"><code>Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/41f2632d22fb317f809f956c99f71e6cb9ffff0f"><code>Merge pull request #10187 from koic/fix_false_positive_for_lint_ambiguous_range</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/96457eee0db1212575025a2aac4c1fba90494f08"><code>[Fix #10185] Fix a false positive for Lint/AmbiguousRange</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/e9c339b7c27e49bf356f40caef2f05b13a31e5fe"><code>Merge pull request #10183 from koic/ci_against_jruby_9_3</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/2d6507f3b3d48ce3de1e1e3521a69289f37a93c9"><code>CI against JRuby 9.3</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/4ca072119f819f7425a162d08ef5025f554b839f"><code>Merge pull request #10181 from koic/fix_an_error_for_style_select_by_regexp</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/abcf9d390e99257d4a7282e1120006f19a8b5c3a"><code>[Fix #10180] Fix an error for Style/SelectByRegexp</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/512b771f88537996e65fdb571724bb67cdb7c6ab"><code>Merge pull request #10176 from koic/unmark_autocorrect_false_from_security_json_load</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/47be464d83b1eed39fbb9fa5eb62e5ef70ee112d"><code>Merge pull request #10177 from dvandersluis/issue/10172</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/42e8adf734b039fb9af6b9d2e1012005edd715b4"><code>Add documentation about rubocop-daemon.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/8c9692b500cc060070963d0990a93198d21704b3"><code>Unmark AutoCorrect: false from Security/JSONLoad</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/8c9860355a128f99ca60852573b77e87e3d53a6a"><code>Merge pull request #10169 from dvandersluis/same-line</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/a255b800dfbd057688ef2ed7e2a26b3796b4ce3e"><code>Tweak spell checking GitHub Actions workflow name</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/e6fa3b95760a5078828da37230c16e7f15c76b55"><code>Merge pull request #10171 from franzliedke/hash-transform-values-leftover-to_h</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/4c5f485bec514e10b29277f6b1b61dd45cecdd39"><code>Style/HashTransform*: Fix incorrect auto-correction when inside block body</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/29d104e6b6b26b713571c2db4bb740f01dce3b2f"><code>[Fix #8101] Reformat rake spec output to amplify signal and reduce noise.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/589c6e8ca02de98a1b5f624274dcdb10140a4e73"><code>Merge pull request #10149 from Drowze/bundler-gemcomment-frozen</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/976f71dfcd7b1fe603c44cb9aa4f6e6d4e56f8ab"><code>Refactor code that can use same_line?.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/7e21d7feb1701c9da0ea91115ca038898e1a46af"><code>Update InternalAffairs/LocationLineEqualityComparison to handle node.loc.first_line, node.first_line and node.source_range.line.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/f7a30886682275c62405d4e059d1fc3be2f808b6"><code>Merge pull request #10168 from dvandersluis/issue/10165</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/8f634b8b8687f4c334a2bd9f5e14e03da7d3fdde"><code>[Fix #10165] Fix Layout/DotPosition false positives when the selector and receiver are on the same line.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/f9d5e3263d15d738f9ca2a59941d2287ae0bc10d"><code>Update Util#same_line? to be able to compare ranges.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/b7f5d53756d39db72570bcca8e2c16c0185a17b3"><code>Merge pull request #10164 from dvandersluis/fix/changelog-spec</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/72a0f532326ec9b2284f4230db6d02b05391f2de"><code>Removed stray puts from changelog.rb.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/d5a2f3d342a09fcb145b11b3f1a1e6500fcfcaf9"><code>Merge pull request #10159 from koic/add_internal_affairs_location_line_equality_comparison_cop</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/3eb9d5008a75dde1cb72fbd4232c5d021f1dd34c"><code>Switch back the docs version</code></a></li> </ul> </details>


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@​depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details>

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchhanami/mailer

branch : depfu/update/rubocop-1.22.2

created branch time in 3 days

issue commenthanami/model

Change default dataset configured in ROM

I am also interested in this. We are introducing soft deletion by adding something like a deleted_at column in the table. However, we have a lot of existing queries and aggregations such that going through the methods one-by-one to add a where(deleted_at: nil) is not feasible.

After digging through the docs and codebase, I am currently stuck at monkey patching the Repository's self.load! method. I'm wondering if there's a better way around this?

class BookRepository < Hanami::Repository
  def self.load!
    super

    configuration.setup.relation_classes.each do |klass|
      # .root => :books. This is to skip other relations included as associations
      next unless klass.register_as == root 

      klass.dataset do
        where(Sequel[:books][:deleted_at] => nil) # overrides default dataset here
      end
    end
  end
end
jaypandya73

comment created time in 3 days

delete branch hanami/helpers

delete branch : depfu/update/rubocop-1.22.1

delete time in 3 days

PR closed hanami/helpers

Upgrade rubocop to version 1.22.1 depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.91 → 1.22.1) · Repo · Changelog

<details> <summary>Release Notes</summary> <p><em>Too many releases to show here. View the <a href="https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md">full release notes</a>.</em></p> </details>

<details> <summary>Commits</summary> <p><a href="https://github.com/rubocop/rubocop/compare/1bdcf65d88dcca526571bfc005af02a4f2695045...b5c9369aea2741877a93d8eaa4d57e16fc4c3be9">See the full diff on Github</a>. The new version differs by 14 commits:</p> <ul> <li><a href="https://github.com/rubocop/rubocop/commit/b5c9369aea2741877a93d8eaa4d57e16fc4c3be9"><code>Cut 1.22.1</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/ba81023c7589f97ff42a06dec3dbaab75a2b7da9"><code>Update Changelog</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/31ea6847cdd12e1269b57350104791d237e8ab3b"><code>[Fix #10145] Update Style/SelectByRegexp to ignore cases where the receiver appears to be a hash.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/a7ef72aa8c35336b169c5d78e2925fc27d739fcb"><code>[Fix #10148] Fix Style/QuotedSymbols handling escaped characters incorrectly.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/eba1d4d018d929a23ee73b005acb3687a1c4c33b"><code>Fix inconsistent capitalization of RuboCop.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/275a70b4286654b06154dbba259c10c1529d89e8"><code>Clarify documentation for Style/QuotedSymbols.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/1bed3ec0bbdfcd166b6246577d178b4b99f01b55"><code>Refine offense highlight range for Style/RedundantArgument</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/efcf741d688a12016fad4823fec7295903c11696"><code>Merge pull request #10146 from koic/fix_an_error_for_lint_require_relative_self_path</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/d26ec0cd6e665f3c38c3cbdac7c128e18705e7a1"><code>Merge pull request #10141 from dvandersluis/issue/10140</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/afa9bb5b7b8fc310a430018b33aa9e5cb166a348"><code>[Fix #10143] Fix an error for Lint/RequireRelativeSelfPath</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/ff42cfe24d9664fdb0b61937625654286932c076"><code>Minor update to changelog and release notes.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/b7a2f1d259a363bb3a7d89b6f99303edd41ac0dc"><code>[Fix #10140] Fix false positive for Layout/DotPosition when a heredoc receives a method on the same line as the start sigil in trailing style.</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/502c606c6ddd7c1bbf6b2d07a9cd716071411de9"><code>Tweak a changelog entry</code></a></li> <li><a href="https://github.com/rubocop/rubocop/commit/be8cc4c5823447918802c4670734b6a6fce7a456"><code>Switch back the docs version</code></a></li> </ul> </details>


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@​depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@​depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@​depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details>

+1 -1

1 comment

1 changed file

depfu[bot]

pr closed time in 3 days