profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/hallelujah/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ramihajamalala Hery hallelujah @propitech Barcelona http://my.rails-royce.org All É Null A

hallelujah/abstract-sql 2

Reverse Perl SQL::Abstract : feed a SQL and return a Hash

hallelujah/gettext_i18n_rails 2

Rails: FastGettext, I18n integration -- simple, threadsafe and fast!

3scale/active_merchant-adyen12 1

Another Adyen gateway for activemerchant using the version 12 of their API

3scale/wildcard-router-service 1

Wildcard Router for 3scale api gateway

hallelujah/cassandra-cql 1

DBI-like CQL driver for Cassandra in Ruby

hallelujah/csv_builder 1

CSV template handler for Rails 3

hallelujah/db_sower 1

A database feeder with nice dsl

push event3scale/porta

3scale

commit sha 7b28ecca7f469cdf52a5f5d488b6a5f79865e3b3

Update Gemfile.prod.lock

view details

push time in an hour

Pull request review comment3scale/porta

[feature] Github action for stale PRs

+name: 'Close stale issues and PRs'+on:+  schedule:+    - cron: '30 3 * * *'++jobs:+  stale:+    runs-on: ubuntu-latest+    steps:+      - uses: actions/stale@v3+        with:+          stale-pr-message: 'This PR is stale because it has not received activity for more than 7 days. Remove stale label or comment or this will be closed in 7 days.'+          days-before-stale: 7

Right. Alert in 2 weeks, closed in another one if nothing changes.

hallelujah

comment created time in 5 hours

Pull request review comment3scale/porta

[2.11] Add Backend form in React

 import Adapter from 'enzyme-adapter-react-16'  Enzyme.configure({adapter: new Adapter()}) -import * as utils from 'utilities/utils'-jest.mock('utilities/utils')-jest.spyOn(utils, 'CSRFToken')-  .mockImplementation(() => '')-+// DELETE: this is false

Then delete it ;)

josemigallas

comment created time in 5 hours

Pull request review comment3scale/porta

[feature] Github action for stale PRs

+name: 'Close stale issues and PRs'+on:+  schedule:+    - cron: '30 3 * * *'++jobs:+  stale:+    runs-on: ubuntu-latest+    steps:+      - uses: actions/stale@v3+        with:+          stale-pr-message: 'This PR is stale because it has not received activity for more than 7 days. Remove stale label or comment or this will be closed in 7 days.'+          days-before-stale: 7

I thought exactly the same as @guicassolato

hallelujah

comment created time in 5 hours

Pull request review comment3scale/porta

[feature] Github action for stale PRs

+name: 'Close stale issues and PRs'+on:+  schedule:+    - cron: '30 3 * * *'++jobs:+  stale:+    runs-on: ubuntu-latest+    steps:+      - uses: actions/stale@v3+        with:+          stale-pr-message: 'This PR is stale because it has not received activity for more than 7 days. Remove stale label or comment or this will be closed in 7 days.'+          days-before-stale: 7

I'd propose at least doubling this. It's quite usual that something is put on hold after a PR was pushed and the responsible gets involved to something else while waiting for resolution or reviews, etc. In my personal opinion, a couple weeks of waiting is not a big deal.

          days-before-stale: 14
hallelujah

comment created time in 5 hours

Pull request review comment3scale/porta

[2.11] New Application page remake

 class Buyers::ApplicationsController < FrontendController   helper DisplayViewPortion::Helper    before_action :authorize_partners-  before_action :find_buyer, :only => [:new, :create]-  before_action :authorize_multiple_applications, :only => [ :new, :create ]+  before_action :find_buyer, :only => [:create]

Because now buyer is not always available and it will return 404.

josemigallas

comment created time in 5 hours

delete branch 3scale/porta

delete branch : fix/THREESCALE-6385_index_pagination

delete time in 5 hours

push event3scale/porta

josemigallas

commit sha 135348e408bedeb8265cbbae9c1aa6c5aea4e89a

fixes item count in Products and BackendApis index paginations

view details

Jose Miguel Gallas Olmedo

commit sha 844a392a98475e0063352c75e620c99ae0035fde

Merge pull request #2388 from 3scale/fix/THREESCALE-6385_index_pagination Fix item count in Products and BackendApis pagination

view details

push time in 5 hours

PR merged 3scale/porta

Fix item count in Products and BackendApis pagination

What this PR does / why we need it:

It fixes a bug in pagination showing always the count of all items regardless of search.

Which issue(s) this PR fixes

THREESCALE-6385: Products/Backends pagination shows all pages even when filtering

Verification steps

Go to Products/Backends index pages Search using Sphinx and check the count of items is reduced.

Special notes for your reviewer: Sphinx is probably not going to work properly but having a result of '0' is actually good for verifying this PR.

+14 -14

0 comment

4 changed files

josemigallas

pr closed time in 5 hours

PR opened 3scale/porta

SCSS lint: remove SelectorFormat rule

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. Please remember to ALWAYS open an issue before starting to work on your pull request. Please take the time to validate your intentions for the pull request with the project maintainers before spending the time to work on it, so your time does not go to waste.
  2. If this is your first time, please make sure you've gone through the Contribution guide.
  3. If the PR is unfinished, add a [WIP] at the start of the PR title. You can remove it when it's ready to be reviewed. -->

What this PR does / why we need it:

scss-lint SelectorFormat rule is not useful anymore, since it's not compatible with Patternfly at all. Instead of disabling the rule everywhere, we should remove it.

Which issue(s) this PR fixes

None ;)

+3 -14

0 comment

9 changed files

pr created time in 6 hours

create barnch3scale/porta

branch : remove-SelectorFormat-rule

created branch time in 6 hours

push event3scale/porta

dependabot-preview[bot]

commit sha e786c12c4080a3af233a77e248b294244ff2f8b9

[Security] Bump dompurify from 2.0.15 to 2.2.6 Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.15 to 2.2.6. **This update includes a security fix.** - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/2.0.15...2.2.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 8f39fbb68fd4ed16fca766af24e5412a70f6be0a

[Security] Bump ini from 1.3.5 to 1.3.8 Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. **This update includes a security fix.** - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Sarah Rambacher

commit sha 42637f0f97d7df58877a8b7571ac6a1798c218a1

removes unused class Header-logo--withIcon

view details

Damián Peralta Mariñelarena

commit sha b0d30e0c8b1b5469f9d8ae529960fd3c76646bb8

Merge pull request #2361 from srambach/THREESCALE-6694-remove-unused-header-icon-class removes unused class Header-logo--withIcon

view details

HemaHG

commit sha cbfc93414a04d5d0746b7d3679608e06a9c97cd3

Adding flash message when the user data is not valid Signed-off-by: HemaHG <hhg@redhat.com>

view details

Sarah Rambacher

commit sha 3235cf85b6d4e5e4f78a99bcb2b0688e2889944b

adds typeahead default plan selector

view details

Sarah Rambacher

commit sha e3c2b4f849cd39dbb6a5950a59d2c1a27957bf3e

format scss file

view details

josemigallas

commit sha c5826b096955501f4f2452c0bd648f034875c39d

adds props

view details

josemigallas

commit sha 8678f3e14be6c256c5baf50238fb7ac8f38f0fbb

adds some logic

view details

josemigallas

commit sha 790a89b1edfe11768f9339a39dad85439757ce38

adds autosubmit feature and renames component

view details

josemigallas

commit sha 0d5526d6738da6fb9f3dd3abaa93eb704fd89bbf

adds PF styling to the page section

view details

josemigallas

commit sha c3b9368a0e0733bdacc23db7014c50882d7cfdd6

removes dummy title

view details

josemigallas

commit sha 366c41fc4017068fc80d905e5972b66e40ecdb06

* renames component * adds some additional PF styling * cleanup a bit * updates view helper and cleanup props * makes path a variable, instead of being hardcoded

view details

josemigallas

commit sha dbba77effa74a9744576a9b233797889fc183dee

returns 404 when plan doesn't exist, set to nil only when no id in params

view details

josemigallas

commit sha c23d6249583d9b5de31668d32a196a411d3ba06b

- renames - fixes styles

view details

Sarah Rambacher

commit sha 423b047d8b37c14a5196b004faa5303c824b48d6

adds a spinner component

view details

josemigallas

commit sha d24235dd635e096589ce2407f1e24e59da7e267c

* moves Spinner into new module Common * reorganizes styles

view details

josemigallas

commit sha da7d13349defacf72580916cfcc3bcaac8748057

* adds patternfly-utils * css fixes

view details

josemigallas

commit sha 2ee3af1e722b830fad0fd629a577d6d5f2c96f4e

disable lint in spinner.scss

view details

josemigallas

commit sha fcbffb1cb9d4829ee5df63c920b8a603b2a251d2

fixes indentation

view details

push time in 7 hours

Pull request review comment3scale/porta

Fix item count in Products and BackendApis pagination

 = javascript_pack_tag 'products_index' = javascript_pack_tag 'PF4Styles/dashboard' -div#products data-products=(@services) data-products-count=(@raw_services.size)

and here's my answer

josemigallas

comment created time in 7 hours

Pull request review comment3scale/porta

Fix item count in Products and BackendApis pagination

 class Provider::Admin::BackendApisController < Provider::Admin::BaseController   def index     activate_menu :backend_apis     search = ThreeScale::Search.new(params[:search] || params)-    @raw_backend_apis = current_account.backend_apis

same question as above

josemigallas

comment created time in 7 hours

Pull request review comment3scale/porta

Fix item count in Products and BackendApis pagination

 class Api::ServicesController < Api::BaseController   def index     activate_menu :products     search = ThreeScale::Search.new(params[:search] || params)-    @raw_services = current_user.accessible_services

we are not using @raw_services in the view?

josemigallas

comment created time in 7 hours

push event3scale/porta

Damian Peralta

commit sha a922e94c82d1521af52196318f7ba790a3941c53

Fixing tests

view details

push time in 7 hours

PR opened 3scale/porta

Fix item count in Products and BackendApis pagination

What this PR does / why we need it:

It fixes a bug in pagination showing always the count of all items regardless of search.

Which issue(s) this PR fixes

THREESCALE-6385: Products/Backends pagination shows all pages even when filtering

Verification steps

Go to Products/Backends index pages Search using Sphinx and check the count of items is reduced.

Special notes for your reviewer: Sphinx is probably not going to work properly but having a result of '0' is actually good for verifying this PR.

+14 -14

0 comment

4 changed files

pr created time in 7 hours

create barnch3scale/porta

branch : fix/THREESCALE-6385_index_pagination

created branch time in 8 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

 // Jest Snapshot v1, https://goo.gl/fbAQLP  exports[`should be able to render a "cancel" button variant 1`] = `-<div-  class="PolicyChain-addPolicy--cancel"+<button+  class="pf-c-button pf-m-link PolicyChain-addPolicy--cancel"+  type="button" >-  <i-    class="fa fa-times-circle"+  <span+    class="pf-c-button__icon"+  >+    <svg+      aria-hidden="true"+      fill="currentColor"+      height="1em"+      role="img"+      style="vertical-align:-0.125em"+      viewBox="0 0 352 512"+      width="1em"+    >+      <path+        d="M242.72 256l100.07-100.07c12.28-12.28 12.28-32.19 0-44.48l-22.24-22.24c-12.28-12.28-32.19-12.28-44.48 0L176 189.28 75.93 89.21c-12.28-12.28-32.19-12.28-44.48 0L9.21 111.45c-12.28 12.28-12.28 32.19 0 44.48L109.28 256 9.21 356.07c-12.28 12.28-12.28 32.19 0 44.48l22.24 22.24c12.28 12.28 32.2 12.28 44.48 0L176 322.72l100.07 100.07c12.28 12.28 32.2 12.28 44.48 0l22.24-22.24c12.28-12.28 12.28-32.19 0-44.48L242.72 256z"+        transform=""+      />+    </svg>+  </span>+  <span+    class="pf-c-button__text"

@josemigallas let's update the test in a new PR, as it's out of scope of this one

damianpm

comment created time in 8 hours

push event3scale/porta

Damian Peralta

commit sha 1e002bbbab2f36b4328a09388b12be1f123ff8ad

Using Button component and deleting unused class

view details

push time in 8 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

   = form.semantic_errors :base_path   = form.input :skip_swagger_validations, as: :boolean = form.buttons do-  = form.commit_button commit_button_label+  = form.button commit_button_label, button_html: { class: 'pf-c-button pf-m-primary' } 

Is not needed: Screenshot 2021-03-04 at 11 47 59

damianpm

comment created time in 8 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

 // Jest Snapshot v1, https://goo.gl/fbAQLP  exports[`should be able to render a "cancel" button variant 1`] = `-<div-  class="PolicyChain-addPolicy--cancel"+<button+  class="pf-c-button pf-m-link PolicyChain-addPolicy--cancel"+  type="button" >-  <i-    class="fa fa-times-circle"+  <span+    class="pf-c-button__icon"+  >+    <svg+      aria-hidden="true"+      fill="currentColor"+      height="1em"+      role="img"+      style="vertical-align:-0.125em"+      viewBox="0 0 352 512"+      width="1em"+    >+      <path+        d="M242.72 256l100.07-100.07c12.28-12.28 12.28-32.19 0-44.48l-22.24-22.24c-12.28-12.28-32.19-12.28-44.48 0L176 189.28 75.93 89.21c-12.28-12.28-32.19-12.28-44.48 0L9.21 111.45c-12.28 12.28-12.28 32.19 0 44.48L109.28 256 9.21 356.07c-12.28 12.28-12.28 32.19 0 44.48l22.24 22.24c12.28 12.28 32.2 12.28 44.48 0L176 322.72l100.07 100.07c12.28 12.28 32.2 12.28 44.48 0l22.24-22.24c12.28-12.28 12.28-32.19 0-44.48L242.72 256z"+        transform=""+      />+    </svg>+  </span>+  <span+    class="pf-c-button__text"

However, I don't think this snapshots make sense anymore @damianpm. The icon class used to be readable but now being it a SVG it doesn't say anything. I'd rewrite the test and look for a PlusIcon and TimesIcon directly.

damianpm

comment created time in 9 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

 // Jest Snapshot v1, https://goo.gl/fbAQLP  exports[`should be able to render a "cancel" button variant 1`] = `-<div-  class="PolicyChain-addPolicy--cancel"+<button+  class="pf-c-button pf-m-link PolicyChain-addPolicy--cancel"+  type="button" >-  <i-    class="fa fa-times-circle"+  <span+    class="pf-c-button__icon"+  >+    <svg+      aria-hidden="true"+      fill="currentColor"+      height="1em"+      role="img"+      style="vertical-align:-0.125em"+      viewBox="0 0 352 512"+      width="1em"+    >+      <path+        d="M242.72 256l100.07-100.07c12.28-12.28 12.28-32.19 0-44.48l-22.24-22.24c-12.28-12.28-32.19-12.28-44.48 0L176 189.28 75.93 89.21c-12.28-12.28-32.19-12.28-44.48 0L9.21 111.45c-12.28 12.28-12.28 32.19 0 44.48L109.28 256 9.21 356.07c-12.28 12.28-12.28 32.19 0 44.48l22.24 22.24c12.28 12.28 32.2 12.28 44.48 0L176 322.72l100.07 100.07c12.28 12.28 32.2 12.28 44.48 0l22.24-22.24c12.28-12.28 12.28-32.19 0-44.48L242.72 256z"+        transform=""+      />+    </svg>+  </span>+  <span+    class="pf-c-button__text"

This is correct, @thomasmaas. Any link-like button (pf-m-link) will have this class in its text.

damianpm

comment created time in 9 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

 describe('PolicyConfig Component', () => {    it('should have a remove button', () => {     const {policyConfigWrapper, props} = setup()-    const removePolicyButton = policyConfigWrapper.find('.PolicyConfiguration-remove')+    const removePolicyButton = policyConfigWrapper.find('.pf-c-button.PolicyConfiguration-remove')
    const removePolicyButton = policyConfigWrapper.find('.pf-c-button')
damianpm

comment created time in 9 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

   = form.input :position  = form.buttons do-  = form.commit_button "#{proxy_rule.new_record? ? 'Create' : 'Update'} Mapping Rule"+  = form.button "#{proxy_rule.new_record? ? 'Create' : 'Update'} Mapping Rule", button_html: { class: 'pf-c-button pf-m-primary' }
  = form.button "#{proxy_rule.new_record? ? 'Create' : 'Update'} Mapping Rule", button_html: { class: 'pf-c-button pf-m-primary', type: 'submit' }
damianpm

comment created time in 9 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

 = semantic_form_for @service, :url => admin_service_path(@service) do |form|   = render :partial => 'api/services/forms/usage_rules', :locals => { :form => form }   = form.buttons do-    = form.commit_button 'Update Product'+    = form.button 'Update Product', button_html: { class: 'pf-c-button pf-m-primary' }
    = form.button 'Update Product', button_html: { class: 'pf-c-button pf-m-primary', type: 'submit' }
damianpm

comment created time in 9 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

 = semantic_form_for @service, :url => admin_service_path(@service) do |form|   = render :partial => 'api/services/forms/integration_settings_apiap', :locals => {:form => form}   = form.buttons do-    = form.commit_button "Update Product", button_html: { name: 'update_settings' }+    = form.commit_button "Update Product", button_html: { name: 'update_settings', class: 'pf-c-button pf-m-primary' }
    = form.button "Update Product", button_html: { name: 'update_settings', class: 'pf-c-button pf-m-primary', type: 'submit' }
damianpm

comment created time in 9 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

 = semantic_form_for @service, url: admin_service_path(@service) do |form|   = render partial: 'api/services/forms/naming', locals: { form: form }   = form.buttons do-    = form.commit_button 'Update Product'+    = form.button 'Update Product', button_html: { class: 'pf-c-button pf-m-primary' }
  = form.button commit_button_label, button_html: { class: 'pf-c-button pf-m-primary', type: 'submit' } 
damianpm

comment created time in 9 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

   = form.input :description, input_html: { rows: 3 }  = form.buttons do-  = form.commit_button "#{@metric.new_record? ? 'Create' : 'Update'} #{@metric.child? ? 'Method' : 'Metric'}"+  = form.button "#{@metric.new_record? ? 'Create' : 'Update'} #{@metric.child? ? 'Method' : 'Metric'}", button_html: { class: 'pf-c-button pf-m-primary' } 
  = form.button commit_button_label, button_html: { class: 'pf-c-button pf-m-primary', type: 'submit' } 
damianpm

comment created time in 9 hours

Pull request review comment3scale/porta

PF compliant buttons: Products

 h2     = form.user_defined_form    = form.buttons do-    = form.commit_button+    = form.button 'Update Application', button_html: {class: 'pf-c-button pf-m-primary' }

Same as before: I may be wrong but I think it has to be either commit_button or have type: 'submit'.

damianpm

comment created time in 9 hours