profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/hageboeck/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

madgraph5/madgraph4gpu 15

GPU development for the Madgraph5_aMC@NLO event generator software package

hageboeck/root 1

Mirror of official ROOT git repository

hageboeck/AdePT 0

Accelerated demonstrator of electromagnetic Particle Transport

hageboeck/asan 0

Address sanitizer demo

hageboeck/cpluspluscourse 0

C++ Course Taught at CERN, from Sebastien Ponce (LHCb)

hageboeck/documents 0

Repository for HSF documents (e.g. technical notes)

hageboeck/madgraph4gpu 0

GPU development for the Madgraph5 event generator software package

hageboeck/rootbench 0

Collection of benchmarks and performance monitoring applications

hageboeck/rootbinder 0

Set of files to use ROOTbooks in mybinder.org

pull request commentroot-project/root

[CMake] Add automatic FAILREGEX for gtests

@phsft-bot build

hageboeck

comment created time in 10 hours

pull request commentroot-project/root

[CMake] Add automatic FAILREGEX for gtests

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

hageboeck

comment created time in 12 hours

push eventhageboeck/root

Vincenzo Eduardo Padulano

commit sha 4081abc0dd61140bf36bf667649a1c60915ca1f4

[core] Exit when calling root command with unrecognized option Options passed to the `root` command are parsed in `TApplication::GetOptions(Int_t *argc, char **argv)`. String options in `argv` are removed from the array of options after parsing. If any string remains in argv, it means it is not recognized by the `root` command. While these could still be useful for other `TApplication` instances, in the specific case of calling `root` which is based on `TRint` it simply means the remaining options are not valid. This commit introduces an early exit logic in the constructor of `TRint`. If there are any remaining unrecognized options as described above, they will be printed to `std::cerr` and then ROOT will terminate execution, similar to other linux commands: ``` $: root -z --nonexistingoption root: unrecognized option '-z' root: unrecognized option '--nonexistingoption' Try 'root --help' for more information. ```

view details

Vincenzo Eduardo Padulano

commit sha 0e0154b4960c92ae62df652b5b21f7d24a1fab1d

[core] Add test for root unrecognized options

view details

Sergey Linev

commit sha 3e1bc202429db49df1769e54dac02ce5b91c0c41

[webgui] fix typo in web geometry viewer

view details

Sergey Linev

commit sha d7781d4b52131612f901ff82690a52cdf3eadac6

[jsroot] dev 7/09/2021 with several fixes plus new draw options for lego axes scaling

view details

Andrei Gheata

commit sha 55684e6dde6a8d0688a01fea36535c243026f55c

Demoting change of TGeo units from Warning to Info. (#8967)

view details

Guilherme Amadio

commit sha b92dbfdee6f063e5372dbc6a40883893074eec0e

Fix relative links for PyROOT on macOS Closes: #8933 Fixes: aefe374411d9bfecaa4a9eb764aee05f7b76a8e6

view details

Enrico Guiraud

commit sha 60a27812784abaac8850b15361a3318cb6b25f7e

[DF] Remove dead code

view details

Olivier Couet

commit sha 72db0de079d4f0a814cb98f00086434a8b67a441

Make sure the pythonisation doc shows up at the end of the classes doc (#8971) * Make sure the pythonisation doc shows up at the end of the classes documentation * Too many lines were commented out `makeinput.sh` * Do changes only related to the python Frame placement * Create the .pyzdoc at the right place. * Update documentation/doxygen/extract_docstrings.py add `_out` Co-authored-by: Enric Tejedor <enric.tejedor.saavedra@cern.ch> * Add comment Co-authored-by: Enric Tejedor <enric.tejedor.saavedra@cern.ch>

view details

Vincenzo Eduardo Padulano

commit sha 25cc77f18820e722f98bc82a34dabffdd8704a27

[core] Fix invalid pointer error in TRintTests.cxx This test needs a char** which is a bit tricky to create without stepping into compiler errors or warnings. Currently it is created on the heap but improperly deallocated, so switch to a stack variable to avoid the need for memory management.

view details

Enrico Guiraud

commit sha 495330d01343a7cd1992b3734ec591f9102e34de

[NFC] Mention EnableImplicitMT(1) != single-thread Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch>

view details

Javier Lopez-Gomez

commit sha 9e1fd83f93fff9071f7d341339061904bcfccda2

[cling] MetaLexer: return `/*` and `*/` as tokens; added `ReadToEndOfLine()` This commit includes the following changes to MetaLexer: - Update `MetaLexer::Lex()` to return `/*` (tok::l_comment), `*/` (tok::r_comment), and `<` (tok::less) as tokens. - Added `MetaLexer::ReadToEndOfLine()` function: consume input until `\r` or `\n`. - Added `MetaLexer::RAII`, a RAII object that saves/restores the current position.

view details

Javier Lopez-Gomez

commit sha 5f9629f2c1edd53e348cdac088861c7976a3af74

[cling] Rewrite of `InputValidator::validate()` Replace implementation of `InputValidator::validate()` by simpler, more maintainable code that also fixes ROOT-9202. The previous implementation was unable to properly handle line continuation after ',' or '\'. Specifically, it skipped over non-punctuation tokens, entering continuation mode even if ',' or '\' were not the last tokens in the input, e.g. `int a, b` or 'int a \ b'. Fixes ROOT-9202.

view details

Javier Lopez-Gomez

commit sha e97a155ce418c93d97a20326f407a6682111a393

[cling] Cleanup MetaLexer; remove unused `LexPunctuatorAndAdvance()`

view details

Javier Lopez-Gomez

commit sha a6984fd6b9cfc50b692a8976a5dc5b55f6a5ebd8

[cling] `InputValidator::validate()`: add test against ROOT-9202

view details

Enrico Guiraud

commit sha 918f9f28ea21289e02cd27b5ffba8ce608343f7f

[DF] Add a sanity check to GetMergeableValue

view details

Javier Lopez-Gomez

commit sha 97571ef683fd4437bb5f5f33389237ab6c75bba7

[trint] Correctly handle line continuation after '\' To have better diagnostics, `TRint::ProcessLineNr()` prepends a `#line 1 "ROOT_prompt_xxx"` PP directive to each input line. However, this causes problems if the previous line is continued with '\', e.g. ``` root [0] #define m(x) printf("%s", \ root (cont'ed, cancel with .@) [1]x); ROOT_prompt_0:2:2: error: '#' is not followed by a macro parameter ^ ROOT_prompt_0:3:1: error: use of undeclared identifier 'x' x); ^ ``` This patch fixes issue #8762.

view details

Javier Lopez-Gomez

commit sha 3dbf55d522ca867290243487837b21b6b451022f

[cling] Enable replacement of the default diagnostic consumer These changes enable the replacement of the default DiagnosticConsumer provided by CIFactory. Concretely, two member functions have been added to the Interpreter class: - replaceDiagnosticConsumer(): replaces the default CIFactory-provided DiagnosticConsumer. - hasReplacedDiagnosticConsumer(): returns whether the default diagnostic consumer has been replaced.

view details

Javier Lopez-Gomez

commit sha c0cbfe1600317f836f7a2f87998d4c33a3886d69

[tcling] Implement `TCling::ReportDiagnosticsToErrorHandler()` This function allows users to route clang diagnostics to the ROOT error handler. Closes issue ROOT-7587.

view details

Olivier Couet

commit sha 72d0d6310f1041c9bc42aacf0bc8b53403695b16

[skip-ci] Add missing "s" (#8980)

view details

Ahmat

commit sha 42ddeb5bdbf938f78416213cd2e68741bb6c97df

[GSoC][TMVA][SOFIE] Add RNN operator (#8825) * Add RNN operator * Removed files from PR * Add missing default constructor * Add tests for RNN * Fix standard library headers handling * Add missing header for RNN * Small fixes * Fix RNN with different sequence lengths * Add documentation

view details

push time in 12 hours

PullRequestReviewEvent

Pull request review commentroot-project/root

[RF] Make it possible to store global observables in `RooAbsData` and consider these global observables in `RooAbsPdf::fitTo`

 ROOT_ADD_GTEST(testRooProductPdf testRooProductPdf.cxx LIBRARIES RooFitCore) ROOT_ADD_GTEST(testNaNPacker testNaNPacker.cxx LIBRARIES RooFitCore) ROOT_ADD_GTEST(testRooSimultaneous testRooSimultaneous.cxx LIBRARIES RooFitCore RooFit) ROOT_ADD_GTEST(testRooGradMinimizerFcn testRooGradMinimizerFcn.cxx LIBRARIES RooFitCore)+ROOT_ADD_GTEST(testGlobalObservables testGlobalObservables.cxx LIBRARIES RooFitCore RooFit)

Oh, but on second look: This introduces a dependency to RooFit, i.e., the entire set of libRooFit.so files needs to be compiled before you can run this test.

guitargeek

comment created time in 9 days

Pull request review commentroot-project/root

[RF] Make it possible to store global observables in `RooAbsData` and consider these global observables in `RooAbsPdf::fitTo`

 ROOT_ADD_GTEST(testRooProductPdf testRooProductPdf.cxx LIBRARIES RooFitCore) ROOT_ADD_GTEST(testNaNPacker testNaNPacker.cxx LIBRARIES RooFitCore) ROOT_ADD_GTEST(testRooSimultaneous testRooSimultaneous.cxx LIBRARIES RooFitCore RooFit) ROOT_ADD_GTEST(testRooGradMinimizerFcn testRooGradMinimizerFcn.cxx LIBRARIES RooFitCore)+ROOT_ADD_GTEST(testGlobalObservables testGlobalObservables.cxx LIBRARIES RooFitCore RooFit)
ROOT_ADD_GTEST(testGlobalObservables testGlobalObservables.cxx LIBRARIES RooFit)

I thought for a long time that you have to mention both, but CMake's transitive dependencies should allow for only mentioning RooFit. If it doesn't work, the CMake config needs to be fixed.

guitargeek

comment created time in 9 days

Pull request review commentroot-project/root

[RF] Make it possible to store global observables in `RooAbsData` and consider these global observables in `RooAbsPdf::fitTo`

 Double_t RooConstraintSum::evaluate() const }  +////////////////////////////////////////////////////////////////////////////////+/// Replace the varaiables in this RooConstraintSum with the global observables
/// Replace the variables in this RooConstraintSum with the global observables
guitargeek

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentroot-project/root

[CMake] Add automatic FAILREGEX for gtests

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

hageboeck

comment created time in 11 days

push eventhageboeck/root

Stephan Hageboeck

commit sha b99447f4167ed732e6e8e28cc41c1073314f8a9e

Include what you use in TFormula tests.

view details

Stephan Hageboeck

commit sha c1b053ad22f13a124db5f951d6fac64360f0a37f

Change how ROOTUnitTestSupport checks for diagnostics. - Save all expected diagnostics in a static vector. - Install a ROOT diagnostic handler callback. - Check/compare on destruction. - Allow for optional diagnostics. These will be caught, but it is not an error if they are not issued. - Allow for specifying only a partial diagnostic message (e.g. when addresses are printed).

view details

Stephan Hageboeck

commit sha 774809c5b493e1e6a61b6f0b385b1ede67c96b59

[RDF] Suppress diagnostics in dataframe_snapshot tests.

view details

Stephan Hageboeck

commit sha 166845f6689c34ac20a25fe2892e1c557b83f3bb

[RDF] Silence a diagnostic in datasource_sqlite.

view details

push time in 11 days

pull request commentroot-project/root

[CMake] Add automatic FAILREGEX for gtests

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

hageboeck

comment created time in 12 days

push eventhageboeck/root

Stephan Hageboeck

commit sha 6aa6116bfdd49999c2fca6760f54b3ebacb4a996

[Hist][NFC] Convert a constant into a constexpr.

view details

Stephan Hageboeck

commit sha 660e6e9c85d968db7ba8f237d25090ae0a8bf1fd

[DF] Try silencing a diagnostic in splitcoll_arrayview.

view details

Stephan Hageboeck

commit sha 08dcef6a83b28a498f7fff1ba9672c22516e82e4

[NFC] Convert constants in TError to constexpr.

view details

Stephan Hageboeck

commit sha 0753ff5c0ffa235df18ca01a0584daa8f11593c1

Include what you use in TClingTests

view details

Stephan Hageboeck

commit sha 4e2f5f35a263ba6d7e786ab4d3aea0843573bde1

Change how ROOTUnitTestSupport checks for diagnostics. - Save all expected diagnostics in a static vector. - Install a ROOT diagnostic handler callback. - Check/compare on destruction. - Allow for optional diagnostics. These will be caught, but it is not an error if they are not issued. - Allow for specifying only a partial diagnostic message (e.g. when addresses are printed).

view details

Stephan Hageboeck

commit sha 266a1c73e2856d308da0a2b00e046d0e40ef318b

[RDF] Suppress diagnostics in dataframe_snapshot tests.

view details

Stephan Hageboeck

commit sha a27e0f0569f19d203dc91ade0af9f654724b5aca

[RDF] Silence a diagnostic in datasource_sqlite.

view details

push time in 12 days

pull request commentroot-project/root

[CMake] Add automatic FAILREGEX for gtests

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

hageboeck

comment created time in 12 days

push eventhageboeck/root

Stephan Hageboeck

commit sha 1f8665dedabc741810aab3fea339725980934363

Change how ROOTUnitTestSupport checks for diagnostics. - Save all expected diagnostics in a static vector. - Install a ROOT diagnostic handler callback. - Check/compare on destruction. - Allow for optional diagnostics. These will be caught, but it is not an error if they are not issued. - Allow for specifying only a partial diagnostic message (e.g. when addresses are printed).

view details

Stephan Hageboeck

commit sha d5223e6998bd2d27a72d552ad40f28c29fdb281d

[RDF] Suppress diagnostics in dataframe_snapshot tests.

view details

Stephan Hageboeck

commit sha 09b2ebeeebbad99cae0da0ffd3274170e8b62be8

[RDF] Silence a diagnostic in datasource_sqlite.

view details

Stephan Hageboeck

commit sha e1675d9fe128c8e9b385a34db7fe34802dbd05c5

Include what you use in TClingTests

view details

push time in 12 days

push eventhageboeck/root

Stephan Hageboeck

commit sha c8c64290ef5383f9b508d624cf04b74db4eb0bef

[NFC] Make const Int_t in TError constexpr.

view details

Stephan Hageboeck

commit sha 0b8cf7ac3cac62307fcbbfaaed181b6eb4ba7dbc

Change how ROOTUnitTestSupport checks for diagnostics. - Save all expected diagnostics in a static vector. - Install a ROOT diagnostic handler callback. - Check/compare on destruction.

view details

Stephan Hageboeck

commit sha 36fceba1c1799cece0c609d388c733373992a536

[RDF] Suppress diagnostics in dataframe_snapshot tests.

view details

Stephan Hageboeck

commit sha f69fbbfd8e68541c38da7729e9c336625cd4b150

[RDF] Silence a diagnostic in datasource_sqlite.

view details

Stephan Hageboeck

commit sha 1b167adb8ded17c2df435b4358c06a0c806a0db3

Include what you use in TClingTests

view details

Stephan Hageboeck

commit sha 02f47e2a4100794551a7fdc2e9e99b7a123868f2

squash! Change how ROOTUnitTestSupport checks for diagnostics. - Allow for optional diagnostics. These will be caught, but it is not an error if they are not issued. - Allow for specifying only a partial diagnostic message (e.g. when addresses are printed).

view details

push time in 12 days

Pull request review commenthsf-training/cpluspluscourse

Add two slides about clang-format

   \end{minted} \end{frame} +\subsection[format]{Code formatting}++\begin{frame}[fragile]+\frametitle{clang-format}+\begin{block}{.clang-format}+	\begin{itemize}+		\item file describing your formatting preferences+		\item should be checked-in at the repository root (project wide)+		\item \mintinline{bash}{clang-format -style=LLVM -dump-config >} \\+		  \mintinline{bash}{.clang-format}+		\item adapt style options with help from: \url{https://clang.llvm.org/docs/ClangFormatStyleOptions.html}+	\end{itemize}+\end{block}+\begin{block}{Run clang-format}+	\begin{itemize}+		\item \mintinline{bash}{clang-format --style=LLVM -i <file.cpp>}+		\item \mintinline{bash}{clang-format -i <file.cpp>} (looks for .clang-format file)+		\item \mintinline{bash}{git clang-format} (formats local changes)+		\item \mintinline{bash}{git clang-format <ref>} (formats changes since git \textless{}ref\textgreater{})+		\item Some editors/IDEs find a .clang-format file and adapt+	\end{itemize}+\end{block}+\end{frame}++\begin{frame}[fragile]+\frametitle{clang-format}+\begin{alertblock}{Exercise Time}+	\begin{itemize}+		\item go to any example+		\item format code with: \mintinline{bash}{clang-format --style=GNU -i <file.cpp>}+		\item inspect changes, try \mintinline{bash}{git diff}+		\item revert changes using \mintinline{bash}{git checkout <file.cpp>}
		\item revert changes using \mintinline{bash}{git checkout -- <file.cpp>}

? In my git, I need the -- to really check out a file. It might otherwise conflict with branch names.

bernhardmgruber

comment created time in 15 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentroot-project/root

Updates to RooFit tutorials necessary before the next release #8808

Hello @edfink234,

welcome on the project. I think that the file that you worked with isn't by anything. It's from a time when tutorials weren't run automatically. I invite you and @guitargeek to check that what I'm claiming here is correct. The real tutorials are in tutorials/roofit. If those files indeed aren't used anywhere (I'm pretty sure they are not), I would suggest to delete them.

edfink234

comment created time in 15 days

pull request commentroot-project/root

[CMake] Add automatic FAILREGEX for gtests

@phsft-bot build just on ROOT-performance-centos8-multicore/default with flags -DCTEST_TEST_EXCLUDE_NONE=On

hageboeck

comment created time in 15 days

push eventhageboeck/root

Stephan Hageboeck

commit sha a158179dab50092ea5ddaf9b0cfbcfb8837233e1

[Hist] Suppress diagnostic due to roundoff errors.

view details

Stephan Hageboeck

commit sha d0187064216f9a945c6bc9b55852928bf7a3b71a

[Hist] Declare a constant constexpr.

view details

Stephan Hageboeck

commit sha ce0f319da6419115c5a7f3b2e973ad59fccd67e8

[DF] Try silencing a diagnostic in splitcoll_arrayview.

view details

push time in 15 days

pull request commentroot-project/root

[CMake] Add automatic FAILREGEX for gtests

@phsft-bot build just on ROOT-performance-centos8-multicore/default with flags -DCTEST_TEST_EXCLUDE_NONE=On

hageboeck

comment created time in 15 days

push eventhageboeck/root

Jonas Rembser

commit sha cdba67864444ff03c37166de31b594c5d48b811f

[core] Add new `ROOT/StringUtils.hxx` file with `ROOT::Split` function The `ROOT::Split` function splits a string in the same way as the `str.split` function from Python.

view details

Jonas Rembser

commit sha 46940dcccb458ec19724add8d92a930d289a130d

Use `ROOT::Split` in `hist` and `tree` components

view details

Jonas Rembser

commit sha ed916d242f172ae71c1efb11e504dfd3ed548774

[RF] Replace `RooHelpers::tokenise()` with `ROOT::Split()`

view details

Vassil Vassilev

commit sha 28f8835b76f79633b8ae74a7f78259ac5817fd0d

[cxxmodules] We are not yet ready to enable the module for R. We need several adjustments to do. First pre-loading of RInterface.pcm in root-project/root@5096f5fffc causes some crashes. Second we seem to still have issues when trying to resolve symbols from the Rcpp library.

view details

Bertrand Bellenot

commit sha fe88911b8cfe5a0e4285ca9ec07681b5c6a0f958

Silent a couple of potential CMake Warnings (#8832) * Silent a couple of potential CMake Warnings Silent the following warnings when enabling arrow (`-Darrow=ON`) on Ubuntu: ``` CMake Warning at cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package): By not providing "Findre2.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "re2", but CMake did not find one. Could not find a package configuration file provided by "re2" with any of the following names: re2Config.cmake re2-config.cmake Add the installation prefix of "re2" to CMAKE_PREFIX_PATH or set "re2_DIR" to a directory containing one of the above files. If "re2" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): /usr/lib/x86_64-linux-gnu/cmake/arrow/Findre2Alt.cmake:25 (find_package) cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package) /usr/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package) /usr/lib/x86_64-linux-gnu/cmake/arrow/ArrowConfig.cmake:96 (find_dependency) cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package) cmake/modules/FindArrow.cmake:206 (find_package) cmake/modules/FindArrow.cmake:313 (arrow_find_package_cmake_package_configuration) cmake/modules/FindArrow.cmake:350 (arrow_find_package) cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package) cmake/modules/SearchInstalledSoftware.cmake:1088 (find_package) CMakeLists.txt:245 (include) ``` and ``` CMake Warning at cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package): By not providing "Findc-ares.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "c-ares", but CMake did not find one. Could not find a package configuration file provided by "c-ares" with any of the following names: c-aresConfig.cmake c-ares-config.cmake Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or set "c-ares_DIR" to a directory containing one of the above files. If "c-ares" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): /usr/lib/x86_64-linux-gnu/cmake/arrow/Findc-aresAlt.cmake:25 (find_package) cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package) /usr/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package) /usr/lib/x86_64-linux-gnu/cmake/arrow/ArrowConfig.cmake:96 (find_dependency) cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package) cmake/modules/FindArrow.cmake:206 (find_package) cmake/modules/FindArrow.cmake:313 (arrow_find_package_cmake_package_configuration) cmake/modules/FindArrow.cmake:350 (arrow_find_package) cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package) cmake/modules/SearchInstalledSoftware.cmake:1088 (find_package) CMakeLists.txt:245 (include) ``` * Update cmake/modules/SearchInstalledSoftware.cmake Co-authored-by: Enrico Guiraud <enrico.guiraud@cern.ch> Co-authored-by: Enrico Guiraud <enrico.guiraud@cern.ch>

view details

Enrico Guiraud

commit sha 9d5fdcfa24223c9e8850f70c9aff1b2d6605615b

[DF] Remove unused helper types

view details

Enrico Guiraud

commit sha 4183906b397bd98bc90df06a12e4262ea3a6e522

[DF][NFC] Switch helper types to new naming convention

view details

Enrico Guiraud

commit sha 7bfce35d680a526dcbf100903b66861a94eb3f03

[DF] Extract R[OneTime]Callback helper types from RLoopManager To make the class more readable.

view details

Jonas Rembser

commit sha 91f2f075edbb5eebc69fe81e8c73d3a6a6c51f42

[RF] Use smart pointers in RooAbsCachedPdf

view details

Jonas Rembser

commit sha 52676828565718024ebfaefe3c544f46db5ba73e

[RF] Replace TString with std::string in RooAbsCachedPdf

view details

Jonas Rembser

commit sha 686de808bcd225e3ed67f28b4a847a398e4dd64d

[RF] Various code modernizations in RooAbsCachedPdf * replace `kTRUE` with `true` and `kFALSE` with `false` * replace `Double_t` with `double` * replace `Int_t` with `int` outside of data members * replace `0` with `nullptr` literals * replace C-style casts with `static_cast` * don't generally use `namespace std` * use `RooAbsCollection::empty()` and `RooAbsCollection::size()` instead of `RooAbsCollection::getSize()`

view details

Enrico Guiraud

commit sha da3bb82bfb0e3ab6d70859e685ad186933045567

[DF][NFC] Sync include guards with class name

view details

Enrico Guiraud

commit sha 0123103a41943370cc82386800bee502e66e81ef

[DF][NFC] Reorder includes in RInterface.hxx

view details

Enrico Guiraud

commit sha 408c8c11d9b9b162298e313debb32d6ee0019d0e

[DF][NFC] Add two missing includes in RInterface.hxx

view details

Omar Zapata

commit sha 1df57d3d96b3560681000326b20013582875ccec

ROOT-R: reverted change in macro define introduced in https://github.com/root-project/root/commit/4809ef48e9d3cc48bfe5f81f971a5c535b593b39 for RExports.h

view details

Baidyanath Kundu

commit sha 751bf6396a0eb3c094ed963ac94df075e2dd0d30

[clad] Bump clad version to v0.9. This new release includes some improvements: * Extended array support * Add cmake variables to control the locations where find_package discovers LLVM and Clang: `LLVM_CONFIG_EXTRA_PATH_HINTS` and `Clang_CONFIG_EXTRA_PATH_HINTS` respectively. See more at: https://github.com/vgvassilev/clad/blob/v0.9/docs/ReleaseNotes.md

view details

Bertrand Bellenot

commit sha 40375b92c22068199fb1171babf4ed95bb5d6794

Improve the FindArrow warning workaround (#8849) Move the `QUIET` `find_package` option from `SearchInstalledSoftware.cmake` to `FindArrow.cmake`. Thanks to Guilherme Amadio for the suggestion

view details

Sanjiban Sengupta

commit sha 6f3149b405aca6abc7e7c08e2e48ef058fe0714b

Remove: RModelParser_ONNX+ from sofie/inc/LinkDef.h

view details

will buttinger

commit sha 502a63f1aed8cb24d18e784fbc3a640d6216bce3

Cleanup workspace

view details

Jonas Rembser

commit sha 2f7936a3ffed281802dd7854fdca39e98cfd579f

[RF] Implement `RooLinkedList::begin()`, `end()`, `rbegin()`, `rend()` Implements `RooLinkedList::begin()`, `end()`, `rbegin()`, `rend()` and extends the `RooLinkedListIterImpl` interface to support range-based loops for the `RooLinkedList`. Range-based loops on `RooLinkedList` are also used in some places in RooFit to test this new feature. In particular the function `RooCmdConfig::process` is used in basically every RooFit script. This commit also adds `RooLinkedList::size()` and `empty()` for better compatibility with STL containers and automatic pythonizations.

view details

push time in 15 days

push eventhageboeck/rootbench

Oksana Shadura

commit sha b97778a379d90aa30927022a9fc41dbb8ba2df9c

Try to update Ubuntu image for Travis bot

view details

Stephan Hageboeck

commit sha 6f8dd82a8c4f6139bd484baae8292a7d89e0ad93

[RF] Add benchmarks for a few vectorised PDFs. - Add benchmarks for Gauss, Johnson and addition of PDFs. - Benchmarks test vectorised/batched code against legacy for - Function evaluation - Likelihood computation - Log-likelihood computation

view details

Stephan Hageboeck

commit sha c0c827992236316f16d412e5e30b68f8a46fa774

[RF] Add MathCore dependency for RooFit benchmarks.

view details

Stefan Wunsch

commit sha 059f39fa053cbfb4abfc677b9dbda9f7617794e6

[TMVA] Exclude TMVA cross-validation benchmark if TMVA not enabled

view details

Oksana Shadura

commit sha 2c2572d7a10411fed4da6166e7057f83562e0970

Adjust home dir with env var for Travis

view details

Oksana Shadura

commit sha c9ab9072c1c3911de8d46435c0df69ff4b988838

Update lcov version

view details

Oksana Shadura

commit sha e799570ccca7a0e8b660e438c35e1298d89a56a4

Change coverals build combination to gcc-5

view details

Oksana Shadura

commit sha 8794457fbdc1c1f01582c5e7629ad057472ead2f

Add ZSTD RDFSnapshot benchmark

view details

Oksana Shadura

commit sha b7034d173501e2b6c1a434fc9f4b3ee03950866a

Allow --allow-unauthenticated installation of cvmfs

view details

Claire Guyot

commit sha 110151c69fa4c8dbfef9902ee131c0255c7f965d

[hist] Benchmarking for TH2D::Fill is possible

view details

Claire Guyot

commit sha a139bf8cf0fcae57d2bb081adae7f204d9e58818

[histv7] adding benchmarking for RHist::Fill

view details

Claire Guyot

commit sha deabcc92f3181ba77bd7ec3f4b30f2ab013bc58f

[histv7] adding arguments to benchmark for RHist::Fill

view details

Claire Guyot

commit sha 1a4b0d9deccf5ee03e003bbe02d3b6875bff7160

[histv7] fixes for PR on RHist::Fill benchmarks

view details

Claire Guyot

commit sha 29d5195b6277d9de76fe1a3c363561d075b214a2

[histv7] adjust benchmark arguments

view details

Claire Guyot

commit sha 27ddff1c561ef1d66f861015e69857964b6cbf95

[histv7] adjust benchmark arguments to match travis build time

view details

Oksana Shadura

commit sha f8b7fd1ff15d635a143e5891c6ee8e84807f114a

Add protection for RootHist benchmark (ROOT shoudl be compiled only with root7=ON)

view details

Oksana Shadura

commit sha 22a59ffd1024d13824468908e4489b9a9f101f43

Add RNtuple benchmarks with support of downloading big files

view details

Oksana Shadura

commit sha 136c61e8ff97997f887f7d392ed630ba4f3ed0d7

Add data generation for RNTuples (format is changing pretty often)

view details

Oksana Shadura

commit sha e399ae43b9afbd85da06e36a99989a796f8d9135

Cleanup Linkdef file (thanks Philippe)

view details

Oksana Shadura

commit sha 4e9e29a5e98ff7d3b58c735527ff74fa4c3d522a

Clang-format file (too long lines)

view details

push time in 15 days

Pull request review commentroot-project/root

[RF] Make it possible to store global observables in `RooAbsData` and consider these global observables in `RooAbsPdf::fitTo`

 class RooAbsData : public TNamed, public RooPrintable {    static StorageType getDefaultStorageType(); +  RooArgSet const* getGlobals() const { return _globalObservables.get(); }

While reading through the rest of the commits, I actually noticed that the function name isn't so great. It looks like dealing with c++ globals. It should at least mention GlobalObservables.

guitargeek

comment created time in 16 days

PullRequestReviewEvent

Pull request review commentroot-project/root

[RF] Make it possible to store global observables in `RooAbsData` and consider these global observables in `RooAbsPdf::fitTo`

 void RooAbsOptTestStatistic::initSlave(RooAbsReal& real, RooAbsData& indata, con    optimizeCaching() ; +  // It would be unusual of the global observables are used in the likelihood

of --> if consistend --> consistent

guitargeek

comment created time in 16 days

Pull request review commentroot-project/root

[RF] Make it possible to store global observables in `RooAbsData` and consider these global observables in `RooAbsPdf::fitTo`

 Bool_t RooAbsOptTestStatistic::setDataSlave(RooAbsData& indata, Bool_t cloneData    setValueDirty() ; -//   cout << "RAOTS::setDataSlave(" << this << ") END" << endl ;+  // It would be unusual of the global observables are used in the likelihood+  // outside of the constraint terms, but if they are we have to be consistend+  // and also redirect them to the snapshots in the dataset if appropriate.

As above.

guitargeek

comment created time in 16 days

Pull request review commentroot-project/root

[RF] Make it possible to store global observables in `RooAbsData` and consider these global observables in `RooAbsPdf::fitTo`

 class RooAbsTestStatistic : public RooAbsReal {     bool cloneInputData = true;     double integrateOverBinsPrecision = -1.;     bool binnedL = false;+    bool takeGlobsFromData = false;

constrant in the commit message.

guitargeek

comment created time in 16 days