profile
viewpoint

gyzerok/adrenaline 721

Simple Relay alternative

codeamigos/gymple 1

Application for GYM

codeamigos/ratee 0

Gather feedback from your customers

gyzerok/aacl 0

Another ACL for Kohana 3. Please see README.md for a justification of this indulgence.

gyzerok/alt 0

Isomorphic flux implementation

gyzerok/atom-react 0

ReactJS Support for atom (syntax, snippets)

gyzerok/awesome-elm 0

A curated list of useful Elm tutorials, libraries and software. Inspired by awesome list. Feel free to contribute. :rocket:

gyzerok/awesome-graphql 0

Awesome list of GraphQL & Relay

issue commentmicrosoft/vscode

File with Chinese chars appears as changed right after opening

@bpasero I think this is happening when a multi-byte character ends up on the 64kb boundary.

Let's say it is 2 byte character. Then you get 1 byte in the first chunk and 1 in the second. By simply calling toString() on the buffers you end up with it being interpreted as 2 single byte characters and thus it gets corrupted.

The solution would be to use streaming converter such as TextDecoder or StringDecoder. Notice that TextDecoder exists in both - browser and node, so likely is a better choice.

mkvoya

comment created time in 16 hours

issue commentbmewburn/vscode-intelephense

Performance improvements

Wow, that was quick! 😄

Thank you! I will check it during my work next week.

gyzerok

comment created time in 21 hours

issue commentashtuchkin/iconv-lite

Support using ArrayBuffer as the "bytes" data type (instead of Buffer)

Overall your plan sounds very solid. I think we can go with it and adjust along the way if need be.

Ideally I would chunk it into smaller pieces which could be done independently. At least for me it makes it easier to move forward when I can complete something within 2-4 hours timeframe when I have some free time.

Would it be possible for you to draft this smaller pieces? At least some initial ones. For example I can look at the implementation of the BufferAPI you've proposed in the browser.

First, let's clearly define a success criteria for this project.

Your criteria sounds exactly right, let's go with it 👍

Second, to make webpack/browserify not include Buffer shim, we need to be careful about dependencies and dependency injections.

Honestly I don't know how well browser entry point is supported by the tooling. In any case consumers will be able to import the version they need directly.

We also need a "concat" operation on the Buffer/Uint8Array type in several places

Hm, I've thought you removed Buffer.concat usage all together.

The only hard part here would be streaming utf8, but we can use StringDecoder implementation like you proposed.

Actually I completely forgot to mention that TextDecoder supports streaming, so technically we might not even need StringDecoder.

Also I've discovered that Node has support for TextDecoder and TextEncoder APIs from version 8.3.

This in practice means that we get utf8 encode/decode for free in both environments. Of course good for you to double-check since I am no pro in encoding business :) Is

Also TextDecoder in both environments does seem to support a lot of other encodings. I am wondering if it can be used to our benefit. I would at least hypothesize that it is implemented in C and thus can give performance improvements over JavaScript implementation. Anyway this a bit off-topic to the current goal.

ashtuchkin

comment created time in 21 hours

issue commentmicrosoft/iconv-lite-umd

Tests from iconv-lite are not passing

I have identified the source of the last error.

// Node
Buffer.from([0x61]).toString('utf16le') == ''
// feross/buffer
Buffer.from([0x61]).toString('utf16le') == '\u0000'

Will see what I can do about it.

bpasero

comment created time in 2 days

pull request commentfeross/buffer

Different behaviour from node.js for utf16leSlice

Hello @roaringUnicorn!

I seem to get a similar issue. Can you confirm that this is the source of it?

// Node
Buffer.from([0x61]).toString('utf16le') == ''
// feross/buffer
Buffer.from([0x61]).toString('utf16le') == '\u0000'
roaringUnicorn

comment created time in 2 days

push eventgyzerok/iconv-lite

Alexander Shtuchkin

commit sha efbad0a92edf1b09c111278abb104d935c6c0482

Release 0.6.2: Actually support Uint8Array decoding

view details

push time in 2 days

issue commentashtuchkin/iconv-lite

Support using ArrayBuffer as the "bytes" data type (instead of Buffer)

Hello @ashtuchkin!

Big thanks to you for finishing a lot of work already to make this migration possible! 🎉

I would like to help you moving forward with this. But before doing any PRs it would be great to get your feedback on the following plan.

The plan

Step 1

Change tests so that they don't expect Buffer as an output => we can gradually migrate iconv-lite to use Uint8Array exclusively.

Here is an example of what it would mean:

-assert.strictEqual(iconv.encode(testStringBase64, "base64").toString("binary"), testString);
+assert.strictEqual(Buffer.from(iconv.encode(testStringBase64, "base64")).toString("binary"), testString);

Step 1

  1. As you suggested, create our own light module with helpers to do things like buffer.toString(encoding) and Buffer.from(str, encoding) and migrate everything to use it instead ofBuffer`.

Initially I suggest we just draft the API and internally still use Buffer. This will make it a single place to be modified when doing actual migration away from Buffer.

So initial implementation would be something like

function toString(buffer, encoding) {
  if (!Buffer.isBuffer(buffer)) {
    buffer = Buffer.from(buffer);
  }
  return buffer.toString(encoding);
}

function toBuffer(str, encoding) {
  return Buffer.from(str, encoding);
}

Step 1

  1. Node has a pure JavaScript implementation for StringDecoder with a single exception - it uses Buffer. We can now copy it and change Buffer usage to our own helpers.

Step 1 4. Looks like we are all set now and the last thing we need to do is to implement our helpers for the Buffer-less environments.

  1. Try to change tests so that the same suite runs both in Node and in the browser. The only tricky part here I see is your usage of iconv, which we won't be able to run in the browser. Maybe there is a way to pregenerate fixtures with it before tests, so we can simple use them?

Other

I think that steps 1 and 2 could be actually done in parallel in a way that 1 module is selected and both internal Buffer usages and tests are changed for it. And personally I would prefer this way of doing things, because: a) it feels more fun to me b) we can parallelize work on different decoders if you are up for it.

Also given your target versions for support I think we can freely get rid of safer-buffer now.

ashtuchkin

comment created time in 2 days

issue commentmicrosoft/iconv-lite-umd

Tests from iconv-lite are not passing

Hello @bpasero! I've looked into this as promised.

Especially Error: Bad argument worries me because I thought any Buffer usage is removed in 0.6.2

It's not exactly like that. In 0.6.2 what changed is that iconv-lite won't expect input to be a Buffer. So it won't use any Buffer specific methods on the input (like Buffer.concat) for example. This makes it safe for us to pass in Uint8Array. However internally Buffer is still used.

With most errors you are seeing the problem is not with the library itself or with our webpack build, but with the fact that tests are written without any expectation that they could be run against umd build where Buffer is shimmed.

So the library creates and returns buffers using it's shimmed Buffer, but tests are expecting it to be Node Buffer. These are not compatible and that's why everywhere Buffer.isBuffer is used the problem arises.

After reading this you might start wondering if it means same problem for VSCode when running in Electron. And according to my understanding it is not the case, because we don't expect Buffer as an output, but simply Uint8Array, which means that we won't be using any Buffer specific methods on the output and thus won't have these errors.

Now the only error here which concerns me personally is

  8) UTF-16 decoder handles very short buffers nice:

      AssertionError [ERR_ASSERTION]: '\u0000' == ''
      + expected - actual

      -�
      
      at Context.<anonymous> (test/utf16-test.js:45:16)
      at processImmediate (internal/timers.js:456:21)

I will look into it. And here is my suggestion: I don't think VSCode nor iconv-lite benefit from tests extracted and modified here. For VSCode team it means additional maintenance burden and for iconv-lite it means that nothing gets improved. To avoid this I will try to contribute to the iconv-lite tests directly and hopefully help to move more of them in the browser. Does this make sense?

bpasero

comment created time in 2 days

issue commentbmewburn/vscode-intelephense

Performance improvements

Thanks, is it worse when many files are open?

I'll try to check this. However I mostly work with 2 huge files, so only they tend to be open. Either only one or both.

Also there are a lot of usages of globally defined things, which I expect would result in more files being parsed. Dunno if this helps anyhow.

Does the code have thorough type declarations and annotations or is this patchy?

It is patchy. Older code does not have them and new code mostly does.

gyzerok

comment created time in 2 days

issue commentbmewburn/vscode-intelephense

Performance improvements

It looks like on the small files in the same codebase autocomplete actually starts working. So my performance problems must have to do with the fact that I mostly work in a huge files.

gyzerok

comment created time in 2 days

issue commentmicrosoft/vscode-remote-release

Support custom remote ports

Thank you for coming back to the issue!

Would it be possible in the meantime to provide some temporary setting in nightly? It won’t lock you into any particular design/decision, but will help those of us who are struggling currently.

umdstu

comment created time in 2 days

issue commentmicrosoft/vscode-remote-release

[SSH] Add config option for host and port on which vscode-server is started on the remote

Closing because it seems to be a duplicate.

gyzerok

comment created time in 3 days

issue closedmicrosoft/vscode-remote-release

[SSH] Add config option for host and port on which vscode-server is started on the remote

Dear VSCode Remote Extensions team,

first of all let me thank you for the great work you are doing!

The problem

On the remote host I am using for development port forwarding is allowed, however only for specific pairs of host and port. Currently there seems to be no way to tell Remote - SSH extension which address I would like vscode-server to run on.

For example, I can only forward localhost:3000, but 127.0.0.1:3000 is not allowed.

To verify that my understanding is correct I've created simple node http server and then tried making ssh tunnels on allowed host/port and not allowed host/port. I can confirm that this is indeed the issue.

Proposed feature

Allow to specify host and port on which vscode-server will be started on in the extension settings.

// settings.json
{
  "remote.SSH.remote-address": {
    "host1": "127.0.0.1:8000",
    "host2": "localhost:3000"
  }
}

For future readers

To make it easier for VSCode team to react to this issue I am kindly asking you to avoid writing +1 comments. Please just add your reaction 👍 to the original post. Thank you!

closed time in 3 days

gyzerok

issue commentmicrosoft/vscode-remote-release

Support custom remote ports

It look like my issue is a duplicate of this one. I will close it in favor of this issue.

umdstu

comment created time in 3 days

issue commentmicrosoft/vscode-remote-release

[SSH] Add config option for host and port on which vscode-server is started on the remote

Recently I was able to finally use Remote - SSH, because it started running server on a static address in nightly extension release. So it seems to be not a hard problem to fix on the extension side.

However now after updating VSCode to 1.47 the issue have returned. I start wondering now if this is intentional and not accidental.

gyzerok

comment created time in 3 days

issue openedbmewburn/vscode-intelephense

Performance improvements

Feature description or problem with existing feature I am working with quite large codebase with thousands of files and millions LOC. Some files can be up to 12k LOC.

  1. Hover popups on symbols take seconds to display (maybe 3-5)
  2. Autocomplete doesn't seem to work at all (probably just takes much longer than the typing)
  3. When I type new code it seems that it's parsing is struggling. I get error line under the code I type, which would show errors from after some symbols were typed (however I finished typing correct code already) and this errors will resolve only after tens of seconds.

Describe the solution you'd like Maybe a release heavily focused on performance optimizations 😄

Additional context I can't share any code with you, but if there are any stats I can collect which would help you identify the problem, I can see what I can do.

Perhaps you can also use some large open-source codebases such as Drupal to analyze the bottlenecks.

created time in 4 days

issue commentmicrosoft/vscode

[Bug] When opening files of encoding GB-2312, File is truncated if one character's DBCS 2-byte code crosses multiple of 64k border

@bpasero I agree, it would be definitely even safer. However I would personally expect webpack to be trustable enough to not mess things up by itself.

WilliamStone

comment created time in 5 days

issue commentmicrosoft/iconv-lite-umd

Tests from iconv-lite are not passing

@bpasero I see.

No worries. I've decided to take a small break. Was using most of my free time before to make everything work 😄 But I am confident we can fix everything for July release. I will get back to it this weekend then.

bpasero

comment created time in 5 days

issue commentmicrosoft/iconv-lite-umd

Tests from iconv-lite are not passing

@bpasero did you also try 0.6.2?

bpasero

comment created time in 5 days

issue commentmicrosoft/vscode

[Bug] When opening files of encoding GB-2312, File is truncated if one character's DBCS 2-byte code crosses multiple of 64k border

@bpasero I am currently on it.

The footgun is located here. It seems like it's some corner case I missed when making a patch for iconv-lite and new tests I added there didn't catch this case.

Can't get node: false to work either. However it works if you set target: node. This is a bit of a hotfix, however Alex already have made the patch to support Uint8Arrays directly it is just not released yet. So shouldn't be a problem for us to remove this hotfix for the July release.

I have tested hotfix myself with the provided file and everything seems to work. Test suite also works completely.

Here is a setup for you, so you can test it yourself quickly: mkdir vscode-hotfix && git clone https://github.com/gyzerok/vscode vscode-hotfix && cd vscode-hotfix && git checkout encoding-hotfix-test

This will install my custom iconv-lite-umd with https://github.com/gyzerok/iconv-lite-umd/commit/28088a01f1e9e1659f0cfa04b083ee93f8b12911#diff-11e9f7f953edc64ba14b0cc350ae7b9dR19.

WilliamStone

comment created time in 5 days

create barnchgyzerok/vscode

branch : encoding-hotfix-test

created branch time in 5 days

create barnchgyzerok/iconv-lite-umd

branch : no-buffer-shim

created branch time in 5 days

push eventgyzerok/iconv-lite

Alexander Shtuchkin

commit sha 3331bbc3ba02e15d11935326dc320d15ee5add43

Fix minor issue in UTF-32 decoder. In streaming mode, if the first chunk is < 32 bytes, but there are more chunks written with total size of the stream > 32 bytes, then we were losing initial chunk. This looks like an unlikely scenario, so not a major issue. Note, this is happening only in UTF-32 decoder, not UTF-32LE or BE, as the problem was in the code that detects encoding.

view details

Fedor Nezhivoi

commit sha dd72d9d5238f84c104d5ee4f93748365d308e60b

Support Uint8Array-s instead of Buffers when decoding (#246)

view details

Alexander Shtuchkin

commit sha 724829e8fc39525fbeded0f837da53c13de179ae

Release 0.6.1: Support Uint8Array when decoding.

view details

Alexander Shtuchkin

commit sha 21004dd4c642b76575449d6bdd4de72a834b965b

Ensure all decoders support Uint8Array-s directly

view details

push time in 5 days

push eventgyzerok/iconv-lite-umd

Fedor Nezhivoi

commit sha 97ff6e4fcfd65041075c78165d73261553faa48d

add umd build of iconv-lite

view details

Fedor Nezhivoi

commit sha 7e52b4a8002e157ee660e78cad83808dc555eaf8

update to 0.6.0

view details

Fedor Nezhivoi

commit sha 57e244a9bf484832bdd40d004d6e427fe6b388b3

ignore fake-loader in npm distribution

view details

Benjamin Pasero

commit sha 2e9d7d50e9359ddda00971ca6ffb830b9320bfb9

Merge pull request #1 from gyzerok/patch-1 add umd build of iconv-lite

view details

Fedor Nezhivoi

commit sha 98adbcc2befea84b4e3df2854277ebb6cd98df26

don't use inline source-maps (#2)

view details

Benjamin Pasero

commit sha c46cb91cb91f85a999ef3030db47e4e995014042

bump@0.6.1

view details

Benjamin Pasero

commit sha dc8801d9bf880da2a412070e462fd9127df0e343

more npm excludes

view details

Fedor Nezhivoi

commit sha 70226d91128de47abc54b98ef44406824546b145

change signatures form Buffer to Uint8Array (#3)

view details

Fedor Nezhivoi

commit sha b0be6944eb45273394e536a7f73393fabda3e417

migrate decode and encode to use Uint8Array (#4)

view details

Benjamin Pasero

commit sha 68574fceb44487e3f39e3f81b35e7b302758d13e

bump@0.6.3

view details

Fedor Nezhivoi

commit sha 11a6402f6fdbab704abc2049c2fb957fe3d140cc

update iconv-lite to 0.6.1 (#5)

view details

Benjamin Pasero

commit sha 9c17d27840833d87a2c349fd6dd7d09f07f928c3

bump@0.6.4

view details

Benjamin Pasero

commit sha 26baf3233e14e8a34a852fe6b36baf9d6ff13f8e

:up: 0.6.5

view details

Benjamin Pasero

commit sha 6cc48fdd57904dfe84f33e72a1f294b8a7327a7a

back to before

view details

Benjamin Pasero

commit sha f4180d8044930d3e2c65d73123f030511f1f3f0d

do not exclude cp949

view details

push time in 5 days

issue commentmicrosoft/vscode

Encoding euckr does not exist anymore

@bpasero I can take a look tomorrow. Quick idea - this because of

https://github.com/microsoft/iconv-lite-umd/blob/6cc48fdd57904dfe84f33e72a1f294b8a7327a7a/webpack.config.js#L3-L14

bpasero

comment created time in 5 days

startedrileytestut/AltStore

started time in 7 days

issue commentcdr/code-server

support other encodings than UTF-8

Definitely! We'll try to get on this at some point but welcome a PR as well.

I am afraid merging your vscode patch with vscode changes requires much deeper knowledge of how things work together than I currently have.

LeuisKen

comment created time in 8 days

issue commentmicrosoft/vscode

Web: support other encodings than UTF-8

I would like to also thank everyone envolved:

  • @LeuisKen for reporting the issue and inspiring me to give it a shot with his own contributions
  • @bpasero for lying down initial plans and helping me to get this done
  • @ashtuchkin for being so responsive on iconv-lite side and giving amazing advice on bundle size reduction

Love the open-source community! ❤️

bpasero

comment created time in 8 days

pull request commentmicrosoft/vscode

fix #79275 enable encodings for web

Yeah that sounds about right, the only reason it was not there before is because encoding.ts was in base layer. But now that it moved in workbench, I am fine moving it over.

Cool, that's exactly the reason though you've had before :)

I think it is always good to correlate a PR back to an issue, e.g. in our testing process at the end of the month we use issues to verify new features or bug fixes. Having a PR without an issue would not allow us to follow that process.

How would I connect something like moving SUPPORTED_ENCODINGS to an issue. The one for encodings support is closed now. Plus this is more of a refactoring, it has nothing to do with the issue itself. Should I create a fresh issue for that to follow this process?

Is there an area in particular where you thought about contributing?

Thanks you for suggesting which categories of issues I can look at.

I think I'll try to see if there are issues I can solve on the web side. While I am waiting Remote - SSH to allow to select static port to run server on, I am stuck with using web version 😄 Might as well help you improve the experience on that front. Basically encodings was the area which I was personally missing.

Also I highly appreciated your test coverage, which helped a lot during my work. I will see if I can make it even better!

gyzerok

comment created time in 8 days

delete branch gyzerok/vscode

delete branch : enable-encoding-for-web

delete time in 8 days

PR closed feross/buffer

remove redundant latin1Write function

Hello!

It looks like the function isn't needed. Am I missing something?

+1 -7

1 comment

1 changed file

gyzerok

pr closed time in 8 days

pull request commentfeross/buffer

remove redundant latin1Write function

Closing since I perefer my lists of PRs to be clean and this doesn't seem to get any traction.

gyzerok

comment created time in 8 days

issue commentcdr/code-server

support other encodings than UTF-8

@nhooyr finally all of the work needed for this is merged to upstream.

Should be in the next couple weeks and their's will be much smaller.

In the end we were able to make the size much smaller, so you are right 😄

Unfortunately it didn't make in time for the June release. Would it be possible to update code-server so that it includes the fresh release (we seem to be lagging behind now) plus commits needed for this feature to work?

LeuisKen

comment created time in 8 days

delete branch gyzerok/vscode

delete branch : remove-jschardet-types-workaround

delete time in 8 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 0d978c243f5b1c429f1ad19c14ec67a86fff96d2

fix one more place and prettify object

view details

push time in 9 days

issue openedmicrosoft/iconv-lite-umd

How to ensure that install is called before new version is published

@bpasero

@gyzerok oh, it would be great if yarn could run as part of the prepublish to fix that in the future.

I've looked into it a bit. Unfortunately when you run yarn the prepublish hook is called automatically. Which means that if you put yarn inside prepublish, you get an infinite loop of installs.

Personally I've had great experiences publishing to npm from CI. This way you just push the new tag and CI will do the rest: install, build and publish.

If it sounds good I think you can use GitHub Actions to make this work. Unfortunately I can't really make it myself since you need to generate an npm secret to make it work.

created time in 9 days

pull request commentmicrosoft/vscode

remove jschardet typings workaround for #79275

Whoops, bot misassigned it. I think it is better suited for @bpasero.

gyzerok

comment created time in 9 days

PR opened microsoft/vscode

fix #79275 enable encodings for web

@bpasero truly epic day today as we are finally there after more than a month of work! Big thanks to you for guiding me through this! 🎉

I believe this is the last bit needed to enable encodings.

Contributing to VSCode was very enjoyable both because I love the editor and use it for many years and because it was very interesting to work with the codebase.

During my work I tried to keep changes that are not strictly important for the feature to work to minimum, so you are not overwhelmed by the amount of changes. However I had some ideas about small refactorings which I would like to try out and see your opinion on if result looks good. I guess I feel a bit of ownership now for the code I worked with 😄

A very simple example would be moving SUPPORTED_ENCODINGS to encoding.ts, so all the encoding stuff lives together.

I know that you in VSCode team have to deal with huge amount of issues and PRs every day, so I don't want to create more work for you just for the sake of it. That's why I would like to ask if you are open to the idea of me doing it. And also what would be the best process for it. Can I just open a PR not connected to any issue?

+266 -290

0 comment

7 changed files

pr created time in 9 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha d3757397dd2a0ecb0f3ed3d8e36fe1088855f51b

fix #79275 enable encodings for web

view details

push time in 9 days

create barnchgyzerok/vscode

branch : enable-encoding-for-web

created branch time in 9 days

PR opened microsoft/vscode

remove jschardet typings workaround for #79275

Refs: https://github.com/microsoft/vscode/pull/101489#issuecomment-653559366

+1 -5

0 comment

1 changed file

pr created time in 9 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 3288b83a83b51e6b2a0f3bffb262ed1cd7056e82

remove jschardet typings workaround for #79275

view details

push time in 9 days

create barnchgyzerok/vscode

branch : remove-jschardet-types-workaround

created branch time in 9 days

startedpubkey/broadcast-channel

started time in 10 days

startedjlevy/the-art-of-command-line

started time in 11 days

delete branch gyzerok/node-chardet

delete branch : patch-types

delete time in 11 days

pull request commentmicrosoft/vscode

Move read and write logic from nativeTextFileService to textFileService for #79275

I think even before you did call setTimeout in a for loop so this test was not actually delaying chunks by a timeout, but simply sending them into the stream all at once after a timeout. With my change it also now waits for one event loop before pushing more data into the stream.

I would expect it to send each chunk in a separate event loop frame, but after the loop is finished, yes.

Can you widen my knowledge here? Why would they go all in a single frame?

gyzerok

comment created time in 11 days

pull request commentmicrosoft/vscode

Move read and write logic from nativeTextFileService to textFileService for #79275

@bpasero

I can check again, meanwhile can you make a git clean -xfd && yarn && yarn watch in your branch and run yarn test-browser to see the test failures?

I've already done that when fixing. It should work for you as well if you update the branch to the latest version.

gyzerok

comment created time in 11 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 86dcfa4e4fc54fee1519dcf64875664d2dd8ea52

use correct comparison

view details

push time in 12 days

pull request commentmicrosoft/vscode

Move read and write logic from nativeTextFileService to textFileService for #79275

@bpasero especially love your changes around timeout. They make code much more linear! Didn't know this function exists.

I rebased on the latest master and made couple of fixes.

By the way how do you make these cool code inline blocks in your comments?

running tests from your branch (even before my changes) results in a lot of test failures (via yarn test-browser). I cannot really explain that given the build also runs these tests and seems to be green. I ran them on macOS, do you see that too?

Do the errors you are seeing look like assertion error between array converted to string and a string? If so this is due to iconv-lite-umd being pre 0.6.5. The funny thing is - I am 100% sure I ran tests locally before pushing and they worked.

Also I can clearly see exactly these tests passing in Azure. And there is no way they can pass in browser if iconv-lite-umd is not 0.6.5.

My guess is as follows:

  1. I've updated master to 0.6.5.
  2. Then I've switched to my own branch, but forgot to rebase on new master => branch was still on 0.6.4, but my node_modules were on 0.6.5.
  3. So locally everything worked for me and my local test runs were also successful.
  4. In Azure dependencies for my branch got populated with the cache from master.

So I suggest you to check the Azure. If I am correct than it doesn't seem to me like a desired cache restoration behavior.

there seems to be a questionable check for value that does not account for the empty string

Haha, great catch! I feel ashamed by the errors I am making 😅 Huge thanks for your thorough reviews, which helps us find these oversights! 👍

gyzerok

comment created time in 12 days

push eventgyzerok/vscode

Chuck Lantz

commit sha 6ab27c4d8cbe77aca7ddde706c69ec59fd6255e0

Development container for VS Code

view details

Chuck Lantz

commit sha 492e8e532033f100de71b2e20f21e89b2b126122

Improve restart reliability

view details

Chuck Lantz

commit sha a3006f5c6a38fdde05490e2ae6644c662fdee2c6

Tweak extensions

view details

Chuck Lantz

commit sha 8c8c801ada8210a623d1cbe9840dc635d6d91c3c

Trim extensions, tweak README

view details

Chuck Lantz

commit sha c2102a2859cc2ccda5dedfe0e9cfb962f5b062ab

Add resource monitor

view details

Chuck Lantz

commit sha f6caf01684207c756589939e7051daaba2561509

Merge branch 'master' of https://github.com/microsoft/vscode into clantz/dev-container

view details

Chuck Lantz

commit sha 087f4d919e6e537b62c4f5dd5c37e726909bb073

Resolve issue with noVNC failing to start

view details

Chuck Lantz

commit sha d2f343305c39461a20d25b0cd038345081c9e760

Fix typos, add password, note slow perf of "Screen Sharing" app

view details

Chuck Lantz

commit sha 1aaf78b06216bf09d5432c115a361028af3e6200

Merge branch 'master' into clantz/dev-container

view details

Chuck Lantz

commit sha fa6364164840820442d4ea3a1ada3fc01a7808d8

Merge branch 'master' into clantz/dev-container

view details

Chuck Lantz

commit sha fde43b37990ee606e5e1128c3183125473b60121

Resolve windows related issues

view details

Chuck Lantz

commit sha 258266126685f6b1cad3b7ac5df2021214b85c0e

Fix Docker WSL2 engine scenario

view details

Daniel Davis

commit sha 3f90d90ab2394c25e7e7584a885f8f5a4e4eb5d4

Adding .git/SQUASH_MSG detection to commit message autofill

view details

Daniel Davis

commit sha 05e719bede1dc28fa4cb57029f5732b90ff27e1d

Changing auto-fill commit message to check for getMergeMessage OR getSquashMessage

view details

Daniel Davis

commit sha 7bb8f9103e49b04081ff21fd33f1bbfb52bd6076

Changing commit message to use Promise.race instead of bad comparison

view details

Daniel Davis

commit sha b3c2e36cd477791b03c1e5a2233233cec1ab8d1f

Changing commit message auto-fill to use the first non-undefined message

view details

Daniel Davis

commit sha df1575d52959cbcd1f956fa0f03f0cc96bba1277

Changing return type back

view details

rebornix

commit sha 310a0dae8b243f4f4230fb48a805689ed263e293

re #91507. re-focus webview when navigating back from another editor.

view details

Sandeep Somavarapu

commit sha c5237f6d5a0b901d6c65b3a6947fcc4d06f04965

introduce resource previews

view details

Benjamin Pasero

commit sha 4f65b914448897ecb5b5ca29003b469c54668504

electron - disable remote module in all windows (#101224)

view details

push time in 12 days

pull request commentmicrosoft/vscode

:up: jschardet@2.2.1 (#33720)

@bpasero yeah you are right.

I was planning to update the version once we are finished with the PR I have currently open, but you beat me to it :)

However, the type is not clear, I think it must be string, why not Uint8Array?

It has to be string indeed. With Uint8Array it won't work. I misunderstood the source code and it is actually mistake on my side. It is fixed in the currently open PR as

const binaryString = encodeLatin1(limitedBuffer.buffer);
bpasero

comment created time in 12 days

issue commentmicrosoft/vscode-remote-release

[SSH] Add config option for host and port on which vscode-server is started on the remote

Hello @roblourens!

My apologies if pinging you is a very bad idea.

I have created this issue couple of months ago and have been patiently waiting for it to get labeled ever since.

Nothing have happened and I am wondering if it got accidentally missed due to the volumes of new issues coming in.

My subjective feeling is that it should be really easy to fix, so I am kind of having high hopes that I’ll be able to use VSCode over ssh eventually 😅

Thank you for working on remote extensions!

gyzerok

comment created time in 12 days

startedagauniyal/vscode-caniuse

started time in 13 days

fork gyzerok/code-server

VS Code in the browser

https://coder.com

fork in 13 days

pull request commentmicrosoft/vscode

[WIP] Move read and write logic from nativeTextFileService to textFileService for #79275

@bpasero at last I am ready for the first full review! 🎉

gyzerok

comment created time in 13 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 0d14771395bfc5cf279a79c55bf7cdc537fd51de

move encoding logic from NativeTextFileService to AbstractTextFileService for #79275

view details

push time in 13 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha b03f792383ed259bb884cc85568374b4e347ff43

update iconv-lite-umd to 0.6.4 for #79275 (#101213)

view details

Fedor Nezhivoi

commit sha ac2e211ba153ccb3d23237a19274aa294985959c

move encoding logic from NativeTextFileService to AbstractTextFileService for #79275

view details

push time in 13 days

PR opened microsoft/vscode

update iconv-lite-umd to 0.6.5 for #79275

@bpasero

+25 -25

0 comment

10 changed files

pr created time in 14 days

create barnchgyzerok/vscode

branch : newer-iconv-lite-umd

created branch time in 14 days

pull request commentmicrosoft/iconv-lite-umd

update iconv-lite to 0.6.1

@bpasero it looks like you missed yarn install before publishing, so new version contains build from old version of iconv-lite.

gyzerok

comment created time in 14 days

delete branch gyzerok/vscode

delete branch : update-iconv-lite-umd

delete time in 15 days

PR opened microsoft/vscode

update iconv-lite-umd to 0.6.4 for #79275

@bpasero new version of iconv-lite-umd

+25 -25

0 comment

10 changed files

pr created time in 15 days

create barnchgyzerok/vscode

branch : update-iconv-lite-umd

created branch time in 15 days

delete branch gyzerok/iconv-lite

delete branch : support-int8

delete time in 15 days

delete branch gyzerok/iconv-lite-umd

delete branch : new-version

delete time in 15 days

PR opened microsoft/iconv-lite-umd

update iconv-lite to 0.6.1

@bpasero this will ensure Uint8Array support and allow me to proceed further with my PR.

+7 -7

0 comment

2 changed files

pr created time in 15 days

create barnchgyzerok/iconv-lite-umd

branch : new-version

created branch time in 15 days

pull request commentashtuchkin/iconv-lite

ensure support for Uint8Array

@ashtuchkin thank you for the review! All the changes applied. Would you be able to publish it as a new version, so I can continue with vscode? :)

gyzerok

comment created time in 15 days

push eventgyzerok/iconv-lite

Fedor Nezhivoi

commit sha c4b6b03b85a3862f66ba2a1cc939442900acb2ba

review

view details

push time in 15 days

issue closedashtuchkin/iconv-lite

Possible bug with base64 and hex encodings

The following test fails for me with base64 and hex. Am I missing something or is this a bug?

    it("calling decode after encode yields initial string for all encodings", function() {
        iconv.decode('', 'utf8'); // load all encodings

        const encodings = Object.keys(iconv.encodings)
        encodings.forEach(function(encoding) {
            if (['_internal', '_sbcs', '_dbcs', '0'].indexOf(encoding) >= 0) {
                return;
            }

            var expected = 'Lorem ipsum';
            var actual = iconv.decode(iconv.encode(expected, encoding), encoding);

            assert.equal(actual, expected, encoding);
        })
    });

closed time in 15 days

gyzerok

issue commentashtuchkin/iconv-lite

Possible bug with base64 and hex encodings

Oh, I see. Thanks for the explanation!

gyzerok

comment created time in 15 days

issue commentbmewburn/vscode-intelephense

Encoding issue in hover tooltips

Thank you!

gyzerok

comment created time in 16 days

CommitCommentEvent

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 0659908fb312c1897f68592c53ad61e228a4ab5c

move encoding logic from NativeTextFileService to AbstractTextFileService for #79275

view details

push time in 16 days

push eventgyzerok/vscode

João Moreno

commit sha 14e287b4ce6c0011e10b1347fb53dbe7b103d6ca

wip: scmView.ts

view details

João Moreno

commit sha 17078bc8267e3ce08f8c4c6235c62c44dab31493

:lipstick:

view details

João Moreno

commit sha aa70d8d83d7f679b0a1e9706e99002293234d370

scm: use view pane terminology

view details

João Moreno

commit sha 0fa893082db63f0db1e77e5b7c1c7a9cba942e79

more cleanup

view details

João Moreno

commit sha 313de84b290ff5d4b2e564a3d3cb1182a3885a35

scm view pane: render repositories

view details

João Moreno

commit sha 4170958cfbe6bb41fe0a3f7b78dbec49c5704799

single scm view: first render

view details

João Moreno

commit sha cdf2bf4d2f6094fb2e6824aa12137fa13539cfd9

scm: styling

view details

rebornix

commit sha 5d9e5655572d188fa6756d9aaa6605f2c1891fa0

:notebook: Separate selections and text model

view details

rebornix

commit sha b91c21b80ea65af62e1b975c6e7449858002fca9

protect list and webview from revert.

view details

rebornix

commit sha 7b136ebc06709c9a17b293e7014441e110020ce7

Merge remote-tracking branch 'origin/master' into rebornix/separate-textmodel-selection

view details

rebornix

commit sha 5fb0d9192c8afc32d5034a80b2e19c0d5a89c40f

render should honor sync flag.

view details

rebornix

commit sha 3da356053341faa424f2ba4b8309c8eec632d9c7

dispose event listeners.

view details

rebornix

commit sha ac9e97aaa5e3c7fee02b6364174bc0ab88c80284

delay cells change from revert.

view details

rebornix

commit sha 8ee4f044c6bf62d54d56f2a5bae87fe808298e74

Merge remote-tracking branch 'origin/master' into rebornix/separate-textmodel-selection

view details

rebornix

commit sha 38776fa77933844ead21a10484b3e7c94443e970

track focus state in notebook view model.

view details

rebornix

commit sha 7a8b616ff08dced43d3bb2adc1192d61adc4898b

update focus state properly

view details

rebornix

commit sha f92962c689c7c0cb761dc64a0f4ef737277a2225

revert selections syncing based on focus

view details

rebornix

commit sha 765681974d5f30307a92e9640026454d96b70372

:lipstick:

view details

rebornix

commit sha d317dd4cdd9d0d710ee286371529cdf520cdf17b

update selections only when focused.

view details

rebornix

commit sha 0ac03e433121bbeabbdc4003ca0e48ac44d9b767

avoid events if notebook webview is disposed.

view details

push time in 16 days

push eventgyzerok/vscode

Martin Aeschlimann

commit sha a5a6a2057f845c4f41931b3cbef613bbf3ef4f24

update distro

view details

Johannes Rieken

commit sha 19385857257a36fd58e5c91381789ac179daf28b

remove unused telemetry

view details

Johannes Rieken

commit sha 04d78b2460707a53a86985d1d9375b84522a0352

clean-up for https://github.com/microsoft/vscode/issues/99597

view details

Martin Aeschlimann

commit sha 03963917cd9cf035a2ab519817c14ed30bf6f670

update distro

view details

Martin Aeschlimann

commit sha b6f557b525d1f5ecab7dfba1bbcc79cf8c6105c4

Merge pull request #99603 from microsoft/aeschli/no-cached-data remote integration tests: add no cached data

view details

isidor

commit sha 89313f739ecd84aecaedfdeb0fb03bca7eb4eb6a

fixes #99437

view details

Johannes Rieken

commit sha 3a56d1d6cec3b77debe9ff4b5146d5981f54b5bb

write directly to _performanceEntries instead of importing performance-object, https://github.com/microsoft/vscode/issues/99597

view details

isidor

commit sha dca516e9d17b5f6721f15791f838bf3c0230a5ed

fixes #99430

view details

Johannes Rieken

commit sha 48a2d3e86323fc2a9c199107b5cc87bf28d115b4

if needed , read clipboard inside MainThreadEditors#insertText, https://github.com/microsoft/vscode/issues/98497

view details

Johannes Rieken

commit sha f5a218d5a77c0f5eff8cd7f7fb0eea16256e1183

restore clipboard text after test, https://github.com/microsoft/vscode/issues/98497

view details

Johannes Rieken

commit sha 8356960e89e1cbcf1bfbcf4026fcfa1d2b1b8b1b

some lipstick for F1 > Insert Snippet, https://github.com/microsoft/vscode/issues/98497

view details

Benjamin Pasero

commit sha 72a55628bc3253cfc2668d9d523830d188d1e3d3

Closing background tab does not dispose dirty text models (fix #98653)

view details

Johannes Rieken

commit sha ed5d0be845894379408cc7824ed791e78d9438f4

if needed, read clipboard during snippet tab completion, https://github.com/microsoft/vscode/issues/98497

view details

Benjamin Pasero

commit sha 20107ba2627b98525d49bf28dc5c4557875190f6

Revisit duplication of ignoreOverrides and overrideId between inputs and options (fix #99123)

view details

Benjamin Pasero

commit sha 5ae8f9321a5c64f67fb25c9f71ea59724539e581

model resolver - add tests for #98653

view details

Benjamin Pasero

commit sha 5f0b0b9c19dff0b792c172652bff8970ff6de7a7

uris - do not rely on isLinux check for comparing mementos

view details

Benjamin Pasero

commit sha 7685c6ed74e129aa33174161f9288d82b29eb9b0

editors - some code cleanup

view details

Benjamin Pasero

commit sha 6a0b3594499122aa48468d9bff94b4229593beb2

files - add resource label to inputs

view details

Isidor Nikolic

commit sha a2983662deb372c1afe20b4e53aea5eba3c31c87

Merge pull request #99453 from jeanp413/fix-99350 Fixes focused status bar entry should use orange border when using the high contrast theme

view details

Benjamin Pasero

commit sha 0c73b69495fa8aab9dcd987312a27b8fc5551460

streams - add highWaterMark option

view details

push time in 16 days

push eventgyzerok/vscode

Mads Kristensen

commit sha 860ca64f070bd89402e0bfe704938e68869f8de6

Fix SchemaStore.org URLs SchemaStore.org now support HTTPS directly instead of relying on the backdoor through *.azurewebsites.net

view details

Mads Kristensen

commit sha 420abc5760390f35c6ae757c3f00f7178024a1bc

Use HTTPS urls for SchemaStore.org SchemaStore.org now supports HTTPS and no longer rely on *.azurewebsites.net as a backdoor to HTTPS

view details

Martin Aeschlimann

commit sha d0a272d0254b8a360c2725ac0a13abc8ed1e4c26

use shared webpack config for browser

view details

Benjamin Pasero

commit sha 880055cbd282cbde7365179d89a7e6931192b643

Revert "exploration - do not merge back to branch automatically to keep repo small" This reverts commit e5d08ae4bc7ef6d97e0593572fbc07ab38c76999.

view details

Benjamin Pasero

commit sha 9ff319b3fcefb9883627d815f615bc31d7a4634b

editors - do not hide certain useful secondary actions when tabs are disabled

view details

Benjamin Pasero

commit sha 0bbc57993bf2dc639d5bb415f5bceff2bc942ce4

fix #100938

view details

Martin Aeschlimann

commit sha cc595adb2c5a862bc77ee1c804aa4c7f5a99994a

Merge pull request #101047 from madskristensen/patch-3 Use HTTPS urls for SchemaStore.org

view details

Martin Aeschlimann

commit sha 4952232a7b4af1834d3fa14feb2ba2eb09c73c7f

Merge pull request #101046 from madskristensen/patch-2 Fix SchemaStore.org URLs

view details

Benjamin Pasero

commit sha be7b08977b51b5203656680af04f30b835c782fa

working copy files - add a create method and adopt @jrieken fyi

view details

Benjamin Pasero

commit sha 8e66829775a449c00908fc82698781911c724f8f

text files - go through working copy service when creating

view details

Benjamin Pasero

commit sha 1eb1acddf3dfb2eeaf887206b3410b208be79259

fix tests

view details

Sandeep Somavarapu

commit sha 8c1215f6da5bde87d4175adb944ed3d824c69e69

move indexedDB @bpasero FYI

view details

isidor

commit sha d15c84110cb4dc34c3b93a78a7f4530acee3b6e7

title control: use 1_run as a group name #92269

view details

nlchar

commit sha 1b54095f9096c0b29d57fc42942b64193810d5c1

fixed state restoring on feedback window reopen (#101074)

view details

Sandeep Somavarapu

commit sha 0786a41139cf5726fc0d8b4f20a0071f72f7613a

:lipstick:

view details

Matt Bierner

commit sha 5848f883852c83e107051d21800167227fdff330

Fix spelling

view details

Martin Aeschlimann

commit sha 94081f67b6ad9f33c18da6f1901db82d2d9deb2e

shared webpack browser config: add WEBWORKER definition

view details

Benjamin Pasero

commit sha 368c53645ac02f6ea1e183035f2beeaaef922c95

fix #101028

view details

Martin Aeschlimann

commit sha bf31134f0d62fcfeb3db77da5ad8ac11a9e086ea

add watch-web & compile-web to scripts

view details

Benjamin Pasero

commit sha 90a0ecc49e601e3f3063db7ccea0e57fd179eec9

workspaces - do not leave stale untitled workspaces around

view details

push time in 16 days

IssuesEvent

issue commentbmewburn/vscode-intelephense

Encoding issue in hover tooltips

It seems like it needn to be handled on the extension side, so reopening.

gyzerok

comment created time in 16 days

issue commentmicrosoft/vscode

Editor hover does not use reference file encoding until it is opened at least once

Personally I would consider it a bug report, not a feature request.

The features of supporting multiple encodings and editor hover tooltips are already there. The question is: would you expect them to work together? My answer is yes.

gyzerok

comment created time in 16 days

issue commentmicrosoft/vscode

Editor hover does not use reference file encoding until it is opened at least once

@amcasey yeah I see what you mean. Thank you for clarifying how TypeScript works 👍

I didn't mean single place as a single implementation, but central place which knows about the files encoding. So to me encoding map you described sounds like an interesting option.

With that model, every language would need to be updated to understand the encoding map.

In any case every language will need to be updated be it adding their own config option for encoding (as the one with tsconfig) or understanding additional LSP feature. However it being a part of the protocol will give a signal to language server authors to consider it from the get go.

Of course it might not be the best solution. I am just suggesting to consider it if possible.

gyzerok

comment created time in 17 days

pull request commentrunk/node-chardet

make type definitions compatible with browser

@runk hm, not sure what you are asking. Is there something else I need to fix in this PR?

gyzerok

comment created time in 17 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 8f3f57665746c8c1b12808be5d934009c70c5ac2

move encoding logic from NativeTextFileService to AbstractTextFileService for #79275

view details

push time in 17 days

issue commentmicrosoft/vscode

Editor hover does not use reference file encoding until it is opened at least once

Hm, it can be solved somehow on the VSCode side, so it doesn't have to be reimplemented per language? Or maybe on LSP side? So client can suggest encoding to the server on creation?

gyzerok

comment created time in 17 days

push eventgyzerok/iconv-lite

Fedor Nezhivoi

commit sha 84780849788e428a7b28916ff925e1fad6b76069

check for Buffer.isBuffer in better places to avoid unnecessary conversions

view details

push time in 18 days

push eventgyzerok/vscode

AlexStrNik

commit sha 906c34d4cd1410c4bc625b7961832dcadb850da3

Fix #97526

view details

AlexStrNik

commit sha 74c47ae214f199641e108ac6cab73884e55e5a57

Merge branch 'master' into fix-peek-problem-actions

view details

Martin Aeschlimann

commit sha d16e306c2e66602b236ae737d85edf9b2f7c37ff

html headless

view details

Connor Peet

commit sha 3a9d44e8c38c277c56ded331e13c1e033b7ffef4

debug: allow a single debug extension to provide multiple configs Previously if a debug extension provided multiple dynamic configurations, we would just use the first debugger -- whatever that was. This change now shows all configurations for which dynamic configs are registered. I also adjusted the picker to automatically select the first item if there's only a single configuration provided. This works well for the debug terminal, but also means that the user doesn't see the name of the selected item, which might not be desirable. Open to pushback. Together these finish the request for a separate top-level contribution for the terminal in #98054 Finally, with that adjustment I made a tweak so that the picker shows up in a `busy` state while extensions are activating. Previously you would select a dynamic configuration title and could have a few seconds of delay before the picker came up, which is probably not desirable.

view details

Connor Peet

commit sha d412f0189cc01c1f58cc61121f8e73dca2f4b025

Merge remote-tracking branch 'origin/master' into connor4312/allow-multiple-dynamic

view details

Connor Peet

commit sha a1f0d54563ed5a2535c17c4c8d7a3869f29d4382

fixup! pr comments

view details

Martin Aeschlimann

commit sha 05c5be7b8772aaf04c765b2b6244963aa576b1e7

extract loadLibrary

view details

Martin Aeschlimann

commit sha 9b8fec154645d3740ebfabe0c5305d574ac73c35

Merge branch 'master' into aeschli/html-headless

view details

Martin Aeschlimann

commit sha 6a18c72bbf3f2f02805e673c27f1340543ba52db

add library loader

view details

rebornix

commit sha 5222c24da0beebd5635618bdca97a3080f639b91

Fix #100455. eary return if setInput is cancelled

view details

rebornix

commit sha 2feb039432ea3692eb0d451f5b420026f126e731

re #100458.

view details

Miguel Solorio

commit sha f9bc5fc631134de4fe2f6b0234bc25d211dbb9a0

Better font-size override for dialog icons (fixes #100863)

view details

Jackson Kearl

commit sha 116b24e61c2b25d66ec8b29c5541e19784240a8d

Update latest-release-monitor.yml

view details

Martin Aeschlimann

commit sha 0869754d4e0566df90eff07dfdae5b569110be5f

update distro

view details

Benjamin Pasero

commit sha 4542519ea7b2e44a551674c4493ad018b79914b8

extensions - put warning about disabled extensions after workbench is restored

view details

Benjamin Pasero

commit sha a3f86f0923eeecbc9826d5bd88e9fe0986b79a8f

Drop node.js require for bootstrap and bootstrap-window (#100857) * sandbox - load bootstrap/bootstrap-window via script tags (workbench) * sandbox - adopt script loading for issue reporter and process explorer

view details

Sandeep Somavarapu

commit sha 5eb021aca955de8d1730b18afc6d2c9b5e16d535

#100911 Skip failing tests

view details

Benjamin Pasero

commit sha fa96b9c82fb2b2280c1e6907dcb698b773ffcf85

electron - always go through window#focus()

view details

Johannes Rieken

commit sha ae6e90c44c943498a286189b52f9dc8b24e412be

restore view state when canceling notebook quick outline, https://github.com/microsoft/vscode/issues/96489

view details

Alex Ross

commit sha ac314ec9d163ec5cfd8730fa1c228ba380db9b2e

Fix sequencing in tunnel service Fixes #100822

view details

push time in 18 days

issue commentmicrosoft/vscode

Editor hover does not use reference file encoding until it is opened at least once

Originally I've experienced this issue with PHP and Intelephense. So it is definitely not exclusive to TypeScript.

gyzerok

comment created time in 18 days

issue commentmicrosoft/vscode

Editor hover encoding issue

@bpasero if you don't mind I would like to look into this issue after we are done with the web encoding.

gyzerok

comment created time in 18 days

issue openedmicrosoft/vscode

Editor hover encoding issue

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.46.1
  • OS Version: macOS 10.15.5

Steps to Reproduce:

  1. Create empty directory
  2. Open it in VSCode and configure your workspace settings like so:
{
  "files.encoding": "windows1251",
  "files.autoGuessEncoding": false
}
  1. Create 2 files with windows-1251 encoding (you can do it through VSCode, doesn't matter)
// foo.ts

/**
 * Возвращает фуу
 */
export function foo(): string {
  return "foo";
}
// test.ts

import { foo } from "./foo";

foo();
  1. Close both files/editors (this is important!)
  2. Close VSCode
  3. Open VSCode
  4. Open test.ts
  5. Hover over foo()
  6. Observe encoding issues
  7. Open foo.ts
  8. Go back to test.ts
  9. Hover over foo()
  10. Observe correctly rendered text

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

created time in 18 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 6ddeecb510ef0b813c6c8e5de3ad6f6d0e8c1ad4

change back because the name was better

view details

push time in 18 days

CommitCommentEvent

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 69553fd2632c20d564e82c2a7dba28fbfd4db883

adjust stat

view details

push time in 19 days

push eventgyzerok/vscode

Fedor Nezhivoi

commit sha 0e44a61aa97675c314c902a3fa983be53d239a91

use canonical name when passing encoding to TextDecoder

view details

Fedor Nezhivoi

commit sha c0d343e7aae82b6763a831fb0ca4a1eadef8e15e

adjust readFile

view details

push time in 19 days

startedchomechome/charamel

started time in 19 days

pull request commentaadsm/jschardet

Multi-byte character ratio detection in UTF-8 prober confidence function

Hello @lingsamuel!

Thank you for fixing this. Can you, please, also include some additional test cases to make sure the fix you've made will not get broken again? :)

lingsamuel

comment created time in 19 days

push eventgyzerok/iconv-lite

Fedor Nezhivoi

commit sha a31298fd924200a30153f48cb1ae93a39a37def0

refactor test to take into account other _foo encodings

view details

push time in 19 days

startedrunk/node-chardet

started time in 19 days

PR opened runk/node-chardet

make type definitions compatible with browser

Hello @runk!

Great job on the library.

I've noticed that you mention browser compatibility in your 1.0.0, however your types aren't browser-compatible. Since there is no Buffer type in browser I've changed it to Uint8Array. It doesn't change anything from NodeJS perspective, because Buffer inherits Uint8Array.

+8 -8

0 comment

3 changed files

pr created time in 19 days

more