profile
viewpoint
Gytis Trikleris gytis Red Hat Barcelona

issue commentsnowdrop-zen/quarkus

Adapt RestEasy links to work with Panache REST and Spring Data REST

RestEasy JIRA issue https://issues.redhat.com/browse/RESTEASY-2510

gytis

comment created time in 3 hours

pull request commentresteasy/Resteasy

Split RESTUtils to links provider and injector

I've renamed commit message to include a JIRA issue.

gytis

comment created time in 3 hours

push eventgytis/Resteasy

Gytis Trikleris

commit sha 118d41148f32ecb535fda0260605c58e4e06e267

[RESTEASY-2510] Split RESTUtils to links provider and injector

view details

push time in 3 hours

issue closedsnowdrop/project

Add OpenShift labels to Snowdrop examples

https://issues.redhat.com/browse/RHMWRT-221

Examples that need labels

Name PR Merged
HTTP API https://github.com/snowdrop/rest-http-example/pull/112 yes
Relational Database Backend https://github.com/snowdrop/crud-example/pull/64 yes
Configmap https://github.com/snowdrop/configmap-example/pull/83 yes
Secured HTTP API https://github.com/snowdrop/secured-example/pull/66 yes
Health Check https://github.com/snowdrop/health-check-example/pull/53 yes
Circuit Breaker https://github.com/snowdrop/circuit-breaker-example/pull/55 yes
Cache https://github.com/snowdrop/cache-example/pull/57 yes

closed time in a day

gytis

delete branch snowdrop/cache-example

delete branch : openshift-labels

delete time in a day

push eventsnowdrop/cache-example

Gytis Trikleris

commit sha 0bb9b651978cd5106f1e20a559397c38c60a2475

[RHMWRT-221] Add OpenShift labels (#57)

view details

push time in a day

issue commentsnowdrop-zen/quarkus

Adapt RestEasy links to work with Panache REST and Spring Data REST

PR https://github.com/resteasy/Resteasy/pull/2311

gytis

comment created time in a day

pull request commentresteasy/Resteasy

Split RESTUtils to links provider and injector

cc @FroMage

gytis

comment created time in a day

pull request commentresteasy/Resteasy

Split RESTUtils to links provider and injector

Should I create a JIRA issue as per contribution guidelines?

gytis

comment created time in a day

PR opened resteasy/Resteasy

Split RESTUtils to links provider and injector

I'm building a Quarkus extension in which I would like to make a use of resteasy-links module. In this PR I've introduced a few changes that would make it easier to use this module in the said extension:

  1. Added entityClassName field to the @LinkResource annotation. This will allow to generate JAX-RS resources with @LinkResource annotation during the build time in Quarkus.
  2. Split RESTUtils class into two classes: ObjectLinksProvider and LinksInjector. This will allow to get links relevant to an object without injecting them into its field.
  3. Add ClassLinksProvider. This will allow to get links relevant to a class (list and add operations that work with a given class)

Most of what I've done is reorganise the code. The procedure of finding links is unchanged.

+660 -356

0 comment

12 changed files

pr created time in a day

push eventgytis/Resteasy

Ron Sigal

commit sha 6f4c249e759949b6b75cf1e17342496e95d1c224

[RESTEASY-2481] Support MicroProfile REST Client 1.4-RC1.

view details

Christos Sotiriou

commit sha 63c091c6da88b69ad9508bfa709a539ab77f25c7

[RESTEASY-2486] Fix for RestEasyClientBuilder http proxy not working (#2268) * check resetProxy flag when deciding whether to initialize a new http engine Only setup a new http engine if a new proxy has been set up. Avoids setting up a new client each time that the proxy is null (which was introduced with the previous commit) * Revert "check resetProxy flag when deciding whether to initialize a new http engine" This reverts commit dd8c8cbf648d021076a4ee51feee52efcdc3da68. * Added support for proxy in URLConnectionEngine * take into account the resteasyClientBuilder's default proxy settings when building * when building the microprofile client instance, take into account user-defined proxy properties, and pass them to the resteasyClientBuilder instance * Only check for Rest client Builder properties if no env property is set. * fixed forgotten setter for proxy in the case where a proxy is set

view details

Alessio Soldano

commit sha 676a1745c63439d8be2bb7cef18b60fb2de6eead

[RESTEASY-2474] Migration to Log4j 2

view details

Andy Damevin

commit sha 70c325b1e6a257a0d489f5e111fcc1a7d9538e3d

[RESTEASY-2489] Handle NPE in AbstractJAXBProvider.findJAXBContext (#2282) Fixes https://issues.redhat.com/browse/RESTEASY-2489

view details

Bill Burke

commit sha 7f718a8955eba609f9a0bbef3bc460d5c39fc673

[RESTEASY-2487] Quarkus fast boot and completion stage unwind (#2276) * first wave resource method initialization client refactor force snapshots Snapshot classes method invoker improvements more optimizations last optimization * finish optimizations * optimizations * completion-stage * injectArguments rollup * constructor unwind * property injector unwind * MethidInvoker.invoke unwind * internalInvokeOnTarget unwind * resource factory unwind * ResourceInvoker.invoke unwind * finish optimizatiosn * forgot to unwrap CompletionStageHOlder

view details

Alessio Soldano

commit sha 5398a8f3be865ae51c94dfb15aa3cf0f79186b01

RESTEASY-2490 Upgrade Netty to 4.1.45

view details

Alessio Soldano

commit sha 8b8dca8d92e2f6026ee663a803c0e853c59cecd7

[RESTEASY-2488] Upgrade to Infinispan 10.1.1.Final

view details

Alessio Soldano

commit sha 64208ce639244ced7c726895a56af8e18c733d6b

RESTEASY-2481 Upgrade to MP Config 1.4

view details

阿男

commit sha 0d77fbac6da44742450dfa82ef75f88ecacdb59d

RESTEASY-2493 - Update the document: 'Spring MVC section' (#2288) * RESTEASY-2493 - Update the document: 'Spring MVC section' * minor fix

view details

Bill Burke

commit sha 54907fe6f78cbeb0354786d614cd5dcccacf3e3f

[RESTEASY-2487] full noops (#2291)

view details

Alessio Soldano

commit sha 97d42ebb60f13df4171d6682f68e5df59c54ae99

[RESTEASY-2481] Upgrade to MP REST Client 1.4.0

view details

Alessio Soldano

commit sha 119b8b86f1adc4c6269bb5268a47a68ad4454611

[RESTEASY-2497] Move to SmallRye Config 1.6.1

view details

阿男

commit sha 7c6ea86d5b3e972030baa12d25be7733fdc637c9

RESTEASY-2494 update resteasy-undertow-spring integration section

view details

阿男

commit sha c9ffcce59ec13964a2ba9823edc870cf730f1e6b

adjust the section order to make to topcis more organized

view details

阿男

commit sha de338171891a73a8c937567a16b43c9274a34bc5

minor fixes in `Spring Web REST annotations in RESTEasy` section

view details

Jim Ma

commit sha 90057b3277b5ee7f0f502135d007a33ae1c2c60e

[RESTEASY-2280]:PatchMethodFilter GET requires Consumes APPLICATION_JSON_PATCH_JSON

view details

Jim Ma

commit sha 64dcfb97ad358b8e97411092be7a57ce3c987879

[RESTEASY-2496]:Add configuration parameter to disable PatchMethodFitler

view details

Jim Ma

commit sha cf185eaefd3e1938fda3740eba15a2a91062ef5a

[RESTEASY-2280]:Refactor the execption and log message; Improve the headers change and restore

view details

Jim Ma

commit sha c9f8dfe32232dace50354e402e2f49513aea8c1f

[RESTEASY-2496]:Add doc

view details

Ron Sigal

commit sha 4cecbe73a873689993f554d745008311442da330

[RESTEASY-2481] Update User Guide for MP REST Client

view details

push time in a day

push eventgytis/Resteasy

Gytis Trikleris

commit sha 55883c5deefc94c2fefd5a7a5911a4438a22307e

[WIP] Move link providers to the public package

view details

push time in a day

delete branch snowdrop/circuit-breaker-example

delete branch : openshift-labels

delete time in a day

push eventsnowdrop/circuit-breaker-example

Gytis Trikleris

commit sha 26434508e4674c3838d73d347620cfef9a1872e6

[RHMWRT-221] Add OpenShift labels (#55)

view details

push time in a day

delete branch snowdrop/health-check-example

delete branch : openshift-labels

delete time in a day

push eventsnowdrop/health-check-example

Gytis Trikleris

commit sha eff76fd16f3f1bb3e3456b0fbe2966f4f8b444ba

[RHMWRT-221] Add OpenShift labels (#53)

view details

push time in a day

delete branch snowdrop/secured-example

delete branch : openshift-labels

delete time in a day

push eventsnowdrop/secured-example

Gytis Trikleris

commit sha 58266ad7b160cc5b9e99dd1ea3e8bb72ecd4f315

[RHMWRT-221] Add OpenShift labels (#66) * [RHMWRT-221] Add OpenShift labels * [RHMWRT-221] Use spring-boot as a runtime in Kubernetes labels * [RHMWRT-221] Write SSO version in quotes

view details

push time in a day

delete branch snowdrop/configmap-example

delete branch : openshift-labels

delete time in a day

push eventsnowdrop/configmap-example

Gytis Trikleris

commit sha bab4736b796b5e226e3b8ffea3d9ba4ffbdefd17

[RHMWRT-221] Add OpenShift labels (#83) * [RHMWRT-221] Add OpenShift labels * [RHMWRT-221] Use spring-boot as a runtime in Kubernetes labels

view details

push time in a day

delete branch snowdrop/crud-example

delete branch : openshift-labels

delete time in a day

push eventsnowdrop/crud-example

Gytis Trikleris

commit sha accb58f52432959c5dbf6af1ffeb86dfe61c29e7

[RHMWRT-221] Add OpenShift labels (#64) * [RHMWRT-221] Add OpenShift labels * [RHMWRT-221] Use spring-boot as runtime in Kubernetes labels * [RHMWRT-221] Write database version in quotes * [RHMWRT-221] Fix indentation in application.yaml

view details

push time in a day

PR merged snowdrop/crud-example

Reviewers
[RHMWRT-221] Add OpenShift labels
+152 -1

4 comments

5 changed files

gytis

pr closed time in a day

pull request commentsnowdrop/secured-example

[RHMWRT-221] Add OpenShift labels

Failure is expected.

gytis

comment created time in a day

create barnchsnowdrop/cache-example

branch : openshift-labels

created branch time in a day

create barnchsnowdrop/health-check-example

branch : openshift-labels

created branch time in a day

push eventsnowdrop/secured-example

Gytis Trikleris

commit sha 5780d74b2ed928ca7151725ee530308f3915dc2c

[RHMWRT-221] Write SSO version in quotes

view details

push time in a day

pull request commentsnowdrop/crud-example

[RHMWRT-221] Add OpenShift labels

I messed up the application.yaml template, CircleCI passes now. As for the rhoar-bot I'm not sure in what state it is. Does it ever pass these days? @aureamunoz @geoand

gytis

comment created time in a day

push eventsnowdrop/crud-example

Gytis Trikleris

commit sha 24309f74de49913c89374179f5ff0fe1bcd2c039

[RHMWRT-221] Fix indentation in application.yaml

view details

push time in a day

push eventsnowdrop/crud-example

Gytis Trikleris

commit sha 1a0c24a3bf8d530d4675664fb1702a8c0b212897

[RHMWRT-221] Write database version in quotes

view details

push time in a day

create barnchsnowdrop/circuit-breaker-example

branch : openshift-labels

created branch time in 2 days

push eventsnowdrop/secured-example

Gytis Trikleris

commit sha 25fcbb7396ee216c2c62404d09ae6e88415db016

[RHMWRT-221] Use spring-boot as a runtime in Kubernetes labels

view details

push time in 2 days

push eventsnowdrop/configmap-example

Gytis Trikleris

commit sha e6f5c78fa571bac8504ca5607ef538f47ee254fe

[RHMWRT-221] Use spring-boot as a runtime in Kubernetes labels

view details

push time in 2 days

push eventsnowdrop/crud-example

Gytis Trikleris

commit sha 738f8101a80577170fb8710fc5124dc41dfc2825

[RHMWRT-221] Use spring-boot as runtime in Kubernetes labels

view details

push time in 2 days

push eventsnowdrop/rest-http-example

Gytis Trikleris

commit sha a78db0477b1ca5c1cfd4fac6d026baf359c0cfa9

Use spring-boot as runtime in Kubernetes labels

view details

push time in 2 days

issue commentsnowdrop/project

Add OpenShift labels to Snowdrop examples

Unless of course we have springboot in other places and it makes it easier to keep it like that.

gytis

comment created time in 2 days

issue commentsnowdrop/project

Add OpenShift labels to Snowdrop examples

@nainaz @cmoulliard as mentioned above, I've started adding snowdrop as a runtime name in our examples. But looking at the comments here https://docs.jboss.org/display/OBST/Labels+needed+for+Examples?focusedCommentId=65667254#comment-65667254 and https://issues.redhat.com/browse/ODC-3051 I should be adding springboot. It's fine by me, however, I would suggest using spring-boot. The name of the framework if of two words and that might also be a copyright thing.

gytis

comment created time in 2 days

create barnchsnowdrop/secured-example

branch : openshift-labels

created branch time in 2 days

create barnchsnowdrop/configmap-example

branch : openshift-labels

created branch time in 2 days

PR opened snowdrop/crud-example

Reviewers
[RHMWRT-221] Add OpenShift labels
+161 -1

0 comment

6 changed files

pr created time in 2 days

create barnchsnowdrop/crud-example

branch : openshift-labels

created branch time in 2 days

delete branch gytis/rest-http-example

delete branch : sb-2.1.x-openshift-labels

delete time in 2 days

push eventsnowdrop/rest-http-example

Gytis Trikleris

commit sha d48e19ed4f580e2fb65a6b9bb1f68d1803dfdb6d

[RHMWRT-221] Add OpenShift labels (#112) * [RHMWRT-221] Add OpenShift labels * [RHMWRT-221] Use spring-boot as runtime name * [RHMWRT-221] Add labels to application.yaml and change runtime from spring-boot to snowdrop

view details

push time in 2 days

issue commentsnowdrop-zen/quarkus

Test entity with a primitive id

Test if Panache REST extension works with entities that have a primitive type ID.

gytis

comment created time in 5 days

issue openedsnowdrop-zen/quarkus

Test entity with a primitive id

created time in 5 days

issue closedsnowdrop/project

test

closed time in 5 days

gytis

issue openedsnowdrop/project

test

created time in 5 days

Pull request review commentsnowdrop/rest-http-example

[RHMWRT-221] Add OpenShift labels

 objects:   kind: BuildConfig   metadata:     name: rest-http+    labels:+      app.kubernetes.io/part-of: http-api-example+      app.kubernetes.io/runtime-version: "SPRING_BOOT_VERSION"+      app.kubernetes.io/runtime: snowdrop

I'd say we add the labels and then sort out the logos once the time comes.

gytis

comment created time in 5 days

Pull request review commentsnowdrop/rest-http-example

[RHMWRT-221] Add OpenShift labels

 objects:   kind: BuildConfig   metadata:     name: rest-http+    labels:+      app.kubernetes.io/part-of: http-api-example+      app.kubernetes.io/runtime-version: "SPRING_BOOT_VERSION"+      app.kubernetes.io/runtime: snowdrop

I don't know if they show anything. We never had labels before

gytis

comment created time in 5 days

issue commentsnowdrop-zen/quarkus

Inject a correct URL to a location header after POST execution

https://github.com/gytis/quarkus/commit/21341a9c4c8f0a597c861346cab39580a7f6dc0c

gytis

comment created time in 6 days

push eventgytis/quarkus

Gytis Trikleris

commit sha 21341a9c4c8f0a597c861346cab39580a7f6dc0c

[WIP Panache REST] Inject a correct URL to a location header

view details

push time in 6 days

pull request commentsnowdrop/rest-http-example

[RHMWRT-221] Add OpenShift labels

@cmoulliard I've updated the PR. Could you give one more full review? Once we agree on how this should look like I'll update the other examples.

gytis

comment created time in 6 days

push eventgytis/rest-http-example

Gytis Trikleris

commit sha 0287c33803e48145adf4a08586af41884ad55bb9

[RHMWRT-221] Add labels to application.yaml and change runtime from spring-boot to snowdrop

view details

push time in 6 days

issue openedsnowdrop-zen/quarkus

Spring Functions on Quarkus

Investigate what should be the solution to adop to develop Spring Functions on Quarkus

created time in 6 days

issue openedsnowdrop-zen/quarkus

Spring @Transactional

created time in 6 days

issue openedsnowdrop/project

Spring Cloud Stream

Some foundational work has already been done in Smallrye Reactive Messaging and Quarkus

created time in 6 days

issue commentsnowdrop-zen/quarkus

Implement SB AutoConfiguration mechanism

@geoand once you start investigate it, please, add subtasks to this epic. Also link upstream Quarkus issue if one exists

gytis

comment created time in 6 days

issue openedsnowdrop-zen/quarkus

Implement SB AutoConfiguration mechanism

  • Implementation about @Conditional or equivalent annotation
  • Develop equivalent Classes for Autoconfiguration

created time in 6 days

issue openedsnowdrop-zen/quarkus

Implement Panache REST PATCH method

created time in 7 days

issue openedsnowdrop-zen/quarkus

Implement Panache REST POST method

created time in 7 days

issue openedsnowdrop/project

Fully implement ignored field check in HalEntityWrapperJacksonSerializer

At the moment only an existence of JsonIgnore annotation on a field is checked. Need to investigate what other checks are necessary.

created time in 7 days

issue commentsnowdrop-zen/quarkus

Abstract Panache REST controller method implementation

https://github.com/gytis/quarkus/commit/6571d5cc010ecf2ab846d0d2957dcfbf29e7df72

gytis

comment created time in 7 days

issue commentsnowdrop-zen/quarkus

Implement @PanacheRestResource annotation

https://github.com/gytis/quarkus/commit/70bb1c4bceab17f910a3bb9009f08f799be207d5

gytis

comment created time in 7 days

issue closedsnowdrop-zen/quarkus

Implement @PanacheRestResource annotation

Implement @PanacheRestResource annotation and its integration. Initially it should allow enable/disable HAL and expose or not a resource or a method.

closed time in 7 days

gytis

push eventgytis/quarkus

Gytis Trikleris

commit sha 70bb1c4bceab17f910a3bb9009f08f799be207d5

[WIP Panache REST] Remove PanacheHalController and add PanacheRestResource

view details

Gytis Trikleris

commit sha 6571d5cc010ecf2ab846d0d2957dcfbf29e7df72

[WIP Panache REST] Abstract Panache REST controller method implementation

view details

push time in 7 days

issue commentsnowdrop/project

Add OpenShift labels to Snowdrop examples

It's still not clear which value should I add for app.kubernetes.io/runtime label. We need to pick one.

gytis

comment created time in 7 days

issue commentsnowdrop/project

Add OpenShift labels to Snowdrop examples

I think we should use either spring-boot or snowdrop label and link the respective logo in the console. I don't think we should link a snowdrop logo to any other label just in case some customer will decide to use the label for his application.

gytis

comment created time in 7 days

Pull request review commentquarkusio/quarkus

feature: Spring API-only deps

             </dependency>              <!-- Spring -->+            <dependency>+                <groupId>me.snowdrop</groupId>

100% agree

aureamunoz

comment created time in 8 days

delete branch snowdrop/snowdrop-automation-client

delete branch : set-spring-boot-version-in-booster-template

delete time in 8 days

push eventsnowdrop/snowdrop-automation-client

Gytis Trikleris

commit sha ec6b5350c868e45802a8120419af28d3c27121fd

Inject Spring Boot version to example templates #35 (#36) * Inject Spring Boot version to example templates #35 * Fix lint failures

view details

push time in 8 days

PR merged snowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates #35

Fixes https://github.com/snowdrop/snowdrop-automation-client/issues/35

+68 -26

2 comments

6 changed files

gytis

pr closed time in 8 days

issue closedsnowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates

Set an environment variable with Spring Boot version (in the same way as we set BOOSTER_VERSION) which could be used in the example templates. As part of https://github.com/snowdrop/project/issues/7 we need to set a Kubernetes label with a Spring Boot version used in an example.

closed time in 8 days

gytis

push eventsnowdrop/snowdrop-automation-client

Gytis Trikleris

commit sha 6f22386c87cb31bffc4c94329486c388201d94c6

Fix lint failures

view details

push time in 8 days

pull request commentsnowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates #35

CI failed because of lint, will fix it and merge once CI is green

gytis

comment created time in 8 days

issue commentsnowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates

In the end I've disabled jenv, installed nvm with node 8.17.0 (13.8.0 and 12.16.0 didn't work) and now I'm able to build this thing.

gytis

comment created time in 8 days

issue commentsnowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates

Might have to reconsider...

gytis

comment created time in 8 days

issue commentsnowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates

I've tried to downgrade, but they're overriden by jenv

gytis

comment created time in 8 days

issue commentsnowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates

They seem to be coming from my graalvm installations

gytis

comment created time in 8 days

issue commentsnowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates

I have the latest, 13.something. But it seems that there is a mixup between my installed node and npm with my java version manager which for some reason also have node and npm executors...

gytis

comment created time in 8 days

issue commentsnowdrop/snowdrop-automation-client

Inject Spring Boot version to example templates

So far I was unable to successfully install our automation client:

❯ npm install

> fsevents@1.2.7 install /Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents
> node install

node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp WARN Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.7/fse-v1.2.7-node-v79-darwin-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for fsevents@1.2.7 and node@13.8.0 (node-v79 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp WARN Pre-built binaries not installable for fsevents@1.2.7 and node@13.8.0 (node-v79 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp WARN Hit error Connection closed while downloading tarball file
  SOLINK_MODULE(target) Release/.node
  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
  CXX(target) Release/obj.target/fse/fsevents.o
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:22:1: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *'
X(Boolean)
^~~~~~~~~~
../../nan/nan_converters_43_inl.h:18:23: note: expanded from macro 'X'
      val->To ## TYPE(isolate->GetCurrentContext())                            \
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2762:37: note: passing argument to parameter 'isolate' here
  Local<Boolean> ToBoolean(Isolate* isolate) const;
                                    ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:22:1: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *'
X(Boolean)
^~~~~~~~~~
../../nan/nan_converters_43_inl.h:18:23: note: expanded from macro 'X'
      val->To ## TYPE(isolate->GetCurrentContext())                            \
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2762:37: note: passing argument to parameter 'isolate' here
  Local<Boolean> ToBoolean(Isolate* isolate) const;
                                    ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:40:1: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *'
X(bool, Boolean)
^~~~~~~~~~~~~~~~
../../nan/nan_converters_43_inl.h:37:29: note: expanded from macro 'X'
  return val->NAME ## Value(isolate->GetCurrentContext());                     \
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2771:30: note: passing argument to parameter 'isolate' here
  bool BooleanValue(Isolate* isolate) const;
                             ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:40:1: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *'
X(bool, Boolean)
^~~~~~~~~~~~~~~~
../../nan/nan_converters_43_inl.h:37:29: note: expanded from macro 'X'
  return val->NAME ## Value(isolate->GetCurrentContext());                     \
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2771:30: note: passing argument to parameter 'isolate' here
  bool BooleanValue(Isolate* isolate) const;
                             ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:103:42: error: no viable conversion from 'v8::Isolate *' to 'Local<v8::Context>'
  return scope.Escape(v8::Function::New( isolate
                                         ^~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:189:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'v8::Isolate *' to 'const v8::Local<v8::Context> &' for 1st argument
class Local {
      ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:189:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'v8::Isolate *' to 'v8::Local<v8::Context> &&' for 1st argument
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:193:13: note: candidate template ignored: could not match 'Local<type-parameter-0-0>' against 'v8::Isolate *'
  V8_INLINE Local(Local<S> that)
            ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:4313:22: note: passing argument to parameter 'context' here
      Local<Context> context, FunctionCallback callback,
                     ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:103:42: error: no viable conversion from 'v8::Isolate *' to 'Local<v8::Context>'
  return scope.Escape(v8::Function::New( isolate
                                         ^~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:189:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'v8::Isolate *' to 'const v8::Local<v8::Context> &' for 1st argument
class Local {
      ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:189:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'v8::Isolate *' to 'v8::Local<v8::Context> &&' for 1st argument
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:193:13: note: candidate template ignored: could not match 'Local<type-parameter-0-0>' against 'v8::Isolate *'
  V8_INLINE Local(Local<S> that)
            ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:4313:22: note: passing argument to parameter 'context' here
      Local<Context> context, FunctionCallback callback,
                     ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:37: error: too few arguments to function call, expected 2, have 1
  return v8::StringObject::New(value).As<v8::StringObject>();
         ~~~~~~~~~~~~~~~~~~~~~      ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:5688:3: note: 'New' declared here
  static Local<Value> New(Isolate* isolate, Local<String> value);
  ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:37: error: too few arguments to function call, expected 2, have 1
  return v8::StringObject::New(value).As<v8::StringObject>();
         ~~~~~~~~~~~~~~~~~~~~~      ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:5688:3: note: 'New' declared here
  static Local<Value> New(Isolate* isolate, Local<String> value);
  ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:58: error: expected '(' for function-style cast or type construction
  return v8::StringObject::New(value).As<v8::StringObject>();
                                         ~~~~~~~~~~~~~~~~^
../../nan/nan_implementation_12_inl.h:337:60: error: expected expression
  return v8::StringObject::New(value).As<v8::StringObject>();
                                                           ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:58: error: expected '(' for function-style cast or type construction
  return v8::StringObject::New(value).As<v8::StringObject>();
                                         ~~~~~~~~~~~~~~~~^
../../nan/nan_implementation_12_inl.h:337:60: error: expected expression
  return v8::StringObject::New(value).As<v8::StringObject>();
                                                           ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1034:53: error: too few arguments to function call, single argument 'context' was not specified
      v8::Local<v8::String> string = from->ToString();
                                     ~~~~~~~~~~~~~~ ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2750:3: note: 'ToString' declared here
  V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
  ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8config.h:419:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1044:37: error: cannot initialize a parameter of type 'v8::Isolate *' with an lvalue of type 'char *'
        length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
                                    ^~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2947:26: note: passing argument to parameter 'isolate' here
  int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
                         ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1034:53: error: too few arguments to function call, single argument 'context' was not specified
      v8::Local<v8::String> string = from->ToString();
                                     ~~~~~~~~~~~~~~ ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2750:3: note: 'ToString' declared here
  V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
  ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8config.h:419:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1044:37: error: cannot initialize a parameter of type 'v8::Isolate *' with an lvalue of type 'char *'
        length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
                                    ^~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2947:26: note: passing argument to parameter 'isolate' here
  int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
                         ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1818:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(New(key).ToLocalChecked(), value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1824:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(key, value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1830:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(index, value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1836:32: error: no matching member function for call to 'Get'
        New(persistentHandle)->Get(New(key).ToLocalChecked()));
        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1842:48: error: no matching member function for call to 'Get'
    return scope.Escape(New(persistentHandle)->Get(key));
                        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1847:48: error: no matching member function for call to 'Get'
    return scope.Escape(New(persistentHandle)->Get(index));
                        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1818:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(New(key).ToLocalChecked(), value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1824:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(key, value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1830:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(index, value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1836:32: error: no matching member function for call to 'Get'
        New(persistentHandle)->Get(New(key).ToLocalChecked()));
        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1842:48: error: no matching member function for call to 'Get'
    return scope.Escape(New(persistentHandle)->Get(key));
                        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1847:48: error: no matching member function for call to 'Get'
    return scope.Escape(New(persistentHandle)->Get(index));
                        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:24:25: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(persistent().IsNearDeath());
           ~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:67:18: error: no member named 'MarkIndependent' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    persistent().MarkIndependent();
    ~~~~~~~~~~~~ ^
../../nan/nan_object_wrap.h:124:26: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(wrap->handle_.IsNearDeath());
           ~~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:24:25: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(persistent().IsNearDeath());
           ~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:67:18: error: no member named 'MarkIndependent' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    persistent().MarkIndependent();
    ~~~~~~~~~~~~ ^
../../nan/nan_object_wrap.h:124:26: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(wrap->handle_.IsNearDeath());
           ~~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
../fsevents.cc:43:32: error: no template named 'Handle' in namespace 'v8'
    static void Initialize(v8::Handle<v8::Object> exports);
                           ~~~~^
../fsevents.cc:43:32: error: no template named 'Handle' in namespace 'v8'
    static void Initialize(v8::Handle<v8::Object> exports);
                           ~~~~^
In file included from ../fsevents.cc:73:
../src/constants.cc:89:11: error: no matching member function for call to 'Set'
  object->Set(Nan::New<v8::String>("kFSEventStreamEventFlagNone").ToLocalChecked(), Nan::New<v8::Integer>(kFSEventStreamEventFlagNone));
  ~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
In file included from ../fsevents.cc:73:
../src/constants.cc:89:11: error: no matching member function for call to 'Set'
  object->Set(Nan::New<v8::String>("kFSEventStreamEventFlagNone").ToLocalChecked(), Nan::New<v8::Integer>(kFSEventStreamEventFlagNone));
  ~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
20 errors generated.
make: *** [Release/obj.target/fse/fsevents.o] Error 1
make: *** [Release/obj.target/fse/fsevents.o] Error 1
gypgyp ERR! build error
ERR! build error
gyp gyp ERR! stackERR! Error: `make` failed with exit code: 2
 gyp stackERR!  Error: `make` failed with exit code: 2
stackgyp     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
 gypERR!  stackERR!     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
 gypstack      at ChildProcess.emit (events.js:321:20)
gypERR!  ERR! stackstack     at ChildProcess.emit (events.js:321:20)
     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 19.3.0
gyp ERR! command "/usr/local/Cellar/node/13.8.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64/fse.node" "--module_name=fse" "--module_path=/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64" "--napi_version=5" "--node_abi_napi=napi"
gyp ERR! gypcwd /Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents
 ERR!gyp  ERR!System  Darwin 19.3.0
node -v v13.8.0
gyp ERR! node-gyp -vgyp v5.0.7
 ERR!gyp command "/usr/local/Cellar/node/13.8.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--module=/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64/fse.node" "--module_name=fse" "--module_path=/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64" "--napi_version=5" "--node_abi_napi=napi"
gyp  ERR! cwd /Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents
ERR! gyp not okERR!
node -v v13.8.0
gyp ERR! node-gyp -v v5.0.7
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/usr/local/Cellar/node/13.8.0/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64/fse.node --module_name=fse --module_path=/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64 --napi_version=5 --node_abi_napi=napi' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:321:20)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:1026:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
node-pre-gyp ERR! System Darwin 19.3.0
node-pre-gyp ERR! command "/usr/local/Cellar/node/13.8.0/bin/node" "/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents
node-pre-gyp ERR! node -v v13.8.0
node-pre-gyp ERR! node-pre-gyp -v v0.10.3
node-pre-gyp ERR! not ok
Failed to execute '/usr/local/Cellar/node/13.8.0/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --module=/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64/fse.node --module_name=fse --module_path=/Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64 --napi_version=5 --node_abi_napi=napi' (1)

> node-expat@2.3.17 install /Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/node-expat
> node-gyp rebuild

  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmlparse.o
  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmltok.o
  CC(target) Release/obj.target/expat/deps/libexpat/lib/xmlrole.o
  LIBTOOL-STATIC Release/libexpat.a
  CXX(target) Release/obj.target/node_expat/node-expat.o
In file included from ../node-expat.cc:1:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:22:1: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *'
X(Boolean)
^~~~~~~~~~
../../nan/nan_converters_43_inl.h:18:23: note: expanded from macro 'X'
      val->To ## TYPE(isolate->GetCurrentContext())                            \
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2762:37: note: passing argument to parameter 'isolate' here
  Local<Boolean> ToBoolean(Isolate* isolate) const;
                                    ^
In file included from ../node-expat.cc:1:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:40:1: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *'
X(bool, Boolean)
^~~~~~~~~~~~~~~~
../../nan/nan_converters_43_inl.h:37:29: note: expanded from macro 'X'
  return val->NAME ## Value(isolate->GetCurrentContext());                     \
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2771:30: note: passing argument to parameter 'isolate' here
  bool BooleanValue(Isolate* isolate) const;
                             ^
In file included from ../node-expat.cc:1:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:103:42: error: no viable conversion from 'v8::Isolate *' to 'Local<v8::Context>'
  return scope.Escape(v8::Function::New( isolate
                                         ^~~~~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:189:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'v8::Isolate *' to 'const v8::Local<v8::Context> &' for 1st argument
class Local {
      ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:189:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'v8::Isolate *' to 'v8::Local<v8::Context> &&' for 1st argument
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:193:13: note: candidate template ignored: could not match 'Local<type-parameter-0-0>' against 'v8::Isolate *'
  V8_INLINE Local(Local<S> that)
            ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:4313:22: note: passing argument to parameter 'context' here
      Local<Context> context, FunctionCallback callback,
                     ^
In file included from ../node-expat.cc:1:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:37: error: too few arguments to function call, expected 2, have 1
  return v8::StringObject::New(value).As<v8::StringObject>();
         ~~~~~~~~~~~~~~~~~~~~~      ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:5688:3: note: 'New' declared here
  static Local<Value> New(Isolate* isolate, Local<String> value);
  ^
In file included from ../node-expat.cc:1:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:58: error: expected '(' for function-style cast or type construction
  return v8::StringObject::New(value).As<v8::StringObject>();
                                         ~~~~~~~~~~~~~~~~^
../../nan/nan_implementation_12_inl.h:337:60: error: expected expression
  return v8::StringObject::New(value).As<v8::StringObject>();
                                                           ^
In file included from ../node-expat.cc:1:
../../nan/nan.h:1034:53: error: too few arguments to function call, single argument 'context' was not specified
      v8::Local<v8::String> string = from->ToString();
                                     ~~~~~~~~~~~~~~ ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2750:3: note: 'ToString' declared here
  V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
  ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8config.h:419:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
In file included from ../node-expat.cc:1:
../../nan/nan.h:1044:37: error: cannot initialize a parameter of type 'v8::Isolate *' with an lvalue of type 'char *'
        length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
                                    ^~~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2947:26: note: passing argument to parameter 'isolate' here
  int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
                         ^
In file included from ../node-expat.cc:1:
../../nan/nan.h:1818:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(New(key).ToLocalChecked(), value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../node-expat.cc:1:
../../nan/nan.h:1824:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(key, value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../node-expat.cc:1:
../../nan/nan.h:1830:28: error: no matching member function for call to 'Set'
    New(persistentHandle)->Set(index, value);
    ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context,
                                    ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:37: note: candidate function not viable: requires 3 arguments, but 2 were provided
  V8_WARN_UNUSED_RESULT Maybe<bool> Set(Local<Context> context, uint32_t index,
                                    ^
In file included from ../node-expat.cc:1:
../../nan/nan.h:1836:32: error: no matching member function for call to 'Get'
        New(persistentHandle)->Get(New(key).ToLocalChecked()));
        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../node-expat.cc:1:
../../nan/nan.h:1842:48: error: no matching member function for call to 'Get'
    return scope.Escape(New(persistentHandle)->Get(key));
                        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../node-expat.cc:1:
../../nan/nan.h:1847:48: error: no matching member function for call to 'Get'
    return scope.Escape(New(persistentHandle)->Get(index));
                        ~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
/Users/gtrikler/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:43: note: candidate function not viable: requires 2 arguments, but 1 was provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Value> Get(Local<Context> context,
                                          ^
In file included from ../node-expat.cc:1:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:24:25: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(persistent().IsNearDeath());
           ~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
In file included from ../node-expat.cc:1:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:67:18: error: no member named 'MarkIndependent' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    persistent().MarkIndependent();
    ~~~~~~~~~~~~ ^
../../nan/nan_object_wrap.h:124:26: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(wrap->handle_.IsNearDeath());
           ~~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
../node-expat.cc:11:26: error: no template named 'Handle'
  static void Initialize(Handle<Object> target)
                         ^
../node-expat.cc:481:23: error: no template named 'Handle'
  void Emit(int argc, Handle<Value> argv[])
                      ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Release/obj.target/node_expat/node-expat.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:321:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 19.3.0
gyp ERR! command "/usr/local/Cellar/node/13.8.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/gtrikler/Workspace/redhat/snowdrop-automation-client/node_modules/node-expat
gyp ERR! node -v v13.8.0
gyp ERR! node-gyp -v v5.0.7
gyp ERR! not ok
npm WARN apollo-link@1.2.2 requires a peer of graphql@^0.11.3 || ^0.12.3 || ^0.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules/fsevents):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 install: `node install`
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-expat@2.3.17 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-expat@2.3.17 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/gtrikler/.npm/_logs/2020-02-18T11_56_41_237Z-debug.log
gytis

comment created time in 8 days

issue commentsnowdrop/project

Add OpenShift labels to Snowdrop examples

So I'll add the following labels to the HTTP example (others will have a couple of extras): app.kubernetes.io/part-of: http-api-example app.kubernetes.io/name: http-api app.kubernetes.io/component: frontend app.kubernetes.io/runtime: spring-boot app.kubernetes.io/runtime-version: {version from the pom.xml}

gytis

comment created time in 8 days

more