profile
viewpoint
Guillermo Iguaran guilleiguaran @Treasure-Data Vancouver, BC. @rails core member

epsanchezma/elixir-contracts 53

Desing by Contracts for Elixir

gsamokovarov/web-console 33

MOVED TO https://github.com/rails/web-console

colombia-dev/bookclub 32

Grupo de Lectura de ColombiaDev

gsamokovarov/web-console-rails3 12

Rails Console on the Browser, Rails 3 edition.

angela4713/tenshitter 5

Microblogging platform

guilleiguaran/appengine-jruby 5

Git Mirror of https://code.google.com/p/appengine-jruby/

gsamokovarov/web-console-pry 4

Deprecated Pry adapter for Web Console.

chip/shippinglogic 3

Simple and straight forward interfaces to the various shipping web services

startedmattdesl/canvas-sketch

started time in 19 days

push eventrails/rails

Sean Doyle

commit sha 71fb8eb833e26caab13280a0ab92d822610f51f5

button_to: Support `authenticity_token:` option Match support for passing `authenticity_token:` in `form_with` and `form_for` calls. ```ruby button_to "Create", Post.new, authenticity_token: false # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button></form> button_to "Create", Post.new, authenticity_token: true # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button><input type="hidden" name="form_token" value="abc123..." autocomplete="off" /></form> button_to "Create", Post.new, authenticity_token: "secret" # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button><input type="hidden" name="form_token" value="secret" autocomplete="off" /></form> ```

view details

Guillermo Iguaran

commit sha b667e48b22a2140890c33970471da3e2270f56b1

Merge branch 'main' into button-to-authenticity-token

view details

Guillermo Iguaran

commit sha 6ddd2cf4310bbefc32866200280f10202dab6ab6

Merge pull request #43417 from seanpdoyle/button-to-authenticity-token button_to: Support `authenticity_token:` option

view details

push time in 25 days

PR merged rails/rails

button_to: Support `authenticity_token:` option actionview

Match support for passing authenticity_token: in form_with and form_for calls.

button_to "Create", Post.new, authenticity_token: false
  # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button></form>

button_to "Create", Post.new, authenticity_token: true
  # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button><input type="hidden" name="form_token" value="abc123..." autocomplete="off" /></form>

button_to "Create", Post.new, authenticity_token: "secret"
  # => <form class="button_to" method="post" action="/posts"><button type="submit">Create</button><input type="hidden" name="form_token" value="secret" autocomplete="off" /></form>
+57 -2

0 comment

3 changed files

seanpdoyle

pr closed time in 25 days

PullRequestReviewEvent

push eventseanpdoyle/rails

Alex Taylor

commit sha dd5a49c14082b559355b1f4d8bc5b686e8f67e3f

Remove glob pattern from app/channels load path

view details

HParker

commit sha 29e502f37494238b440c57d41b8f6003813c9a88

Improve active_job test_helper error messages Error messages from assert_enqueued_with and assert_performed_with shows which other jobs are enqueued or performed when you get an error. We can improve these messages to make it clearer why the job didn't match. This one error messages now have three different formats based on why the job didn't match 1. Didn't match because no jobs are queued at all. This now reports, ``` No performed job found with {:job=>HelloJob, :args=>[]} No jobs where performed ``` 2. Didn't match because that job class was not queued. This now reports, ``` No performed job found with {:job=>MultipleKwargsJob, :args=>[#<Person:0x00007fe38f9f8100 @id=11>]} No jobs of class MultipleKwargsJob where performed, job classes performed: HelloJob ``` 3. Doesn't match due to arguments, queue, priority or other reason. This now reports ``` No performed job found with {:job=>HelloJob, :args=>[#<Person:0x00007fe3a89fc2c8 @id=11>]} Potential matches: {"job_class"=>"HelloJob", "job_id"=>"f8636fd9-c7a0-4565-9198-17e175f30f0e", "provider_job_id"=>nil, "queue_name"=>"default", "priority"=>nil, "arguments"=>[{"_aj_globalid"=>"gid://aj/Person/9"}], "executions"=>0, "exception_executions"=>{}, "locale"=>"en", "timezone"=>nil, "enqueued_at"=>"2021-10-27T23:19:54Z", :job=>HelloJob, :args=>[#<Person:0x00007fe3a89dce00 @id="9">], :queue=>"default", :priority=>nil} ``` Which matches the old error message, but only reports jobs that where queued of the same class as the job you are asserting was queued.

view details

Christian Schmidt

commit sha 9a2cbb1ca9b9636a8d4b0d205f56480572544cb0

Document delivery_job and deliver_later_queue_name

view details

Sean Doyle

commit sha 3dae4469afdd1e1fedac8686d63c30d6a65a7abf

Support `<form>` elements without `[action]` Some background --- By default, when a `<form>` is declared without an `[action]` attribute, browsers will encode a `<form>`'s fields into the _current_ URL. This can be useful for a `<form method="get">` that operates on the current page. For example, when filtering search results, a form that sorts: ```html <form method="get"> <button name="sort" value="desc">Most to least</button> <button name="sort" value="asc">Least to most</button> </form> ``` can operate on a page that is filtered in another way by merging the `?sort=asc` or `?sort=desc` values _into_ the existing page, which might have the `?q=...` string set elsewhere. The problem --- Prior to this commit, none of the `<form>` construction variations supported declaring a `<form>` without an `[action]` attribute. `form_with`, `form_for`, and `form_tag` all default to `url_for({})` when a `url:` or `action:` option is omitted. The solution --- Treat `url: false`, or `action: false` as an escape hatch to signal to Action View that we don't need to transform the `model:` option or argument into a Rails route. Similarly, when calling `button_to` with `false` as the URL options arguments will construct a `<form>` element without an `[action]` attribute.

view details

Dorian Marié

commit sha 5e51dacc29a5745f68341238ece6e50495ef738b

remove removed seamless attribute https://caniuse.com/?search=seamless Chrome 20-26 had partial support behind a flag, though this was later removed.

view details

Kasper Timm Hansen

commit sha 603631b335af8314593ff9995dea9e068b96cd8d

Merge pull request #43560 from c960657/action-mailer-docs ActionMailer: Document delivery_job and deliver_later_queue_name

view details

Matthew LS

commit sha fe58908d28d4902b8e7f5008fd4f1656bfcb524b

Include name in from address Extends `email_address_with_name` instructions to demonstrate how to specify a name in the from address.

view details

Jonathan Hefner

commit sha 099289b6360ac82d1e0fa0a5592ac10cfc05e6e0

Merge pull request #43572 from matt17r/patch-2 ActionMailer Docs: Include name in from address [ci-skip]

view details

Xavier Noria

commit sha 14940def0d908aae9a59f9ecf25b2f013026b925

Suggest eager load in CI in the C2Z HOWTO guide

view details

Xavier Noria

commit sha e74012c7baf1e1efc4b48b5dc86989a9fe96c82b

Suggest eager load in CI in the testing guide

view details

Xavier Noria

commit sha d4d16e21066b65a119f16d33bf2a6f7796aedbc2

Document testing in the autoloading guide

view details

Matthew Draper

commit sha 1df47b8cc7fe8ad141baf2c838b8f51efa0a7d48

Extract AbstractAdapter#schema_version We don't want migration_context in general to be public API, but this is a reasonable question for a user to ask. Similarly, schema cache shouldn't need to reach into private details of the migrations API, and this way it doesn't have to.

view details

Matthew Draper

commit sha 37c46e859bc53175dba913e61b60042aee216ab1

Merge pull request #43578 from matthewd/connection-schema-version Extract AbstractAdapter#schema_version

view details

ignacio chiazzo

commit sha 4acb6660e265fd40b38e301fbd15909574d6a59e

Use nested queries when doing UPDATE in myslq and GROUP_BY and HAVING clauses are present. MySQL does not support GROUP_BY and HAVING on UPDATE, we need to use a Subquery.

view details

Xavier Noria

commit sha 3a8bb99e2d14cb60f53ccd3dc630b12b0bf04c91

Fixes fenced code block

view details

Rafael Mendonça França

commit sha 86e5c93792ba1434142e3c45d26849d90399de5c

Merge pull request #43465 from ignacio-chiazzo/group_update_all Allow group_by and having with update_all

view details

Rafael Mendonça França

commit sha bdfc6c27a9d78ffbf7587082d0d1712fc8df1ec5

Merge pull request #43569 from dorianmariefr/remove-seamless-iframe-attribute remove removed seamless attribute

view details

Rafael Mendonça França

commit sha a85cfc493c0ee263ea69715fb10d64ff5c47e970

Merge pull request #43554 from HParker/improve-job-test_helper-error-messages Improve active_job test_helper error messages

view details

Rafael Mendonça França

commit sha fbd11abe46c200729365f53571de67aead38edab

Document new executor_around_test_case in the guides

view details

Rafael Mendonça França

commit sha 33ca3923170a50da7f173165f7b8ba20fcd32803

Avoid adding new method to `ActiveSupport`. We don't need this delegation and can be setting directly to the right object. Also document the new configuration.

view details

push time in 25 days

push eventrails/rails

Sean Doyle

commit sha 3dae4469afdd1e1fedac8686d63c30d6a65a7abf

Support `<form>` elements without `[action]` Some background --- By default, when a `<form>` is declared without an `[action]` attribute, browsers will encode a `<form>`'s fields into the _current_ URL. This can be useful for a `<form method="get">` that operates on the current page. For example, when filtering search results, a form that sorts: ```html <form method="get"> <button name="sort" value="desc">Most to least</button> <button name="sort" value="asc">Least to most</button> </form> ``` can operate on a page that is filtered in another way by merging the `?sort=asc` or `?sort=desc` values _into_ the existing page, which might have the `?q=...` string set elsewhere. The problem --- Prior to this commit, none of the `<form>` construction variations supported declaring a `<form>` without an `[action]` attribute. `form_with`, `form_for`, and `form_tag` all default to `url_for({})` when a `url:` or `action:` option is omitted. The solution --- Treat `url: false`, or `action: false` as an escape hatch to signal to Action View that we don't need to transform the `model:` option or argument into a Rails route. Similarly, when calling `button_to` with `false` as the URL options arguments will construct a `<form>` element without an `[action]` attribute.

view details

Guillermo Iguaran

commit sha e0076e4c68951e106d1d3020a3a051ee09cd6cc2

Merge pull request #42051 from seanpdoyle/form-empty-action Support `<form>` elements without `[action]`

view details

push time in 25 days

PR merged rails/rails

Support `<form>` elements without `[action]` actionview

Some background

By default, when a <form> is declared without an [action] attribute, browsers will encode a <form>'s fields into the current URL.

This can be useful for a <form method="get"> that operates on the current page. For example, when filtering search results, a form that sorts:

<form method="get">
  <button name="sort" value="desc">Most to least</button>
  <button name="sort" value="asc">Least to most</button>
</form>

can operate on a page that is filtered in another way by merging the ?sort=asc or ?sort=desc values into the existing page, which might have the ?q=... string set elsewhere.

The problem

Prior to this commit, none of the <form> construction variations supported declaring a <form> without an [action] attribute. form_with, form_for, and form_tag all default to url_for({}) when a url: or action: option is omitted.

The solution

Treat url: false, or action: false as an escape hatch to signal to Action View that we don't need to transform the model: option or argument into a Rails route.

+144 -15

5 comments

8 changed files

seanpdoyle

pr closed time in 25 days

PullRequestReviewEvent

push eventrails/rails

Shozo Hatta

commit sha eb1a9ddd914158eb41cbb74611732652ff7f0952

Fix typo in upgrading_ruby_on_rails.md [ci-skip]

view details

Guillermo Iguaran

commit sha 0a751a021bfc0c71bb2a10ff8af9654c785c94f1

Merge pull request #43480 from hachi8833/hachi8833-patch-1 Fix typo in upgrading_ruby_on_rails.md [ci-skip]

view details

push time in 2 months

PR merged rails/rails

Fix typo in upgrading_ruby_on_rails.md [ci-skip] docs

A small fix in Upgrading Guides.

+1 -1

0 comment

1 changed file

hachi8833

pr closed time in 2 months

push eventrails/rails

Guillermo Iguaran

commit sha 5aa60833355416f1b877967cdd2c22b37e119102

Add missing configuration to middleware test

view details

push time in 3 months

push eventrails/rails

Guillermo Iguaran

commit sha 9059df9f034cfa373fdfb9f5e258c19e671365d8

Add ActionDispatch::ServerTiming to the list of middlewares in test

view details

push time in 3 months

pull request commentrails/rails

Add Server Timing middleware

@sebastians sorry for the super-late reply, I've merged this and added the CHANGELOG entry in https://github.com/rails/rails/commit/54707cb7a71fa3677cab35c139df6ca3ad685566

I think we should explain the new configuration variable added to the Configuring Guide: https://guides.rubyonrails.org/configuring.html

sebastians

comment created time in 3 months

push eventrails/rails

Guillermo Iguaran

commit sha 54707cb7a71fa3677cab35c139df6ca3ad685566

Add CHANGELOG entry for ServerTiming middleware [ci skip]

view details

push time in 3 months

push eventrails/rails

Sebastian Sogamoso

commit sha 0547b1646d09a80d0685a03c932fb0ba09c3e614

Add Server Timing middleware (#36289) * Add Server Timing middleware What is server timing? It's a specification that defines how the server can communicate the user-agent performance metrics about the request it is responding to. Here's the official specification: https://www.w3.org/TR/server-timing/#dfn-server-timing-header-field How does it work? This introduces a new `ServerTiming` middleware only on `development` by default, this is done using the `config.server_timing` setting. It works by subscribing to all `ActiveSupport::Notifications` and adding their duration to the `Server-Timing` header. Why is this useful? It makes looking at performance metrics in development much easier, especially when using Chrome dev tools which includes the metrics in the Network Inspector. Here's an example: ![](https://d3vv6lp55qjaqc.cloudfront.net/items/371h2y3B3a0U470j040u/Image%202019-05-15%20at%205.40.37%20PM.png?) Paired on this with @guilleiguaran

view details

push time in 3 months

PR merged rails/rails

Add Server Timing middleware actionpack railties

Summary

What is server timing?

It's a specification that defines how the server can communicate the user agent performance metrics about the request it is responding to.

Here's the official specification: https://www.w3.org/TR/server-timing/

How does it work?

This introduces a new ServerTiming middleware only on development by default, this is done using the config.server_timing setting.

It works by subscribing to all ActiveSupport::Notifications and adding their duration to the Server-Timing header.

Why is this useful?

It makes looking at performance metrics in development much easier, especially when using Chrome dev tools which include the metrics in the Network Inspector. Here's an example:

Paired on this with @guilleiguaran

+112 -1

12 comments

7 changed files

sebastians

pr closed time in 3 months

startedrails/propshaft

started time in 3 months

startedwestonganger/protected_attributes_continued

started time in 3 months

push eventrails/rails

Weston Ganger

commit sha 0e8432e97404edf5a259374e6aa0cf47ce009273

Remove warning when overwriting existing scopes

view details

Guillermo Iguaran

commit sha f4da3e6307b10b40b65f371307422db01863f620

Merge branch 'main' into remove_scope_overwrite_warning

view details

Guillermo Iguaran

commit sha f832fa58d38fb0747c9ce60903b1a01e65f1c332

Merge pull request #43204 from westonganger/remove_scope_overwrite_warning Remove warning when overwriting existing scopes

view details

push time in 3 months

PR merged rails/rails

Remove warning when overwriting existing scopes activerecord

Summary

Solves #43163 as approved by @rafaelfranca

+10 -36

2 comments

4 changed files

westonganger

pr closed time in 3 months

push eventwestonganger/rails

Tom Prats

commit sha fcc46228c626b02f7ace689843dbbcf400d118df

Squashed commit of the following: commit 1dca99ad4f8082d8daaa17c6600f3036c25f8e50 Author: Tom Prats <tprats108@gmail.com> Date: Thu Aug 5 18:07:00 2021 -0400 Moved header commit 62201870ff5c4124d90912989745819b05d94516 Merge: 5fa3ecae74 c91a8135c7 Author: Tom Prats <tprats108@gmail.com> Date: Thu Aug 5 14:41:22 2021 -0400 Merge branch 'main' into active-storage-byte-range commit 5fa3ecae745b4f7c67a6b6b1b7ec420877c96fb8 Author: Tom Prats <tprats108@gmail.com> Date: Thu Aug 5 14:39:53 2021 -0400 Apply suggestions from code review Syntax updates Co-authored-by: Rafael França <rafael@franca.dev> commit b9553e3698a7af5105171f9d63bd7b89cbb7e2c3 Author: Tom Prats <tprats108@gmail.com> Date: Wed Jun 23 17:36:26 2021 -0400 Added Active Storage support for byte ranges

view details

Breno Gazzola

commit sha 77f2af34f91b04fa8e97b49d6f3a197c2a09c754

Fix open redirects in active storage

view details

John Hawthorn

commit sha da8140366596cb630670dc8591e6a548cb9e7b8d

Use TemplateDetails::Requested as details_key

view details

John Hawthorn

commit sha 76561430e5e64f64ce46b9bf4af00ef58def4782

Normalize locals in unbound templates

view details

John Hawthorn

commit sha 4db7ae52f8312ddee193d9902489a6c795c82d51

Remove cache from Template::Resolver

view details

John Hawthorn

commit sha bb5208692aed3a3b4200287fe69a032b169dd9eb

Avoid building full path objects when cached

view details

Breno Gazzola

commit sha b4e394767d9fe8815357a3098a8e7c26a00448d9

Reduce file size of tiff image in Active Storage

view details

Ryuta Kamizono

commit sha 01244284cf471afb0f9a7a33a31e7d6f44b314e0

Merge pull request #43007 from FestaLab/activestorage/tiff-size Reduce file size of tiff image in Active Storage

view details

Kasper Timm Hansen

commit sha fe4ec2ac0c131013090d9f36bceb3ce4a084af82

Merge pull request #41437 from tomprats/active-storage-byte-range Added Active Storage support for byte ranges

view details

Kasper Timm Hansen

commit sha 7faf8a0fe3ac40725ec5c4769547856e5e613d62

[ci skip] Undocument send_blob_byte_range_data, don't commit to a public API just yet

view details

Kasper Timm Hansen

commit sha ef65eeef081785e39da717cd9ce7888fa010d217

Merge pull request #42960 from FestaLab/activestorage/unsafe-redirect Fix open redirects in active storage

view details

Drew Bragg

commit sha 592570f1bfefaf48deac2f264112bc5bbcc64955

Add `weekday_options_for_select` method Add `weekday_select` method Create `Tags::WeekdaySelect` class Add `weekday_select` to `FromBuilder` Add Documentation Allow `WeekdaySelect` to use selected option if value is nil Doc fix Add tests Use kwrd args Update CHANGELOG Fix `Tags::WeekdaySelect` for updated kwrd args Update CHANGELOG format Condense `weekday_options_for_select` method Update tests for kwargs

view details

Kasper Timm Hansen

commit sha 13a714f30d5e4c4a53062bb1b29fbeb287efd3be

Merge pull request #42979 from DRBragg/drbragg/add-weekday-select Add `weekday_options_for_select` method

view details

Weston Ganger

commit sha a77dd104ea9557d26d311d17a8b53c8ab7d7f8a8

Implement db config option `database_tasks: false`

view details

Eileen M. Uchitelle

commit sha 86aeadc481a0ffff8d08845da17a81ec0f29000f

Merge pull request #42794 from westonganger/multi_db_config_database_tasks_option Add database config option `database_tasks: false`

view details

eileencodes

commit sha dfef44716a6a0fc50c44e12218e65e51e6ee88bf

Fix rubocop and cleanup test Followup to #42794. This fixes a rubocop failure for the spacing before the curly brace and uses a more common/correct approach to testing the error message.

view details

Xavier Noria

commit sha 2a22b4c53b930678c221abbe26f2fe2394dbc261

Delete AS::Dependencies.hook!

view details

Xavier Noria

commit sha bbe74a8c97d55460bd21ef875d2ea3cee7a61376

Delete AS::Dependencies.unhook!

view details

Xavier Noria

commit sha d7e7948789398d00cd6675a037535f07434d09e1

Deletes the initializer `warn_if_autoloaded`

view details

Xavier Noria

commit sha 6ee025ad44948f64bb18ae8b07014363f922bfe1

Deletes the initializer `ensure_autoload_once_paths_as_subset` There is no need for this nowadays. you could have a directory somehwere that is not in autoload_paths, but you want the once loader to manage. At the same time, when we setup the main loader, we remove any directory in the autoload_once_paths, since Zeitwerk does not allow loaders to have overlapping root directories.

view details

push time in 3 months

push eventrails/rails

Michael Bayucot

commit sha 4497abb4a9026bf98475824de3fb15ca9f549c13

Add ssl support for postgresql database tasks

view details

Guillermo Iguaran

commit sha 99bc69ad289012a3af3008bdffe23d475d4f12b4

Merge branch 'main' into 42994-add-support-for-postgresql-certs-on-db-tasks

view details

Guillermo Iguaran

commit sha 203e757fd3e0626d258136278716602867e1120d

Merge pull request #43068 from mbayucot/42994-add-support-for-postgresql-certs-on-db-tasks Add ssl support for postgresql database tasks

view details

push time in 3 months

PR merged rails/rails

Add ssl support for postgresql database tasks activerecord

Summary

Add PGSSLMODE, PGSSLCERT, PGSSLKEY and PGSSLROOTCERT to pg_env from database config when running postgresql database tasks.

```yaml
# config/database.yml

production:
  sslmode: verify-full
  sslcert: client.crt
  sslkey: client.key
  sslrootcert: ca.crt
```

Environment variables

```
PGSSLMODE=verify-full
PGSSLCERT=client.crt
PGSSLKEY=client.key
PGSSLROOTCERT=ca.crt
```

Fixes #42994

+63 -4

3 comments

3 changed files

mbayucot

pr closed time in 3 months

issue closedrails/rails

pg_env in postgresql_database_tasks doesn't support certs for mtls

Looks like config entries related to connection certs are missing from https://github.com/rails/rails/blob/5e8a26d70559c0b3183e81a5d2775d19146b0c04/activerecord/lib/active_record/tasks/postgresql_database_tasks.rb#L100-L107

  • PGSSLCERT
  • PGSSLKEY
  • PGSSLROOTCERT

Steps to reproduce

  • Configure a database.yml to postgres connecting using clientKey clientCertificate for mutual tls
  • run the db:structure:load rake task

Expected behavior

Schema is loaded

Actual behavior

psql: error: FATAL:  connection requires a valid client certificate

System configuration

Rails version: 6.1.3.2

Ruby version: 2.7.3

closed time in 3 months

twk3

push eventmbayucot/rails

Shouichi Kamiya

commit sha 35d8890c92b931cecf323d4bdd7e318f20326926

Instrument ActiveStorage analyzers

view details

Shouichi Kamiya

commit sha 2ad684bc49b6a09f8df58fef0859141a3285c717

Update activestorage/CHANGELOG.md Co-authored-by: Petrik de Heus <petrik@deheus.net>

view details

Cody Cutrer

commit sha 1fbb3ddcd343b92f5a902d8c77c092b1843fe1b4

avoid calling attributes.keys in ActiveModel#serializable_hash for ActiveRecord objects, it will force the entire attributes hash to be constructed, which may include expensive deserialization. ActiveModel already has a simple attribute_names method defined which returns attributes.keys, exactly like the code we're replacing. ActiveRecord overrides that method, and returns the names of the attributes _without_ having to deserialize any values. this change can save a lot of CPU if you have a serialized column on a model that you often load from the DB because it's not worth the effort to customize the SELECT on every relation, but also rarely expose in any JSON serializations (i.e. have a default except option for it).

view details

Linas Juškevičius

commit sha f60fbfaee6be9618f306c55fc2d6e0dc4c6ab77f

Support gem comments in Rails templates

view details

Jose Galisteo

commit sha dfd9e6afd285ecbe047e25e95f9651982ae6558e

Keep RedirectController links consistent. There are two links defined to RedirectController, with backticks and without them. This commit removes the link without backticks for the sake of consistency as discussed here: https://github.com/rails/rails/pull/42703/files#r667270569

view details

Jose Galisteo

commit sha 8fb2123073ac6a6672f736ce91cd7c764423d628

Change links from github.com to api.rubyonrails.org The guide's guidelines do not mention anything against linking to the Github repo, but it describes [how to link][] to api.rubyonrails.org works. So I guess that it's better to link "api.rubyonrails.org" when is possible, for instance: classes, modules, and methods. [how to link]: https://guides.rubyonrails.org/ruby_on_rails_guides_guidelines.html#linking-to-the-api

view details

Michael Bayucot

commit sha 9f57debbd04093f75d116a7ddcccd8d76de39063

Add SSL support for postgresql in bin/rails dbconsole

view details

Brian Kephart

commit sha 87f37419c463e03cdfb73ac70ce87197c5f829f3

Add HEIF image types to variable content types

view details

Rafael Mendonça França

commit sha 331a0684aa8107a77613c8e1a36202a3cc287f62

Fix CHANGELOG [ci skip]

view details

Rafael Mendonça França

commit sha 03f2b882a59aa80df79cb4697563f42f50a07304

Document config.active_record.schema_cache_ignored_tables in the guide [ci skip]

view details

Rafael Mendonça França

commit sha 55199212542d8d8536e5bb93c43f1be50730ae74

Remove need for using alias_method trick using the inheritance That trick make the code hard to understand, this implementation is more readable.

view details

Rafael Mendonça França

commit sha a1ac107e2ae72588063acbbccb1dc1b6eba66045

Remove duplicated statement that was already happening in raw_execute

view details

Petrik

commit sha 4fae79adc34e91158ca05eb2ce181d488a68f766

Improve casing in encryption guide headings Update the guide to use the casing as defined in the contribution guide. https://guides.rubyonrails.org/ruby_on_rails_guides_guidelines.html#headings [ci-skip] Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>

view details

Jonathan Hefner

commit sha 6bd39252442ff9bb1025e9ccf7a98c085b896f6a

Merge pull request #43120 from p8/guides/encryption-headings Improve casing in encryption guide headings [ci-skip]

view details

Guillermo Iguaran

commit sha b1b8f8aa230011c661d0ec7d08fbbc3f8602affd

Merge branch 'instrument-analyzers' of https://github.com/shouichi/rails into shouichi-instrument-analyzers

view details

Guillermo Iguaran

commit sha 9ac1827331e85f01490b57f27e9cdf75a9cd1b69

Merge branch 'shouichi-instrument-analyzers'

view details

Guillermo Iguaran

commit sha c5b11bb1c493f2ccd359ed4fe807281a0f9b1203

Merge branch 'avoid_deserialization' of https://github.com/ccutrer/rails into ccutrer-avoid_deserialization

view details

Aaron Lahey

commit sha 82fc62ca71fb37eec456d65dc1cb40f3d9151b9a

Use static message when raising HTTP request parameter parse errors When parsing HTTP request parameters, Rails delegates to a set of parsing strategies based on the MIME type. If any of these strategies raises an error Rails rescues it and raises an instance of `ActionDispatch::Http::Parameters::ParseError` with the same message as the underlying error. However, in the presence of malformed JSON, the default parameter parser for the `application/json` MIME type raises a `JSON:ParserError` with a message containing the entire malformed JSON string (the request body in this context). By raising a new error with this same message Rails inadvertently ends up logging the full HTTP request body at the `fatal` level. This request body could contain sensitive information or could be intentionally crafted to be extremely large. This commit sets the `ActionDispatch::Http::Parameters::ParseError` message to a static message which mirrors that of the corresponding `debug` log.

view details

Guillermo Iguaran

commit sha 75ea8284094a48fd556482e2e69e4cf5a7c3b03e

Don't add attribute_names to ActiveModel::Serialization public API

view details

Guillermo Iguaran

commit sha 00d72d7319e639b88839de2743879fe10cd53f39

Merge branch 'ccutrer-avoid_deserialization'

view details

push time in 3 months

push eventrails/rails

Anton Rieder

commit sha db286625d0132ebef27b51f9c44de571793d39dd

Don't show deprecation warning for equal paths Before, if a user set `file_fixture_path` to the same path as `fixture_path`, this would have resulted in a deprecation warning such as: "Please modify the call from `fixture_file_upload('rails.jpg')` to `fixture_file_upload('rails.jpg')"

view details

Guillermo Iguaran

commit sha c0e17d4520c75cd3244687e3cad91f4f231d0062

Merge pull request #43186 from aried3r/ar/dont_show_file_fixture_path_deprecation_if_same_path Don't show deprecation warning for equal paths

view details

push time in 3 months

PR merged rails/rails

Don't show deprecation warning for equal paths actionpack

Summary

Before, if a user set file_fixture_path to the same path as fixture_path, this would have resulted in a deprecation warning such as:

"Please modify the call from fixture_file_upload('rails.jpg') to `fixture_file_upload('rails.jpg')"

If this PR should indeed be a fix and not a mistake, I'd assume it should also be backported?

+19 -6

0 comment

2 changed files

aried3r

pr closed time in 3 months

push eventrails/rails

Wojciech Wnętrzak

commit sha 10467dbbb388772310e729f53bc821e4e39eaf5d

Mention Good Job as Active Job backend. It's fully based on Rails, so not really possible to run in any other way. Thanks to that it is simple, yet powerfull. It's very well maintained and used in production systems by many people. [ci skip]

view details

Guillermo Iguaran

commit sha 01fd264d0012aa8f450513a7533f5064b696f6d6

Merge pull request #43189 from tiramizoo/good-job Mention Good Job as Active Job backend.

view details

push time in 3 months

PR merged rails/rails

Mention Good Job as Active Job backend. docs

It's fully based on Rails, so not really possible to run in any other way. Thanks to that it is simple, yet powerful. It's very well maintained and used in production systems by many people.

I think it's worth mentioning it in the Rails guides, so more people are aware about it.

[ci skip]

+1 -0

0 comment

1 changed file

morgoth

pr closed time in 3 months

more