profile
viewpoint
Grant Timmerman grant @Google Earth http://grant.cm Google Engineer working on Serverless

chrusty/protoc-gen-jsonschema 218

Protobuf to JSON-Schema compiler

grant/20-Apps 54

📱Learning iOS development by creating 20 apps in 20 days.

grant/algo-rhythm 34

Algorithmic Music Composition using Artificial Neural Nets

GoogleCloudPlatform/workflows-samples 30

This repository contains samples for Cloud Workflows.

grant/apple-wwdc-logo 6

Apple's WWDC logo made with HTML/CSS/JS.

dhalima3/Autoscribe 5

Hack The Planet

GoogleCloudPlatform/dart-samples 4

A collection of samples on using Dart with Google Cloud Platform.

grant/app-icon-generator 3

A tool to generate lots and lots of app icon images.

gcpevents/eventsforcloudrun 2

Events for Cloud Run

PullRequestReviewEvent

issue commentGoogleCloudPlatform/functions-framework-nodejs

ESM support stopped working in Cloud Functions (GCF)

Is there any plans on resolving this soon? I'm using another package that requires Node 16 so going back to node 14 engine is not an option for me.

Understood. Matt is actively working on a solution that is visible internally https://github.com/GoogleCloudPlatform/functions-framework-nodejs/issues/407#issuecomment-1017870928. There's no update since yesterday.

koistya

comment created time in 4 days

PullRequestReviewEvent

issue commentgoogleapis/google-cloudevents-go

[Policy Bot] found one or more issues with this repository.

I'm not working on this repo anymore, but this should be an easy fix. Feel free to ping me for more info :). Unassigning.

google-cloud-policy-bot[bot]

comment created time in 6 days

issue commentGoogleCloudPlatform/functions-framework-nodejs

Update Event Functions Typing

Thanks for the issue. Can you provide more detail with link to parts inside here? There is not much detail in the issue.

The types could possibly be improved, although it may be better for the type library depending on the request: https://github.com/googleapis/google-cloudevents-nodejs

cmbirk

comment created time in 7 days

PullRequestReviewEvent

pull request commentGoogleCloudPlatform/functions-framework-nodejs

chore(deps): update dependency @types/node to v16

Errors unrelated:


> @google-cloud/functions-framework@2.1.0 compile /home/runner/work/functions-framework-nodejs/functions-framework-nodejs
> tsc -p .

src/function_wrappers.ts:45:18 - error TS2339: Property 'domain' does not exist on type 'Process'.

45   return process.domain.bind<OnDoneCallback>((err, result) => {
                    ~~~~~~

src/function_wrappers.ts:45:47 - error TS7006: Parameter 'err' implicitly has an 'any' type.

45   return process.domain.bind<OnDoneCallback>((err, result) => {
                                                 ~~~

src/function_wrappers.ts:45:52 - error TS7006: Parameter 'result' implicitly has an 'any' type.

45   return process.domain.bind<OnDoneCallback>((err, result) => {
                                                      ~~~~~~


Found 3 errors.
renovate-bot

comment created time in 7 days

PullRequestReviewEvent

push eventrenovate-bot/functions-framework-nodejs

johannesgiani

commit sha 02637646e64d83a5b2c9619e6bf1529275c06ee5

docs: add instructions for deploying with typescript codebase (#417) Update typescript readme as proposed in [issue](https://github.com/GoogleCloudPlatform/functions-framework-nodejs/issues/254)

view details

WhiteSource Renovate

commit sha 5393d78c3ef5e1f086dce7a7de1db2e25f3cf3e8

chore(deps): update dependency @types/body-parser to v1.19.2 (#411)

view details

Grant Timmerman

commit sha 245de0c709f1d7f9261ecabaf5a381d48e547d0d

Merge branch 'master' into renovate/sinon-12.x

view details

push time in 7 days

push eventGoogleCloudPlatform/functions-framework-nodejs

WhiteSource Renovate

commit sha 5393d78c3ef5e1f086dce7a7de1db2e25f3cf3e8

chore(deps): update dependency @types/body-parser to v1.19.2 (#411)

view details

push time in 7 days

PR merged GoogleCloudPlatform/functions-framework-nodejs

chore(deps): update dependency @types/body-parser to v1.19.2

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/body-parser 1.19.1 -> 1.19.2 age adoption passing confidence

Configuration

📅 Schedule: "every 3 months on the first day of the month" (UTC).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate-bot

pr closed time in 7 days

PullRequestReviewEvent

delete branch grant/grant.cm

delete branch : dependabot/npm_and_yarn/tools/follow-redirects-1.14.7

delete time in 10 days

push eventgrant/grant.cm

dependabot[bot]

commit sha a59b792329fe16d8965434948a808cfb8e392ff4

chore(deps): bump follow-redirects from 1.14.4 to 1.14.7 in /tools Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.4 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.4...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Grant Timmerman

commit sha 7ffff1b2ffc676223b427497a57acc075056e11d

Merge pull request #77 from grant/dependabot/npm_and_yarn/tools/follow-redirects-1.14.7

view details

push time in 10 days

PR merged grant/grant.cm

chore(deps): bump follow-redirects from 1.14.4 to 1.14.7 in /tools dependencies

Bumps follow-redirects from 1.14.4 to 1.14.7. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2ede36d7c60d3acdcd324dcd99a9dbd52e4fb3a6"><code>2ede36d</code></a> Release version 1.14.7 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/8b347cbcef7c7b72a6e9be20f5710c17d6163c22"><code>8b347cb</code></a> Drop Cookie header across domains.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/6f5029ae1a0fdab4dc25f6379a5ee303c2319070"><code>6f5029a</code></a> Release version 1.14.6 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/af706bee57de954414c0bde0a9f33e62beea3e52"><code>af706be</code></a> Ignore null headers.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/d01ab7a5c5df3617c7a40a03de7af6427fdfac55"><code>d01ab7a</code></a> Release version 1.14.5 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/40052ea8aa13559becee5795715c1d45b1f0eb76"><code>40052ea</code></a> Make compatible with Node 17.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/86f7572f9365dadc39f85916259b58973819617f"><code>86f7572</code></a> Fix: clear internal timer on request abort to avoid leakage</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2e1eaf0218c5315a2ab27f53964d0535d4dafb51"><code>2e1eaf0</code></a> Keep Authorization header on subdomain redirects.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2ad9e82b6277ae2104f7770e9ff1186cc6da29d4"><code>2ad9e82</code></a> Carry over Host header on relative redirects (<a href="https://github-redirect.dependabot.com/follow-redirects/follow-redirects/issues/172">#172</a>)</li> <li>See full diff in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.14.4...v1.14.7">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgoogleapis/google-cloudevents

Create LogEntryData-bigqueryjobcompleted.json

+{+    "insertId": "jpllvgecd7bx",

I can't tell if 2 space indentation is here or more. Should be 2 spaces.

minyu19

comment created time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgoogleapis/google-cloudevents

Create LogEntryData-bigqueryjobcompleted.json

     },     "severity": "INFO",     "timestamp": "2021-11-25T21:56:00.276607Z"-  },-  "datacontenttype": "application/json; charset=utf-8",-  "dataschema": "https://googleapis.github.io/google-cloudevents/jsonschema/google/events/cloud/audit/v1/LogEntryData.json",-  "id": "projects/my-project/logs/cloudaudit.googleapis.com%2Fdata_accessjpllvgecd7bx1637877360276607",-  "methodName": "jobservice.jobcompleted",-  "recordedTime": "2021-11-25T21:56:00.276607Z",-  "resourceName": "projects/my-project/jobs/bqjob_r3ac45813612fa2d6_0000017d591922c9_1",-  "serviceName": "bigquery.googleapis.com",-  "source": "//cloudaudit.googleapis.com/projects/my-project/logs/data_access",-  "specversion": "1.0",-  "subject": "bigquery.googleapis.com/projects/my-project/jobs/bqjob_r3ac45813612fa2d6_0000017d591922c9_1",-  "time": "2021-11-25T21:56:00.653866570Z",-  "type": "google.cloud.audit.log.v1.written"-}+  }

Format is off, there should be no space here.

minyu19

comment created time in 11 days

PullRequestReviewEvent

Pull request review commentgoogleapis/google-cloudevents

Create MessagePublishedData-simple.json file

+{+    "data": "SGVsbG8gV29ybGQh",+    "messageId": "3103425958877813",+    "publishTime": "2021-10-01T20:37:27.386Z"+  }

Format is off.

2 spaces indentation. Line 5 should have 0 spaces.

minyu19

comment created time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent
more