profile
viewpoint

gorkem/app-labels 14

Kuberbetes/OpenShift recommended labeling

gorkem/BarcodeScannerRCP 3

A barcode scanner Eclipse RCP application

che-incubator/ms-code.typescript 0

ms-code.typescript

gorkem/aerogear-push-quickstarts 0

UnifiedPush Quickstart Examples

gorkem/che 0

Eclipse Che: Next-generation Eclipse IDE. Open source workspace server and cloud IDE.

gorkem/che-dependencies 0

Che Dependencies

Pull request review commentredhat-developer/vscode-tekton

Hide cancel button on finished pipelinerun

       "view/item/context": [         {           "command": "k8s.tekton.run.logs",-          "when": "viewItem =~ /vsKubernetes\\.resource\\.(pipelinerun|taskrun)/i",+          "when": "viewItem =~ /vsKubernetes\\.resource\\.(pipelinerun|pipelineRun|taskrun)/i",

So, maybe pipelineRunFinished is more descriptive?

sudhirverma

comment created time in 2 minutes

Pull request review commentshipwright-io/build

Build watch secrets

 func add(ctx context.Context, mgr manager.Manager, r reconcile.Reconciler) error  	// Watch for changes to primary resource Build 	err = c.Watch(&source.Kind{Type: &build.Build{}}, &handler.EnqueueRequestForObject{}, pred)++	preSecret := predicate.Funcs{++		// Only filter events where the secret have the Build specific annotation+		CreateFunc: func(e event.CreateEvent) bool {+			objectAnnotations := e.Meta.GetAnnotations()+			if _, ok := buildSecretRefAnnotationExist(objectAnnotations); ok {+				return true+			}+			return false

@SaschaSchwarze0 thanks, I actually needed to test this to verify it, which is the case. I think this types of improvements we should do them on a bigger card, something via changing our HA model from active/passive to active/active. Please read the internal doc we have around the tekton active/active, they explain there an approach to warm up the pods in advance(informers cache), which should address this concern.

qu1queee

comment created time in 3 minutes

Pull request review commentredhat-developer/vscode-tekton

Hide cancel button on finished pipelinerun

       "view/item/context": [         {           "command": "k8s.tekton.run.logs",-          "when": "viewItem =~ /vsKubernetes\\.resource\\.(pipelinerun|taskrun)/i",+          "when": "viewItem =~ /vsKubernetes\\.resource\\.(pipelinerun|pipelineRun|taskrun)/i",

To hide the cancel button I am using pipelineRun, I will switch the contextValue to pipelineRun when pipelinerun is finished.

sudhirverma

comment created time in 4 minutes

pull request commentopenshift/odo

Modifies WaitForDeploymentRollout() to collect events.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign mik-dass after the PR has been reviewed. You can assign the PR to them by writing /assign @mik-dass in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["mik-dass"]} -->

mik-dass

comment created time in 6 minutes

PR opened openshift/odo

Modifies WaitForDeploymentRollout() to collect events.

What type of PR is this?

/kind flake

What does does this PR do / why we need it:

Modifies WaitForDeploymentRollout() to collect events. It also uses WaitAndGetPodWithEvents() for getting the pod in the adapter package.

Which issue(s) this PR fixes:

Fixes NA

PR acceptance criteria:

  • [X] Unit test

  • [ ] Integration test

  • [ ] Documentation

  • [ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:

  • Tests should pass.
  • If failures related to https://github.com/openshift/odo/issues/3256 occur, collected events should be printed.
+120 -35

0 comment

8 changed files

pr created time in 6 minutes

issue commentcode-ready/crc

Space issue - how to clean VM folder /sysroot/ostree/deploy/rhcos/var/lib/containers/storage/overlay

Is this a duplicate of https://github.com/code-ready/crc/issues/1711 ?

JiriHusak-lab

comment created time in 9 minutes

push eventeclipse/che-theia

Vladyslav Zhukovskyi

commit sha d59c79f3aa7f77eab402eb3aa38009fcc0282487

Debug Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

view details

push time in 10 minutes

issue commentcode-ready/crc

Space issue - how to clean VM folder /sysroot/ostree/deploy/rhcos/var/lib/containers/storage/overlay

Do these images show up in sudo podman images? If yes, I'd try sudo podman image prune and see if it helps.

JiriHusak-lab

comment created time in 10 minutes

delete branch eclipse/che

delete branch : sl/test

delete time in 10 minutes

delete branch eclipse/che

delete branch : rc

delete time in 11 minutes

Pull request review commentopenshift/odo

Handling absolute and relative source path file uri

 func GenFileURL(location string, os ...string) string { 	} 	urlPath := location 	if currOS == WIN {-		urlPath = "/" + strings.Replace(location, "\\", "/", -1)+		urlPath = strings.Replace(location, "\\", "/", -1) 	}-	return "file://" + urlPath+	if filepath.IsAbs(urlPath) || strings.Contains(urlPath, ":/") {+		if currOS == WIN {

You current code prints different output for win and Linux. On windows path will be with file:// on Linux it won't

All we need to to do fix the original issue is to make sure that the path aways starts with file:/// (3 slashes)

prietyc123

comment created time in 11 minutes

pull request commentshipwright-io/build

Refactor conditions

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign qu1queee after the PR has been reviewed. You can assign the PR to them by writing /assign @qu1queee in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["qu1queee"]} -->

qu1queee

comment created time in 13 minutes

PR opened shipwright-io/build

Refactor conditions

Modify buildrun_types.go to host Conditions: This simplifies a lot the generation of deepcopy functions, by having this objects under the same directory as the other BuildRun ones. Having the conditions types somewhere else, force us to manually generate deepcopy functions.

Update the *.deepcopy.go files: Based on the new Conditions definition for BuildRun types

Remove the conditions pkg : This is not longer needed, while we realize that only the BuildRun would be supporting status.conditions, and we do not have another controller that requires this at the moment.

+140 -233

0 comment

7 changed files

pr created time in 13 minutes

pull request commenteclipse/che-theia

Make Che-Theia spelling consistent with the docs

:white_check_mark: E2E Happy path tests succeed :tada:

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

<details> <summary>See Details</summary> <p>

name link
che-theia docker.io/maxura/che-theia:943
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:943

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

</p> </details>

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.
azatsarynnyy

comment created time in 17 minutes

push eventredhat-developer/service-binding-operator-manifests

redhat-developer

commit sha a489f03f891a7dbfdc7d0686dedf099b33b06c50

d0c320bdf30346dca6bcc769d9132a47fca4570e

view details

push time in 18 minutes

Pull request review commenteclipse/che-theia

Make Che-Theia spelling consistent with the docs

 EXPOSE 3000 3030 RUN npm config set prefix "${HOME}/.npm-global" && \     echo "--global-folder \"${HOME}/.yarn-global\"" > ${HOME}/.yarnrc && \     yarn config set network-timeout 600000 -g && \-    # add eclipse che theia generator+    # add eclipse che-theia generator

The module is called eclipse-che-theia-generator: let's use that

azatsarynnyy

comment created time in 19 minutes

issue commenteclipse/che

The rust getting started sample should use the vscode extension

finally, specifying the toolchain is not mandatory, the following commands work and no need to adapt the arch or distro in the command line:

rustup component add rust-src
rustup component add rust-analysis
rustup component add rls
sunix

comment created time in 23 minutes

issue commenteclipse/che

The rust getting started sample should use the vscode extension

@gattytto you can give a try:

apiVersion: 1.0.0
metadata:
  generateName: rust-
projects:
  - name: HelloWorld-Rust
    source:
      location: 'https://github.com/che-samples/helloworld-rust.git'
      type: git
      branch: master
components:
  - mountSources: true
    memoryLimit: 512Mi
    type: dockerimage
    alias: rust
    image: quay.io/eclipse/che-rust-1.39:nightly
 
  - type: chePlugin
    reference: 'https://gist.githubusercontent.com/sunix/eb86fdf6802afbfb4de059ed19f08d37/raw/41515915211723ca3c740d28263d7b8a87e0a8b6/meta.yaml'
 
commands:
  - name: build
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/HelloWorld-Rust'
        type: exec
        command: cargo build
        component: rust
  - name: run
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/HelloWorld-Rust'
        type: exec
        command: cargo run
        component: rust

sunix

comment created time in 26 minutes

issue closedredhat-developer/vscode-tekton

When clicking on TaskRuns tree view it throws an error.

When clicking on TaskRuns tree view it throws an error error: Cannot read property 'tekton.dev/pipelineTask' of undefined

using the latest pipeline version.

Client version: 0.12.1
Pipeline version: v0.16.3
Triggers version: v0.8.1

closed time in 29 minutes

sudhirverma

issue commentopenshift/odo

describe and create commands test for existing component in context folder is inconsistent

I think as there is no devfile present - the user cannot move forward in anyway, one solution I feel is allowing the user to override the env/env.yaml when user does odo create nodejs.

This should work.

It would be interesting to know how this situation can happen.

Current folder has .odo/env left after previous component and no devfile.yaml

@dgolovin, how did you get it into this state? There should be no way to create this situation with odo.

dgolovin

comment created time in 35 minutes

pull request commenteclipse/che-theia

Make Che-Theia spelling consistent with the docs

LGTM!

azatsarynnyy

comment created time in an hour

PR opened eclipse/che-theia

Make Che-Theia spelling consistent with the docs

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

<!-- Please review the following before submitting a PR: Che's Contributing Guide: https://github.com/eclipse/che/blob/master/CONTRIBUTING.md Pull Request Policy: https://github.com/eclipse/che/wiki/Development-Workflow#pull-requests -->

What does this PR do?

Makes Che-Theia spelling consistent with the rest of the docs. By request of the docs team. Thanks @MichalMaler for noticing that.

Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

What issues does this PR fix or reference?

<!-- Please include any related issue from eclipse che repository (or from another issue tracker). Include link to other pull requests like documentation PR from the docs repo -->

How to test this PR?

<!-- Please explain for example :

  • The test platform (openshift, kubernetes, minikube, CodeReady Container, docker-desktop, etc)
  • Installation method: chectl / che-operator
  • steps to reproduce -->

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

<!-- Select the Happy Path Channel used for tests. stable will use the latest che version to run Che-Theia editor. next will use the current development che version. May be unstable.

if omitted, it will use stable --> HAPPY_PATH_CHANNEL=stable

+40 -40

0 comment

14 changed files

pr created time in an hour

issue openedcode-ready/crc

Space issue - how to clean VM folder /sysroot/ostree/deploy/rhcos/var/lib/containers/storage/overlay

Hi,

I've realized that my CRC space issue is caused by the fact that Container data are not purged after Container is deleted.

This is VM folder, where container folder are created: /sysroot/ostree/deploy/rhcos/var/lib/containers/storage/overlay

Each started container creates new folder here with Container content and when terminated - folder remains here. One folder Example: /sysroot/ostree/deploy/rhcos/var/lib/containers/storage/overlay/1d14f839a486d2ad3a4f3f959e87e704f8096d73ea1f2b730fb73ad167fe0f13

I tried (using some logic based on folder content) to delete folders created by my Pods but I've created too many so my CRC can't start and I've to delete and create cluster again. Ok, I can improve my process but it is danger and difficult.

So question - how to purge mentioned folder or how to set CRC to delete container folder on Container termination? What I need to setup in CRC?

Now, each container restart add new folder, previous remain. So VM size is growing and growing.

Thanks a lot, Jiri

created time in an hour

push eventeclipse/che

cccs-eric

commit sha 17824f86a0622104b32f37590696f9f31137ca60

Adding support for Keycloak admin secret and endpoint-watcher image configuration (#18506) * Added support for Keycloak admin secret Added support to change endpoint-watcher image Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca> * Added user feedback and validation for Keycloak password Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca> * Apply suggestions from code review Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca> Co-authored-by: Anatolii Bazko <abazko@redhat.com> * Apply suggestions from code review Signed-off-by: Eric Ladouceur <eric.ladouceur@cyber.gc.ca> Co-authored-by: Anatolii Bazko <abazko@redhat.com> Co-authored-by: Anatolii Bazko <abazko@redhat.com>

view details

push time in an hour

PR merged eclipse/che

Reviewers
Adding support for Keycloak admin secret and endpoint-watcher image configuration kind/enhancement status/code-review

What does this PR do?

Currently the only supported ways of configuring the admin user of Keycloak are:

  1. Set its username and password via helm values
  2. Leave the default admin:admin and mark them as to be changed at first login.

This PR is introducing a new way to inject the username and password using a Kubernetes secret, which make this more secure than passing values in the clear in helm values. It is adding this new way and keeping the other ones also. To create a secret recognized by the chart, you would do the following:

kubectl --namespace ${NAMESPACE} create secret generic keycloak-admin-secret \
    --from-literal=user=admin \
    --from-literal=password=XXXXXX

and then in your values.yaml:

che-keycloak:
  keycloakCredentialsSecret: "keycloak-admin-secret"
  #requireAdminPasswordChange: true
  #keycloakAdminUserName: admin
  #keycloakAdminUserPassword: admin

The PR also adds a new global value to configure quay.io/eclipse/che-endpoint-watcher:nightly image to something else, which is useful if you are using Che's helm charts from the repository and not from chectl. Otherwise, you cannot change the image and you are stuck with the nighlty build.

How to test this PR?

In order to test this, you can create a Che deployment using its helm chart. You could also modify chectl to create a Kubernetes secret with the random password it generates and then --set che-keycloak.keycloakCredentialsSecret=keycloak-admin-secret. In my opinion, modifying chectl in this regard would be a good idea.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

+30 -5

3 comments

4 changed files

cccs-eric

pr closed time in an hour

issue closedeclipse/che

[chectl] - set CheCluster `server.cheClusterRoles` to namespace-editor ClusterRole

Is your enhancement related to a problem? Please describe.

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] --> When chectl deploys ClusterRoles for operator, it uses custom naming. It needs to tell che-operator the name of namespace-editor ClusterRole.

Describe the solution you'd like

<!-- A clear and concise description of what you want to happen. --> When chectl deploys che-operator, it should set the namespace-editor ClusterRole name to server.cheClusterRoles of the CheCluster CR.

Describe alternatives you've considered

<!--A clear and concise description of any alternative solutions or features you've considered. -->

Additional context

<!-- Add any other context or screenshots about the enhancement here. --> https://github.com/eclipse/che/issues/17504

closed time in an hour

sparkoo

issue commenteclipse/che

[chectl] - set CheCluster `server.cheClusterRoles` to namespace-editor ClusterRole

fixed by https://github.com/che-incubator/chectl/pull/1003

sparkoo

comment created time in an hour

push eventopenshift/odo

Yana Hontyk

commit sha ed4a082b7792f3182974634b94aae945cd46e6d3

Add a note to the Operators docs. [skip ci] (#4282) Signed-off-by: Yana Hontyk <yhontyk@redhat.com>

view details

push time in an hour

PR merged openshift/odo

Reviewers
Add a note to the Operators docs. [skip ci] approved kind/documentation lgtm

Signed-off-by: Yana Hontyk yhontyk@redhat.com

What type of PR is this? /kind documentation [skip ci]

What does this PR do / why we need it: Clarity about around installing Operators on the cluster. Which issue(s) this PR fixes:

Fixes https://github.com/openshift/odo/issues/4130

PR acceptance criteria:

  • [ ] Unit test

  • [ ] Integration test

  • [x] Documentation

  • [ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:

+10 -1

4 comments

1 changed file

boczkowska

pr closed time in an hour

issue closedopenshift/odo

We need clarity around installing and using Operators with odo both on OCP & k8s environments

<!--

Welcome! - We kindly ask you to:

  1. Check the documents under https://github.com/openshift/odo/tree/master/docs
  2. Use the Google group if you have a question/doubt rather than a documentat mistake or request.

The group is at: https://groups.google.com/forum/#!forum/odo-users

Thanks for understanding, and for contributing to the project!

-->

What mistake did you find / what is missing in the documentation?

odo has the feature to start services from Operators and link Devfile components to it. But installing Operators in itself is not a task that can be done by odo. We need to document that it's not in the scope of odo and point users to relevant documentation for OCP and k8s about how to install Operators on their cluster.

What is the relevance of it?

Lately we're seeing confusion around Operators wherein certain users are expecting to use odo to install Operators.

/kind documentation /area service-operators

closed time in an hour

dharmit
more