profile
viewpoint
Gonzalo D'Elia gndelia Argentina Software Engineer.

gndelia/codemod-replace-react-fc-typescript 68

jscodeshift's codemod to replace React.FC when using React with Typescript

gndelia/onesky-uploader-action 5

GitHub action to upload resource files to OneSky

bloq/eslint-config-bloq 0

Bloq's ESLint shareable config

estefaniadiaz/docx-templates 0

Template-based docx report creation

gndelia/blog 0

Repository containing entries from my blog

gndelia/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

gndelia/dom-testing-library 0

🐙 Simple and complete DOM testing utilities that encourage good testing practices.

gndelia/es.javascript.info 0

Spanish translation of javascript.info site.

gndelia/eslint-plugin-testing-library 0

ESLint plugin for Testing Library

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventgndelia/codemod-replace-react-fc-typescript

dependabot[bot]

commit sha d3264ad38b4536a69d06f6ea7733e3164ba0a850

build(deps): bump path-parse from 1.0.6 to 1.0.7 (#23) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 13 days

PR merged gndelia/codemod-replace-react-fc-typescript

build(deps): bump path-parse from 1.0.6 to 1.0.7 dependencies

Bumps path-parse from 1.0.6 to 1.0.7. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/jbgutierrez/path-parse/commits/v1.0.7">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

delete branch gndelia/codemod-replace-react-fc-typescript

delete branch : dependabot/npm_and_yarn/tmpl-1.0.5

delete time in 13 days

push eventgndelia/codemod-replace-react-fc-typescript

dependabot[bot]

commit sha 7782d3b47a81ebfa359540d263a1de6ba3417497

build(deps): bump tmpl from 1.0.4 to 1.0.5 (#22) Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 13 days

PR merged gndelia/codemod-replace-react-fc-typescript

build(deps): bump tmpl from 1.0.4 to 1.0.5 dependencies

Bumps tmpl from 1.0.4 to 1.0.5. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/daaku/nodejs-tmpl/commits/v1.0.5">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 13 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventpurefinance/pure.finance

Gonzalo D'Elia

commit sha 1d068e53193d9f4d85688caf42ba55db9d142271

Remove duplicated Question icon component

view details

push time in 20 days

push eventpurefinance/pure.finance

Martin Bon Foster

commit sha 69a707981bfb90a6bd7edf313eb5938a8c5f4741

Add sweep dust to unwrap eth

view details

Gabriel Montes

commit sha da1ec538c16ecf6ed120b5f2df8e70a157790892

Merge pull request #78 from purefinance/sweep-dust-unwrap-eth Add sweep dust to unwrap eth

view details

Gabriel Montes

commit sha 5bdbf8b8cab28f5c81968500644caf1f458c387d

Update the deployment script

view details

Gabriel Montes

commit sha ea552d3b447c47280fb2824f438c8dcf80c1a36c

Update dependencies to force a deploy

view details

Gabriel Montes

commit sha 2a9b0e21b895e6c8e5ee1904d7814021be3eee8a

Merge pull request #79 from purefinance/upd-deploy-script Update the deployment script

view details

Gabriel Montes

commit sha b8b826fd8d5a4308dc4597d515b3f4e1aafefd02

Remove extra env var set through .env instead

view details

Gabriel Montes

commit sha 08764166450767deafe7ee65860ee24eb4f7cda0

Update more deps

view details

Gabriel Montes

commit sha be204f73104c6467d6569398e2edac2b0b20dda5

Merge pull request #80 from purefinance/upd-deploy-script Cleanup deploy script

view details

Gonzalo D'Elia

commit sha 30db5bc48dffffcb475d3b1cda73292de100d9e8

Merge branch 'master' into pf-payments

view details

push time in 25 days

push eventpurefinance/pure.finance

Gonzalo D'Elia

commit sha 09c5cd23f7a7aef37a2cae9900269d962bb922c2

Add streams cache in UI

view details

push time in a month

PullRequestReviewEvent

push eventpurefinance/pure.finance

Gonzalo D'Elia

commit sha 6d23bedfc19ad6c13f2b5845124ce50d46434fd5

Verify approved token in Streams with chainlink data

view details

Gonzalo D'Elia

commit sha af93d4da9f1c6d7ba678767b230a68b6864e2711

Merge branch 'pf-payments' of github.com:purefinance/pure.finance into pf-payments

view details

Gonzalo D'Elia

commit sha 8a5ea692cffda73dc8f08a20b0e66446664d2cab

erge branch 'pf-payments' of github.com:purefinance/pure.finance into pf-payments

view details

push time in a month

issue commentChainSafe/web3.js

getFeeHistory gives error when running local fork with hardhat

I get Method eth_feeHistory not supported. - but that might be that I just need to update ganache-cli 😬

gndelia

comment created time in a month

issue commentnomiclabs/hardhat

eth_feeHistory gives error when calling it from web3 (with hardhat local fork)

Thanks for your response @fvictorio ! I tried to find the spec before opening the tickets in both repos but I failed to find them. Thanks for the help! 🚀

gndelia

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

issue openednomiclabs/hardhat

eth_feeHistory gives error when calling it from web3 (with hardhat local fork)

When calling getFeeHistory in my app, using a local fork with hardhat, I get the following error

Error: Internal JSON-RPC error.
{
  "code": -32602,
  "message": "Errors encountered in param 0: Invalid value 1 supplied to : QUANTITY"
}

Expected Behavior

I expect the proper response of eth_feeHistory, something like

{
        "oldestBlock": "0xce1806",
        "baseFeePerGas": [
            "0x26a51093d0",
            "0x2532e26b6d"
        ],
        "gasUsedRatio": [
            0.35032733868710536
        ]
}

Steps to Reproduce

fork a hardhat node with

npx hardhat node \
  --fork "$BASE_NODE_URL" \
  --verbose

This is the very basic config I've used

'use strict'
require('dotenv').config()

module.exports = {
  defaultNetwork: 'hardhat',
  networks: {
    hardhat: {
      accounts: {
        accountsBalance: process.env.WEI_BALANCE || '10000000000000000000000',
        mnemonic: process.env.MNEMONIC
      },
      forking: {
        url: process.env.BASE_NODE_URL,
        blockNumber: process.env.BLOCK_NUMBER
          ? parseInt(process.env.BLOCK_NUMBER)
          : undefined
      }
    },
    mainnet: {
      url: process.env.BASE_NODE_URL,
      chainId: 1
    }
  }
}

BASE_NODE_URL contains an HTTPS URL of a node that supports eth_feeHistory.

Then, from JS, I just do

const web3 = new Web3(new Web3.providers.HttpProvider('local-fork-url'))
web3.eth.getFeeHistory(1, 'latest', []).then(console.log).catch(console.error)
// same problem with
// web3.eth.getFeeHistory('0x1', 'latest', []).then(console.log).catch(console.error)

and I get the above-mentioned error. If instead of pointing out to a local fork I point out to the HTTPS URL directly (without any local fork), it works.

Environment

  • Web3.js Version: 1.5.3 (which supports EIP-1559)
  • Operating System: Mac OS 11.6
  • Browser: Brave
  • Node.js Version: 14.16.1
  • NPM Version: 6.14.32

There's a counterpart of this issue in web3js repo https://github.com/ChainSafe/web3.js/issues/4510 but it seems they believe the problem is within hardhat

created time in a month

issue commentChainSafe/web3.js

getFeeHistory gives error when running local fork with hardhat

Thanks for your response! I'll try to ping them on their side. I'm ok if you want to close this in the meantime. Thank you!

gndelia

comment created time in a month

issue openedChainSafe/web3.js

getFeeHistory gives error when running local fork with hardhat

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

Not sure if this is an error in web3.js or in hardhat, but after reading some docs and tracing the possible bug fix I think it should be fixed here (I might be wrong!)

When calling getFeeHistory in my app, using a local fork with hardhat, I get the following error

Error: Internal JSON-RPC error.
{
  "code": -32602,
  "message": "Errors encountered in param 0: Invalid value 1 supplied to : QUANTITY"
}

Expected Behavior

I expect the proper response of eth_feeHistory, something like

{
        "oldestBlock": "0xce1806",
        "baseFeePerGas": [
            "0x26a51093d0",
            "0x2532e26b6d"
        ],
        "gasUsedRatio": [
            0.35032733868710536
        ]
    }

Steps to Reproduce

(according to the docs, these are valid parameters)


web3.eth.getFeeHistory('0x1', 'latest', []).then(console.log).catch(console.error)

By running this with a local fork with hardhat, I get the above-mentioned error (See below for hardhat config)

Web3.js Version

1.5.3

Environment

  • Operating System: Mac OS 11.6
  • Browser: Brave
  • Node.js Version: 14.16.1
  • NPM Version: 6.14.32

Anything Else?

hardhat config is pretty simple

.'use strict'
require('dotenv').config()

module.exports = {
  defaultNetwork: 'hardhat',
  networks: {
    hardhat: {
      accounts: {
        accountsBalance: '10000000000000000000000',
        mnemonic: process.env.MNEMONIC
      },
      forking: {
        url: process.env.BASE_NODE_URL,
        blockNumber: 8
      }
    },
    mainnet: {
      url: process.env.BASE_NODE_URL,
      chainId: 1
    }
  }
}

hardhat version: 2.6.7

so I just run npx hardhat node and connect with Metamask to that local fork

Then, the code of the app just do what I wrote in the "Steps to Reproduce" section After a couple of hours of debugging; I found that if I change this line right here, updating the formatters for eth_feeHistory from

new Method({
  name: 'getFeeHistory',
  call: 'eth_feeHistory',
  params: 3,
  inputFormatter: [utils.toNumber, formatter.inputBlockNumberFormatter, null]
}),

to

new Method({
  name: 'getFeeHistory',
  call: 'eth_feeHistory',
  params: 3,
  // replace utils.toNumber here with utils.numberToHex
  inputFormatter: [utils.numberToHex, formatter.inputBlockNumberFormatter, null]
}),

then it works. I found this as part of implementing EIP-1559 for a dapp.

I tried to use this method with a fork with ganache-cli, but I also failed to make it work, but I am still unsure of the reasons, as the error was different.

Not sure if this is a problem in web3 or in hardhat though 😓

created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

startedAfterShip/phone

started time in 2 months

PR opened AfterShip/phone

Extend Bolivia to accept mobile phones beginning with 6

According to Wikipedia, Bolivia has started to accept mobile phones that start with 6, in addition to 7 (See cellphones at the bottom)

image

The Spanish version has a bit more info, stating that it is a recent change. See here

I fail to find an official regulation, but several pages, such as this one also include 6 as a valid prefix

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchgndelia/phone

branch : update-bolivia-prefix

created branch time in 2 months

fork gndelia/phone

With a given country and phone number, validate and reformat the mobile phone number to the E.164 standard. The purpose of this is to allow us to send SMS to mobile phones only.

https://www.aftership.com

fork in 2 months

more