profile
viewpoint
Gireesh Punathil gireeshpunathil IBM India Working to improve man - machine interactions

expressjs/discussions 33

Public discussions for the Express.js organization

gireeshpunathil/nodev0.12.7tlsmemoryleak 2

Standalone test case which shows C++ objects pertinent to TLS/SSL leaking over time

gireeshpunathil/nodev0.10httpsmemoryleak 1

Contains test case which demonstrates how Buffer, Request, IncomingMessage objects are leaking across completely recycled transactions.

gireeshpunathil/admin 0

Facilitating joint collaboration amongst the TSC and CommComm

gireeshpunathil/appsody 0

Appsody command line tool.

gireeshpunathil/appsody-buildah 0

A docker image with Appsody CLI installed that can be used for running Appsody with buildah in Tekton pipelines.

gireeshpunathil/appsody-docker 0

A docker image with Appsody CLI installed. Useful for running Appsody in Tekton pipelines.

gireeshpunathil/blink 0

Example file to blink the LED on an Arduino

gireeshpunathil/build 0

Better build and test infra for Node.

PR closed nodejs/node

:D C++

Hi there this is just a test please disregard. :D

+1 -1

0 comment

1 changed file

techhire11

pr closed time in a day

issue commentnodejs/node

flaky: test-child-process-pipe-dataflow

looking at the dates of landing that PR and the latest issue report (march 13 and April 20) I would say it is not resolved fully. However, we might be seeing a different issue here:

1 !== 0 // exit code of one of the child bad
131072 < 1048576 // truncated data in one of the child

I guess we are not seeing these anymore, while

0 !== 1048576 || 1048577 // full data loss in the pipes

start seeing this, which looks to be a new issue to me.

  • abrupt child exit cannot be, as we have checks in place
  • stream errors cannot be, as those should have resulted in child abnormal exits?
  • pre-mature stream close that was absorbed adn not thrown - possible
refack

comment created time in 3 days

Pull request review commentnodejs/node

win: allow skipping the supported platform check

 #include <VersionHelpers.h> #include <WinError.h> +#define SKIP_CHECK_VAR "NODE_SKIP_PLATFORM_CHECK"+#define SKIP_CHECK_SIZE 1+#define SKIP_CHECK_VALUE "1"+ int wmain(int argc, wchar_t* wargv[]) {   // Windows Server 2012 (not R2) is supported until 10/10/2023, so we allow it   // to run in the experimental support tier.+  char buf[SKIP_CHECK_SIZE + 1];   if (!IsWindows8Point1OrGreater() &&-      !(IsWindowsServer() && IsWindows8OrGreater())) {+      !(IsWindowsServer() && IsWindows8OrGreater()) &&+      (GetEnvironmentVariableA(SKIP_CHECK_VAR, buf, sizeof(buf)) !=+       SKIP_CHECK_SIZE ||+       strncmp(buf, SKIP_CHECK_VALUE, SKIP_CHECK_SIZE + 1) != 0)) {     fprintf(stderr, "This application is only supported on Windows 8.1, "
    fprintf(stderr, "Node.js is only supported on Windows 8.1, "

Otherwise it brings a confusion to the user: which application? the one that runs on Node.js, Is it coming from a third party module, etc.

(I know this word not touched by this PR, but given that we are changing the behavior here, it makes sense to reduce confusion)

joaocgreis

comment created time in 5 days

PR closed ibmruntimes/yieldable-json

Fix small typo in readme

I am using this package to great success. Just wanted to say thanks for this work guys.

Here's a small typo fix.

+1 -1

1 comment

1 changed file

matttt

pr closed time in 7 days

pull request commentibmruntimes/yieldable-json

Fix small typo in readme

landed in 1765b6cbee1524f3e282073a67d28f89f4bb26d0 , thanks for the contribution!

matttt

comment created time in 7 days

push eventibmruntimes/yieldable-json

Matthew Martori

commit sha 1765b6cbee1524f3e282073a67d28f89f4bb26d0

doc: fix small typo in readme I am using this package to great success. Just wanted to say thanks for this work guys. Here's a small typo fix. PR-URL: https://github.com/ibmruntimes/yieldable-json/pull/26 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

push time in 7 days

issue commentnodejs/diagnostics

Node.js Diagnostics WorkGroup Meeting 2020-05-20

thanks @mmarchini . few points:

  • we don't have to stick to one proposal
  • tracing arch in core - looks great to me

in short, items that benefit from wider discussions

mhdawson

comment created time in 7 days

issue commentibmruntimes/yieldable-json

Loop starvation time

@logidelic - I haven't tested to see how expensive it is; but assuming it is not, still how frequently will you call it, to figure out an interval has reached? after every JSON field processing? or every 100 fields? there is a tradeoff between number of fields we want to skip versus the precision in meeting the responsiveness SLA versus the perf penalty we pay in calling the hrtime.

logidelic

comment created time in 8 days

issue commentibmruntimes/yieldable-json

Loop starvation time

I still think it would be useful to allow specifying a threshold in ms as an alternative

@logidelic - I understand, and have full desire to achieve that, as that is the best abstraction that an end user can understand, as opposed to the number of JSON fields being processed as a criteria. Unfortunately, there is no direct way of detecting elapsed time while performing CPU bound operations without resorting to heavy duty checks. Normal node.js timer primitives such as setInterval etc. will not work here, as those are async. and will not go well with the JSON processing.

In summary, desire is to expose a time threshold, but we are not yet there!

logidelic

comment created time in 8 days

issue commentnodejs/diagnostics

Node.js Diagnostics WorkGroup Meeting 2020-05-20

I would like to propose collab-summit session proposal (https://github.com/openjs-foundation/summit/issues/236) from diag WG as well, to be added to agenda.

mhdawson

comment created time in 9 days

issue commentibmruntimes/yieldable-json

Loop starvation time

@logidelic - thanks for reviewing that, and the issue. 5 ms is empirically drawn value, neither fixed nor tunable.

However, we take an input called intensity for the APIs. This essentially acts as a counter, while traversing through deeply nested structures, when the count of traversal reaches the intensity value, we return back from the JSON API (with a yield clause, so that we can resume from there later), and attend to the rest of the work for a while.

The value of 5 ms is obtained from a normal linux system when we used 512 as the intensity. So we used this default value.

As you say, if the system, the nature of the JSON, the responsiveness SLA etc. changes and you want a different loop starvation, all you need to do is to adjust the intensity for a couple of times, find out your sweet spot, and fix it there.

Hope this helps!

logidelic

comment created time in 12 days

issue closedappsody/stacks

deploy: org.apache.kafka.common.KafkaException: Failed to construct kafka consumer

Describe the bug when deployed an appsody stack of type spring-boot2 kafka failed in openshift with the quoted error message

To Reproduce Steps to reproduce the behavior:

  1. appsody init java-spring-boot2 kafka
  2. appsody run

Expected behavior A clear and concise description of what you expected to happen.

the stack is booted up and running

Actual behaviour

[Container] 2020-05-04 13:07:44.982 ERROR 171 --- [  restartedMain] o.s.boot.SpringApplication               : Application run failed
[Container] 
[Container] org.springframework.context.ApplicationContextException: Failed to start bean 'org.springframework.kafka.config.internalKafkaListenerEndpointRegistry'; nested exception is org.apache.kafka.common.KafkaException: Failed to construct kafka consumer
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:185) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:53) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:360) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:158) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:122) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:893) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.finishRefresh(ServletWebServerApplicationContext.java:162) ~[spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:552) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:141) ~[spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:744) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:391) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.run(SpringApplication.java:312) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1215) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1204) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at application.Main.main(Main.java:10) [classes/:na]
[Container] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_242]
[Container] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_242]
[Container] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_242]
[Container] 	at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_242]
[Container] 	at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:49) [spring-boot-devtools-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] Caused by: org.apache.kafka.common.KafkaException: Failed to construct kafka consumer
[Container] 	at org.apache.kafka.clients.consumer.KafkaConsumer.<init>(KafkaConsumer.java:799) ~[kafka-clients-2.0.1.jar:na]
[Container] 	at org.apache.kafka.clients.consumer.KafkaConsumer.<init>(KafkaConsumer.java:615) ~[kafka-clients-2.0.1.jar:na]
[Container] 	at org.springframework.kafka.core.DefaultKafkaConsumerFactory.createKafkaConsumer(DefaultKafkaConsumerFactory.java:164) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.core.DefaultKafkaConsumerFactory.createConsumerWithAdjustedProperties(DefaultKafkaConsumerFactory.java:160) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.core.DefaultKafkaConsumerFactory.createKafkaConsumer(DefaultKafkaConsumerFactory.java:135) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.core.DefaultKafkaConsumerFactory.createConsumer(DefaultKafkaConsumerFactory.java:109) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.listener.AbstractMessageListenerContainer.checkTopics(AbstractMessageListenerContainer.java:300) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.listener.ConcurrentMessageListenerContainer.doStart(ConcurrentMessageListenerContainer.java:136) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.listener.AbstractMessageListenerContainer.start(AbstractMessageListenerContainer.java:292) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.config.KafkaListenerEndpointRegistry.startIfNecessary(KafkaListenerEndpointRegistry.java:311) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.config.KafkaListenerEndpointRegistry.start(KafkaListenerEndpointRegistry.java:255) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:182) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	... 19 common frames omitted
[Container] Caused by: org.apache.kafka.common.config.ConfigException: Invalid url in bootstrap.servers: ${KAFKA_BOOTSTRAP_SERVERS}
[Container] 	at org.apache.kafka.clients.ClientUtils.parseAndValidateAddresses(ClientUtils.java:51) ~[kafka-clients-2.0.1.jar:na]
[Container] 	at org.apache.kafka.clients.consumer.KafkaConsumer.<init>(KafkaConsumer.java:709) ~[kafka-clients-2.0.1.jar:na]
[Container] 	... 30 common frames omitted

Environment Details (please complete the following information):

  • OS: mac os
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

If applicable please specify:

  • CLI version: 0.6.1
  • Stack you are using (including the version):

spring-boot2 kafka

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

afterwards, the log showed:

[Container] 
[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] BUILD SUCCESS
[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] Total time:  01:34 min
[Container] [INFO] Finished at: 2020-05-04T13:07:45Z
[Container] [INFO] ------------------------------------------------------------------------

not sure what that means

we are building solution builder that builds deployment descriptors and stack images from a graphics based user input. the failure actually was reported when we deployed the generated yaml.

closed time in 22 days

gireeshpunathil

issue commentappsody/stacks

deploy: org.apache.kafka.common.KafkaException: Failed to construct kafka consumer

following the above suggestion solves the issue; thanks!

gireeshpunathil

comment created time in 22 days

issue commentnodejs/TSC

TSC Chair Election 2020 - proposed schedule

@mhdawson continuing as chair: +1 not needing a voting: +1

mhdawson

comment created time in 22 days

issue commentnodejs/diagnostics

Node.js Diagnostics WorkGroup Meeting 2020-05-06

a new entry to the existing agenda: Discuss usage and support of eBPF #386 (@No9 will present eBPF, ~15 minutes)

mhdawson

comment created time in 23 days

issue commentnodejs/diagnostics

Discuss usage and support of eBPF

@No9 - thanks, I have added this to the agenda in the upcoming meeting.

No9

comment created time in 23 days

issue openedappsody/stacks

deploy: org.apache.kafka.common.KafkaException: Failed to construct kafka consumer

Describe the bug when deployed an appsody stack of type spring-boot2 kafka failed in openshift with the quoted error message

To Reproduce Steps to reproduce the behavior:

  1. appsody init java-spring-boot2 kafka
  2. appsody run

Expected behavior A clear and concise description of what you expected to happen.

the stack is booted up and running

Actual behaviour

[Container] 2020-05-04 13:07:44.982 ERROR 171 --- [  restartedMain] o.s.boot.SpringApplication               : Application run failed
[Container] 
[Container] org.springframework.context.ApplicationContextException: Failed to start bean 'org.springframework.kafka.config.internalKafkaListenerEndpointRegistry'; nested exception is org.apache.kafka.common.KafkaException: Failed to construct kafka consumer
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:185) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:53) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:360) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:158) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:122) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:893) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.finishRefresh(ServletWebServerApplicationContext.java:162) ~[spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:552) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:141) ~[spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:744) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:391) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.run(SpringApplication.java:312) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1215) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1204) [spring-boot-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] 	at application.Main.main(Main.java:10) [classes/:na]
[Container] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_242]
[Container] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_242]
[Container] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_242]
[Container] 	at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_242]
[Container] 	at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:49) [spring-boot-devtools-2.1.12.RELEASE.jar:2.1.12.RELEASE]
[Container] Caused by: org.apache.kafka.common.KafkaException: Failed to construct kafka consumer
[Container] 	at org.apache.kafka.clients.consumer.KafkaConsumer.<init>(KafkaConsumer.java:799) ~[kafka-clients-2.0.1.jar:na]
[Container] 	at org.apache.kafka.clients.consumer.KafkaConsumer.<init>(KafkaConsumer.java:615) ~[kafka-clients-2.0.1.jar:na]
[Container] 	at org.springframework.kafka.core.DefaultKafkaConsumerFactory.createKafkaConsumer(DefaultKafkaConsumerFactory.java:164) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.core.DefaultKafkaConsumerFactory.createConsumerWithAdjustedProperties(DefaultKafkaConsumerFactory.java:160) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.core.DefaultKafkaConsumerFactory.createKafkaConsumer(DefaultKafkaConsumerFactory.java:135) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.core.DefaultKafkaConsumerFactory.createConsumer(DefaultKafkaConsumerFactory.java:109) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.listener.AbstractMessageListenerContainer.checkTopics(AbstractMessageListenerContainer.java:300) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.listener.ConcurrentMessageListenerContainer.doStart(ConcurrentMessageListenerContainer.java:136) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.listener.AbstractMessageListenerContainer.start(AbstractMessageListenerContainer.java:292) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.config.KafkaListenerEndpointRegistry.startIfNecessary(KafkaListenerEndpointRegistry.java:311) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.kafka.config.KafkaListenerEndpointRegistry.start(KafkaListenerEndpointRegistry.java:255) ~[spring-kafka-2.2.12.RELEASE.jar:2.2.12.RELEASE]
[Container] 	at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:182) ~[spring-context-5.1.13.RELEASE.jar:5.1.13.RELEASE]
[Container] 	... 19 common frames omitted
[Container] Caused by: org.apache.kafka.common.config.ConfigException: Invalid url in bootstrap.servers: ${KAFKA_BOOTSTRAP_SERVERS}
[Container] 	at org.apache.kafka.clients.ClientUtils.parseAndValidateAddresses(ClientUtils.java:51) ~[kafka-clients-2.0.1.jar:na]
[Container] 	at org.apache.kafka.clients.consumer.KafkaConsumer.<init>(KafkaConsumer.java:709) ~[kafka-clients-2.0.1.jar:na]
[Container] 	... 30 common frames omitted

Environment Details (please complete the following information):

  • OS: mac os
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

If applicable please specify:

  • CLI version: 0.6.1
  • Stack you are using (including the version):

spring-boot2 kafka

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

afterwards, the log showed:

[Container] 
[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] BUILD SUCCESS
[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] Total time:  01:34 min
[Container] [INFO] Finished at: 2020-05-04T13:07:45Z
[Container] [INFO] ------------------------------------------------------------------------

not sure what that means

we are building solution builder that builds deployment descriptors and stack images from a graphics based user input. the failure actually was reported when we deployed the generated yaml.

created time in 23 days

issue commentopenshift/origin

diagnostics operator

3 months with no human response, sad! Is there anything I can help with to move this forward? /remove-lifecycle stale

gireeshpunathil

comment created time in 23 days

issue commentkubernetes/kubernetes

Automatic PV(C) support

no acknowledgement for 3 months. sad!

/remove-lifecycle stale

gireeshpunathil

comment created time in 25 days

PR closed nodejs/node

doc: add util.types.isArrayBufferView() author ready doc util

This function was added by nodejs/node#15663, but was never documented. This PR adds it to the documentation for util.

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+19 -0

1 comment

1 changed file

kevinoid

pr closed time in 25 days

pull request commentnodejs/node

doc: add util.types.isArrayBufferView()

landed in 7c36ec38f16add6ecfc1a3514514b55c5b610434

kevinoid

comment created time in 25 days

push eventnodejs/node

Kevin Locke

commit sha 7c36ec38f16add6ecfc1a3514514b55c5b610434

doc: add util.types.isArrayBufferView() This function was added by nodejs/node#15663, but was never documented. This commit documents it. PR-URL: https://github.com/nodejs/node/pull/33092 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

push time in 25 days

PR closed nodejs/node

Reviewers
doc: clarify when not to run CI on docs author ready doc review wanted

Collaborators won't need to run CI on documentation-only changes.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+4 -2

1 comment

1 changed file

juanarbol

pr closed time in 25 days

pull request commentnodejs/node

doc: clarify when not to run CI on docs

landed 26477b82a5fa1db918b4969918859d28bb0d7193

juanarbol

comment created time in 25 days

push eventnodejs/node

Juan José Arboleda

commit sha 26477b82a5fa1db918b4969918859d28bb0d7193

doc: clarify when not to run CI on docs Collaborators won't need to run CI on documentation-only changes. PR-URL: https://github.com/nodejs/node/pull/33101 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

push time in 25 days

Pull request review commentnodejs/node

meta: add issue template for API reference docs

+---+name: "\U0001F4D7 Open an issue regarding the Node.js API reference docs"+about: Let us know about any problematic API reference documents+title: "doc: "+labels: doc+---++# 📗 API Reference Docs Problem++<!------------------------------------------------------------------------------+Thank you for wanting to make nodejs.org better!++This template is for issues with the Node.js API reference docs.++For more general support, please open an issue in+our help repo at “https://github.com/nodejs/help”.++For the issue title, enter a one-line summary after “doc: ”.+The “✍️” signifies a request for input. If unsure, do the best you can.++If you found a problem with nodejs.org beyond the API reference docs, please+open an issue in our website repo at “https://github.com/nodejs/nodejs.org”.+------------------------------------------------------------------------------->++<!--+Version: output of “node -v”+Platform: output of “uname -a” (UNIX), or version and 32 or 64-bit (Windows)+Subsystem: if known, please specify affected core module name+-->++- **Version**: ✍️+- **Platform**: ✍️+- **Subsystem**: ✍️++## Location++_Section of the site where the content exists_++Affected URL(s):+- https://nodejs.org/api/✍️++## Problem description+

may be:

  • [ ] missing / incomplete doc
  • [ ] doc is confusing
  • [ ] actual behavior not aligned with doc
DerekNonGeneric

comment created time in a month

Pull request review commentnodejs/diagnostics

doc: add minutes for meeting 22 Apr 2020

+# Node.js  Diagnostics WorkGroup Meeting 2020-04-22++## Links++* **Recording**: https://www.youtube.com/watch?v=AUL_rA6_Gz4+* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/381+* **Minutes Google Doc**: https://docs.google.com/document/d/1nBAFxiu3DSbp4yu8meZeIAB5ZLCaazjCU33OU_gHEfA++## Present++* Diagnostics team: @nodejs/diagnostics+* Stephen Belanger @qard+* Michael Dawson (@mhdawson)+* Gireesh Punathil (@gireeshpunathil)+* Chengzhong Wu (@legendecas)+* Peter Marton (@hekike)+* Harshitha K P (@harshithakp)+* Matheus Marchini (@mmarchini)+ ++## Agenda++## Announcements+ +*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.++### nodejs/diagnostics++* Deep dives are pushed out currently because of many topics+  * Gireesh: earlier we switched two bi-weekly because of low attendance+  * Michael: we could add to calendar+  * Peter: should we try this approach and create a deep dive next week and normal meeting after that+  * Mattheus: we could always just skip meetings if there is not enough topic+  * Stephen: I’d rather meet more frequently than running out of time+  * Michael: I’ll add to the calendar+* self nomination to diagnostics working group [#379](https://github.com/nodejs/diagnostics/pull/379)+  * Peter: Many approves, what’s the action item here+  * Michael: our rules say we to add to agenda for visibility+* Harshitha: working with Gireesh and interested in Diagnostics+  * Looking into collaborating more into diagnostics and improving tooling +  * Currently interested in Node Report and Heap Profiling+++* COVID-19 and WG sittings [#370](https://github.com/nodejs/diagnostics/issues/370)+  * No concerns/comments this week++* proposal: elevate diagnostic report to tier1 [#369](https://github.com/nodejs/diagnostics/issues/369)+  * Gireesh: Process was approved, raised in main repo now+  * After waiting for seven days we could process, but we have only one approval at the moment+  * Michael: did I approve?+  * Gireesh: une comment about putting back old report to unclassified

@HarshithaKP - done, fixed the typos.

gireeshpunathil

comment created time in a month

push eventgireeshpunathil/diagnostics

Gireesh Punathil

commit sha 462c68c13250463e4c03d12181c6acdc71a1a8f0

fixup: address review comments

view details

push time in a month

issue commentnodejs/admin

Self-nomination: Social Team

+1

bnb

comment created time in a month

issue commentnodejs/node

Dispute of "block running on EOL Windows versions #31954" - Alternative Suggestion

As per the docs, there is no difference between issue and PRs w.r.t tsc agenda. What matters is whether we are in an impasse or not:

https://github.com/nodejs/node/blob/efefdd668dece956c4f75039c77fb0c40dfdd3c8/GOVERNANCE.md#tsc-meetings

Any community member can create a GitHub issue asking that the TSC review something. If consensus-seeking fails for an issue, a Collaborator may apply the tsc-agenda label. That will add it to the TSC meeting agenda.

https://github.com/nodejs/node/blob/f67601cd772b9dbcc94cbf9939b0e229b815e939/doc/guides/onboarding-extras.md#General

tsc-agenda - Open issues and pull requests with this label will be added to the Technical Steering Committee meeting agenda

either ways, there is a PR opened already, so this (tsc agenda or not) is resolved

xCykrix

comment created time in a month

issue commentnodejs/node

Dispute of PR (Alternative Suggestion): #31954

there are few ways:

  • raise a PR with one of the change proposal as above, that allows review and collaboration
  • leave this issue for allowing more opinions to come in, and hoping to see a consensus
  • optionally involve TSC if not converging naturally.

Technically this code change proposal implies a policy change proposal too, and hence I am personally inclined to second and third options.

xCykrix

comment created time in a month

issue commentnodejs/node

Dispute of PR (Alternative Suggestion): #31954

@xCykrix - for me, removing the check or adding the flag is an implementation detail with differing level of abstraction and control; and a consensus on doing or not doing it should happen first, and for me, as notes earlier, I am unable to make an opinion with the current info.

xCykrix

comment created time in a month

pull request commentnodejs/node

worker: add stack size resource limit option

commit in #33084 appears here as well, I guess it is an error?

addaleax

comment created time in a month

issue commentnodejs/node

Dispute of PR (Alternative Suggestion): #31954

@fastcoder15 -

Windows is not a free operating system. If someone bought Win7 machines five years ago, upgrading to Win10 costs money. ...

agree, to the extent of windows is not free and upgrading is not free, so the current state causes users to spend more. This is the very strong reason that makes this issue relevant IMO.

Dropping support for something that still works is at least inappropriate and forces users to spend more resources and time on manually patching and recompiling each release. Even if the support is excluded from official releases, I would suggest keeping the support in some other release channel (like https://unofficial-builds.nodejs.org/).

couple of concerns here:

  • it incurs efforts to the project too, to validate that certain such OS flavors still work. Please remember there are a number of platform combinations.
  • it is not that easy to make such assertions IMO. something that still works cannot be qualified as such. Plurality of workloads might prove the case differently.
  • keeping in channels like https://unofficial-builds.nodejs.org : agree on the logistics and channel, if we decide to publish on unsupported platforms.

Being affraid of receiving issues regarding broken Win7 features is not really a problem in my opinion. State explicitly in the documentation that Win7 is no longer supported and move all future Win7 issues to the help repo, with an explanation that the Node.js team will not work on the fix.

  • I don't think it is a question of being afraid of receiving issues; it is the question of standard release practices versus providing improved user experience.
  • help repo is not differentiated from core repo based on support stands. Instead, it is based on the nature of the issue - perceived as a bug (core) versus may not be a bug, but still need investigation assistance or clarification or advise (help)

While giving all the respect to the Node.js TSC decisions, I would prefer that Node.js in the future conducts a survey for all crucial decisions regarding fundamental user experience features.

  • we have been doing this, couple of examples that come on top of my head are:
    • https://github.com/nodejs/TSC/issues/790
    • https://github.com/nodejs/diagnostics/issues/280 (for pro-actively seeking feedback)
    • user-feedback@nodejs.org (for users to reach out to the project)
    • it is not very easy to collect feedback for every PRs though.

bottom-line: w.r.t do this or don't do this, I am still in the middle, and can reach to an opinion based on more user feedback or more insights.

xCykrix

comment created time in a month

Pull request review commentnodejs/diagnostics

doc: add minutes for meeting 22 Apr 2020

+# Node.js  Diagnostics WorkGroup Meeting 2020-04-22++## Links++* **Recording**: https://www.youtube.com/watch?v=AUL_rA6_Gz4+* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/381+* **Minutes Google Doc**: https://docs.google.com/document/d/1nBAFxiu3DSbp4yu8meZeIAB5ZLCaazjCU33OU_gHEfA++## Present++* Diagnostics team: @nodejs/diagnostics+* Stephen Belanger @qard+* Michael Dawson (@mhdawson)+* Gireesh Punathil (@gireeshpunathil)+* Chengzhong Wu (@legendecas)+* Peter Marton (@hekike)+* Harshitha K P (@harshithakp)+* Matheus Marchini (@mmarchini)+ ++## Agenda++## Announcements+ +*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.++### nodejs/diagnostics++* Deep dives are pushed out currently because of many topics+  * Gireesh: earlier we switched two bi-weekly because of low attendance+  * Michael: we could add to calendar+  * Peter: should we try this approach and create a deep dive next week and normal meeting after that+  * Mattheus: we could always just skip meetings if there is not enough topic+  * Stephen: I’d rather meet more frequently than running out of time+  * Michael: I’ll add to the calendar+* self nomination to diagnostics working group [#379](https://github.com/nodejs/diagnostics/pull/379)+  * Peter: Many approves, what’s the action item here+  * Michael: our rules say we to add to agenda for visibility+* Harshitha: working with Gireesh and interested in Diagnostics+  * Looking into collaborating more into diagnostics and improving tooling +  * Currently interested in Node Report and Heap Profiling+++* COVID-19 and WG sittings [#370](https://github.com/nodejs/diagnostics/issues/370)+  * No concerns/comments this week++* proposal: elevate diagnostic report to tier1 [#369](https://github.com/nodejs/diagnostics/issues/369)+  * Gireesh: Process was approved, raised in main repo now+  * After waiting for seven days we could process, but we have only one approval at the moment+  * Michael: did I approve?+  * Gireesh: une comment about putin back old report to unclassified

@legendecas - thanks, fixed!

gireeshpunathil

comment created time in a month

push eventgireeshpunathil/diagnostics

Gireesh Punathil

commit sha 42ae66a5802ffcf357db4d83dbbfbb87cf74f8eb

fixup: fix typo

view details

push time in a month

issue commentexpressjs/discussions

Express TC Meeting 04-22-2020

Thanks to all who responded with candid and honest opinions and insights on this matter! I value and respect all of those.

In an earnest effort to nullify any tension, I am going to take a step back - I will make little or no interactions in this project for a period of time. This is in no way an act of discord or decision in a haste, but my best effort to balance between project's objectives & priorities, and interpersonal relations & mutual trust, with a bias towards the later.

Looking at work items that I have been involved and helping with, this will imply #100 will be impacted and express 5 GA may be delayed. I am not feeling great to leave it in its current state, so requesting someone who is willing and has bandwidth to take it up.

I care and feel for this project!

dougwilson

comment created time in a month

issue commentnodejs/diagnostics

diagnostic report behavior on fatal error

just trying to figure out if there is anything outstanding.

boneskull

comment created time in a month

issue closednodejs/diagnostics

Session at the OpenJS Collaborator Summit?

Hey Folks,

Are we planning to do a session at the Collab Summit? https://github.com/nodejs/summit/issues/149

M

closed time in a month

mcollina

issue commentnodejs/diagnostics

Session at the OpenJS Collaborator Summit?

obsolete, closing

mcollina

comment created time in a month

issue closednodejs/diagnostics

Issue for Feedback on Diagnostic report

Since Diagnostic report has been recently added to core I think it is good to have an issue where people can post feedback on it's use. Opening this issue for that purpose. @gireeshpunathil will be putting out a blog post that talks about Diagnostic report and will mention this issue as one place to provide feedback.

closed time in a month

mhdawson

issue commentnodejs/diagnostics

Issue for Feedback on Diagnostic report

the report is now stable in core, so closing. pls open feature requests if you have an improvement suggestion, or a bug report if there an issue.

mhdawson

comment created time in a month

issue closednodejs/diagnostics

proposal: elevate diagnostic report to tier1

refs: https://github.com/nodejs/node/blob/master/doc/guides/diagnostic-tooling-support-tiers.md

diagnostic report meets all the criteria required for being tier1, namely:

  • The maintainers of the tool must remain responsive when there are problems; tool is part of the core, so maintainers are node core collaborators itself.
  • The tool must be actively used by the ecosystem; evidence of usage in the field - through core and help repo issues, as well as in person feedback in collab summit 2019 montreal
  • The tool must be heavily depended on; subjective, but report is being established as a unique FFDC capability that helped many issues so far.
  • The tool must have a guide or other documentation in the Node.js GitHub organization or website; - API guide exists part of the org, and several external documentations.
  • The tool must be working on all supported platforms; achieved
  • The tool must only be using APIs exposed by Nodejs as opposed to its dependencies; and
  • The tool must be open source. achieved

I propose to elevate report to tier1 status.

closed time in a month

gireeshpunathil

issue commentnodejs/diagnostics

proposal: elevate diagnostic report to tier1

this is achieved, closing. thanks all!

gireeshpunathil

comment created time in a month

issue closednodejs/diagnostics

Node.js Diagnostics WorkGroup Meeting 2020-03-11

Time

UTC Wed 11-Mar-2020 16:30 (04:30 PM):

Timezone Date/Time
US / Pacific Wed 11-Mar-2020 09:30 (09:30 AM)
US / Mountain Wed 11-Mar-2020 10:30 (10:30 AM)
US / Central Wed 11-Mar-2020 11:30 (11:30 AM)
US / Eastern Wed 11-Mar-2020 12:30 (12:30 PM)
London Wed 11-Mar-2020 16:30 (04:30 PM)
Amsterdam Wed 11-Mar-2020 17:30 (05:30 PM)
Moscow Wed 11-Mar-2020 19:30 (07:30 PM)
Chennai Wed 11-Mar-2020 22:00 (10:00 PM)
Hangzhou Thu 12-Mar-2020 00:30 (12:30 AM)
Tokyo Thu 12-Mar-2020 01:30 (01:30 AM)
Sydney Thu 12-Mar-2020 03:30 (03:30 AM)

Or in your local time:

  • http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Diagnostics%20WorkGroup+Meeting+2020-03-11&iso=20200311T16
  • or http://www.wolframalpha.com/input/?i=04PM+UTC%2C+Mar+11%2C+2020+in+local+time

Links

Agenda

Extracted from diag-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/diagnostics

  • doc: self nomination to diagnostics WG #363
  • reportVersion semantics are not defined #349
  • Proposal to drive Diagnostics WG initiatives through user journeys #295
  • Diagnostics "Best Practices" Guide? #211
  • [async_hooks] stable API - tracking issue #124

Invited

  • Diagnostics team: @nodejs/diagnostics

Observers/Guests

Notes

The agenda comes from issues labelled with diag-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

  • link for participants: https://zoom.us/j/466707925
  • For those who just want to watch:
  • youtube admin page: https://www.youtube.com/my_live_events?filter=scheduled

closed time in a month

mhdawson

issue closednodejs/diagnostics

Node.js Diagnostics WorkGroup Meeting 2020-03-25

Time

UTC Wed 25-Mar-2020 16:30 (04:30 PM):

Timezone Date/Time
US / Pacific Wed 25-Mar-2020 09:30 (09:30 AM)
US / Mountain Wed 25-Mar-2020 10:30 (10:30 AM)
US / Central Wed 25-Mar-2020 11:30 (11:30 AM)
US / Eastern Wed 25-Mar-2020 12:30 (12:30 PM)
London Wed 25-Mar-2020 16:30 (04:30 PM)
Amsterdam Wed 25-Mar-2020 17:30 (05:30 PM)
Moscow Wed 25-Mar-2020 19:30 (07:30 PM)
Chennai Wed 25-Mar-2020 22:00 (10:00 PM)
Hangzhou Thu 26-Mar-2020 00:30 (12:30 AM)
Tokyo Thu 26-Mar-2020 01:30 (01:30 AM)
Sydney Thu 26-Mar-2020 03:30 (03:30 AM)

Or in your local time:

  • http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Diagnostics%20WorkGroup+Meeting+2020-03-25&iso=20200325T16
  • or http://www.wolframalpha.com/input/?i=04PM+UTC%2C+Mar+25%2C+2020+in+local+time

Links

Agenda

Extracted from diag-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/diagnostics

  • reportVersion semantics are not defined #349
  • Proposal to drive Diagnostics WG initiatives through user journeys #295
  • Diagnostics "Best Practices" Guide? #211
  • [async_hooks] stable API - tracking issue #124

Invited

  • Diagnostics team: @nodejs/diagnostics

Observers/Guests

Notes

The agenda comes from issues labelled with diag-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

  • link for participants: https://zoom.us/j/466707925
  • For those who just want to watch:
  • youtube admin page: https://www.youtube.com/my_live_events?filter=scheduled

closed time in a month

mhdawson

issue commentnodejs/diagnostics

Node.js Diagnostics WorkGroup Meeting 2020-03-25

closed via #371

mhdawson

comment created time in a month

issue closednodejs/diagnostics

Node.js Diagnostics WorkGroup Meeting 2020-04-08

Time

UTC Wed 08-Apr-2020 16:30 (04:30 PM):

Timezone Date/Time
US / Pacific Wed 08-Apr-2020 09:30 (09:30 AM)
US / Mountain Wed 08-Apr-2020 10:30 (10:30 AM)
US / Central Wed 08-Apr-2020 11:30 (11:30 AM)
US / Eastern Wed 08-Apr-2020 12:30 (12:30 PM)
London Wed 08-Apr-2020 17:30 (05:30 PM)
Amsterdam Wed 08-Apr-2020 18:30 (06:30 PM)
Moscow Wed 08-Apr-2020 19:30 (07:30 PM)
Chennai Wed 08-Apr-2020 22:00 (10:00 PM)
Hangzhou Thu 09-Apr-2020 00:30 (12:30 AM)
Tokyo Thu 09-Apr-2020 01:30 (01:30 AM)
Sydney Thu 09-Apr-2020 02:30 (02:30 AM)

Or in your local time:

  • http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Diagnostics%20WorkGroup+Meeting+2020-04-08&iso=20200408T16
  • or http://www.wolframalpha.com/input/?i=04PM+UTC%2C+Apr+08%2C+2020+in+local+time

Links

Agenda

Extracted from diag-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/diagnostics

  • COVID-19 and WG sittings #370
  • proposal: elevate diagnostic report to tier1 #369
  • reportVersion semantics are not defined #349
  • Proposal to drive Diagnostics WG initiatives through user journeys #295
  • Diagnostics "Best Practices" Guide? #211
  • [async_hooks] stable API - tracking issue #124
  • Node CPU Profiling Roadmap #148

Invited

  • Diagnostics team: @nodejs/diagnostics

Observers/Guests

Notes

The agenda comes from issues labelled with diag-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

  • link for participants: https://zoom.us/j/466707925
  • For those who just want to watch:
  • youtube admin page: https://www.youtube.com/my_live_events?filter=scheduled

closed time in a month

mhdawson

PR closed nodejs/diagnostics

Fixup some typos in using_gc_traces

Fixing up some typos in the just landed PR

+2 -2

1 comment

1 changed file

jasnell

pr closed time in a month

pull request commentnodejs/diagnostics

Fixup some typos in using_gc_traces

landed in dda67870331a2a931f087a46a96fce08d8268a45

jasnell

comment created time in a month

push eventnodejs/diagnostics

James M Snell

commit sha dda67870331a2a931f087a46a96fce08d8268a45

doc: Fixup some typos in using_gc_traces PR-URL: https://github.com/nodejs/diagnostics/pull/383 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshi46@in.ibm.com>

view details

push time in a month

Pull request review commentnodejs/diagnostics

doc: document how to use diagnostic report for abnormal termination

 configuration and component version issues with in your process. //TODO, raw notes from deep dive:  1. Open the generated report (either from file or from console)-2. Take a look to allocation section in the report-3. Look for the old_space-    - used is high-    - available is very low-4. Look javascriptStack to see the victim of the memory leak which can be the allocation pattern and source to find what causes it (JavaScript stack trace won’t always point to the right frame, can be confusing)-5. -> see memory related user journeys to identify exact cause++  Report can be generated using the following cli flags: `node --experimental-report --report-on-fatal-error <app.js>`.
  Report can be generated using the following cli flags: `node --report-on-fatal-error <app.js>`.
HarshithaKP

comment created time in a month

pull request commentnodejs/diagnostics

doc: syntax highlight for bash script

landed in 0953cd27d91e3077aa26e81b07ed61652de2575b

mmarchini

comment created time in a month

push eventnodejs/diagnostics

Matheus Marchini

commit sha 0953cd27d91e3077aa26e81b07ed61652de2575b

doc: syntax highlight for bash script PR-URL: https://github.com/nodejs/diagnostics/pull/373 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

push time in a month

PR opened nodejs/diagnostics

doc: add minutes for meeting 22 Apr 2020

Fixes: https://github.com/nodejs/diagnostics/issues/381

/cc @nodejs/diagnostics

+93 -0

0 comment

1 changed file

pr created time in a month

create barnchgireeshpunathil/diagnostics

branch : 22apr2020

created branch time in a month

PR closed nodejs/node

src: assignment to valid type C++ author ready net

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md --> We are doing conversion of arguments to uint32_t but the lvalue type is not consistent with the casting. Also, the lvalue type differs at different occurrences. Ideally, such changes should be picked up by the linter, can we move forward in this direction 🤔 .

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+3 -2

9 comments

1 changed file

yashLadha

pr closed time in a month

pull request commentnodejs/node

src: assignment to valid type

landed in 658cae06846877a16308b100931c7c8d6f1ed27c

yashLadha

comment created time in a month

push eventnodejs/node

Yash Ladha

commit sha 658cae06846877a16308b100931c7c8d6f1ed27c

src: assignment to valid type We are converting the argument to a uint32_t value but the lvalue is not consistent with the casting. PR-URL: https://github.com/nodejs/node/pull/32879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

push time in a month

pull request commentnodejs/node

tools: decrease timeout in test.py

@addaleax - point taken. I thought I was following the right process (the core-validate-commit was failing without the adjustments), but now looking back, I realize I was using an older version of core-validate-commit

addaleax

comment created time in a month

Pull request review commentnodejs/node

src: assignment to valid type

 void TCPWrap::Listen(const FunctionCallbackInfo<Value>& args) {  void TCPWrap::Connect(const FunctionCallbackInfo<Value>& args) {   CHECK(args[2]->IsUint32());-  int port = args[2].As<Uint32>()->Value();+  uint32_t port = args[2].As<Uint32>()->Value();
  // explicit cast to fit to libuv's type expectation
  int port = static_cast<int>(args[2].As<Uint32>()->Value());
yashLadha

comment created time in a month

Pull request review commentnodejs/node

src: assignment to valid type

 void TCPWrap::SetKeepAlive(const FunctionCallbackInfo<Value>& args) {   Environment* env = wrap->env();   int enable;   if (!args[0]->Int32Value(env->context()).To(&enable)) return;-  unsigned int delay = args[1].As<Uint32>()->Value();+  uint32_t delay = args[1].As<Uint32>()->Value();
  unsigned int delay = static_cast<unsigned int>(args[1].As<Uint32>()->Value());
yashLadha

comment created time in a month

issue commentnodejs/node

Dispute of PR (Alternative Suggestion): #31954

many vendors allow free upgrade. looks like that is not the case here?

pros (of allowing untested / life-ended platforms):

  • in many cases, it does not harm anything; the code will run as is. so great relief for users; business continuity

cons:

  • many customers upgrade slowly. ability to run on older versions cause further slowness
  • maintenance becomes hard. tools, skills, etc. become stale
  • not many bug reports carry OS information despite we ask for it. Many times, several cycles are spent before we dig into that direction. It is not a best practice to start the investigation by suspecting the OS.
  • security and compliance issues for those who care for it.

I do not see one outweighing another; so may be other parameters could be brought in to the considerations.

xCykrix

comment created time in a month

issue commentibmruntimes/yieldable-json

Nested date objects are not get stringified properly

@mickeyjohn - thanks for reporting this. This looks like a bug to me.

@harshithakp - can you pls have a look at this?

mickeyjohn

comment created time in a month

issue commentexpressjs/discussions

Express TC Meeting 04-22-2020

@dougwilson - I don't have the recording, but if it is something that came from me, I am sorry - I wasn't fully sure about your attendance status, I thought you wanted to take part, but had something that came up unexpectedly. I remember asking who is hosting the meeting and came to know it was you, plus saw your chat messages. Again, did not mean anything tricky, just did not clearly understand your involvement in the meeting. Hope you are ok with this?

dougwilson

comment created time in a month

pull request commentexpressjs/express

Triage Edits

@expressjs/express-tc - can you pls chime in to resolve a difference in opinion here?

Problem: this PR can potentially conflict with the release process (If not landed in time, can leave the doc in an in-coherent state in different branches)

@dougwilson suggested to amend the PR to retain non-dynamic part of the PR.

I disagree on that, and propose to leave the PR and go ahead with release - affected parties are triagers. In today's TC meeting, they were more than happy to delay this till post release.

wesleytodd

comment created time in a month

pull request commentexpressjs/express

Triage Edits

So the risk of delaying the release is by opposing my proposal, in fact...

sorry, I don't agree on that. I re-iterate my opinion: leave this aside and go ahead with release.

wesleytodd

comment created time in a month

pull request commentexpressjs/express

Triage Edits

The statement of that is quite hurtful with all the time I put in to do those exact task and I am very much not inconvenienced to do them.

@dougwilson - I am not a native speaker, no apologies if it cause any hurt to you.

My bottom line is that we don't have enough people to run the project in many critical areas (release is one of those, as you will agree). So let us don't let this task come in way of the release!

wesleytodd

comment created time in a month

pull request commentexpressjs/express

Triage Edits

Can these not run in parallel?

I have several examples of resource constraints in this project, especially on people with commit rights. You are super active, but many times we discussed your constraints too:

  • paid company vs. open source
  • release work vs. non-release work
  • inconvenience to start or run TC
  • inconvenience to attend / initiate agreed upon meetings ...

So I am trying to be super-pragmatic here - weeding out ripples from super-priority items

wesleytodd

comment created time in a month

pull request commentexpressjs/express

Triage Edits

How does the proposal risk delay of the release?

that needs a change to the doc, and needs to undergo a full PR life cycle.

wesleytodd

comment created time in a month

pull request commentexpressjs/express

Triage Edits

I can't start the 4.18 process until we make a decision around this

Please don't let doc reasons to be release blockers. the missing doc can be re-pr'd, if need be.

Your proposal (land static part of the triage section) still has the risk of delaying release. I don't recommend that. Most straightforward and popular thing to do is to move past this and release.

wesleytodd

comment created time in a month

pull request commentexpressjs/express

Triage Edits

there wasn't any discussions on multiple proposals and pros and cons of each. The only conviction we had was that this item should NOT come in between the (5.0) release.

The only reason we quoted is: project (and the release) is important over and above anything.

I don't think anyone read your proposal that was posted 5 minutes prior to the meeting, I may be wrong. I did not.

wesleytodd

comment created time in a month

issue commentexpressjs/discussions

express 5.0.0

https://github.com/pillarjs/router/pull/60 : PR to make router 2.0 . All the checklists are marked, yet not sure what it is waiting for?

https://github.com/expressjs/body-parser/pull/66: PR to release body-parser 2.0: how this is a pre-requisite for query praser change in 5.0?

gireeshpunathil

comment created time in a month

issue commentexpressjs/discussions

express 5.0.0

@dougwilson -

We built up our group quickly, with a sudden focus to release 5.0 as fast as possible, and perhaps we are cutting corners we should not, like fully articulating the plan.

I wouldn't call it sudden - it has been 2 months since this issue is opened, to say the least. And there were several express 5.0 plans in the past as well?

I think perhaps we need to stop the work towards 5.0 at this point and focus on a full plan of all the sub-dependency work across the three orgs that we are holding in our minds so we can get a full picture of what is being done and the plan.

No. Lot of contributors spent a lot of effort to get this out. Let us don't think of any other actions that will delay it any further. I am understanding now that there are several gaps in the documentation, process and other nagging problems that needs collaborative effort to improve upon, but let us don't allow those to derail the current focus and larger goal.

we will need to finish up the feature in the router repo, get the body parser 2.0 out to match the query praser change in 5.0, and get all those deps to be non beta release as well, ...

are there issues / PRs opened for these? or need to start from scratch?

gireeshpunathil

comment created time in a month

issue commentexpressjs/discussions

express 5.0.0

@dougwilson -

In order to jump from alpha to GA, we will need to finish up the feature in the router repo, get the body parser 2.0 out to match the query praser change in 5.0, and get all those deps to be non beta release as well, as a GA express shouldn't have non GA deps.

this is surprising! where do this come from? I have proposed GA 2 months back here https://github.com/expressjs/discussions/issues/100#issuecomment-590185515 and this was not raised!

GA express shouldn't have non GA deps

where is this documented?

we will need to finish up the feature in the router repo, get the body parser 2.0 out to match the query praser change in 5.0, and get all those deps to be non beta release as well, ...

are there issues / PRs opened for these? or need to start from scratch?

gireeshpunathil

comment created time in a month

pull request commentexpressjs/express

Triage Edits

no concerns from anyone in today's TC on handling in whatever way that accelerates the release process. every one feels the project is important, so the list can wait if need be (or even they can re-pr if need be.)

  • so pls exclude this item from the release process
wesleytodd

comment created time in a month

issue commentexpressjs/discussions

express 5.0.0

https://github.com/expressjs/expressjs.com/pull/1131 is landed now, so we are down to 4!

gireeshpunathil

comment created time in a month

issue commentexpressjs/discussions

express 5.0.0

Reduced list after today's TC meeting:

https://github.com/expressjs/express/pull/3621: good to land https://github.com/expressjs/express/pull/4208 : no concerns from anyone on not printing the deprecation. Close and abandon. https://github.com/expressjs/express/pull/4212: needs review and progress https://github.com/expressjs/expressjs.com/pull/1114: post release action https://github.com/expressjs/expressjs.com/pull/1131: needs review and progress

@expressjs/express-tc - please chime in! we are getting closer, and this now needs few landings + the release process!

note 1: there isn't anything major between the last alpha and the current, so I strongly recommend for GA, not a beta.

note 2: the risk of delaying further is that new issues can slip in from unknown corners with potential of delaying and blocking things.

gireeshpunathil

comment created time in a month

issue commentexpressjs/expressjs.com

Outstanding issues with the 5.x api docs

for the context, the only pending item in the list is https://github.com/expressjs/expressjs.com/pull/1131/ really.

One other thing that comes to mind is that we need to make sure all links in Guide and Getting Started point to the 5.x api docs.

I suggest we stick to the original list and not doing this at this point of time - it is not a blocker, and can be done post release as well.

dougwilson

comment created time in a month

pull request commentnodejs/diagnostics

self nomination to diagnostics working group

landed in 3e5766e991fd939bd937aa36f97bb8746b1f1da7

HarshithaKP

comment created time in a month

PR closed nodejs/diagnostics

self nomination to diagnostics working group diag-agenda

I'd like to nominate myself to this working group. I have been attending the last few sessions; and I am interested in its theme and content. I have contributed to the best practices content, and plan to contribute more.

+1 -0

2 comments

1 changed file

HarshithaKP

pr closed time in a month

push eventnodejs/diagnostics

Harshitha KP

commit sha 3e5766e991fd939bd937aa36f97bb8746b1f1da7

doc: self nomination to diagnostics working group I'd like to nominate myself to this working group. I have been attending the last few sessions; and I am interested in its theme and content. I have contributed to the best practices content, and plan to contribute more. PR-URL: https://github.com/nodejs/diagnostics/pull/379 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

push time in a month

issue commentnodejs/diagnostics

General Crash Reporting questions

If any of this could or should be merged into any FAQ-like docs (should we make an FAQ.md doc?) to hep others out, let me know.

Looks like a great idea to me. Shall we discuss this in the WG? (probably needs an issue in itself)

RichardLitt

comment created time in a month

issue commentnodejs/diagnostics

Node.js Diagnostics WorkGroup Meeting 2020-04-22

while few items require just few minutes to discuss, the others could potentially take up the whole time. So many be extending the meeting by half an hour and covering deep dive makes sense?

mhdawson

comment created time in a month

Pull request review commentlibuv/libuv

unix: yield cpu when spinlocking on async handle

 int uv_async_send(uv_async_t* handle) {  /* Only call this from the event loop thread. */ static int uv__async_spin(uv_async_t* handle) {+  int i;   int rc;    for (;;) {-    /* rc=0 -- handle is not pending.-     * rc=1 -- handle is pending, other thread is still working with it.-     * rc=2 -- handle is pending, other thread is done.+    /* 997 is not completely chosen at random. It's a prime number, acyclical+     * by nature, and should therefore hopefully dampen sympathetic resonance.      */

thanks @bnoordhuis for trying it! sorry for any noise I caused on this!

bnoordhuis

comment created time in a month

pull request commentexpressjs/express

query: deprecate extended query parser

thanks @dougwilson ! user experience is extremely valuable, and it proved time and again! I can relate to all what you wrote!! kudos to your team that spent time on this, and provided candid and critical feedback!

I am happy to close this instantly on these grounds:

  • deprecation printed on the most common use cases
  • no obvious location visible to the user to circumvent the deprecation

but may be as you pinged the TC, let us wait for their views as well!

gireeshpunathil

comment created time in a month

Pull request review commentnodejs/node

doc: elevate diagnostic report to tier1

 The tools are currently assigned to Tiers as follows:   | Tool Type | Tool/API Name             | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier |  |-----------|---------------------------|-------------------------------|-------------------------|-------------|- | FFDC      | node-report               | No                            | No                      |     1       |

@richardlau @mhdawson - reverted the case of node-report, PTAL!

gireeshpunathil

comment created time in a month

push eventgireeshpunathil/node

Gireesh Punathil

commit sha 1039e50470263e80d41529acdae6a14982b565d3

fixup: revert node-report tier status

view details

push time in a month

issue commentnodejs/diagnostics

Diagnostics "Best Practices" Guide?

removed from wg meeting agenda, as per discussed in the last meeting (rationale: the work is being progressed as part of uesr journey deep dives and subsequent documentation work. If doc work stalls, we could always re-insert this to gain focus)

mike-kaufman

comment created time in a month

pull request commentnodejs/diagnostics

doc: add minutes for 08 april 2020

landed in 5bba7eea16afdbe2497e04725965a795a435c1be

gireeshpunathil

comment created time in a month

push eventgireeshpunathil/diagnostics

Gireesh Punathil

commit sha 45fe9aa45c00fc612403fad00a247595204f933c

doc: fix a link PR-URL: https://github.com/nodejs/diagnostics/pull/368 Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Gireesh Punathil

commit sha 839245e4f4b6b8c0687864933d85320880e3e03d

doc: add minutes for 25 mar 2020 PR-URL: https://github.com/nodejs/diagnostics/pull/371 Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

view details

Harshitha KP

commit sha 4e8b0bcbc210b09945474e9a6570e4da56aa8fca

doc: explain how to examine `--trace_gc` output PR-URL: https://github.com/nodejs/diagnostics/pull/372 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Gireesh Punathil

commit sha 5bba7eea16afdbe2497e04725965a795a435c1be

doc: add minutes for 08 april 2020 PR-URL: https://github.com/nodejs/diagnostics/pull/377 Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

view details

push time in a month

push eventnodejs/diagnostics

Gireesh Punathil

commit sha 5bba7eea16afdbe2497e04725965a795a435c1be

doc: add minutes for 08 april 2020 PR-URL: https://github.com/nodejs/diagnostics/pull/377 Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

view details

push time in a month

PR closed nodejs/node

test: changed function to arrow function author ready test

Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the this object in places where that was required.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+4 -4

6 comments

1 changed file

nimit95

pr closed time in a month

pull request commentnodejs/node

test: changed function to arrow function

landed in 498628644645d58a9655af71633900dd3ef159cc

nimit95

comment created time in a month

push eventnodejs/node

Nimit

commit sha 498628644645d58a9655af71633900dd3ef159cc

test: changed function to arrow function Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: https://github.com/nodejs/node/pull/32875 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in a month

PR closed nodejs/node

src: elevate v8 namespaces C++ author ready cares

Leverage using semantics for repeated usage of v8 artifacts.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+4 -3

2 comments

2 changed files

nimit95

pr closed time in a month

pull request commentnodejs/node

src: elevate v8 namespaces

landed in e231e1a0d8857c70d6569f39d8d2e5b1955562b5

nimit95

comment created time in a month

push eventnodejs/node

Nimit

commit sha e231e1a0d8857c70d6569f39d8d2e5b1955562b5

src: elevate v8 namespaces elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: https://github.com/nodejs/node/pull/32872 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

push time in a month

more