profile
viewpoint
Gabriel Féron gferon @heremaps Berlin, Germany https://leirbag.net/

boxdot/gerritbot-rs 13

Cisco Teams bot for Gerrit code reviews.

gferon/dockwrap 9

A very simple Docker wrapper written in bash designed to enforce some kind of lifecycle for your containerized app

boxdot/osmflat-rs 3

OpenStreetMap flatdata format and compiler

gferon/am2320.rs 1

Rust AM2320 driver using traits of embedded-hal

boxdot/basic-rs 0

Minimal BASIC interpreter written in Rust

boxdot/cargo 0

The Rust package manager

boxdot/openapi-generator 0

OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)

gferon/adafruit-led-backpack.rs 0

Rust (embedded) driver for the Adafruit LED backpacks

gferon/arguman.org 0

Argument analysis and mapping platform

startedfermeise/flatdata-sublime-syntax

started time in 11 hours

push eventgferon/sony-xperia-kernel

Gabriel Féron

commit sha 0148762ef94d41c613f300fc13f77b10145bc9ad

Enable d2w for loire

view details

push time in 8 days

issue openedheremaps/flatdata

Expose maximum possible value for primitive types in generated code

While playing with flatdata, I realized that if you encode a primitive field with a custom size like so:

struct Attribute {
    value : u32 : 3;
}

then in the generated code, the number of bytes of the field is not exposed anywhere.

This could be useful for example when adding a static_assert in C++ that internal enum values match the size of the field. I suppose in Rust, we could also leverage this for some safer fun!

created time in 10 days

Pull request review commentheremaps/flatdata

Bump versions in preparation of release

 pub fn generate(         path     } else {         eprintln!("installing flatdata-generator from PyPI");-        PathBuf::from("flatdata-generator")+        PathBuf::from("flatdata-generator=0.4")

you want ==0.4.* to be super explicit

VeaaC

comment created time in 10 days

startedfrancescocarlucci/job-offers-http-headers

started time in 11 days

issue commentsonyxperiadev/bug_tracker

Double tap to wake and lift to wake for AOSP

@gferon that's nice to hear, though beware of touch issues after prolonged suspend. If you are certain the feature works well at least for loire devices, please open a PR to enable dt2w for those devices.

well, there's at least one bug where the touchscreen is inactive on first boot. you have to switch the screen off and on once to make it work. I'll try to get to the bottom of it.

ApostolosB

comment created time in 11 days

create barnchgferon/sony-xperia-kernel

branch : loire-tap-to-wake

created branch time in 12 days

create barnchgferon/device-sony-kugo

branch : tap-to-wake

created branch time in 12 days

issue commentsonyxperiadev/bug_tracker

Double tap to wake and lift to wake for AOSP

@ix5 slightly off topic, but I just tried the suggested changes on a build for a Xperia X Compact kugo and it works perfectly fine! Thanks :smile:

ApostolosB

comment created time in 12 days

startedboxdot/abbot-rs

started time in 20 days

pull request commentjonmbake/discourse-ldap-auth

Make LDAP password field secret

It is now! Annotating the field like I did in the commit will make the input field of type password. I have successfully tested it.

gferon

comment created time in 23 days

PR opened jonmbake/discourse-ldap-auth

Make LDAP password field secret

I just realized when installing the plugin that the password field wasn't marked as secret, thus revealing it in the admin panel :open_mouth:

Fortunately, this is a really easy fix!

(Thanks for the plugin, it works perfectly)

+1 -0

0 comment

1 changed file

pr created time in 24 days

push eventgferon/discourse-ldap-auth

Gabriel

commit sha 49bf17406081619e67a6b24ca2520cf358a16860

Make LDAP password field secret

view details

push time in 24 days

push eventgferon/discourse-ldap-auth

Gabriel

commit sha cbedf54a93caa573604061c77c70d0f9fb986ddd

Make LDAP password field secret

view details

push time in 24 days

fork gferon/discourse-ldap-auth

Discourse plugin to enable LDAP/Active Directory authentication.

fork in 24 days

starteddandavison/delta

started time in a month

issue closedUltimaker/Uranium

test_init_bad fails with Python 3.8

Running pytest tests/Settings/TestSettingFunction.py fails on test_init_bad, which I guess means some feature slightly broke with Python 3.8.

======================================================================= test session starts =======================================================================
platform linux -- Python 3.8.2, pytest-4.6.9, py-1.8.0, pluggy-0.13.0
rootdir: /home/gabriel/Development/rpmbuild/BUILD/Uranium-4.6.0, inifile: pytest.ini
collected 35 items                                                                                                                                                

tests/Settings/TestSettingFunction.py .............F.....................                                                                                   [100%]

============================================================================ FAILURES =============================================================================
_____________________________________________________________________ test_init_bad['a_a'[1]] _____________________________________________________________________

setting_function_bad = <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >

    def test_init_bad(setting_function_bad):
        assert setting_function_bad is not None
>       assert not setting_function_bad.isValid()
E       AssertionError: assert not True
E        +  where True = <bound method SettingFunction.isValid of <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >>()
E        +    where <bound method SettingFunction.isValid of <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >> = <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >.isValid

tests/Settings/TestSettingFunction.py:72: AssertionError
=============================================================== 1 failed, 34 passed in 0.06 seconds ===============================================================

closed time in a month

gferon

issue commentUltimaker/Uranium

test_init_bad fails with Python 3.8

Alright, then I can close this issue. Would you still accept a MR that fixes it for Python 3.8?

gferon

comment created time in a month

pull request commentmitsuhiko/redis-rs

Add TLS support, gated by a feature flag

@Marwes could you try to help me figure out what's going on with the test suite? It's most probably linked to my change, but I can't figure it out right now.

gferon

comment created time in a month

issue openedUltimaker/Uranium

test_init_bad fails with Python 3.8

Running pytest tests/Settings/TestSettingFunction.py fails on test_init_bad, which I guess means some feature slightly broke with Python 3.8.

======================================================================= test session starts =======================================================================
platform linux -- Python 3.8.2, pytest-4.6.9, py-1.8.0, pluggy-0.13.0
rootdir: /home/gabriel/Development/rpmbuild/BUILD/Uranium-4.6.0, inifile: pytest.ini
collected 35 items                                                                                                                                                

tests/Settings/TestSettingFunction.py .............F.....................                                                                                   [100%]

============================================================================ FAILURES =============================================================================
_____________________________________________________________________ test_init_bad['a_a'[1]] _____________________________________________________________________

setting_function_bad = <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >

    def test_init_bad(setting_function_bad):
        assert setting_function_bad is not None
>       assert not setting_function_bad.isValid()
E       AssertionError: assert not True
E        +  where True = <bound method SettingFunction.isValid of <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >>()
E        +    where <bound method SettingFunction.isValid of <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >> = <UM.Settings.SettingFunction (0x7f761ac14730) ='a_a'[1] >.isValid

tests/Settings/TestSettingFunction.py:72: AssertionError
=============================================================== 1 failed, 34 passed in 0.06 seconds ===============================================================

created time in a month

issue commentUltimaker/Uranium

Segmentation fault on tests/TaskManagement/TestHttpRequestManager.py::test_getBasicAuthSuccess

I'm trying to package python-uranium w/ cura 4.5 and 4.6 for Fedora, and I'm getting the same segfault. I'm currently trying to investigate but came to the same conclusion as you did @Ghostkeeper (that it should never happen).

ggardet

comment created time in a month

PullRequestEvent

PR closed mitsuhiko/redis-rs

Reviewers
Add TLS support, gated by a feature flag

Following up on my earlier attempt in MR #244.

TODO:

Resolves issue #241

+472 -41

3 comments

11 changed files

gferon

pr closed time in a month

startedgear-genomics/dicey

started time in a month

push eventgferon/marlin-ender3-pro

Gabriel

commit sha 4d9127740f95c43d8e9b30b6837691f1fbe3bbb8

Add initial script

view details

Gabriel

commit sha 1ab0eac2c4b036658dd6063382bf35301b4a1e29

Add git submodules

view details

Gabriel

commit sha 92b51963836d83f4e6cc0da553174d016584f68d

Re-import Ender-3 Pro config * Disable SD card support * Enable nozzle parking and advanced filament change

view details

Gabriel

commit sha eb8f938bdfa41fdaa047b4fb4edb7d7764f1b012

Restore custom boot and status screens

view details

Gabriel

commit sha 465d35c0bf27cccf9748a75cefa41261d729cfe7

Adjust build & flash scripts

view details

Gabriel

commit sha d200f696b65374421599f0ad21de31d1f3618841

Add README

view details

push time in a month

create barnchgferon/marlin-ender3-pro

branch : master

created branch time in a month

created repositorygferon/marlin-ender3-pro

Configuration and build scripts to build Marlin 2.x for my Ender 3-Pro

created time in a month

push eventgferon/redis-rs

Gabriel

commit sha b94207a55fffe5352e7e324d4b39d8605c490202

Make sure stunnel doesn't fork itself

view details

push time in 2 months

push eventgferon/redis-rs

Gabriel

commit sha 87e48f7a0de47289c9faf5b2d1c93ad2a9a20020

Add a way to generate a self-signed cert, spawn stunnel and redis-server when running integration tests

view details

push time in 2 months

startedrust-lang/rust-artwork

started time in 2 months

pull request commentmitsuhiko/redis-rs

Add TLS support, gated by a feature flag

There doesn't seem to be a place where features are documented atm (though it would be nice, problably in the top level docs in src/lib.rs).

Adding some/a test for TLS, even without certificate validation would be useful.

Alright, I'll figure something out later then.

gferon

comment created time in 2 months

pull request commentmitsuhiko/redis-rs

Add TLS support, gated by a feature flag

@Marwes I guess I should also add something in the documentation about the new feature flag?

gferon

comment created time in 2 months

Pull request review commentmitsuhiko/redis-rs

Add TLS support, gated by a feature flag

 impl IntoConnectionInfo for String { }  fn url_to_tcp_connection_info(url: url::Url) -> RedisResult<ConnectionInfo> {+    let host = match url.host() {+        Some(host) => host.to_string(),+        None => fail!((ErrorKind::InvalidClientConfig, "Missing hostname")),+    };+    let port = url.port().unwrap_or(DEFAULT_PORT);+    let addr = if url.scheme() == "redis+tls" {+        #[cfg(feature = "tls")]+        {+            if url.fragment() == Some("insecure") {

@Marwes I guess I should also add something in the documentation about the new feature flag?

gferon

comment created time in 2 months

push eventgferon/redis-rs

Gabriel

commit sha 789b3086e9492f9a6ae36f3118d63f61641e4e3c

Address review comments

view details

push time in 2 months

Pull request review commentmitsuhiko/redis-rs

Add TLS support, gated by a feature flag

 impl IntoConnectionInfo for String { }  fn url_to_tcp_connection_info(url: url::Url) -> RedisResult<ConnectionInfo> {+    let host = match url.host() {+        Some(host) => host.to_string(),+        None => fail!((ErrorKind::InvalidClientConfig, "Missing hostname")),+    };+    let port = url.port().unwrap_or(DEFAULT_PORT);+    let addr = if url.scheme() == "redis+tls" {+        #[cfg(feature = "tls")]+        {+            if url.fragment() == Some("insecure") {

Should any fragment other than insecure and None be an error?

I guess it makes sense, I just pushed a new commit to address both of your comments.

gferon

comment created time in 2 months

push eventgferon/redis-rs

Gabriel

commit sha 05b86cb0baf3e50ce03a90e2881df653e945b63c

Add support to async-native-tls

view details

push time in 2 months

push eventgferon/redis-rs

Gabriel

commit sha 3ecbaab1a3f43780a3a2c4a6b4e837914ffc2ddb

Fix unrelated clippy error

view details

push time in 2 months

push eventgferon/redis-rs

Gabriel

commit sha 924170d164edd969453c7772b9ff18220f62505d

Fix unrelated clippy error

view details

push time in 2 months

push eventgferon/redis-rs

Gabriel

commit sha 0d22d093b815e97d8051dae65cee3dbdae14de35

Propagate errors when instantiating TlsConnector

view details

push time in 2 months

PR opened mitsuhiko/redis-rs

Add TLS support, gated by a feature flag

Finally following up from my earlier attempt in MR #244.

Open questions (I can definitely work on all of these):

  • [ ] : Implement support for async-std (should be straightforward, as it should mostly be fiddling with feature names in Cargo.toml) and writing a little bit of code
  • [ ] : Should a way to run automated tests with TLS (either with redis 6.0 or stunnel) be implemented

Sorry for the delay!

Resolves issue #241

+280 -20

0 comment

7 changed files

pr created time in 2 months

push eventgferon/redis-rs

Sam Stelfox

commit sha 3318c0334ddaeb9482b2004e01cf5660659e49d7

fix the command verb being sent to redis for zremrangebyrank

view details

Omid Ghaffarinia

commit sha 2009c816cf699bd82036cf30c4a6f1e9efe3b77f

Add get_connection_with_timeout to Client

view details

Lachezar Lechev

commit sha 5c70d754cfb5c571149248658f407b25e22531db

Small typo fix for async module name

view details

Jan-Erik Rediger

commit sha 24a2a7448f3a2918be732eb27e280237f5a54764

Small typo fix for async module name (#247) Small typo fix for async module name

view details

Markus Westerlind

commit sha 0b314e2cb22fdc0f543c60cdcf89b93faceabbbc

feat: Add Cmd::set, Cmd::get etc It is currently possible to call `set`,`get` etc on a connection and run the query directly but it isn't possible to create a `Cmd` struct without running the query (except for `Pipeline`). This adds this capability with just some small tweaks to the macro allowing `Cmd::set("abc", 123)` to be used etc.

view details

Markus Westerlind

commit sha b01456e60a70aa48a79babcfff4f55dbea353228

feat: Remove the redundant PipelineCommands trait A simple `impl Pipeline` block will do the trick here. BREAKING CHANGE Remove any imports of PipelineCommands

view details

Nate Mara

commit sha f7a63929ab8a48d95713de0efda325f5d703d5e6

Do not require transaction to use FromRedisValue `redis::transaction` takes a closure that returns a value, and it returns that value itself if the value is Option::Some. There is no use of FromRedisValue in `transaction`, so it's not clear why this trait bound is required. It seems perfectly valid to return something that will never be serialized/deserialized with redis, such as a struct containing metrics about the statements run in the transaction.

view details

Markus Westerlind

commit sha 5a55b565b46dc52f8a0f49d57d5bed944cc2f5c9

Merge pull request #255 from nate-onesignal/patch-1 Do not require transaction to use FromRedisValue

view details

Jan-Erik Rediger

commit sha c0f3b8eacc40bc59a7bc61ff7211436fac598c46

Add get_connection_with_timeout to Client (#243) Add get_connection_with_timeout to Client

view details

Jan-Erik Rediger

commit sha 550a0b1e81511b2b15285d755d3a9f46d061b19d

Fix the command verb being sent to redis for zremrangebyrank (#240) Fix the command verb being sent to redis for zremrangebyrank

view details

Jan-Erik Rediger

commit sha e78d371ae3283848eb299656a0b1f368d60e58a3

Rename the command to match its Redis command **BREAKING CHANGE**: This renames the function. Old: ```rust connection.zrembyrank(0, 2); ``` New: ```rust connection.zremrangebyrank(0, 2); ```

view details

Jan-Erik Rediger

commit sha 93b5b506d09676a4b39f860026681349f50e67d2

Add Cmd::get, Cmd::set and remove PipelineCommands (#253) Add Cmd::get, Cmd::set and remove PipelineCommands

view details

Markus Westerlind

commit sha 5e3f3e5a4384419bbde684a5c71a81d5bf33dc69

feat: Update to std::future::Future

view details

Markus Westerlind

commit sha 1562fe2709c7f1ce342fc1bb27350a36d00ae603

Async-ify the API With async/await we can take references in the async api and clones and moves in many cases.

view details

Markus Westerlind

commit sha 99cc73915fafa4c3a7ffe23201364e676f611b3b

refactor: Avoid using async fn so `&self` does not get captured Avoids https://github.com/rust-lang/rust/issues/63778

view details

Markus Westerlind

commit sha a5c729a0a63993ecdf2abf14b3a9bc36741a90de

Fix async tests

view details

Markus Westerlind

commit sha bfadb8a417dc01a613d8702daae03024cfb7d66e

Allow commands to be written to io::Write

view details

Markus Westerlind

commit sha bdd68dbd9ba5319b0e7bfe09f9b1fe8040b93cd7

Update benchmarks

view details

Markus Westerlind

commit sha 352545fde94eb7a75041e6bb84390fbe7dbdc986

Fix write

view details

Markus Westerlind

commit sha 34b16af5f82bcf8ea01bc74814abf454ef6073e4

Pass Cmd to the ConnectionLike trait

view details

push time in 2 months

issue commentmitsuhiko/redis-rs

TLS support

Actually sounds like a great side-project, I'll get back at it today! I'm happy to collaborate with you @ajmwagar if you want.

gferon

comment created time in 2 months

issue commentMCUdude/MightyCore

Error during build: fork/exec /bin/avr-g++: no such file or directory

It looks like you just need to install arduino:avr as well. Well, at least it worked for me.

rejoys-servify

comment created time in 2 months

push eventgferon/dotfiles

Gabriel Féron

commit sha 2ba306806c7464c8df6066ea32f093083569cad6

Switch to using zlogin .zshrc and .zprofile should stay customizable

view details

Gabriel Féron

commit sha dfb6cc4b58af3b8bc047e5e72bc62ac7ad1e337d

Merge branch 'master' of github.com:gferon/dotfiles

view details

push time in 2 months

push eventgferon/dotfiles

Gabriel Féron

commit sha 873d7454d9f24c97238f753d1e4ba436974152df

Update README.md

view details

push time in 2 months

push eventgferon/dotfiles

Gabriel Féron

commit sha 289d9d550e05e3c74127b5601b8937bfbbee29ca

Update README.md

view details

push time in 2 months

push eventgferon/dotfiles

Gabriel Féron

commit sha a62db04bb7911ee0ef4223efd675135b1daae3cc

Use alacritty from path and add headphones to status bar

view details

push time in 2 months

push eventgferon/dotfiles

Gabriel

commit sha 9429755ff6ff55d169febef5816665625925f3f7

Switch back to alacritty

view details

Gabriel

commit sha 61952b51b4df3f94dd5fd780fd991ab4aafba439

Add zprofile for gnome-keyring-daemon

view details

Gabriel

commit sha b2d3254ba1b1918a96e8f391584af19406484441

Add mako

view details

Gabriel

commit sha c502175632c7236c0b13c29406ca4215133cd7f8

More goodies

view details

Gabriel

commit sha f6537b00e83e232205de862b512c6629f1cf255a

Moar

view details

push time in 3 months

push eventgferon/dotfiles

Gabriel Féron

commit sha 729cfa5ba78e59aafeb5fce760a6f64ac8f3a93c

Initial import of sway config

view details

push time in 3 months

more