profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/gep13/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Gary Ewan Park gep13 @chocolatey Aberdeen, UK https://www.gep13.co.uk/blog Senior Software Engineer at @chocolatey

emmabostian/developer-portfolios 2755

A list of developer portfolios for your inspiration

daveaglick/discoverdotnet 256

A web site that helps you discover awesome .NET open source and community resources

ferventcoder/chocolatey-packages 111

The packages...all about the packages.

chocolatey/chocolatey-workshop 76

Chocolatey Workshop

dtgm/chocolatey-packages 42

chocolateynuget packages published on chocolatey.org

cake-contrib/Cake.Terraform 11

Terraform Addin for Cake.

cake-contrib/Cake.AWS.ElasticBeanstalk 2

Cake addin that extends Cake with AWS Elasticbeanstalk extensions

pull request commentchocolatey/choco

(#2398) Restore PowerShell v2 support

@corbob thanks for greeting this fixed!

corbob

comment created time in 7 hours

push eventchocolatey/choco

corbob

commit sha 375ad53d17fcfba7c78ee4bfba7fd55f71c84fca

(#2398) Restore PowerShell v2 support PowerShell v2 doesn't recognize `-notin` as it was introduced in v3. This changes to use `-notcontains` which was introduced in v2 and works similar to `-notin`.

view details

Gary Ewan Park

commit sha 9cc24197cf415b7b3b896328d55b02a8cdebc056

Merge pull request #2411 from corbob/2398_PS2_support

view details

push time in 7 hours

PR merged chocolatey/choco

Reviewers
(#2398) Restore PowerShell v2 support

Description Of Changes

Commit c408d1299b6f5f7e3e285d17f9e2d1719dfac122 introduced a change to fix a bug with the $env:TEMP variable. As well, commit f68a242245defa7f9dc9189f1350f5ca6e6e922b introduced handling of msps in the install helper.

However, they both introduced PowerShell 3+ syntax. This changes those to work with PowerShell 2+.

Motivation and Context

We currently support PowerShell 2+, so it's important that the PowerShell uses v2 compatible commands.

What Have I Done To Test This

This one is specific to PowerShell 2 and the import of the helpers\chocolateyInstaller.psm1. It can be tested either on a Windows 7 with PowerShell 2 system (this is a multi-hour waiting game to build and update a system if you don't already have one), or on a newer Windows system with the PowerShell 2 compatibility feature enabled by running powershell -version 2.

From PowerShell 2 run: Import-Module src\chocolatey.resources\helpers\chocolateyInstaller.psm1 -force from the root of the repository. This should result in no errors and no output.

Change Types Made

  • [x] Bug fix (non-breaking change)
  • [ ] Feature / Enhancement (non-breaking change)
  • [ ] Breaking change (fix or feature that could cause existing functionality to change)

Related Issue

Fix #2398

Change Checklist

  • [ ] Requires a change to the documentation
  • [ ] Documentation has been updated
  • [ ] Tests to cover my changes, have been added
  • [x] All new and existing tests passed.
+2 -2

7 comments

2 changed files

corbob

pr closed time in 7 hours

PullRequestReviewEvent

pull request commentchocolatey/choco

(#2398) Restore PowerShell v2 support

Based on this:

https://iannotes.wordpress.com/2011/12/25/powershell-comparison-operators/

They are equivalent, but it would be better to have them the same, right?

corbob

comment created time in 9 hours

pull request commentchocolatey/choco

(#2398) Restore PowerShell v2 support

@vexx32 that is a great question!

corbob

comment created time in 9 hours

PullRequestReviewEvent

push eventcorbob/choco

AdmiringWorm

commit sha a9b0ea9ddf56dad03d8bc3e5985839d9d0304146

(#2412) Switch to output warning on failure This commit updates the chocolateyInstaller module to not output an error when failing to load the Chocolatey Licensed Extension which would prevent all helper cmdlets in FOSS being exported. Instead the importing have been wrapped inside a try/catch block and writes out a Warning that includes the reason the importing failed.

view details

Gary Ewan Park

commit sha 708a860809c174d768ff5b31070e7cfd2cafd1d1

Merge pull request #2414 from AdmiringWorm/2412-Faling-to-load-all-helper-cmdlets-when-extensions-fails-to-load (#2412) Change importing of Licensed extension to output warning

view details

corbob

commit sha 486192a28c435a29b06d9fb28f43dffb770ebbe3

(#2398) Restore PowerShell v2 support PowerShell v2 doesn't recognize `-notin` as it was introduced in v3. This changes to use `-notcontains` which was introduced in v2 and works similar to `-notin`.

view details

push time in 10 hours

issue closedchocolatey/choco

Faling to load all helper cmdlets when extensions fails to load

What You Are Seeing?

When the Chocolatey Licensed extension fails to load some of the expected helper cmdlets won't be available due to the importing being aborted before everything is processed. This also affects when normal extensions are imported if they fail to be imported in some way. This especially affects users of the AU extension which makes a monkey patch of the cmdlets to make maintenance easier for the user, in which case the Licensed extension can not be loaded.

What is Expected?

All cmdlets available in open source Chocolatey should be loaded even in the case where an extension is failing to load, even if that extension is the Licensed edition of Chocolatey. Before Chocolatey 0.11.0 failing to import any extension with a DLL extension would report a Warning, but continue execution. After 0.11.1 this has been changed to an error, and is preventing the execution of the module loading.

How Did You Get This To Happen? (Steps to Reproduce)

  1. Have Chocolatey 0.11.1+ and a supported Licensed extension installed.
  2. Create a new package that uses the Get-ChocolateyWebFile cmdlet.
  3. Create an AU update script for updating the package.
  4. Ensure the monkey patched scripts are first removed (Remove-Item $env:TEMP\chocolatey\au
  5. Force a package update using the created AU update script.

Output Log

<details> <summary>Chocolatey Log</summary>

<p>

No log file available

</p>

</details>

<details> <summary>AU Log</summary>

<p>

Console:

Updating 1 automatic packages at 2021-10-21 12:54:36 (forced)
Push is disabled
NoCheckChocoVersion is disabled
FORCE IS ENABLED. All packages will be updated
   [1/1] veeam-one-iso ERROR:
     The term 'Get-ChocolateyWebFile' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. (3,77s)

</p>

<p>

Log File:

veeam-one-iso - checking updates using au version 2021.7.18

URL check
  https://download2.veeam.com/VONE/v11/VeeamONE_11.0.1.1880_20210922.iso
nuspec version: 11.0.1.1880
remote version: 11.0.1.1880
No new version found, but update is forced
New version is available
Automatic checksum started

</p>

</details>

<details> <summary>Manual Import</summary>

<p>

> import-module $env:ChocolateyInstall\helpers\chocolateyInstaller.psm1
Import-Module : Could not load file or assembly 'chocolatey, Version=0.10.15.0, Culture=neutral, PublicKeyToken=79d02ea
9cad655eb' or one of its dependencies. Systemet finner ikke angitt fil.
At C:\ProgramData\chocolatey\helpers\chocolateyInstaller.psm1:76 char:13
+             Import-Module $licensedExtensionPath
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Import-Module], FileNotFoundException
    + FullyQualifiedErrorId : System.IO.FileNotFoundException,Microsoft.PowerShell.Commands.ImportModuleCommand

</p>

</details>

closed time in 10 hours

AdmiringWorm

pull request commentchocolatey/choco

(#2412) Change importing of Licensed extension to output warning

@AdmiringWorm thank you for getting this fixed up!

AdmiringWorm

comment created time in 10 hours

push eventchocolatey/choco

AdmiringWorm

commit sha a9b0ea9ddf56dad03d8bc3e5985839d9d0304146

(#2412) Switch to output warning on failure This commit updates the chocolateyInstaller module to not output an error when failing to load the Chocolatey Licensed Extension which would prevent all helper cmdlets in FOSS being exported. Instead the importing have been wrapped inside a try/catch block and writes out a Warning that includes the reason the importing failed.

view details

Gary Ewan Park

commit sha 708a860809c174d768ff5b31070e7cfd2cafd1d1

Merge pull request #2414 from AdmiringWorm/2412-Faling-to-load-all-helper-cmdlets-when-extensions-fails-to-load (#2412) Change importing of Licensed extension to output warning

view details

push time in 10 hours

PR merged chocolatey/choco

(#2412) Change importing of Licensed extension to output warning

Description Of Changes

Version 0.11.1 introduced changes to how the Chocolatey Licensed Extension was loaded, and changed any failures of loading the extension away from being a warning to be a Error instead.

This pull request updates the importing to instead re-introduce the failure as a warning by wrapping the imports inside a try/catch block instead.

Motivation and Context

To revert a breaking change that had been introduced in v0.11.1, and to keep it backwards compatible.

What Have I Done To Test This

This have been tested with following scenarios in mind.

  1. Manual importing of the chocolateyInstaller.psm1 script, which did not use to write out an error.
  2. Create a AU package, or import an existing one that uses Get-ChocolateyWebFile, and make sure any monkey patch is not already available. Try updating the package.
  3. Load in an extension version we are sure that will fail to load (like loading official licensed extension, into an unofficial Chocolatey build).

Change Types Made

  • [x] Bug fix (non-breaking change)
  • [ ] Feature / Enhancement (non-breaking change)
  • [ ] Breaking change (fix or feature that could cause existing functionality to change)

Related Issue

fixes #2412

Change Checklist

  • [ ] Requires a change to the documentation
  • [ ] Documentation has been updated
  • [ ] Tests to cover my changes, have been added
  • [x] All new and existing tests passed.
+17 -11

0 comment

1 changed file

AdmiringWorm

pr closed time in 10 hours

PullRequestReviewEvent

push eventAdmiringWorm/choco

AdmiringWorm

commit sha a9b0ea9ddf56dad03d8bc3e5985839d9d0304146

(#2412) Switch to output warning on failure This commit updates the chocolateyInstaller module to not output an error when failing to load the Chocolatey Licensed Extension which would prevent all helper cmdlets in FOSS being exported. Instead the importing have been wrapped inside a try/catch block and writes out a Warning that includes the reason the importing failed.

view details

push time in 10 hours

push eventAdmiringWorm/choco

AdmiringWorm

commit sha 15a55aa8461f9c00ff6804a766e90e8bf330cbf9

(#2412) Change importing of Licensed extension to output warning This commit updates the chocoalteyInstaller module to not output an error when failing to load the Chocolatey Licensed Extension which would prevent all helper cmdlets in FOSS being exported. Instead the importing have been wrapped inside a try/catch block and writes out a Warning that includes the reason the importing failed.

view details

push time in 10 hours

create barnchchocolatey/choco

branch : hotfix/0.11.3

created branch time in 10 hours

push eventchocolatey-community/chocolatey-templates

AdmiringWorm

commit sha 77e851e5196b4683b23a762097ce3d3ef4ce53a5

(#10) Add basic build script to use in automation

view details

AdmiringWorm

commit sha 1043bc92abca7c84192283a595b94b0bfe523ea6

(#10) Add github workflow to build and test packages

view details

Gary Ewan Park

commit sha 02d418fa35915ea6361084f601f6a36fcf97456e

Merge pull request #12 from AdmiringWorm/features/GH-10

view details

push time in 2 days

issue closedchocolatey-community/chocolatey-templates

Add automation to tests changes on pull requests

Add a GitHub action that builds, installs and tests available templates in the repository.

This action should run on every pull request and commit.

Steps that are action needs to do.

  1. Build all template packages in the repository
  2. Install all built packages
  3. Run all Pester Unit Tests
  4. Report status on the pull request

closed time in 2 days

AdmiringWorm

PR merged chocolatey-community/chocolatey-templates

(#10) Add automation for testing pull requests

This pull request adds a new build script that can be used to build, install and test packages as well as adding a new workflow file that makes use of this file directly.

No logic for commenting on pull requests have been added, but should be enough to set the workflow as required on pull requests.

fixes #10

+96 -0

0 comment

2 changed files

AdmiringWorm

pr closed time in 2 days

PullRequestReviewEvent

issue closedchocolatey/choco

nuspec created by "choco new" command contains UTF-8 BOM

This violates a recommendation here: https://github.com/chocolatey/choco/wiki/CreatePackages#character-encoding

closed time in 3 days

qzo

issue commentchocolatey/choco

nuspec created by "choco new" command contains UTF-8 BOM

@TheCakeIsNaOH agreed. Will close this as a duplicate.

qzo

comment created time in 3 days

pull request commentchocolatey-community/chocolatey-templates

(#3) Move vscode.template source files to repository

@AdmiringWorm thanks for getting this moved over to this repository!

AdmiringWorm

comment created time in 3 days

push eventchocolatey-community/chocolatey-templates

AdmiringWorm

commit sha fb9390cff14a40318720f62b74bacad2597ace04

(maint) Add very basic git ignore file This file have been added to ignore any nuget packages created, and build output directory.

view details

AdmiringWorm

commit sha 470893c9a62ace598336935921a99c2ce320523c

(#3) Move source files for vscode.template package to repo This move also updates the template with new urls, and some additional fixes.

view details

AdmiringWorm

commit sha e710fc26dc06f77fa67b6fa8ae356f43e4bbd4aa

(#3) Add pester tests for new vscode template

view details

Gary Ewan Park

commit sha 4921f6c58daf9b296bd5a678d9e194297548bfa3

Merge pull request #8 from AdmiringWorm/features/GH-3

view details

push time in 3 days

PR merged chocolatey-community/chocolatey-templates

(#3) Move vscode.template source files to repository

This pull request moves the existing vscode.template file to this repository, together with Pester tests that can be used to verify new packages using this template are created as we expect.

Additionally a basic .gitignore file is added to make sure that any .nupkg files are ignore, and that the _output directory used by the tests is not committed.

fixes #3

+269 -0

0 comment

7 changed files

AdmiringWorm

pr closed time in 3 days

issue closedchocolatey-community/chocolatey-templates

Move source files for vscode.template package into this repository

The package can be found here:

https://community.chocolatey.org/packages/vscode.template

Once complete, we can remove the source files from this repository:

https://github.com/AdmiringWorm/chocolatey-packages

/cc @AdmiringWorm

closed time in 3 days

gep13
PullRequestReviewEvent

push eventgep13-talks/OssTalk

Gary Ewan Park

commit sha 15a0b77c728b6bc183a75d93ec46fb0e1d698eba

Tweaking slides ahead of presentation

view details

Gary Ewan Park

commit sha cddb04c05dc1f0abf035e47cf405ceec204ca760

Merge branch 'master' of https://github.com/gep13-talks/OssTalk * 'master' of https://github.com/gep13-talks/OssTalk: Update abstract.md

view details

push time in 3 days

pull request commentchocolatey-community/chocolatey-package-requests

Fix a couple of typos

@flcdrg thanks for fixing those up!

flcdrg

comment created time in 4 days

push eventchocolatey-community/chocolatey-package-requests

David Gardiner

commit sha b2d9dc9b8200b2e1e770bf6f7452252150b73d43

Fix a couple of typos

view details

Gary Ewan Park

commit sha cb18c4e8cd297e88c2ecbd97d7bf6e82354399fb

Merge pull request #1076 from flcdrg/flcdrg-patch-1 Fix a couple of typos

view details

push time in 4 days