profile
viewpoint

marvelapp/paper.js 2

The Swiss Army Knife of Vector Graphics Scripting – Scriptographer ported to JavaScript and the browser, using HTML5 Canvas. Created by @lehni & @puckey

georeith/AOC 1

My AOC 2019 solutions

chriscartlidge/MediaHub 0

A repository to store media related files, mainly audio & video with meta data around them.

georeith/bantamcss 0

Highly reusable and performant CSS framework for scalable front-end development.

georeith/berry-609 0

Reproduces https://github.com/yarnpkg/berry/issues/609

georeith/canvas-engines-comparison 0

Performance comparison of PixiJS, Two.js and Paper.js

georeith/eslint 0

A fully pluggable tool for identifying and reporting on patterns in JavaScript

georeith/lint-staged 0

🚫💩 — Run linters on git staged files

georeith/lisk-nano 0

💻 Lisk Nano, a minimal feature client

issue closedemscripten-core/emscripten

em++ deleting port cache on every run

Running emc++ with the following config:

/root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/em++
    -O0 --js-opts 0 -s DEMANGLE_SUPPORT=1 -s ASSERTIONS=1 -s GL_ASSERTIONS=1 -g4 -DSK_DEBUG -s DISABLE_EXCEPTION_CATCHING=0 --source-map-base ./
    src/*.cpp
    -DSK_DISABLE_AAA
    -DSK_FORCE_8_BYTE_ALIGNMENT
    -lEGL -lGLESv2 -DSK_SUPPORT_GPU=1 -DSK_GL           -DSK_DISABLE_LEGACY_SHADERCONTEXT           -s USE_WEBGL2=1
    -std=c++17
    --bind
    --pre-js src/pre.js
    /root/design-wasm-renderer/third_party/skia/out/debug/libskshaper.a
    /root/design-wasm-renderer/third_party/skia/out/debug/libskia.a
    -s ALLOW_MEMORY_GROWTH=1
    -s INITIAL_MEMORY=128MB
    -s NO_EXIT_RUNTIME=1
    -s STRICT=1
    -s WARN_UNALIGNED=1
    -s WASM=1
    -s USE_BOOST_HEADERS=1
    -I /root/design-wasm-renderer/third_party/skia
    -I /root/design-wasm-renderer/include
    -o out/dwr.js

Everytime I run this it deletes the boost port and recompiles it:

Creating WASM
system_libs:INFO: retrieving port: boost_headers from https://github.com/emscripten-ports/boost/releases/download/boost-1.70.0/boost-headers-1.70.0.zip
system_libs:INFO: unpacking port: boost_headers
root:INFO: Cache: deleting cached file: /root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/cache/wasm/libboost_headers.a
cache:INFO: generating port: libboost_headers.a... (this will be cached in "/root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/cache/wasm/libboost_headers.a" for subsequent builds)
root:INFO: building port: boost_headers

This has only started happening after I had to delete my docker image and reinstall emscripten via emsdk.

closed time in 3 days

georeith

issue commentemscripten-core/emscripten

em++ deleting port cache on every run

This seems to be resolved by installing emsdk and image creation time and activating it then. I'm guessing something to do with the .emscripten and .emscripten_sanity_wasm last modified times?

georeith

comment created time in 3 days

issue closedemscripten-core/emsdk

em++ deleting port cache on every run

Running emc++ with the following config:

/root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/em++
    -O0 --js-opts 0 -s DEMANGLE_SUPPORT=1 -s ASSERTIONS=1 -s GL_ASSERTIONS=1 -g4 -DSK_DEBUG -s DISABLE_EXCEPTION_CATCHING=0 --source-map-base ./
    src/*.cpp
    -DSK_DISABLE_AAA
    -DSK_FORCE_8_BYTE_ALIGNMENT
    -lEGL -lGLESv2 -DSK_SUPPORT_GPU=1 -DSK_GL           -DSK_DISABLE_LEGACY_SHADERCONTEXT           -s USE_WEBGL2=1
    -std=c++17
    --bind
    --pre-js src/pre.js
    /root/design-wasm-renderer/third_party/skia/out/debug/libskshaper.a
    /root/design-wasm-renderer/third_party/skia/out/debug/libskia.a
    -s ALLOW_MEMORY_GROWTH=1
    -s INITIAL_MEMORY=128MB
    -s NO_EXIT_RUNTIME=1
    -s STRICT=1
    -s WARN_UNALIGNED=1
    -s WASM=1
    -s USE_BOOST_HEADERS=1
    -I /root/design-wasm-renderer/third_party/skia
    -I /root/design-wasm-renderer/include
    -o out/dwr.js

Everytime I run this it deletes the boost port and recompiles it:

Creating WASM
system_libs:INFO: retrieving port: boost_headers from https://github.com/emscripten-ports/boost/releases/download/boost-1.70.0/boost-headers-1.70.0.zip
system_libs:INFO: unpacking port: boost_headers
root:INFO: Cache: deleting cached file: /root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/cache/wasm/libboost_headers.a
cache:INFO: generating port: libboost_headers.a... (this will be cached in "/root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/cache/wasm/libboost_headers.a" for subsequent builds)
root:INFO: building port: boost_headers

This has only started happening after I had to delete my docker image and reinstall emscripten via emsdk.

closed time in 3 days

georeith

issue commentemscripten-core/emsdk

em++ deleting port cache on every run

I made this in the wrong repo, moved to: https://github.com/emscripten-core/emscripten/issues/11595

georeith

comment created time in 3 days

issue openedemscripten-core/emscripten

em++ deleting port cache on every run

Running emc++ with the following config:

/root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/em++
    -O0 --js-opts 0 -s DEMANGLE_SUPPORT=1 -s ASSERTIONS=1 -s GL_ASSERTIONS=1 -g4 -DSK_DEBUG -s DISABLE_EXCEPTION_CATCHING=0 --source-map-base ./
    src/*.cpp
    -DSK_DISABLE_AAA
    -DSK_FORCE_8_BYTE_ALIGNMENT
    -lEGL -lGLESv2 -DSK_SUPPORT_GPU=1 -DSK_GL           -DSK_DISABLE_LEGACY_SHADERCONTEXT           -s USE_WEBGL2=1
    -std=c++17
    --bind
    --pre-js src/pre.js
    /root/design-wasm-renderer/third_party/skia/out/debug/libskshaper.a
    /root/design-wasm-renderer/third_party/skia/out/debug/libskia.a
    -s ALLOW_MEMORY_GROWTH=1
    -s INITIAL_MEMORY=128MB
    -s NO_EXIT_RUNTIME=1
    -s STRICT=1
    -s WARN_UNALIGNED=1
    -s WASM=1
    -s USE_BOOST_HEADERS=1
    -I /root/design-wasm-renderer/third_party/skia
    -I /root/design-wasm-renderer/include
    -o out/dwr.js

Everytime I run this it deletes the boost port and recompiles it:

Creating WASM
system_libs:INFO: retrieving port: boost_headers from https://github.com/emscripten-ports/boost/releases/download/boost-1.70.0/boost-headers-1.70.0.zip
system_libs:INFO: unpacking port: boost_headers
root:INFO: Cache: deleting cached file: /root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/cache/wasm/libboost_headers.a
cache:INFO: generating port: libboost_headers.a... (this will be cached in "/root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/cache/wasm/libboost_headers.a" for subsequent builds)
root:INFO: building port: boost_headers

This has only started happening after I had to delete my docker image and reinstall emscripten via emsdk.

created time in 3 days

issue openedemscripten-core/emsdk

em++ deleting port cache on every run

Running emc++ with the following config:

/root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/em++
    -O0 --js-opts 0 -s DEMANGLE_SUPPORT=1 -s ASSERTIONS=1 -s GL_ASSERTIONS=1 -g4 -DSK_DEBUG -s DISABLE_EXCEPTION_CATCHING=0 --source-map-base ./
    src/*.cpp
    -DSK_DISABLE_AAA
    -DSK_FORCE_8_BYTE_ALIGNMENT
    -lEGL -lGLESv2 -DSK_SUPPORT_GPU=1 -DSK_GL           -DSK_DISABLE_LEGACY_SHADERCONTEXT           -s USE_WEBGL2=1
    -std=c++17
    --bind
    --pre-js src/pre.js
    /root/design-wasm-renderer/third_party/skia/out/debug/libskshaper.a
    /root/design-wasm-renderer/third_party/skia/out/debug/libskia.a
    -s ALLOW_MEMORY_GROWTH=1
    -s INITIAL_MEMORY=128MB
    -s NO_EXIT_RUNTIME=1
    -s STRICT=1
    -s WARN_UNALIGNED=1
    -s WASM=1
    -s USE_BOOST_HEADERS=1
    -I /root/design-wasm-renderer/third_party/skia
    -I /root/design-wasm-renderer/include
    -o out/dwr.js

Everytime I run this it deletes the boost port and recompiles it:

Creating WASM
system_libs:INFO: retrieving port: boost_headers from https://github.com/emscripten-ports/boost/releases/download/boost-1.70.0/boost-headers-1.70.0.zip
system_libs:INFO: unpacking port: boost_headers
root:INFO: Cache: deleting cached file: /root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/cache/wasm/libboost_headers.a
cache:INFO: generating port: libboost_headers.a... (this will be cached in "/root/design-wasm-renderer/third_party/emsdk/upstream/emscripten/cache/wasm/libboost_headers.a" for subsequent builds)
root:INFO: building port: boost_headers

created time in 3 days

issue closedmicrosoft/vscode-cpptools

using boost/multi_index error: sequenced is not a template

Type: LanguageService <!----- Input information below ----->

<!-- Prior to filing an issue, please review:

  • Existing issues at https://github.com/Microsoft/vscode-cpptools/issues
  • Our documentation at https://code.visualstudio.com/docs/languages/cpp
  • FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp -->

Describe the bug

Incorrect error squiggle when trying to create a boost::multi_index_container with a sequenced index.

  • OS and Version: Mac OS 10.15.5
  • VS Code Version: 1.46.1
  • C/C++ Extension Version: 0.29.0-insiders
  • Other extensions you installed (and if the issue persists after disabling them):
  • Does this issue involve using SSH remote to run the extension on a remote machine?:
  • A clear and concise description of what the bug is, including information about the workspace (i.e. is the workspace a single project or multiple projects, size of the project, etc).

Steps to reproduce

#include <boost/multi_index_container.hpp>
#include <boost/multi_index/sequenced_index.hpp>

using namespace boost::multi_index;

typedef multi_index_container<
    int,
    indexed_by<
        sequenced<>
    >>
    multi;

Expected behavior <!-- A clear and concise description of what you expected to happen. -->

Should not show an error squiggle

Screenshots

image

closed time in 9 days

georeith

issue commentmicrosoft/vscode-cpptools

using boost/multi_index error: sequenced is not a template

@sean-mcmanus my bad it was a difference in boost version in my compilation environment and my editing environment. (1.56 vs 1.72) Thanks for looking into this.

georeith

comment created time in 9 days

issue openedmicrosoft/vscode-cpptools

sequenced<> is not a template

Type: LanguageService <!----- Input information below ----->

<!-- Prior to filing an issue, please review:

  • Existing issues at https://github.com/Microsoft/vscode-cpptools/issues
  • Our documentation at https://code.visualstudio.com/docs/languages/cpp
  • FAQs at https://code.visualstudio.com/docs/cpp/faq-cpp -->

Describe the bug

Incorrect error squiggle when trying to create a boost::multi_index_container with a sequenced index.

  • OS and Version: Mac OS 10.15.5
  • VS Code Version: 1.46.1
  • C/C++ Extension Version: 0.29.0-insiders
  • Other extensions you installed (and if the issue persists after disabling them):
  • Does this issue involve using SSH remote to run the extension on a remote machine?:
  • A clear and concise description of what the bug is, including information about the workspace (i.e. is the workspace a single project or multiple projects, size of the project, etc).

Steps to reproduce

#include <boost/multi_index_container.hpp>
#include <boost/multi_index/sequenced_index.hpp>

using namespace boost::multi_index;

typedef multi_index_container<
    int,
    indexed_by<
        sequenced<>
    >>
    multi;

Expected behavior <!-- A clear and concise description of what you expected to happen. -->

Should not show an error squiggle

Screenshots

image

created time in 10 days

issue commentfacebook/react

Feature proposal(eslint-react-hooks): don't require empty dependency useCallback in another dependency array

@bvaughn no problem, thanks for reopening, I didn't really know the language to explain it in the right terms (stable vs unstable) so I can see how it's an easy mistake to make.

georeith

comment created time in 12 days

issue commentfacebook/react

eslint rules: mark certain values as having a stable identity

Made this ticket https://github.com/facebook/react/issues/19217 for the same issue as I didn't see this one, I give more examples and reasoning there.

seansfkelley

comment created time in 12 days

issue commentfacebook/react

Feature proposal(eslint-react-hooks): don't require empty dependency useCallback in another dependency array

@bvaughn how is this a substantial change? It already does it for setState. Its just a lint rule exception 🤔

georeith

comment created time in 12 days

issue openedfacebook/react

Feature proposal(eslint-react-hooks): don't require empty dependency useCallback in another dependency array

Consider the following:

  const [mouseDown, setMouseDown] = useState(false);
  const onMouseDown = useCallback(e => { 
    setMouseDown(true);
  }, []);
  const onMouseMove = useCallback(e => { /* ... */ }, []);
  const onMouseUp = useCallback(() => {
    setMouseDown(false);
  }, []);
  const removeEventListeners = useCallback(() => {
    document.removeEventListener('mousemove', onMouseMove);
    document.removeEventListener('mouseup', onMouseUp);
  }, []);
  useEffect(() => {
    if (mouseDown) {
      document.addEventListener('mousemove', onMouseMove);
      document.addEventListener('mouseup', onMouseUp);
    } else {
      removeEventListeners();
    }
    return removeEventListeners;
  }, [mouseDown]);

Above the useEffect() will complain that it didn't receive removeEventListeners, onMouseMove and onMouseUp in its dependency array and it's correct. But it could be smarter, because they were all defined by useCallback(() => {}, []) meaning they will all remain the same value throughout the lifetime of this component.

Given this information I could write

created time in 12 days

issue commentfacebook/react

Bug: ESLint react-hooks/exhaustive-deps rule does not catch missing dependency for useCallback without a lambda

React.useCallback(fn(foo), [foo]);

and

 React.useCallback((bar: string) => fn(foo)(bar), [foo]);

are not equivalent.

In the first case you are immediately invoking fn(foo) and passing its return value to useCallback, thus neither fn or foo are dependencies of the useCallback unless you are returning a function from fn(foo) which uses them (the linter won't catch that case as it is likely unable to statically determine what the return of fn(foo) will be).

In the second case you are passing in a function which uses them and thus they are dependencies.

fn(foo) will be called every render in the first example.

mradamczyk

comment created time in 12 days

issue commentwebpack/webpack

Webpack 5, watchOptions.ignored with a RegExp object is broken

@sokra it says:

It is also possible to have and use multiple anymatch patterns:

Which are described here (where it links out to) as:

String to be directly matched, string with glob patterns, regular expression test, function that takes the testString as an argument and returns a truthy value if it should be matched, or an array of any number and mix of these types.

georeith

comment created time in a month

IssuesEvent

issue closedwebpack/webpack

Webpack 5, watchOptions.ignored with a RegExp object is broken

<!-- Please don't delete this template because we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of webpack. -->

Bug report

<!-- Please ask questions on StackOverflow or the webpack Gitter. --> <!-- https://stackoverflow.com/questions/ask?tags=webpack --> <!-- https://gitter.im/webpack/webpack --> <!-- Issues which contain questions or support requests will be closed. -->

What is the current behavior?

Passing a RegExp to watchOptions.ignore results in the following error:

/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/glob-to-regexp/index.js:3
    throw new TypeError('Expected a string');
    ^

TypeError: Expected a string
    at module.exports (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/glob-to-regexp/index.js:3:11)
    at stringToRegexp (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:26:17)
    at /Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:34:38
    at Array.map (<anonymous>)
    at ignoredToRegexp (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:34:29)
    at normalizeOptions (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:49:12)
    at cachedNormalizeOptions (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:58:21)
    at new Watchpack (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:71:25)
    at NodeWatchFileSystem.watch (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/webpack/lib/node/NodeWatchFileSystem.js:70:18)
    at Watching.watch (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/webpack/lib/Watching.js:176:48)
    at /Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/webpack/lib/Watching.js:155:11
    at processTicksAndRejections (internal/process/task_queues.js:82:9)
    at runNextTicks (internal/process/task_queues.js:59:3)
    at processImmediate (internal/timers.js:412:9)

If the current behavior is a bug, please provide the steps to reproduce.

watchOptions: {
  ignored: [/node_modules/];
}

<!-- A great way to do this is to provide your configuration via a GitHub repository --> <!-- The most helpful is a minimal reproduction with instructions on how to reproduce --> <!-- Repositories with too many files or large webpack.config.js files are not suitable --> <!-- Please only add small code snippets directly into this issue --> <!-- https://gist.github.com is a good place for longer code snippets --> <!-- If your issue is caused by a plugin or loader, please create an issue on the loader/plugin repository instead -->

What is the expected behavior?

Should be able to take RegExp object as configuration as per the documentation or the breaking change should be noted in the migration docs.

Other relevant information: webpack version: 5.0.0-beta.16 Node.js version: 12.4.0 Operating System: macOS mojave Additional tools:

closed time in a month

georeith

issue openedwebpack/webpack

Webpack 5, watchOptions.ignored with a RegExp object is broken

<!-- Please don't delete this template because we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of webpack. -->

Bug report

<!-- Please ask questions on StackOverflow or the webpack Gitter. --> <!-- https://stackoverflow.com/questions/ask?tags=webpack --> <!-- https://gitter.im/webpack/webpack --> <!-- Issues which contain questions or support requests will be closed. -->

What is the current behavior?

Passing a RegExp to watchOptions.ignore results in the following error:

/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/glob-to-regexp/index.js:3
    throw new TypeError('Expected a string');
    ^

TypeError: Expected a string
    at module.exports (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/glob-to-regexp/index.js:3:11)
    at stringToRegexp (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:26:17)
    at /Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:34:38
    at Array.map (<anonymous>)
    at ignoredToRegexp (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:34:29)
    at normalizeOptions (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:49:12)
    at cachedNormalizeOptions (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:58:21)
    at new Watchpack (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/watchpack/lib/watchpack.js:71:25)
    at NodeWatchFileSystem.watch (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/webpack/lib/node/NodeWatchFileSystem.js:70:18)
    at Watching.watch (/Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/webpack/lib/Watching.js:176:48)
    at /Users/george/Documents/marvel/mkiii/src/sites/marvel3/node_modules/webpack/lib/Watching.js:155:11
    at processTicksAndRejections (internal/process/task_queues.js:82:9)
    at runNextTicks (internal/process/task_queues.js:59:3)
    at processImmediate (internal/timers.js:412:9)

If the current behavior is a bug, please provide the steps to reproduce.

<!-- A great way to do this is to provide your configuration via a GitHub repository --> <!-- The most helpful is a minimal reproduction with instructions on how to reproduce --> <!-- Repositories with too many files or large webpack.config.js files are not suitable --> <!-- Please only add small code snippets directly into this issue --> <!-- https://gist.github.com is a good place for longer code snippets --> <!-- If your issue is caused by a plugin or loader, please create an issue on the loader/plugin repository instead -->

What is the expected behavior?

Should be able to take RegExp object as configuration as per the documentation or the breaking change should be noted in the migration docs.

Other relevant information: webpack version: 5.0.0-beta.16 Node.js version: 12.4.0 Operating System: macOS mojave Additional tools:

created time in a month

create barnchgeoreith/canvas-engines-comparison

branch : canvaskit

created branch time in 2 months

startedDefinitelyTyped/DefinitelyTyped

started time in 2 months

push eventmarvelapp/pixi-blit

George Reith

commit sha d9a2caa1807340a351f1f67553ea0cf37c9bd86f

build

view details

push time in 2 months

push eventmarvelapp/pixi-blit

Ivan Popelyshev

commit sha 047b1c0f5bf1dec6f046f4960fc1b9c36944e630

small refactor added snap

view details

George Reith

commit sha 5006cac4ed0a1166cb80ad67b518e9a652f5f1d5

Merge branch 'master' into yarnable

view details

push time in 2 months

push eventmarvelapp/pixi-blit

Ivan Popelyshev

commit sha 047b1c0f5bf1dec6f046f4960fc1b9c36944e630

small refactor added snap

view details

push time in 2 months

push eventmarvelapp/pixi-blit

Ivan Popelyshev

commit sha 5c83d3079c865d5bbfe52be326da1ec3f2eae80c

moved raster static vectorSprite issue

view details

George Reith

commit sha 17c6275250baa03b1c0ec2f66fee01df4d76fb7e

Merge branch 'master' into yarnable

view details

George Reith

commit sha 28c5c65714237812a30ed4b84273e4b69e06aaac

build

view details

push time in 2 months

push eventmarvelapp/pixi-blit

Ivan Popelyshev

commit sha 5c83d3079c865d5bbfe52be326da1ec3f2eae80c

moved raster static vectorSprite issue

view details

push time in 2 months

push eventmarvelapp/pixi-blit

Ivan Popelyshev

commit sha 2734f7de01c2a6c5a816681de700250abc195e10

new example by GeorgeReith fixes from upstream make_dts mistake

view details

George Reith

commit sha e57ab9ac297cf2e137bd138745ad91ece451e7ef

Merge branch 'master' into yarnable

view details

George Reith

commit sha 700f204a383a9ab5ecbc72b6e41657df86acc2d4

build

view details

push time in 2 months

push eventmarvelapp/pixi-blit

Ivan Popelyshev

commit sha 2734f7de01c2a6c5a816681de700250abc195e10

new example by GeorgeReith fixes from upstream make_dts mistake

view details

push time in 2 months

issue commentpixijs/pixi.js

lineAlignment at small sizes

@SukantPal up to you guys, I think this would still be considered unexpected behaviour for most. I can appreciate the complexity and cost in fixing it so can also appreciate the "won't fix" for this.

georeith

comment created time in 2 months

create barnchmarvelapp/pixi-blit

branch : model-reset-bug

created branch time in 2 months

issue openedslaylines/canvas-engines-comparison

Suggestion: show initialisation speed

I think another important factor that I'm noticing is the initialisation speed. I am noticing the Two.js example takes a long time to initialise at 5000 items.

Would be interesting to see how long it takes each library to draw their first frame.

created time in 2 months

pull request commentslaylines/canvas-engines-comparison

Make pixi.js comparison fair

@gnykka depends if you need to apply different operations.

The golden rule is the less you have to clear() and redraw the insides of the graphics the faster it's going to be.

Because you move each rectangle at a different rate I used a separate graphics instance so that we could move them without having to redraw them.

georeith

comment created time in 2 months

push eventgeoreith/canvas-engines-comparison

George Reith

commit sha 9a3ac1579d8855d3cd02a349da53ef5c2bdc9ea6

cleaner positioning

view details

push time in 2 months

push eventgeoreith/canvas-engines-comparison

George Reith

commit sha 09a238b904760353f3ff090f893df97a1a1b8a6c

match the coding style

view details

push time in 2 months

PR opened slaylines/canvas-engines-comparison

Make pixi.js comparison fair

The comparison is currently unfair, in both the Two.js and Paper.js cases the rectangles are created then their position is updated each frame.

In the Pixi.js the rectangles are created from scratch every frame which means they need to be retesselated every frame.

This makes the Pixi.js code match the other two in structure and as a result makes it much quicker.

+12 -20

0 comment

1 changed file

pr created time in 2 months

push eventgeoreith/canvas-engines-comparison

George Reith

commit sha f63506b61d9effa8cc611a182e777e984812ca8e

last fix

view details

push time in 2 months

push eventgeoreith/canvas-engines-comparison

George Reith

commit sha 4ec380d673a89bfd2570cdb5d8df7a953818c539

fix pixi.js example

view details

push time in 2 months

push eventmarvelapp/pixi-blit

George Reith

commit sha b4a1c719d1915555009b5b22c9cbd72dacd8babf

build

view details

push time in 2 months

push eventmarvelapp/pixi-blit

Ivan Popelyshev

commit sha 10d4b90f141871b35d51c9c8572b392e24231285

atlas storage fix

view details

Ivan Popelyshev

commit sha 115d719d2bfd378d2cb052109a649d9cf938253d

add a debug mode

view details

Ivan Popelyshev

commit sha d9b0b9d749686b382ec3c49f930e2ea2813b70c9

fix memory leaks

view details

Ivan Popelyshev

commit sha b70d664b2ff3eb880b7645cf842870150c3ed55d

basic interaction, filter fix queue bug

view details

Ivan Popelyshev

commit sha 34e287bfce05ea7727dcbdbf597518155ffaaa5c

remove blit mixins (obsolete)

view details

George Reith

commit sha b7fd1ffa41f6ea752e9cfe3368122746e74ae6fb

commit built files

view details

push time in 2 months

push eventmarvelapp/pixi-blit

Ivan Popelyshev

commit sha b70d664b2ff3eb880b7645cf842870150c3ed55d

basic interaction, filter fix queue bug

view details

Ivan Popelyshev

commit sha 34e287bfce05ea7727dcbdbf597518155ffaaa5c

remove blit mixins (obsolete)

view details

push time in 2 months

startedkylef/PathKit

started time in 2 months

delete branch marvelapp/pixi-blit

delete branch : marvel/master

delete time in 2 months

create barnchmarvelapp/pixi-blit

branch : yarnable

created branch time in 2 months

create barnchmarvelapp/pixi-blit

branch : marvel/master

created branch time in 2 months

issue commentpixijs/pixi.js

Dashed line style

@eXponenta have you seen https://studylib.net/doc/18300862/shader-based-antialiased--dashed--stroked-polylines?

glinskyc

comment created time in 3 months

issue commentpixijs/pixi.js

Dashed line style

Also need this

glinskyc

comment created time in 3 months

issue commentpixijs/pixi.js

Opacity on lines borked

Thanks @SukantPal I need a bit to digest this information as I'm very new to WebGL and the concepts of batching etc. I'm going to drop you a line if thats OK as I have a lot of features and this is part of a larger project and want to make sure of the suitability of the approach.

georeith

comment created time in 3 months

issue commentpixijs/pixi.js

Opacity on lines borked

Sorry miss pressed close there.

Thanks @bigtimebuddy just evaluating the alternatives you suggested:

  • AlphaFilter: it works but destroys the crispness of the lines, would require some sort of anti-aliasing on top not sure if I can maintain the fidelity of edges to an acceptable degree here.
  • useCacheAsBitmap: same as above ^
  • Don't use strokes: convert your strokes to fills. Very difficult in my case as these are not pre-generated assets but parameterised assets in a vector drawing tool so would need a general case solution for stroke conversion to outlines which isn't cheap, especially as they can then edit these strokes on the fly.
  • use a parallel CanvasRenderer: possibly the best solution? Doesn't require antialiasing, worried about how it scales as I need to do this to thousands of vectors.
georeith

comment created time in 3 months

IssuesEvent

issue closedpixijs/pixi.js

Opacity on lines borked

<!-- Thank you for reporting an issue!

Before opening an issue please check if a similar issue exists by searching existing issues (https://github.com/pixijs/pixi.js/issues).

If possible, please provide code that demonstrates the problem. Links to a running example of the problem are best!

Before submitting please read:

Contributors guide: https://github.com/pixijs/pixi.js/blob/dev/.github/CONTRIBUTING.md Code of Conduct: https://github.com/pixijs/pixi.js/blob/dev/.github/CODE_OF_CONDUCT.md -->

<!-- Bug Report (delete if not applicable) -->

Expected Behavior

Should be able to add opacity to a line

Current Behavior

Where the line overlaps in a curve streaks appear in it.

image

Possible workaround

Draw the line solid, render to a texture and then apply opacity (can be seen by applying circle.cacheAsBitmap = true to the attached pixiplayground). This suffers a loss of fidelity in the curve though.

Steps to Reproduce

Create an ellipse or curve and put a line on it

Environment

  • pixi.js version: 5.2.1
  • Browser & Version: Chrome 80
  • OS & Version: Mac OS Mojave
  • Running Example: https://pixiplayground.com/#/edit/A22hhBZYvo9FlcJOaUAHa <!-- https://pixiplayground.com/#/edit/8d3dEhG-g99EO7kgmrKik -->

closed time in 3 months

georeith

issue commentpixijs/pixi.js

Opacity on lines borked

Someone modified that example, i dont see a problem there. I updated the link. Not sure what happened there.

and it would be good if you point me to WebGL renderer that solved ;) Don't know of any open source ones.

georeith

comment created time in 3 months

issue commentpixijs/pixi.js

How to yarn/npm link pixi.js into a webpack

I don't see anything special here.

This may be due to my resolve.symlinks settings then . I have it set to false.

georeith

comment created time in 3 months

issue openedpixijs/pixi.js

Opacity on lines borked

<!-- Thank you for reporting an issue!

Before opening an issue please check if a similar issue exists by searching existing issues (https://github.com/pixijs/pixi.js/issues).

If possible, please provide code that demonstrates the problem. Links to a running example of the problem are best!

Before submitting please read:

Contributors guide: https://github.com/pixijs/pixi.js/blob/dev/.github/CONTRIBUTING.md Code of Conduct: https://github.com/pixijs/pixi.js/blob/dev/.github/CODE_OF_CONDUCT.md -->

<!-- Bug Report (delete if not applicable) -->

Expected Behavior

Should be able to add opacity to a line

Current Behavior

Where the line overlaps in a curve streaks appear in it.

image

Possible workaround

Draw the line solid, render to a texture and then apply opacity (can be seen by applying circle.cacheAsBitmap = true to the attached pixiplayground).

Steps to Reproduce

Create an ellipse or curve and put a line on it

Environment

  • pixi.js version: e.g. 4.7.1
  • Browser & Version: e.g. Chrome 67
  • OS & Version: e.g. Ubuntu 18.04
  • Running Example: https://pixiplayground.com/#/edit/Ib5smxGx9ksTU0mYKhPig <!-- https://pixiplayground.com/#/edit/8d3dEhG-g99EO7kgmrKik -->

created time in 3 months

fork georeith/react-pixi-fiber

Write PixiJS applications using React declarative style.

fork in 3 months

more