profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/geido/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Geido geido everywhere Developer Inside®

geido/incubator-superset 1

Apache Superset is a Data Visualization and Data Exploration Platform

geido/react-boilerplate-cra-template 1

:fire: Setup Create React App with React Boilerplate. Highly scalable & Best DX & Performance Focused & Best practices.

geido/geido 0

This is me

geido/react-pivottable 0

React-based drag'n'drop pivot table with Plotly.js charts

geido/superset-ui 0

Apache Superset UI packages

push eventgeido/incubator-superset

Andreas Schöneck

commit sha 633f29f3e9f5579a01a0b1cc33020cec1093f74b

Helm chart: Support hostAliases (#16703)

view details

Ville Brofeldt

commit sha 4e3d4f6daf01749b8f28e0770e138db5ed8fae91

feat: add global max row limit (#16683) * feat: add global max limit * fix lint and tests * leave SAMPLES_ROW_LIMIT unchanged * fix sample rowcount test * replace max global limit with existing sql max row limit * fix test * make max_limit optional in util * improve comments

view details

Evan Rusackas

commit sha 986ed684ac7d71cb486bfada694f806b13b58ca0

chore: bump path parse module in websocket sidecar app (#16720)

view details

David Aaron Suddjian

commit sha a4f60010a10bb4acd3c31c54910012c353e00692

add semantic title to the pull request template (#16693)

view details

Yongjie Zhao

commit sha cc1c6c1bb60b6357348028209062772927fd39ca

feat: add resample operator in post processing (#16607) * feat: add resample operator in post processing * wip * fill zero values * updates * fix ut

view details

William Gan

commit sha 7586e479a97184b11fc3fb7692547ee5ebfff645

other: Provide option to add environment variables to only supersetNode (#16627) * Add env variables for supersetNode in Helm template * Typo in template * Removed unnecessary if * Revert "Removed unnecessary if" This reverts commit af83568fb875faee95561e6f6e4c782727b0c97d. * Bumping chart version to 0.3.8 Co-authored-by: Craig Rueda <craig@craigrueda.com>

view details

Yongjie Zhao

commit sha 67b13308ca96d6fe0612749d411dc09a45a12a6d

chore: bump superset-ui 0.18.5 (#16725)

view details

simcha90

commit sha 985aa0643916292dfa3824cc03f4ae8a18bb1f80

chore: Upgrade immer package version (#16741) * fix:fix get permission function * chore: update immer * chore: update immer

view details

Ville Brofeldt

commit sha b92358b5b844e552ca79e02c5d30ac186136879e

ci: bump npm to version 7 (#16748)

view details

Elizabeth Thompson

commit sha 2a25e2d7cadb36295ef3ee950b8af00447595b03

update execution logs and states for alerts (#16736)

view details

Junlin Chen

commit sha a8d5342953057b2af055af28b9588d8d3dc375a9

chore: add browser info to template (#16732) * add browser info to template issue report with browser info * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>

view details

Elizabeth Thompson

commit sha f032cc254c7c42e3a1faa88504cfb40116193407

fix shared query (#16753)

view details

Elizabeth Thompson

commit sha d37553867157464ffb36b5cdeaf9e0cf7a2546a9

only fetch db function when db exists in sql lab (#16754)

view details

Beto Dealmeida

commit sha 493e804320ff037438ed5df07e7001d3aa4698a3

chore: log URI before downloading data on import (#16762)

view details

Beto Dealmeida

commit sha 48a61bacc581b1e585453f8181af9d76ef557e86

fix: handle CTEs with comments on is_select (#16769)

view details

Beto Dealmeida

commit sha a74352644ecc1f377c88f68d10685573ff8e064a

fix: typo in log (#16767)

view details

Ville Brofeldt

commit sha 1d5100daa2ea0089054acc6583d4fcb90716c6f6

fix(dataset): retain is_dttm if set on metadata sync (#16776)

view details

Michael S. Molina

commit sha 596e1cdf9b9cdcc5ac2d3a9bac579b27b15ecc1c

refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483)

view details

Michael S. Molina

commit sha b6d78bf4f263c428b3c0364682d081692815a19d

refactor: Changes the list views to use the new Select component (#16393) * chore: Change the list views to use the new Select component * Fix Cypress tests * Enables search for all controls * Adjusts controls width * Removes 'Me' and keeps the logged user on top * Fixes tests * Uses the borderless version for the filters * Fixes the tests * Reverts the Select theme to the default * Rebases and fixes js error * Fixes failing test * Removes unused withTheme

view details

Michael S. Molina

commit sha 9b17e86b447dc36fd39c3912d3ed3baf78d3bb2e

chore: Moves messageToasts to the components folder (#14431) * chore: Moves messageToasts to the components folder * Rebases

view details

push time in 17 hours

pull request commentapache/superset

feat: Select Component Feature Branch (Testing only)

Found 2 cosmetic issues in data table (can not repo on dev and prod): 1, the row bubble take some time to load when switching between data and sample

Could not repro

https://user-images.githubusercontent.com/60598000/134532383-88289411-ccca-4694-ae05-acc785b1dfe1.mp4

2, rolling down the data table and sample table the column title row is rolling too

Could not repro as well

https://user-images.githubusercontent.com/60598000/134532462-0ace75ef-fbcb-4862-bf82-5bf03b69dc6a.mp4

3, when adding annotation, need to click ok twice to add one annotation

I could reproduce this one and I am going to tackle it in the appropriate PR.

I also finished all the test cases and could not find any blocker. So I believe we are safe to proceed @jinghua-qa @junlincc

rusackas

comment created time in 18 hours

push eventgeido/incubator-superset

Shaoqing Hu

commit sha d0f69f2e5c5150ce74b645ac62e824337b1f7448

fix: pybabel extract fails (#16629) * fix pybabel extract fails * fix black * trigger GitHub actions

view details

Michael S. Molina

commit sha e9e6c5de8a69bfea4828b733767fab7daee67368

chore: Writes the tests for the new Select component (#16638) * chore: Writes the tests for the new Select component * Uses array destructuring

view details

ofekisr

commit sha df7d9d55158b5167abb4bba39e029f6b9ae27ae8

refactor sql_json view endpoint: separate save query concern into ad hod method (#16646)

view details

Daniel Vaz Gaspar

commit sha 3d0ebd5abcab58db10205a1b23988b895c903f15

chore: Bump Flask-OpenID to 1.3.0 (#16648)

view details

ofekisr

commit sha 62637f275f03a0d3b2095bd6e54f2ef758035ee7

refactor sql_json view endpoint: separate validate the query concern into ad hod method (#16647)

view details

ofekisr

commit sha 267b327a3c1b530cad5f1d43ab9e13e621432664

refactor sql_json view endpoint: separate query rendering concern into ad hod method (#16649)

view details

ofekisr

commit sha dad55a78f4d4446911efb067c87a7b1ffe345d26

refactor sql_json view endpoint: separate set the query's limiting concern into ad hod method (#16653)

view details

Ajay M

commit sha 4b70d46355c3018a516e1cb68c3d4a23004402ad

feat(dashboard): Native filters - add type to native filter configuration (#16549) * iSort fixes * Add type key to the new filters * Fix wrong attribute * PR comments * PR comments * Fix failing tests

view details

天河

commit sha bb014b513101c65cfcc22795380881ada0bda78a

fix: fix assignment in FilterBoxViz (#16662) * Fixing assignment. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Adding unit test for FilterBoxViz. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Reformatting with black. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Revert format change in other test. Signed-off-by: tianhe1986 <w1s2j3229@163.com> * Reformatting with the same black version with pre-commit config. Signed-off-by: tianhe1986 <w1s2j3229@163.com>

view details

Jack Fragassi

commit sha 4dc859f89e5668ed3f94cd1ef0532a301a3ab85a

fix: Ensure alerts & reports aren't schduled when flag is off (#16639) * Don't schedule alerts & reports when flag is off * Fix test function name * Fix test * Oops * Another tweak * Try to lint by hand * Fix mock

view details

ofekisr

commit sha 1429d9dab60cec3b3d19c08ce195acbdbbf839dc

refactor sql_json view endpoint: extract methods and rearrange code ordering (#16675) Co-authored-by: Jack Fragassi <jfragassi98@gmail.com>

view details

ofekisr

commit sha 51acadad74b698cd5e0e01f0eefd385315b20f2f

refactor sql_json view endpoint: separate a response creation (#16676)

view details

simcha90

commit sha 668ae23f28c64c0251c07e2b2c4a766e0d80bbc5

feat: Tabs in column (#16593) * fix:fix get permission function * feat: add tabs inside column * lint: fix lint * test: fix test * test: fix tests * test: fix tests * fix: pass onChangeTab function through layout

view details

ofekisr

commit sha 1cc726364a5f4ec61bb8af673cc0cd27c044ba87

refactor: sql_json view endpoint: use execution context instead of query (#16677) * refactor sql_json view endpoint: use execution context instead of query * fix failed tests * fix failed tests * refactor renaming enum options

view details

Daniel Vaz Gaspar

commit sha f2bc139e355df5c486383b6a5db446058511b634

feat: feature flag configurable custom backend (#16618) * feat: feature flag configurable custom backend * fix lint * simpler approach * fix tests * revert dependency updates * Update superset/utils/feature_flag_manager.py Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * Update superset/config.py Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

view details

Ville Brofeldt

commit sha 83581b126d34906a3c1c1b78e96965984f101915

feat(sqla): add time grain and time column to jinja params (#16680)

view details

ofekisr

commit sha 29b635a0a1846fed30613b5f468bed68c5ed2288

refactor sql_json view endpoint: move all logic from view to ExecuteSqlCommand (#16682)

view details

Grace Guo

commit sha b0b996582c9c6db20b9de30e26546264214f0716

fix: reset perf logger timer for soft navigation for SPA pages (#16668) * fix: reset perf logger timer for soft navigation for SPA pages * fix comments * fix extra comments Co-authored-by: grace_guo <grace_guo@grace-guos-MacBook-Pro.local>

view details

cccs-joel

commit sha c6ac10716a8d2dfe222fb2b1639b8486c93687ce

feat: show build number value in the About if present in the config (#14955)

view details

John Bodley

commit sha 1669947bcd429e926c6e8de5ceaafcfe5496b28b

chore(pylint): Reenable too-many-lines check (#16287) Co-authored-by: John Bodley <john.bodley@airbnb.com>

view details

push time in 18 hours

PullRequestReviewEvent

pull request commentapache/superset

feat: Select Component Feature Branch (Testing only)

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_UX_BETA=true FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true FEATURE_ENABLE_TEMPLATE_PROCESSING=true FEATURE_ENABLE_DND_WITH_CLICK_UX=true FEATURE_VERSIONED_EXPORT=true

rusackas

comment created time in 2 days

PullRequestEvent

PR closed apache/superset

feat: Select Component Feature Branch (Testing only) size/XXL preset-io hold!

<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly -->

SUMMARY

<!--- Describe the change below, including rationale and design decisions -->

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

<!--- Skip this if not applicable -->

TESTING INSTRUCTIONS

<!--- Required! What steps can be taken to manually verify the changes? -->

ADDITIONAL INFORMATION

<!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API
+593 -800

4 comments

36 changed files

rusackas

pr closed time in 2 days

push eventgeido/incubator-superset

Elizabeth Thompson

commit sha f032cc254c7c42e3a1faa88504cfb40116193407

fix shared query (#16753)

view details

Elizabeth Thompson

commit sha d37553867157464ffb36b5cdeaf9e0cf7a2546a9

only fetch db function when db exists in sql lab (#16754)

view details

Beto Dealmeida

commit sha 493e804320ff037438ed5df07e7001d3aa4698a3

chore: log URI before downloading data on import (#16762)

view details

Beto Dealmeida

commit sha 48a61bacc581b1e585453f8181af9d76ef557e86

fix: handle CTEs with comments on is_select (#16769)

view details

Beto Dealmeida

commit sha a74352644ecc1f377c88f68d10685573ff8e064a

fix: typo in log (#16767)

view details

Ville Brofeldt

commit sha 1d5100daa2ea0089054acc6583d4fcb90716c6f6

fix(dataset): retain is_dttm if set on metadata sync (#16776)

view details

Michael S. Molina

commit sha 596e1cdf9b9cdcc5ac2d3a9bac579b27b15ecc1c

refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483)

view details

Michael S. Molina

commit sha b6d78bf4f263c428b3c0364682d081692815a19d

refactor: Changes the list views to use the new Select component (#16393) * chore: Change the list views to use the new Select component * Fix Cypress tests * Enables search for all controls * Adjusts controls width * Removes 'Me' and keeps the logged user on top * Fixes tests * Uses the borderless version for the filters * Fixes the tests * Reverts the Select theme to the default * Rebases and fixes js error * Fixes failing test * Removes unused withTheme

view details

Michael S. Molina

commit sha 9b17e86b447dc36fd39c3912d3ed3baf78d3bb2e

chore: Moves messageToasts to the components folder (#14431) * chore: Moves messageToasts to the components folder * Rebases

view details

Kamil Gabryjelski

commit sha 486e0d412c66bc2c9edb9e4b75f12c8285db6f09

chore: Upgrade Webpack to v5 (#16701) * Upgrade Webpack to v5 * Remove mapbox hack * Replace url-loaders and file-loaders with asset modules * Remove 1 rule * Change --colors to --color * Remove invalid option (--no-progress) * Remove url-loader, bump plugin * Fix AnnotationLayer formula check * Remove redundant tests * Bump cypress packages * Remove old comment * Fix tests * Remove checks for number of scripts in markdown test * Cosmetic changes * Add tests * Fix test * Fix test * Fixes test warnings * disable flaky test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>

view details

Michael S. Molina

commit sha 99d15b25b0177e0b62c25fe859a1f31262b0f7e8

chore: Moves the images folder to the assets folder (#14429) * chore: Moves the images folder to the assets folder * Rebases

view details

Hugh A. Miles II

commit sha 77ae2e1826618bab8ff65ec10a03ca6668df887e

allow users to set port for cypress runs (#16533)

view details

geido

commit sha fd924083af0f93465be07438df5134caa8bc27df

Merge

view details

push time in 2 days

push eventgeido/incubator-superset

geido

commit sha 5f1b3b3984ce28f60d86aa0318d92cabb6435237

Refactor Select

view details

Geido

commit sha 461b11cdbffab23985c125232724c152e9a520d8

Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

view details

Geido

commit sha 5d61b44c745f1b44efbc80df569f45ffc8e9420b

Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

view details

Geido

commit sha d6ebcf2f0139d4df904f3388c26c34c797ea2a60

Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

view details

geido

commit sha e8815beef958436bb7d572746acb852c3ab6ebb4

Merge branch 'master' of https://github.com/apache/superset into chore/select-component-refactoring-timeseriescolumncontrol-iteration-5

view details

geido

commit sha 130db5cf345dabe7d897e4e9f9983a4892d72ee9

Merge branch 'chore/select-component-refactoring-timeseriescolumncontrol-iteration-5' of github.com:geido/incubator-superset into chore/select-component-refactoring-timeseriescolumncontrol-iteration-5

view details

geido

commit sha 1e73ac4053f660946fc8a43b030d7a3cc6e803c2

Fix tests

view details

geido

commit sha f9c4f554992c163a322f8ae13f7ef508dfa032f5

Mock debounce

view details

geido

commit sha d78b8bb649ce0b3f4ac89c63e6d0d19017070e7f

Merge branch 'chore/select-component-refactoring-timeseriescolumncontrol-iteration-5' into feature/select-component-refactor

view details

push time in 2 days

push eventgeido/incubator-superset

geido

commit sha 1e73ac4053f660946fc8a43b030d7a3cc6e803c2

Fix tests

view details

geido

commit sha f9c4f554992c163a322f8ae13f7ef508dfa032f5

Mock debounce

view details

push time in 2 days

push eventgeido/incubator-superset

geido

commit sha cf8751a5ad3cb4639706ac422d378010ec6cceda

Refactor Select for AdhocFilterEditPopoverSqlTabContent

view details

geido

commit sha 8ccd82403a41586fa7cc889915a8fe8289221bc3

Refactor Selects

view details

geido

commit sha 10c5c1b16c9e0a345601f663cc5612f1001ba32f

Merge branch 'master' of https://github.com/apache/superset into chore/select-component-filtercontrol-iteration-5

view details

geido

commit sha 1ef1a370896eadbb253ac4556c518e1715cbc580

Fix numeric options

view details

geido

commit sha feec347a5a7fe299c3a1577b9dea19b5ba9ea9bf

Clean up

view details

geido

commit sha 394118e5ec0edb59d28e539de13aecce98ab229b

Merge

view details

geido

commit sha 810bcc83ce231da780298ec997948b467cbfd353

Fix Select value

view details

geido

commit sha 82decb8c14f22b6df955d40266c44ef224f1daeb

Add showSearch

view details

geido

commit sha 30c3ca85347cb9daf2ff3e24d4f76e3f34ddf692

Display null label

view details

geido

commit sha d0739cc89d2c2ef0c13a3dd9ea01ca5f5ea1c06f

Implement StyledSelect

view details

Geido

commit sha 5be04e9269cff8df5ea1ca53c694f3f6d8a423d3

Update superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSqlTabContent/index.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

view details

geido

commit sha ddc0d7e4733071632d1e0fca66617c69e8466af1

Merge branch 'master' of https://github.com/apache/superset into chore/select-component-filtercontrol-iteration-5

view details

geido

commit sha 22b6f677e0db56e1986d02276ddcf05476f02825

Fix aria-label

view details

geido

commit sha 382315c2d5f4c3c393c8a19012f8cbe7080ca1b3

Refactor Select

view details

geido

commit sha de7ecf4c598bec2921815eca839b83821df691d3

Revert MetricControls changes

view details

geido

commit sha 6574d97a8f0caef35efa7a41708c45a79a90abfb

Render saved metric option

view details

geido

commit sha 7e3785d99611608e0ecd4521e37d95e8b5f953d5

Update tests

view details

geido

commit sha 7a39dfcef670719b45ebd75e5934bbda6cf0b19f

Refactor Select

view details

geido

commit sha fd9686cb162f5ca96775a7f4b114dd5b3ae54f56

Merge branch 'master' of https://github.com/apache/superset into chore/select-component-refactoring-metric-control-iteration-5

view details

geido

commit sha 710a8b9fbbb7fda5e0ae8c80faa6b526f362fd61

Refactor Select

view details

push time in 3 days

push eventgeido/incubator-superset

geido

commit sha 6e5712f1fd9ee958b279a32ecad2e26f50bda323

Refactor Select

view details

geido

commit sha f2e1be6fc717880a31c7596cc58fc74c9a3e9e11

Merge branch 'master' of https://github.com/apache/superset into chore/select-component-refactoring-selectasynccontrol-iteration-5

view details

geido

commit sha 4c4d63975c41c26d5feb47caae8ba5e08dfef799

Implement onError

view details

geido

commit sha e67c8ad9e08658a0cdc4b5b0bf4e158d1a936274

Separate async request

view details

geido

commit sha dbb8de42bed6d2eabf7e2a92c3cbf95f865d6fc4

Lint

view details

geido

commit sha 0ea923f37a90593739fe11645a68733463ad2cfd

Allow clear

view details

geido

commit sha 86e7650ba14e6de81025d3afdb6703dead7206b7

Merge branch 'master' of https://github.com/apache/superset into chore/select-component-refactoring-selectasynccontrol-iteration-5

view details

geido

commit sha 9e2e7e4c90751c0fa84235de2b821c23ad7a6e24

Improve type

view details

geido

commit sha b7c53da7f97ec3a58b8e3a6b62b89a0ccda43f6e

Merge branch 'master' of https://github.com/apache/superset into chore/select-component-refactoring-selectasynccontrol-iteration-5

view details

geido

commit sha a2de55510cea40e4ba82072a877dc2ae725ea624

Reconcile with Select latest changes

view details

geido

commit sha 825350ae0f69745acb97c70296307d733c768404

Fix handleOnChange

view details

geido

commit sha 7136a577064923ad79378a9a90013c897c8728f3

Clean up

view details

geido

commit sha 96e8d3f15128153f7760d9eacc08946c6f470660

Add placeholder

view details

geido

commit sha 4cd0ea1576576a2739cbd65e23c5b272f8bed3d0

Accept null values

view details

Geido

commit sha 92f3a6c0a7519e5c8bd26906974ecbb2710f86b8

Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

view details

geido

commit sha 5b11c2ffaea69d71b8a1da4a1afd41b5dafc5df3

Clean up

view details

geido

commit sha 164b9aa593ce05a4d21e0560f37fc33936f4d244

Implement type guard

view details

geido

commit sha 045887c4b3d8eec33f79022070d9643448fd9f88

Fix lint

view details

geido

commit sha e927e60addf95d4f6d4b321639e676ff1d528e27

Merge branch 'chore/select-component-refactoring-selectasynccontrol-iteration-5' into feature/select-component-refactor

view details

push time in 3 days

create barnchgeido/incubator-superset

branch : feature/select-component-refactor

created branch time in 3 days

pull request commentapache/superset

chore: Select component refactoring - FilterControl - Iteration 5

I think we need to clear the filter value when changing the column.

Screen.Recording.2021-09-15.at.6.19.33.PM.mov

Just tested on master. As @pkdotson reported this is currently not implemented. I think it makes sense to tackle that in a separate PR as it would be slightly unrelated to the objective of this PR. I'll work on that as soon as we merge this PR.

geido

comment created time in 3 days

push eventgeido/incubator-superset

geido

commit sha 678a0855bf3ae9d5968db19f41e7b5580004e09b

Enhance labels

view details

push time in 3 days

push eventgeido/incubator-superset

geido

commit sha 31fae65ef66162756f8c55d62a1a590220deb1f5

Fix lint

view details

push time in 3 days

push eventgeido/incubator-superset

geido

commit sha 045887c4b3d8eec33f79022070d9643448fd9f88

Fix lint

view details

push time in 3 days

push eventgeido/incubator-superset

geido

commit sha 67464ca78f7dcd387829c6cd2329190573265002

Apply enhancements

view details

push time in 3 days

Pull request review commentapache/superset

chore: Select component refactoring - SelectAsyncControl - Iteration 5

+/**+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements.  See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership.  The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License.  You may obtain a copy of the License at+ *+ *   http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */+import React, { useEffect, useState } from 'react';+import { t, SupersetClient } from '@superset-ui/core';+import ControlHeader from 'src/explore/components/ControlHeader';+import { Select } from 'src/components';+import { SelectProps, OptionsType } from 'src/components/Select/Select';+import { SelectValue, LabeledValue } from 'antd/lib/select';+import withToasts from 'src/messageToasts/enhancers/withToasts';++type SelectAsyncProps = Omit<SelectProps, 'options' | 'ariaLabel' | 'onChange'>;++interface SelectAsyncControlProps extends SelectAsyncProps {+  addDangerToast: (error: string) => void;+  ariaLabel?: string;+  dataEndpoint: string;+  default?: SelectValue;+  mutator?: (response: Record<string, any>) => OptionsType;+  multi?: boolean;+  onChange: (val: SelectValue) => void;+  // ControlHeader related props+  description?: string;+  hovered?: boolean;+  label?: string;+}++const SelectAsyncControl = ({+  addDangerToast,+  allowClear = true,+  ariaLabel,+  dataEndpoint,+  multi = true,+  mutator,+  onChange,+  placeholder,+  value,+  ...props+}: SelectAsyncControlProps) => {+  const [options, setOptions] = useState<OptionsType>([]);++  const handleOnChange = (val: SelectValue) => {+    let onChangeVal = val;+    if (Array.isArray(val)) {+      const values = val.map(v =>+        typeof v === 'object' && 'value' in v ? v.value : v,+      );+      onChangeVal = values as string[] | number[];+    }+    if (typeof val === 'object' && (val as LabeledValue)?.value) {+      onChangeVal = (val as LabeledValue).value;+    }

This is a great suggestion @villebro. For now, I implemented it here but I do agree we should go back to the Select component and add type guards wherever it makes sense.

geido

comment created time in 3 days

PullRequestReviewEvent

push eventgeido/incubator-superset

geido

commit sha 164b9aa593ce05a4d21e0560f37fc33936f4d244

Implement type guard

view details

push time in 3 days

push eventgeido/incubator-superset

geido

commit sha 151e087179920fbeb65d069845e1fa5bf026461f

Fix lint

view details

push time in 3 days

push eventgeido/incubator-superset

geido

commit sha e08746de22329746b2b7c1b2e638a1f117f8026d

Update Cypress test

view details

push time in 3 days

push eventgeido/incubator-superset

geido

commit sha 353ae0091c6fadfa111c0202295d7d62e17357bb

Revert changes to test

view details

push time in 3 days

push eventgeido/incubator-superset

Geido

commit sha 3a5ee3f50d52d8e2e29e96fe381d1b23ce628fa1

Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

view details

push time in 3 days

push eventgeido/incubator-superset

Geido

commit sha 5a94d561a980915206875613a11fc586e5d763db

Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

view details

push time in 3 days

push eventgeido/incubator-superset

geido

commit sha 5b11c2ffaea69d71b8a1da4a1afd41b5dafc5df3

Clean up

view details

push time in 3 days

push eventgeido/incubator-superset

Geido

commit sha 92f3a6c0a7519e5c8bd26906974ecbb2710f86b8

Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

view details

push time in 3 days

PullRequestReviewEvent

Pull request review commentapache/superset

chore: Select component refactoring - SelectAsyncControl - Iteration 5

+/**+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements.  See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership.  The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License.  You may obtain a copy of the License at+ *+ *   http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */+import React, { useEffect, useState } from 'react';+import { t, SupersetClient } from '@superset-ui/core';+import ControlHeader from 'src/explore/components/ControlHeader';+import { Select } from 'src/components';+import { SelectProps, OptionsType } from 'src/components/Select/Select';+import { SelectValue, LabeledValue } from 'antd/lib/select';+import withToasts from 'src/messageToasts/enhancers/withToasts';++type SelectAsyncProps = Omit<SelectProps, 'options' | 'ariaLabel' | 'onChange'>;++interface SelectAsyncControlProps extends SelectAsyncProps {+  addDangerToast: (error: string) => void;+  ariaLabel?: string;+  dataEndpoint: string;+  default?: SelectValue;+  mutator?: (response: Record<string, any>) => OptionsType;+  multi?: boolean;+  onChange: (val: SelectValue) => void;+  // ControlHeader related props+  description?: string;+  hovered?: boolean;+  label?: string;+}++const SelectAsyncControl = ({+  addDangerToast,+  allowClear = true,+  ariaLabel,+  dataEndpoint,+  multi = true,+  mutator,+  onChange,+  placeholder,+  value,+  ...props+}: SelectAsyncControlProps) => {+  const [options, setOptions] = useState<OptionsType>([]);

There is a mutator function that is expecting to get an object with a result property. In order to make sure the mutator gets the right data this is the shortest path.

geido

comment created time in 7 days