profile
viewpoint
Matt Gaunt gauntface Google USA https://gauntface.com Currently @Google supporting open source efforts.

gauntface/dpad-navigation 43

A javascript library to add basic spatial navigation to your web app. Useful until spatial focusing becomes the norm in browsers

gauntface/Android-Proximity-Alerts-Example 18

Just a simple example of multiple proximity alerts (by no means complete)

gauntface/Android-Headset-Example 16

This is a simple example to use Android headsets in you're application

gauntface/dotfiles-old 4

My dot files.

gauntface/Android-Boiler-Plate-Kitchen-Sink 2

This is an app to help with creating themes for applications

gauntface/gapic-generator-kotlin 1

Generate Kotlin gRPC client libraries from Protocol Buffer definitions.

PullRequestReviewEvent

Pull request review commentgoogle/go-github

Addressing issues raised by staticcheck

 func (s *IssueImportService) Create(ctx context.Context, owner, repo string, iss 		if ok { 			decErr := json.Unmarshal(aerr.Raw, i) 			if decErr != nil {-				err = decErr+				return nil, resp, decErr

yeah it's unusual here because the err was never used in this can, so we could simply drop the decErr which will be the current behavior

gauntface

comment created time in 9 hours

PR opened google/go-github

Addressing issues raised by staticcheck

I've disabled the checks for switch from go's openpgp implementation to a community fork because it seems like it's not a drop in replacement and needs some extra work.

github/git_commits.go:16:2: SA1019: package golang.org/x/crypto/openpgp is deprecated: this package is unmaintained except for security fixes. New applications should consider a more focused, modern alternative to OpenPGP for their specific task. If you are required to interoperate with OpenPGP systems and need a maintained package, consider a community fork. See https://golang.org/issue/44226. (staticcheck)
        "golang.org/x/crypto/openpgp"
+32 -12

0 comment

9 changed files

pr created time in 11 hours

push eventgauntface/go-github

Matt Gaunt

commit sha b2ec98cbb17c8676d4eb07aca35cc7522754ac94

Addressing issues raised by staticcheck

view details

push time in 11 hours

push eventgauntface/go-github

Matt Gaunt

commit sha 5ae38abe8ce1dbef7e5cf8c6998ffc8dfd0a2f81

Revert static check

view details

push time in 11 hours

push eventgauntface/go-github

Matt Gaunt

commit sha 79a2716e3b6ea331d5c87ae591d2aee7563ba398

Addess staticcheck issues regarding pgp

view details

push time in 11 hours

push eventgauntface/go-github

Matt Gaunt

commit sha 303c7d4d0b7b079843ddf65ad11f711a51a12c5c

Reverting openpgp changes

view details

push time in 12 hours

create barnchgauntface/go-github

branch : staticcheck

created branch time in 14 hours

push eventgauntface/go-github

Glenn Lewis

commit sha 8bb91d67e040bf62e199089cc0ec2d4ece3e56d8

Support go1.13 (#1279) Closes #1273.

view details

Glenn Lewis

commit sha 6de976c8cebd78576edefd295528a12551693c14

Update .travis.yml

view details

Dave Protasowski

commit sha eaf0d7dfd98f87e7c18ecae92c0ee7d5437916be

Update git_refs.go (#1240)

view details

Michael Cristina

commit sha 9686ff0746200cf521ce225525b421e13b4eac1a

Add start and end column to Annotation (#1241)

view details

Michael Cristina

commit sha c476c8213e8cc03dbaca2e439acd56cd4374dede

Remove blob_href from check annotations (#1242)

view details

Dmitry Savintsev

commit sha 51df1a01f93ea12e1cde997e86a94527144171ae

Fix failure in closing PRs (#1251) Fix an error in PullRequestsService.Edit when closing PRs due to 'base' field being present together with State = 'closed'. In this case the GitHub API v2.17.5 responds with error: 'Cannot change base branch of closed pull request'. Fixes #1250.

view details

Chris Raborg

commit sha 183e92fa7670fe3bf1b5680d9f80a9f065b87daf

Add sort, direction parameters to Repositories.ListByOrg (#1258)

view details

Emory Ruscus

commit sha 85279f51b0485d71a0e58ac5181f8e668f80a44b

Fix 'Reqest' -> 'Request' (add back the 'u'). (#1262)

view details

Francisco Guimarães

commit sha 9ee92864bda904cef6d83b83dd878efee8797bd4

Fix BranchCommit.Protected (#1274)

view details

Matt Gaunt

commit sha 512a8219bf28c87249674b405cc367610f3b9459

Add ListOptions to ListMigrations (#1278) Fixes #1277.

view details

Shota Terashita

commit sha e389f8689a34832ce0eeb91177a7f6e64aacacdb

Add support for BranchListOptions (#1272)

view details

Daoq

commit sha a01ea50f2fc0ce93dad509f31ed1b279cc07b424

Add default enterprise suffix when creating an enterprise method (#958) (#1165) Fixes #958.

view details

Quang Le Hong

commit sha 740806ae9dd43b6f68f872c299eedee17bcfa717

Add document for query of search functions (#1300) * Add document for search query * Add more detail of using search query

view details

thomaslanghorst

commit sha a291ecb5d81071fafe9bd24508e308923dcd6451

added test for JSON marshalling for Reviewers - relates to (#55) (#1309)

view details

Will Norris

commit sha 6b2a6456a7a093a3da8fc0f474afb4d1c71c1885

add experimental scrape package This package adds a very experimental client for accessing GitHub data via screen scraping. It is exempt from any stability promise that would otherwise be implied by the go-github version number.

view details

Will Norris

commit sha 982fe2db3e34ab144728f8d99e7ba30bad5a0066

define a new go module for the scrape package

view details

Will Norris

commit sha 3b6d4147caaa2f411a300f7ce147d30c47bf523c

scrape: add convenience Get method also extract the GitHub baseURL which will make testing easier, and allow overriding the underlying http.RoundTripper used by the client, which is needed in some environments.

view details

Will Norris

commit sha 944b567545fa137d6ca44324dceb5032641fc542

scrape: add tests for initial set of functions

view details

Will Norris

commit sha d40042531e938716fb801877b99dade5e93f02f3

scrape: don't export the generic form functions there's no need for these to be part of the exported API, they're just an implementation detail.

view details

Will Norris

commit sha b5d726b0e8bf09681c200438acb8ba1473466a72

scrape: don't export client.get (for now)

view details

push time in 16 hours

issue commentgoogle/go-github

Use https://staticcheck.io/

I'll take a stab at cleaning and enabling it later today if no one is working on it.

gauntface

comment created time in 16 hours

issue openedgoogle/go-github

Use https://staticcheck.io/

I just updated the internal (Google) version of go-github and one of the existing tools flagged some issues that seem reasonable to flag on GitHub.

The tool is staticcheck: https://staticcheck.io/

They look like they have a CLI and GitHub Actions.

Example of the errors it found, on actions_artifacts.go Line 121 there is an unused error value

parsedURL, err := url.Parse(resp.Header.Get("Location"))
return parsedURL, newResponse(resp), nil

@gmlewis and @willnorris curious what you think?

created time in 19 hours

push eventgauntface/gaunt.dev

Matt Gaunt

commit sha fcce76a22f47f5720e6a6283d00446d4f8743d04

Fixing lighthouse issues

view details

push time in 6 days

push eventgauntface/gaunt.dev

Matt Gaunt

commit sha 66fd65da2e849101a4ad9268c2148768a1ef5dfe

Fixing padding issue

view details

push time in 10 days

push eventgauntface/gaunt.dev

Matt Gaunt

commit sha 04b7d2fe593059dddce8b6da05f3b711cf8cc6af

We rely on s3 for building images

view details

push time in 10 days

push eventgauntface/gaunt.dev

Matt Gaunt

commit sha 6acd6e5d2437f78e37a6ab23b6c877e34d9e44c0

adding accessible colors and exclude generated imgs

view details

push time in 10 days

release gauntface/go-html-asset-manager

v2.0.3

released time in 11 days

created taggauntface/go-html-asset-manager

tagv2.0.3

created time in 11 days

push eventgauntface/go-html-asset-manager

Matt Gaunt

commit sha 4a12b8aaa6d74799d0171620cc5be1f2708a93a5

Adding cache control to images (#173)

view details

push time in 11 days

delete branch gauntface/go-html-asset-manager

delete branch : genimgs

delete time in 11 days

create barnchgauntface/go-html-asset-manager

branch : genimgs

created branch time in 11 days

push eventgauntface/gaunt.dev

Matt Gaunt

commit sha 9531797061b4a29ada9a05f45766f4b92cd168dc

Minor tweaks to layout

view details

push time in 11 days

push eventgauntface/go-html-asset-manager

Matt Gaunt

commit sha e3e2b39c28c5b94fbae9d28585be1f58d07168c7

Adding width/height for images and public acls for genimgs (#171)

view details

push time in 11 days

delete branch gauntface/go-html-asset-manager

delete branch : s3-acls

delete time in 11 days

create barnchgauntface/go-html-asset-manager

branch : s3-acls

created branch time in 11 days

push eventgauntface/gaunt.dev

Matt Gaunt

commit sha 1d2085c6baba3c98a148264523271343323a9e86

Configure aws region

view details

push time in 12 days

push eventgauntface/gaunt.dev

Matt Gaunt

commit sha 6335ddeb1ce962616f1c83583a74e6b657e1680d

Bumping to v2 (#59)

view details

push time in 12 days

more