profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/gahr/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

flightaware/speedtables 52

Speed tables is a high-performance memory-resident database. The speed table compiler reads a table definition and generates a set of C access routines to create, manipulate and search tables containing millions of rows. Currently oriented towards Tcl.

flightaware/kafkatcl 11

Tcl interface to the Apache Kafka distributed messaging system

flightaware/tcllauncher 10

This is tcllauncher, a launcher program for Tcl applications.

flightaware/casstcl 9

Tcl language interface to the Cassandra database

flightaware/tclbsd 9

A Tcl package for interfacing to various BSD UNIX system calls and library routines

gahr/fbackup 2

Perform incremental backups using a fossil repository as a storage.

gahr/bwget 1

Sync & search a local gpg-encrypted cache of a Bitwarden vault

gahr/acutest 0

Simple (single header) C/C++ unit testing facility.

gahr/autosetup 0

A better, faster autoconf replacement

PR closed neomutt/neomutt

Reviewers
Unset the pager menu when done bug:confirmed

Fixes #3033

We don't want the pager's pointer to the index to remain there and handle redraw notifications. I'd really love to hear @flatcap 's opinion on this one.

+1 -0

4 comments

1 changed file

gahr

pr closed time in 7 hours

pull request commentneomutt/neomutt

Unset the pager menu when done

Thanks, that was it!

gahr

comment created time in 7 hours

issue closedneomutt/neomutt

Pager Not Showing Message Body

Neomutt is not displaying the contents of any email message. It seems like it's trying to use lynx to view them and is complaining about not having access to some file. Here's an example -

Date: Tue, 23 Feb 2021 13:29:37 -0500 (EST)
From: Discount Electronics <deals@discountelectronics.com>
To: jpbaiocchi@protonmail.com
Subject: Pop-Up Deal $275 HP i5 15.6" Laptops
X-Mailer: Roving Constant Contact 2012 (http://www.constantcontact.com)

[-- Autoview using lynx -assume_charset='utf-8' -display_charset=utf-8 -dump '/tmp/neomutt.html' --]
[-- Autoview stderr of lynx -assume_charset='utf-8' -display_charset=utf-8 -dump '/tmp/neomutt.html' --]

Can't Access `file://localhost/tmp/neomutt.html'
Alert!: Unable to access document.

lynx: Can't access startfile

Note I am using Protonmail and configured my neomutt with Mutt-Wizard (https://github.com/LukeSmithxyz/mutt-wizard)

closed time in 9 hours

ghost
PullRequestReviewEvent

push eventgahr/freddieandthecannonballs.com

Pietro Cerutti

commit sha 743e54acd6b322b7c792913862ea0fcd30d4cc0d

Handle intervals in gigs dates

view details

push time in 3 days

Pull request review commentneomutt/neomutt

Do not attemp to copy from a FILE* onto itself

 int mutt_copy_message(FILE *fp_out, struct Email *e, struct Message *msg,   {     return -1;   }+  if (fp_out == msg->fp)+  {+    mutt_debug(LL_DEBUG1, "trying to read/write from/to the same FILE*!\n");

I'm willing to put an assert here.

gahr

comment created time in 4 days

PullRequestReviewEvent

issue commentneomutt/neomutt

<sync-mailbox> unable to write to mailbox after manually linking threads with <link-threads>

@yomotherboard can you please try the devel/issue-3040 branch?

yomotherboard

comment created time in 4 days

PR opened neomutt/neomutt

Reviewers
Do not attemp to copy from a FILE* onto itself bug:confirmed

Fixes #3040

I introduced this bug in #2908.

+14 -4

0 comment

3 changed files

pr created time in 4 days

create barnchneomutt/neomutt

branch : devel/issue-3040

created branch time in 4 days

issue commentneomutt/neomutt

<sync-mailbox> unable to write to mailbox after manually linking threads with <link-threads>

I can reproduce this on a simple Maildir.

yomotherboard

comment created time in 4 days

pull request commentneomutt/neomutt

Unset the pager menu when done

Yup, I read again 3033 and I think I'm fixing some different issue: what I'm preventing with this commit is a full redraw of the entire index when changing selection (up, down) after having opened an email (i.e., after the pager has been opened at least once).

gahr

comment created time in 4 days

PR opened neomutt/neomutt

Reviewers
Unset the pager menu when done

Fixes #3033

We don't want the pager to remain there and handle redraw notifications. I'd really love to hear @flatcap 's opinion on this one.

+1 -0

0 comment

1 changed file

pr created time in 5 days

create barnchneomutt/neomutt

branch : devel/issue-3033

created branch time in 5 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha 8890a515bad114407f6995b240d5edad011fc7d9

Kill GreetingInfo (refactor) (#3038)

view details

push time in 5 days

PR merged neomutt/neomutt

Reviewers
Kill GreetingInfo (refactor) topic:refactoring

No functional change

+6 -18

0 comment

1 changed file

gahr

pr closed time in 5 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha 9009f4c108a6dbcc36cb1171248414fc02b4fee3

Tidy

view details

push time in 6 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha 1f4995dd803563467a48d404f9b493d534d09dfb

Documentation

view details

Pietro Cerutti

commit sha e531da363d974e2ae9535cb3f40d830cca48d329

Flesh out send_simple_email API

view details

push time in 6 days

push eventneomutt/neomutt

push time in 6 days

PR opened neomutt/neomutt

Reviewers
Kill GreetingInfo (refactor) topic:refactoring

No functional change

+6 -18

0 comment

1 changed file

pr created time in 6 days

create barnchneomutt/neomutt

branch : devel/kill-greeting-info

created branch time in 6 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha b9bd149db6606fae463b37f4dcf311bbd6e96ad0

Fix leak

view details

Pietro Cerutti

commit sha a9c1f7b5cf1efd026cdda449c9195ade945982e9

Document

view details

Pietro Cerutti

commit sha d65e8cb1b1e2577ace5305747c7cb29af9a48149

Kill GreetingInfo (refactor)

view details

push time in 6 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha f7d5333f7868ef6dff9171e0a6322f2910cd1730

Fetch list-(un)subscribe with headers

view details

Pietro Cerutti

commit sha a0833b49a7c44f722a1dd2e20f5d27b62fb05420

Make list-(un)subscribe available in index/pager/attach

view details

Pietro Cerutti

commit sha 248f116eccabc8edf12eaab64040c7ee3016441b

clang-format

view details

push time in 6 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha 9bb7239bf523cec6bc541a43932798c3bf2386a3

Implement list-subscribe for completeness

view details

push time in 6 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha dcd4cf48f2208d813330b9b6f72f9587dfe84341

Implement list-subscribe for completeness

view details

push time in 6 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha fcfbe529dc711f8c519683a6188e0bffca1918ae

Document new function

view details

push time in 6 days

PR opened neomutt/neomutt

Reviewers
Implement list-unsubscribe type:enhancement

This function uses the List-Unsubscribe header from RFC2369 to send an unsubscribe email. Works best with unignore list-unsubscribe.

TODO

  • [ ] documentation
  • [ ] implement simple API to send an email
+199 -119

0 comment

10 changed files

pr created time in 6 days

push eventneomutt/neomutt

Pietro Cerutti

commit sha 91505bfeb6268c35601063bad18225f137dc0aa0

Implement list-unsubscribe This function uses the List-Unsubscribe header from RFC2369 to send an unsubscribe email. Works best with `unignore list-unsubscribe`.

view details

push time in 6 days

create barnchneomutt/neomutt

branch : devel/list-unsubscribe

created branch time in 7 days

issue closedneomutt/neomutt

ASAN detects use-after-free during compose

<!-- Sorry you've found a bug, but thanks for reporting it here. Please try to give as much information as you can. -->

Expected Behaviour

no crash <!-- What were you trying to do? -->

Actual Behaviour

After composing an email and hitting 'y' to send it, neomutt crashes with a use-after-free <!-- What went wrong? -->

If NeoMutt crashed, did your OS create a 'coredump' file?

=================================================================
==1890811==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700001c060 at pc 0x0000006c25f0 bp 0x7ffe24d13980 sp 0x7ffe24d13978
READ of size 4 at 0x60700001c060 thread T0
    #0 0x6c25ef in mutt_compose_menu compose/compose.c:471
    #1 0x6aa4d9 in mutt_send_message send/send.c:2721
    #2 0x6a4440 in mutt_resend_message send/send.c:1665
    #3 0x5080da in op_resend pager/functions.c:1170
    #4 0x50d0c9 in pager_function_dispatcher pager/functions.c:1902
    #5 0x4f0b43 in mutt_pager pager/dlg_pager.c:848
    #6 0x5008be in mutt_display_message pager/message.c:430
    #7 0x4d1d96 in op_display_message index/functions.c:325
    #8 0x4e409a in index_function_dispatcher index/functions.c:2995
    #9 0x4cf2d9 in mutt_index_menu index/dlg_index.c:1333
    #10 0x4824f6 in main /home/eblake/neomutt/main.c:1368
    #11 0x7fc78e609b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)
    #12 0x40c23d in _start (/home/eblake/neomutt/neomutt+0x40c23d)

0x60700001c060 is located 64 bytes inside of 72-byte region [0x60700001c020,0x60700001c068)
freed by thread T0 here:
    #0 0x7fc78f029647 in free (/lib64/libasan.so.6+0xae647)
    #1 0x733012 in mutt_mem_free mutt/memory.c:75
    #2 0x6c979c in compose_shared_data_free compose/shared_data.c:42
    #3 0x577c1f in mutt_window_free gui/mutt_window.c:217
    #4 0x6c25bc in mutt_compose_menu compose/compose.c:469
    #5 0x6aa4d9 in mutt_send_message send/send.c:2721
    #6 0x6a4440 in mutt_resend_message send/send.c:1665
    #7 0x5080da in op_resend pager/functions.c:1170
    #8 0x50d0c9 in pager_function_dispatcher pager/functions.c:1902
    #9 0x4f0b43 in mutt_pager pager/dlg_pager.c:848
    #10 0x5008be in mutt_display_message pager/message.c:430
    #11 0x4d1d96 in op_display_message index/functions.c:325
    #12 0x4e409a in index_function_dispatcher index/functions.c:2995
    #13 0x4cf2d9 in mutt_index_menu index/dlg_index.c:1333
    #14 0x4824f6 in main /home/eblake/neomutt/main.c:1368
    #15 0x7fc78e609b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)

previously allocated by thread T0 here:
    #0 0x7fc78f029af7 in calloc (/lib64/libasan.so.6+0xaeaf7)
    #1 0x732f45 in mutt_mem_calloc mutt/memory.c:55
    #2 0x6c97b6 in compose_shared_data_new compose/shared_data.c:51
    #3 0x6c1921 in compose_dlg_init compose/compose.c:351
    #4 0x6c1c4c in mutt_compose_menu compose/compose.c:406
    #5 0x6aa4d9 in mutt_send_message send/send.c:2721
    #6 0x6a4440 in mutt_resend_message send/send.c:1665
    #7 0x5080da in op_resend pager/functions.c:1170
    #8 0x50d0c9 in pager_function_dispatcher pager/functions.c:1902
    #9 0x4f0b43 in mutt_pager pager/dlg_pager.c:848
    #10 0x5008be in mutt_display_message pager/message.c:430
    #11 0x4d1d96 in op_display_message index/functions.c:325
    #12 0x4e409a in index_function_dispatcher index/functions.c:2995
    #13 0x4cf2d9 in mutt_index_menu index/dlg_index.c:1333
    #14 0x4824f6 in main /home/eblake/neomutt/main.c:1368
    #15 0x7fc78e609b74 in __libc_start_main (/lib64/libc.so.6+0x27b74)

SUMMARY: AddressSanitizer: heap-use-after-free compose/compose.c:471 in mutt_compose_menu
Shadow bytes around the buggy address:
  0x0c0e7fffb7b0: 00 00 00 00 00 00 00 00 05 fa fa fa fa fa fd fd
  0x0c0e7fffb7c0: fd fd fd fd fd fd fd fa fa fa fa fa 00 00 00 00
  0x0c0e7fffb7d0: 00 00 00 00 05 fa fa fa fa fa 00 00 00 00 00 00
  0x0c0e7fffb7e0: 00 00 05 fa fa fa fa fa 00 00 00 00 00 00 00 00
  0x0c0e7fffb7f0: 05 fa fa fa fa fa 00 00 00 00 00 00 00 00 00 03
=>0x0c0e7fffb800: fa fa fa fa fd fd fd fd fd fd fd fd[fd]fa fa fa
  0x0c0e7fffb810: fa fa 00 00 00 00 00 00 00 00 03 fa fa fa fa fa
  0x0c0e7fffb820: 00 00 00 00 00 00 00 00 00 07 fa fa fa fa fd fd
  0x0c0e7fffb830: fd fd fd fd fd fd fd fa fa fa fa fa 00 00 00 00
  0x0c0e7fffb840: 00 00 00 00 00 07 fa fa fa fa fd fd fd fd fd fd
  0x0c0e7fffb850: fd fd fd fd fa fa fa fa 00 00 00 00 00 00 00 00
==1890811==ABORTING

Steps to Reproduce

compose message, and hit send <!-- As much detail as possible, please -->

How often does this happen?

  • Always

When did it start to happen?

  • When I upgraded Seeing it with commit e09af48d3, did not see it with 55f126fc

NeoMutt Version

NeoMutt 20210205-771-e09af4
Copyright (C) 1996-2020 Michael R. Elkins and others.
NeoMutt comes with ABSOLUTELY NO WARRANTY; for details type 'neomutt -vv'.
NeoMutt is free software, and you are welcome to redistribute it
under certain conditions; type 'neomutt -vv' for details.

System: Linux 5.13.10-200.fc34.x86_64 (x86_64)
ncurses: ncurses 6.2.20200222 (compiled with 6.2.20200222)
libidn2: 2.3.2 (compiled with 2.3.2)
GPGME: 1.15.1
GnuTLS: 3.7.2
libnotmuch: 5.3.0
PCRE2: 10.36 2020-12-04
storage: tokyocabinet, lmdb
compression: lz4, zlib, zstd

Configure options: --testing --sysconfdir=/etc --full-doc SENDMAIL=/usr/sbin/sendmail ISPELL=/usr/bin/hunspell --autocrypt --gnutls --gpgme --gss --disable-idn --idn2 --lmdb --lua --lz4 --notmuch --pcre2 --sasl --tokyocabinet --zlib --zstd {EXTRA_CFLAGS=-ggdb3 -Og} --asan

Compilation CFLAGS: -g -O2 -std=c99 -fno-delete-null-pointer-checks -D_ALL_SOURCE=1 -D_GNU_SOURCE=1 -D__EXTENSIONS__ -I/usr/include -DNCURSES_WIDECHAR -fsanitize=address -O0 -fno-omit-frame-pointer -fno-common

Default options:
  +attach_headers_color +compose_to_sender +compress +cond_date +debug 
  +encrypt_to_self +forgotten_attachments +forwref +ifdef +imap +index_color 
  +initials +limit_current_thread +multiple_fcc +nested_if +new_mail +nntp +pop 
  +progress +quasi_delete +regcomp +reply_with_xorig +sensible_browser +sidebar 
  +skip_quoted +smtp +status_color +timeout +tls_sni +trash 

Compile options:
  +autocrypt +fcntl -flock -fmemopen +futimens +getaddrinfo +gnutls +gpgme +gss 
  +hcache -homespool +idn +inotify -locales_hack +lua -mixmaster +nls +notmuch 
  -openssl +pcre2 +pgp +sasl +smime +sqlite +sun_attachment 

Debug options:
  !asan 

MAILPATH="/var/mail"
PKGDATADIR="/usr/share/neomutt"
SENDMAIL="/usr/sbin/sendmail"
SYSCONFDIR="/etc"

To learn more about NeoMutt, visit: https://neomutt.org
If you find a bug in NeoMutt, please raise an issue at:
    https://github.com/neomutt/neomutt/issues
or send an email to: <neomutt-devel@neomutt.org>

Extra Info

<!-- This info might help us narrow down the source of the problem. -->

  • Operating System and its version Fedora 34
  • Were you using multiple copies of NeoMutt at once? no
  • Were you using 'screen' or 'tmux'?
  • Is your email local (maildir) or remote (IMAP)? notmuch access into local maildir

closed time in 15 days

ebblake