profile
viewpoint
Philipp Giese frontendphil @signavio Potsdam, Germany https://philgiese.com

jfschwarz/substyle 34

Build reusable React components that can be styled with css, css modules, inline styles & many css-in-js libs

frontendphil/analyzr 6

Expertise reports for code repositories

frontendphil/OpenCanteen-PHP-Lib 1

A PHP Library for the OpenCanteen Webservice

frontendphil/Rub-the-Process 1

A little fun game designed for the iPad where you have to rub a covered process model until you freed all elements.

frontendphil/Apartment-Awesome 0

Website for the hippest apartment out there!

frontendphil/browser-cookies 0

Tiny cookies library for the browser

frontendphil/CG-Admin 0

An administration tool for a physiotherapist.

frontendphil/condition-circle 0

Checks CircleCI environment before publishing successful build using semantic-release

push eventsignavio/react-stick

Philipp Giese

commit sha c339d225c1cc69c257e3443c9ff750a63c2f98ca

Improvement/improve specs (#152) * chore: use forwardRef internally * chore: add mocha flow types * chore: use testing-library/react in specs, remove callback hell * chore: remove accidetally added jest * chore: use correct test command on circle ci * chore: remove release-preview step

view details

push time in 10 days

delete branch signavio/react-stick

delete branch : improvement/imrpove-specs

delete time in 10 days

PR merged signavio/react-stick

Improvement/improve specs
  • remove all those callbacks from the specs
  • use @testing-library/react in specs
  • add flow-types to all specs
+909 -842

2 comments

14 changed files

frontendphil

pr closed time in 10 days

push eventsignavio/react-stick

Philipp Giese

commit sha 44fce63042866f2eadd4feea68dc4e7fa1e90bb6

chore: remove release-preview step

view details

push time in 10 days

push eventsignavio/react-stick

Philipp Giese

commit sha 553b02de61b3335ce19635ba11b6a83e02578d48

chore: use correct test command on circle ci

view details

push time in 10 days

push eventsignavio/react-stick

Philipp Giese

commit sha 9b96947a9e9d04a2721c9fee7adf8105e63f4582

chore: remove accidetally added jest

view details

push time in 10 days

PR opened signavio/react-stick

Improvement/improve specs
+2206 -883

0 comment

13 changed files

pr created time in 10 days

create barnchsignavio/react-stick

branch : improvement/imrpove-specs

created branch time in 10 days

issue commentsignavio/react-stick

Run checkAlignment procedure on first render

Hey, @yakunins sorry for overlooking this for so long! Please go ahead and put together a PR if you already have an idea how to solve this :)

yakunins

comment created time in 11 days

PR merged signavio/react-stick

chore(deps): bump http-proxy from 1.18.0 to 1.18.1 dependencies

Bumps http-proxy from 1.18.0 to 1.18.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md">http-proxy's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/http-party/node-http-proxy/compare/1.18.0...v1.18.1">v1.18.1</a> - 2020-05-17</h2> <h3>Merged</h3> <ul> <li>Skip sending the proxyReq event when the expect header is present <a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/pull/1447"><code>#1447</code></a></li> <li>Remove node6 support, add node12 to build <a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/pull/1397"><code>#1397</code></a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/http-party/node-http-proxy/commit/9b96cd725127a024dabebec6c7ea8c807272223d"><code>9b96cd7</code></a> 1.18.1</li> <li><a href="https://github.com/http-party/node-http-proxy/commit/335aeeba2f0c286dc89c402eeb76af47834c89a3"><code>335aeeb</code></a> Skip sending the proxyReq event when the expect header is present (<a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/issues/1447">#1447</a>)</li> <li><a href="https://github.com/http-party/node-http-proxy/commit/dba39668ba4c9ad461316e834b2d64b77e1ca88e"><code>dba3966</code></a> Remove node6 support, add node12 to build (<a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/issues/1397">#1397</a>)</li> <li>See full diff in <a href="https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+8 -19

2 comments

1 changed file

dependabot[bot]

pr closed time in 11 days

push eventsignavio/react-stick

dependabot[bot]

commit sha de83389345b9559fa517426ed2581f27932caf41

chore(deps): bump http-proxy from 1.18.0 to 1.18.1 (#148) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 11 days

delete branch signavio/react-stick

delete branch : dependabot/npm_and_yarn/http-proxy-1.18.1

delete time in 11 days

PullRequestReviewEvent

push eventsignavio/react-stick

renovate[bot]

commit sha 05f1ea5de1fddbd0f04080bb82998c9664067264

chore(deps): update dependency prettier to v2.1.2 (#140) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 11 days

delete branch signavio/react-stick

delete branch : renovate/prettier-2.x

delete time in 11 days

PR merged signavio/react-stick

chore(deps): update dependency prettier to v2.1.2

This PR contains the following updates:

Package Type Update Change
prettier (source) devDependencies patch 2.1.0 -> 2.1.2

Release Notes

<details> <summary>prettier/prettier</summary>

v2.1.2

Compare Source

diff

Fix formatting for directives in fields (#​9116 by @​sosukesuzuki)

<!-- prettier-ignore -->


v2.1.1

Compare Source

diff

Fix format on html with frontMatter (#​9043 by @​fisker)

<!-- prettier-ignore -->

<!-- Input -->
---
layout: foo
---

Test <a
href="https://prettier.io">abc</a>.

<!-- Prettier stable -->
TypeError: Cannot read property 'end' of undefined
  ...

<!-- Prettier master -->
---
layout: foo
---

Test <a href="https://prettier.io">abc</a>.
Fix broken format for ...infer T (#​9044 by @​fisker)

<!-- prettier-ignore -->

// Input
type Tail<T extends any[]> = T extends [infer U, ...infer R] ? R : never;

// Prettier stable
type Tail<T extends any[]> = T extends [infer U, ...(infer R)] ? R : never;

// Prettier master
type Tail<T extends any[]> = T extends [infer U, ...infer R] ? R : never;
Fix format on style[lang="sass"] (#​9051 by @​fisker)

<!-- prettier-ignore -->

<!-- Input -->
<style lang="sass">
.hero
  @&#8203;include background-centered
</style>

<!-- Prettier stable -->
<style lang="sass">
.hero @&#8203;include background-centered;
</style>

<!-- Prettier master -->
<style lang="sass">
  .hero
    @&#8203;include background-centered
</style>
Fix self-closing blocks and blocks with src attribute format (#​9052, #​9055 by @​fisker)

<!-- prettier-ignore -->

<!-- Input -->
<custom lang="markdown" src="./foo.md"></custom>
<custom lang="markdown" src="./foo.md" />
<custom lang="markdown" />

<!-- Prettier stable -->
<custom lang="markdown" src="./foo.md">

</custom>
<custom lang="markdown" src="./foo.md"

/>
<custom lang="markdown"

/>

<!-- Prettier master -->
<custom lang="markdown" src="./foo.md"></custom>
<custom lang="markdown" src="./foo.md" />
<custom lang="markdown" />

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+5 -5

2 comments

2 changed files

renovate[bot]

pr closed time in 11 days

PullRequestReviewEvent

push eventsignavio/react-stick

dependabot[bot]

commit sha 516e9b619e1b4cc24d4534fa86698fc55b551d14

chore(deps): bump elliptic from 6.4.0 to 6.5.3 (#129) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.4.0 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.4.0...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 16 days

delete branch signavio/react-stick

delete branch : dependabot/npm_and_yarn/elliptic-6.5.3

delete time in 16 days

PR merged signavio/react-stick

chore(deps): bump elliptic from 6.4.0 to 6.5.3 dependencies

Bumps elliptic from 6.4.0 to 6.5.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/indutny/elliptic/commit/8647803dc3d90506aa03021737f7b061ba959ae1"><code>8647803</code></a> 6.5.3</li> <li><a href="https://github.com/indutny/elliptic/commit/856fe4d99fe7b6200556e6400b3bf585b1721bec"><code>856fe4d</code></a> signature: prevent malleability and overflows</li> <li><a href="https://github.com/indutny/elliptic/commit/60489415e545efdfd3010ae74b9726facbf08ca8"><code>6048941</code></a> 6.5.2</li> <li><a href="https://github.com/indutny/elliptic/commit/9984964457c9f8a63b91b01ea103260417eca237"><code>9984964</code></a> package: bump dependencies</li> <li><a href="https://github.com/indutny/elliptic/commit/ec735edde187a43693197f6fa3667ceade751a3a"><code>ec735ed</code></a> utils: leak less information in <code>getNAF()</code></li> <li><a href="https://github.com/indutny/elliptic/commit/71e4e8e2f5b8f0bdbfbe106c72cc9fbc746d3d60"><code>71e4e8e</code></a> 6.5.1</li> <li><a href="https://github.com/indutny/elliptic/commit/7ec66ffa255079260126d87b1762a59ea10de5ea"><code>7ec66ff</code></a> short: add infinity check before multiplying</li> <li><a href="https://github.com/indutny/elliptic/commit/ee7970b92f388e981d694be0436c4c8036b5d36c"><code>ee7970b</code></a> travis: really move on</li> <li><a href="https://github.com/indutny/elliptic/commit/637d0216b58de7edee4f3eb5641295ac323acadb"><code>637d021</code></a> travis: move on</li> <li><a href="https://github.com/indutny/elliptic/commit/5ed0babb6467cd8575a9218265473fda926d9d42"><code>5ed0bab</code></a> package: update deps</li> <li>Additional commits viewable in <a href="https://github.com/indutny/elliptic/compare/v6.4.0...v6.5.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+22 -22

2 comments

1 changed file

dependabot[bot]

pr closed time in 16 days

PullRequestReviewEvent

issue openedfacebook/flow

Disjoint union in tuple to express function arguments does not work

https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVAXAngBwKZgCCYAvGAN6phgCGAXGAM4YBOAlgHYDmqAvutnxgAYh1JgAFAG1m7bmAA+RALoBKUgD4wANzhsAJgNwEACizg5GAHkIsujLWUrUAFjQ76YeFgwkA6AJo7RgZbe3USLV0DPnQoAFcOAGMMNjgxAGE4AFscdLwODAlyMDcPLxYwXgYzC2sZVk4uRRUNdWdS909vCQByDDxmXtV0ahY8DHiWMQ54mBg+IA

Flow version: 0.132.0

Expected behavior

In the example above I would expect to be able to call handler with both a string and an object of type A.

Actual behavior

It seems like when expressed like this flow expects the argument to be both a string and of type A

created time in a month

issue commentsignavio/react-mentions

Any way to add event handlers to the mentions

Hey there. What I'd recommend is to use the renderSuggestion prop to achieve this. You can return any valid react element from this function. So in there you could also set up the handlers you've been talking about.

<Mention
  renderSuggestion={(entry, search, highlightedDisplay, index, focused) => (
    <div onMouseEnter={...} onMouseLeave={...} onClick={...} />
  )}
/>
rramaa

comment created time in 2 months

issue openedgaearon/whatthefuck.is

GDPR compliance?

Hey there! I just noticed that whatthefuck.is uses local storage and google analytics. Both would require consent of the user if I understand the GDPR guidelines correctly. If I'm wrong then please tell me because that would also make my life easier :D

https://github.com/gaearon/whatthefuck.is/blob/d1732c1829ec9ffcdd6d6dd9bec934aaef89697a/pages/_document.js#L8

created time in 2 months

issue closedwebpack/webpack

Object(...) is not a function

Bug report

What is the current behavior?

After receiving the update to 4.44.0 our application cannot start anymore. In one of our modules, we export a function as the default export. However, it seems webpack is now treating the default as an object, which then cannot be called.

If the current behavior is a bug, please provide the steps to reproduce.

I couldn't come up with a minimal repro example. However, this worked in 4.43.0 and stopped in 4.44.0 so I expect that it has something to do with the changes in that particular release.

What is the expected behavior?

Function default exports should work.

Other relevant information: webpack version: 4.44.0 Node.js version: 12.x Operating System: Whatever "Vercel" uses Additional tools: -

closed time in 2 months

frontendphil

issue commentwebpack/webpack

Object(...) is not a function

Apparently "fix bug in sideEffects optimization when using export * from "non-esm" and a default export." in the latest release was the culprit.

frontendphil

comment created time in 2 months

delete branch signavio/react-stick

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 2 months

push eventsignavio/react-stick

dependabot[bot]

commit sha 717f162088f9a55cf372f8f780b7db599d530fcb

chore(deps): bump lodash from 4.17.13 to 4.17.19 (#119) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.13 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.13...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 2 months

PR merged signavio/react-stick

chore(deps): bump lodash from 4.17.13 to 4.17.19 dependencies

Bumps lodash from 4.17.13 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.13...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -11

2 comments

1 changed file

dependabot[bot]

pr closed time in 2 months

issue openedwebpack/webpack

Object(...) is not a function

Bug report

What is the current behavior?

After receiving the update to 4.44.0 our application cannot start anymore. In one of our modules, we export a function as the default export. However, it seems webpack is now treating the default as an object, which then cannot be called.

If the current behavior is a bug, please provide the steps to reproduce.

I couldn't come up with a minimal repro example. However, this worked in 4.43.0 and stopped in 4.44.0 so I expect that it has something to do with the changes in that particular release.

What is the expected behavior?

Function default exports should work.

Other relevant information: webpack version: 4.44.0 Node.js version: 12.x Operating System: Whatever "Vercel" uses Additional tools: -

created time in 2 months

issue openedgaearon/whatthefuck.is

WTF is a tuple

<!-- Don't be shy! And vote on other people's proposals. -->

created time in 2 months

issue commentfacebook/flow

Type refinement stopped working in 0.125

I guess this one really is harder to fix than I expected :D

frontendphil

comment created time in 2 months

push eventsignavio/react-stick

renovate[bot]

commit sha 61b5791db9401bfb5795aab191c2316fdef9308e

chore(deps): update dependency flow-bin to v0.129.0 (#115) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 3 months

delete branch signavio/react-stick

delete branch : renovate/flow-bin-0.x

delete time in 3 months

PR merged signavio/react-stick

chore(deps): update dependency flow-bin to v0.129.0

This PR contains the following updates:

Package Type Update Change
flow-bin (changelog) devDependencies minor 0.128.0 -> 0.129.0

Release Notes

<details> <summary>flowtype/flow-bin</summary>

v0.129.0

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+5 -5

2 comments

2 changed files

renovate[bot]

pr closed time in 3 months

delete branch signavio/react-mentions

delete branch : fix-inline-style-position

delete time in 3 months

push eventsignavio/react-mentions

Jan-Felix

commit sha b7609a5149e65b802828e206537a0cee89b79072

fix #410 make sure the default position is absolute for pure inline styles (#415) this makes the overlay clickable again

view details

push time in 3 months

issue closedsignavio/react-mentions

onChange event for MentionsInput component captures arrow keys, but not mouse clicks

Steps to reproduce:

Using a very simple example of the MentionsInput component, with a simple onChange function instead of the recompose handlers from the examples.

This works fine for keyboard events (trigger with '@', and navigate suggestions list with arrow keys + enter). However clicking on suggestions in the list simply closes the list, rather than selecting the clicked item. And the function supplied to onChange is never called for click events.

Is there a good way to enable click events through a simple onChange function, without importing the 'recompose' handlers from the examples?

class App extends Component {
  
  constructor(){
    super()
    this.state = {
      aValue: 'beep beep',
      users: [ {id: 'walter',display: 'Walter White',}, {id: 'jesse', display: 'Jesse Pinkman',}, {id: 'gus', display: 'Gustavo "Gus" Fring',}, ]
    }
  }
  
  handleChange(event){
    console.log('change event did run')
    this.setState({
      aValue: event.target.value,
    });
  }

  render() {
    return (
      <div className="App">
        <MentionsInput
          value={this.state.aValue}
          placeholder={"Mention people using '@'"}
          onChange={this.handleChange.bind(this)}
          style={styleBlock}
        >
          <Mention data={ this.state.users } />

        </MentionsInput>
      </div>
    );
  }
}

Expected behaviour: Clicking on a suggestion will select that suggestion, or at least fire onChange event

Observed behaviour: Clicking on a suggestion closes the suggestionlist without firing onChange event

Workaround: None

closed time in 3 months

mitchizzle
more