profile
viewpoint
Philipp Giese frontendphil @signavio Potsdam, Germany https://philgiese.com

frontendphil/analyzr 6

Expertise reports for code repositories

frontendphil/OpenCanteen-PHP-Lib 1

A PHP Library for the OpenCanteen Webservice

frontendphil/Rub-the-Process 1

A little fun game designed for the iPad where you have to rub a covered process model until you freed all elements.

frontendphil/Apartment-Awesome 0

Website for the hippest apartment out there!

frontendphil/browser-cookies 0

Tiny cookies library for the browser

frontendphil/CG-Admin 0

An administration tool for a physiotherapist.

frontendphil/condition-circle 0

Checks CircleCI environment before publishing successful build using semantic-release

frontendphil/env-ci 0

Get environment variables exposed by CI services

push eventsignavio/react-stick

renovate[bot]

commit sha 61b5791db9401bfb5795aab191c2316fdef9308e

chore(deps): update dependency flow-bin to v0.129.0 (#115) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 6 days

delete branch signavio/react-stick

delete branch : renovate/flow-bin-0.x

delete time in 6 days

PR merged signavio/react-stick

chore(deps): update dependency flow-bin to v0.129.0

This PR contains the following updates:

Package Type Update Change
flow-bin (changelog) devDependencies minor 0.128.0 -> 0.129.0

Release Notes

<details> <summary>flowtype/flow-bin</summary>

v0.129.0

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+5 -5

2 comments

2 changed files

renovate[bot]

pr closed time in 6 days

delete branch signavio/react-mentions

delete branch : fix-inline-style-position

delete time in 6 days

push eventsignavio/react-mentions

Jan-Felix

commit sha b7609a5149e65b802828e206537a0cee89b79072

fix #410 make sure the default position is absolute for pure inline styles (#415) this makes the overlay clickable again

view details

push time in 6 days

issue closedsignavio/react-mentions

onChange event for MentionsInput component captures arrow keys, but not mouse clicks

Steps to reproduce:

Using a very simple example of the MentionsInput component, with a simple onChange function instead of the recompose handlers from the examples.

This works fine for keyboard events (trigger with '@', and navigate suggestions list with arrow keys + enter). However clicking on suggestions in the list simply closes the list, rather than selecting the clicked item. And the function supplied to onChange is never called for click events.

Is there a good way to enable click events through a simple onChange function, without importing the 'recompose' handlers from the examples?

class App extends Component {
  
  constructor(){
    super()
    this.state = {
      aValue: 'beep beep',
      users: [ {id: 'walter',display: 'Walter White',}, {id: 'jesse', display: 'Jesse Pinkman',}, {id: 'gus', display: 'Gustavo "Gus" Fring',}, ]
    }
  }
  
  handleChange(event){
    console.log('change event did run')
    this.setState({
      aValue: event.target.value,
    });
  }

  render() {
    return (
      <div className="App">
        <MentionsInput
          value={this.state.aValue}
          placeholder={"Mention people using '@'"}
          onChange={this.handleChange.bind(this)}
          style={styleBlock}
        >
          <Mention data={ this.state.users } />

        </MentionsInput>
      </div>
    );
  }
}

Expected behaviour: Clicking on a suggestion will select that suggestion, or at least fire onChange event

Observed behaviour: Clicking on a suggestion closes the suggestionlist without firing onChange event

Workaround: None

closed time in 6 days

mitchizzle

created tagsignavio/i18n

tagv2.1.1

Minimalist gettext style i18n for JavaScript

created time in 22 days

push eventsignavio/i18n

Philipp Giese

commit sha ed3b25422db793c63d4560781b9753f1fdc46afc

2.1.1

view details

push time in 22 days

delete branch signavio/i18n

delete branch : improvement/merge-flags

delete time in 22 days

push eventsignavio/i18n

Philipp Giese

commit sha 5f14c5accd0f00c584a9b3f5a7d168acd264490d

fix: allow passing of arbitrary flags to i18n-merge command (#63)

view details

push time in 22 days

PR merged signavio/i18n

fix: allow passing of arbitrary flags to i18n-merge command

This PR implements a pretty naïve approach to forwarding CLI flags to the msgmerge command when i18n-merge is executed.

+18 -6

0 comment

1 changed file

frontendphil

pr closed time in 22 days

create barnchsignavio/i18n

branch : improvement/merge-flags

created branch time in 22 days

issue commentbahmutov/condition-circle

breaking change in semantic-release@16

I've created this PR https://github.com/bahmutov/condition-circle/pull/23 to help fix this.

tomas-mechura

comment created time in 22 days

PR opened bahmutov/condition-circle

fix: upgrade to semantic release v16 syntax

BREAKING CHANGE: requires at least sematic-release v16

+4208 -761

0 comment

3 changed files

pr created time in 22 days

push eventfrontendphil/condition-circle

Philipp Giese

commit sha 38d614ba9eff7f17157c225da639c6741a13e81e

fix: upgrade to semantic release v16 syntax BREAKING CHANGE: requires at least `sematic-release` v16

view details

push time in 22 days

fork frontendphil/condition-circle

Checks CircleCI environment before publishing successful build using semantic-release

fork in 22 days

issue closedsignavio/kraken

useApi hook does not re-fetch after cache wipe

Describe the bug When the cache is cleared fetch requests aren't sent again. This is caused by the current logic implemented here: https://github.com/signavio/kraken/blob/master/src/hooks/createUseApi.js#L335

This doesn't account for cache wipes.

After the cache is cleared all fetch requests which aren't lazy should re-run immediately.

closed time in 25 days

frontendphil

push eventsignavio/kraken

renovate[bot]

commit sha 0750fa7a9825cb74c2f83f695adf48ed71729e39

Update dependency mocha to v8 (#430) * Update dependency mocha to v8 * update mocha setup Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Philipp Giese <giese.philipp+git@gmail.com>

view details

push time in a month

delete branch signavio/kraken

delete branch : renovate/mocha-8.x

delete time in a month

PR merged signavio/kraken

Update dependency mocha to v8

This PR contains the following updates:

Package Type Update Change
mocha (source) devDependencies major 7.2.0 -> 8.0.1

Release Notes

<details> <summary>mochajs/mocha</summary>

v8.0.1

Compare Source

The obligatory patch after a major.

:bug: Fixes

v8.0.0

Compare Source

In this major release, Mocha adds the ability to run tests in parallel. Better late than never! Please note the breaking changes detailed below.

Let's welcome @​giltayar and @​nicojs to the maintenance team!

:boom: Breaking Changes

  • #​4164: Mocha v8.0.0 now requires Node.js v10.0.0 or newer. Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 (@​UlisesGascon)

  • #​4175: Having been deprecated with a warning since v7.0.0, mocha.opts is no longer supported (@​juergba)

    :sparkles: WORKAROUND: Replace mocha.opts with a configuration file.

  • #​4260: Remove enableTimeout() (this.enableTimeout()) from the context object (@​craigtaub)

    :sparkles: WORKAROUND: Replace usage of this.enableTimeout(false) in your tests with this.timeout(0).

  • #​4315: The spec option no longer supports a comma-delimited list of files (@​juergba)

    :sparkles: WORKAROUND: Use an array instead (e.g., "spec": "foo.js,bar.js" becomes "spec": ["foo.js", "bar.js"]).

  • #​4309: Drop support for Node.js v13.x line, which is now End-of-Life (@​juergba)

  • #​4282: --forbid-only will throw an error even if exclusive tests are avoided via --grep or other means (@​arvidOtt)

  • #​4223: The context object's skip() (this.skip()) in a "before all" (before()) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites (@​juergba)

  • #​4178: Remove previously soft-deprecated APIs (@​wnghdcjfe):

    • Mocha.prototype.ignoreLeaks()
    • Mocha.prototype.useColors()
    • Mocha.prototype.useInlineDiffs()
    • Mocha.prototype.hideDiff()

:tada: Enhancements

:book: Documentation

:bug: Fixes

(All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+205 -118

2 comments

4 changed files

renovate[bot]

pr closed time in a month

push eventsignavio/kraken

Philipp Giese

commit sha 705598e53be6b12d3ba24c83ab702a45b781b2f1

update mocha setup

view details

push time in a month

push eventsignavio/kraken

renovate[bot]

commit sha bb18f6b931d4f894acac9808bcd604118f180c3f

Update dependency eslint-plugin-flowtype to v5.1.3 (#420) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in a month

delete branch signavio/kraken

delete branch : renovate/eslint-plugin-flowtype-5.x

delete time in a month

PR merged signavio/kraken

Update dependency eslint-plugin-flowtype to v5.1.3

This PR contains the following updates:

Package Type Update Change
eslint-plugin-flowtype devDependencies patch 5.1.1 -> 5.1.3

Release Notes

<details> <summary>gajus/eslint-plugin-flowtype</summary>

v5.1.3

Compare Source

Bug Fixes

v5.1.2

Compare Source

Bug Fixes
  • check type annotation context (1ec503d)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+5 -5

1 comment

2 changed files

renovate[bot]

pr closed time in a month

issue commentsignavio/kraken

useApi hook does not re-fetch after cache wipe

You can check whether changes have an effect by reverting this PR and checking whether it still works (the test suite should still be green)

frontendphil

comment created time in a month

issue commentsignavio/kraken

useApi hook does not re-fetch after cache wipe

Maybe we can somehow make that part of the request state. Whether or not the request is "initial". Then we don't need to track that as a ref in the code. Any further action then needs to set this field to something not "initial".

frontendphil

comment created time in a month

issue openedsignavio/kraken

useApi hook does not re-fetch after cache wipe

Describe the bug When the cache is cleared fetch requests aren't sent again. This is caused by the current logic implemented here: https://github.com/signavio/kraken/blob/master/src/hooks/createUseApi.js#L335

This doesn't account for cache wipes.

After the cache is cleared all fetch requests which aren't lazy should re-run immediately.

created time in a month

delete branch signavio/react-stick

delete branch : dependabot/npm_and_yarn/websocket-extensions-0.1.4

delete time in a month

push eventsignavio/react-stick

dependabot[bot]

commit sha 6c0c164012480cf417af27282f1505cfc31cc313

chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 (#88) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in a month

PR merged signavio/react-stick

chore(deps): bump websocket-extensions from 0.1.3 to 0.1.4 dependencies

Bumps websocket-extensions from 0.1.3 to 0.1.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

2 comments

1 changed file

dependabot[bot]

pr closed time in a month

issue commentfacebook/flow

Type refinement stopped working in 0.125

Suppressing isn't really an option because that would remove type-safety from some key parts of our application. We use this in some core factory functions. If we can't trust what comes out we have a problem.

When you're saying "overloading the definition of the function", how do I do that? Is that something I can do inline with the function definition? Do I need to declare the function somehow?

frontendphil

comment created time in a month

issue commentfacebook/flow

Type refinement stopped working in 0.125

Any status on that? This is halting us from upgrading to any newer flow version.

frontendphil

comment created time in a month

push eventsignavio/react-stick

renovate[bot]

commit sha b718526f27fc3981f7d2f6dca1ee7c41b5c425dd

chore(deps): update babel monorepo to v7.10.2 (#83) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in a month

delete branch signavio/react-stick

delete branch : renovate/babel-monorepo

delete time in a month

PR merged signavio/react-stick

chore(deps): update babel monorepo to v7.10.2

This PR contains the following updates:

Package Type Update Change
@babel/core (source) devDependencies patch 7.10.1 -> 7.10.2
@babel/preset-env (source) devDependencies patch 7.10.1 -> 7.10.2

Release Notes

<details> <summary>babel/babel</summary>

v7.10.2

Compare Source

:rocket: New Feature
:bug: Bug Fix
:nail_care: Polish
:house: Internal
  • babel-parser

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+43 -19

2 comments

2 changed files

renovate[bot]

pr closed time in a month

push eventfrontendphil/env-ci

Philipp Giese

commit sha f35ac8edfa263c852eb20032bd4a3b40af1cbe19

add required prettier rules to config

view details

Philipp Giese

commit sha 3e03dae65a90cfa28390a659cfd0972649b41408

adjust specs

view details

push time in 2 months

PR opened pvdlg/env-ci

fix: use head ref to determine branch of github action

Correct me if I'm wrong. I just spent a couple of hours trying to get a release preview of semantic-release working with a GitHub action. This action runs on PR events and should analyze the commits on the branch of the PR. However, semantic-release kept claiming that it would run on master and not the branch.

Then I ended up here and saw that you're using event.pull_request.base to determine the branch. If I understand the docs correctly then base is the branch the PR is targeted to, so not the branch of the PR itself.

I've therefore changed it to head. Does this make sense or am I getting something completely wrong?

+10 -10

0 comment

1 changed file

pr created time in 2 months

push eventfrontendphil/env-ci

Philipp Giese

commit sha aff27d0de17d7d7806e16855897247383db7350d

use head ref to determine branch of github action

view details

push time in 2 months

fork frontendphil/env-ci

Get environment variables exposed by CI services

fork in 2 months

issue closedfacebook/flow

Merging two variables with same indexer does not work

Flow version: 0.111

//@flow
type Indexed = { [string]: number };
const x: Indexed = {foo: 3};
const y: Indexed = {bar: 5}

const z: Indexed = {...x, ...y};

Try here

Expected behavior

I would have expected that the assignment to z works because all indexers are the same so the new variable should also work.

Actual behavior

Cannot determine a type for object literal [1]. `Indexed` [2] cannot be spread because the indexer string [3] may overwrite properties with explicit keys in a way that Flow cannot track. Can you spread `Indexed` [2] first or remove the indexer?

closed time in 2 months

frontendphil

issue commentfacebook/flow

Merging two variables with same indexer does not work

I'm closing this myself since it has been fixed in the meantime.

frontendphil

comment created time in 2 months

push eventsignavio/react-stick

renovate[bot]

commit sha a37442d95bc09f8e1368c41c805711df7be098bc

chore(deps): update dependency nwb to v0.25.2 (#68) * chore(deps): update dependency nwb to v0.25.2 * chore: bust cache Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Philipp Giese <giese.philipp+git@gmail.com>

view details

push time in 2 months

delete branch signavio/react-stick

delete branch : renovate/nwb-0.x

delete time in 2 months

PR merged signavio/react-stick

chore(deps): update dependency nwb to v0.25.2

This PR contains the following updates:

Package Type Update Change
nwb devDependencies minor 0.24.5 -> 0.25.2

Release Notes

<details> <summary>insin/nwb</summary>

v0.25.2

Compare Source

Fixed

  • Bumped Node.js version in templates.

v0.25.1

Compare Source

Changed

  • Don't include docs/ in the npm package.

v0.25.0

Compare Source

Breaking Changes

  • Node.js 8 is no longer supported; Node.js 10.13.0 is now the minimum required version, as per many of nwb's dependencies.

Browser Support

Configuration

  • Deprecated using a string for webpack.autoprefixer config to configure supported browsers - this will no longer do anything and should be moved to the new browsers config.

  • Removed support for babel.stage and webpack.uglify config deprecated in nwb v0.24.0.

  • copy-webpack-plugin v6.0.0 has breaking changes to its options which you should read if you're using webpack.copy config.

    In particular, the ignore option in a copy pattern must now be put inside the new globOptions option.

Dependencies

Added

Dependencies

  • autoprefixer: v9.7.6 → v9.8.0
  • chalk: v3.0.0 → v4.0.0
  • copy-webpack-plugin: v5.1.1 → v6.0.1
  • file-loader: v4.3.0 → v6.0.0
  • fs-extra: v8.1.0 → v9.0.0
  • karma: v4.4.1 → v5.0.9
  • karma-mocha: v1.3.0 → v2.0.1
  • terser-webpack-plugin v2.3.6 → v3.0.1
  • url-loader: v2.3.0→ v4.1.0

v0.24.7

Compare Source

Fixed

  • Fixed inclusion of __source and __self debugging information when transpiling JSX in react-component projects by defaulting process.env.NODE_ENV to 'production' when building.

Dependencies

v0.24.6

Compare Source

Dependencies

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled due to failing status checks.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+647 -1531

3 comments

3 changed files

renovate[bot]

pr closed time in 2 months

push eventsignavio/react-stick

Philipp Giese

commit sha 90e3de15e1b3d66c56f90f58fdf54a527d7fcaf0

chore: bust cache

view details

push time in 2 months

issue openedfacebook/flow

Type refinement stopped working in 0.125

Flow version: 0.125

Expected behavior

The type refinement works as expected (it did in 0.124). In the last version methods written like this produced the expected return type based on the type parameter that was passed. Now, these methods fail the type check.

Actual behavior

Type error.

  • Link to Try-Flow or Github repo: https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVAXAngBwKZgCCYAvGAN6phjb4BcYA5IY6gL7q0EBCpFVNXHgaNurDpiFgAKkICyAQxx9K1Qg0IAaAdwbd2nKQAU4AZ1MBLAEYw8s-Kb4ASANJ4spgDz28inAD5DfBkhRzJiAB8wfVQoAFcAOwBjDAs4BLAkgCc8BQw8bwYTc2tbH1N-AAouBmkASgYnAFFbAFs8BIwfb3klTRl-fmocjDisjPJBYI42IA

created time in 2 months

push eventsignavio/react-stick

Jan-Felix

commit sha 726e3f690fb042a5fb2029468d0851dc05c053d1

chore: fixed docs of `position` and `align` props (#67) Co-authored-by: Philipp Giese <giese.philipp+git@gmail.com>

view details

push time in 2 months

delete branch signavio/react-stick

delete branch : fix-props-docs

delete time in 2 months

push eventsignavio/react-stick

renovate[bot]

commit sha ba44a1ecc880f3db7048c76aa06963702ae49bc0

chore(deps): update dependency eslint-plugin-react-hooks to v4.0.1 (#69) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha f227cb0de8f648409ffb374750540e356fec18de

chore(deps): update dependency eslint-plugin-react to v7.20.0 (#70) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha bccabec26efcc7487afbf0c94f74b349174c39cd

chore(deps): update dependency eslint-plugin-react-hooks to v4.0.2 (#71) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Philipp Giese

commit sha 513396822e204647399913442fbd711d14fbc3ea

Merge branch 'master' into fix-props-docs

view details

push time in 2 months

created tagsignavio/kraken

tagv9.0.7

Make your API types easily accessible

created time in 2 months

push eventsignavio/kraken

Philipp Giese

commit sha b94aa54a937e2cd59580c804939be500f5b8da12

9.0.7

view details

push time in 2 months

push eventsignavio/kraken

Herman D

commit sha 939af6b43727ad5af1aa28b568e906be7c2f6516

Re fetch on remount using refresh (#406) * use current request state to compare refresh tokens * reorder paramters

view details

push time in 2 months

delete branch signavio/kraken

delete branch : bugfix/refresh-after-remount

delete time in 2 months

PR merged signavio/kraken

Re fetch on remount using refresh

Fixes https://github.com/signavio/workflow-client/issues/6689

+33 -8

1 comment

2 changed files

HermanDahlen

pr closed time in 2 months

Pull request review commentsignavio/kraken

Re fetch on remount using refresh

 function createUseApi(apiTypes: ApiTypeMap) {     }, [currentEntityState])      useFetchOnInitialMount(method, lazy, entityState, promiseProp)-    useReFetchOnRefresh(refresh, method, lazy, promiseProp)+    useReFetchOnRefresh(+      refresh,+      method,+      lazy,+      promiseProp,+      requestState?.refresh

Should have said this before. Can you move the requestState?.fresh in front or directly after the refresh parameter? My very personal opinion is that similar parameters should be close to another.

HermanDahlen

comment created time in 2 months

issue closedsignavio/react-stick

Development warnings about unsupported style property

Description

I'm getting console warnings when using version 3.0.2:

index.js:1 Warning: Unsupported style property &align-top. Did you mean &alignTop?

Screen Shot 2020-03-24 at 3 05 16 PM

closed time in 2 months

davi-mbatista

issue commentsignavio/react-stick

Development warnings about unsupported style property

@davi-mbatista @tzimmermann I'm going to close this issue. Neither the current dev build nor the prod build shows the warnings anymore.

davi-mbatista

comment created time in 2 months

issue commentsignavio/react-stick

Development warnings about unsupported style property

Hey @yakunins! Thanks, but the reason this didn't work correctly was a different one that had to do with the generic styling solution we're using. However, we've just upgraded it. With the new v4 you shouldn't see this behavior anymore.

davi-mbatista

comment created time in 2 months

issue closedsignavio/react-stick

Node position not updated correctly during scroll [v3 regression]

Since updating from 2.3.0 to 3.0.6, in a certain scenario (re-built in codesandbox link below), I observed the following bug:

A sticky node is not moving correctly with its anchor when scrolling horizontally. Instead, it always stays in the same (initial) position.

I built a minimal repro example here: https://codesandbox.io/s/adoring-star-lqpti

If I'd have to guess, I think that the calculateWidth function here is not doing what it should, but I am not able to fix the issue myself: https://github.com/signavio/react-stick/blob/689d09b89dabaf0a2be858a40a40a209370213ee/src/Stick.js#L230

closed time in 2 months

tzimmermann

push eventsignavio/react-stick

Philipp Giese

commit sha 1bb581cd76092307551b2edbe77a83336b2cb43e

fix: correctly adjust left scroll position in nested scroll container (#64) * fix: correctly adjust left scroll position in nested scroll container * also check for overflow='scroll' * only measure node when it is visible * chore: improve auto alignment example * chore: only render node when it has been measured in * chore: better wording for regression

view details

push time in 2 months

delete branch signavio/react-stick

delete branch : bugfix/56-scroll-position

delete time in 2 months

PR merged signavio/react-stick

fix: correctly adjust left scroll position in nested scroll container

Fixes #56

I've adjusted the calculateLeft method to look for the nearest scroll container. This fixes the reported issue. However, be aware that an absolutely positioned node will most likely overlay the scroll container. This means the node will not disappear when the anchor is scrolled away. In order to achieve this, you should use the transportTo property of the stick to mount the node inside the scroll container.

+155 -64

6 comments

4 changed files

frontendphil

pr closed time in 2 months

push eventsignavio/react-stick

Jan-Felix

commit sha a939554d7048bed7d4ce4d8c915cd4d0dccb434f

chore: upgrade to latest substyle (#52) * chore: upgrade to latest substyle BREAKING CHANGE: requires upgrade to latest versions of substyle-jss/substyle-glamor if these are used * upgrade to latest substyle * fix width handling * chore: upgrade to latest substyle version * chore: clear out unused recompose dep * chore: fix test to enforce line break closes #62 * chore: get rid of lodash dep * chore: fix flow typings * some smaller changes Co-authored-by: Philipp Giese <giese.philipp+git@gmail.com>

view details

Philipp Giese

commit sha 75c289b2d9b49f7e6703287cc807272ae6598ec9

fix: correctly adjust left scroll position in nested scroll container

view details

Philipp Giese

commit sha 22f9530435b3227afdf2c8e4ceb2adfd7b71324a

also check for overflow='scroll'

view details

Philipp Giese

commit sha 50bfe26f2d44d59c87220226386d858d6d9151bc

only measure node when it is visible

view details

Philipp Giese

commit sha 06d49dedbc977a5d9d8822a9b6e1853aff96c35c

chore: improve auto alignment example

view details

Philipp Giese

commit sha 8d59b8184a764313edcaa29a3ee5261fab31502c

chore: only render node when it has been measured in

view details

Philipp Giese

commit sha 692bb3606e7bddbea0224f2243e7b051d3657d83

chore: better wording for regression

view details

push time in 2 months

push eventsignavio/react-stick

Jan-Felix

commit sha a939554d7048bed7d4ce4d8c915cd4d0dccb434f

chore: upgrade to latest substyle (#52) * chore: upgrade to latest substyle BREAKING CHANGE: requires upgrade to latest versions of substyle-jss/substyle-glamor if these are used * upgrade to latest substyle * fix width handling * chore: upgrade to latest substyle version * chore: clear out unused recompose dep * chore: fix test to enforce line break closes #62 * chore: get rid of lodash dep * chore: fix flow typings * some smaller changes Co-authored-by: Philipp Giese <giese.philipp+git@gmail.com>

view details

push time in 2 months

delete branch signavio/react-stick

delete branch : upgrade-substyle

delete time in 2 months

issue closedsignavio/react-stick

Example does not look like how it is supposed to look

In our manual regression test suite (a.k.a the demo page) we have a scenario called "Stick node width". It specifies that the sticked node in the example at the very right must line break. However, this is broken and the node thus reaches off screen (effectively introducing a horizontal scrollbar).

I haven't investigated which version introduced the regression yet.

closed time in 2 months

jfschwarz

PR merged signavio/react-stick

chore: upgrade to latest substyle

BREAKING CHANGE: requires upgrade to latest versions of substyle-jss/substyle-glamor if these are used

+178 -289

5 comments

16 changed files

jfschwarz

pr closed time in 2 months

push eventsignavio/react-stick

renovate[bot]

commit sha 301c2e9bcf2121848a07f328663c9a754a0024b7

chore(deps): update dependency flow-bin to v0.124.0 (#63) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Philipp Giese

commit sha d7f091c57739a4548653c86127ff6185e7a0526c

Merge branch 'master' into upgrade-substyle

view details

push time in 2 months

pull request commentsignavio/react-stick

fix: correctly adjust left scroll position in nested scroll container

@tzimmermann this should now also be fixed. The node is only rendered after the initial position has been calculated. That should make this flicker go away.

frontendphil

comment created time in 2 months

push eventsignavio/react-stick

Philipp Giese

commit sha 45196aad4e45db707dbe98c57dbd476d08f79ed6

chore: improve auto alignment example

view details

Philipp Giese

commit sha 75efd7ba97639e21a3859fcba26eff8edada12b8

chore: only render node when it has been measured in

view details

Philipp Giese

commit sha 29e4fd1cb703c1be72a101e829e5fef25d9b8b1c

chore: better wording for regression

view details

push time in 2 months

issue commentsignavio/react-stick

Configure z-index

I didn't have time so far. But you're right. First off the way of styling shouldn't have changed. The major bump was only done because we required a react version that supports hooks now. The API should have stayed stable. But we might have missed the styling part since this has never been documented. I'll make a note to hopefully do that this week. That might also help some teams in our company :D

mattfelten

comment created time in 2 months

pull request commentsignavio/react-stick

fix: correctly adjust left scroll position in nested scroll container

@tzimmermann you'll need to yarn link the react and react-dom versions of your main application so that there aren't multiple versions of them.

@jfschwarz I've also snuck in a small performance improvement so that a portal node will only measure its position when the node is actually visible. This should save us quite some CPU cycles.

frontendphil

comment created time in 2 months

Pull request review commentsignavio/react-stick

fix: correctly adjust left scroll position in nested scroll container

 function calculateLeft(     return result - hostLeft   } +  if (scrollHost) {

Interestingly that doesn't seem to be the case. Look at the regression example at the bottom of the example page. Vertical scroll seems to "just work".

frontendphil

comment created time in 2 months

push eventsignavio/react-stick

Philipp Giese

commit sha 750291a9a8a5543c6c8c912206dbcaa2c31328ad

also check for overflow='scroll'

view details

Philipp Giese

commit sha d9092df3f16d9f3c3a9f8951ba791b883243b448

only measure node when it is visible

view details

push time in 2 months

Pull request review commentsignavio/react-stick

fix: correctly adjust left scroll position in nested scroll container

 function calculateLeft(     return result - hostLeft   } +  if (scrollHost) {+    return result + scrollX(nodeRef) - scrollHost.scrollLeft+  }+   return result + scrollX(nodeRef) } +function getScrollParent(element) {+  if (!element) {+    return null+  }++  if (element.nodeName === 'BODY' || element.nodeName === 'HTML') {+    return null+  }++  const style = getComputedStyle(element)++  if (style.overflowX === 'auto') {

Ah yeah... I somehow threw that away after I've typed it.

frontendphil

comment created time in 2 months

pull request commentsignavio/react-stick

fix: correctly adjust left scroll position in nested scroll container

@tzimmermann can you verify whether this fixes the issue for you?

frontendphil

comment created time in 2 months

pull request commentsignavio/react-stick

chore: upgrade to latest substyle

I'm gonna approve this PR if you also review mine ;) I've already created a v3 branch so that I can pull changes onto the latest v3 release without forcing to upgrade substyle.

jfschwarz

comment created time in 2 months

PR opened signavio/react-stick

fix: correctly adjust left scroll position in nested scroll container

Fixes #56

I've adjusted the calculateLeft method to look for the nearest scroll container. This fixes the reported issue. However, be aware that an absolutely positioned node will most likely overlay the scroll container. This means the node will not disappear when the anchor is scrolled away. In order to achieve this, you should use the transportTo property of the stick to mount the node inside the scroll container.

+96 -9

0 comment

3 changed files

pr created time in 2 months

push eventsignavio/react-stick

Philipp Giese

commit sha 824bcbc40cb4b31daca6fd36a5e595a6cfb4b722

fix: correctly adjust left scroll position in nested scroll container

view details

push time in 2 months

create barnchsignavio/react-stick

branch : bugfix/56-scroll-position

created branch time in 2 months

issue commentsignavio/react-stick

Node position not updated correctly during scroll [v3 regression]

I didn't notice there was another scroll-container. I've added a border so that I don't overlook this again https://codesandbox.io/s/summer-sun-0ykm

Now I can also reproduce this. Thinking about it now. If you need a temp workaround: set the inline prop on the Stick then it works as expected.

tzimmermann

comment created time in 2 months

issue commentsignavio/react-stick

Configure z-index

Hey there. It seems like in order to get this to work (again?) you need to nest the styles.

style={{
  node: {
    zIndex: 1000
  }
}}

I'm looking into whether we should have mentioned that in the release notes.

mattfelten

comment created time in 2 months

create barnchsignavio/react-stick

branch : v3

created branch time in 2 months

pull request commentsignavio/react-stick

chore: upgrade to latest substyle

@jfschwarz I wonder whether there will ever be a PR where you just did what you said you did. For instance, only upgrade substyle and not also change a ton of other things. Even if these are small this always makes PRs harder to review.

jfschwarz

comment created time in 2 months

push eventsignavio/react-stick

Philipp Giese

commit sha 0313de95ccffe994a2a9aed7d7724a339fa57692

some smaller changes

view details

push time in 2 months

issue commentsignavio/react-stick

Node position not updated correctly during scroll [v3 regression]

What is it exactly that is wrong? I've recorded a gif and to me, it seems like this behaves like I would have expected. Am I getting this wrong?

May-05-2020 18-09-37

tzimmermann

comment created time in 2 months

created tagsignavio/kraken

tagv9.0.6

Make your API types easily accessible

created time in 2 months

push eventsignavio/kraken

Philipp Giese

commit sha 2b9d68ec3b6c7f6e1f645566f3f144f068d7d53b

extended types for request states

view details

Philipp Giese

commit sha 179d8be05da6a9c9593c9e10c22f618043567e1a

9.0.6

view details

push time in 2 months

created tagsignavio/kraken

tagv9.0.5

Make your API types easily accessible

created time in 2 months

push eventsignavio/kraken

Philipp Giese

commit sha 740765a06637ac1358413512d46493edfa6cea7d

allow any for query

view details

Philipp Giese

commit sha 511c0aab2d20425c522954dfa5b30fea669d378a

9.0.5

view details

push time in 2 months

created tagsignavio/kraken

tagv9.0.4

Make your API types easily accessible

created time in 2 months

push eventsignavio/kraken

Philipp Giese

commit sha 8168d5e13797ba819f96ec385b5edb67a5efe474

added responseHeaders to fulfilled promise prop type

view details

Philipp Giese

commit sha c8df6fc590b7c0b91543e0f70149f3f6204af1e2

9.0.4

view details

push time in 2 months

created tagsignavio/kraken

tagv9.0.3

Make your API types easily accessible

created time in 2 months

push eventsignavio/kraken

Philipp Giese

commit sha 49d5cabbb6f86d02c8e9129c76538c6858f73f9a

9.0.3

view details

push time in 2 months

delete branch signavio/kraken

delete branch : improvement/shallow-equal

delete time in 2 months

push eventsignavio/kraken

Philipp Giese

commit sha e8737a80e933c838a0ad01f934817742973029af

add better shallow-equal comparison (#391)

view details

push time in 2 months

more