profile
viewpoint
Francisco Lourenço franciscolourenco Berlin

franciscolourenco/done 299

A fish-shell package to automatically receive notifications when long processes finish.

franciscolourenco/atea 1

A minimalistic menu bar time tracker for MacOS

franciscolourenco/CAAT 1

Canvas Advanced Animation Toolkit

franciscolourenco/Deluge-Growl 1

Growl Notification Plugin for the Deluge BitTorrent client

franciscolourenco/Dispatch-Cancel 1

Provides a cancel mechanism for delayed block dispatch

codingamigos/Amigonia 0

The new world, created by and for CodignAmigos

issue openedfastify/fastify-sensible

fastify.error()

🚀 Feature Proposal

It is harder to remember and type https status codes names, compared to numbers:

throw fastify.httpErrors.unauthorized('Incorrect password')

On the other hand the assert api is easy to read and write:

fastify.assert(false, 401, 'Incorrect password')

The proposal is to expose an error api to generate errors by status code.

fastify.error(401, 'incorrect password')

or

throw fastify.error(401, 'incorrect password')

Motivation

Make the error interface easier to use and more similar to fastify.assert()

Example

fastify.error(401, 'Incorrect password')

created time in 5 hours

issue commenthasura/graphql-engine

Granular permissions for `by_pk` queries vs multiple row queries

Any updates on this or https://github.com/hasura/graphql-engine/pull/4110? Thanks!

franciscolourenco

comment created time in 3 days

startedfoambubble/foam

started time in 7 days

issue commentfranciscolourenco/done

test: Missing argument at index 2

Thank you for catching this, and sorry for releasing with this issue. Fixed in v1.14.8

Pitasi

comment created time in 20 days

release franciscolourenco/done

1.14.8

released time in 20 days

created tagfranciscolourenco/done

tag1.14.8

A fish-shell package to automatically receive notifications when long processes finish.

created time in 20 days

push eventfranciscolourenco/done

Francisco Lourenco

commit sha c32c6f64ee5846a06fd648a7079051ff1cfcfc2d

Replace text -q with set -q (bug) Fix #86

view details

Francisco Lourenco

commit sha 9351f5a9f4ae6c73dd6f18e41364e63a77be5d90

1.14.8

view details

push time in 20 days

issue closedfranciscolourenco/done

test: Missing argument at index 2

Hi, since this morning I started to have errors at the end of every command output:

$  sleep 6; echo yay
yay
test: Missing argument at index 2

~/.config/fish/conf.d/done.fish (line 180):
                if test -q __done_notification_urgency_level
                   ^
in function '__done_ended'
in event handler: handler for generic event “fish_prompt”

(Type 'help test' for related documentation)

not sure what caused the issue. Alerts are working fine as usual (both normal and errors).

I'm using tmux 3.1b, fish 3.1.2, done 1.14.7.

closed time in 20 days

Pitasi

PR closed franciscolourenco/done

Update done.fish

propose to add -u near $urgency because on the newer version of notify-send the command will fail (notify-send version 0.7.9)

+4 -4

1 comment

1 changed file

charliemaiors

pr closed time in 21 days

pull request commentfranciscolourenco/done

Update done.fish

@charliemaiors I've released these changes in https://github.com/franciscolourenco/done/releases/tag/1.14.7. Would you mind test it out? Thanks!

charliemaiors

comment created time in 21 days

release franciscolourenco/done

1.14.7

released time in 21 days

created tagfranciscolourenco/done

tag1.14.7

A fish-shell package to automatically receive notifications when long processes finish.

created time in 21 days

delete tag franciscolourenco/done

delete tag : 1.14.7

delete time in 21 days

push eventfranciscolourenco/done

Pasquale Carlo Maiorano Picone

commit sha b8f2d048db60f888523ed616e7c88ec58a4ac46d

Add support for notify-send v0.7.9+ propose to add -u near $urgency because on the newer version of notify-send the command will fail (notify-send version 0.7.9)

view details

Francisco Lourenco

commit sha a45aa6fe7718d4aeadb39f49d8813d6e70e9ed3e

Fix urgency

view details

Francisco Lourenco

commit sha 4345e4a945bfcf69594106e4672767e6fb4498b6

1.14.7

view details

push time in 21 days

release franciscolourenco/done

1.14.7

released time in 21 days

created tagfranciscolourenco/done

tag1.14.7

A fish-shell package to automatically receive notifications when long processes finish.

created time in 21 days

issue commentHammerspoon/hammerspoon

Option to customise key repeat rate.

@megalithic I've not used Hammerspoon for a while, but I still use those settings in macOS. I could test it if it is important.

franciscolourenco

comment created time in a month

push eventfranciscolourenco/octopus

Francisco Lourenco

commit sha 4bf466bbc0c06cfc1fe18aed6a84a2e14ba49801

Fix all warnings

view details

push time in a month

push eventfranciscolourenco/octopus

Francisco Lourenco

commit sha 068ad5e77ce62166e9a38bb681bf5fffafd618df

Upgrade from Swift 3 to 5

view details

push time in a month

issue openedinikulin/replicator

Max Depth support

Is it possible to limit the serialization to a certain depth of property nesting? Thanks!

created time in a month

startedLappleApple/awesome-leading-and-managing

started time in a month

startedjmstfv/open-expenses

started time in a month

push eventfranciscolourenco/octopus

Francisco Lourenco

commit sha 5a850f181117132422ccb8b0ecc48ac497c3ffa1

Latest changes

view details

push time in a month

issue commenthasura/graphql-engine

migrate apply failed: failed parsing json: json: cannot unmarshal array into Go struct field HasuraError.internal of type hasuradb.SQLInternalError;

@scriptonist I assume that if you try to apply a migration which fails due to a computed field being based on a pgsql function which has not been defined yet, you might be able to reproduce.

  1. Create and track table
  2. Create function, without creating migration
  3. Create computed field based on function
  4. Apply migrations to a new hasura
franciscolourenco

comment created time in a month

issue openedhasura/graphql-engine

migrate apply failed: failed parsing json: json: cannot unmarshal array into Go struct field HasuraError.internal of type hasuradb.SQLInternalError;

This issue is not about the failed migration, but about the error parsing json when the migration fails.

FATA[0006] apply failed: failed parsing json: json: cannot unmarshal array into Go struct field HasuraError.internal of type hasuradb.SQLInternalError;
response from API: {"internal":[{"definition":{"definition":{"function":{"schema":"public","name":"plan"},"table_argument":null},"name":"plan","comment":"","table":{"schema":"public","name":"users"}},"reason":"in table \"users\": in computed field \"plan\": no such function exists in postgres : \"plan\"","type":"computed_field"}],"path":"$.args[36].args","error":"in table \"users\": in computed field \"plan\": no such function exists in postgres : \"plan\"","code":"constraint-violation"}

created time in a month

PR merged franciscolourenco/done

Detect focused window correctly under GNOME Shell + Wayland

The xprop strategy for checking window focus presumably works correctly when GNOME Shell is using X11. However, when GNOME Shell is using Wayland, the focused window is always reported as 0x0 regardless of what actually has focus.

My understanding is that Wayland in general does not have a "current focused window" concept at all. Any specific Wayland-based compositor might have such a concept, though. GNOME Shell does have such a concept, and exposes an API for checking the current window focus via JavaScript. We can use the session D-Bus to pass JavaScript to GNOME Shell for evaluation. This should work the same regardless of whether GNOME Shell is using Wayland or X11.

+2 -0

3 comments

1 changed file

liblit

pr closed time in 2 months

push eventfranciscolourenco/done

Ben Liblit

commit sha c2c5d40b70bd17f3fdc4d15bc610949a5cf0c477

Detect focused window correctly under GNOME Shell + Wayland The xprop strategy for checking window focus presumably works correctly when GNOME Shell is using X11. However, when GNOME Shell is using Wayland, the focused window is always reported as "0x0" regardless of what actually has focus. My understanding is that Wayland in general does not have a "current focused window" concept at all. Any specific Wayland-based compositor might have such a concept, though. GNOME Shell does have such a concept, and exposes an API for checking the current window focus via JavaScript. We can use the session D-Bus to pass JavaScript to GNOME Shell for evaluation. This should work the same regardless of whether GNOME Shell is using Wayland or X11.

view details

Francisco Lourenço

commit sha cad91110ed69b3ba6a85771f1f91df5af5c9ddd6

Merge pull request #83 from liblit/fix-window-focus-under-GNOME-Shell-and-Wayland Detect focused window correctly under GNOME Shell + Wayland

view details

push time in 2 months

pull request commentfranciscolourenco/done

Detect focused window correctly under GNOME Shell + Wayland

Thank you for the contribution!

liblit

comment created time in 2 months

push eventfranciscolourenco/done

Ben Liblit

commit sha 79acf7f7bb20562fd6f77c1bf2445755248367b5

Use correct terminal icon for Linux notifications "terminal" is not among the Freedesktop standard icon names: <https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html>. On GNOME 3.36 as shipped with Fedora 32, this results in a notification with an generic placeholder icon. The proper standard icon name is "utilities-terminal", which results in a notification with a suitable terminal icon.

view details

Francisco Lourenço

commit sha b6f6fde35e19ed55a5ca56e42c5fa820cd9f9364

Merge pull request #84 from liblit/fix-terminal-icon-under-GNOME-3.36-and-Fedora-32 Use correct terminal icon for Linux notifications

view details

push time in 2 months

PR merged franciscolourenco/done

Use correct terminal icon for Linux notifications

terminal is not among the Freedesktop standard icon names. On GNOME 3.36 as shipped with Fedora 32, this results in a notification with an generic placeholder icon:

image

The proper standard icon name is utilities-terminal, which results in a notification with a suitable terminal icon:

image

+2 -2

3 comments

1 changed file

liblit

pr closed time in 2 months

pull request commentfranciscolourenco/done

Use correct terminal icon for Linux notifications

Good enough, thank you for the PR!

liblit

comment created time in 2 months

pull request commentfranciscolourenco/done

Detect focused window correctly under GNOME Shell + Wayland

@liblit thank you for the contribution. Could you test if this is indeed also working with Gnome on x11? thanks!

liblit

comment created time in 2 months

Pull request review commentfranciscolourenco/done

Update done.fish

 if test -z "$SSH_CLIENT" # not over ssh                 end              else if type -q notify-send # Linux notify-send-                set -l urgency $__done_notification_urgency_level+                set urgency $__done_notification_urgency_level

Better keep the -l flag to define the variable as local no?

charliemaiors

comment created time in 2 months

Pull request review commentfranciscolourenco/done

Update done.fish

 if test -z "$SSH_CLIENT" # not over ssh                 end              else if type -q notify-send # Linux notify-send-                set -l urgency $__done_notification_urgency_level+                set urgency $__done_notification_urgency_level                 # override user-defined urgency level if non-zero exitstatus-                if test $exit_status -ne 0-                    set urgency "--urgency=critical"+                if test -z $urgency+                    set urgency "critical"

This is setting urgency to critical if it is not set. You probably want to set it to normal in this case.

charliemaiors

comment created time in 2 months

Pull request review commentfranciscolourenco/done

Update done.fish

 if test -z "$SSH_CLIENT" # not over ssh                 end              else if type -q notify-send # Linux notify-send-                set -l urgency $__done_notification_urgency_level+                set urgency $__done_notification_urgency_level                 # override user-defined urgency level if non-zero exitstatus-                if test $exit_status -ne 0-                    set urgency "--urgency=critical"

This is necessary to set the urgency to critical when the exit status is not zero.

charliemaiors

comment created time in 2 months

pull request commentfranciscolourenco/done

Use correct terminal icon for Linux notifications

@liblit does this have the potential of breaking the icon on other desktops? thanks!

liblit

comment created time in 2 months

issue commentfastify/fastify-sensible

customErrorHandler should not obscure original error

@Eomm the 'onError' hook will be called if you reply with an error in the error handled. From the docs:

This hook will be executed only after the customErrorHandler has been executed, and only if the customErrorHandler sends an error back to the user (Note that the default customErrorHandler always sends the error back to the user).

franciscolourenco

comment created time in 2 months

issue commentfastify/fastify-sensible

customErrorHandler should not obscure original error

Preserving the stacktrace seems to be possible without that getting exposed in the response, but how would you go about making the original message available in the hook and at the same time have the reply contain the modified error message?

franciscolourenco

comment created time in 2 months

issue openedfastify/fastify-sensible

customErrorHandler should not obscure original error

🚀 Feature Proposal

When using the onError hook to log errors to monitoring services, it would be great to have access to the original error.

However this is not currently possible with fastify-sensible customErrorHandler, because it creates a new Error with a new stacktrace for unhandled 500 errors.

Motivation

Being able to log the original error without having to disable fastify-sensible customErrorHandler

Example

fastify.addHook('onError', async (request, reply, error) => {
    Sentry.captureException(error)
}

created time in 2 months

issue openedhasura/graphql-engine

Computed fields for function without results should return null

Actual:

Querying a computed field defined by a function which returns 0 rows, results in an array with 1 element

"computed_field": [
  {
    "id": null
    "name": null
  }
]

Expected:

The computed field should be null, or an array with 0 depending on the function results a SETOF rows or a single row(https://github.com/hasura/graphql-engine/issues/4678).

"computed_field": null

OR

"computed_field": []

Notes:

This is only happening when querying using with x-hasura-admin. When querying with the user access token, I get an empty array. This could be because of extra permission filtering?

Related to https://github.com/hasura/graphql-engine/issues/4299 Related to https://github.com/hasura/graphql-engine/issues/4678

created time in 2 months

issue commentkhaosdoctor/gotql

Enum support

Thank you for creating and maintaining :) All the helper function needs to do really is return an object {value: x, escape: b}

franciscolourenco

comment created time in 2 months

issue commentkhaosdoctor/gotql

Enum support

or with a tagged template literal

import {literal} from 'gotql'

on_conflict: {
  constraint: literal`subscriptions_pkey`,
  update_columns: [literal`status`, literal`price`],
},
franciscolourenco

comment created time in 2 months

issue commentkhaosdoctor/gotql

Enum support

Thanks. It might be worth to enrich the docs with this example. This edge case makes the concept of this library a bit more verbose than expected. Have you thought of providing a helper function for escaped values? Example:

import {literal} from 'gotql'

on_conflict: {
  constraint: literal('subscriptions_pkey'),
  update_columns: literal(['status','price']),
},
franciscolourenco

comment created time in 2 months

issue commentkhaosdoctor/gotql

Enum support

on_conflict: {
  constraint: {value: 'subscriptions_pkey', escape: false},
  update_columns: {
    value: ['status', 'price'],
    escape: false,
  },
},

almost works:

on_conflict: { constraint: subscriptions_pkey, update_columns: status,price }
franciscolourenco

comment created time in 2 months

IssuesEvent

issue commentkhaosdoctor/gotql

Enum support

Re-opening because this:

on_conflict: {
  constraint: {value: 'subscriptions_pkey', escape: false},
  update_columns: [
    {value: 'status', escape: false},
    {value: 'price', escape: false},
  ],
},

results in this query:

on_conflict: { constraint: subscriptions_pkey, update_columns: [\"[object Object]\",\"[object Object]\"] })
franciscolourenco

comment created time in 2 months

issue closedkhaosdoctor/gotql

Enum support

Describe the bug Hasura's on_conflict argument expect enums to be provided without quotes, however gotql does use quotes for every argument value. This result in an error (see screenshots).

To Reproduce

gotQl.mutation(
  process.env.GRAPHQL_HOST,
  {
    operation: {
      name: 'insert_example',
      args: {
        objects: {id, status, price},
        on_conflict: {constraint: 'example_pkey', update_columns: ['status', 'price']},
      },
      fields: ['affected_rows'],
    }
  },
)

Current behavior Part of the query:

on_conflict: {constraint: \"example_pkey\", update_columns: [\"status\", \"price\"]}

Expected behavior Part of the query:

on_conflict: {constraint: example_pkey, update_columns: [status, price]}

Screenshots image image image

closed time in 2 months

franciscolourenco

issue commentkhaosdoctor/gotql

Enum support

I guess I found my answer: https://github.com/khaosdoctor/gotql#enum-args

franciscolourenco

comment created time in 2 months

issue openedkhaosdoctor/gotql

Enum support

Describe the bug Hasura's on_conflict argument expect enums to be provided without quotes, however gotql does use quotes for every argument value. This result in an error.

To Reproduce

gotQl.mutation(
  process.env.GRAPHQL_HOST,
  {
    operation: {
      name: 'insert_example',
      args: {
        objects: {id, status, price},
        on_conflict: {constraint: 'example_pkey', update_columns: ['status', 'price']},
      },
      fields: ['affected_rows'],
    }
  },
)

Current behavior Part of the query:

on_conflict: {constraint: \"example_pkey\", update_columns: [\"status\", \"price\"]}

Expected behavior Part of the query:

on_conflict: {constraint: example_pkey, update_columns: [status, price]}

Screenshots image image image

Additional context Add any other context about the problem here.

created time in 2 months

issue openedhasura/graphql-engine

Computed fields of functions which return a single row should return a single object

Actual:

Querying a computed field defined by a function which RETURNS table_name, results in an array of objects, same as if the function was defined with RETURNS SETOF tablename

"computed_field": [
  {
    "id": 1
  }
]

Expected:

A function which RETURNS table_name should result in a single object, because the function can only return a single row.

"computed_field": {
    "id": 1
}


Related to https://github.com/hasura/graphql-engine/issues/4299

created time in 2 months

issue openedkhaosdoctor/gotql

Arrays in args are treated as objects

Arrays nested inside args are translated as objects

To Reproduce

return gotQl.mutation(
  process.env.GRAPHQL_HOST,
  {
    operation: {
      name: 'insert_example',
      args: {
        objects: {id, status, price},
        on_conflict: {constraint: 'example_pkey', update_columns: ['status', 'price']},
      },
      fields: ['affected_rows'],
    }
  },
)

Current behavior Resulting query contains:

update_columns: { 0: "status", 1: "price" }

Expected behavior Resulting query contains:

update_columns: ["status", "price"]

created time in 2 months

issue commentkhaosdoctor/gotql

Arg parsing error (Cannot read property 'indexOf' of undefined)

thanks, it works 👍

franciscolourenco

comment created time in 2 months

issue closedfastify/fastify-sensible

Can't customize the message on errors with 500 status code

🐛 Bug Report

When throwing or returning errors, the custom error message is overwritten when the status code is 500. It works with other status codes like 400 or 501.

To Reproduce

Steps to reproduce the behavior:

module.exports = async function (fastify, options) {
	fastify.register(require('fastify-sensible'))

	fastify.get('/fails/1', async function (req, reply) {
		return new Error('Not working') // responds  with default error message
	})
	fastify.get('/fails/2', async function (req, reply) {
		throw new Error('Not working') // responds  with default error message
	})
	fastify.get('/fails/3', async function (req, reply) {
		reply.code(500)
		throw new Error('Not working') // responds  with default error message
	})

	fastify.get('/works/1', async function (req, reply) {
		reply.code(500)
		return 'This works'
	})
	fastify.get('/works/2', async function (req, reply) {
		reply.code(501)
		throw new Error('This works')
	})
	fastify.get('/works/3', async function (req, reply) {
		reply.code(400)
		throw new Error('This works')
	})
}

Expected behavior

The custom error message should always be respected.

Your Environment

  • node version: 12.14.0
  • fastify-cli version: 1.5.0
  • os: Mac

Moved from https://github.com/fastify/fastify/issues/2246

closed time in 2 months

franciscolourenco

issue commentfastify/fastify-sensible

Can't customize the message on errors with 500 status code

Was not aware of this feature. Thanks.

franciscolourenco

comment created time in 2 months

issue closedkhaosdoctor/gotql

response.statusCode should be a Number

Describe the bug response.statusCode is a String, but it should be a Number. All the libraries I've used so far use numbers for status codes, including nodejs. https://nodejs.org/api/http.html#http_response_statuscode

To Reproduce Make a request with gotql.query() and examinine the statusCode property of the response.

Current behavior typeof response.statusCode === 'string'

Expected behavior typeof response.statusCode === 'number'

closed time in 2 months

franciscolourenco

issue commentkhaosdoctor/gotql

response.statusCode should be a Number

Can't reproduce it anymore either, thanks!

franciscolourenco

comment created time in 2 months

issue closedfastify/fastify

Can't customize error message when statusCode is 500

🐛 Bug Report

When setting the status code to 500 in any way, it is not possible to customise the error message. Most other status codes (400, 501, etc.) works as expected.

To Reproduce

Steps to reproduce the behavior:

module.exports = async function(fastify) {
	fastify.post('/', async function(request, reply) {
		reply.code(500)
		return new Error('Hello World') // responds  with default error message
	})
}
// OR
module.exports = async function(fastify) {
	fastify.post('/', async function(request, reply) {
		reply.code(500)
		throw new Error('Hello World') // responds  with default error message
	})
}
// OR
module.exports = async function(fastify) {
	fastify.post('/', async function(request, reply) {
		const error = new Error('Hello World')
		error.statusCode = 500
		throw error  // responds  with default error message
	})
}

Expected behavior

The reply to the server should contain the customized error message

Your Environment

  • node version: v12.14.0
  • fastify version: >=2.14.0
  • os: Mac Catalina

closed time in 2 months

franciscolourenco

issue commentfastify/fastify

Can't customize error message when statusCode is 500

It seems to be fastify-sensible fault. Opened a ticket there instead with full example. Closing this one?

franciscolourenco

comment created time in 2 months

issue openedfastify/fastify-sensible

Can't customize the message on errors with 500 status code

🐛 Bug Report

When throwing or returning errors, the custom error message is overwritten when the status code is 500. It works with other status codes like 400 or 501.

To Reproduce

Steps to reproduce the behavior:

module.exports = async function (fastify, options) {
	fastify.register(require('fastify-sensible'))

	fastify.get('/fails/1', async function (req, reply) {
		return new Error('Not working') // responds  with default error message
	})
	fastify.get('/fails/2', async function (req, reply) {
		throw new Error('Not working') // responds  with default error message
	})
	fastify.get('/fails/3', async function (req, reply) {
		reply.code(500)
		throw new Error('Not working') // responds  with default error message
	})

	fastify.get('/works/1', async function (req, reply) {
		reply.code(500)
		return 'This works'
	})
	fastify.get('/works/2', async function (req, reply) {
		reply.code(501)
		throw new Error('This works')
	})
	fastify.get('/works/4', async function (req, reply) {
		reply.code(400)
		throw new Error('This works')
	})
}

Expected behavior

The custom error message should always be respected.

Your Environment

  • node version: 12.14.0
  • fastify-cli version: 1.5.0
  • os: Mac

Moved from https://github.com/fastify/fastify/issues/2246

created time in 2 months

issue openedkhaosdoctor/gotql

response.statusCode should but a Number

Describe the bug response.statusCode is a String, but it should be a Number. All the libraries I've used so far use numbers for status codes, including nodejs. https://nodejs.org/api/http.html#http_response_statuscode

To Reproduce Make a request with gotql.query() and examinine the statusCode property of the response.

Current behavior typeof response.statusCode === 'string'

Expected behavior typeof response.statusCode === 'number'

created time in 2 months

issue commentkhaosdoctor/gotql

Null arg values are not supported (Cannot read property 'indexOf' of undefined)

Thanks for answering! Just to clarify, should I look for another library in the meanwhile?

franciscolourenco

comment created time in 2 months

issue openedkhaosdoctor/gotql

Null arg values are not supported (Cannot read property 'indexOf' of undefined)

Describe the bug Null arg values are not supported (Cannot read property 'indexOf' of undefined)

To Reproduce

  return gotQl.mutation('https://example.com', {
    operation: {
      args: {
        where: {id: {_eq: userId}},
        _set: {name: null},
      },
      fields: ['affected_rows'],
    },
  })

Current behavior

Runner error: Error when executing query: Parse error: Failed to parse operation "update_users" => Cannot read property 'indexOf' of undefined

Expected behavior null values should be supported.

created time in 2 months

issue commentkhaosdoctor/gotql

Seems to choke on boolean argument values

Think this still might be an issue with null value arguments

NetOperatorWibby

comment created time in 2 months

issue openedfastify/fastify

Can't customize error message when statusCode is 500

🐛 Bug Report

When setting the status code to 500 in any way, it is not possible to customise the error message. Most other status codes (400, 501, etc.) works as expected.

To Reproduce

Steps to reproduce the behavior:

module.exports = async function(fastify) {
	fastify.post('/', async function(request, reply) {
		reply.code(500)
		return new Error('Hello World') // responds  with default error message
	})
}
// OR
module.exports = async function(fastify) {
	fastify.post('/', async function(request, reply) {
		reply.code(500)
		throw new Error('Hello World') // responds  with default error message
	})
}
// OR
module.exports = async function(fastify) {
	fastify.post('/', async function(request, reply) {
		const error = new Error('Hello World')
		error.statusCode = 500
		throw error  // responds  with default error message
	})
}

Expected behavior

The reply to the server should contain the customized error message

Your Environment

  • node version: v12.14.0
  • fastify version: >=2.14.0
  • os: Mac Catalina

created time in 2 months

Pull request review commentfranciscolourenco/done

Update done.fish

 if test -z "$SSH_CLIENT" # not over ssh                 if test $exit_status -ne 0                     set urgency "--urgency=critical"                 end-                notify-send $urgency --icon=terminal --app-name=fish "$title" "$message"+                notify-send -u $urgency --icon=terminal --app-name=fish "$title" "$message"

Point is that there might not be a urgency level defined by the user, in which case the it won't work if the command finishes with a 0 exit status

charliemaiors

comment created time in 2 months

Pull request review commentfranciscolourenco/done

Update done.fish

 if test -z "$SSH_CLIENT" # not over ssh                 if test $exit_status -ne 0                     set urgency "--urgency=critical"                 end-                notify-send $urgency --icon=terminal --app-name=fish "$title" "$message"+                notify-send -u $urgency --icon=terminal --app-name=fish "$title" "$message"

Also, favour --urgency= to -u for readability and consistency

charliemaiors

comment created time in 2 months

Pull request review commentfranciscolourenco/done

Update done.fish

 if test -z "$SSH_CLIENT" # not over ssh                 if test $exit_status -ne 0                     set urgency "--urgency=critical"                 end-                notify-send $urgency --icon=terminal --app-name=fish "$title" "$message"+                notify-send -u $urgency --icon=terminal --app-name=fish "$title" "$message"

Needs to account for empty $urgency variable

charliemaiors

comment created time in 2 months

Pull request review commentfranciscolourenco/done

Update done.fish

 if test -z "$SSH_CLIENT" # not over ssh                 if test $exit_status -ne 0                     set urgency "--urgency=critical"

This also needs to be changed, otherwise the command will fail because the option name is already built in the variable.

charliemaiors

comment created time in 2 months

release franciscolourenco/done

1.14.6

released time in 2 months

push eventfranciscolourenco/done

Francisco Lourenco

commit sha 4503af92f5425b4169d3915f7c9297437f42bfe1

1.14.6

view details

push time in 2 months

created tagfranciscolourenco/done

tag1.14.6

A fish-shell package to automatically receive notifications when long processes finish.

created time in 2 months

pull request commentfranciscolourenco/done

WSL support improvements

Thank you for the awesome contribution!

eugene-babichenko

comment created time in 2 months

push eventfranciscolourenco/done

Yevhenii Babichenko

commit sha e5efe8ecb82ebf8894bd85f5be43c3bd03697d40

WSL support improvements - Implement `__done_get_focused_window_id` on WSL as a PowerShell script. - Replace `command "$powershell_exe"` with `eval` because a variable cannot be used as a command path. - Use the `-Silent` option of BurntToast when `__done_notify_sound` is set to zero.

view details

Francisco Lourenço

commit sha 1754b50fbadbc6ccfb1a1360cd03bb26eb61a726

Merge pull request #79 from eugene-babichenko/windows-support WSL support improvements

view details

push time in 2 months

PR merged franciscolourenco/done

WSL support improvements
  • Implement __done_get_focused_window_id on WSL as a PowerShell script.
  • Replace command "$powershell_exe" with eval because a variable cannot be used as a command path.
  • Use the -Silent option of BurntToast when __done_notify_sound is set to zero.
+39 -14

5 comments

1 changed file

eugene-babichenko

pr closed time in 2 months

issue commentfranciscolourenco/done

It's doing nothing with SSH + Byobu + Fish

@ammgws I think you have a good understanding. The last part is that the user configures 3rd party service as a proxy to deliver a some stor of notification to the local machine. That 3rd party service could be a chat like Telegram, or a generic push notification app like PushBullet.

@frederickjh If I understood correctly, could you please could open a new issue for this? Thanks!

BarbzYHOOL

comment created time in 3 months

pull request commentfranciscolourenco/done

WSL support improvements

@eugene-babichenko thank you for the PR. @ammgws do you have windows setup handy to test this? would be nice to have at least a 2nd person testing before publishing. thanks!

eugene-babichenko

comment created time in 3 months

issue closedfranciscolourenco/done

done doesn't work on KDE Neon/Ubuntu 18.04

Running __done_get_focused_window_id currently returns this:

$ __done_get_focused_window_id
usage:  xprop [-options ...] [[format [dformat]] atom] ...

where options include:
    -grammar                       print out full grammar for command line
    -display host:dpy              the X server to contact
    -id id                         resource id of window to examine
    -name name                     name of window to examine
    -font name                     name of font to examine
    -remove propname               remove a property
    -set propname value            set a property to a given value
    -root                          examine the root window
    -len n                         display at most n bytes of any property
    -notype                        do not display the type field
    -fs filename                   where to look for formats for properties
    -frame                         don't ignore window manager frames
    -f propname format [dformat]   formats to use for property of given name
    -spy                           examine window properties forever

It is the results of running xprop -version 2>&1 >/dev/null at done.fish#L33. There is no option -version in KDE Neon's (which is Ubuntu 18.04-based) xprop. Commenting out that line makes it work well.

closed time in 3 months

lephuongbg

issue commentfranciscolourenco/done

done doesn't work on KDE Neon/Ubuntu 18.04

Fixed in v1.14.5, thank you @jriddy and @ammgws

lephuongbg

comment created time in 3 months

release franciscolourenco/done

1.14.5

released time in 3 months

push eventfranciscolourenco/done

Francisco Lourenco

commit sha 261629b4e46e557752a519cfedb8bedf1f77b535

1.14.5

view details

push time in 3 months

created tagfranciscolourenco/done

tag1.14.5

A fish-shell package to automatically receive notifications when long processes finish.

created time in 3 months

push eventfranciscolourenco/done

Josh Reed

commit sha 2d7a99cbe24e3545f46451831b350d1264adc724

allow xprop to be annyoingly picky about how it is asked for help

view details

Josh Reed

commit sha a838ef56454deb45e793ba8ebe06c2bb088ab255

use fish_ident's misguided formatting rules

view details

Josh Reed

commit sha 33bcfad4f56178d0f5ded46a589790e3a177fddf

use only the -grammar test to xprop

view details

Francisco Lourenço

commit sha 4b961f8c50c24323c8ba760008bc97b3109e4615

Merge pull request #78 from jriddy/bugfix/xprop-grammar.#77 Replace xprop -help with xprop -grammar

view details

push time in 3 months

PR merged franciscolourenco/done

allow xprop to be annyoingly picky about how it is asked for help

Fixes the requested re-opening of #77 which seems tied to a mis-behaving xprop config.

This just allows us to consider xprop as working if it responds correctly to either the -help or -grammar flags.

+2 -1

8 comments

1 changed file

jriddy

pr closed time in 3 months

pull request commentfranciscolourenco/done

allow xprop to be annyoingly picky about how it is asked for help

@jriddy thank you for the contribution. If grammar works consistently, should we drop -help all together?

jriddy

comment created time in 3 months

issue commentfranciscolourenco/done

done doesn't work on KDE Neon/Ubuntu 18.04

@lephuongbg what is the result of printenv DISPLAY?

lephuongbg

comment created time in 3 months

issue commentfranciscolourenco/done

done doesn't work on KDE Neon/Ubuntu 18.04

-help will fail if xprop cannot connect with the configured $DISPLAY. thats the odd behaviour which make the command be useful to us in the first place.

Is it possible that the command is failing but not because of -help, as it should?

lephuongbg

comment created time in 3 months

issue commentfranciscolourenco/done

done doesn't work on KDE Neon/Ubuntu 18.04

in which version was -grammar introduced? seems like -help and -version are only available in some versions and were introduced at different points in time.

lephuongbg

comment created time in 3 months

IssuesEvent

issue commentfranciscolourenco/done

done doesn't work on KDE Neon/Ubuntu 18.04

seriously?

lephuongbg

comment created time in 3 months

push eventfranciscolourenco/GitSavvy

Randy Lai

commit sha 8557926ebd53f9461552d7e8faecd10caec7673b

Fix: need to config username and email in appveyor

view details

Simon

commit sha b5c9277f5c9cf345da24de2d5d12624320a09ba0

Merge pull request #652 from randy3k/appveyor Fix: need to config username and email in appveyor

view details

Francisco Lourenço

commit sha da6d179a8752b3182c6acc43d24cac0b4e34743a

Enhance GitCommandFromTerminal w/ PULLREQ_EDITMSG (#650) This is used by `hub pull-request` and is identical to a commit message https://hub.github.com/ Related #402

view details

Pavel Savchenko

commit sha 8565d6ec6c8b04d57dd8b040c144269aa9ef0d50

Docs: Add OS type and version in bug information requested Often needed to debug the user's underlying systems, since both Python and Git communicate to each OS differently.

view details

Simon

commit sha 5083c637ddbdfcc7cca108054bb8fd65011b318f

Merge pull request #658 from divmain/more-req-bug-info Docs: Add OS type and version in bug information requested

view details

Simon

commit sha 7f24c951419a2155eb06cf11e35a280520c9ccb2

Housecleaning: Remove vendor folder Before sublime had a had is specifying dependencies, we manually added it here. Dependencies is specified in dependencies.json

view details

Simon

commit sha 14ffae4ed9b9b374998e4df9269f51a651e2e5f2

Move commit generation into history mixin

view details

Simon

commit sha 6c5e41bcbbf0d97a31d9d394c48567be7439303d

Enhancement: Add option for "Pick a commit" in git blame Really handy if have some changes and would like to see the blame to the lines you changed. If you would just select 'Default' it would show `not committed yet`. This is one step closer to Blame walker. Closes #654

view details

Simon

commit sha 3f05fd5a158de8a88ba1310af07b4a15bb01e71a

Enhancement: Add option for "Blame file at commit" in git log current file Closes #654

view details

Simon

commit sha 1f209f4ecf99da355844da2f5165355fc389a365

Merge pull request #656 from stoivo/blame Generally improve the git blame feature

view details

Simon

commit sha 2b10772530437f7088f8fcebdba459f05efb2c7c

Improve: In log, add seconds (#655) Useful to debug to see if there is a long running command

view details

Randy Lai

commit sha d9abb60fbd4c1355a6835526d3f2c5ee20077050

Improvement: refresh status bar and related fix (#659) * Improvement: refresh status bar less often * Fix: 1 second equals 1000 ms

view details

Adrian L Lange

commit sha 1680baa3faf86d58a9be4ccab5a02b79a4bdaa6e

Adds a setting to disable git init prompts (#665) * Add a setting to disable the git initialization prompt globally Fixes #664 * Add disable_git_init_prompt to default settings

view details

Simon

commit sha 56723e76a63d8d6e1aa32fe727ade9002c725a63

Enhancement: Show diffstat when showing a commit

view details

Simon

commit sha 1d22b927290133f82a6551b18c4a8c4944009830

Settings: New setting `show_diffstat` defaults to true

view details

Simon

commit sha a573d30df02eea629fd9ad7a5abf30f349365034

Merge pull request #672 from stoivo/diffstat Diffstat

view details

Simon

commit sha 8dccb6bb7da4dfe75a4c9c99f416ce3301ea4ba3

Fix: If refresh_gitsavvy get called without a view, it is fine (#674)

view details

Simon

commit sha 1796cc793145945ceb773609504303312af30194

Improve: Refresh blame on enter

view details

Simon

commit sha 636ce71d28be8ffafa9cdbf47861fee695b5272f

Improve: Blame, Always show the original line number Almost a reverse of commit e45527adc4854b45f434a3811c723d9f4d4dea1d Only output right side of partition if non-empty We would like to print the line number event it the content is empty. This should be fine with `Trailing Spaces`. There will still me the same amount of lines.

view details

Simon

commit sha 783b0177dbde27e5033e32b60e4f4cc666021a37

Move blame action to on enter

view details

push time in 3 months

more