profile
viewpoint
Flavius Aspra flavius Austria http://flavius-as.com Clean, testable architectures. Language doesn't matter (PHP/C/Rust/Golang/Typescript/Python/Java). I eat two technology stacks and a Linux meal a day

flavius/phpmeta 27

A PHP module for generating the AST tree of a PHP source code, useful for userland tools for static code analysis, a preprocessor, eventually meta programming (a prototype, open for suggestions)

flavius/apacheparser 1

Parse and manipulate programmatically apache configurations

flavius/batchify 1

A small tool which can run jobs concurrently or in parallel

flavius/patterns 1

A catalogue of Rust design patterns

flavius/php-multiver 1

Infrastructure for compiling and using multipe PHP versions on the same machine

flavius/businesslib 0

A library for organizing your business logic needs and algorithms

flavius/calculator 0

calculates + - / * ! operands and () from a string input

flavius/compiler-team 0

A home for compiler team planning documents, meeting minutes, and other such things.

issue commentwirecard/magento2-ee

HTTP Error 500/String could not be parsed as XML with Magento 2.3.5

@avoelkl We're totally aware of the problem. The plan is to ramp up the compatibility for all our products, and also to keep up with the compatibility thenceforth.

avoelkl

comment created time in a month

issue commentwirecard/magento2-ee

HTTP Error 500/String could not be parsed as XML with Magento 2.3.5

Hi @avoelkl

Supporting Magento 2.3.5 is planned in our backlog, but unfortunately we cannot give a hard date.

Please keep an eye on the release notes.

Kind Regards, Flavius Aspra - Shopsystems Team

avoelkl

comment created time in a month

delete branch wirecard/extension-order-state-module

delete branch : TPWDCEE-6908-feature

delete time in a month

push eventwirecard/extension-order-state-module

ozada

commit sha 9eeb1cbd43dae9af35944145d3a462e656ba4daa

Float rounding edge cases.

view details

ozada

commit sha b36484a5b44088eb9e6c3c6376869fd8092c173a

Calculate Float diff / equal with precision.

view details

ozada

commit sha 796a5fa04edc5c55304f827497665c2a1d32db15

Calculate Float diff / equal with precision.

view details

ozada

commit sha 566be5656bb6c3b36ba06b23a54bc3fbf6237a1f

Calculate Float diff / equal with precision. Fix codacy issues.

view details

ozada

commit sha 5e6423406a67c4b3b76cecc4527245f6704b530e

Calculate Float diff / equal with precision. Fix codacy issues.

view details

Flavius Aspra

commit sha 991b08e1df016528609d1e138c9decbd92580249

Merge pull request #6 from wirecard/TPWDCEE-6908-feature Tpwdcee 6908 feature

view details

push time in a month

Pull request review commentwirecard/extension-order-state-module

Tpwdcee 6908 feature

 class OrderState      */     private $mapper; +    /** @var int */+    private $precision;+     /**      * OrderState constructor.      * @param OrderStateMapper $mapper+     * @param int $precision      * @since 1.0.0      */-    public function __construct(OrderStateMapper $mapper)+    public function __construct(OrderStateMapper $mapper, $precision)

Validate $precision before storing it and throw an exception if it's not an integer.

ozada

comment created time in a month

delete branch wirecard/magento2-ee

delete branch : TPWDCEE-6733-feature

delete time in a month

push eventwirecard/magento2-ee

edra.bumci

commit sha 140f155d52542d6140de9fa809c46cad2cfb2515

Add PSD2 hint in phrase app translation files and admin credit card view

view details

Flavius Aspra

commit sha 9ed77e8bc02f17b6e066a57d6452c2a67a1070da

Merge pull request #432 from wirecard/TPWDCEE-6733-feature Add PSD2 hint in phrase app translation files and admin credit card view

view details

push time in a month

delete branch wirecard/prestashop-ee

delete branch : TPWDCEE-6496-feature

delete time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha fff809ad37adda94087a594d8db3f4a57f7c9fd9

Additional filtering of backend operations based on type

view details

Flavius Aspra

commit sha c49a7be6e3f5c418d838201c50e356e6bd05c813

Merge remote-tracking branch 'origin/RC-2.10.0-minor' into TPWDCEE-6496-feature

view details

Flavius Aspra

commit sha 28875b8c7afe41cd1212b910fbfc454992a4c0db

Mark initial transaction as closed when it's settled

view details

Flavius Aspra

commit sha 99c42ad5ca11741a0436c0656602f5c6001a05f9

Use proper object after refactoring

view details

Flavius Aspra

commit sha 6acace848f401203bb2558277f1f6db12b869d91

Display error message from the payment gateway

view details

Flavius Aspra

commit sha 2f2e31fc27a045cc11e37027cd2aeaf3f36aae97

Always use the full amount when refunding a purchase

view details

Flavius Aspra

commit sha 2b7cc5ef8f4cadabd645cca90f5d634b40552aa2

IgnorablePostProcessingFailureException does not have a message

view details

Flavius Aspra

commit sha bf4ae49f3dd8e44f89f218fee34a901076d4ef45

Take into consideration if it's parent when selecting post-processing operations

view details

Flavius Aspra

commit sha c255d3534273bda2d2629007c75bc1b2298fa6fd

Make static analysis happy

view details

Flavius Aspra

commit sha b028a4a9938c2230d649830454a52ee3f659410e

Type hinting

view details

Flavius Aspra

commit sha d4deec1625e1a105b99e52d571428a052669650d

Use the new system for managing transactions

view details

Flavius Aspra

commit sha f4beeecf47338d1762a0c23169a58fcf43d9ee39

Revert "Always use the full amount when refunding a purchase" This reverts commit 2f2e31fc27a045cc11e37027cd2aeaf3f36aae97.

view details

Flavius Aspra

commit sha 50e660b906a1410673b49ff1a367622900a130e8

Keep old behavior

view details

Flavius Aspra

commit sha 267ffb4e3f22eb66e20a83678022a43a9aab672e

Merge remote-tracking branch 'origin/RC-2.10.0-minor' into TPWDCEE-6496-feature

view details

Flavius Aspra

commit sha 1587bb162d428108a9464e7069275072e979511f

Also mark cancel void authorization as closed

view details

Flavius Aspra

commit sha 6e665703ae16ffa852fbf9a4e47a1cfb0029cb19

Add additional value for param

view details

Flavius Aspra

commit sha 7a0bbd7ada2243ea59716ba730e5dad57a265b09

Redirect in case of an error but keep cart

view details

Flavius Aspra

commit sha d599c27dce73141075c7f80a85b25e912d1cddf5

Merge pull request #344 from wirecard/TPWDCEE-6496-feature Additional filtering of backend operations based on type

view details

push time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 7a0bbd7ada2243ea59716ba730e5dad57a265b09

Redirect in case of an error but keep cart

view details

push time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 6e665703ae16ffa852fbf9a4e47a1cfb0029cb19

Add additional value for param

view details

push time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 1587bb162d428108a9464e7069275072e979511f

Also mark cancel void authorization as closed

view details

push time in a month

push eventwirecard/prestashop-ee

Sebastijan Sakac

commit sha 8cd567e308f1a311dda5d5a589a2256e79a47598

Add partial refund and capture order payment

view details

Sebastijan Sakac

commit sha a2ac2032db60092fb34a928e566d4b0830e0f2c6

Update partial capture for order payment table

view details

edra.bumci

commit sha 6a332c9c6768b05c10ff76374f48b746871f7dfd

Add requested amount to the params

view details

edra.bumci

commit sha ea819f8d96f3ea5f47b7aeb760c9173cd046dac3

Add extra condition for partially refunded

view details

edra.bumci

commit sha 26dca2bc9cfbf4095752c1d5069a3db3198d5701

Add extra condition for partially refunded

view details

Sebastijan Sakac

commit sha ca95b97c32f39e886ca6b1ca090877377e5b127c

Update partilly capture

view details

Sebastijan Sakac

commit sha 3e5a43ffa5116da6fbc619130f14050b5bf500e0

Merge branch 'TPWDCEE-6464-test' into TPWDCEE-6464-feature

view details

Sebastijan Sakac

commit sha dcf4dd7d264187eff8a4fe364f02cb276ae5256b

Add method for checking if transaction is refund

view details

Sebastijan Sakac

commit sha dc71be54eccf2d0f13ef3d681c42a589982774de

Fix codacy

view details

Sebastijan Sakac

commit sha 83f4beb792ac8a5adc2d2a558355ae10888a9e77

Add tests

view details

Sebastijan Sakac

commit sha fa00f553e912c02892aaa71396fa4a572e2d6eab

Update OrderService test

view details

Sebastijan Sakac

commit sha 4fdcac2f3d5998b8df6626fbd1e855b39d496672

Fix Order payment deletion

view details

Sebastijan Sakac

commit sha 0fc45614f416596d5431b26bdc093a1b5a3f7f6e

Merge branch 'RC-2.10.0-minor' into TPWDCEE-6464-feature

view details

Sebastijan Sakac

commit sha 41a3de16f2c5f0c8c8b3206f669487245686304b

Rename method addTransactionIdToOrder to updateOrderPayment

view details

Sebastijan Sakac

commit sha 29bc800d638b4d22ca582e42d71c06433665a06f

Merge branch 'RC-2.10.0-minor' into TPWDCEE-6464-feature

view details

Sebastijan Sakac

commit sha b01e489906d6cf1cba0cf2dcbf6af2333c8dba4e

Refactor the code

view details

Sebastijan Sakac

commit sha dad19aaf6e80aed309a7e4810d2718876cacece0

Add depricated annotation

view details

Oskar H. Zada

commit sha 1a9326c7e646459d87bd6252b5a1892a4c28429b

Merge pull request #342 from wirecard/TPWDCEE-6464-feature Add partial refund and capture order payment

view details

Flavius Aspra

commit sha 267ffb4e3f22eb66e20a83678022a43a9aab672e

Merge remote-tracking branch 'origin/RC-2.10.0-minor' into TPWDCEE-6496-feature

view details

push time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 50e660b906a1410673b49ff1a367622900a130e8

Keep old behavior

view details

push time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha b028a4a9938c2230d649830454a52ee3f659410e

Type hinting

view details

Flavius Aspra

commit sha d4deec1625e1a105b99e52d571428a052669650d

Use the new system for managing transactions

view details

Flavius Aspra

commit sha f4beeecf47338d1762a0c23169a58fcf43d9ee39

Revert "Always use the full amount when refunding a purchase" This reverts commit 2f2e31fc27a045cc11e37027cd2aeaf3f36aae97.

view details

push time in a month

Pull request review commentwirecard/prestashop-ee

Additional filtering of backend operations based on type

 public function getPossibleOperationList($returnTemplateFormat = true)             (new Logger())->error($exception->getMessage());         } -        $possibleOperations = $this->disallowCancelIfPartialOperationsDone($possibleOperations);+        $possibleOperations = $this->disallowOperationsIfPartialOperationsDone($possibleOperations);+        $isParent = empty($this->transaction->getParentTransactionId());

Line too long.

flavius

comment created time in a month

Pull request review commentwirecard/prestashop-ee

Additional filtering of backend operations based on type

 protected function processForType($processType)             $currentState,             $processType,             $this->response->getData(),-            new OrderAmountCalculatorService($this->order)+            new OrderAmountCalculatorService($this->order_service->getOrder())

It's what we discussed, reducing the number of dependencies.

flavius

comment created time in a month

issue commentPrestaShop/PrestaShop

Plans for referential integrity in the database

@PrestaShop/prestashop-core-developers Thanks for the nice history recap. So how would you like to move forward?

flavius

comment created time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha c255d3534273bda2d2629007c75bc1b2298fa6fd

Make static analysis happy

view details

push time in a month

push eventwirecard/prestashop-ee

claufruh

commit sha 2c861a1b740068055f22a91ffb72f0c7fdec55c8

Update README.md

view details

Caroline Pfoser

commit sha 5f1f906040389b650014786e298ae77d9767a406

Merge pull request #341 from wirecard/claufruh-patch-1 Change order of WPP v2 and General information

view details

tatjana.starcenko

commit sha 51a3bceb8b847fcd49d1473350b0f1dc13e34bea

Clean up travis file

view details

tatjana.starcenko

commit sha a53cc778621d5993583ff456d73c1816811f6916

Remove redundant lines from .travis file

view details

tatjana.starcenko

commit sha 76343af38f217e801842544ec4b53c2957a0c780

Use php version from Travis config

view details

tatjana.starcenko

commit sha d4bac7a594a3f715136d11fafc0a81443a936d14

Fix typo

view details

Tatjana Starcenko

commit sha c9b9c6603304ecef8aa4752819f5dc60c8971c80

Merge pull request #343 from wirecard/TPWDCEE-6739-configuration Clean up travis file

view details

Sebastijan Sakac

commit sha 329f831036c5ac21da8d2dca25b0c8ff65cc4ace

Merge branch 'master' into RC-2.10.0-minor

view details

Flavius Aspra

commit sha c49a7be6e3f5c418d838201c50e356e6bd05c813

Merge remote-tracking branch 'origin/RC-2.10.0-minor' into TPWDCEE-6496-feature

view details

Flavius Aspra

commit sha 28875b8c7afe41cd1212b910fbfc454992a4c0db

Mark initial transaction as closed when it's settled

view details

Flavius Aspra

commit sha 99c42ad5ca11741a0436c0656602f5c6001a05f9

Use proper object after refactoring

view details

Flavius Aspra

commit sha 6acace848f401203bb2558277f1f6db12b869d91

Display error message from the payment gateway

view details

Flavius Aspra

commit sha 2f2e31fc27a045cc11e37027cd2aeaf3f36aae97

Always use the full amount when refunding a purchase

view details

Flavius Aspra

commit sha 2b7cc5ef8f4cadabd645cca90f5d634b40552aa2

IgnorablePostProcessingFailureException does not have a message

view details

Flavius Aspra

commit sha bf4ae49f3dd8e44f89f218fee34a901076d4ef45

Take into consideration if it's parent when selecting post-processing operations

view details

push time in a month

PR opened wirecard/woocommerce-ee

Test automatition
+0 -0

0 comment

0 changed file

pr created time in a month

create barnchwirecard/woocommerce-ee

branch : RC-100.100.100-major

created branch time in a month

push eventwirecard/woocommerce-ee

tatjana.starcenko

commit sha 17e0566e0cba071d4028633a0ff5e2baa67c0011

Remove compatiblity legacy code and leave only one UI test run

view details

brkicadis

commit sha a1176bab5ae0b010ae2325f14b979a0c97da70dd

Add github action for checking release notes in changelog file

view details

brkicadis

commit sha 5df45f707f0d5f2e2441bb9e652bb3f41303a50d

Execute GitHub action on specific branch

view details

tatjana.starcenko

commit sha 5e8ec1965074e666f7e1bb546281f05f0dcf8902

Add adjustments for new action

view details

tatjana.starcenko

commit sha e6fca1b90ece230db8caf60490e5f948e3b6355e

Add workflow for bumping versions

view details

tatjana.starcenko

commit sha d2e5d2a810a11b7a483eebd346178d71f93ee65a

Remove version workflow

view details

tatjana.starcenko

commit sha f5d404b868cfc54c39c602cc076e7d06279537fe

Add getting tags to the workflow

view details

tatjana.starcenko

commit sha 02b3980da3b124002fbe7c3c284effa760d33e33

Update action branch

view details

Tatjana Starcenko

commit sha 6abbb6506c84e6ab9ae61b17b58091b056e7927a

Merge pull request #372 from wirecard/TPWDCEE-6751-configuration Add github action for checking release notes in changelog file

view details

tatjana.starcenko

commit sha d33cebbceb21abdbf4653bfdab30eea86d08e0e8

Bump php version in woocommerce dockerfile

view details

tatjana.starcenko

commit sha 65c97d39ad770320b8fe9a0c5e2d4d6a5a69b50c

Remove redundant lines from travis file

view details

tatjana.starcenko

commit sha df7732c6f1a08c2bdd83f22f05fcfc64ec3e9682

Use php version from travis settings for UI tests

view details

Tatjana Starcenko

commit sha fdb78ef494ae32b9d97efff36d1b55353088ccb6

Merge branch 'master' into TPWDCEE-6739-configuration

view details

Flavius Aspra

commit sha 611b11b8c584faaf6ad5b06fc803baadf8859fda

Merge pull request #373 from wirecard/TPWDCEE-6739-configuration Prepare automatic version update from single point of truth

view details

push time in a month

create barnchwirecard/prestashop-ee

branch : TPWDCEE-6496-feature

created branch time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 3a53f6ed18d1ba9ff7a554246e4e9b41824f5b59

Do not import classes from root ns

view details

push time in a month

startedplausible-insights/plausible

started time in a month

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 6574ba2da5fd969cf320d5b044d6f2d323e13511

fix based on feedback from code review

view details

Flavius Aspra

commit sha ecfea43ea946cae13c25cdce0ef5ef0a13f0fccc

Remove php 5.6 in readme

view details

push time in 2 months

Pull request review commentwirecard/prestashop-ee

Tpwdcee 6621 feature

 public function postProcess()         $delta_amount = Tools::getValue('partial-delta-amount', $parentTransaction->getAmount());          $transactionPostProcessingService = new TransactionPostProcessingService($operation, $transactionId);-        $transactionPostProcessingService->process($delta_amount);+        $transactionPostProcessingService->process((float)$delta_amount);

I'm not sure I understand the question, but this particular change is just cosmetics - casting the value to float, as it's what is defined in the docblock of the method.

The precision itself is taken from prestashop.

flavius

comment created time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 6ade9d67f87ca64d8877ed9f239e94db97f2cf3d

Add new logo image for order state authorization

view details

push time in 2 months

Pull request review commentwirecard/extension-release-info-update-action

Tpwdcee 6739 configuration

+from src.PhpVersion import PhpVersion+from src.ExtensionVersion import ExtensionVersion+from src.ShopSystemVersion import ShopSystemVersion+from src.Constants import Constants+from src.ChangelogEntry import ChangelogEntry+from src.ChangelogUpdater import ChangelogFileUpdater+from src.InternalFileUpdater import InternalFileUpdater+import argparse+import os+++def add_new_changelog_entry_and_update_internal_files(extension_name):+    """+    Updates CHANGELOG file with the new release candidate entry+    :param extension_name:+    :return:+    """+    php_version = PhpVersion(extension_name)+    extension_version = ExtensionVersion()+    print("{} Release candidate version: {} {}".format(Constants.PRETTY_LOG_ADDITION,+                                                       extension_version.get_release_candidate_version(semver=True),+                                                       Constants.PRETTY_LOG_ADDITION))+    print("{} Last released version: {} {}".format(Constants.PRETTY_LOG_ADDITION,+                                                   extension_version.get_last_released_version(semver=True),+                                                   Constants.PRETTY_LOG_ADDITION))++    shopsystem_version = ShopSystemVersion(extension_name, extension_version.get_last_released_version(semver=True))++    changelog_updater = ChangelogFileUpdater(extension_name,+                                             extension_version.get_release_candidate_version(semver=True),+                                             extension_version.get_last_released_version(semver=True),+                                             php_version.get_compatible_php_versions_from_config(),+                                             php_version.get_tested_php_versions_from_config(),+                                             shopsystem_version.get_compatible_shopsystem_versions_range(),+                                             shopsystem_version.get_tested_shopsystem_versions_range(),+                                             shopsystem_version.get_compatible_platform_versions_range(),+                                             shopsystem_version.get_tested_platform_versions_range())+    changelog_updater.add_new_release_entry_to_changelog()+    internal_file_updater = InternalFileUpdater(extension_name,+                                                extension_version.get_release_candidate_version(),+                                                extension_version.get_last_released_version(),+                                                php_version.get_compatible_php_versions_from_config(),+                                                php_version.get_tested_php_versions_from_config(),+                                                shopsystem_version.get_compatible_shopsystem_versions_range(),+                                                shopsystem_version.get_tested_shopsystem_versions_range(),+                                                shopsystem_version.get_compatible_platform_versions_range(),+                                                shopsystem_version.get_tested_platform_versions_range())+    internal_file_updater.update_files()+++if __name__ == "__main__":+    parser = argparse.ArgumentParser(description='Provide shop extension name as an argument.')+    parser.add_argument('repository', metavar='extension name', type=str,+                        help='shop extension name e.g. woocommerce-ee')+    parser.add_argument('action', metavar='action name', type=str,+                        help='the action to be performed e.g. initial_changelog_and_version_update, '+                             'check_changelog_updated',+                        choices=['initial_changelog_and_version_update', 'check_changelog_updated'])++    args = parser.parse_args()+    try:+        extension_name = Constants.EXTENSION_NAMING_CONVENTION[args.repository]+    except KeyError:+        raise Exception("Unknown extension name {}".format(args.repository))+    action = args.action+    if args.action == "initial_changelog_and_version_update":+        add_new_changelog_entry_and_update_internal_files(extension_name)++#   if action == check_changelog_updated

part of a follow-up ticket or forgotten code?

tatsta

comment created time in 2 months

Pull request review commentwirecard/extension-release-info-update-action

Tpwdcee 6739 configuration

+from src.FileActionHelper import FileActionHelper+++class ChangelogEntry:++    def __init__(self, extension, last_released_version):+        self.extension = extension+        self.last_released_version = last_released_version+        self.changelog_entries = []+        self.set_changelog_entries()++    def set_changelog_entries(self):+        """+         Sets comments from latest changelog latest entry+         """+        last_release_entry = FileActionHelper.get_changelog_markdown_entry_part(self.extension,+                                                                                self.last_released_version,+                                                                                'comments')+        comments = []+        for comment in last_release_entry.find_all('li'):+            comments.append(comment.text)+        self.changelog_entries = comments+        print(comments)

debugging statement?

tatsta

comment created time in 2 months

Pull request review commentwirecard/extension-release-info-update-action

Tpwdcee 6739 configuration

+from src.FileActionHelper import FileActionHelper+from src.Constants import Constants+++class PhpVersion:++    def __init__(self, extension):+        self.extension = extension+        self.compatible_php_versions_from_config = []+        self.tested_php_versions_from_config = []+        self.tested_php_versions_from_changelog = []+        self.compatible_php_versions_from_changelog = []+        self.set_compatible_php_version_from_config()+        self.set_tested_php_versions_from_config()++    def set_tested_php_versions_from_config(self):+        """+        Sets tested php versions from ui test settings+        """+        workflow_data = FileActionHelper.get_data_from_workflow_file(self.extension,+                                                                     Constants.UI_TEST_WORKFLOW)+        tested_php_versions = workflow_data['jobs']['include'][0]['php']+        if isinstance(tested_php_versions, list):+            for version in tested_php_versions:+                self.tested_php_versions_from_config.append(str(version))+        if isinstance(tested_php_versions, float):+            self.tested_php_versions_from_config = [str(tested_php_versions)]++    def set_compatible_php_version_from_config(self):+        """+        Sets tested php versions from unit test settings+        """+        workflow_data = FileActionHelper.get_data_from_workflow_file(self.extension,+                                                                     Constants.UNIT_TEST_WORKFLOW)+        self.compatible_php_versions_from_config = workflow_data['jobs']['run']['strategy']['matrix']['php-versions']++    def get_compatible_php_versions_from_config(self) -> list:+        """+        Returns compatible php versions from config+        :return: list+        """+        return self.compatible_php_versions_from_config++    def get_tested_php_versions_from_config(self) -> list:+        """+        Returns tested php versions from config+        :return: list+        """+        return self.tested_php_versions_from_config++    def set_tested_php_versions_from_changelog(self):+        pass

what's the goal with the empty methods?

tatsta

comment created time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 17a2b6c8f8f2533fa9691cdcb55f541140e2d8fa

Use longer variable name

view details

Flavius Aspra

commit sha aa122e3afc92911224f42a5169f61b9e124535fe

Ignore coupling warning in creational patterns

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 3a25d2872e8fbff7678fba6c4b50c91b7031312c

Reduce coupling of base failure class

view details

Flavius Aspra

commit sha 2034045bda0afca494cbb3feff8a2109999869fb

Use longer variable name

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 087c23e173fba36e0baecf1c4b73920c654a4910

CS fix

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha d170a72e21ac6a4d8c30a3dde53c9e6a23fd972e

CS fixes

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 147e6916d483ea9749330c68a20f187dd6b963d1

Improve numeric helper We can safely round the difference between two numbers because we first convert them to their integer representation.

view details

Flavius Aspra

commit sha 72892e9637ccd37638d542c86a0064fc82137164

Centralize exception handling

view details

Flavius Aspra

commit sha 0cd86422172eb6862ef63993745d02d323c0c750

Remove custom logger

view details

Flavius Aspra

commit sha a2b941db9914be144d4c62dc4a7170a481c4db82

CS fixes

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha bac3cba5caf8b9b5ee7f59a56ae96ef6c04365ce

Optimize imports

view details

push time in 2 months

push eventwirecard/prestashop-ee

edra.bumci

commit sha 8a683d68643e5e352e8427b26c45f24d8b2afebb

Adding order number as part of request data being always sent

view details

edra.bumci

commit sha f80984e5b04a58d148049ba15bee0d1b9e44816e

Adding order number as part of request data being always sent

view details

edra.bumci

commit sha 261a8237dca28456d219778b308696462c358f1c

Adding a unit test for checking that orderNumber is always sent

view details

edra.bumci

commit sha a6156bc9345246f0245e4cc1b1e0308db9d05f02

Update php style based on unit test results

view details

edra.bumci

commit sha be9e4d4318b1c2d3b713a884bdfb742ddca27cfd

Update php style based on unit test results

view details

edra.bumci

commit sha 61086b0ba31fef61461c3cc4a036d443ea0e3985

Update code based on codacy review

view details

edra.bumci

commit sha 33d0ec9c50bcb8315328fe37fd90bc25f8e189b4

Adding missing block comments

view details

edra.bumci

commit sha 18e0b8ecd6a05f3d724e5f7cfb2a02cefe761635

Merge remote-tracking branch 'origin/TPWDCEE-6244-feature' into TPWDCEE-6713-feature

view details

edra.bumci

commit sha 3b9c58ff3e1a2d60d45ce8edff6db4cf247eacac

Add solution for order payment table in prestashop order overview

view details

edra.bumci

commit sha 913f1a443ed4ac1f3403a6f1cd1023175221d74f

Fix code style for tests

view details

edra.bumci

commit sha bbd7e48461ce5a1b2a49b79966111307c079b34a

Update Transaction constants

view details

edra.bumci

commit sha 137596abd0d1ddb45d4ad4d4dcb9ce67f3b32bf5

Fix code style for tests

view details

edra.bumci

commit sha c43006d320e37fc18fa6f468bc23bde0c0c682bf

Merge remote-tracking branch 'origin/TPWDCEE-6244-feature' into TPWDCEE-6463-feature

view details

edra.bumci

commit sha 4a285f36c01e312db0c743b2dab7658840d68963

Remove unused parameter declaration

view details

edra.bumci

commit sha 7f3370594e3fed684e6545e83e7ed106706997b2

Fix code style for tests

view details

edra.bumci

commit sha 2507661fd3a71a642e2a13b14d838d9616672041

Merge remote-tracking branch 'origin/RC-2.10.0-minor' into TPWDCEE-6463-feature # Conflicts: # wirecardpaymentgateway/classes/Notification/Initial/Success.php # wirecardpaymentgateway/classes/Notification/PostProcessing/Success.php

view details

edra.bumci

commit sha 090a1df65047556e3dd69c4164100f58f262b1ba

Fix code after merge of RC

view details

edra.bumci

commit sha 2913d011620651ca5d2d9a7c4189f09a90eef8ef

Fix code after merge

view details

edra.bumci

commit sha 45c062e7cea40c0b236cf5c7e5856bd2a2f1d15a

Fix code style for tests

view details

edra.bumci

commit sha f3eb195e318d94e724f41486e2f724b06ebb948e

Decouple orderPayments from transaction

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha a40adf7e83d8a9afa6e4ae1b542d519e0dfbb5f5

Create subclasses for failure initial and post-processing operations

view details

Flavius Aspra

commit sha 9383d34e683686298f8cf467795ac85468fc8018

Restructure validation

view details

Flavius Aspra

commit sha 6ee428fbb16bc6715f50421c814c6a8db4c35c6d

Use the same php compatibility in composer as documented publicly

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 7bd34ec1914575501c96d6fa51f6eed58b5992f2

Start TPWDCEE-6621

view details

push time in 2 months

PR opened wirecard/prestashop-ee

Tpwdcee 6621 feature
+1436 -277

0 comment

50 changed files

pr created time in 2 months

create barnchwirecard/prestashop-ee

branch : TPWDCEE-6621-feature

created branch time in 2 months

startedunblevable/quick-scope

started time in 2 months

issue openedrodrimati1992/abi_stable_crates

Plugins depending on other plugins

At first sight this crate does many things I've tried to accomplish in the past 2 years in my free time, so thank you for that.

Before I dig in further, I wanted to ask if, in a plugin system, any if the plugins can get as dependency any other plugins?

Of course:

  • I would have to ensure in my application that there are no dependency cycles in the graph
  • I would need to construct my plugins in two stages, one in which they can advertise "their handle" (akin to TypeId) and a list of handles that they depend on, and the second stage in which I sort topologically the dependency graph and actually start each plugin with all the dependencies they need

If not currently possible, do you see this as a possible feature which can be planned in? Would it be before 1.0.0 or after that?

created time in 2 months

startedrodrimati1992/abi_stable_crates

started time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 98b9b98d8339e31c9c5f5fe8e34b3edd082e1393

TEST cart total

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 9478514ea6df5db1475b6205ffaf8ceabcd24cdd

Revert good fixes to the logger because of bad prestashop PSR compliance

view details

Flavius Aspra

commit sha 09504df9be5cbca078679e71c686f7cf0068d69e

fix tests

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha de598b27d5492e90cd8445f5b6c2decbbeb831ae

Improve logger

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 17227aee2e2be79476937aad7d01acf5202380aa

cleanup logger

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha d3ced0e40f7b90fe210903a493ed0cef875742b2

Fix tests

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 67333208bd40f40b1f6ed5cb9591183361e1cea0

Fix tests

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 1ae886819bea041b29a116b05616cb6b4b318527

Use configuration instead of constant

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 545786e3c7e84faec777a7a49632b86a715dc4c0

CS fixes

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 03a6655c5512c0061676b91b1fb106576b595aa2

CS fixes

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 76d6688c7f4856b4f56a8899aa3ecd3602759b0c

CS fixes

view details

Flavius Aspra

commit sha df79014cfa19af0023ae2b659e7d27e257580d1f

CS fix: long lines

view details

push time in 2 months

push eventwirecard/prestashop-ee

brkicadis

commit sha 3665e3200a5b6d5f3e755fb6330edc301b0258e1

Add change release version GitHub action

view details

Adis Brkic

commit sha 9cac183caf0675dfbfd10e7a176b0c9d47e98869

Update change-release-version.yml

view details

Tatjana Starcenko

commit sha 9b112721df0e670aa2def1443050f3555342f8dd

Merge pull request #319 from wirecard/TPWDCEE-6382-configuration Add change release version GitHub action

view details

brkicadis

commit sha fe2e039ce9d630a4dc483318165e47dbfeab6875

Add dependabot to PR lint

view details

Tomaž

commit sha a96c628c68e273ea829c7ac1de758cc03c437d46

Merge pull request #323 from wirecard/TPWDCEE-6617-configuration Add dependabot to PR lint

view details

brkicadis

commit sha 0c962421fb63c3e13481c69b573d4b55575b8bf3

Add github action to validate travis file

view details

Tatjana Starcenko

commit sha 82a8c6cbfe128c8c0a3231e2e6d12d10edea00d1

Merge pull request #324 from wirecard/TPWDCEE-5955-configuration Add github action to validate travis file

view details

brkicadis

commit sha a0abc96e57820d68a5411a5b912a9ea3d9eb3c68

Use Wirecard GitHub action and expand PR labeler

view details

Tatjana Starcenko

commit sha a4d287fe260f48664ef7c5179d18f7a6856b9cb0

Merge pull request #325 from wirecard/TPWDCEE-6670-configuration Use Wirecard GitHub action and expand PR labeler

view details

tatjana.starcenko

commit sha 1036c0b16068a1f7aea5530fa0d74f93ad9cc684

Merge branch 'master' of https://github.com/wirecard/prestashop-ee into RC-2.10.0-minor

view details

Tatjana Starcenko

commit sha bbd48f178f041a3f7509a0e79a96f751bc4d1cfe

Update pr-labeler.yml

view details

Tomaž

commit sha d5e9b8edeb9252e87553b93d1b45937bdf4068b1

Merge pull request #328 from wirecard/add-master-to-prlint-configuration Update pr-labeler.yml

view details

Tomaž

commit sha 14f6f82064ebfa81b9e5277a2c943deb2503fc4f

Merge branch 'master' into RC-2.10.0-minor

view details

tatjana.starcenko

commit sha 38814697740961c3e2b02b54ea79c3a178a1ba76

Add master to allowed PR branch names

view details

Tomaž

commit sha 96bd237cd453e313cd043741a205e15dcefba1cf

Merge pull request #330 from wirecard/TPWDCEE-6685-configuration Add master to allowed PR branch names

view details

Tatjana Starcenko

commit sha c4c44fe678360387096ac5360ed715a7df7a7797

Merge branch 'master' into RC-2.10.0-minor

view details

Flavius Aspra

commit sha 55f7922efd1730beffaa1f6eaac0403a23ef9828

Make error notifications always be an array

view details

Flavius Aspra

commit sha cb0f3d146c5e6fef5968f9625fc689692a6c48f5

Merge remote-tracking branch 'origin/RC-2.10.0-minor' into TPWDCEE-6244-feature

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 5b40f2f0887cb965ad37ccd7044f722f4dda6fcb

Cleanup logging

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 38270f58a7374fb04b906398c176278da0711f76

Translation of new order state

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha ed8a530c2c73557b42262876011df4c279c9d185

Partial refund works

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 2903b81d88fc49c6f06cab0f02a322b45a1889e1

Full refund works

view details

push time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha b0271fe894edd0eac0ead94e1bb39605f95a7465

[WIP] Broken state

view details

push time in 2 months

push eventwirecard/opencart-ee

tatjana.starcenko

commit sha 0181ae2e97239ae449c3f552c92223d5ff9e5441

Update 'validate travis' pipeline to run only on travis file change

view details

Flavius Aspra

commit sha ba56070eaf7e16bc6339d093a8ef18fad4eebf08

Merge pull request #226 from wirecard/update-travislinttrigger-configuration Update 'validate travis' pipeline to run only on travis file change

view details

push time in 2 months

delete branch wirecard/opencart-ee

delete branch : update-travislinttrigger-configuration

delete time in 2 months

delete branch wirecard/oxid-ee

delete branch : update-travislinttrigger-configuration

delete time in 2 months

push eventwirecard/oxid-ee

tatjana.starcenko

commit sha 9014e52f43c60611ff517fd0ab3d40a34dc5a498

Update 'validate travis' pipeline to run only on travis file change

view details

Flavius Aspra

commit sha a52596e2a0bf997a7c3cd5e44be010466ee2a4f2

Merge pull request #243 from wirecard/update-travislinttrigger-configuration Update 'validate travis' pipeline to run only on travis file change

view details

push time in 2 months

delete branch wirecard/shopware-ee

delete branch : update-travislinttrigger-configuration

delete time in 2 months

push eventwirecard/shopware-ee

tatjana.starcenko

commit sha 0c2576c5556f86297c5cdbac11bef1a15b270035

Update 'validate travis' pipeline to run only on travis file change

view details

Flavius Aspra

commit sha eb50568cc3b108ad46f499c197797c11e3a2cade

Merge pull request #197 from wirecard/update-travislinttrigger-configuration Update 'validate travis' pipeline to run only on travis file change

view details

push time in 2 months

delete branch wirecard/magento2-ee

delete branch : update-travislinttrigger-configuration

delete time in 2 months

push eventwirecard/magento2-ee

tatjana.starcenko

commit sha 51e903ec7d3b5d81c2e6cf3f7a0ff27048281ec2

Update 'validate travis' pipeline to run only on travis file change

view details

Flavius Aspra

commit sha f0857f6b182084556f04a983b2fd7e3e11b233da

Merge pull request #424 from wirecard/update-travislinttrigger-configuration Update 'validate travis' pipeline to run only on travis file change

view details

push time in 2 months

delete branch wirecard/prestashop-ee

delete branch : update-travislinttrigger-configuration

delete time in 2 months

push eventwirecard/prestashop-ee

tatjana.starcenko

commit sha 0dd91332d916fa6b481a185119eecb8f4e8059ab

Update validate travis pipeline to run only on travis file change

view details

Flavius Aspra

commit sha 026c1d8ec1f06671f04830a79ce0d5baeabb6fc1

Merge pull request #335 from wirecard/update-travislinttrigger-configuration Update validate travis pipeline to run only on travis file change

view details

push time in 2 months

delete branch wirecard/woocommerce-ee

delete branch : update-travislinttrigger-configuration

delete time in 2 months

push eventwirecard/prestashop-ee

Flavius Aspra

commit sha 55f7922efd1730beffaa1f6eaac0403a23ef9828

Make error notifications always be an array

view details

push time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha 89dd7b3179670bcc9bed09583dd7feefe434af63

gitignore

view details

Flavius Aspra

commit sha d08647a4091a8285e9e4b39ae0f2627499fb210c

Fix license in help

view details

push time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha 928ce18e326437aae3306978833b19fe73bc2b09

Add screenshot

view details

push time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha a60982ee0d08931bd93952ae8a5e94dc2c377748

Update issue templates

view details

Flavius Aspra

commit sha 1e61cedf45f408c27f3b28bbb49d56f0eed39996

Merge remote-tracking branch 'origin/master' into RC-0.1.0

view details

push time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha a60982ee0d08931bd93952ae8a5e94dc2c377748

Update issue templates

view details

push time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha 04028cdcb3d0530c0cf2e6e7ca14adce0a097db3

Add license

view details

push time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha c52bf0d7030a15420ff5dd027a8159761a2036b9

Finished initial draft for doc

view details

push time in 2 months

issue commentmetinorak/devSeater

Create infrastructure for database migrations

Looking over what is out there, this library seems like a good fit for this project https://ollycope.com/software/yoyo/latest/

I know that making everything from scratch is fun, but you don't create any value in terms of "dev seating" if you do this one yourself.

flavius

comment created time in 2 months

issue commentmetinorak/devSeater

Create infrastructure for database migrations

You will have files like:

sql/00_initial.sql
sql/01_featureA.sql
sql/02_featureB.sql
sql/03_bugfixC.sql
sql/04_optimizationD.sql
sql/NNN_name.sql

The names are arbitrary and purely informational, but the numbers matter.

You will only execute the files not already executed, so you need to know the number executed "last year", and start from there. If you don't know the number, you start at 0.

flavius

comment created time in 2 months

CommitCommentEvent

issue commentmetinorak/devSeater

Homepage shows signup page when I'm logged in

I realized that it logs me out. The problem is that the visual cues that you're logged out are too small.

Take for instance github:

logged out:

Screenshot 2020-05-03 at 18 08 49

logged in:

Screenshot 2020-05-03 at 18 09 18

flavius

comment created time in 2 months

issue commentmetinorak/devSeater

Create infrastructure for database migrations

Yes, do that.

But you will also make modifications to the database over time. Keep track of those modifications (also as .sql scripts, which will probably contain "ALTER TABLE" statements).

So you'll need an installation procedure (automatized) which will apply these scripts one by one.

flavius

comment created time in 2 months

issue commentvim-airline/vim-airline

Airline does not load with packadd! when cloned inside pack/visuals/opt/vim-airline

According to the docs, packadd! from .vimrc should work.

flavius

comment created time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha 838a56d6908e4450c505e6917eb1d819eeacd711

Improve docs

view details

push time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha 685529f3d2105907770015794e277339676e9b60

Restructure docs

view details

push time in 2 months

push eventflavius/vim-tabs

Flavius Aspra

commit sha 65cd9b295227258c1f3d1443bf505c6a4462435a

Update README

view details

push time in 2 months

more