profile
viewpoint
F. Hinkelmann fhinkel Google New York https://fhinkel.rocks Ph.D software engineer working on Node.js at Google. Node.js TSC member. ❤️ JavaScript.

davidmarkclements/v8-perf 248

Exploring v8 performance characteristics in Node across v8 versions 5.1, 5.8, 5.9, 6.0 and 6.1

fhinkel/AdventOfCode2018 11

https://adventofcode.com/

fhinkel/awesome-developer-streams 2

👩🏿‍💻👨🏾‍💻👩🏼‍💻👨🏽‍💻👩🏻‍💻 Awesome Developers, Streaming

fhinkel/create-download-link 2

Create a link to download a text file.

fhinkel/abi-stable-node 1

NAPI — Node with PoC ABI stable API for native modules.

fhinkel/Battleship-JavaScript 1

A very very simple Battleship game written in plain JavaScript

fhinkel/beertopeer 1

Real-time, cross-border, multi-currency, and low-cost payments by leveraging existing crypto currency technologies

fhinkel/broadcasters 1

iPlant Viewer-Editor integration framework

pull request commentgoogle/eventid-js

build: use GitHub Actions

Someone with admin rights needs to change the branch protection rules for the new CI.

JustinBeckwith

comment created time in a day

push eventGoogleCloudPlatform/nodejs-getting-started

WhiteSource Renovate

commit sha d3486dafa5e4c2487e5d8c452d01b73c180295c1

fix(deps): update dependency @google-cloud/firestore to v3 (#372)

view details

push time in a day

PR merged GoogleCloudPlatform/nodejs-getting-started

fix(deps): update dependency @google-cloud/firestore to v3 cla: yes kokoro:force-run kokoro:run

This PR contains the following updates:

Package Type Update Change
@google-cloud/firestore dependencies major ^2.0.0 -> ^3.0.0
@google-cloud/firestore dependencies major ^1.0.0 -> ^3.0.0

Release Notes

<details> <summary>googleapis/nodejs-firestore</summary>

v3.5.1

Compare Source

v3.5.0

Compare Source

Features
Bug Fixes
  • add missing generics on query (#​917) (c5b9442)
  • better parameter naming in path template helpers (aac02f4)
  • retry streaming methods if initial write errored (#​897) (2ec0489)
3.4.1 (2020-01-22)
Bug Fixes
  • do not assume all custom objects have constructors (#​893) (f668e8e)

v3.4.1

Compare Source

Features
Bug Fixes
  • add missing generics on query (#​917) (c5b9442)
  • better parameter naming in path template helpers (aac02f4)
  • retry streaming methods if initial write errored (#​897) (2ec0489)
3.4.1 (2020-01-22)
Bug Fixes
  • do not assume all custom objects have constructors (#​893) (f668e8e)

v3.4.0

Compare Source

Features
Bug Fixes
3.3.4 (2020-01-12)
Bug Fixes
3.3.3 (2020-01-08)
Bug Fixes
3.3.2 (2020-01-06)
Bug Fixes
3.3.1 (2020-01-06)
Bug Fixes
  • don't recreate instances when client is idle (0aa2a8b)

v3.3.4

Compare Source

Features
Bug Fixes
3.3.4 (2020-01-12)
Bug Fixes
3.3.3 (2020-01-08)
Bug Fixes
3.3.2 (2020-01-06)
Bug Fixes
3.3.1 (2020-01-06)
Bug Fixes
  • don't recreate instances when client is idle (0aa2a8b)

v3.3.3

Compare Source

v3.3.2

Compare Source

v3.3.1

Compare Source

v3.3.0

Compare Source

Features
Bug Fixes

v3.2.0

Compare Source

Features
Bug Fixes

v3.1.0

Compare Source

Features
  • allow specifying how many idle GRPC channels to keep (#​837) (37e93da)
Bug Fixes
  • reduce overhead for listDocuments()/listCollections() (#​838) (5c870e6)

v3.0.0

Compare Source

Features
Bug Fixes

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

4 changed files

renovate-bot

pr closed time in a day

push eventGoogleCloudPlatform/nodejs-getting-started

WhiteSource Renovate

commit sha 16e96fd9e9a8faf00d338cc136c6720e75d52a15

chore(deps): update dependency eslint-plugin-node to v11 (#370)

view details

push time in a day

PR merged GoogleCloudPlatform/nodejs-getting-started

chore(deps): update dependency eslint-plugin-node to v11 cla: yes kokoro:force-run

This PR contains the following updates:

Package Type Update Change
eslint-plugin-node devDependencies major ^10.0.0 -> ^11.0.0

Release Notes

<details> <summary>mysticatea/eslint-plugin-node</summary>

v11.0.0

Compare Source

💥 Breaking changes

  • b6cb9a0 updated node/no-unsupported-features/node-builtins rule based on Node.js 13.2.0.
  • fb9ce15 updated node/no-unsupported-features/es-syntax rule to recognize BigInt literal property names.
  • 4295f6a updated the rules that check global variables to recognize globalThis.*.
  • 04051ed updated node/no-unsupported-features/es-builtins rule to recognize globalThis.

✨ Enhancements

  • 276a9ad updated node/no-deprecated-api rule to allow revoked deprecations.
  • 972f828 updated node/no-unsupported-features/node-builtins rule to handle backporting properly.

🐛 Bug fixes

  • 4f74fbf fixed a crash bug around dynamic import syntax.

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is stale, or if you tick the rebase/retry checkbox below.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate-bot

pr closed time in a day

delete branch GoogleCloudPlatform/nodejs-docs-samples

delete branch : nor1

delete time in 2 days

push eventGoogleCloudPlatform/nodejs-docs-samples

Justin Beckwith

commit sha f9e24c40176e3a188935f55ae0a71b494ecd284c

test: reduce request usage (#1606) * test: reduce request usage * cleanup * make deterministic Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

push time in 2 days

PR merged GoogleCloudPlatform/nodejs-docs-samples

Reviewers
test: reduce request usage cla: yes kokoro:run

The request module is officially deprecated: https://www.npmjs.com/package/request

This is removing one usage of it, and replacing it with gaxios. Hope is that we can use this as a template for others to make this change as we go along as well.

This change also includes:

  • removing unused supertest package
  • doing a deterministic wait on the host/port, instead of counting on retries
+49 -49

0 comment

2 changed files

JustinBeckwith

pr closed time in 2 days

issue commentGoogleCloudPlatform/nodejs-docs-samples

Help with token service GCF

👋 @mhr78 Thanks for opening the issue. @nnegrey could you have a look please. Thanks.

mhr78

comment created time in 2 days

issue commentGoogleCloudPlatform/nodejs-docs-samples

[nodejs-docs-samples/functions/scheduleinstance/index.js] How to configure projectId to control other project's vm?

👋 @team-jinhong-kim Thanks for opening the issue. @djmailhot could you have a look please. Thanks.

team-jinhong-kim

comment created time in 2 days

PR merged GoogleCloudPlatform/nodejs-docs-samples

fix: reduce request usage cla: yes

Request is now deprecated. This moves the sample over to using gaxios, along with other cleanup.

+14 -19

0 comment

3 changed files

JustinBeckwith

pr closed time in 2 days

push eventGoogleCloudPlatform/nodejs-docs-samples

Justin Beckwith

commit sha 89f5f291cca5912e649adf2bef0599cd61a0c40c

fix: reduce request usage (#1607) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

F. Hinkelmann

commit sha 0e9eee489d091a83e31ce085586bf2af665316c9

Merge branch 'master' into nor1

view details

push time in 2 days

delete branch GoogleCloudPlatform/nodejs-docs-samples

delete branch : nor2

delete time in 2 days

push eventGoogleCloudPlatform/nodejs-docs-samples

Justin Beckwith

commit sha 89f5f291cca5912e649adf2bef0599cd61a0c40c

fix: reduce request usage (#1607) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

push time in 2 days

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 1b9c980f798cc85843095a4e7fae35e375ad1281

fix(deps): update dependency @opencensus/exporter-stackdriver to ^0.0.20 (#1609)

view details

F. Hinkelmann

commit sha 5437559605902a7a8bf69f0ba413b513037ea94f

Merge branch 'master' into nor2

view details

push time in 2 days

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 518968588a81014e8b492c7fc949788e3559b45e

chore(deps): update dependency sinon to v9

view details

Ace Nassri

commit sha bcb76b9230fd24c947f1e0e3ff6a3d45a578fb9f

Update {dialogflow -> tokenservice} functions CODEOWNERS (#1613)

view details

WhiteSource Renovate

commit sha 78f0f9653ebded63ff8bff6faeca9a8ffdab21ec

fix(deps): update dependency @opencensus/core to ^0.0.20 (#1608)

view details

WhiteSource Renovate

commit sha 1b9c980f798cc85843095a4e7fae35e375ad1281

fix(deps): update dependency @opencensus/exporter-stackdriver to ^0.0.20 (#1609)

view details

F. Hinkelmann

commit sha ecdf51d546b0691f7bce669b36798e04a541554e

Merge branch 'master' into nor1

view details

push time in 2 days

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 1b9c980f798cc85843095a4e7fae35e375ad1281

fix(deps): update dependency @opencensus/exporter-stackdriver to ^0.0.20 (#1609)

view details

push time in 2 days

PR merged GoogleCloudPlatform/nodejs-docs-samples

fix(deps): update dependency @opencensus/exporter-stackdriver to ^0.0.20 cla: yes

This PR contains the following updates:

Package Type Update Change
@opencensus/exporter-stackdriver dependencies patch ^0.0.19 -> ^0.0.20

Release Notes

<details> <summary>census-instrumentation/opencensus-node</summary>

v0.0.20

Compare Source

2c40254 fix(resources): GKE pod name label (#​728) a6381af chore: update dependency grpc to 1.24.2 (#​750) b6e6814 fix: core version (#​753) 7f1cddb chore(deps): bump handlebars (#​719)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate-bot

pr closed time in 2 days

push eventrenovate-bot/nodejs-docs-samples

Ace Nassri

commit sha bcb76b9230fd24c947f1e0e3ff6a3d45a578fb9f

Update {dialogflow -> tokenservice} functions CODEOWNERS (#1613)

view details

WhiteSource Renovate

commit sha 78f0f9653ebded63ff8bff6faeca9a8ffdab21ec

fix(deps): update dependency @opencensus/core to ^0.0.20 (#1608)

view details

F. Hinkelmann

commit sha b4d1ac8fc84cd99f6b59dd4cc167ba792599371e

Merge branch 'master' into renovate/uuid-7.x

view details

push time in 2 days

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 78f0f9653ebded63ff8bff6faeca9a8ffdab21ec

fix(deps): update dependency @opencensus/core to ^0.0.20 (#1608)

view details

push time in 2 days

PR merged GoogleCloudPlatform/nodejs-docs-samples

fix(deps): update dependency @opencensus/core to ^0.0.20 cla: yes

This PR contains the following updates:

Package Type Update Change
@opencensus/core dependencies patch ^0.0.19 -> ^0.0.20

Release Notes

<details> <summary>census-instrumentation/opencensus-node</summary>

v0.0.20

Compare Source

2c40254 fix(resources): GKE pod name label (#​728) a6381af chore: update dependency grpc to 1.24.2 (#​750) b6e6814 fix: core version (#​753) 7f1cddb chore(deps): bump handlebars (#​719)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate-bot

pr closed time in 2 days

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 518968588a81014e8b492c7fc949788e3559b45e

chore(deps): update dependency sinon to v9

view details

Ace Nassri

commit sha bcb76b9230fd24c947f1e0e3ff6a3d45a578fb9f

Update {dialogflow -> tokenservice} functions CODEOWNERS (#1613)

view details

F. Hinkelmann

commit sha efc766b0350edd6daba2e535d9700151ae45d5c3

Merge branch 'master' into nor2

view details

push time in 2 days

pull request commentGoogleCloudPlatform/nodejs-docs-samples

test: modernize mocha config

Closing due to inactivity. Please re-open if needed.

JustinBeckwith

comment created time in 2 days

issue closedGoogleCloudPlatform/nodejs-docs-samples

Internal CI (run/hello-broken) - Tests failed

I've noticed Internal CI (run/hello-broken) is breaking the CI pipeline and preventing unrelated changes to be merged. I'm not familiar with Cloud Run samples, but investigating the error logs generated for a PR I submitted earlier, it turns out Broken resource uses the NAME override might be the culprit.

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/6f31b840cb314eccf59b9304c68ca80c85646c13/run/hello-broken/test/system.test.js#L79-L91

Would you be able to take a look at this?

Thanks!

closed time in 13 days

ricardolsmendes

issue commentGoogleCloudPlatform/nodejs-docs-samples

Internal CI (run/hello-broken) - Tests failed

We know that those tests fail, that's why they're optional for merging.

@grayside any thought on when they'll be fixed?

ricardolsmendes

comment created time in 13 days

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 794c2689b6d50a50b04ce672a746e59625c9b66c

chore(deps): update dependency mocha to v7 (#1604) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

push time in 13 days

PR merged GoogleCloudPlatform/nodejs-docs-samples

chore(deps): update dependency mocha to v7 cla: yes

This PR contains the following updates:

Package Type Update Change
mocha (source) devDependencies major ^6.0.0 -> ^7.0.0

Release Notes

<details> <summary>mochajs/mocha</summary>

v7.0.1

Compare Source

:bug: Fixes

:book: Documentation

:nut_and_bolt: Other

v7.0.0

Compare Source

:boom: Breaking Changes

  • #​3885: Drop Node.js v6.x support (@​mojosoeun)
  • #​3890: Remove Node.js debug-related flags --debug/--debug-brk and deprecate debug argument (@​juergba)
  • #​3962: Changes to command-line options (@​ParkSB):
    • --list-interfaces replaces --interfaces
    • --list-reporters replaces --reporters
  • Hook pattern of this.skip() (@​juergba):
    • #​3859: When conditionally skipping in a it test, related afterEach hooks are now executed
    • #​3741: When conditionally skipping in a beforeEach hook, subsequent inner beforeEach hooks are now skipped and related afterEach hooks are executed
    • #​4136: Disallow this.skip() within after hooks
  • #​3967: Remove deprecated getOptions() and lib/cli/options.js (@​juergba)
  • #​4083: Uncaught exception in pending test: don't swallow, but retrospectively fail the test for correct exit code (@​juergba)
  • #​4004: Align Mocha constructor's option names with command-line options (@​juergba)

:tada: Enhancements

  • #​3980: Refactor and improve --watch mode with chokidar (@​geigerzaehler):
    • adds command-line options --watch-files and --watch-ignore
    • removes --watch-extensions
  • #​3979: Type "rs\n" to restart tests (@​broofa)

:fax: Deprecations

These are soft-deprecated, and will emit a warning upon use. Support will be removed in (likely) the next major version of Mocha:

:bug: Fixes

:mag: Coverage

:book: Documentation

:nut_and_bolt: Other

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is stale, or if you tick the rebase/retry checkbox below.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate-bot

pr closed time in 13 days

push eventrenovate-bot/nodejs-docs-samples

Ricardo Mendes

commit sha f4e200bd0745d6cfb25ba50e47d1d0a09eafa751

Add delete fileset Entry sample (#1569) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com> Co-authored-by: Marcelo Costa <mycelo19@gmail.com>

view details

F. Hinkelmann

commit sha 1c2aab9e9b657cb462e4d60138ed2c902703bb79

Merge branch 'master' into renovate/mocha-7.x

view details

push time in 13 days

push eventGoogleCloudPlatform/nodejs-docs-samples

Ricardo Mendes

commit sha f4e200bd0745d6cfb25ba50e47d1d0a09eafa751

Add delete fileset Entry sample (#1569) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com> Co-authored-by: Marcelo Costa <mycelo19@gmail.com>

view details

push time in 13 days

PR merged GoogleCloudPlatform/nodejs-docs-samples

Data Catalog: add delete fileset Entry sample cla: yes

Fileset operations were added to Data Catalog's API and the client library now supports them. Samples are required to update the official docs.

+146 -0

3 comments

2 changed files

ricardolsmendes

pr closed time in 13 days

pull request commentGoogleCloudPlatform/nodejs-docs-samples

Data Catalog: add delete fileset Entry sample

Sounds good to me!

ricardolsmendes

comment created time in 13 days

push eventricardolsmendes/nodejs-docs-samples

Ricardo Mendes

commit sha c5883ca67d38e739f6e60811cb149d3777b1648f

Data Catalog: add create fileset Entry sample (#1568) * Add create fileset Entry sample * Upgrade Data Catalog library Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com> Co-authored-by: Marcelo Costa <mycelo19@gmail.com>

view details

F. Hinkelmann

commit sha 6e8ac1ef587304f551d337c51d0ace5aa867910e

Merge branch 'master' into task/add-delete-entry-sample

view details

push time in 13 days

push eventGoogleCloudPlatform/nodejs-docs-samples

Ricardo Mendes

commit sha c5883ca67d38e739f6e60811cb149d3777b1648f

Data Catalog: add create fileset Entry sample (#1568) * Add create fileset Entry sample * Upgrade Data Catalog library Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com> Co-authored-by: Marcelo Costa <mycelo19@gmail.com>

view details

push time in 13 days

PR merged GoogleCloudPlatform/nodejs-docs-samples

Data Catalog: add create fileset Entry sample cla: yes

Fileset operations were added to Data Catalog's API and the client library now supports them. Samples are required to update the official docs.

+225 -0

2 comments

3 changed files

ricardolsmendes

pr closed time in 13 days

push eventricardolsmendes/nodejs-docs-samples

WhiteSource Renovate

commit sha 6f31b840cb314eccf59b9304c68ca80c85646c13

fix(deps): update dependency redis to v3 (#1601)

view details

F. Hinkelmann

commit sha 7b4b0e02ebc88b8460b69b117e09b558de6feda9

Merge branch 'master' into task/add-delete-entry-sample

view details

push time in 15 days

issue closedGoogleCloudPlatform/nodejs-docs-samples

Deployment failure: Function failed on loading user code.

Deployment failure: Function failed on loading user code. Error message: Code in file index.js can't be loaded. Did you list all required modules in the package.json dependencies? Detailed stack trace: Error: Cannot find module '@google-cloud/language'

closed time in 15 days

arashokbabu

issue closedGoogleCloudPlatform/nodejs-docs-samples

connection pooling problem

Hi,

I tried your suggestion but it does not work as-is:

// [START functions_tips_connection_pooling]
const http = require('http');
const agent = new http.Agent({keepAlive: true});

/**
 * HTTP Cloud Function that caches an HTTP agent to pool HTTP connections.
 *
 * @param {Object} req Cloud Function request context.
 * @param {Object} res Cloud Function response context.
 */
exports.connectionPooling = (req, res) => {
  req = http.request(
    {
      host: '',
      port: 80,
      path: '',
      method: 'GET',
      agent: agent,
    },
    resInner => {
      let rawData = '';
      resInner.setEncoding('utf8');
      resInner.on('data', chunk => {
        rawData += chunk;
      });
      resInner.on('end', () => {
        res.status(200).send(`Data: ${rawData}`);
      });
    }
  );
  req.on('error', e => {
    res.status(500).send(`Error: ${e.message}`);
  });
  req.end();
};
// [END functions_tips_connection_pooling]

(1) http is not allowed.

Likely solution: the port error disappears when using https instead i.e.

const https = require('https'); ...

(2) I tried different settings of options to https.request(options, ...) but I could not get any to work.

For example:

const options = 
    { "method": "POST",
      "protocol": "https:", 
      "host": "https://us-central1-[my_project_id].cloudfunctions.net", 
      "hostname": "https://us-central1-[my_project_id].cloudfunctions.net", 
      "agent": agent,
      "path": "",
      "port": "",
      "headers": { "Content-Type": "application/json" } 
    }

resulted in error message:

Error: getaddrinfo ENOTFOUND https://us-central1-[my_project_id].cloudfunctions.net https://us-central1-[my_project_id].cloudfunctions.net:443

(3) I searched for a solution and found this: https://github.com/expressjs/express/issues/3556 i.e. not to use your require("https") approach but to simply utilize the expressjs functionality by adding e.g.:

exports.connectionPooling = (req, res) => {
  
    res.set("Access-Control-Allow-Origin", "*");
  
    req.socket.setKeepAlive({"enable": true})

   ...

(4)

I tried to run artillery with a POST json request that but could not see any gains with and without req.socket.setKeepAlive({"enable": true})

Here is the artillery .yml I used:

config:
  target: "https://us-central1-[my_project_id].cloudfunctions.net/connectionPooling"
  phases:
    - duration: 10
      arrivalRate: 30
scenarios:
    - flow:
      - post:
          url: "/"
          json:
            request: '{"request": [1,"yes", true]}'

Please advice, thanks :)

closed time in 15 days

SinanGabel

issue commentGoogleCloudPlatform/nodejs-docs-samples

functions/composer-storage-trigger/index.js sends nonexistent argument "iap.jwt" to "makeIapPostRequest"

@ace-n , could you have a look at this functions sample? Thanks

starmandeluxe

comment created time in 15 days

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 6f31b840cb314eccf59b9304c68ca80c85646c13

fix(deps): update dependency redis to v3 (#1601)

view details

push time in 15 days

PR merged GoogleCloudPlatform/nodejs-docs-samples

Reviewers
fix(deps): update dependency redis to v3 cla: yes kokoro:run

This PR contains the following updates:

Package Type Update Change
redis dependencies major ^2.8.0 -> ^3.0.0

Release Notes

<details> <summary>NodeRedis/node-redis</summary>

v3.0.2

Compare Source

v3.0.1

Compare Source

v3.0.0

Compare Source

This version is mainly a release to distribute all the unreleased changes on master since 2017 and additionally removes a lot of old deprecated features and old internals in preparation for an upcoming modernization refactor (v4).

Breaking Changes
  • Dropped support for Node.js < 6
  • Dropped support for hiredis (no longer required)
  • Removed previously deprecated drain event
  • Removed previously deprecated idle event
  • Removed previously deprecated parser option
  • Removed previously deprecated max_delay option
  • Removed previously deprecated max_attempts option
  • Removed previously deprecated socket_no_delay option
Bug Fixes
  • Removed development files from published package (#​1370)
  • Duplicate function now allows db param to be passed (#​1311)
Features
  • Upgraded to latest redis-commands package
  • Upgraded to latest redis-parser package, v3.0.0, which brings performance improvements
  • Replaced double-ended-queue with denque, which brings performance improvements
  • Add timestamps to debug traces
  • Add socket_initial_delay option for socket.setKeepAlive (#​1396)
  • Add support for rediss protocol in url (#​1282)

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is stale, or if you tick the rebase/retry checkbox below.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+3 -3

0 comment

3 changed files

renovate-bot

pr closed time in 15 days

pull request commentGoogleCloudPlatform/nodejs-docs-samples

test: modernize mocha config

This breaks the billing tests.

JustinBeckwith

comment created time in 21 days

push eventGoogleCloudPlatform/nodejs-docs-samples

sofisl

commit sha d091c8f7c7334844d11e949c6c21ad5ef4f38dfa

fix: refactor stubConsole and restoreConsole methods in repo-tools with sinon dependency (#1600)

view details

F. Hinkelmann

commit sha 119870d9c683477c2d12d42096ef1b8e0a6a480d

Merge branch 'master' into mocharc

view details

push time in 22 days

push eventGoogleCloudPlatform/nodejs-docs-samples

sofisl

commit sha d091c8f7c7334844d11e949c6c21ad5ef4f38dfa

fix: refactor stubConsole and restoreConsole methods in repo-tools with sinon dependency (#1600)

view details

push time in 22 days

Pull request review commentGoogleCloudPlatform/nodejs-docs-samples

fix: refactor stubConsole and restoreConsole methods in repo-tools with sinon dependency

 const path = require('path'); const assert = require('assert'); const utils = require('@google-cloud/nodejs-repo-tools');+const sinon = require('sinon');  const cwd = path.join(__dirname, '../'); const requestObj = utils.getRequest({   cwd: cwd,   cmd: 'server', }); -beforeEach(utils.stubConsole);-afterEach(utils.restoreConsole);+const stubConsole = function () {+      sinon.stub(console, `error`);+      sinon.stub(console, `log`).callsFake((a, b) => {+        if (+          typeof a === `string` &&

Would the tests pass without this if clause?

sofisl

comment created time in 22 days

issue closednodejs/node

Math.pow gives wrong value on windows

  • Version: v9.9.0
  • Platform: Windows 10
  • Subsystem: Number, Math

This is probably a V8 issue, but I just need to confirm.

14 ** .9;         // 10.752643127243294
14 ** (a=>a)(.9); // 10.752643127243292

These two should be the same. Even if they are not the same (but I don't see why they wouldn't be), then at least <s>their absolute difference should be smaller than Number.EPSILON</s> (seems like it is not the case). So, these two values are definitely different and inconsistent.

My opinion is that V8 optimizes 14 ** .9 as a constant and evaluates it while parsing. But V8 probably uses different methods (algorithms) for exponentiation, so it yields inconsistent values.

closed time in 23 days

ghost

issue commentnodejs/node

Math.pow gives wrong value on windows

Closing this as it's a V8 bug and not a Node.js specific issue.

ghost

comment created time in 23 days

push eventGoogleCloudPlatform/nodejs-docs-samples

sofisl

commit sha 9631b11c1fb5c987064a77e066ec3a811f17c2c3

chore: replace repo tools tools.runAsync function with execSync (#1597)

view details

F. Hinkelmann

commit sha ae1c7b08b8e8c1ceebcdfffb9f621af325adac9f

Merge branch 'master' into mocharc

view details

push time in 23 days

issue closedGoogleCloudPlatform/nodejs-getting-started

gcloud app deploy - cannot deploy to new project

i have created a new project, and am attempting to deploy the hello world node app. i get this error:

Updating service [default] (this may take several minutes)...failed.
DEBUG: (gcloud.app.deploy) Error Response: [13] An internal error occurred during deployment. You may need to delete this version manually.
Traceback (most recent call last):
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/calliope/cli.py", line 984, in Execute
    resources = calliope_command.Run(cli=self, args=args)
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/calliope/backend.py", line 798, in Run
    resources = command_instance.Run(args)
  File "/Applications/google-cloud-sdk/lib/surface/app/deploy.py", line 110, in Run
    default_strategy=flex_image_build_option_default))
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/command_lib/app/deploy_util.py", line 642, in RunDeploy
    ignore_file=args.ignore_file)
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/command_lib/app/deploy_util.py", line 432, in Deploy
    extra_config_settings)
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/api_lib/app/appengine_api_client.py", line 208, in DeployService
    poller=done_poller)
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/api_lib/app/operations_util.py", line 314, in WaitForOperation
    sleep_ms=retry_interval)
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/api_lib/util/waiter.py", line 264, in WaitFor
    sleep_ms, _StatusUpdate)
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/api_lib/util/waiter.py", line 326, in PollUntilDone
    sleep_ms=sleep_ms)
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/core/util/retry.py", line 229, in RetryOnResult
    if not should_retry(result, state):
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/api_lib/util/waiter.py", line 320, in _IsNotDone
    return not poller.IsDone(operation)
  File "/Applications/google-cloud-sdk/lib/googlecloudsdk/api_lib/app/operations_util.py", line 183, in IsDone
    encoding.MessageToPyValue(operation.error)))
OperationError: Error Response: [13] An internal error occurred during deployment. You may need to delete this version manually.
ERROR: (gcloud.app.deploy) Error Response: [13] An internal error occurred during deployment. You may need to delete this version manually.

this is a new project within an existing account. i've noted several issues online referencing this in the past, but i cannot resolve by restarting Build Api, and I cannot clean out old versions of my app since there are none. i believe those are the only workarounds that i had found.

note - i had first attempted to deploy a more complex app than hello world, then simplified.

closed time in 23 days

stlbucket

issue commentGoogleCloudPlatform/nodejs-getting-started

gcloud app deploy - cannot deploy to new project

@stlbucket thanks for opening the issues. Looks like a temporary problem. Please let us know if the problem still persists.

stlbucket

comment created time in 23 days

issue closedGoogleCloudPlatform/nodejs-getting-started

Error: ALREADY_EXISTS: Resource already exists in the project

I'm getting this error, after the topic on pub/sub was created:

> nodejs-getting-started@1.0.0 start /app
> node ${SCRIPT:-app.js}

App listening on port 8080
/app/worker.js:59
      throw err;
      ^

Error: 6 ALREADY_EXISTS: Resource already exists in the project (resource=shared-worker-subscription).
    at Object.callErrorFromStatus (/app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/call.js:30:26)
    at Http2CallStream.call.on (/app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/client.js:96:33)
    at Http2CallStream.emit (events.js:203:15)
    at process.nextTick (/app/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/call-stream.js:75:22)
    at process._tickCallback (internal/process/next_tick.js:61:11)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! nodejs-getting-started@1.0.0 start: `node ${SCRIPT:-app.js}`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the nodejs-getting-started@1.0.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-10-12T18_56_41_582Z-debug.log

I follow all the steps of this tutorial: https://cloud.google.com/nodejs/docs/tutorials/bookshelf-on-kubernetes-engine?hl=pt-br

closed time in 23 days

gustavopradoreis

issue closedGoogleCloudPlatform/nodejs-getting-started

Error: no matching index found

nodejs-getting-started/2-structured-data

I keep getting the no matching index found (followed the instructions). Is there a step missing in the instructions to create the data ?

App listening on port 8080 Error: no matching index found. at Http2CallStream.<anonymous> (path/nodejs-getting-started/2-structured-data/node_modules/@grpc/grpc-js/build/src/client.js:101:45) at Http2CallStream.emit (events.js:205:15) at path/nodejs-getting-started/2-structured-data/node_modules/@grpc/grpc-js/build/src/call-stream.js:71:22 at processTicksAndRejections (internal/process/task_queues.js:82:9)

closed time in 23 days

aa505

issue closedGoogleCloudPlatform/nodejs-getting-started

multer example usage in 3-binary-data

Multer does not add a file property to the request object when calling single(), it adds a files object which contains an object with the name of the field that was passed into single(). properties that do not exist:

  • file
  • buffer
  • originalname Please update the examples.

closed time in 23 days

bill-thedbaguy

issue commentGoogleCloudPlatform/nodejs-docs-samples

appengine example for analytics has faulty got call

@ace-n Could you have a look at this appengine problem. Thanks

luukvr

comment created time in 23 days

push eventGoogleCloudPlatform/nodejs-docs-samples

sofisl

commit sha 9631b11c1fb5c987064a77e066ec3a811f17c2c3

chore: replace repo tools tools.runAsync function with execSync (#1597)

view details

push time in 23 days

Pull request review commentGoogleCloudPlatform/nodejs-docs-samples

chore: replace repo tools tools.runAsync function with execSync

  const path = require('path'); const assert = require('assert');-const tools = require('@google-cloud/nodejs-repo-tools');+const {execSync} = require('child_process');

👍

sofisl

comment created time in 23 days

pull request commentGoogleCloudPlatform/nodejs-docs-samples

test: modernize mocha config

Running failing functions/billing test again.

JustinBeckwith

comment created time in 23 days

PR closed googleapis/google-cloud-node

Reviewers
[Syntax Review] Additional types of SampleGen code samples cla: yes

Follow-up code review PR –

To evaluate the readiness of 🚀 Node.js's GAPIC sample generator for use on cloud.google.com,
this provides a full set of samples which demonstrate the basic features of generated samples.

The .yaml sample config files for these samples can all be found here: .yaml sample configs

The first review Pull Requests had samples to show the basic structure as well as LRO samples.

This contains samples demonstrating those features and a few more use-cases for review –

Sample Description
samplegen_basics.js Shows basic structure/anatomy of Python samples
samplegen_no_config.js Minimal sample example (zero configuration)
samplegen_no_response.js API method which returns Empty
samplegen_paged.js Paged API method (iterates over pages of results)
samplegen_resource_path.js Sample which requires user's Google Project ID
samplegen_map_field_access.js Access map value by key and enumerate keys/values
samplegen_read_and_write_files.js Read binary file into bytes & write string to local file
samplegen_repeated_fields.js Repeated request field & show loop/access by index
samplegen_write_bytes_to_file.js Write bytes field in response to local file
samplegen_lro.js Call long-running operation API endpoint

This Pull Request is focused on feedback collection & a similar PR is being sent to all languages.

Once you've completed your review and left comments, you may feel free to close the PR!

We will scope out making all of the requested changes and reach out to language team offline.

🙏 Thanks in advance for your review!


P.S. Nits welcome! We'd like to get these as polished as possible for usage on cloud.google.com.

Please feel free to note in comments whether something is: 🛑 Blocker -vs- 📌 Nit


🔍 Known Issues

  1. Overall structure of samples (UPDATED)
  2. ❓ Open Question: ok to continue using yargs so long as sample-tester is used

📑 (internal)

+630 -0

6 comments

10 changed files

beccasaurus

pr closed time in a month

pull request commentgoogleapis/google-cloud-node

[Syntax Review] Additional types of SampleGen code samples

Closing for now. Thanks

beccasaurus

comment created time in a month

issue commentGoogleCloudPlatform/nodejs-getting-started

Incorrect Kokoro configuration prevents auto-linter presubmit from running

@feywind did this get fixed with your PR?

feywind

comment created time in a month

pull request commentGoogleCloudPlatform/nodejs-docs-samples

chore: replace repo tools tools.runAsync function with execSync

datacatalog tests are failing independently of your PR. I can't tell at a first glance if the iot failure is related. If it keeps failing you might want to submit a PR that doesn't touch those tests. Then we know right away if the failure is related to your changes.

sofisl

comment created time in a month

Pull request review commentGoogleCloudPlatform/nodejs-docs-samples

chore: replace repo tools tools.runAsync function with execSync

  const path = require('path'); const assert = require('assert');-const tools = require('@google-cloud/nodejs-repo-tools');+const childProcess = require('child_process');

If execSync is the only property we use, I'd prefer this:

const execSync = require('child_process').execSync;
sofisl

comment created time in a month

Pull request review commentGoogleCloudPlatform/nodejs-docs-samples

chore: replace repo tools tools.runAsync function with execSync

 before(() => { });  it('should load credentials implicitly', async () => {-  const output = await tools.runAsync(`${cmd} auth-cloud-implicit`, cwd);+  const output = await childProcess.execSync(`${cmd} auth-cloud-implicit`, cwd);

execSync does not return a promise, so we don't want/need await. It's blocking by default.

sofisl

comment created time in a month

push eventGoogleCloudPlatform/nodejs-docs-samples

Emily Herbert

commit sha cab0d56f247029b1ed3c41fc200d42f71c4d8bd0

Add --runtime argument to gcloud deploy in README. (#1595) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

push time in a month

PR merged GoogleCloudPlatform/nodejs-docs-samples

Reviewers
Add --runtime argument to gcloud deploy in README. cla: yes

gcloud requires a --runtime argument when deploying new functions, otherwise the user sees:

ERROR: (gcloud.functions.deploy) Missing required argument [runtime]: Flag--runtimeis required for new functions.

This addition is consistent with the tutorial (https://cloud.google.com/functions/docs/tutorials/http).

+20 -9

12 comments

4 changed files

emilyaherbert

pr closed time in a month

Pull request review commentgoogleapis/nodejs-scheduler

[DO NOT MERGE] Add samples for all methods

+// Copyright 2019 Google LLC+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//     https://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.++// DO NOT EDIT! This is a generated sample ("Request",  "cloud_scheduler_create_job")++// sample-metadata:+//   title: Create Job+//   description: Create a job that posts to /log_payload on an App Engine service.+//   usage: node samples/v1/cloud_scheduler_create_job.js [--project_id "PROJECT_ID"] [--location_id "LOCATION_ID"] [--service_id "my-service"]++'use strict';++function main(projectId = 'PROJECT_ID', locationId = 'LOCATION_ID', serviceId = 'my-service') {+  // [START cloud_scheduler_create_job]+  /**+  * TODO(developer): Uncomment these variables before running the sample.+  */+  // const projectId = 'PROJECT_ID';+  // const locationId = 'LOCATION_ID';+  // const serviceId = 'my-service';++  // Imports the client library+  const {CloudSchedulerClient} = require('@google-cloud/scheduler').v1;++  // Instantiates a client+  const cloudSchedulerClient = new CloudSchedulerClient();++  async function sampleCreateJob() {+    const formattedParent = cloudSchedulerClient.locationPath(projectId, locationId);+    const httpMethod = 'POST';+    const relativeUri = '/log_payload';+    const body = 'Hello World';+    const appEngineRouting = {+      service: serviceId,+    };+    const appEngineHttpTarget = {+      httpMethod: httpMethod,+      relativeUri: relativeUri,+      body: body,+      appEngineRouting: appEngineRouting,+    };+    const timeZone = 'America/Los_Angeles';+    const schedule = '* * * * *';+    const job = {+      appEngineHttpTarget: appEngineHttpTarget,+      timeZone: timeZone,+      schedule: schedule,+    };++    // Construct request+    const request = {+      parent: formattedParent,+      job: job,+    };++    // Run request+    const [response] = await cloudSchedulerClient.createJob(request);++    console.log(`Created job: ${response.name}`);+  }+  sampleCreateJob();+  // [END cloud_scheduler_create_job]+}++const argv = require(`yargs`)

We need to keep the syntax consistent between all languages, otherwise the test runner doesn't work. I think we can live with this difference between manual tests and tests generated by SampleGen. I'll look into the dependencies, making sure we include yargs for generated samples.

fhinkel

comment created time in a month

push eventemilyaherbert/nodejs-docs-samples

Gus Class

commit sha 41d170a2429adc78743a1fc64d6a983583c4424d

IoT Cloud Client Migration part 4/4 (#1594) * Migrates remaining NodeJS samples to Cloud Client library * Converts cleanup helpers to Cloud * Removes duplicate get_client snippet

view details

Ace Nassri

commit sha 534310285a8da4dceee8a233c12329684b4c7298

Add .mocharc to create test XML results. (#1588) * Add mocharc to export test XML * Take 2: use sponge_log.xml for test result filename * Add XUnit exports to ALL node tests Co-authored-by: Benjamin E. Coe <bencoe@google.com>

view details

Grant Timmerman

commit sha 82e75e052078c24f0ee4538fd761b09066208557

chore: cloud run ga (#1582)

view details

Adam Ross

commit sha c7f523a89aa67b1e93fb1fb2a4ff4c7f1bc4a369

run/logging-manual: stabilize tests (#1515) * run/logging-manual: confirm environment * hello-broken: extend test timeout * run/kokoro: use kokoro build id in service name * e2e: fix service URL derivation and remove beta component Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

F. Hinkelmann

commit sha 0b547d6c6d70fe4fb469c763e2275fe8d4d897cf

Merge branch 'master' into master

view details

push time in a month

push eventricardolsmendes/nodejs-docs-samples

WhiteSource Renovate

commit sha 3c4a61544e5be332ea6a7404ecdc521ee53b58df

Update dependency googleapis to v47 (#1593)

view details

Gus Class

commit sha 41d170a2429adc78743a1fc64d6a983583c4424d

IoT Cloud Client Migration part 4/4 (#1594) * Migrates remaining NodeJS samples to Cloud Client library * Converts cleanup helpers to Cloud * Removes duplicate get_client snippet

view details

Ace Nassri

commit sha 534310285a8da4dceee8a233c12329684b4c7298

Add .mocharc to create test XML results. (#1588) * Add mocharc to export test XML * Take 2: use sponge_log.xml for test result filename * Add XUnit exports to ALL node tests Co-authored-by: Benjamin E. Coe <bencoe@google.com>

view details

Grant Timmerman

commit sha 82e75e052078c24f0ee4538fd761b09066208557

chore: cloud run ga (#1582)

view details

Adam Ross

commit sha c7f523a89aa67b1e93fb1fb2a4ff4c7f1bc4a369

run/logging-manual: stabilize tests (#1515) * run/logging-manual: confirm environment * hello-broken: extend test timeout * run/kokoro: use kokoro build id in service name * e2e: fix service URL derivation and remove beta component Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

F. Hinkelmann

commit sha dff0882109fbfc3674759958f825713f410aef95

Merge branch 'master' into task/add-create-entry-sample

view details

push time in a month

push eventfhinkel/nodejs-scheduler

Benjamin E. Coe

commit sha 15e23084eabcb26ce19820c89ba69f34d8cd4472

build: script updated for new Windows image (#183)

view details

F. Hinkelmann

commit sha efcc2606b8c1d4b994e793f7f36dfd3c5bd55296

Merge branch 'master' into generatedSamples

view details

push time in a month

Pull request review commentgoogleapis/nodejs-scheduler

[DO NOT MERGE] Add samples for all methods

+type: test/samples

No, there's one test.yaml for all languages. It lives with the sample config and proto. SynthTool generates the samples but only copies the test config to GitHub.

fhinkel

comment created time in a month

Pull request review commentgoogleapis/nodejs-scheduler

[DO NOT MERGE] Add samples for all methods

+type: test/samples+schema_version: 1+test:+  suites:+  - name: Manage jobs+    cases:++    - name: cloud_scheduler_list_job+      spec:+      - call:+          sample: cloud_scheduler_list_jobs+          params:+            project_id:+              literal: "tribal-cortex-199921"

Doesn't need to be hard coded, just easier while we're prototyping.

fhinkel

comment created time in a month

Pull request review commentgoogleapis/nodejs-scheduler

[DO NOT MERGE] Add samples for all methods

+// Copyright 2019 Google LLC+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//     https://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.++// DO NOT EDIT! This is a generated sample ("Request",  "deletejob")++// sample-metadata:+//   title:+//   usage: node samples/v1/deletejob.js++'use strict';++function main() {++  // Imports the client library+  const {CloudSchedulerClient} = require('@google-cloud/scheduler').v1;++  // Instantiates a client+  const cloudSchedulerClient = new CloudSchedulerClient();++  async function sampleDeleteJob() {+    const formattedName = cloudSchedulerClient.jobPath('[PROJECT]', '[LOCATION]', '[JOB]');++    // Run request+    const [response] = await cloudSchedulerClient.deleteJob({name: formattedName});

The sample config was generated without any config. Thus no specific log statements.

fhinkel

comment created time in a month

push eventfhinkel/nodejs-scheduler

Franziska Hinkelmann

commit sha f89e5830626ba9e662011b9b1886eb91408d084d

Rename samples

view details

push time in a month

delete branch googleapis/sloth

delete branch : fhinkel-patch-2

delete time in a month

PR opened googleapis/sloth

fix: add fhinkel to yoshi-nodejs team
+1 -0

0 comment

1 changed file

pr created time in a month

create barnchgoogleapis/sloth

branch : fhinkel-patch-2

created branch time in a month

PR closed googleapis/sloth

fix: add fhinkel to yoshi-nodejs cla: yes
+1 -0

0 comment

1 changed file

fhinkel

pr closed time in a month

PR opened googleapis/sloth

Add fhinkel to yoshi-nodejs
+1 -0

0 comment

1 changed file

pr created time in a month

create barnchgoogleapis/sloth

branch : fhinkel-patch-1

created branch time in a month

PR opened googleapis/nodejs-scheduler

[DO NOT MERGE] Add samples for all methods

cloud_scheduler_create_job.js and cloud_scheduler_list_jobs.js are generated from manually written config files. cloud_scheduler_create_job.js is almost idential to the existing hand written sample.

The other samples are generated from config files that are generated via script, no manual configuration.

+826 -6

0 comment

13 changed files

pr created time in a month

create barnchfhinkel/nodejs-scheduler

branch : generatedSamples

created branch time in a month

issue openedgoogleapis/sample-tester

uuid example usage missing in docs

Please add an example of using it in a config file. Thank you :)

created time in a month

push eventfhinkel/nodejs-scheduler

F. Hinkelmann

commit sha e7cf0d931d131c5e68e69d710bb15567176f59ff

fix: delete stale comment from sample

view details

push time in a month

fork fhinkel/nodejs-scheduler

Node.js client for Google Cloud Scheduler: Fully managed, enterprise-grade scheduler

https://cloud.google.com/scheduler/

fork in a month

pull request commentGoogleCloudPlatform/nodejs-docs-samples

Add --runtime argument to gcloud deploy in README.

👋 @emilyaherbert thanks for opening a pull request. @ace-n Could you have a look please. Thanks.

emilyaherbert

comment created time in a month

pull request commentGoogleCloudPlatform/nodejs-docs-samples

Add .mocharc to create test XML results.

Sounds good, let's see if it causes any problems (also with the build cop bot).

ace-n

comment created time in a month

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 3c4a61544e5be332ea6a7404ecdc521ee53b58df

Update dependency googleapis to v47 (#1593)

view details

push time in a month

PR merged GoogleCloudPlatform/nodejs-docs-samples

Reviewers
Update dependency googleapis to v47 cla: yes

This PR contains the following updates:

Package Type Update Change
googleapis dependencies major ^46.0.0 -> ^47.0.0
googleapis devDependencies major ^46.0.0 -> ^47.0.0

Release Notes

<details> <summary>googleapis/google-api-nodejs-client</summary>

v47.0.0

Compare Source

⚠ BREAKING CHANGES
Features

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+11 -11

0 comment

11 changed files

renovate-bot

pr closed time in a month

push eventricardolsmendes/nodejs-docs-samples

Renovate Bot

commit sha 2b01144fbcfe989e739f66ee6aa16ca690e43bf5

Update dependency eslint-plugin-node to v11 (#1576)

view details

Ace Nassri

commit sha 6af440324152d536c38296459028d559c4ca7bfa

functions + appengine: export XUnit results (#1587) * functions: export xunit results * appengine: export xunit results

view details

Gus Class

commit sha 0ae59a983e2e9ca02d2f9cd4deae20895372a54e

Upgrade dependencies before starting final migration step (#1586)

view details

Ace Nassri

commit sha b0cbf5a77056963bd88345dd13583e93f111fc08

functions/slack: message verification - tokens -> signatures (#1562) * functions/slack: message verification - tokens -> signatures * Fix lint * Fix tests

view details

WhiteSource Renovate

commit sha b1160b1f5798efb959b8bc88b3fc0396a5f5c2e5

Update dependency @google-cloud/logging to v7 (#1585) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

WhiteSource Renovate

commit sha 06f0db2e95ea8f7473119ab2700592d9864ee885

Update dependency mocha to v7 (#1580) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

WhiteSource Renovate

commit sha 69d28ff1bb5828071c536d355e7852bba1b6e514

Update dependency sinon to v8 (#1574)

view details

F. Hinkelmann

commit sha 9dde80dd024b4236b50c25b48367d84a9e8b0aef

Merge branch 'master' into task/add-create-entry-sample

view details

push time in a month

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 69d28ff1bb5828071c536d355e7852bba1b6e514

Update dependency sinon to v8 (#1574)

view details

push time in a month

PR merged GoogleCloudPlatform/nodejs-docs-samples

Reviewers
Update dependency sinon to v8 cla: yes

This PR contains the following updates:

Package Type Update Change
sinon (source) devDependencies major ^7.2.7 -> ^8.0.0

Release Notes

<details> <summary>sinonjs/sinon</summary>

v8.0.4

Compare Source

==================

  • Remove misleading 'own' from exception message

v8.0.3

Compare Source

==================

  • Move .printf to proxy

v8.0.2

Compare Source

==================

v8.0.1

Compare Source

==================

  • Force upgrade @​sinonjs/commons (#​2181)
  • Update docs/changelog.md and set new release id in docs/_config.yml
  • Add release documentation for v8.0.0

v8.0.0

Compare Source

==================

The major release is caused by removing old mistakes and upgrading dependencies that themselves have had new major releases.

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+28 -28

0 comment

28 changed files

renovate-bot

pr closed time in a month

issue closedGoogleCloudPlatform/nodejs-docs-samples

Hi, I am getting authentication error while running OCR in nodeJS

Error: The incoming JSON object does not contain a client_email field at JWT.fromJSON can someone please help , where to send the config from?

closed time in a month

mamta-dhaka

push eventrenovate-bot/nodejs-docs-samples

WhiteSource Renovate

commit sha 06f0db2e95ea8f7473119ab2700592d9864ee885

Update dependency mocha to v7 (#1580) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

F. Hinkelmann

commit sha 8f50188954fb54ce6f290b464980162464ee48e7

Merge branch 'master' into renovate/sinon-8.x

view details

push time in a month

push eventGoogleCloudPlatform/nodejs-docs-samples

WhiteSource Renovate

commit sha 06f0db2e95ea8f7473119ab2700592d9864ee885

Update dependency mocha to v7 (#1580) Co-authored-by: F. Hinkelmann <franziska.hinkelmann@gmail.com>

view details

push time in a month

PR merged GoogleCloudPlatform/nodejs-docs-samples

Reviewers
Update dependency mocha to v7 cla: yes

This PR contains the following updates:

Package Type Update Change
mocha (source) devDependencies major ^6.0.0 -> ^7.0.0

Release Notes

<details> <summary>mochajs/mocha</summary>

v7.0.0

Compare Source

:boom: Breaking Changes

  • #​3885: Drop Node.js v6.x support (@​mojosoeun)
  • #​3890: Remove Node.js debug-related flags --debug/--debug-brk and deprecate debug argument (@​juergba)
  • #​3962: Changes to command-line options (@​ParkSB):
    • --list-interfaces replaces --interfaces
    • --list-reporters replaces --reporters
  • Hook pattern of this.skip() (@​juergba):
    • #​3859: When conditionally skipping in a it test, related afterEach hooks are now executed
    • #​3741: When conditionally skipping in a beforeEach hook, subsequent inner beforeEach hooks are now skipped and related afterEach hooks are executed
    • #​4136: Disallow this.skip() within after hooks
  • #​3967: Remove deprecated getOptions() and lib/cli/options.js (@​juergba)
  • #​4083: Uncaught exception in pending test: don't swallow, but retrospectively fail the test for correct exit code (@​juergba)
  • #​4004: Align Mocha constructor's option names with command-line options (@​juergba)

:tada: Enhancements

  • #​3980: Refactor and improve --watch mode with chokidar (@​geigerzaehler):
    • adds command-line options --watch-files and --watch-ignore
    • removes --watch-extensions
  • #​3979: Type "rs\n" to restart tests (@​broofa)

:fax: Deprecations

These are soft-deprecated, and will emit a warning upon use. Support will be removed in (likely) the next major version of Mocha:

:bug: Fixes

:mag: Coverage

:book: Documentation

:nut_and_bolt: Other

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+59 -59

2 comments

59 changed files

renovate-bot

pr closed time in a month

issue closedGoogleCloudPlatform/nodejs-docs-samples

startInstancePubSub

use this instruction for create scheduled instance, using gcloud

https://cloud.google.com/scheduler/docs/start-and-stop-compute-engine-instances-on-a-schedule

After created functions - instance is not started. error in cloud fucntion startInstancePubSub -

TypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object.

closed time in a month

zhukovnv84
more