profile
viewpoint
Felix Arntz felixarntz @Google San Francisco, CA https://felix-arntz.me Developer Programs Engineer at @Google. @WordPress Core Committer. Previously @Yoast. Runner, musician, movie geek. Aprendiendo español. Fueled by Mountain Dew.

ampproject/amp-wp 1711

Enable AMP on your WordPress site, the WordPress way.

ampproject/amp.dev 499

The AMP Project Website.

api-api/authenticator-basic 0

Authenticator implementation for Basic Authentication.

api-api/authenticator-bearer 0

Authenticator implementation for Bearer Authentication.

api-api/authenticator-key 0

Authenticator implementation for passing a plain and simple API key.

api-api/authenticator-oauth1 0

Authenticator implementation for OAuth 1.0.

api-api/authenticator-x 0

Authenticator implementation for X header tokens.

api-api/authenticator-x-account 0

Authenticator implementation for X header tokens in combination with an account identifier in the base URI.

api-api/boilerplate-for-authenticator 0

Boilerplate for an authenticator package.

api-api/boilerplate-for-storage 0

Boilerplate for a storage package.

issue commentgoogle/site-kit-wp

Prevent layout shifts when jumping between sections on the unified dashboard

@tofumatt @aaemnnosttv @techanvil Revisiting this, I'm also wondering now whether we're going a bit overboard. When I tested the unified dashboard navigation, I found the overall experience okay enough to at least not rush a fix for this - IMO we can launch without it, which allows us to take a step back and rethink the implementation. I think the severity of the layout shifts is not as critical since they at least only surface in the loading states of widgets, which realistically only are slow enough to matter when making API requests. On subsequent page loads with cached API responses, it's not as relevant.

One thing I want to call out here that was weird to me though is that, even on page loads where all API responses were cached, for some reason clicking the "Speed" pill always scrolled me in a way that the "Speed" section wasn't actually at the top of the dashboard, but somewhere in the middle (screenshot below). I would expect that if I click it super-quickly, even before the "cached API request" has run through, but it even happened for me when I waited for more than 10 seconds. It only happens if I click the "Speed" pill as very first tab on the page though, on any click afterwards it scrolls correctly. Any idea where that is coming from?

Screen Shot 2022-01-22 at 1 28 45 PM

aaemnnosttv

comment created time in 6 hours

issue commentgoogle/site-kit-wp

Add Dashboard Notifications for modules that are gathering data (eg isGatheringData)

@tofumatt The ACs here are mostly good, however I think we need to clarify the wording here with @marrrmarrr, so I've moved it back to ACs. But most importantly, if the wording remains as it is in the screenshot above, the ACs need to specify that it has to be somehow dynamic. For example, what if Search Console has data, but Analytics is gathering data? In that case, the wording here would be incorrect.

I'll review this with @marrrmarrr and then we can see how to proceed.

tofumatt

comment created time in 6 hours

issue commentgoogle/site-kit-wp

Add "Gathering data" output to DataBlock component

@asvinb The "gathering data..." should be displayed on any DataBlocks where the respective service/API still isGatheringData (via the respective module store's selector). So I'd say yes, eventually this should be on all DataBlocks. Let's review how much effort that is - potentially we can say that this issue is only for the main dashboard and entity dashboard and then we can have follow-up one for other areas (e.g. WP dashboard widget and admin bar). What do you think @tofumatt?

tofumatt

comment created time in 6 hours

issue commentgoogle/site-kit-wp

Change CTA placement for Search Funnel on mobile

@tofumatt I marked this as blocked by #4694. The order doesn't really matter, but I think it makes sense to block one by the other to avoid conflicts.

tofumatt

comment created time in 6 hours

issue commentgoogle/site-kit-wp

Update Blue Box CTA components to more visually-illustrative versions

@tofumatt Let's make sure to capture in the ACs here that the new component should be Analytics specific. Right now we have the more generic ActivateModuleCTA component, but that should not be adjusted itself since it's still used in other places. So we should just replace that usage in the one place on the main dashboard/entity dashboard where it is per the Figma design.

@marrrmarrr The above reminds me, we also need to review in which other places outside the dashboard we still have blue CTAs and see whether/how we want to replace them.

tofumatt

comment created time in 6 hours

issue commentgoogle/site-kit-wp

Add Dashboard Notifications for modules with Zero Data (eg hasZeroData)

@tofumatt I think the ACs are good here indeed, but let's keep it in here until we've determined which URL to use.

@marrrmarrr @bethanylang Do we already have started (or at least planned) to write documentation for this? I think overall we'll need documentation pages to:

  • explain what it means when Google services are "gathering data"
  • explain what it means when there are 0s (but the services have already gathered data), e.g. site is not popular enough yet etc.

Also @marrrmarrr, double-checking, is the copy in these Figma files final? If not, could you please revise it in the next few days?

tofumatt

comment created time in 6 hours

issue commentgoogle/site-kit-wp

Introduce dashboard tour tooltips

@asvinb Great questions.

  • For the event category, let's use { viewContext }_unified-dashboard.
  • Correct, tooltip 4 is no longer relevant in the dashboard, so I've removed it now.

IB ✅

Please just add the event category to the IB. Once you've done that, feel free to move to Execution Backlog without another review.

marrrmarrr

comment created time in 6 hours

Pull request review commentgoogle/site-kit-wp

Update webdatastreams to be web datastreams

 export async function submitChanges( { select, dispatch } ) { 		dispatch( MODULES_ANALYTICS_4 ).setWebDataStreamID( webdatastream._id ); 		dispatch( MODULES_ANALYTICS_4 ).setMeasurementID( 			// eslint-disable-next-line sitekit/acronym-case-			webdatastream.measurementId+			webdatastream.webStreamData.measurementId

Maybe safer to use ?. here? Not strictly necessary since we only deal with web data streams, but you do use it below, so not sure why we shouldn't have it here.

			webdatastream.webStreamData?.measurementId
aaemnnosttv

comment created time in 7 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventgoogle/site-kit-wp

Tom Rees-Herdman

commit sha 3fcd8d6fda9d0703c854fde5a7fefd1359042f60

Update VRT reference images.

view details

Evan Mattson

commit sha 5d690e98e1f5a748bc0050176a17dc4dfc54205d

Merge pull request #4687 from google/fix/4683-vrts

view details

Felix Arntz

commit sha 6766124fb272644d9dae1ed95afcd91b014cd1ed

Merge branch 'main' into fix/4677-webdatastreams.

view details

push time in 7 hours

issue commentgoogle/site-kit-wp

Remove Analytics tag permission related components and infra

@eclarke1 @FlicHollis @aaemnnosttv Just leaving a note here that whenever this goes into a sprint/release, we should make sure it eventually lands in the same release as #4703, to not cause some weird "intermediate" user experience.

aaemnnosttv

comment created time in 7 hours

issue commentgoogle/site-kit-wp

Simplify Analytics UX for existing tags and GTM properties

@eclarke1 @FlicHollis @aaemnnosttv Just leaving a note here that whenever this goes into a sprint/release, we should make sure it eventually lands in the same release as #4702, to not cause some weird "intermediate" user experience.

aaemnnosttv

comment created time in 7 hours

issue commentgoogle/site-kit-wp

Simplify Analytics UX for existing tags and GTM properties

@aaemnnosttv IB almost ✅ , but similar to #4702 let's add a note on Storybook adjustments.

aaemnnosttv

comment created time in 7 hours

issue commentgoogle/site-kit-wp

Remove Analytics tag permission related components and infra

@aaemnnosttv IB almost ✅ , just can you please add at least one note to also remove/adjust any related Storybook stories? Specifically the ones with tag permission errors should no longer be relevant.

aaemnnosttv

comment created time in 7 hours

IssuesEvent

issue commentWordPress/performance

Configure GitHub action for automated plugin deployment to wordpress.org

Reopening this to figure out which WordPress account credentials to use for deployment, as well as actually configure this on GitHub. Since we can't modify the settings of this repository ourselves, we'll need to ask for help on this once we've decided which account credentials to use.

cc @JustinyAhin @ThierryA

felixarntz

comment created time in 2 days

push eventWordPress/performance

Justin Ahinon

commit sha 5e6c321b72872a7f08369d8184de520a6c4ac12e

Base setup for deploying the plugin to W.org

view details

Justin Ahinon

commit sha e7d8a6d4d01e53dc4c842913a905572f1763f536

Update deploy-dotorg.yml

view details

Justin Ahinon

commit sha 98ab0cb1c7aa057710980db00d9a9ffabe477a8b

Create .distignore

view details

Justin Ahinon

commit sha 6cd5bf7765d2fd953a1f2a2cfefb00a31d661256

Update .distignore

view details

Justin Ahinon

commit sha 36b17d7e25d2a4ac1ec58c6d98d4e703d5253909

Update .distignore

view details

Justin Ahinon

commit sha f2b581e3800ac21ef9163647c759d3140b9c7dfc

Add SLUG variable to the deployment workflow

view details

Justin Ahinon

commit sha 19f1493f66b491d0c34c081edec97140ad21e39b

Include the LICENSE file in the deploy build

view details

Justin Ahinon

commit sha 82476f1e0de453433329db786e24bcaee534b7f7

Merge branch 'trunk' into add/42-actions-automatic-deployment-wordpressdotorg

view details

Justin Ahinon

commit sha f99ff4c8871a263fc51c69ed42cf9058ad271827

Update .github/workflows/deploy-dotorg.yml Co-authored-by: Eugene Manuilov <eugene.manuilov@gmail.com>

view details

Felix Arntz

commit sha 8cf3b18d5ef03ff72e3a2037b0cba3e2f1e54412

Merge pull request #89 from WordPress/add/42-actions-automatic-deployment-wordpressdotorg GitHub action for automated plugin deployment to wordpress.org

view details

push time in 2 days

PR merged WordPress/performance

Reviewers
GitHub action for automated plugin deployment to wordpress.org [Type] Feature Infrastructure

Fixes #42.

This PR implements a GitHub action for deploying the performance plugin to W.org.

It uses 10up https://github.com/10up/action-wordpress-plugin-deploy to deploy on new releases on the repository.

The action also uses the SVN_PASSWORD and SVN_USERNAME secrets (not set yet in the repository) for the credentials.

Next steps:

  • [x] Attach a zip file to the release This is usually done using this action https://github.com/actions/upload-release-asset (see https://github.com/marketplace/actions/wordpress-plugin-deploy#deploy-on-publishing-a-new-release-and-attach-a-zip-file-to-the-release).
+52 -0

1 comment

2 changed files

JustinyAhin

pr closed time in 2 days

issue closedWordPress/performance

Configure GitHub action for automated plugin deployment to wordpress.org

Once the plugin is released on the wordpress.org plugin repository, we will need to regularly push updates. Since this is somewhat of a tedious and potentially error-prone process, it should be automated: We need a GitHub action that deploys the plugin release to wordpress.org when a GitHub release is published.

Some potential approaches / inspiration:

  • https://github.com/10up/action-wordpress-plugin-deploy
  • https://github.com/WordPress/gutenberg/blob/trunk/.github/workflows/upload-release-to-plugin-repo.yml

We don't need this yet, but it certainly doesn't hurt starting to already think about and discuss how we should go about it.

closed time in 2 days

felixarntz

issue commentgoogle/site-kit-wp

Problems with "Unique Visitors from Search" part of new "Search Funnel widget"

@hussain-t Hmm yes, looking at that code, I think the ga:channelGrouping dimension shouldn't be there. It's only relevant as a dimension filter, not a dimension.

felixarntz

comment created time in 2 days

PullRequestReviewEvent

issue openedgoogle/site-kit-wp

Fix GA tracking events for banner notifications

There is something slightly off with how Site Kit currently sends GA tracking events for banner notifications. The original purpose of #4056 was to introduce tracking events exclusively for the remote notifications (from core/site/data/notifications endpoint, controlled via proxy), but there was some confusion on this and eventually this was implemented as a general set of tracking events that fire for every BannerNotification, which results in some duplicate events that are unnecessary.

Part of the problem was that #4153 and #4170 only happened after the above issue, and those should probably have been a prerequisite to implement the GA events correctly. Anyway, this issue is about correcting the behavior.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • <!-- One or more bullet points for acceptance criteria. -->

Implementation Brief

  • <!-- One or more bullet points for how to technically resolve the issue. Make sure to include changes to Storybook and visual regression tests where relevant. -->

Test Coverage

  • <!-- One or more bullet points for how to implement automated tests to verify the issue is resolved. -->

QA Brief

  • <!-- One or more bullet points for how to test that the issue has been resolved. -->

Changelog entry

  • N/A

created time in 2 days

PullRequestReviewEvent

issue commentgoogle/site-kit-wp

Implement new Idea Hub prompt banner and widget notification

@aaemnnosttv Having Widgets.select SGTM for now!

felixarntz

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentgoogle/site-kit-wp

Feat/pr checklist

+name: Checklists++on:+  pull_request:+    branches:+      - develop+      - main+    types:+      - opened+      - reopened+      - edited

Yeah, I would prefer to keep this only a checklist for awareness, we don't need to enforce anything at the automation level.

eugene-manuilov

comment created time in 2 days

PullRequestReviewEvent

push eventgoogle/site-kit-wp

Crisoforo Gaspar

commit sha 661f9be70da4285fe95103dcc4fb4f3b2c61f8f2

Add tests for Permissions class Based on the definition from the ticket #4472 scenarios were described individually.

view details

Crisoforo Gaspar Hernández

commit sha 15f9888bba9c756ef045f9368eee2ecfe7a339fe

Add the `Tests` namespace Co-authored-by: Evan Mattson <emattson@google.com>

view details

Crisoforo Gaspar Hernández

commit sha ec8108e311161934e9fa54194fbfb18f70051a38

Update method name variant. Co-authored-by: Evan Mattson <emattson@google.com>

view details

Crisoforo Gaspar Hernández

commit sha 4e5bc861f17109d21fc00c3830c47d62cfe46269

Rename method to improve clarification on intent. Co-authored-by: Evan Mattson <emattson@google.com>

view details

Crisoforo Gaspar

commit sha ab02e01fe5716fd7d1eff9fe67ab4da891dac982

Merge branch 'develop' into ticket/4472-permissions-tests

view details

Crisoforo Gaspar

commit sha 2bf11bbbb1d16bf50360f81d27f8d188a962548c

Merge branch 'ticket/4472-permissions-tests' of github.com:google/site-kit-wp into ticket/4472-permissions-tests

view details

Crisoforo Gaspar

commit sha 53cb94b4775fa9d837978ccfa4169a3d1574485f

Add missing import due changes on namespace.

view details

Crisoforo Gaspar

commit sha f06f70786acd26c9546a9ddcc06b5aa34bf9b00f

Replace `foreach` with `assertEqualSets` Simplify tests and replace hash map to test an array with a valid set of values.

view details

Crisoforo Gaspar

commit sha f0d10e68b49d25280e5d879cdc293181da68bdc8

Update `package` to the correct location. The previous package was not defined correctly for the `Permissions` class.

view details

Crisoforo Gaspar

commit sha 88c33cf2b9229e3ea34e492f359671e2e55e3280

Define `Permissions` group for the test file.

view details

Crisoforo Gaspar

commit sha 921edfd7310027dccf72708e65e4e2406a72852d

Use `fake_proxy_site_connection` from `Fake_Site_Connection_Trait`. Replace the `add_filter` with the existing functionality from the trait.

view details

Crisoforo Gaspar

commit sha 0dbc2333e1493d70c99ec4baf832056f16c0f97a

Update file description to include, package and license.

view details

Crisoforo Gaspar

commit sha 62f607c83c392d08547718ff4999fd08c002109a

Replace `get_instance` with definition of each instance.

view details

Crisoforo Gaspar

commit sha e0d265fe58f76b348eda161384e02a0c2c60afce

Replace prefix `provider` with `data`.

view details

Crisoforo Gaspar

commit sha 4c0cb74fd23ee51c0f0753964f386c0267b911a6

Setup `tearDown` and group `wp_login` action of the user. Make sure the action that is dispatched after a user is logged in is fired. Additionally, make sure the user is logged out of correctly.

view details

Crisoforo Gaspar

commit sha 4eafefb5f13471b2e4c98dcd0815b8b2d7d7a8dc

Add tests for `check_all_for_current_user` public method. Add coverage for the public method `check_all_for_current_user`.

view details

Crisoforo Gaspar

commit sha 53302040439de0517c83f21df7972b84544b9842

Rename methods by variants. Rename the different variants using a prefix with `__`, based on the code guidelines.

view details

Evan Mattson

commit sha d7fa9e35d7a33f00dd10e22586b9abfd502363a0

Merge branch 'develop' into ticket/4472-permissions-tests.

view details

Evan Mattson

commit sha 1083c204454bf7f516df27f4eb7e1581469017df

Restore package in test file header.

view details

Evan Mattson

commit sha 8af0e5039826e782a7ba11c6a681dd400cb486b4

Add space before namespace.

view details

push time in 2 days

more