profile
viewpoint
Fadi Hadzh fdhadzh https://fdhadzh.com Perfectionist with deadlines

fdhadzh/flask-pipenv-example 36

Flask application using Pipenv

fdhadzh/clickdown 19

Explore vulnerable ClickHouse servers

fdhadzh/awesome-rust 4

A curated list of Rust code and resources.

fdhadzh/node-google-feed 4

[DEPRECATED] Google Feed API wrapper

fdhadzh/dotfiles 1

Configuration files for emacs, zsh, etc.

fdhadzh/AdguardBrowserExtension 0

AdGuard browser extension

fdhadzh/arachni 0

Web Application Security Scanner Framework

fdhadzh/awesome-python 0

A curated list of awesome Python frameworks, libraries and software

fdhadzh/c3po 0

Simple TCP chat

fdhadzh/ClickHouse 0

ClickHouse is a free analytic DBMS for big data.

push eventdoublify/pre-commit-rust

Teymour Aldridge

commit sha 06f8e3769e6ca0be1de8f861e6cbca2124c87dd1

Add a `clippy` hook.

view details

Fadi Hadzh

commit sha 14b3e118cfc36fb87d8d9cbd1305a2238fd85868

Merge pull request #10 from teymour-aldridge/patch-1 Add a `clippy` hook.

view details

push time in 5 days

push eventdoublify/pre-commit-rust

DanielChabrowski

commit sha e06d845e5b25141ed8a4ca92a758439d45747a5e

Autoupdate pre-commit

view details

DanielChabrowski

commit sha 77fcfde37179cb05e1c5f710bd56a84b3b50f048

Allow passing arguments to fmt, do not pass filenames

view details

DanielChabrowski

commit sha b60ba3790b4e943ba74a2a5d8cf9047643b07508

Use https instead of git protocol

view details

DanielChabrowski

commit sha a76233c81cd5c13fc0ecc33e91d54e0f13000f06

Pass filenames with args

view details

DanielChabrowski

commit sha 2630d3537d012640b8497cd7512212102891802c

Add fmt arguments example to readme

view details

Fadi Hadzh

commit sha 2c7d02620318f6ebd4faba023c037bd9b88b805f

Merge pull request #9 from DanielChabrowski/format-arguments Allow passing fmt arguments

view details

push time in 5 days

PR merged doublify/pre-commit-rust

Allow passing fmt arguments

Closes #7 and #8

To maintain the previous behaviour of formatting the files added and not necessarily used (cargo fmt won't format modules that are not used) there is a catch that if someone wants to pass arguments, one also has to add '--' at the very end, like so:

args: ['--manifest-path', 'my-project/Cargo.toml', '--']
+15 -5

0 comment

3 changed files

DanielChabrowski

pr closed time in 5 days

issue closeddoublify/pre-commit-rust

Cannot pass arguments to rustfmt

cargo fmt would use cargo.toml for the info, rustfmt has also the option --edition but

-   repo: https://github.com/doublify/pre-commit-rust
    rev: master
    hooks:
    -   id: fmt
        args:
          - --edition=2018

Says: "Error: file --edition=2018 does not exist"

Workaround: create .rustfmt.toml and put edition="2018" there.

closed time in 5 days

rambo

issue commentdoublify/pre-commit-rust

Providing location to Cargo.toml

Hello. Thanks for your activity. Please create Pull request if you know solution to fix this issue

dzieciou

comment created time in 20 days

push eventdoublify/pre-commit-clang-format

agasparovic-sabre

commit sha b106196dc02af2f355769694bee586f2500f12cb

Add textproto as a valid ClangFormat file ClangFormat recognizes .textproto files and will format in TextProto format.

view details

Fadi Hadzh

commit sha 62302476d0da01515660132d76902359bed0f782

Merge pull request #6 from agasparovic-sabre/patch-1 Add textproto as a valid ClangFormat file

view details

push time in 2 months

PR merged doublify/pre-commit-clang-format

Reviewers
Add textproto as a valid ClangFormat file

ClangFormat recognizes .textproto files and will format in TextProto format.

+1 -1

4 comments

1 changed file

agasparovic-sabre

pr closed time in 2 months

push eventdoublify/pre-commit-rust

Mathieu Lemay

commit sha 6db38901bffc81937d13587b005a90928b5291c8

Use cargo fmt instead of rustfmt

view details

Mathieu Lemay

commit sha 257c8ca7b4502d8dc7467b644fb85c5fc3836972

Use `types` instead of `files`

view details

Mathieu Lemay

commit sha 4bb2cb56a19f1f12165d1dfd9b53697034001e09

Allow user to send args to cargo fmt, not just to rustfmt

view details

Mathieu Lemay

commit sha 84b3445a55f873ed725fac8a32cc11e9760dc288

Revert "Allow user to send args to cargo fmt, not just to rustfmt" This actually broke the hook. The -- needs to be present for pre-commit to be able to pass the file names to run the hook on. This reverts commit 4bb2cb56a19f1f12165d1dfd9b53697034001e09.

view details

Fadi Hadzh

commit sha c9d5fe3776c92519e0b7eb9175fb56400f2a518f

Merge pull request #6 from mathieu-lemay/master Use `cargo fmt` instead of `rustfmt`

view details

push time in 2 months

more