App to manage a store among several users
fcamblor/backbone-fundamentals 1
A creative-commons book on Backbone.js for beginners and advanced users alike
A javascript framework for developing pretty browser dialogs and notifications.
fcamblor/angular-typescript-webpack 0
My angular typescript webpack architecture
Angular 2 Codelab: Let's develop an Angular 2 application...
A curated list of awesome Java frameworks, libraries and software. Inspired by awesome-python.
fcamblor/backbone-deep-model 0
Improved support for models with nested attributes.
A plugin to make Backbone.js keep track of nested attributes.
fcamblor/backbone.marionette 0
The Backbone Framework
create barnchfcamblor/open-wc
branch : externalize-storybook-prebuilt
created branch time in 3 hours
fork fcamblor/open-wc
Open Web Components: guides, tools and libraries for modern web development and web components
fork in 3 hours
issue commentpikapkg/snowpack
You can even maintain the DRY principle using any of these proposals when using a
snowpack.config.jsfile.
I agree if it comes to properties configuration only.
But if you think about having to register proxy handlers like :
proxy.on('proxyReq', function (proxyReq, req, res, options) {
proxyReq.setHeader('X-Special-Proxy-Header', 'foobar');
});
It can become complicated to put some parts of the handler common and some others specifics, without having the snowpack id config in hands.
But to be 100% honest, we could use function factories like :
const createOptionsFor = (name, proxy) => {
if(name === 'api2'){
proxy.on('proxyReq', function (proxyReq, req, res, options) {
proxyReq.setHeader('X-Special-Proxy-Header', 'foobar');
});
}
return {
target: ENVIRONMENTS.dev,
changeOrigin: name === 'api1',
ws: true,
};
};
module.exports = {
scripts: {
'proxy:api': 'proxy http://localhost:5000/api --to /api',
'proxy:api1': (proxy, options) => ({
path: '/proxy',
...createOptionsFor('api1', proxy)
}),
'proxy:api2': (proxy, options) => ({
path: '/proxy2',
...createOptionsFor('api2', proxy)
})
}
}
comment created time in 8 hours
issue commentpikapkg/snowpack
@FredKSchott Not sure if you captured my comment here into the Proposal #3 (what is api-proxy-config.js's format ? the same format than http-proxy options ? Or a snowpack-specific (very close to the http-proxy) one ?)
I'm not really fan of providing potentially multiple programmatic configuration points, I'd rather provide a single configuration point, passing the current proxy as input parameter (that way, if developer wants to add specificities to some snowpack configs he can ... and if he wants to share proxy config across multiple snowpack config he can easily as well)
My opinion about Proposals :
- Proposal 1 : will break
Map<string, string>scriptsnode configuration (not a big deal, but it may have a lot of Typescript impacts here and there to take the newMap<string, string|object>into consideration - Proposal 2 : I find it a bit verbose, having to maintain same keys (config ids) across multiple nodes doesn't look very convenient (but OTOH, we have separation of concerns here)
- Proposal 3 : Why not, if this is a snowpack-specific file format that allows to take snowpack configs as input parameters
- Proposal 4 : It fixes a lot of the downsides, but doesn't provide ease to share the same configuration across multiple proxy configs
comment created time in 8 hours
issue commentpikapkg/snowpack
Improve proxy support with http-proxy
@thisguychris the SSL support is only 2 lines of code, why not simply add it to #373 ?
I'm not preaching for having my commit integrated it, but simply not have 2 different PRs for only 2 lines of code :-)
I didn't pushed another PR for my +56/-35 line changes :-)
comment created time in 8 hours
pull request commentpikapkg/snowpack
Add support for websockets in proxy build script
@germanftorres wondering if you shouldn't rename your PR as the http-proxy move has widened a lot the scope of the initial PR :-)
comment created time in 9 hours
issue commentpikapkg/snowpack
Improve proxy support with http-proxy
As it currently stands, if someone wants to extend it, they can just make a new server and just pass it in the proxy and they can do whatever they want with that http-server. So I personally don't think we need to make it more complicated as it is.
If we follow this reasoning, why then provide a proxy feature into snowpack if, as soon as we have to work a bit with proxy, we have to build our own middleware on top of it ?
comment created time in 9 hours
issue commentpikapkg/snowpack
Improve proxy support with http-proxy
@thisguychris why not propose a PR on @germanftorres fork (which evolved with an improvement from my side .. he was very quick to merge it already :-) and I didn't had any visibility issue) ?
Also, I guess that #373 has a lot of interesting comments in it, why not close #375 and continue working/discussing on #373 ? I guess that would avoid too much dispersion.
comment created time in 9 hours
pull request commentpikapkg/snowpack
Add support for websockets in proxy build script
FYI, created a PR for this PR on @germanftorres repo : https://github.com/germanftorres/snowpack/pull/1 regarding http-proxy conditional module loading :-)
Regarding config, I would have done something like this :
// snowpack.config.js
module.exports = {
scripts: {
'proxy:api': 'proxy http://localhost:5000/api --to /api',
'proxy:weather': 'proxy http://weather.dev/weather--to /weather'
},
devOptions: {
// General purpose options that are going to be applied on proxy:* configs
httpProxyOptions: {
changeOrigin: false
},
// Allows finer tuning
configureHttpProxy: (snowpackProxyConfig, httpProxyOptions, proxy) => {
if(snowpackProxyConfig.id === 'weather') {
proxy.on('proxyReq', function (proxyReq, req, res, options) {
proxyReq.setHeader('X-Special-Proxy-Header', 'foobar');
});
return Object.assign(httpProxyOptions, { changeOrigin: true });
}
return httpProxyOptions;
}
}
};
My feeling is we're not going to have 100 different proxy configs, that's why we may have different config levels here :
- Standard (existing, simple) snowpack config based on a single string
- Common config with
devOptions.httpProxyOptionsflag (if you want to specify some general-purposehttp-proxyconfigs - More flexible configuration, aimed at "decorating" proxy instance & options on a per-config basis (config informations passed as parameter ... meaning that if you want to "share" some configuration across multiple configs, that's easy #DRY)
comment created time in 9 hours
push eventfcamblor/snowpack
commit sha 8d450a585695b1aab459c008274cc1b8db183068
making http-proxy import conditionnal depending on if a 'proxy' workerConfig exists or not
push time in 10 hours
push eventfcamblor/snowpack
commit sha 58595744501eb064870a22675b25267c7432a327
making http-proxy import conditionnal depending on if a 'proxy' workerConfig exists or not
push time in 10 hours
PR opened germanftorres/snowpack
Hi !
I reworked a bit your PR by taking into consideration @stramel comments on it :
- [x] Making
http-proxymodule loading conditional - [ ] Allowing to pass per-workerConfig
http-proxyconfig
pr created time in 10 hours
push eventfcamblor/snowpack
commit sha 398ec264e68129e55a4569b969070d6fec90637d
making http-proxy import conditionnal depending on if a 'proxy' workerConfig exists or not
push time in 10 hours
create barnchfcamblor/snowpack
branch : improving-http-proxy-support
created branch time in 10 hours
pull request commentpikapkg/snowpack
Add support for websockets in proxy build script
Also, wondering if there would be a benefit in offering the basic string configuration for a simple to use for general use-cases? For me, this is a must have to keep the basic string config : both in terms of backward compat (even if 2.0 is fresh), simplicity and documentation.
Accept a config object for the value portion of the proxy command that would be passed directly to the proxy instance. This would allow when using a .js config to use the advanced callbacks as well.
💯 with that, something like devOptions.httpProxyOptions and having the exact same representation than http-proxy's options
Currently, my issue regarding content-encoding was fixed only by using http-proxy, but I assume a lot of flexibility should be added to request/response headers using this config.
Only load and initialize the proxy for configs that specify a proxy option, so we don't add load time for users not utilizing this feature.
👍
comment created time in 10 hours
issue commentpikapkg/snowpack
Improve proxy support with http-proxy
@germanftorres FYI, my issue about content-encoding: gzip is fixed by your PR (=migrating to http-proxy), so that's definitely a 👍 from me here :)
comment created time in 12 hours
push eventfcamblor/snowpack
commit sha 6d25692470bc4dfe6946c3507a212c2ba35ff62e
fixed proxy impl when translating --to url to proxified url (#343)
commit sha 6140c5ae2a344871d92da2d05d673bf529956ea5
prototype websockets
commit sha 9d4723e4bc373ed878889953af0b7080cb88f606
connection seems open but messages aren't passing
commit sha 8c11ac4d9ea70f28aef0cdba321a9c7adb9a79bb
remove the outdated '_' filter from autodetected exports
commit sha a4a0ef779a38e7e692ce53348c4b5b5a57b56741
Merge branch 'master' of github.com:pikapkg/snowpack
commit sha 8eefef0efc947a14340ae73bef52061cfa44cfe2
update tests
commit sha 639c63d8315a3112d2e10d6b95665158327f5911
2.0.0-rc.7
commit sha 5bef0793aaa822c3e18657a96a5af014dbb3c955
stop overwriting on config merge
commit sha c20c0cf46c3b96592abca64df96903cc535dd826
Fix Inject Style (#345)
commit sha c89bc1c150119679eefd3f8b6b89602396891d53
Merge branch 'websockets' of https://github.com/JoviDeCroock/snowpack into JoviDeCroock-websockets
commit sha 7a8ba30a35e465fc0b8d4a8a25ee64afb6c2b777
fix up websocket usage
commit sha ce3b50d053a9f082cd70b3ad6ef5d87756db812e
Merge branch 'master' of github.com:pikapkg/snowpack
commit sha 5894dbae7b864117d9cdceb4b08557d3296bc157
handle reload flag
commit sha 02999f9e7d0db644c5a4a1d8a368262b7f27bf26
update docs
commit sha be918f10f5df52b2b15a0ad0bba835a388982d5b
update docs
commit sha 88b5d17a9ec5b4fbdae501b1ce111323cd7f4762
Update README.md
commit sha 8fbf9a05c8bca7c5284ae131b14857c47340f2f8
Update README.md
commit sha 3cf940161f2dab76497f47d4f296df53f44ada01
Update README.md
commit sha 9c21438efbe705fd4924f7e26a969c6117846d04
update docs
commit sha fa89eb5c862d77a3526e8284691c284ed4e27a51
logUpdate, not log error
push time in 12 hours
push eventfcamblor/snowpack
commit sha 6d25692470bc4dfe6946c3507a212c2ba35ff62e
fixed proxy impl when translating --to url to proxified url (#343)
commit sha 6140c5ae2a344871d92da2d05d673bf529956ea5
prototype websockets
commit sha 9d4723e4bc373ed878889953af0b7080cb88f606
connection seems open but messages aren't passing
commit sha 8c11ac4d9ea70f28aef0cdba321a9c7adb9a79bb
remove the outdated '_' filter from autodetected exports
commit sha a4a0ef779a38e7e692ce53348c4b5b5a57b56741
Merge branch 'master' of github.com:pikapkg/snowpack
commit sha 8eefef0efc947a14340ae73bef52061cfa44cfe2
update tests
commit sha 639c63d8315a3112d2e10d6b95665158327f5911
2.0.0-rc.7
commit sha 5bef0793aaa822c3e18657a96a5af014dbb3c955
stop overwriting on config merge
commit sha c20c0cf46c3b96592abca64df96903cc535dd826
Fix Inject Style (#345)
commit sha c89bc1c150119679eefd3f8b6b89602396891d53
Merge branch 'websockets' of https://github.com/JoviDeCroock/snowpack into JoviDeCroock-websockets
commit sha 7a8ba30a35e465fc0b8d4a8a25ee64afb6c2b777
fix up websocket usage
commit sha ce3b50d053a9f082cd70b3ad6ef5d87756db812e
Merge branch 'master' of github.com:pikapkg/snowpack
commit sha 5894dbae7b864117d9cdceb4b08557d3296bc157
handle reload flag
commit sha 02999f9e7d0db644c5a4a1d8a368262b7f27bf26
update docs
commit sha be918f10f5df52b2b15a0ad0bba835a388982d5b
update docs
commit sha 88b5d17a9ec5b4fbdae501b1ce111323cd7f4762
Update README.md
commit sha 8fbf9a05c8bca7c5284ae131b14857c47340f2f8
Update README.md
commit sha 3cf940161f2dab76497f47d4f296df53f44ada01
Update README.md
commit sha 9c21438efbe705fd4924f7e26a969c6117846d04
update docs
commit sha fa89eb5c862d77a3526e8284691c284ed4e27a51
logUpdate, not log error
push time in 12 hours
issue commentpikapkg/snowpack
Improve proxy support with http-proxy
FYI I have currently an issue about proxy due to "content-encoding: gzip" : see https://www.pika.dev/npm/snowpack/discuss/259
I imagine that http-proxy may fix this issue, I will look at your PR @germanftorres as I'm very interested into my issue to be fixed (I had something different ready on my side, but it only fits my problem which is not the right direction I guess)
comment created time in 12 hours
push eventfcamblor/snowpack
commit sha 76cb41cfeb7d9d37a4c646b0805f0060838a0976
removed content-encoding header as when the proxified payload is gzipped, it is transferred to the browser unzipped
push time in 13 hours
create barnchfcamblor/snowpack
branch : removing-content-encoding-response-header-in-dev
created branch time in 13 hours
PR opened pikapkg/snowpack
Proxy url translation doesn't work since commit 541e5da35c65fdf55fec5ffd62a0379ae9b8d7d7 (2.0.0-beta.22) due to .length removed
See https://github.com/pikapkg/snowpack/commit/541e5da35c65fdf55fec5ffd62a0379ae9b8d7d7#diff-d577271f764f63004633a4aa7a30aa26R362
pr created time in 7 days
push eventfcamblor/snowpack
commit sha cc0ae8bb5e67422754b41a507d3e02971694e65b
fixed proxy impl when translating --to url to proxified url
push time in 7 days
create barnchfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
created branch time in 8 days
issue openedopen-wc/storybook-prebuilt
Hi everyone,
I'm currently trying to put storybook on a snowpack app starter (https://github.com/fcamblor/lit-element-typescript-sass-constructible-stylesheet-starter) which doesn't have any build tool involved (no webpack)
Thanks to storybook-prebuilt, I was able to make my starter work with a prebuilt version of storybook which is exactly what I want, you can see it in action here : https://github.com/fcamblor/lit-element-typescript-sass-constructible-stylesheet-starter/tree/static-storybook-setup
Now, I'd like to refine a bit this setup and externalize all the storybook stuff (.storybook, stories/ and npm dependencies) into a dedicated /storybook/ folder so that the config is clear from a developper point of view.
You can have an idea of this refactoring here : https://github.com/fcamblor/lit-element-typescript-sass-constructible-stylesheet-starter/commit/dedicated-storybook-folder
Challenges I have are :
- Making
storybook'ses-dev-serverserving files from/and not/storybook/as my components resides in/(root) folder and are regularly importing snowpack modules through absolute url (import {html} from '/web_modules/lit-element.js';). This is currently done through thees-dev-server'srootDirattribute : https://github.com/fcamblor/lit-element-typescript-sass-constructible-stylesheet-starter/blob/dedicated-storybook-folder/storybook/.storybook/main.js#L38 - In that config, I'd like to serve
storybook-prebuiltthroughhttp://localhost:8001/storybook/context, but it doesn't look it's working presently.
Am I following a bad path here ? Would you have a simpler one ? Do you see any missing config that could help here ?
Thanks in advance for your help.
created time in 9 days
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha eadccdc2c2d116e7e828f39a46366919ee38ada5
added storybook pointers in readme
commit sha d817a44aa692b42bc824f1337de073a81683e104
WIP: moved storybook into a dedicated module, externalizing storybook-prebuilt specific config from the regular app config
push time in 9 days
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha eadccdc2c2d116e7e828f39a46366919ee38ada5
added storybook pointers in readme
push time in 9 days
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
push time in 9 days
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha 4dce9430d6c574668585686a5b8938d503bfbee5
WIP: moved storybook into a dedicated module, externalizing storybook-prebuilt specific config from the regular app config
push time in 9 days
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha 3acc849417dc4e90795f02b430b9e17759c1368c
moved storybook into a dedicated module, externalizing storybook-prebuilt specific config from the regular app config
push time in 9 days
create barnchfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
branch : dedicated-storybook-folder
created branch time in 9 days
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha f17e75f13f49135a8d8eecefbed98052ce39c3f5
added open-wc/demoing-storybook dependency (based on open-wc/storybook-prebuilt with some building script addition)
commit sha 5fc055dd69f7b4afe6b074f3219dd9ab2cbd7e99
externalized es-dev-server config into dedicated config file
push time in 9 days
issue openedfcamblor/slack-scoring-bot
Rename sheet <configName> to <configName>-Leaderboard
This will be more meaningful
created time in 16 days
issue openedfcamblor/slack-scoring-bot
Missing formula on -ReactionLog sheet after channel setup
L1 cell is not filled with following formula :
=EXTRACT_SCORES_FROM_REACTIONS(Config!$A$5;Config!$C$5;UserList!A:B;A:K)
(change line number in this formula)
created time in 16 days
create barnchfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
branch : static-storybook-setup
created branch time in 21 days
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha 84a6b944228afc2fceb5ad48bdf813bf032d1d86
naming concurrent dev tasks
push time in 21 days
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha 61d76a3138736522d47779cbcd579d69dc95f241
initialized storybook with type web-component
commit sha 82a08489c39782592dc1d24bdc1d611adb2abdcc
added storybook's typescript preset in order to be able to compile ts stories
commit sha f456779b87a6087df87d5577eb46a5bb60ea95a5
fix babel error due to ts decorators used : Support for the experimental syntax 'decorators-legacy' isn't currently enabled
push time in a month
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha 41be4c6d9aa88ee2e8dc058d88867e2ff04b6850
initialized storybook with type web-component
commit sha 3defd73962a316b9c27d05802c4bb4b66a790cb6
added storybook's typescript preset in order to be able to compile ts stories
commit sha d012ea1a8f196d32f909d5f84ad29e2da08e2ff7
fix babel error due to ts decorators used : Support for the experimental syntax 'decorators-legacy' isn't currently enabled
push time in a month
create barnchfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
created branch time in a month
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha a4eb188272468030dfa63da779ad3ce77e63877a
Bump jquery from 3.4.1 to 3.5.0 Bumps [jquery](https://github.com/jquery/jquery) from 3.4.1 to 3.5.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.4.1...3.5.0) Signed-off-by: dependabot[bot] <support@github.com>
commit sha 2123277b1243f29f231dad9539305fc20b758a59
Merge pull request #2 from fcamblor/dependabot/npm_and_yarn/jquery-3.5.0
commit sha 5db6e2e093d2e6e25fef071808e78ad0db451887
enforcing node is greater than v12
commit sha a6495e6b352bf48f25fe0802985ac5cddc3ddd37
updated package-lock versions
push time in a month
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha de2ee131c566b0c89d62cb1bc3c1b21869bb4ce9
Bump jquery from 3.4.1 to 3.5.0 Bumps [jquery](https://github.com/jquery/jquery) from 3.4.1 to 3.5.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](https://github.com/jquery/jquery/compare/3.4.1...3.5.0) Signed-off-by: dependabot[bot] <support@github.com>
commit sha d14979fabeab5ce77d09bf81e68f829055ec61fb
Merge pull request #2 from fcamblor/dependabot/npm_and_yarn/jquery-3.5.0 Bump jquery from 3.4.1 to 3.5.0
push time in a month
PR merged fcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
Bumps jquery from 3.4.1 to 3.5.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jquery/jquery/commit/7a0a850f3d41c0412609c1d32b1e602d4afe2f4e"><code>7a0a850</code></a> 3.5.0</li> <li><a href="https://github.com/jquery/jquery/commit/8570a08f6689223aa06ca8cc51d488c6d81d44f9"><code>8570a08</code></a> Release: Update AUTHORS.txt</li> <li><a href="https://github.com/jquery/jquery/commit/da3dd85b63c4e3a6a768132c2a83a1a6eec24840"><code>da3dd85</code></a> Ajax: Do not execute scripts for unsuccessful HTTP responses</li> <li><a href="https://github.com/jquery/jquery/commit/065143c2e93512eb0c82d1b344b71d06eb7cf01c"><code>065143c</code></a> Ajax: Overwrite s.contentType with content-type header value, if any</li> <li><a href="https://github.com/jquery/jquery/commit/1a4f10ddc37c34c6dc3a451ee451b5c6cf367399"><code>1a4f10d</code></a> Tests: Blacklist one focusin test in IE</li> <li><a href="https://github.com/jquery/jquery/commit/9e15d6b469556eccfa607c5ecf53b20c84529125"><code>9e15d6b</code></a> Event: Use only one focusin/out handler per matching window & document</li> <li><a href="https://github.com/jquery/jquery/commit/966a70909019aa09632c87c0002c522fa4a1e30e"><code>966a709</code></a> Manipulation: Skip the select wrapper for <option> outside of IE 9</li> <li><a href="https://github.com/jquery/jquery/commit/1d61fd9407e6fbe82fe55cb0b938307aa0791f77"><code>1d61fd9</code></a> Manipulation: Make jQuery.htmlPrefilter an identity function</li> <li><a href="https://github.com/jquery/jquery/commit/04bf577e2f961c9dde85ddadc77f71bc7bc671cc"><code>04bf577</code></a> Selector: Update Sizzle from 2.3.4 to 2.3.5</li> <li><a href="https://github.com/jquery/jquery/commit/7506c9ca62a2f3ef773e19385918c31e9d62d412"><code>7506c9c</code></a> Build: Resolve Travis config warnings</li> <li>Additional commits viewable in <a href="https://github.com/jquery/jquery/compare/3.4.1...3.5.0">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mgol">mgol</a>, a new releaser for jquery since your current version.</p> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
</details>
pr closed time in a month
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha 7065cbee447bba3e13430eb6fccc6160c9d4521f
fixed package-lock,json versions
push time in a month
push eventfcamblor/rg-gallery
commit sha 770d33dcdc2b6c687d1874c02f36b2b797677a9b
moved global gallerie config into a dedicated index.d.ts file in case this config will be used across multiple ts files
commit sha 852ac8c0e934ecfeca6301c4846244265c21f311
storing preloaded pictures in dedicated localstorage entries on both fb/rg galleries
commit sha 0492286ee30b02a6dc2fe44c082577e9f0abc33c
fixed service worker registration due to bad base url
commit sha 1e9f637d2749efd68bc88b3cfdc3eee3129010fd
removing 'rg' from application cache names, as we're going to share pictures across rg and fb galleries
commit sha 32864bfc424ad4ab3d13ca6ca01453ab9130e1fc
fixed issue where navigator.serviceWorker.controller was null sometimes, when trying to call postMessage() on it
commit sha da087ece4b702c69801c85171d4378e263ff0bb7
implemented pictures cacche invalidation feature
push time in a month
push eventfcamblor/rg-gallery
commit sha 94758bafde8fdf017f524bd155aefc29c4f2ce58
extracted tab configuration into dedicated config file
commit sha 8b393fb04620b242f63278d90628448bfd8ea20f
added fb galerie page
push time in a month
pull request commentrestx/restx
#315 Upgrade maven-javadoc-plugin to 3.2.0
Thanks 👌
comment created time in a month
push eventrestx/restx
commit sha 7e849f2a0afa5b9bd9fcf5ba5cdca7926d4c306b
#315 Upgrade maven-javadoc-plugin to 3.2.0
commit sha 2304de72e4a22881fa08021c495d469a3362eaba
Merge pull request #320 from nhumblot/315_code_review #315 Upgrade maven-javadoc-plugin to 3.2.0
push time in a month
PR merged restx/restx
Re-factoring accordingly to @fcamblor comment in #315 after the pull request's merge.
pr closed time in a month
push eventfcamblor/rg-gallery
commit sha 15cdd12b2e5dbce20d779b1b38267b93ecd215da
allowing to invalidate pre-loaded pictures
commit sha 06402f2cb0a4d25d3c61c66fb757961b45975ab2
changed order of tab categories
commit sha b8fd9fd6ac221f212b4a545aa5a1e5d8aee0f2b9
moved tab configuration into index.html file
push time in a month
push eventfcamblor/slack-scoring-bot
commit sha 485e6d8696244c7cdaad9f54b61fc099f1fc08f5
preventing to create channels with same config/sheet names
push time in a month
push eventfcamblor/slack-scoring-bot
commit sha 50a251fd140e31d2389e532d924017310b56da30
introduced !reactions-config command allowing to configure this channel's reaction configuration (channel admin only)
push time in a month
issue closedfcamblor/slack-scoring-bot
Sometimes, the bot is receiving the same reaction event multiple times (looks like a slack bug ?)
It would be nice to improve score calculation history in order to prevent counting twice reactions attached to a given message.
For instance, we should :
- Filter messages generating score changes
- Group them by (thread id, thread author, issuer name, target name)
=> If we see more than 1 "consecutive" entries sharing the same
reactionof this grouped tuple happening, then it means that we have duplicates and we should remove these lines (for example, we can't add/remove a 👍 reaction twice in a row to the same message)
closed time in a month
fcamblor
push eventfcamblor/slack-scoring-bot
commit sha 6bf7e7ac91edd7227719c1ad17770b2a45373a45
added some missing type definition in Slack events types
commit sha 92279f3e1e7dfc3e75f15c4e4322fa2a69f453bc
storing message id in reaction logs sheet, in order to be able to identify uniqueness of messages, not only based on their content
commit sha a433c2a6a96387850481195c5c500546b66d46c8
fix ts compilation error
commit sha 78bc0b594135c610bbbbe79e3491436fa4848f70
identifying reaction duplicates in reaction logs when it comes to determining scores, ignoring duplicates in total score
push time in a month
issue closedfcamblor/slack-scoring-bot
When command is performed into a thread, detect it and make the bot answers right into the target thread
closed time in a month
fcamblor
issue commentfcamblor/slack-scoring-bot
fixed through 634f29e
comment created time in a month
push eventfcamblor/slack-scoring-bot
commit sha 634f29ea671f070dcc3e97b3739641fd3a968a2f
when command is sent into a thread, bot should respond into the thread
push time in a month
issue closedfcamblor/slack-scoring-bot
- Showing
!setuphelp is not really relevant (should only be shown when current channel is not setup yet, see #2) - Showing
!update-usersshould only be shown as a "global maintenance" command ... not sure if we shouldn't create a dedicated!help-advancedcommand for this.
closed time in a month
fcamblor
issue commentfcamblor/slack-scoring-bot
fixed through c2688bb
comment created time in a month
issue closedfcamblor/slack-scoring-bot
!help doesn't show anything if !setup has not been performed
Bot should help to !setup channel when calling !help command on a non-setup-ed channel
closed time in a month
fcamblor
issue commentfcamblor/slack-scoring-bot
!help doesn't show anything if !setup has not been performed
fixed through c2688bb
comment created time in a month
push eventfcamblor/slack-scoring-bot
commit sha c2688bbe7dff8e611d5e112ea748414eb902f3db
better help (suggesting when not setup yet + changed order of commands in order to show !scores first)
push time in a month
create barnchfcamblor/slack-scoring-bot
branch : happy-hours-restrictions
created branch time in a month
issue openedfcamblor/slack-scoring-bot
When command is performed into a thread, detect it and make the bot answers right into the target thread
created time in a month
pull request commentrestx/restx
#314 Allow restx-common maven packaging with JDK 11
FYI, simply upgrading to latest maven-javadoc-plugin (3.2.0) made the mvn verify pass with jdk11 on restx-common (I've got another error, but later in the build, on restx-factory module and it seems unrelated)
comment created time in a month
pull request commentrestx/restx
#314 Allow restx-common maven packaging with JDK 11
I guess that your solution source was https://stackoverflow.com/questions/57081473/how-to-make-maven-javadoc-plugin-work-with-any-java-version, correct ?
comment created time in a month
pull request commentrestx/restx
#314 Allow restx-common maven packaging with JDK 11
forget, the issue seems unrelated (got caught by issue title :-) )
comment created time in a month
pull request commentrestx/restx
#314 Allow restx-common maven packaging with JDK 11
@nhumblot seems like you hit https://issues.apache.org/jira/browse/MJAVADOC-580
Did you try upgrading to maven-javadoc-plugin@3.1.0 (or greater) ?
I guess this may fix the issue in a more beautiful way (avoiding maven profile for detecting javadoc path)
comment created time in a month
issue openedfcamblor/slack-scoring-bot
- Showing
!setuphelp is not really relevant (should only be shown when current channel is not setup yet, see #2) - Showing
!update-usersshould only be shown as a "global maintenance" command ... not sure if we shouldn't create a dedicated!help-advancedcommand for this.
created time in a month
issue openedfcamblor/slack-scoring-bot
Sometimes, the bot is receiving the same reaction event multiple times (looks like a slack bug ?)
It would be nice to improve score calculation history in order to prevent counting twice reactions attached to a given message.
For instance, we should :
- Filter messages generating score changes
- Group them by (thread id, thread author, issuer name, target name)
=> If we see more than 1 "consecutive" entries sharing the same
reactionof this grouped tuple happening, then it means that we have duplicates and we should remove these lines (for example, we can't add/remove a 👍 reaction twice in a row to the same message)
created time in a month
issue openedfcamblor/slack-scoring-bot
!help doesn't show anything if !setup has not been performed
Bot should help to !setup channel when calling !help command on a non-setup-ed channel
created time in a month
pull request commentLAB-MI/deplacement-covid-19
Ne faudrait-il pas fournir un palliatif aux données du QR Code lorsqu'on décide de ne pas l'afficher ? Car actuellement, les données de la page 1 du PDF sont écrits vraiment petit et nécessiterait de s'approcher du téléphone très près pour pouvoir les lire.
J'aurais imaginé quelque chose comme une page 2 en mode paysage avec :
comment created time in a month
issue commentLAB-MI/deplacement-covid-19
Problème de sécurité concernant le QR code
@xgaia la discussion me fait avancer dans ma réflexion...
En fait, je m'interroge sur le processus d'un contrôle avec l'attestation : à quoi servent toutes les données qu'on renseigne dans l'attestation ?
N'ayant moi-même jamais été controlé, je ne suis pas sûr de ce que j'avance, mais j'imagine que :
- les 4 premiers champs (nom, prénom, date naissance, lieu de naissance) du formulaire servent pour être croisées avec une pièce d'identité afin de valider que c'est bien "nous" qui sommes concernés par l'attestation => identification
- l'adresse / ville / code postal permettent de connaître notre "point géographique de départ", à comparer avec le "point géographique du contrôle" (si vous habitez à Nantes et qu'on vous contrôle à Bordeaux, il y a un soucis si vous êtes sortis faire des courses) => vérification (géographique)
- le motif permet de connaître la raison du déplacement => vérification (motivation)
- la date/heure de sortie permettent de connaître la durée, jusqu'au point de contrôle, du déplacement => vérification (temporelle)
=> On a donc clairement une dichotomie entre données d'identification et données de vérifications
Nous discutons ici du point 1, et je m'interroge sur la manière dont les forces de l'ordre croisent les infos de l'attestation avec celles de la pièce d'identité utilisée. J'ose espérer qu'ils ne prennent jamais cette dernière en main (sinon, pour le coup, le QR code serait totalement inutile comme limiteur de contacts) et, si je comprends bien votre raisonnement, @xgaia, le simple fait d'afficher sur l'écran du téléphone les informations importantes (cf points 1/2/3/4 ci-dessus) du PDF généré serait suffisant pour le croisement avec la pièce d'identité et les vérifs 2 -> 4 et éviterait de s'interroger sur un potentiel tracking des données lors d'un contrôle.
Si c'est le cas, je suis plutôt d'accord (sur le principe) avec vous finalement (mais je reste persuadé que la grande partie des utilisateurs s'en ficheront, et que pour les autres, "au pire" il reste l'attestation papier même si ça ne fera pas plaisir à Milou :-) )
En fait, tout cela me fait surtout m'interroger sur le bien fondé de mettre dans le QR Code les informations de vérification (points 2/3/4), qui incluent notamment l'adresse.
Pour moi, ces informations sont "volatiles" (même si on n'est pas censé changer d'adresse pendant le confinement...) et ne devraient pas avoir vocation à être davantage partagées que par écrit.
J'imagine qu'elles sont dans le QR Code uniquement à des fins de "simplicité ergonomiques" pour les forces de l'ordre, afin qu'elles puissent être parcourues facilement sur leur terminal ... mais cette "simplicité ergonomique" a un coût : le fait d'engager la confiance dans le traitement qui est fait de ces données et de nous interroger ici de leur bien fondé.
comment created time in a month
issue commentLAB-MI/deplacement-covid-19
Problème de sécurité concernant le QR code
Rien n'oblige les utilisateurs à utiliser l'application : s'ils souhaitent continuer à imprimer (ou à reproduire de manière manuscrite) le formulaire libre à eux de le faire, seuls les arbres leur en tiendront rigueur.
comment created time in a month
issue commentLAB-MI/deplacement-covid-19
Problème de sécurité concernant le QR code
En effet, la personne qui va le scanner peux sauvegarder les QR codes scanné dans la journée.
En raisonnant comme ça, on peut aussi se dire que la personne peut prendre en photo le formulaire papier, ou encore votre tête, la plaque d'immatriculation du véhicule etc...
Le QR Code n'est qu'un "facilitateur" à la saisie, qui a l'avantage d'éviter tout contact entre la personne concernée et les forces de l'ordre (pour réduire les chances de transmission du virus, dans un sens comme dans l'autre).
Aucune donnée n'étant envoyée à une tierce partie (au moins au moment de la "génération" de ce dernier), je trouve qu'il s'agit là d'un bon compromis. Après, on ne peut savoir ce que les FDO feront des données récupérées lors d'un contrôle .. mais ça, c'est pas la génération (ou pas) d'un QR Code qui va y changer quoi que ce soit :-)
comment created time in a month
issue commentLAB-MI/deplacement-covid-19
Sécurité : il est possible de falsifier l'heure à laquelle a été généré le PDF
Après la question est : est-ce vraiment important d'éviter la falsification ?
Tellement d'accord avec ça...
J'ajouterais : n'est-ce pas se tirer une balle dans le pied que d'envoyer un contenu chiffré (même en toute bonne foi, sans possibilité par le serveur de revenir à l'information d'origine) à un serveur ?
N'est-ce pas ouvrir la boîte de pandore sur une mauvaise interprétation de ces informations par les réseaux sociaux ? (on est tracé par le gouvernement, toussa...)
comment created time in 2 months
issue commentLAB-MI/deplacement-covid-19
Problème de sécurité concernant le QR code
Dans la mesure où ce QR code n'est censé être lu que par un logiciel spécial à disposition des forces de l'ordre, il serait judicieux de chiffrer les données.
Attention : pour pouvoir faire ceci :
- Soit c'est fait sur le client, et alors la clef de chiffrage sera (facilement) connue de tous, et donc inutile IMHO
- Soit c'est fait sur le serveur, et cela nécessitera l'envoi de nos données privées sur un serveur où nous ne sauront pas ce qu'il en sera fait
Personnellement, le fonctionnement actuel me satisfait complètement.
comment created time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha 9fa949608d99f9f3a00506f1e882f8e611d3fd01
provided configuration documentation
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha 2c08f6759374970a76bfbeb992fee1d521d3b691
provided configuration documentation
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha 82eb4899d11e1f0df52ad9ee1ec3d4eb4db07159
added installation precisions
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha 74cf5c63af76718d3a6ae6d08be42e6496d86231
added installation precisions
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha 5826a3ba755bfc1857c8aa9af7f72b56a63a6435
renamed directory spreadsheet to slack-scores-sheet as directory name is used for the spreadsheet name
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha f2ad29c35bbee57d023585d3415be07052bcc698
renamed some channel config properties in the spreadsheet
commit sha 8fdb7b75365533d964030f483fc9c22dce22b382
showing log only if spreadsheet id is provided and slack challenge is not activated
commit sha bc0e7700da17dc9b040c851b8327c4e4aeea482d
showing leaderboard link only when available + putting a reminder to create this link after !setup
commit sha 4e3b8253dcc8718bd15c95f6fb5edb6b51b3b9ff
simplified a bit code using Array.map
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha bffe2bfa8802f63cc093e5c4901c247fab671c18
imported bot implementation, converted to typescript
commit sha 4a1fe25a705c59418dc5fdd8ceee9f1a53690dcd
created module for spreadsheet
commit sha 8d9d6b309cb9b7fe38bac9cf1aac6ced845787d4
imported spreadsheet app script converted to typescript
commit sha 9040094966043eb7c6664dcc8cf06df5ffb20f2d
moved bot stuff into scoring-slack-bot directory (as directory is going to be app script's default name)
commit sha bbe4f070a15cdd154f9de0367658bac9783b6eac
added readme file
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha b8bd20f2b3fa48106f60e9d28d8b18f3d0f6b434
added readme file
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha cdb236d4ad95658c79f1356a3ba6e49ac1e42528
added readme file
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha b90745194e1c9baa08bd8b8036ffb2bfdfb6339d
added readme file
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha 67395a62c82abf851595f8cb429c32ce4f9d46d9
imported bot implementation, converted to typescript
commit sha f3b39ad25f89d12dc75a0c9e2d7b89af7d26404e
created module for spreadsheet
commit sha 24dab2a411f1bfa2cbebd1fe7a85ed2caba7beef
imported spreadsheet app script converted to typescript
commit sha 4aaca97e2e70ef043e1dd6ec0ef392678524b024
moved bot stuff into scoring-slack-bot directory (as directory is going to be app script's default name)
commit sha 264647e38e7a9b8fe6f307fbbd6903e86cfeff76
added readme file
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha 7ffb618dbdfd9c534746aad5ed5ded5dd59c53c3
moved bot stuff into scoring-slack-bot directory (as directory is going to be app script's default name)
commit sha d959246d140b456e30623d49df1d75f6615fd9a3
added readme file
push time in 2 months
push eventfcamblor/slack-scoring-bot
commit sha e22d4174ecd2880edf7ab8d340c7770779648b2a
installing typescript, clasp and google-app-script typings
commit sha 12683c7837165e38c0d64480615ebc7e47114bce
created clasp project
commit sha aaed2de25d9e6531b2da2de7dbd20c5a9f69f24c
script should be executed as deployer and be accessible as an anonymous user
commit sha 28ada89b088cb89099fc51b16e191d8ab43def7d
ignoring intellij files
commit sha 5a4f03ac9d7de49ccd05fa1e9f7974fb4881cf13
imported bot implementation, converted to typescript
commit sha 5ce5070dbeb3d797d6bc2f93b7eb8a2fb5920968
created module for spreadsheet
commit sha b4cb95b8e181cabbd8bc66b7f266ed004d3d28c3
imported spreadsheet app script converted to typescript
push time in 2 months
created repositoryfcamblor/slack-scoring-bot
Slack bot for handling per-channel questions & scores
created time in 2 months
issue commentapache/cordova-cli
cordova run xxx regularly updates package.json with an empty line
BTW, @arzyu seems to have implemented a plugin just for this purpose ( that's crazy x-D )
comment created time in 2 months
issue closedapache/cordova-cli
cordova run xxx regularly updates package.json with an empty line
Bug Report
Problem
Everytime I run cordova run browser, my package.json file is locally updated :
What is expected to happen?
package.json is left unmodified, after any cordova run call (which sounds to be idempotent)
What does actually happen?
A new line is added at the end of package.json
Information
You have a reproducer script below
Command or Code
mkdir /tmp/cordova-sample/ && cd /tmp/cordova-sample/
git init && npm init
npm install --save-dev cordova@9.0.0
echo node_modules/ > .gitignore
git add . && git commit -m "initial commit"
npx cordova create tmp-cordova && rm tmp-cordova/package.json && mv tmp-cordova/* ./ && rm -Rf tmp-cordova/
echo platforms >> .gitignore
echo plugins >> .gitignore
git add . && git commit -m "created cordova app"
npx cordova platform add browser@6.0.0
git add . && git commit -m "added browser platform"
# installing a random npm package, resulting in changes in package.json
npm install --save-dev noop
git add . && git commit -m "added no-op package"
# running a cordova run command
npx cordova run browser
# End of line appended at the end of the package.json line
git diff
Environment, Platform, Device
Mac OS X 10.14.4
Version information
Tested on cordova cli 7.1.0, 8.1.2 and 9.0.0
No matter the platform and its version.
Checklist
- [X] I searched for existing GitHub issues
- [X] I updated all Cordova tooling to most recent version
- [X] I included all the necessary information above
closed time in 2 months
fcamblor
issue commentapache/cordova-cli
cordova run xxx regularly updates package.json with an empty line
For history, seems a duplicate of #353 and #394 => closing as 353 is the placeholder for this issue
comment created time in 2 months
push eventfcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
commit sha 64fe481acaeb67c8f8b721dac6ce5d8b2f7871ab
Bump minimist from 1.2.0 to 1.2.5 Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.5. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.5) Signed-off-by: dependabot[bot] <support@github.com>
commit sha 654b4e7c0a07b9738fe04b34a4e071baf5af636b
Merge pull request #1 from fcamblor/dependabot/npm_and_yarn/minimist-1.2.5 Bump minimist from 1.2.0 to 1.2.5
push time in 2 months
PR merged fcamblor/lit-element-typescript-sass-constructible-stylesheet-starter
Bumps minimist from 1.2.0 to 1.2.5. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/substack/minimist/commit/aeb3e27dae0412de5c0494e9563a5f10c82cc7a9"><code>aeb3e27</code></a> 1.2.5</li> <li><a href="https://github.com/substack/minimist/commit/278677b171d956b46613a158c6c486c3ef979b20"><code>278677b</code></a> 1.2.4</li> <li><a href="https://github.com/substack/minimist/commit/4cf1354839cb972e38496d35e12f806eea92c11f"><code>4cf1354</code></a> security notice</li> <li><a href="https://github.com/substack/minimist/commit/1043d212c3caaf871966e710f52cfdf02f9eea4b"><code>1043d21</code></a> additional test for constructor prototype pollution</li> <li><a href="https://github.com/substack/minimist/commit/6457d7440a47f329c12c4a5abfbce211c4235b93"><code>6457d74</code></a> 1.2.3</li> <li><a href="https://github.com/substack/minimist/commit/38a4d1caead72ef99e824bb420a2528eec03d9ab"><code>38a4d1c</code></a> even more aggressive checks for protocol pollution</li> <li><a href="https://github.com/substack/minimist/commit/13c01a5327736903704984b7f65616b8476850cc"><code>13c01a5</code></a> more failing proto pollution tests</li> <li><a href="https://github.com/substack/minimist/commit/f34df077a6b2bee1344188849a95e66777109e89"><code>f34df07</code></a> 1.2.2</li> <li><a href="https://github.com/substack/minimist/commit/67d3722413448d00a62963d2d30c34656a92d7e2"><code>67d3722</code></a> cleanup</li> <li><a href="https://github.com/substack/minimist/commit/63e7ed05aa4b1889ec2f3b196426db4500cbda94"><code>63e7ed0</code></a> don't assign onto <strong>proto</strong></li> <li>Additional commits viewable in <a href="https://github.com/substack/minimist/compare/1.2.0...1.2.5">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
</details>
pr closed time in 2 months