profile
viewpoint
Evan Lucas evanlucas Austin, TX https://evanlucas.com @nodejs TSC Emeritus

evanlucas/apex7000 3

package for interfacing with the Apex 7000 bill acceptor

evanlucas/assert6 2

Node assert with support for Maps and Sets

evanlucas/argsplit-swift 1

Swift port of https://github.com/evanlucas/argsplit

esatterwhite/eslint-plugin-sensible 0

Better comma first indent rules for eslint

evanlucas/a2switch 0

CLI tool for quickly switching between Apache configurations

evanlucas/ampersand-calendar 0

Creates an SVG calendar using D3.

evanlucas/ampersand-chart 0

Bar charts for AmpersandJS using D3.

evanlucas/ampersand-filter-tracker 0

Creates both a GUI and a filter from multiple models.

evanlucas/ampersand-search-select 0

Creates a search bar that shows a list of matching items that can be selected.

push eventevanlucas/libuv

cjihrig

commit sha 60823103332df5732dcbe92535ceb3aa916084c9

Add SHA to ChangeLog

view details

cjihrig

commit sha c42d31ba53dba89b27104a9cdbe86d5894eb6c9e

Now working on version 1.11.1

view details

Santiago Gimeno

commit sha c355c8b1a64f155a4bcfed748b45e6f43cb4dc23

test: fix tests on OpenBSD It fixes `process_title`, `poll_bad_fdtype` and `poll_nested_kqueue` tests. Fixes: https://github.com/libuv/libuv/issues/1216 PR-URL: https://github.com/libuv/libuv/pull/1218 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Santiago Gimeno

commit sha 309d603382159eacdf52cbf0fa936deb60552d32

test: fix -Wformat warning Substitute the `z` length modifier with `l` to avoid warnings, as the `z` modifier is defined in the C99 standard. PR-URL: https://github.com/libuv/libuv/pull/1220 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

Vladimir Matveev

commit sha 02dcde08386441d5a89dbcb602a1ad367a506cc0

win,fs: avoid double freeing uv_fs_event_t.dirw Set `dirw` to `pathw` after `uv_fs_event_start` is known to be completed successfully. Fixes: https://github.com/libuv/libuv/issues/1221 PR-URL: https://github.com/libuv/libuv/pull/1222 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

Fedor Indutny

commit sha 52ae826492f50f151138ed115faa5e0ac8c803ce

unix: remove unused code in `uv__io_start` The code path in `uv__io_start` cannot be reached because `pevents` is always non-zero at that point. PR-URL: https://github.com/libuv/libuv/pull/1227 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Santiago Gimeno

commit sha 45616f542da523b3d87a8d379bb116ffc3a97845

signal: add uv_signal_start_oneshot method It behaves as `uv_signal_start` but it resets the signal handler as soon as the signal is received. Fixes: https://github.com/libuv/libuv/issues/1104 PR-URL: https://github.com/libuv/libuv/pull/1106 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

view details

Brad King

commit sha 2ba39be67e948f8b99af7cf408828f1507371fd5

unix: factor out reusable POSIX hrtime impl Create a dedicated source file to share among platforms on which we implement hrtime using POSIX `clock_gettime`. De-duplicate our existing copies of this implementation on such platforms. PR-URL: https://github.com/libuv/libuv/pull/1239 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

cjihrig

commit sha ee02f60c90bbf01e2107b3800b3dfbbe090484ab

unix,win: add uv_os_{get,set,unset}env() These functions are used to create, retrieve, update, and delete environment variables. Fixes: https://github.com/libuv/libuv/issues/1198 PR-URL: https://github.com/libuv/libuv/pull/1234 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

cjihrig

commit sha 53995a3825d23eacd01e2bcfa35642c4a188d32b

win: add uv__convert_utf8_to_utf16() This is an internal helper function for converting UTF-8 strings to UTF-16 strings. It performs the inverse operation of the existing uv__convert_utf16_to_utf8() function. Fixes: https://github.com/libuv/libuv/issues/1198 PR-URL: https://github.com/libuv/libuv/pull/1234 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

cjihrig

commit sha c4bd9f48e0b3c1b58606a6c53613165fcd5a4f74

docs: improve UV_ENOBUFS scenario documentation This commit adds additional documentation to the UV_ENOBUFS scenario for several methods. Fixes: https://github.com/libuv/libuv/issues/1179 PR-URL: https://github.com/libuv/libuv/pull/1235 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

jBarz

commit sha 399b08aa9f02362a14f8d2975ac7f70b91bb0963

unix: return UV_EINVAL for NULL env name "setenv" on z/OS returns successfully on a NULL ptr argument for name. Check for this on all unixes. PR-URL: https://github.com/libuv/libuv/pull/1243 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

Brad King

commit sha 80c4cf6b6238eadab1466eb69bce9f01a51ad98c

unix: filter getifaddrs results consistently We loop over getifaddrs results multiple times. Fix the filter conditions to be consistent for all passes. PR-URL: https://github.com/libuv/libuv/pull/1240 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

Brad King

commit sha 0f84c305e0bf54d3b5b5e324f0e117625016adb6

unix: factor out getifaddrs result filter On platforms using getifaddrs we iterate over the interfaces two or three times. First we count them, then we enumerate them, and then we fill in physical addresses. Each loop needs to do the same filtering, so factor out the exclusion test into a helper function for each platform. PR-URL: https://github.com/libuv/libuv/pull/1240 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

Brad King

commit sha f277cb6f920f0abbb2fb314861b3d79ef1de02fd

unix: factor out reusable BSD ifaddrs impl Create a dedicated source file to share among platforms on which we find ifaddrs using the BSD getifaddrs API. De-duplicate our existing copies of this implementation on such platforms. PR-URL: https://github.com/libuv/libuv/pull/1240 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

jBarz

commit sha d7cf771072b3153e7641a9cef61160974cee8a39

unix: use union to follow strict aliasing rules With strict-aliasing rules, a char* type can be cast to any other pointer type. However, that does not necessarily mean char array type. So instead of de-referencing a char array, use a union with an additional char member for aliasing. PR-URL: https://github.com/libuv/libuv/pull/1211 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

Ben Noordhuis

commit sha 5fc8aecd81dbb31e76bd80834bb73b0e9b1e5c4c

unix: simplify async watcher dispatch logic Remove the unused `nevents` parameter from `uv__async_event()` and remove the indirection of having a separate `uv__async` type. There is only one instance per event loop these days. This incidentally removes the `assert(n == sizeof(val))` in a Linux-specific code path that some users seem to hit from time to time. The cause is not well-understood and I've never been able to reproduce it myself. Presumably libuv gets an EAGAIN when trying to read from the eventfd but when and why that happens is unclear. Since the byte count is unused, removing the assert seems safe. Worst case, libuv sometimes iterates over the async watcher list when it doesn't have to. Fixes: https://github.com/libuv/libuv/issues/1171 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Supersedes: https://github.com/libuv/libuv/pull/1214

view details

Ben Noordhuis

commit sha 7b9f379923fc97817c873e25b34d46bb68897f8e

samples: update timer callback prototype The socks5 proxy sample application was still using the old prototype where timer callbacks take a second 'status' parameter but that was removed in commit db2a9072 ("unix, windows: removed unused status parameter") from March 2014. PR-URL: https://github.com/libuv/libuv/pull/1250 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

Jason Madden

commit sha fd7ce57f2b14651482c227898f6999664db937de

unix: make loops and watchers usable after fork() Added the uv_loop_fork() API that must be called in a child process to continue using an existing loop. Internally this calls a uv__io_fork function for each supported platform, similar to the way uv__platform_loop_init works. After this call, existing and new IO, async and signal watchers will contiue working as before on all platforms, as will the threadpool (although any threads it was using are of course gone). On Linux and BSDs that use kqueue, existing and new fsevent watchers will also continue to work as expected. On OS X, though, directory fsevents will not be able to use the optimized CoreFoundation path if they had already been used in the parent process, instead falling back to the kqueue path used on other BSDs. Existing fsevent watchers will not function on AIX or SunOS. This could be relatively easily fixed by someone with AIX knowledge in the future, but SunOS will require some additional work to keep track if the watchers. A new test file, test/test-fork.c, was added to contain fork-related tests to verify functionality in the child process. PR-URL: https://github.com/libuv/libuv/pull/846 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

view details

cjihrig

commit sha e7a7ffb1524326d6a431f219b07278ceaebac915

win: free uv__loops once empty This commit moves the allocation of uv__loops into uv__loops_add() and frees all of the memory associated with uv__loops in uv__loops_remove() once the loop count reaches zero. Fixes: https://github.com/libuv/libuv/issues/1125 Fixes: https://github.com/libuv/libuv/issues/1252 PR-URL: https://github.com/libuv/libuv/pull/1262 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

view details

push time in 2 days

push eventevanlucas/node

Milad Farazmand

commit sha de501d281cc96582f82dc56364a10019bb62c912

deps: V8: cherry-pick b5939c758924 Original commit message: Revert "s390: [arm] Add missing RELATIVE_CODE_TARGET iteration" This reverts commit 9d3cca1cd3ad7c6653cab1cdf111d356f33f77cd. Reason for revert: Only the test needs to be skipped on s390. Refer to this: https://crrev.com/c/1981505 Original change's description: > s390: [arm] Add missing RELATIVE_CODE_TARGET iteration > > Port b766299d2c382cc9817e73225bbebe29ce62b9d1 > Port 9592b043eed86db91a441d4bf78b7f0c8c2ce4dd > Port d915b8d668615a7d6d75cf7a61d3ca5a3d139799 > > Original Commit Message: > > Code object iteration was missing logic for RELATIVE_CODE_TARGET > reloc entries. Garbage collection could thus miss objects that were > referenced only as targets of pc-relative calls or jumps. > > RELATIVE_CODE_TARGETs are only used on arm, mips, and s390 and only > at mksnapshot-time. > > This exposed another issue in that the interpreter entry trampoline > copy we generate for profiling *did* contain relative calls in > runtime-accessible code. This is a problem, since code space on arm is, > by default, too large to be fully addressable through pc-relative > calls. This CL thus also disables the related > FLAG_interpreted_frames_native_stack feature on arm. > > objects. > > R=​jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > LOG=N > > Change-Id: Ifbcaed98d90a2730f0d6a8a7d32c621dab1ff5b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087693 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#66644} TBR=michael_dawson@ca.ibm.com,mlippautz@chromium.org,jyan@ca.ibm.com,jgruber@chromium.org,joransiu@ca.ibm.com,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id645a9def23d278235ff77f25249d2187e8105ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196521 Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67751} Refs: https://github.com/v8/v8/commit/b5939c758924f56824ca137e3bdc47bb373443e9 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Milad Farazmand

commit sha 651088c3e6b6399a3e656e397c3845b970ad7903

deps: V8: cherry-pick 4e1bf2bc92bd Original commit message: Skip InterpreterWithNativeStack on jitless mode As discussed under https://crrev.com/c/1981505, Test requires an executable CODE_SPACE and is thus incompatible with jitless mode. Change-Id: Icddad50a3484f0cfc5fb4abd7175058d50bc06d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193911 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67726} Refs: https://github.com/v8/v8/commit/4e1bf2bc92bd8560353ba2af2f171045bbecb7c7 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Brian White

commit sha 4ba90809edec189a2c4662258ef6cadb9d9620b4

events: improve arrayClone performance PR-URL: https://github.com/nodejs/node/pull/33774 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

cjihrig

commit sha 2e49010bc8f2d05f6b0eca66bd9fca08cb5745a5

doc: make events Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the events documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 85dbd17bde1049022854581d09dc7d48fc6e6d24

doc: make perf_hooks Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the perf_hooks documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 862d005e603e8897336ee021094106c402603c2d

doc: make globals Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the globals documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha fd7e40854c447234a05dc3ef0ee717cad138c681

doc: update V8 inspector example This commit updates the V8 inspector example to reflect what is currently printed to the console. PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

cjihrig

commit sha 921f75534cdc2ad6fdc61c573d18f61ca14b35da

inspector: drop 'chrome-' from inspector url It has been reported that the https://github.com/cjihrig/node-v8-inspector V8 inspector extension can no longer connect DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the chrome-devtools: scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome. Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779 PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

legendecas

commit sha 5590ee0d99a867f115a8eeced15a63be6bfaf298

test: fix invalid regular expressions in case test-trace-exit PR-URL: https://github.com/nodejs/node/pull/33769 Fixes: https://github.com/nodejs/node/issues/30516 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Dennis Ameling

commit sha 35871c3e404d4378802efa9cbb41494a5835aa89

win,msi: add arm64 config for windows msi Adds configuration to allow building an MSI installer for Windows ARM64. MSI can be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/33689 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

view details

Anna Henningsen

commit sha 4678e44bb28c00dc22771a0ef2684a4d46715ab0

src: perform bounds checking on error source line Fixes: https://github.com/nodejs/node/issues/33578 PR-URL: https://github.com/nodejs/node/pull/33645 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

unknown

commit sha 278aae28e14da89e6bd6d91c07ded2dc5f8fe8c3

zlib: add `maxOutputLength` option Fixes: https://github.com/nodejs/node/issues/27253 PR-URL: https://github.com/nodejs/node/pull/33516 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Michael Dawson

commit sha 502f53ff491c33b320d1f6fd70bd2da05874f1f1

test: temporarily exclude test on arm Refs: https://github.com/nodejs/node/issues/33796 Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33814 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Michael Dawson

commit sha 362e4a1aec46f386b7bc5a1b3493c690976d9105

n-api: ensure scope present for finalization Refs: https://github.com/nodejs/node-addon-api/issues/722 Ensure a scope is on stack during finalization as finalization functions can create JS Objects Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33508 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 0f9d474c524e5132423a96db05d2b2541fcda121

doc: standardize constructor doc header layout Our docs use a mixture of _Constructor: `new Fhqwhgads()`_ in some headers and only _`new Fhqwhgads()`_ in other headers. The latter is about three times as common, so let's standardize on that. PR-URL: https://github.com/nodejs/node/pull/33781 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Derek Lewis

commit sha f4e805c86082fcf8157c745e71977cc343dd1bc4

doc: fix misc. mislabeled code block info strings Prior to this commit, a handful of misc. code blocks were in need of fixup. Corrections are according to predetermined conventions. Closes: https://github.com/nodejs/node/issues/32938 PR-URL: https://github.com/nodejs/node/pull/33548 Fixes: https://github.com/nodejs/node/issues/32938 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Daniel Bevenius

commit sha cf32b4c74d84774e5465f6307acbbdb85846a634

doc: use single quotes in --tls-cipher-list Currently, running the example code will produce the following error in bash: $ node --tls-cipher-list="ECDHE-RSA-AES128-GCM-SHA256:!RC4" server.js bash: !RC4: event not found This commit changes the two examples to use single quotes to avoid the shell from trying to interpret '!' as the history command. PR-URL: https://github.com/nodejs/node/pull/33709 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Andrey Pechkurov

commit sha db3d6b38b6a20f0caf432077a585bf51af5d06f4

doc: add snippet for AsyncResource and EE integration PR-URL: https://github.com/nodejs/node/pull/33751 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>

view details

Gus Caplan

commit sha 4faec56b8aaf4750167c8883ead90244c1e17341

vm: allow proxy callbacks to throw Fixes: https://github.com/nodejs/node/issues/33806 PR-URL: https://github.com/nodejs/node/pull/33808 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 58bae4d0ef4802e472204d5e18d7dbb7296878d1

util: restrict custom inspect function + vm.Context interaction When `util.inspect()` is called on an object with a custom inspect function, and that object is from a different `vm.Context`, that function will not receive any arguments that access context-specific data anymore. PR-URL: https://github.com/nodejs/node/pull/33690 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 11 days

delete branch evanlucas/node

delete branch : node-consistency

delete time in 13 days

push eventevanlucas/node

Milad Farazmand

commit sha de501d281cc96582f82dc56364a10019bb62c912

deps: V8: cherry-pick b5939c758924 Original commit message: Revert "s390: [arm] Add missing RELATIVE_CODE_TARGET iteration" This reverts commit 9d3cca1cd3ad7c6653cab1cdf111d356f33f77cd. Reason for revert: Only the test needs to be skipped on s390. Refer to this: https://crrev.com/c/1981505 Original change's description: > s390: [arm] Add missing RELATIVE_CODE_TARGET iteration > > Port b766299d2c382cc9817e73225bbebe29ce62b9d1 > Port 9592b043eed86db91a441d4bf78b7f0c8c2ce4dd > Port d915b8d668615a7d6d75cf7a61d3ca5a3d139799 > > Original Commit Message: > > Code object iteration was missing logic for RELATIVE_CODE_TARGET > reloc entries. Garbage collection could thus miss objects that were > referenced only as targets of pc-relative calls or jumps. > > RELATIVE_CODE_TARGETs are only used on arm, mips, and s390 and only > at mksnapshot-time. > > This exposed another issue in that the interpreter entry trampoline > copy we generate for profiling *did* contain relative calls in > runtime-accessible code. This is a problem, since code space on arm is, > by default, too large to be fully addressable through pc-relative > calls. This CL thus also disables the related > FLAG_interpreted_frames_native_stack feature on arm. > > objects. > > R=​jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > LOG=N > > Change-Id: Ifbcaed98d90a2730f0d6a8a7d32c621dab1ff5b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087693 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#66644} TBR=michael_dawson@ca.ibm.com,mlippautz@chromium.org,jyan@ca.ibm.com,jgruber@chromium.org,joransiu@ca.ibm.com,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id645a9def23d278235ff77f25249d2187e8105ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196521 Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67751} Refs: https://github.com/v8/v8/commit/b5939c758924f56824ca137e3bdc47bb373443e9 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Milad Farazmand

commit sha 651088c3e6b6399a3e656e397c3845b970ad7903

deps: V8: cherry-pick 4e1bf2bc92bd Original commit message: Skip InterpreterWithNativeStack on jitless mode As discussed under https://crrev.com/c/1981505, Test requires an executable CODE_SPACE and is thus incompatible with jitless mode. Change-Id: Icddad50a3484f0cfc5fb4abd7175058d50bc06d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193911 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67726} Refs: https://github.com/v8/v8/commit/4e1bf2bc92bd8560353ba2af2f171045bbecb7c7 PR-URL: https://github.com/nodejs/node/pull/33702 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Brian White

commit sha 4ba90809edec189a2c4662258ef6cadb9d9620b4

events: improve arrayClone performance PR-URL: https://github.com/nodejs/node/pull/33774 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

cjihrig

commit sha 2e49010bc8f2d05f6b0eca66bd9fca08cb5745a5

doc: make events Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the events documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 85dbd17bde1049022854581d09dc7d48fc6e6d24

doc: make perf_hooks Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the perf_hooks documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 862d005e603e8897336ee021094106c402603c2d

doc: make globals Extends usage consistent The docs use `* Extends: {type}` to define inheritance. This commit updates the globals documentation to be consistent. PR-URL: https://github.com/nodejs/node/pull/33777 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha fd7e40854c447234a05dc3ef0ee717cad138c681

doc: update V8 inspector example This commit updates the V8 inspector example to reflect what is currently printed to the console. PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

cjihrig

commit sha 921f75534cdc2ad6fdc61c573d18f61ca14b35da

inspector: drop 'chrome-' from inspector url It has been reported that the https://github.com/cjihrig/node-v8-inspector V8 inspector extension can no longer connect DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the chrome-devtools: scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome. Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779 PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

legendecas

commit sha 5590ee0d99a867f115a8eeced15a63be6bfaf298

test: fix invalid regular expressions in case test-trace-exit PR-URL: https://github.com/nodejs/node/pull/33769 Fixes: https://github.com/nodejs/node/issues/30516 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Dennis Ameling

commit sha 35871c3e404d4378802efa9cbb41494a5835aa89

win,msi: add arm64 config for windows msi Adds configuration to allow building an MSI installer for Windows ARM64. MSI can be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/33689 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

view details

Anna Henningsen

commit sha 4678e44bb28c00dc22771a0ef2684a4d46715ab0

src: perform bounds checking on error source line Fixes: https://github.com/nodejs/node/issues/33578 PR-URL: https://github.com/nodejs/node/pull/33645 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

unknown

commit sha 278aae28e14da89e6bd6d91c07ded2dc5f8fe8c3

zlib: add `maxOutputLength` option Fixes: https://github.com/nodejs/node/issues/27253 PR-URL: https://github.com/nodejs/node/pull/33516 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Michael Dawson

commit sha 502f53ff491c33b320d1f6fd70bd2da05874f1f1

test: temporarily exclude test on arm Refs: https://github.com/nodejs/node/issues/33796 Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33814 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Michael Dawson

commit sha 362e4a1aec46f386b7bc5a1b3493c690976d9105

n-api: ensure scope present for finalization Refs: https://github.com/nodejs/node-addon-api/issues/722 Ensure a scope is on stack during finalization as finalization functions can create JS Objects Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33508 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 0f9d474c524e5132423a96db05d2b2541fcda121

doc: standardize constructor doc header layout Our docs use a mixture of _Constructor: `new Fhqwhgads()`_ in some headers and only _`new Fhqwhgads()`_ in other headers. The latter is about three times as common, so let's standardize on that. PR-URL: https://github.com/nodejs/node/pull/33781 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Derek Lewis

commit sha f4e805c86082fcf8157c745e71977cc343dd1bc4

doc: fix misc. mislabeled code block info strings Prior to this commit, a handful of misc. code blocks were in need of fixup. Corrections are according to predetermined conventions. Closes: https://github.com/nodejs/node/issues/32938 PR-URL: https://github.com/nodejs/node/pull/33548 Fixes: https://github.com/nodejs/node/issues/32938 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Daniel Bevenius

commit sha cf32b4c74d84774e5465f6307acbbdb85846a634

doc: use single quotes in --tls-cipher-list Currently, running the example code will produce the following error in bash: $ node --tls-cipher-list="ECDHE-RSA-AES128-GCM-SHA256:!RC4" server.js bash: !RC4: event not found This commit changes the two examples to use single quotes to avoid the shell from trying to interpret '!' as the history command. PR-URL: https://github.com/nodejs/node/pull/33709 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Andrey Pechkurov

commit sha db3d6b38b6a20f0caf432077a585bf51af5d06f4

doc: add snippet for AsyncResource and EE integration PR-URL: https://github.com/nodejs/node/pull/33751 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>

view details

Gus Caplan

commit sha 4faec56b8aaf4750167c8883ead90244c1e17341

vm: allow proxy callbacks to throw Fixes: https://github.com/nodejs/node/issues/33806 PR-URL: https://github.com/nodejs/node/pull/33808 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 58bae4d0ef4802e472204d5e18d7dbb7296878d1

util: restrict custom inspect function + vm.Context interaction When `util.inspect()` is called on an object with a custom inspect function, and that object is from a different `vm.Context`, that function will not receive any arguments that access context-specific data anymore. PR-URL: https://github.com/nodejs/node/pull/33690 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 13 days

push eventnodejs/node

Evan Lucas

commit sha f6dbba82bd9648d5df3721905fc952c896cb3449

internal: rename error-serdes for consistency All other JavaScript files in lib use snake case, so make this one consistent. PR-URL: https://github.com/nodejs/node/pull/33793 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

push time in 13 days

PR closed nodejs/node

internal: rename error-serdes for consistency build worker

All other JavaScript files in lib use snake case, so make this one consistent.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+5 -5

1 comment

6 changed files

evanlucas

pr closed time in 13 days

delete branch evanlucas/eslint-plugin-sensible

delete branch : fixnested

delete time in 20 days

push eventesatterwhite/eslint-plugin-sensible

Evan Lucas

commit sha 85f97d7368f4eb37df02e1556c78e7b9cb0fd30d

check-require: properly handle nested requires Previously, `require("thing/file.js")` would trigger a lint error. Now, it checks that the package alone is present. Semver: patch

view details

push time in 20 days

PR merged esatterwhite/eslint-plugin-sensible

check-require: properly handle nested requires

Previously, require("thing/file.js") would trigger a lint error. Now, it checks that the package alone is present.

Semver: patch

+14 -0

0 comment

2 changed files

evanlucas

pr closed time in 20 days

PR opened esatterwhite/eslint-plugin-sensible

check-require: properly handle nested requires

Previously, require("thing/file.js") would trigger a lint error. Now, it checks that the package alone is present.

Semver: patch

+14 -0

0 comment

2 changed files

pr created time in 20 days

create barnchevanlucas/eslint-plugin-sensible

branch : fixnested

created branch time in 20 days

push eventevanlucas/eslint-plugin-sensible

Evan Lucas

commit sha a5da17c293b5487180e8deea06da9e4f040f2d22

rules: fix indent of BinaryExpressions This fixes things like ``` var a = 1 + 1 ``` to be ``` var a = 1 + 1 ``` Semver: major

view details

Eric Satterwhite

commit sha 9269329a01a57eaf8e57984caedd397a2c83814d

2.0.0

view details

Eric Satterwhite

commit sha 0b51601554e7d05fc3782fb1343c96c5b680c501

tests: adds better test cases

view details

Evan Lucas

commit sha 54ea66bdbd1bcee801e91ec43d00c89cbec59e24

rules: add check-require eslint rule This rule will verify that any require CallExpressions are either listed in the package.json or a valid file on disk. Semver: minor

view details

Eric Satterwhite

commit sha 31643f5ff8760180084ca1ee67b7580bce1d5069

2.1.0

view details

push time in 20 days

issue openedevanlucas/fish-kubectl-completions

Add support for plugin auto completion

It would be nice if completions worked with kubectl plugins like krew.

created time in 21 days

delete branch evanlucas/eslint-plugin-sensible

delete branch : check-pkg

delete time in a month

push eventesatterwhite/eslint-plugin-sensible

Evan Lucas

commit sha 54ea66bdbd1bcee801e91ec43d00c89cbec59e24

rules: add check-require eslint rule This rule will verify that any require CallExpressions are either listed in the package.json or a valid file on disk. Semver: minor

view details

push time in a month

PR merged esatterwhite/eslint-plugin-sensible

rules: add check-require eslint rule

This rule will verify that any require CallExpressions are either listed in the package.json or a valid file on disk.

Semver: minor

+165 -0

0 comment

2 changed files

evanlucas

pr closed time in a month

PR opened esatterwhite/eslint-plugin-sensible

rules: add check-require eslint rule

This rule will verify that any require CallExpressions are either listed in the package.json or a valid file on disk.

Semver: minor

+165 -0

0 comment

2 changed files

pr created time in a month

create barnchevanlucas/eslint-plugin-sensible

branch : check-pkg

created branch time in a month

PR opened nodejs/node

internal: rename error-serdes for consistency

All other JavaScript files in lib use snake case, so make this one consistent.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+5 -5

0 comment

6 changed files

pr created time in a month

create barnchevanlucas/node

branch : node-consistency

created branch time in a month

push eventevanlucas/node

cjihrig

commit sha 99e57259ecc15cdcd7fc73d454ff93ce36a94bcd

doc: document fs.watchFile() bigint option This commit documents the bigint option to fs.watchFile(), which has been supported since v10.5.0. PR-URL: https://github.com/nodejs/node/pull/32128 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha 3b8d70d924bee5126b1583fc3f1c4a8c70bce53b

src: fix -Winconsistent-missing-override warning ../src/node_http_common.h:497:8: warning: 'MemoryInfo' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void MemoryInfo(MemoryTracker* tracker) const { PR-URL: https://github.com/nodejs/node/pull/32126 Refs: https://github.com/nodejs/node/pull/32069 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

cjihrig

commit sha 7bb4f95c1cdf860082a27e2592488c2ba6734c20

src: fix -Wreorder compiler warning ../src/node_http_common-inl.h:126:7: warning: field 'token_' will be initialized after field 'name_' [-Wreorder] : token_(other.token_), PR-URL: https://github.com/nodejs/node/pull/32126 Refs: https://github.com/nodejs/node/pull/32069 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Gil Tayar

commit sha 9dbe6ab2773372bd04c0626826efd7ed845227a8

doc: document self-referencing a package name Added a section for "Self-referencing a package using its name" that documents importing a package's own exports (this was missed when adding the feature). PR-URL: https://github.com/nodejs/node/pull/31680 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

himself65

commit sha 0a539ddc0ad53c609199465dcb85008811e57bd2

fs: fix valid id range on chown, lchown, fchown PR-URL: https://github.com/nodejs/node/pull/31694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

Juan José Arboleda

commit sha c1e672595f230d7e41ede5a96d778ada1c1e71ac

src: create a getter for kernel version PR-URL: https://github.com/nodejs/node/pull/31732 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

legendecas

commit sha e70705c0f18a9317e33dcdd3189a5cb4c553a4cd

src: add missing namespace using statements in node_watchdog.h Although these `using`s can derived from other header files, it will be better to be self-contained. PR-URL: https://github.com/nodejs/node/pull/32117 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Denys Otrishko

commit sha cee145251eef709d73a88d457d04b029f9feffd3

src: improve KVStore API This adds `const char*` based APIs to KVStore to avoid multiple string conversions (char -> Utf8 -> Local -> char etc.) when possible. PR-URL: https://github.com/nodejs/node/pull/31773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Denys Otrishko

commit sha 98f44296dcf5ba526f1a517effaeb309b10b9ea1

src: simplify node_worker.cc using new KVStore API PR-URL: https://github.com/nodejs/node/pull/31773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Vita Batrla

commit sha 077f9dc6036b97e9e12e3681e3c3bdf29d44de2b

test: allow EAI_FAIL in test-net-dns-error.js Test test-net-dns-error.js causes assertion failure on SunOS, test expects ENOTFOUND, but OS returns EAI_FAIL. Maximum length of a host name is 63 characters. Test test-net-dns-error.js makes a connection attempt to invalid host name (longer than maximum). Such connection attempt on SunOS returns permanent failure (EAI_FAIL) as invalid hostname won't be ever resolved. PR-URL: https://github.com/nodejs/node/pull/31780 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha ef95de3492152290321f1f8a811401146c464138

doc: link setRawMode() from signal docs Fixes: https://github.com/nodejs/node/issues/32065 PR-URL: https://github.com/nodejs/node/pull/32088 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

view details

André Draszik

commit sha d3af52715271920294d244f2e7aea02757899be2

build: allow passing multiple libs to pkg_config Sometimes it's necessary to pass multiple library names to pkg-config, e.g. the brotli shared libraries can be pulled in with pkg-config libbrotlienc libbrotlidec Update the code to handle both, strings (as used so far), and lists of strings. Signed-off-by: André Draszik <git@andred.net> PR-URL: https://github.com/nodejs/node/pull/32046 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

André Draszik

commit sha 616b7fbcb1a7f53ea21f5ee4e3f80c61951c5728

build: allow use of system-installed brotli brotli is available as a shared library since 2016, so it makes sense to allow its use as a system-installed version. Some of the infrastructure was in place already (node.gyp and node.gypi), but some bits in the configure script here were missing. Add them, keeping the default as before, to use the bundled version. Refs: https://github.com/google/brotli/pull/421 Signed-off-by: André Draszik <git@andred.net> PR-URL: https://github.com/nodejs/node/pull/32046 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

ProdipRoy89

commit sha d5a06e73b6b543ba7a0f3ec62878f132aeae48b0

test: changed function to arrow function PR-URL: https://github.com/nodejs/node/pull/32045 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ben Noordhuis

commit sha 8ce6315e8896dd30f5d21caca542b031f33e6b8d

test: use index.js if package.json "main" is empty Verify that the module loader uses index.js when the "main" property of package.json is the empty string. Refs: https://github.com/nodejs/node/issues/32013 PR-URL: https://github.com/nodejs/node/pull/32040 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Harshitha KP

commit sha e9fa5ae3a1198213f8f58d4b97eb6233c05a28b4

src: handle NULL env scenario Convert hard assertion into a throw with a useful error message in src/module_wrap.cc. PR-URL: https://github.com/nodejs/node/pull/31899 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ruben Bridgewater

commit sha 41ac1921920b736f812cc03f6df98ff169d32c07

test: increase test timeout to prevent flakiness This increases the waiting time for each event from 500 to 750 ms. The former timeout could be hit on very slow machines with high load. PR-URL: https://github.com/nodejs/node/pull/31716 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 2a7d66200b53f645b4f7e412ed080f249e2e667e

doc: revise tools/icu/README.md * Simplify introductory sentence. * Remove some passive voice. * Make style in bulleted list a little more consistent. * Remove superfluous list entry. PR-URL: https://github.com/nodejs/node/pull/32136 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Stephen Belanger

commit sha d368dcc63af2eb75d5dbef5c6669e5e8ab3be5d2

async_hooks: add sync enterWith to ALS This allows transitioning the entire following sync and async execution sub-tree to the given async storage context. With this one can be sure the context binding will remain for any following sync activity and all descending async execution whereas the `run*(...)` methods must wrap everything that is intended to exist within the context. This is helpful for scenarios such as prepending a `'connection'` event to an http server which binds everything that occurs within each request to the given context. This is helpful for APMs to minimize the need for patching and especially adding closures. PR-URL: https://github.com/nodejs/node/pull/31945 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gabriel Schulhof

commit sha c0c81ed204b08c264f235234ab35a490f6d147ea

n-api: define release 6 Mark all N-APIs that have been added since version 5 as stable. PR-URL: https://github.com/nodejs/node/pull/32058 Fixes: https://github.com/nodejs/abi-stable-node/issues/393 Co-Authored-By: legendecas <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

push time in a month

delete branch evanlucas/eslint-plugin-sensible

delete branch : fix-2

delete time in a month

PR opened esatterwhite/eslint-plugin-sensible

rules: fix indent of BinaryExpressions

This fixes things like

var a = 1
+ 1

to be

var a = 1
  + 1

Semver: major

+7 -13

0 comment

2 changed files

pr created time in a month

push eventevanlucas/eslint-plugin-sensible

Evan Lucas

commit sha dde11be078555b42d29ce21842cecec1b66e6695

rules: fix indent of BinaryExpressions This fixes things like ``` var a = 1 + 1 ``` to be ``` var a = 1 + 1 ``` Semver: major

view details

push time in a month

create barnchevanlucas/eslint-plugin-sensible

branch : fix-2

created branch time in a month

fork evanlucas/eslint-plugin-sensible

Better comma first indent rules for eslint

fork in a month

create barnchevanlucas/docker-login-action

branch : master

created branch time in a month

created repositoryevanlucas/docker-login-action

created time in a month

push eventevanlucas/fish-kubectl-completions

Evan Lucas

commit sha 7bea3e12ff2147961e808b9308b79828aa17b222

main,completions: bump to k8s 1.18.3 and improve speed of completions Previously, we were calling "kubectl get <resource> -o name" and it ended up being about 5 times slower than "kubectl get <resource> --no-headers | awk '{print $1}'".

view details

push time in a month

created tagevanlucas/lintit

tagv8.1.0

created time in 2 months

push eventevanlucas/lintit

Evan Lucas

commit sha 77c115f6497d9e5139d9dd0c8f67d6090cab36d6

rules: fix comma-style for ObjectPattern

view details

Evan Lucas

commit sha 9954a3ec19a4303af1c4a7db47a89fdf967ba21f

8.1.0

view details

push time in 2 months

created tagevanlucas/lintit

tagv8.0.0

created time in 2 months

push eventevanlucas/lintit

Evan Lucas

commit sha 87889d648e80b1ecd60bfe9976990258a9cc2748

bump deps and switch to comma last

view details

Evan Lucas

commit sha e4dc13ae5edc1f73a1f464c00fa87350ed27199a

8.0.0

view details

push time in 2 months

fork evanlucas/build-ast

Makes building AST nodes for code generation easier

fork in 3 months

more